Re: version-0.7201 patch

2007-04-17 Thread Johan Vromans
Adam Kennedy <[EMAIL PROTECTED]> writes: > Plus I imagine on case-insensitive filesystem (I'm looking at Win32) > here, I'm about 80% certain we'll see some disaster or another > occuring. Rename it to Data::Version would be a trivial solution, and a much better name IMHO. It provides version obj

Re: new stringification behavior in version-0.7201

2007-04-17 Thread Eric Wilhelm
# from John Peacock # on Sunday 15 April 2007 11:28 am: > I had to tweak a couple of tests that expected a leading >'v' (which the old code would prepend). It wasn't just the tests that expected to see a v there. I have a lot of code that depends on it. I just svn up'd and now my builds get a

Re: version-0.7201 patch

2007-04-17 Thread Eric Wilhelm
# from John Peacock # on Sunday 15 April 2007 11:28 am: >Attached, please find the patch to bring Module::Build into > compliance. Also very odd is that I can't use the CPAN version.pm in conjunction with this patch. I get a segfault as soon as it tries to stringify. The version.pm tests are s

Re: version-0.7201 patch

2007-04-17 Thread John Peacock
Eric Wilhelm wrote: Also very odd is that I can't use the CPAN version.pm in conjunction with this patch. I get a segfault as soon as it tries to stringify. What do you have installed and what are you testing? i.e. did you install version-0.7201 and you are now testing Module::Build? Or you

Re: version-0.7201 patch

2007-04-17 Thread Eric Wilhelm
# from John Peacock # on Tuesday 17 April 2007 11:55 am: >What do you have installed and what are you testing?  i.e. did you >install version-0.7201 and you are now testing Module::Build?  Or you >don't have version installed at all (which is the only way to > correctly test the embedded code). I

Re: version-0.7201 patch

2007-04-17 Thread John Peacock
Eric Wilhelm wrote: I can test either way. Presently, I'm at r9425 in the M::B svn with a version-0.7201 tarball and -I switches. The segfault seems to come from stringifying a MB::Version which was created from a real version.pm object: I've got /that/ problem figured out: when copying the

Re: version-0.7201 patch

2007-04-17 Thread John Peacock
Ken Williams wrote: > > Thanks, applied. I'm really sorry, but the problems Eric Wilhelm noted required me to release 0.7203 (0.7202 was a misfire). The small patch attached needs to go on top of the one you already applied. John -- John Peacock Director of Information Research and Technology

Re: version-0.7201 patch

2007-04-17 Thread Eric Wilhelm
# from John Peacock # on Tuesday 17 April 2007 06:58 pm: >I'm really sorry, but the problems Eric Wilhelm noted required me to > release 0.7203 (0.7202 was a misfire).  The small patch attached > needs to go on top of the one you already applied. Thanks. That's applied. I'm wondering if there's

Re: Adding configure_requires to META.yml

2007-04-17 Thread Eric Wilhelm
# from Adam Kennedy # on Sunday 18 March 2007 04:28 am: >> Also - what happens if a user has an old CPAN, an old M::B, and >> downloads a META.yml containing a configure_requires entry? >>  Presumably that entry would be ignored and the user would miss the >> dependency altogether. >There is no g