Re: version-0.7201 patch

2007-04-17 Thread Eric Wilhelm
# from John Peacock # on Sunday 15 April 2007 11:28 am: Attached, please find the patch to bring Module::Build into compliance. Also very odd is that I can't use the CPAN version.pm in conjunction with this patch. I get a segfault as soon as it tries to stringify. The version.pm tests are

Re: version-0.7201 patch

2007-04-17 Thread John Peacock
Eric Wilhelm wrote: Also very odd is that I can't use the CPAN version.pm in conjunction with this patch. I get a segfault as soon as it tries to stringify. What do you have installed and what are you testing? i.e. did you install version-0.7201 and you are now testing Module::Build? Or

Re: version-0.7201 patch

2007-04-17 Thread Eric Wilhelm
# from John Peacock # on Tuesday 17 April 2007 11:55 am: What do you have installed and what are you testing?  i.e. did you install version-0.7201 and you are now testing Module::Build?  Or you don't have version installed at all (which is the only way to correctly test the embedded code). I

Re: version-0.7201 patch

2007-04-17 Thread John Peacock
Ken Williams wrote: Thanks, applied. I'm really sorry, but the problems Eric Wilhelm noted required me to release 0.7203 (0.7202 was a misfire). The small patch attached needs to go on top of the one you already applied. John -- John Peacock Director of Information Research and Technology

Re: version-0.7201 patch

2007-04-17 Thread Eric Wilhelm
# from John Peacock # on Tuesday 17 April 2007 06:58 pm: I'm really sorry, but the problems Eric Wilhelm noted required me to release 0.7203 (0.7202 was a misfire).  The small patch attached needs to go on top of the one you already applied. Thanks. That's applied. I'm wondering if there's a

Re: version-0.7201 patch

2007-04-16 Thread John Peacock
Randy W. Sims wrote: I don't believe the current version objects support mathematical operations, but it seems something very reasonable to add. (At least, the addition of increment($step)/decrement($step) type ops.) I'm fairly adamant that version.pm is feature-complete; I don't want to add

Re: version-0.7201 patch

2007-04-16 Thread Johan Vromans
John Peacock [EMAIL PROTECTED] writes: I'm fairly adamant that version.pm is feature-complete; I don't want to add *anything* else to the base class. I am planning on releasing version::Math which will cover what you discuss, though. I have been playing with it for a couple of years, on a

Re: version-0.7201 patch

2007-04-16 Thread demerphq
On 4/16/07, Johan Vromans [EMAIL PROTECTED] wrote: John Peacock [EMAIL PROTECTED] writes: Especially now since you mention version::Math, an ordinary module in a pragma's namespace? Original issue aside, I think there is an assumption that we can add new functionality that is pragma related

Re: version-0.7201 patch

2007-04-16 Thread John Peacock
Johan Vromans wrote: Sorry to bring this up (again) but I am still wondering why version is a pragma instead of a module. The original goal was to make the simple act of writing: $VERSION = 1.2.0; create a version object. It turns out I can do that in bleadperl (since I have

Re: version-0.7201 patch

2007-04-16 Thread John Peacock
Johan Vromans wrote: I'd say this is the VERY LAST CHANCE to change it. Once released as a core module with 5.10 there is no way back. I'd say that boat has already pulled out of the dock and is rapidly making its way through the North Atlantic! Damian's Perl Best Practices recommends 'use

Re: version-0.7201 patch

2007-04-16 Thread Johan Vromans
John Peacock [EMAIL PROTECTED] writes: Damian's Perl Best Practices recommends 'use version' in print (since July 2005), so I don't think we /can/ change it now... Damian recommends truck loads of CPAN modules. But that doesn't necessarily mean that it has to be put in the core that way. --

version-0.7201 patch

2007-04-15 Thread John Peacock
Based on a discussion started on p5p, I have revised the version object code to always return the initializer string as the stringified version (much like I was already doing for Module::Build::Version). Thus what you put in is what you get out; the sole exception is that the use of qv(1.2)