Re: [Musicpd-dev-team] Pulse mixer

2009-01-13 Thread Linel Patrice
Max Kellermann wrote: Hello Linel, Hi I happened to notice that you already pushed code to your public git repository. I cannot merge this right now, because Viliam has changed the mixer API meanwhile. Yes, I saw this, I'm a little busy this week but I already started to make the changes

Re: [Musicpd-dev-team] Pulse mixer

2009-01-13 Thread Max Kellermann
On 2009/01/13 10:29, Linel Patrice patnathan...@gmail.com wrote: The pa_threaded_mainloop control the mainloop of pulseaudio. So if the pulse output is not used, there are no reasons to introduce overhead. We didn't need the main loop stuff before your patch. I don't know the pulse API,

Re: [Musicpd-dev-team] Pulse mixer

2009-01-13 Thread Linel Patrice
Max Kellermann wrote: On 2009/01/13 10:29, Linel Patrice patnathan...@gmail.com wrote: The pa_threaded_mainloop control the mainloop of pulseaudio. So if the pulse output is not used, there are no reasons to introduce overhead. We didn't need the main loop stuff before your patch. I don't

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-13 Thread Max Kellermann
On 2009/01/10 23:57, Vasily Stepanov vasily.stepa...@gmail.com wrote: Currently I'm working on MPD visualization stuff. Hi Vasily, here's a rough review of the udpfeed plugin (commit f0fd78a911d6). First: I like your coding style, you're using inline functions a lot. You're writing a lot of

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-13 Thread Vasily Stepanov
On Tue, Jan 13, 2009 at 10:24 PM, Max Kellermann m...@duempel.org wrote: On 2009/01/10 23:57, Vasily Stepanov vasily.stepa...@gmail.com wrote: Currently I'm working on MPD visualization stuff. Hi Vasily, here's a rough review of the udpfeed plugin (commit f0fd78a911d6). First: I like

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-13 Thread Max Kellermann
On 2009/01/14 03:37, Vasily Stepanov vasily.stepa...@gmail.com wrote: Great :) About CamelCase... do you have any code formatting standards? May be in your wiki... I didn't found them, so of course I was trying to copypaste existing functions names and variables. No, we don't have it