Re: [Musicpd-dev-team] Connection issues with master

2013-01-28 Thread Denis Krjuchkov
27.01.2013 23:30, Max Kellermann пишет: According to quick searches on the net, neither libevent nor libev seems to work well with Bionic (Android's libc). However, for Android, we could simply roll our own event loop. That's not too hard, and the scalability of libevent/libev is not

Re: [Musicpd-dev-team] Connection issues with master

2013-01-28 Thread zw g
It would be great if MPD on Windows can have the auto update feature. That is one of the most desired feature i need for Windows platform. As a user, I'm very glad to see that MPD's development now is active again. Thank you guys. Gui On Tue, Jan 29, 2013 at 1:33 AM, Denis Krjuchkov

Re: [Musicpd-dev-team] Connection issues with master

2013-01-27 Thread Max Kellermann
On 2013/01/27 08:56, Denis Krjuchkov de...@crazydev.net wrote: I've made improvements to the code and documentation. Also there is one more patch. Please take a look. I've merged the first two. I stopped at the MPD_PATH_MAX_UTF8 definition because I could not see an explanation for the value.

Re: [Musicpd-dev-team] Connection issues with master

2013-01-27 Thread Denis Krjuchkov
27.01.2013 22:18, Max Kellermann пишет: I've merged the first two. I stopped at the MPD_PATH_MAX_UTF8 definition because I could not see an explanation for the value. What is this worst case that requires 4*MPD_PATH_MAX? UTF-8 requires at most 4 bytes for single character. So if there is

Re: [Musicpd-dev-team] Connection issues with master

2013-01-27 Thread Max Kellermann
On 2013/01/27 17:38, Denis Krjuchkov de...@crazydev.net wrote: 27.01.2013 22:18, Max Kellermann ??: I've merged the first two. I stopped at the MPD_PATH_MAX_UTF8 definition because I could not see an explanation for the value. What is this worst case that requires 4*MPD_PATH_MAX?

Re: [Musicpd-dev-team] Connection issues with master

2013-01-27 Thread Denis Krjuchkov
27.01.2013 22:47, Max Kellermann пишет: You have described that a character may be represented by 4 bytes, but that does not really answer my question. That upper limit would apply if a string holding MPD_PATH_MAX 4-byte characters must be represented. OK. Let me explain with more details.

Re: [Musicpd-dev-team] Connection issues with master

2013-01-27 Thread Denis Krjuchkov
I'll rework my patch and move this definition to Path.cxx with comment. I've pushed updated (and rebased) version. -- Denis -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8

Re: [Musicpd-dev-team] Connection issues with master

2013-01-26 Thread Denis Krjuchkov
26.01.2013 15:26, Max Kellermann пишет: Can we somehow convert the integer file handle to a WIN32 HANDLE for use in GPollFD? Yes, it's possible. In theory things look simple: create event object with CreateEvent() or WSACreateEvent(), associate event with socket via WSAEventSelect(). This

Re: [Musicpd-dev-team] Connection issues with master

2013-01-26 Thread Jonathan Neuschäfer
On Sat, Jan 26, 2013 at 10:26:00AM +0100, Max Kellermann wrote: There are still a few missing pieces before we can replace the GMainLoop completely. See src/output/HttpdClient.cxx. What is a replacement that runs on Linux (POSIX), Windows and Android? Or shall we just roll our own?

Re: [Musicpd-dev-team] Connection issues with master

2013-01-26 Thread Denis Krjuchkov
26.01.2013 6:17, Max Kellermann пишет: Path: ToUTF() returns std::string removes the ability for the caller to check for errors. Maybe checking for an empty string might work, as paths may be expected to be non-empty, however you removed documentation on this. This should be a

Re: [Musicpd-dev-team] Connection issues with master

2013-01-25 Thread Max Kellermann
On 2013/01/24 21:38, Denis Krjuchkov de...@crazydev.net wrote: I've prepared few more patches with Path class migration. Path: ToUTF() returns std::string removes the ability for the caller to check for errors. Maybe checking for an empty string might work, as paths may be expected to be