Re: [nant-dev] Core tests excludes ?

2003-02-25 Thread Ian MacLean
Gert Driesen wrote: Is there any reason why the following testers are being excluded : GetTaskTest.cs MailTaskTest.cs I think these were taking a long time to execute > TouchTaskTest.cs AllTests.cs (dunno what this last one is) I'm not sure what this one is either. Ok, they're probably being e

[nant-dev] Patch for CL task...

2003-02-25 Thread Tony Boggis
I'm submitting this task for review. I found the problem with the CL task not correctly parsing the . Simple really. It should have been looking at Includes.Includes instead of Includes.Filenames. There's a few other changes in the file, most of which are not necessary, but I felt made usin

RE: [nant-dev] Problem with CL task and Filesets...

2003-02-25 Thread Tony B.
Well, after getting the GUI .NET debugger to work I worked out what was happening. It was "sort of" working. The directories do get added to the Fileset, but under the "Fileset.Includes" collection. Changing the part of ClTask.cs that does the includes to reference "Fileset.Includes" instead of "

[nant-dev] (no subject)

2003-02-25 Thread mctwo
I'm certainly not saying drop NUnit 2.0 support in favor of 2.1 support. I'm still asking what those short commings in the runner where. I haven't seen anything on the nunit mailing list, at least not for quite some time. We can't fix it if you won't tell us what the issues are. I'm not getting

Re: [nant-dev] Bug fix for DirectoryScanner

2003-02-25 Thread Ian MacLean
Brian Deacon wrote: So attached is the patch. Let me know if the tortoise fails to satisfy… first time using it…. Patch is fine. btw with tortoise you can select multiple files before creating a patch and it will put all the changes in a single file. Hmmm… on second thought, I’m attaching the

Re: [nant-dev] Problem with CL task and Filesets...

2003-02-25 Thread Ian MacLean
Tony, The directories do get added to the Fileset, but under the "Fileset.Includes" collection. Changing the part of ClTask.cs that does the includes to reference "Fileset.Includes" instead of "Fileset.FileNames" fixes that issue. However, is it the correct, long term fix? Based on what you've st

[nant-dev] Core tests excludes ?

2003-02-25 Thread Gert Driesen
Hi,   Is there any reason why the following testers are being excluded :   GetTaskTest.cs MailTaskTest.cs TouchTaskTest.cs AllTests.cs (dunno what this last one is)   Ok, they're probably being excludes because they give build (or test) errors, but are we going to fix these issues or are thes

RE: [nant-dev] Problem with CL task and Filesets...

2003-02-25 Thread Brian Deacon
My hunting around DirectoryScanner left me with a nervous tick about the same issue... mostly because the code is a bit mungy trying to do both things at the same time... Ant does have the distinction 'tween DirSet and FileSet... and I'm starting to see why... Brian -Original Message- Fr

Re: [nant-dev] Nant test-build broken?

2003-02-25 Thread Tomas Restrepo
HI Ian, > I just backed out your change to NAntTest.cs and it builds and tests for > me. I'm going to commit this so that people can build. Great, thank you :) I was just able to run all tests, and committed the NUnit2 patch for the current directory thingy. -- Tomas Restrepo [EMAIL PROTECTED]

Re: [nant-dev] Problem with CL task and Filesets...

2003-02-25 Thread Ian MacLean
I just had a thought. The change I made means that the following includes statement : will include both files and directories which might break somthing that is only expecting to get files passed to it. we could add filesonly and directoriesdonly attributes on the fileset to prevent this. Or

Re: [nant-dev] Nant test-build broken?

2003-02-25 Thread Ian MacLean
I just backed out your change to NAntTest.cs and it builds and tests for me. I'm going to commit this so that people can build. Ian Yes, me too. I think it has something to do with changes I made to the nanttask. It seems to happen on the self-doc target. It is recursive. I've been thinking abou

Re: [nant-dev] Problem with CL task and Filesets...

2003-02-25 Thread Ian MacLean
Tony, the includedirs fileset wasn't working. The fileset scanning code was only supporting files. ie it wasn't even trying to add directories that matched the includes spec. Its working now. I haven't tried running NAnt against Cordbg. What problems are you having ? Is NAnt being built with d

Re: [nant-dev] Nant test-build broken?

2003-02-25 Thread Scott Hernandez
Yes, me too. I think it has something to do with changes I made to the nanttask. It seems to happen on the self-doc target. It is recursive. I've been thinking about adding a check to make sure that recursive (depth > 5) buildfiles fail by default. This would stop someone from accidentally creating

Re: [nant-dev] Nant test-build broken?

2003-02-25 Thread Ian MacLean
I just did a sync and I'm getting the same thing. The nightly build seemed to run OK - there have been a bunch of cultureInfo related changes since then - maybe somthing to do with that. Ian Hi Guys, OK, is it just me, or is NAnt's build/test broken? During build on my machine, when the unit

[nant-dev] Nant test-build broken?

2003-02-25 Thread Tomas Restrepo
Hi Guys, OK, is it just me, or is NAnt's build/test broken? During build on my machine, when the unit tests get running, NAnt seems stuck in an infinite loop spanning instances of NAnt.exe :( -- Tomas Restrepo [EMAIL PROTECTED] --- This

[nant-dev] Support for Multimple Testing Frameworks (Using NUnitAddin TestRunner)

2003-02-25 Thread Jamie Cansdale
Hi folks, I've been working on another SourceForge project that has needed to interface to multiple versions of NUnit. Recently I have introduced a pluggable testing framework. At the moment is supports NUnit (tested with 2.0.6.0 and 2.0.9.001), JUnit and AdHoc tests. It probably already works

[nant-dev] Problem with CL task and Filesets...

2003-02-25 Thread Tony Boggis
Does the ... fileset work? Since I am invoking Nant from the command line, it will inherit the current environment. In order to ensure that regardless of a users local workstation environment, my build works, I use the ... fileset to specify the project's include directories as follows:

RE: [nant-dev] Patch for NullReferenceException error

2003-02-25 Thread John Barstow
If you don't explicitly specify the culture, it gets picked up from the current thread. This can be a very bad thing - number and date formats get completely screwed up, the default code page changes, and collation (sorting) and uppercase/lowercase rules change. Try setting your system locale to A

RE: [nant-dev] contribution to project

2003-02-25 Thread Jeff McManus
Command-line purists might argue, but I think an NAnt GUI is a great idea; I've had several people ask if something like this exists as I've been evangelizing NAnt in the past few months. One thought (possibly premature since I haven't actually seen Philip's contribution yet): If the community app

Re: [nant-dev] NUnit2.1

2003-02-25 Thread Tomas Restrepo
Hi Mike, <> Quick question here: Are you proposing wew dump NUnit 2.0 support in favor of 2.1, or keep them both? Unless we deal with this correctly, it could become a mess Notice: I haven't taken a look at the new version yet. I certainly hope several of the runner shortcomings have been fi

Re: [nant-dev] Behavioral differences between NUnit V2.0.6 and th e task

2003-02-25 Thread Tomas Restrepo
Mike, << That will allow it to find the assemblies, but it still does not help tests that use relative paths in their code. Could be I'm missing something. >> This was discussed quite a bit of time ago here. I was the one to argue that NUnit2's behavior is dangereous, in the sense that using relat

Re: [nant-dev] Patch for NullReferenceException error

2003-02-25 Thread Ian MacLean
hmm well the only doc on that I could find is at http://www.gotdotnet.com/team/libraries/FxCopRules/GlobalizationRules.aspx which didn't really convince me that its necessary. Are there issues with the way it is now on on other cultures ? If it does become necessary then I'd prefer to do it every

Re: Re: [nant-dev] Patch for NullReferenceException error

2003-02-25 Thread [EMAIL PROTECTED]
Hi Ian, It's just a good programming practice to always specify the culture (FxCop considers it to be a rule violation when you don't specify the cultureinfo) Gert Ian MacLean <[EMAIL PROTECTED]> wrote: >Gert, >I've applied this with s

Re: [nant-dev] Add property for retrieving program files location?

2003-02-25 Thread Ian MacLean
I've added this plus a number of other special folders to sysinfo. Ian Hi Scott, Can you submit this (very simple) patch ? Thanks, Gert - Original Message - *From:* Scott Hernandez *To:* Gert Driesen ; [EMAIL PROT

Re: [nant-dev] Patch for NullReferenceException error

2003-02-25 Thread Ian MacLean
Gert, I've applied this with some changes. I'm not sure what was behind your use of the CultureInfo.InvariantCulture constant so I pulled it out. Can you please explain what it was supposed to be doing ? Ian Hi, I noticed that you get a NullReferenceException when you try to read the value of

RE: [nant-dev] Behavioral differences between NUnit V2.0.6 and the task

2003-02-25 Thread Arnoldus, Michael
I couldn't agree more. We have had a discussion about this and as far as I remember Tomas Restrepo said the change is only a few lines, which he said he would do - don't know if he's done it though ...   Enjoy,       Michael Arnoldus -Original Message-From: [EMAIL PROTECTED] [ma