On 16/04/2012 22:18, Kurchi Hazra wrote:
Hi,
Thanks for the reviews. Here is an updated webrev:
http://cr.openjdk.java.net/~khazra/7152856/webrev.01
Looks okay to me. I guess is and os could be locals but it's a minor
comment (and no need to generate another webrev if you decide to move
On 16/04/12 22:18, Kurchi Hazra wrote:
Hi,
Thanks for the reviews. Here is an updated webrev:
http://cr.openjdk.java.net/~khazra/7152856/webrev.01
The updated webrev looks ok, but the canned HTTP response looks funny.
Each HTTP header must be followed by a CRLF ( '\r\n' ), and the end of
Thanks Chris. Right, RFC itself contains the statements that can lead to
ambiguity and including examples from different sections of RFC w/o a
proper context doesn't help with understanding what the method should do
and what shouldn't. I'll go ahead and push the fix.
thanks,
dmeetry
On
ship it!
-Chris.
On 17/04/12 19:27, Kurchi Hazra wrote:
Updated webrev:
http://cr.openjdk.java.net/~khazra/7152856/webrev.02/
Alan: On second thoughts, both is and os were not required at all. I
removed them.
- Kurchi
On 4/17/2012 8:47 AM, Kurchi Subhra Hazra wrote:
I think the HTTP spec
Hi,
In Windows Vista and later, InterfaceAddress.getBroadcast() returns
0.0.0.0 , since these platforms return IF_TYPE_IEEE80211 instead of
MIB_IF_TYPE_ETHERNET for wireless interface type now. The fix is to
handle IF_TYPE_IEEE80211 in the relevant switch
statement. While doing this, I also
On 17/04/12 19:47, Kurchi Hazra wrote:
Hi,
In Windows Vista and later, InterfaceAddress.getBroadcast() returns
0.0.0.0 , since these platforms return IF_TYPE_IEEE80211 instead of
MIB_IF_TYPE_ETHERNET for wireless interface type now. The fix is to
handle IF_TYPE_IEEE80211 in the relevant switch
Changeset: 1757f049e8c0
Author:khazra
Date: 2012-04-17 12:21 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1757f049e8c0
7157893: Warnings Cleanup in java.util.*
Summary: Minor code changes to cleanup warnings in java.util.*
Reviewed-by: mduigou, naoto, smarks
On 17/04/12 20:14, Alan Bateman wrote:
On 17/04/2012 19:47, Kurchi Hazra wrote:
Hi,
In Windows Vista and later, InterfaceAddress.getBroadcast() returns
0.0.0.0 , since these platforms return IF_TYPE_IEEE80211 instead of
MIB_IF_TYPE_ETHERNET for wireless interface type now. The fix is to
handle
Updated webrev: http://cr.openjdk.java.net/~khazra/7158636/webrev.01/
Windows has a more secure version of snprintf and I used that:
http://msdn.microsoft.com/en-us/library/f30dzcf6%28v=vs.110%29.aspx
Thanks,
Kurchi
On 4/17/2012 12:24 PM, Chris Hegarty wrote:
On 17/04/12 20:14, Alan
