Re: Indenting code?

2012-09-13 Thread Weijun Wang
On 09/14/2012 08:21 AM, Brad Wetmore wrote: Netbean's automatic formatting does a pretty good job with new code. That's Alt-Shift-F, which I rarely dare to press, because it change existing codes. In fact, NetBeans is doing very smart indentation while you are coding, at least it adheres

Re: Indenting code?

2012-09-13 Thread Brad Wetmore
Netbean's automatic formatting does a pretty good job with new code. However, I think the general advice is to not change existing code just because. When you're dealing with multiple release families, it makes the merges much more difficult. Brad On 9/13/2012 6:18 AM, John Zavgren wrote:

hg: jdk8/tl/langtools: 7177970: fix issues in langtools doc comments

2012-09-13 Thread jonathan . gibbons
Changeset: 30c36e23f154 Author:jjg Date: 2012-09-13 14:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/30c36e23f154 7177970: fix issues in langtools doc comments Reviewed-by: mcimadamore ! src/share/classes/com/sun/javadoc/Doc.java ! src/share/classes/com/sun/javadoc

hg: jdk8/tl/jdk: 7197637: (ch) sun.nio.ch.Default* cause providers for other platforms to be included in rt.jar

2012-09-13 Thread alan . bateman
Changeset: e8a3807de977 Author:alanb Date: 2012-09-13 15:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8a3807de977 7197637: (ch) sun.nio.ch.Default* cause providers for other platforms to be included in rt.jar Reviewed-by: mchung ! src/solaris/classes/sun/nio/ch/Defaul

Indenting code?

2012-09-13 Thread John Zavgren
Greetings: I have a simple question about how to enforce code styles for: java, c, and c++. I know there are style guides that legislate the indentation, "curly brace and parenthesis management", etc. I'm looking for a simple automatic way to transform any source code file so that it's image

hg: jdk8/tl/jdk: 7197203: sun/misc/URLClassPath/ClassnameCharTest.sh failed, compile error

2012-09-13 Thread chris . hegarty
Changeset: e095be3820ee Author:chegar Date: 2012-09-13 11:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e095be3820ee 7197203: sun/misc/URLClassPath/ClassnameCharTest.sh failed, compile error Reviewed-by: alanb ! test/sun/misc/URLClassPath/ClassnameCharTest.java - test/su

Re: Code review request: 7198205: CloseTest fails on mac

2012-09-13 Thread Weijun Wang
On 09/13/2012 04:46 PM, Alan Bateman wrote: On 13/09/2012 09:41, Weijun Wang wrote: : It was added thru http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9de97594f062 At first I thought this is the reason and the machine does shows an environment variable http_proxy. However, I unset it and not

Re: Code review request: 7198205: CloseTest fails on mac

2012-09-13 Thread Alan Bateman
On 13/09/2012 09:41, Weijun Wang wrote: : It was added thru http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9de97594f062 At first I thought this is the reason and the machine does shows an environment variable http_proxy. However, I unset it and nothing changed. After some println it seems the

Re: Code review request: 7198205: CloseTest fails on mac

2012-09-13 Thread Weijun Wang
On 09/13/2012 04:20 PM, Alan Bateman wrote: On 13/09/2012 09:10, Weijun Wang wrote: http://cr.openjdk.java.net/~weijun/7198205/webrev.00/ The test hangs on this line loadClass ("java.awt.Button", loader, true); It looks like no AWT class can be loaded in the testing environment. The fix

Re: Code review request: 7198205: CloseTest fails on mac

2012-09-13 Thread Alan Bateman
On 13/09/2012 09:10, Weijun Wang wrote: http://cr.openjdk.java.net/~weijun/7198205/webrev.00/ The test hangs on this line loadClass ("java.awt.Button", loader, true); It looks like no AWT class can be loaded in the testing environment. The fix uses "java.sql.Array" instead. I guess it shou

Code review request: 7198205: CloseTest fails on mac

2012-09-13 Thread Weijun Wang
http://cr.openjdk.java.net/~weijun/7198205/webrev.00/ The test hangs on this line loadClass ("java.awt.Button", loader, true); It looks like no AWT class can be loaded in the testing environment. The fix uses "java.sql.Array" instead. I guess it should be a class inside JRE but also not lo