Changeset: 38d3d1027f5a
Author:mcimadamore
Date: 2013-01-08 10:15 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/38d3d1027f5a
8005243: Restructure method check code to allow pluggable checkers
Summary: Add interface to perform a method check - to be implemented by
Changeset: 954541f13717
Author:vromero
Date: 2013-01-08 13:47 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/954541f13717
8005167: execution time of combo tests in javac should be improved
Reviewed-by: jjg, jjh
! test/tools/javac/Diagnostics/6769027/T6769027.java
!
Changeset: d29a7ce28189
Author:dxu
Date: 2013-01-08 20:37 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d29a7ce28189
8002306: (se) Selector.open fails if invoked with thread interrupt status set
[win]
Reviewed-by: alanb
! src/windows/classes/sun/nio/ch/PipeImpl.java
+
Changeset: 46e6a4b7ca26
Author:valeriep
Date: 2013-01-07 11:11 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46e6a4b7ca26
6996769: support AEAD cipher
Summary: Added implementation for GCM mode under AES cipher
Reviewed-by: weijun
!
On 12/28/2012 10:49 AM, John Zavgren wrote:
Please consider the following webrev for JDK-8005120.
http://cr.openjdk.java.net/~mullan/webrevs/jzavgren/8005120/webrev.06/
(I apologize for overlooking an error in the windows code that I created in my
previous release. )
Thanks!
John Zavgren
Changeset: ac5fd681a7a2
Author:darcy
Date: 2013-01-08 16:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac5fd681a7a2
8005298: Add FunctionalInterface type to the core libraries
Reviewed-by: mduigou
+ src/share/classes/java/lang/FunctionalInterface.java
Hi,
According to RFC 3986[1], hexadecimal digits encoded by a '%'
should be case-insensitive, for example,%A2 and %a2 should be
considered equal. Although, URI.equals() does take this into
consideration, the implementation of URI.hashCode() does not and
returns different hashcodes for two
Hi Kurchi,
I had a couple quick comments:
On line 1756, you might want to allocate the StringBuilder normalizedS
= new StringBuilder(s.length()); to avoid resizing during the
appending.
On line 1754 and 1759, is it worth restructuring the logic to avoid
performing indexOf twice to find the
Hi Kurchi,
In the hash method, I suggest you move handling of strings with % into a
separate method to keep the hash method small for common case (no %).
Otherwise, there's a chance this method won't get inlined anymore due to
its (newly increased) size.
Also, I realize toLower does the same
Also, I'm not sure how hot this method is in practice but allocating
StringBuilder seems a bit heavy (maybe it gets partially escape analyzed
out though). Can you instead loop over all the chars in the string and
build up the hash code as you go along? If you see a % then you handle next
2 chars
Thanks a lot for your comments David.
On 1/8/13 6:39 PM, David Schlosnagle wrote:
Hi Kurchi,
I had a couple quick comments:
On line 1756, you might want to allocate the StringBuilder normalizedS
= new StringBuilder(s.length()); to avoid resizing during the
appending.
- I am now wondering if
On Tue, Jan 8, 2013 at 10:57 PM, Kurchi Subhra Hazra
kurchi.subhra.ha...@oracle.com wrote:
On 1/8/13 6:39 PM, David Schlosnagle wrote:
Hi Kurchi,
I had a couple quick comments:
On line 1756, you might want to allocate the StringBuilder normalizedS
= new StringBuilder(s.length()); to avoid
On 1/8/13 6:55 PM, Vitaly Davidovich wrote:
Also, I'm not sure how hot this method is in practice but allocating
StringBuilder seems a bit heavy (maybe it gets partially escape
analyzed out though). Can you instead loop over all the chars in the
string and build up the hash code as you go
Yes, I also thought about range checks not being eliminated if using
charAt() but I guess that depends on how smart the JIT is - if charAt is
inlined there's technically enough info there for the compiler to see that
range checks aren't needed. Whether that happens or not I haven't
checked.
14 matches
Mail list logo
