Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2015-10-27 Thread Mark Sheppard
Hi Max, thanks for the reply. I'll change the hosts file names used to correspond with an associated test dynamic update of host / ip mappings updates are accommodated as seen per the tests http://cr.openjdk.java.net/~msheppar/8134577/webrev/test/sun/net/InetAddress/nameservice/simple/Defa

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2015-10-27 Thread Mark Sheppard
thanks Alan, I'll double check the illegal state token recognition. There was a security test that used this. property name of "jdk.net.hosts.file" is fine. we can remove the code for reading the service provider property sun.net.spi.nameservice.provider. and ignore its setting if we think t

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2015-10-27 Thread Alan Bateman
On 25/10/2015 23:32, Mark Sheppard wrote: Hi, please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8134577/webrev/ which address the issue raised in https://bugs.openjdk.java.net/browse/JDK-8134577 the operative word has been "eliminate". This has been a very t

RFR: 5108778 Too many instances of java.lang.Boolean created in Java application(net)

2015-10-27 Thread Sebastian Sickelmann
Hello, Actually I am searching through the JBS for low hanging fruits. Right now i am looking through the openjdk-sources and try to evaluate if i can make something about JDK-5108778. Please find my webrevs for the jdk(net) repos at: http://cr.openjdk.java.net/~sebastian/5108778/net/webrev.00/

RFR: JDK-8022748 (new URI(u.toString()).equals(u), does not hold with paths containing colons

2015-10-27 Thread Sebastian Sickelmann
Hi, i investigated the problem described in JDK-8022748[1] i found that the parser needed to be rescued for confusion while handling relative URIs. A URI created through the relativize-method is schemaless and so it need to handle the special-case (a colon in the path-element). While there is als

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2015-10-27 Thread David M. Lloyd
Hi, please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8134577/webrev/ which address the issue raised in https://bugs.openjdk.java.net/browse/JDK-8134577 the operative word has been "eliminate". As such, the interface and service descriptor sun.net.spi.namese

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2015-10-27 Thread Mark Sheppard
Hi Artem, thanks for the feedback, I'll make the changes for 2 & 3. I'll look into rework of try-with-resources. regards Mark On 26/10/2015 00:24, Artem Smotrakov wrote: Hi Mark, I am not a reviewer, just have a couple of comments about InetAddress.java 1. It may be better to create an in