RE: RFR(M): 8167457: Fixes for InetAddressImpl native coding on Windows

2017-01-26 Thread Langer, Christoph
Hi Michael, Thanks for reviewing. So I'll push them in jdk10. Best regards Christoph From: Michael McMahon [mailto:michael.x.mcma...@oracle.com] Sent: Donnerstag, 26. Januar 2017 15:51 To: Langer, Christoph Cc: Chris Hegarty ;

Re: RFR(M): 8167457: Fixes for InetAddressImpl native coding on Windows

2017-01-26 Thread Michael McMahon
Christoph, I would prefer to not push these native code change to JDK 9 at this stage. They look fine for JDK 10 though. Consider them both reviewed. Thanks Michael. On 26/01/2017, 10:02, Langer, Christoph wrote: Hi Chris, Michael, as I consider this change final from my side and the jdk10

Re: RFR [9] Warning notice for types in Incubator Modules

2017-01-26 Thread Magnus Ihse Bursie
On 2017-01-25 13:51, Chris Hegarty wrote: On 24 Jan 2017, at 16:44, Erik Joelsson wrote: Hello, Build changes look good except for one thing. In Javadoc.gmk, the dependency on $(BUILD_TOOLS_JDK) needs to be set for $$($1_INDEX_FILE) (on line 317), where the actual

RE: RFR(M): 8167457: Fixes for InetAddressImpl native coding on Windows

2017-01-26 Thread Langer, Christoph
Hi Chris, Michael, as I consider this change final from my side and the jdk10 forest is open now, I guess it is a good point to come back to this. I personally would prefer if I could still submit it to jdk9, given that it is automatically consolidated to jdk10 and the code base would remain

Re: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2017-01-26 Thread Chris Hegarty
Arno, > On 16 Jan 2017, at 11:23, Zeller, Arno wrote: > > Hi Michael and Chris, > > I see that in with "RFR: 8172253 SetIfModifiedSince.java test fails with http > return code 404" you fix a problem > on macOS that does occur, because macOS is the only platform that sets

Re: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2017-01-26 Thread Volker Simonis
Hi Chris, this change is fine for me now and I think Arno addressed all of your concerns. Is it OK for you if I push this to 9 and add you as one of the reviewers? Thank you and best regards, Volker On Wed, Jan 11, 2017 at 3:21 PM, Zeller, Arno wrote: > Hi Chris, > > I