On Tue, 31 May 2022 18:29:30 GMT, Brian Burkhalter wrote:
>> Modify `sun.net.www.MimeTable.findByFileName(String)` to attempt to find the
>> file extension in the entire file name if it is not found in the portion of
>> the name preceding the optional fragment beginning with a hash (`#`).
>
> B
On Mon, 23 May 2022 18:58:34 GMT, Mark Powers wrote:
>> JDK-6725221 Standardize obtaining boolean properties with defaults
>
> Mark Powers has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Alan and Jamil comments
On Tue, 10 May 2022 19:24:24 GMT, Mark Powers wrote:
>> src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 777:
>>
>>> 775: if (!printStackPropertiesSet && VM.initLevel() >= 1) {
>>> 776: printStackWhenAccessFails = GetBooleanAction.
>>> 777:
On Fri, 13 May 2022 05:54:15 GMT, Alan Bateman wrote:
>> src/java.base/linux/classes/sun/nio/ch/EPollSelectorImpl.java line 128:
>>
>>> 126: // timed poll interrupted so need to adjust timeout
>>> 127: long adjust = System.nanoTime() - startTime;
>>> 128:
On Tue, 10 May 2022 21:32:10 GMT, Roger Riggs wrote:
> PR#8599 8244681: proposes to add compiler warnings for possible lossy
> conversions
> From the CSR:
>
> "If the type of the right-hand operand of a compound assignment is not
> assignment compatible with the type
On Thu, 12 May 2022 14:25:44 GMT, Daniel Fuchs wrote:
>> In relation to
>> [JDK-8244681](https://bugs.openjdk.java.net/browse/JDK-8244681), please find
>> here a patch that addresses possibly lossy conversions in java.net.http
>
> Daniel Fuchs has updated the pull request incrementally with one
On Wed, 11 May 2022 18:33:44 GMT, Daniel Fuchs wrote:
>> So if x is a char, ~x seems to be an int :-(
>
> I have reverted adding constant fields. Too bad - the casts are back.
Phooey: Sorry to have lead you astray. :(
And casting before `~` does the same not wanted result.
-
PR:
On Wed, 11 May 2022 18:02:32 GMT, Daniel Fuchs wrote:
>> In relation to
>> [JDK-8244681](https://bugs.openjdk.java.net/browse/JDK-8244681), please find
>> here a patch that addresses possibly lossy conversions in java.net.http
>
> Daniel Fuchs has updated the pull request incrementally with one
On Wed, 11 May 2022 17:46:15 GMT, Daniel Fuchs wrote:
>> These methods either set or clear a single bit in `firstChar`.
>> The constant is an `int` so its complement is a 32 bit int.
>>
>> It could also be written as `~ (char) 0b100_000`. Then the 16 bit
>> unsigned char would be comp
On Wed, 11 May 2022 17:04:19 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/websocket/Frame.java
>> line 222:
>>
>>> 220: // compiler will emit a warning if not cast
>>> 221: firstChar &= (char) ~0b1000_;
>>> 222:
nd suggestions will inform similar updates to other OpenJDK modules).
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Updated copyrights
Fixed cast style to add a space after cast, (where consistent with file style)
Improved code per
nd suggestions will inform similar updates to other OpenJDK modules).
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
remove stray file
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8642/files
- new: https://g
PR#8599 8244681: proposes to add compiler warnings for possible lossy
conversions
>From the CSR:
"If the type of the right-hand operand of a compound assignment is not
assignment compatible with the type of the variable, a cast is implied and
possible lossy conversion may silently occur. While
On Fri, 11 Mar 2022 16:47:46 GMT, Aleksei Efimov wrote:
> The following fix seals the `java.net.InetAddress` class and permits only two
> implementations - `java.net.Inet4Address` and `java.net.Inet6Address`.
>
> No issues have been detected by regression and JCK tests.
>
> Links: [JBS](https
On Tue, 8 Mar 2022 05:51:21 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java line 204:
>>
>>> 202: } catch (GeneralSecurityException | java.io.IOException e)
>>> {
>>> 203: throw new SSLHandshakeException(
>>> 204:
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
We usually request that these be be broken up by area to attract the
appropriate reviewers and avoid eye-strain. The client mo
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote:
> Reduce noise in test output by adding the @SuppressWarnings("removal")
> annotation (which has already been widely applied).
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7328
On Thu, 9 Dec 2021 13:03:39 GMT, Сергей Цыпанов wrote:
>> Instead of something like
>>
>> long x;
>> long y;
>> return (x < y) ? -1 : ((x == y) ? 0 : 1);
>>
>> we can use `return Long.compare(x, y);`
>>
>> All replacements are done with IDE.
>
> Сергей Цыпанов has updated the pull request incr
On Wed, 1 Dec 2021 14:47:54 GMT, Roger Riggs wrote:
> Compilation warnings of the test library introduce noise in test output and
> should be addressed or suppressed.
> Changes include:
> - SuppressWarnings("deprecation") and SuppressWarnings("removal")
&g
On Tue, 14 Dec 2021 03:14:10 GMT, Leonid Mesnik wrote:
> Is test/micro/org/openjdk/bench/java/io/SerialFilterOverhead.java added
> accidentally or by purpose?
By mistake, thanks for noticing.
-
PR: https://git.openjdk.java.net/jdk/pull/6638
ing a hashCode method where equals was already present
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove a test/micro file added by mistake.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6638/files
- new: http
ing a hashCode method where equals was already present
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additional commits since
the last re
On Wed, 1 Dec 2021 14:47:54 GMT, Roger Riggs wrote:
> Compilation warnings of the test library introduce noise in test output and
> should be addressed or suppressed.
> Changes include:
> - SuppressWarnings("deprecation") and SuppressWarnings("removal")
&g
Compilation warnings of the test library introduce noise in test output and
should be addressed or suppressed.
Changes include:
- SuppressWarnings("deprecation") and SuppressWarnings("removal")
- Adding type parameters to Raw types
- Adding a hashCode method where equals was already present
-
On Mon, 29 Nov 2021 08:18:47 GMT, Сергей Цыпанов wrote:
>> Instead of something like
>>
>> long x;
>> long y;
>> return (x < y) ? -1 : ((x == y) ? 0 : 1);
>>
>> we can use `return Long.compare(x, y);`
>>
>> All replacements are done with IDE.
>
> Сергей Цыпанов has updated the pull request inc
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Wed, 3 Nov 2021 10:11:31 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a trivial cleanup change that updates classes in the
> `java.net.http` module to use the "blessed modifier order".
>
> The changeset was obtained by running `sh ./bin/blessed-modifier-order.sh
> src/java.net.http
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote:
> This PR follows up one of the recent PRs, where I used a non-canonical
> modifier order. Since the problem was noticed [^1], why not to address it at
> mass?
>
> As far as I remember, the first mass-canonicalization of modifiers took place
On Tue, 2 Nov 2021 18:48:06 GMT, Mark Sheppard wrote:
>> Here's a bit of archaeology. I found the original JDK-8136583 patch, which
>> has moved from where it was in the RFR to
>> https://cr.openjdk.java.net/~martin/webrevs/jdk9/blessed-modifier-order/.
>> That patch doesn't change Object.java
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote:
> This PR follows up one of the recent PRs, where I used a non-canonical
> modifier order. Since the problem was noticed [^1], why not to address it at
> mass?
>
> As far as I remember, the first mass-canonicalization of modifiers took place
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by rriggs (R
On Wed, 1 Sep 2021 07:37:53 GMT, Andrey Turbanov
wrote:
> There are few places in code where manual while loop is used with Iterator to
> iterate over Collection.
> Instead of manual while cycles it's preferred to use enhanced-for cycle
> instead: it's less verbose, makes code easier to read a
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote:
> C-style array declarations generate noisy warnings in IDEs, et.c. This patch
> cleans up all java.* packages.
>
> (Copyrights intentionally not updated due the triviality of most changes)
34 Minutes from proposed to integrated!
Its hard
On Thu, 29 Jul 2021 16:36:21 GMT, Roger Riggs wrote:
> Improve the clarity of comments in the ObjectInputFilter FilterInThread
> example.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk17/pull/292
Improve the clarity of comments in the ObjectInputFilter FilterInThread example.
-
Commit messages:
- 8271489: (doc) Clarify Filter Factory example
- 8270398: Enhance canonicalization
- 8270404: Better canonicalization
- Merge
- Merge
- 8263531: Remove unused buffer int
- 82627
On Wed, 14 Jul 2021 20:53:34 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/FileReader.java line 41:
>>
>>> 39: * @see InputStreamReader
>>> 40: * @see FileInputStream
>>> 41: * @see java.nio.charset.Charset#defaultCharset()
>>
>> The @ see duplicates the link above, the javad
On Thu, 8 Jul 2021 21:23:00 GMT, Naoto Sato wrote:
> This is an implementation for the `JEP 400: UTF-8 by Default`. The gist of
> the changes is `Charset.defaultCharset()` returning `UTF-8` and
> `file.encoding` system property being added in the spec, but another notable
> modification is in
On Tue, 13 Apr 2021 15:39:17 GMT, Julia Boes wrote:
> Add two static factory methods to com.sun.net.httpserver that facilitate the
> creation of pre- and post-processing Filters:
>
> `public static Filter beforeResponse(String description,
> Consumer filterImpl) {}`
> `public static Filter af
On Wed, 14 Apr 2021 14:03:01 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial doc changes reviewed please, caused by:
>
> - broken tags in MethodHandles referring to package.html instead of
> package-summary.html
>
> - references to a package level #unixdomain anchor t
On Sat, 13 Mar 2021 22:45:30 GMT, Alex Blewitt
wrote:
> Sonar displays a warning message that modifiers should be declared in the
> order listed in the JLS; specifically, that isntead of using `final static`
> the `static final` should be preferred.
>
> This fixes the issues in the `java.base
On Fri, 8 Jan 2021 20:34:10 GMT, Roger Riggs wrote:
> Cleanup of tests test/jdk/java/net and test/jdk/sun/net that format
> hexadecimal strings to use java.util.HexFormat methods.
> Also in tests test/jdk/java/util/Locale/SoftKeys.
This pull request has now been integrated.
Cleanup of tests test/jdk/java/net and test/jdk/sun/net that format hexadecimal
strings to use java.util.HexFormat methods.
Also in tests test/jdk/java/util/Locale/SoftKeys.
-
Commit messages:
- 8259493: [test] Use HexFormat instead of adhoc hex utilities in network code
and locale
On Fri, 18 Dec 2020 16:54:59 GMT, Chris Hegarty wrote:
> Temporarily revert use of pattern match instanceof construct until
> docs-reference is fixed, see JDK-8258657.
>
> ...
> Generating REFERENCE_API javadoc for 21 modules
>
> if (delegate instanceof ExecutorService service)
java.util.HexFormat utility:
- Format and parse hexadecimal strings, with parameters for delimiter, prefix,
suffix and upper/lowercase
- Static factories and builder methods to create HexFormat copies with
modified parameters.
- Consistent naming of methods for conversion of byte arrays to fo
On Mon, 28 Sep 2020 09:23:55 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean
>> up in Authenticator and BasicAuthenicator'
>> ?
>> This fix is set of formatting changes intended to clean up the javadoc of
>> the following
On Fri, 25 Sep 2020 17:32:41 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean
>> up in Authenticator and BasicAuthenicator'
>> ?
>> This fix is set of formatting changes intended to clean up the javadoc of
>> the following
On Tue, 22 Sep 2020 16:20:17 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean
>> up in Authenticator and BasicAuthenicator'
>> ?
>> This fix is set of formatting changes intended to clean up the javadoc of
>> the following
On Thu, 10 Sep 2020 11:43:51 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
>> warnings in jdk.net.httpserver’ ?
>>
>> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
>> missing/incomplete API docu
On Wed, 9 Sep 2020 12:14:28 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
>> warnings in jdk.net.httpserver’ ?
>>
>> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
>> missing/incomplete API docum
On Wed, 9 Sep 2020 12:14:28 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
>> warnings in jdk.net.httpserver’ ?
>>
>> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
>> missing/incomplete API docum
On Wed, 9 Sep 2020 12:16:44 GMT, Patrick Concannon
wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsParameters.java
>> line 30:
>>
>>> 28: import java.net.InetSocketAddress;
>>> 29:
>>> 30: //BEGIN_TIGER_EXCLUDE
>>
>> I don't have the context here - but if we're removing
Hi Patrick,
Usually, the @param and @returns text does not edit a period (unless it
is a complete sentence).
The indentation of the new comment blocks is in a few places off.
I.e.
+++ b/src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java
Mon Aug 31 16:57:06 2020 +0100
@
Looks fine Julia
On 8/18/20 1:02 PM, Julia Boes wrote:
Hi,
The two changes below still need to be reviewed. Any takers?
Cheers,
Julia
---
old/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java2020-08-14
23:55:41.953638446 +0530
+++
new/src/java.base/sha
Hi Michael,
Looks good.
Maybe just a future cleanup to rename files, since the "...so..." is
refering to solaris.
src/java.base/unix/native/libjli/java_md_solinux.h
src/java.base/unix/native/libjli/java_md_solinux.h
Regards, Roger
On 5/4/20 4:49 AM, Alan Bateman wrote:
On 04/05/2020 06:12
Hi Ivan,
Minor editorial suggestion in ExtendedSocketOptions.java:177
...that +an+ application can use...
$.02, Roger
On 4/29/20 2:11 PM, Ivanov, Vladimir A wrote:
Updated version of the webrev available as
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.03/
The tests run
I'm not sure its worth the time, but on failure, a combination of
netstat and lsof
could identify the consumers of the sockets.
Roger
On 11/29/19 2:49 AM, Alan Bateman wrote:
On 22/11/2019 16:35, Chris Hegarty wrote:
:
QuickAckTest only creates one DatagramSocket and one MulticastSocket, so
+1,
Another finalizer gone!
On 11/12/19 12:57 PM, Daniel Fuchs wrote:
Looks good to me Michael.
Good riddance! :-)
best regards,
-- daniel
On 12/11/2019 16:45, Michael McMahon wrote:
Hi,
Could I get the following small change reviewed please?
8233958 complains about memory retention caus
Hi Claes,
Looks fine.
Thanks for the updates, Roger
On 7/11/19 10:39 AM, Claes Redestad wrote:
Hi Roger,
On 2019-07-11 16:10, Roger Riggs wrote:
Hi Claes,
JavaLangAccess.java:
316: Add @param tag
done.
System.java: 2282, 2287
Runtime.loadLibrary0 makes a second check for a security
Hi Claes,
JavaLangAccess.java:
316: Add @param tag
System.java: 2282, 2287
Runtime.loadLibrary0 makes a second check for a security manager.
Is there any potential gain by calling ClassLoader.loadLibrary directly?
None of the internal uses would have a separatorChar.
I expect most of the files
Hi Brian,
Having the extraneous suffix consistently removed seems like a good thing.
Though I'm not sure what the best form of the utility function is:
1) return the count of characters to remove
2) just truncate the buffer.
There may be ways to force some of the errors that would lead to the
Hi,
If you need different @requires for different runs, there is a jtreg
feature to define separate tests using separate comment blocks.
/*...
*@requires x
*@run ...
*/
/*
* @requires !x
* @run ...
*/
$.02, Roger
On 04/11/2019 12:01 PM, Chris Hegarty wrote:
Arthur, Daniel,
On 10 Apr
Thanks Brian
On 01/24/2019 02:19 PM, Brian Burkhalter wrote:
Verified against current repo.
+1
Brian
On Jan 24, 2019, at 10:58 AM, Roger Riggs <mailto:roger.ri...@oracle.com>> wrote:
Please review a quick fix for a test compilation error, as a side
effect of 8216986.
diff --g
Please review a quick fix for a test compilation error, as a side effect
of 8216986.
diff --git a/test/jdk/java/net/Socks/SocksIPv6Test.java
b/test/jdk/java/net/Socks/SocksIPv6Test.java
--- a/test/jdk/java/net/Socks/SocksIPv6Test.java
+++ b/test/jdk/java/net/Socks/SocksIPv6Test.java
@@ -173,7
Looks fine Joe
I hadn't realized example.com was registered for that purpose. :)
On 11/26/2018 04:38 PM, joe darcy wrote:
Hello,
Please review a simple doc-only change to address:
JDK-8213911: Use example.com in java.net and other examples
http://cr.openjdk.java.net/~darcy/8213911.0
+1
On 6/27/2018 1:15 PM, Alan Bateman wrote:
On 27/06/2018 18:09, Daniel Fuchs wrote:
Hi,
Please find below a trivial fix for:
https://bugs.openjdk.java.net/browse/JDK-8205397
8205397: InetAddress has wrong declaration for readObjectNoData
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev-
Hi Chris,
TwoStacksPlainDatagramSocketImpl.java:136 could be explicit about the
native bind0
changing the state.
And I agree with Alan that the calls to updateCleaner (:144) should
occur whether or not
the native bind0 throws an exception.
Thanks, Roger
On 3/28/2018 1:22 PM, Alan Bateman w
+1
On 3/6/2018 10:57 AM, Langer, Christoph wrote:
Looks good, Brian.
*From:*net-dev [mailto:net-dev-boun...@openjdk.java.net] *On Behalf Of
*Brian Burkhalter
*Sent:* Dienstag, 6. März 2018 16:27
*To:* OpenJDK Network Dev list
*Subject:* RFR 8198302: VS2017 (C4477)
java.base/windows/native/
Hi Ashton,
Your optimism seems misplaced; I heard several suggestions that you
pick another
web server to depend on. The http server is an unsupported utility;
nothing more.
BTW, my mailer marks this email as a possible scam because the link is
malformed.
Also, the mention of jdk6 is an
Hi Claes,
Looks fine,
Roger
On 2/14/2018 11:36 AM, Claes Redestad wrote:
Right, I expanded the range as much as possible given the constraint
provided by L_ENCODED minus '/'. I will think of a better comment to
this effect.
/Claes
Daniel Fuchs skrev: (14 februari 2018
17:25:20 CET)
Hi Florian,
Thanks for the reminder, I'll add it to 8196716 Refactor FileDescriptor
FDCleanup <https://bugs.openjdk.java.net/browse/JDK-8196716>
Thanks, Roger
On 2/4/2018 4:17 PM, Florian Weimer wrote:
* Roger Riggs:
Updated in place.
http://cr.openjdk.java.net/~rriggs
:07, Roger Riggs wrote:
Hi Chris,
Updated in place.
http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/
Thanks, Roger
On 2/2/2018 11:30 AM, Chris Hegarty wrote:
Roger,
On 01/02/18 21:29, Roger Riggs wrote:
Hi Chris,
Thanks for the review and suggestion.
Webrev upd
Hi Chris,
Updated in place.
http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/
Thanks, Roger
On 2/2/2018 11:30 AM, Chris Hegarty wrote:
Roger,
On 01/02/18 21:29, Roger Riggs wrote:
Hi Chris,
Thanks for the review and suggestion.
Webrev updated:
http://cr.openjdk.java.net
the test by retaining the checking for GC reclaimed
objects but
removed checking fd counts, since they were unreliable in testing
and not consistent across OS's
Thanks, Roger
On 2/1/2018 10:11 AM, Chris Hegarty wrote:
Hi Roger,
On 31 Jan 2018, at 15:52, Roger Riggs wrote:
Addin
Adding net-dev@openjdk.java.net
On 1/30/2018 5:08 PM, Roger Riggs wrote:
Please review changes to replace finalizers in socket, datagram, and
multicast networking
with Cleaner based release of the raw file descriptors. Each
FileDescriptor is registered
for cleanup after the raw fd (or handle
+1
On 1/24/2018 5:43 AM, Chris Hegarty wrote:
On 23/01/18 09:42, vyom tewari wrote:
Hi,
Please review below code change for simple fix.
Webrev: http://cr.openjdk.java.net/~vtewari/8194676/webrev0.0/index.html
Thanks Vyom, I think your change is good.
-Chris.
+1
On 12/2/2017 4:17 AM, Chris Hegarty wrote:
On 1 Dec 2017, at 07:13, vyom tewari wrote:
Hi Chris,
Thanks for review, while my testing i discovered issue in the way we handle
extended socket options and standard socket options. I fixed it and updated
one test as well.
I removed one redun
Hi Vyom,
Looks fine
Roger
On 11/16/2017 4:03 AM, vyom tewari wrote:
Hi All,
Please review the small code change for the below issue.
Webrev :
http://cr.openjdk.java.net/~vtewari/8190843/webrev0.0/index.html
BugId : https://bugs.openjdk.java.net/browse/JDK-8190843
In this cod
+1, Reviewed
Roger
On 11/14/2017 2:45 PM, Ivan Gerasimov wrote:
Hello!
A typo in the javadoc:
--- a/src/java.base/share/classes/java/net/InetAddress.java
+++ b/src/java.base/share/classes/java/net/InetAddress.java
@@ -1133,7 +1133,7 @@
/**
* Create an instance of the NameService i
super.remove()) then the next call to
the Iterator would throw a CME. But we don’t go back to the iterator
as we return after removing.
Nevertheless, I can still remove the comment or change it… let me know.
Thanks
Christoph
*From:*Roger Riggs [mailto:roger.ri...@oracle.com]
*Sent:* Mittwoch, 18
lto:net-dev-boun...@openjdk.java.net] *On Behalf Of
*Roger Riggs
*Sent:* Dienstag, 17. Oktober 2017 16:53
*To:* net-dev@openjdk.java.net
*Subject:* Re: RFR(S): 8155590: Dubious collection management in
sun.net.www.http.KeepAliveCache
Hi,
Keep the synchronized, it will be low overhead since
Hi,
Keep the synchronized, it will be low overhead since the Vector operations
are synchronized and in the same thread.
I think a CCE could occur during the iteration to find the entry when
Vector.Itr.next() checks.
(It you want to more radical fix, replace the Vector with something more
cur
Hi Vyom,
A few suggestions:
PlainDatagramSocketImpl.java:
- line 95/96: I think you can use just forEach, the order version is
not necessary.
The code will be a bit more readable if the .filter and .forEach
are on a new line and don't wrap.
You can also remove the extra "(" and ")
Hi Ivan,
Looks fine,
Thanks, Roger
On 9/25/2017 4:58 PM, Ivan Gerasimov wrote:
Thank you Roger for review!
On 9/25/17 11:47 AM, Roger Riggs wrote:
Hi Ivan,
Looks ok to me.
I don't see a reason to skimp on the additional size since it is
allocated and then freed immediately.
Hi Ivan,
Looks ok to me.
I don't see a reason to skimp on the additional size since it is
allocated and then freed immediately.
The increment might as well be as big as the initial size.
I don't see a reason to retry if the buffer gets close to ULONG_MAX; I'd
just break the for loop
and let
Hi Vyom,
Looks fine to me too.
My only concern was adding an intensive test (used to be a stress test)
to the normal
test cycles. I'd be more comfortable with it being in a separate/lower
tier or as @manual.
Roger
On 9/24/2017 1:15 PM, Chris Hegarty wrote:
On 15 Sep 2017, at 10:29, vyom
Hi Felix,
Looks ok; though could be simpler to just print all the addresses of all
NIs.
findIntefacesWithDupAddress could use streams more effectively (if its
worth the time to rewrite).
The inetAddresses() method on NetworkInterface produces a stream of
InetAddress which could
be filtere
Hi Felix,
Looks fine.
Roger
On 8/28/2017 3:51 AM, Felix Yang wrote:
Hi there,
please review the patch to enable debug diagnostic for
test/java/net/ipv6tests/TcpTest.java. Then we can know which addresses
are being used, to isolate possible multi-homed issues.
Bug:
https://bugs.op
Hi Daniel,
Looks fine,
Roger
On 8/3/2017 2:21 PM, Daniel Fuchs wrote:
Hi,
Please find below a fix for a test bug:
https://bugs.openjdk.java.net/browse/JDK-8185794
8185794: java/net/httpclient/security/Driver.java fails in timeout
http://cr.openjdk.java.net/~dfuchs/webrev_8185794/webrev.00/
Looks fine Felix,
Roger
On 6/29/2017 3:59 AM, Felix Yang wrote:
Hi all,
please review a minor patch to add key intermittent to two tests.
They have been observed to be failing intermittently.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8182975
Patch:
diff -r 7cef1c3f1dbe test/j
/GetResourceAsStream.java
URLConnection/6212146/Test.java:47 typo: ULR -> URL
Regards, Roger
On 5/25/2017 11:14 PM, Felix Yang wrote:
Hi Roger,
please review the updated webrev:
http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.01/
Thanks,
Felix
On 2017/5/26 3:24, Roger Riggs wrote:
Hi Fe
Hi Felix,
closetest/CloseTest:
32: Please put the @modules directives together (and not repeat)
44: do not use wildcard imports (reconfigure your IDE if necessary to
avoid accidents).
63: setup() is invoked twice... remove 1 or explain why 2 calls
69, 78,90,91,... : space in method call
Hi Michael,
Looks fine.
But they are applicable to JDK 9 and as doc changes are acceptable.
Why JDK 10?
Roger
On 4/19/2017 12:36 PM, Michael McMahon wrote:
Could I get the following JDK 10 reviews please.
They are minor doc cleanups, that do not involve spec changes
https://bugs.openjdk.jav
Hi Chris,
Looks good, nice use of streams.
B6558853.java: 28: an extra "*"
A few tests do nothing unless an interface is found; they could use
either output that says what
interface is tested or a message that no interface was available.
(In case someone is reviewing the logs and wants to kn
Hi Vyom,
Thanks for taking this on. I have a few comments and questions.
In aix_close.c line 547 The code for if (nanoTimeout >= NSEC_PER_MSEC)
seems ineffective.
The update of nanoTime at 549-550 ensures the timeout is > NSEC_PER_MSEC
if it loops.
On the first pass through the code if nan
Hi Sean,
Looks good,
Roger
On 3/20/2017 12:11 PM, Seán Coffey wrote:
Looking for a simple review. Test should be run in ovm mode :
https://bugs.openjdk.java.net/browse/JDK-8177144
diff --git a/test/sun/net/www/http/HttpClient/B8025710.java
b/test/sun/net/www/http/HttpClient/B8025710.java
-
NameImpl impl;
/**
* Syntax properties for this compound name.
* This field is initialized by the constructors and cannot be
null.
On Tuesday 17 January 2017 09:20 PM, Roger Riggs wrote:
Hi Vyom,
Please also correct or remove the comment saying it should be treated
as read-only
Hi Vyom,
Please also correct or remove the comment saying it should be treated as
read-only by subclasses.
Roger
On 1/16/2017 4:56 AM, Chris Hegarty wrote:
Looks good. Thanks Vyom.
-Chris.
On 16 Jan 2017, at 09:10, Vyom Tewari wrote:
Hi All,
Please review below the small fix for the
On 11/1/2016 2:34 PM, Daniel Fuchs wrote:
Hi Roger,
I think we agree :-)
On 01/11/16 18:01, Roger Riggs wrote:
Hi Daniel,
It seemed useful to be able to run the test in as many environments as
possible
though realistically java.util.logging may be there too.
I don't see that setting t
opped or configured via the
java.util.logging.config.file system property if/when needed.
$.02, Roger
On 11/1/2016 1:53 PM, Daniel Fuchs wrote:
Hi Roger,
On 01/11/16 17:21, Roger Riggs wrote:
Hi Sergei,
I think it would be preferable to convert the tests to use
System.getLogger.
Is that pos
1 - 100 of 184 matches
Mail list logo
