Thanks Chris. I will take your comments into account and push the patch.
- Kurchi
On 4/24/2012 5:46 AM, Chris Hegarty wrote:
Kurchi,
The change looks fine to me. Thanks for forward porting.
Trivially, the indentation of getDefaultScopeID looks a little off.
Specifically, L121 in the new fil
Kurchi,
The change looks fine to me. Thanks for forward porting.
Trivially, the indentation of getDefaultScopeID looks a little off.
Specifically, L121 in the new file:
ni_defaultIndexID = (*env)->GetStaticFieldID(env, c,
"defaultIndex", "I");
Hi,
Before joining multicast groups with IPv6 addresses on Mac OS, the
network interface to be used should also be set correctly. This
change enables using a default network interface on Mac OS X if no
interface has been specified.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=714
Looks fine to me.
-Chris.
On 02/14/12 07:12 PM, Kurchi Hazra wrote:
Updated webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.02/
- Kurchi
On 2/14/2012 12:58 AM, Chris Hegarty wrote:
Trivially, I don't think getDefaultScopeID needs it's implementation
to be ifdef'ed with MACOSX, at
Updated webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.02/
- Kurchi
On 2/14/2012 12:58 AM, Chris Hegarty wrote:
Trivially, I don't think getDefaultScopeID needs it's implementation
to be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'.
It is just a general util
Trivially, I don't think getDefaultScopeID needs it's implementation to
be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'.
It is just a general utility method to get the value of the defaultIndex
field of NetworkInterace. Yes, the value will be 0 on all platforms
other than
On 13/02/2012 22:03, Kurchi Hazra wrote:
Hi,
Before joining multicast groups with IPv6 addresses on Mac OS, the
network interface to be used should also be set correctly. This
change enables using a default network interface on Mac OS X if no
interface
has been specified.
Bug:http://bugs.sun
Hi,
Before joining multicast groups with IPv6 addresses on Mac OS, the
network interface to be used should also be set correctly. This
change enables using a default network interface on Mac OS X if no interface
has been specified.
Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274