Re: RFR(M): 8060470 : Unify and simplify the implmentations of Inet{4, 6}AddressImpl_getLocalHostName()

Hello, I (still) like it. But I still think the AI_CANONNAME can and should be removed. If you keep it, it will trigger additional lookups and the actual canonized result (res->ai_canonname) is never used. This is true for all 3 locations (but you changed only one). I wonder if you want to make

Re: RFR(M): 8060470 : Unify and simplify the implmentations of Inet{4, 6}AddressImpl_getLocalHostName()

Hi, under the following link you can find an updated version of my change where I've fixed all indentation in Inet{4,6}AddressImpl.c to 4 spaces and changed the few C++-style comments (i.e. '//') to C-style comments (i.e. '/* */'): http://cr.openjdk.java.net/~simonis/webrevs/8060470.v2/ Can I pl

Re: RFR(M): 8060470 : Unify and simplify the implmentations of Inet{4, 6}AddressImpl_getLocalHostName()

On 27.10.2014 21:45, Volker Simonis wrote: On Fri, Oct 24, 2014 at 7:07 PM, Ivan Gerasimov wrote: Hi Volker! I'm not a Reviewer, but have a couple of minor comments. In the C source files you changed the indentation to two spaces. It looks inconsistent with other JDK sources. I know that in

Re: RFR(M): 8060470 : Unify and simplify the implmentations of Inet{4, 6}AddressImpl_getLocalHostName()

On 27/10/2014 17:45, Volker Simonis wrote: : Well, the problem is that already that very file contains code in both code conventions (see for example the implementations of 'ping4()' and 'Java_java_net_Inet4AddressImpl_isReachable0()' in Inet4AddressImpl.c which are mostly indented by two spaces)

Re: RFR(M): 8060470 : Unify and simplify the implmentations of Inet{4, 6}AddressImpl_getLocalHostName()

On Fri, Oct 24, 2014 at 7:07 PM, Ivan Gerasimov wrote: > Hi Volker! > > I'm not a Reviewer, but have a couple of minor comments. > > In the C source files you changed the indentation to two spaces. > It looks inconsistent with other JDK sources. > I know that in hotspot they use two space indentat

Re: RFR(M): 8060470 : Unify and simplify the implmentations of Inet{4, 6}AddressImpl_getLocalHostName()

Hi Volker! I'm not a Reviewer, but have a couple of minor comments. In the C source files you changed the indentation to two spaces. It looks inconsistent with other JDK sources. I know that in hotspot they use two space indentation, but it's a different set of sources. Inet4AddressImpl.c: 1

Re: RFR(M): 8060470 : Unify and simplify the implmentations of Inet{4, 6}AddressImpl_getLocalHostName()

Hi, could somebody please have a quick look at this change. It's really not that complicated as it looks like from the comments - I just didn't manage to write it up in a more concise way :) Thanks, Volker On Thu, Oct 16, 2014 at 4:39 PM, Volker Simonis wrote: > Hi, > > could you please hava a

RFR(M): 8060470 : Unify and simplify the implmentations of Inet{4, 6}AddressImpl_getLocalHostName()

Hi, could you please hava a look at the following change: http://cr.openjdk.java.net/~simonis/webrevs/8060470.v1 https://bugs.openjdk.java.net/browse/JDK-8060470 It's probably easier to read the following in the webrev, but I copy it below for discussion. Regards, Volker So here comes the firs