Re: Review of new Http client API

2012-11-02 Thread Michael McMahon
Richard, It is not part of JDK 8 yet, but you can download and build the source against JDK7 in Netbeans. We have been running it as a java.net project at http://java.net/projects/http-client If you'd prefer me to send you a pre-built jar file I could do that. However, the API has moved on a bit

Re: Review of new Http client API

2012-08-23 Thread Chris Hegarty
On 23/08/2012 16:34, Paul Sandoz wrote: ... OK, i would be inclined to separate out the instance used for building from the instance passed around, so one cannot muck around with the state of the latter. Agreed, HttpResponse could use a builder pattern. Then user code may do: AsyncHttp

Re: Review of new Http client API

2012-08-23 Thread Paul Sandoz
On Aug 23, 2012, at 5:16 PM, Michael McMahon wrote: > Paul, > > Thanks for looking at it. Yes, this is an area that needs some more work. > The current thinking is along the lines that Chris just posted and I hope to > have another version of the API to look at tomorrow. > > What you suggest

Re: Review of new Http client API

2012-08-23 Thread Paul Sandoz
On Aug 23, 2012, at 5:05 PM, Chris Hegarty wrote: > Paul, > > All good feedback, and I will leave it to Michael to reply to the specifics. > On thought I had on separation of modes is something list this: > > interface HeaderHandler { > onHeaders(HttpResponse); > } > interface ErrorHa

Re: Review of new Http client API

2012-08-23 Thread Michael McMahon
Paul, Thanks for looking at it. Yes, this is an area that needs some more work. The current thinking is along the lines that Chris just posted and I hope to have another version of the API to look at tomorrow. What you suggest seems like an unusual usage of Future<> as we have tried to provide

Re: Review of new Http client API

2012-08-23 Thread Chris Hegarty
Paul, All good feedback, and I will leave it to Michael to reply to the specifics. On thought I had on separation of modes is something list this: interface HeaderHandler { onHeaders(HttpResponse); } interface ErrorHandler { onError(HttpResponse, Throwable); } interface B

Re: Review of new Http client API

2012-08-23 Thread Paul Sandoz
Hi, A potential simplification of the HttpResponseHeadersHandler interface is to turn it into a functional interface: HttpResponseHandler onHeaders(Future dresp) throws InterruptedException, ExecutionException; [Chris, i am not sure if an interface with two methods, one default, is classifi

Re: Review of new Http client API

2012-08-23 Thread Michael McMahon
On 22/08/12 22:09, Sam Pullara wrote: On Aug 22, 2012, at 1:17 PM, Chris Hegarty wrote: On 22/08/12 21:05, Michael McMahon wrote: On 22/08/12 15:29, Chris Hegarty wrote: Michael what you have looks good. But, I think what Sam is suggesting ( or maybe not, but I like it ;-) ), is something lik

Re: Review of new Http client API

2012-08-22 Thread Chris Hegarty
On 22/08/12 21:05, Michael McMahon wrote: On 22/08/12 15:29, Chris Hegarty wrote: Michael what you have looks good. But, I think what Sam is suggesting ( or maybe not, but I like it ;-) ), is something like this. (I'd need to think more about what effect this has on the different modes, async/b

Re: Review of new Http client API

2012-08-22 Thread Michael McMahon
On 22/08/12 15:29, Chris Hegarty wrote: Michael what you have looks good. But, I think what Sam is suggesting ( or maybe not, but I like it ;-) ), is something like this. (I'd need to think more about what effect this has on the different modes, async/blocking ) class HttpResponse { Http

Re: Review of new Http client API

2012-08-22 Thread Chris Hegarty
Michael what you have looks good. But, I think what Sam is suggesting ( or maybe not, but I like it ;-) ), is something like this. (I'd need to think more about what effect this has on the different modes, async/blocking ) class HttpResponse { HttpResponse onHeaders(Block); HttpRespons

Re: Review of new Http client API

2012-08-21 Thread Michael McMahon
Sam, Thanks for the comments. Some discussion below. On 17/08/12 00:13, Sam Pullara wrote: I suggest that you make it a more fluent API rather than having multiple callback methods in your callback interface. As it stands it isn't compatible with lambdas. You might take some inspiration for th

Review of new Http client API

2012-08-14 Thread Michael McMahon
Hi, (apologies for sending this again) We have just published a draft of a proposed new Http client API [1] for JDK 8. This message has been cc'd to jdk8-dev so that as many people as possible know about it, but the discussion will be on the net-dev list (net-dev@openjdk.java.net). So, folks

Review of new Http client API

2012-08-13 Thread Michael McMahon
Hi, We have just published a draft of a proposed new Http client API [1] for JDK 8. This message has been bcc'd to jdk8-dev so that as many people as possible know about it, but the discussion will be on the net-dev list (net-dev@openjdk.java.net). So, folks will have to join that list [2],