Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-17 Thread Frank Ding
Hi Chris and Jonathan, Thank you all. The change set is OK. Best regards, Frank On 8/17/2012 5:20 PM, Jonathan Lu wrote: On 08/17/2012 04:14 PM, Chris Hegarty wrote: On 16/08/12 10:21, Frank Ding wrote: Hi Chris and Alan, Thank you for taking time to help this issue. I have built

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-17 Thread Jonathan Lu
On 08/17/2012 04:14 PM, Chris Hegarty wrote: On 16/08/12 10:21, Frank Ding wrote: Hi Chris and Alan, Thank you for taking time to help this issue. I have built using latest openjdk 8 repo on Windows 64 and Linux 32/64. Since it's a macro change in path "src/solaris", I only did jtreg t

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-17 Thread Chris Hegarty
On 16/08/12 10:21, Frank Ding wrote: Hi Chris and Alan, Thank you for taking time to help this issue. I have built using latest openjdk 8 repo on Windows 64 and Linux 32/64. Since it's a macro change in path "src/solaris", I only did jtreg tests for Linux 32 and 64 build. The jtreg tes

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-16 Thread Dmitry Samersoff
Chris, Yes, I'm asking more general question - it's why I address it to you but Frank. IMHO, logic cleanup would take almost the same time as just reformatting macros (in all cases testing is required) and create almost the same disturbance for people porting openjdk to other platforms. So (on m

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-16 Thread Chris Hegarty
Dmitry, You already know this, but to be clear, Frank's changes are simply changing the definitions so that platforms like AIX will use the same implementation as Solaris, Mac, etc. There will be no behavior changes from this. You're just asking general questions, right? On 16/08/2012 12:25,

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-16 Thread Dmitry Samersoff
Chris, Sorry for being later at the party. 1. Could you explain why you are calling both mcast_set_if_by_addr_v4 mcast_set_if_by_addr_v6 for Linux and only mcast_set_if_by_addr_v6 for other OS-es. 2. If it's really necessary did you consider of writing special variant of mcast_set_if_by_a

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-16 Thread Frank Ding
On 8/14/2012 10:42 PM, Chris Hegarty wrote: On 14/08/12 13:11, Alan Bateman wrote: On 14/08/2012 04:11, Frank Ding wrote: On 8/7/2012 1:46 PM, Frank Ding wrote: : Could anybody take a look at my patch below and make comment? http://cr.openjdk.java.net/~youdwei/ojdk-533/webrev.00/ Thanks & Be

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-14 Thread Chris Hegarty
On 14/08/12 13:11, Alan Bateman wrote: On 14/08/2012 04:11, Frank Ding wrote: On 8/7/2012 1:46 PM, Frank Ding wrote: : Could anybody take a look at my patch below and make comment? http://cr.openjdk.java.net/~youdwei/ojdk-533/webrev.00/ Thanks & Best regards, Frank Hi all, Is there anybod

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-14 Thread Alan Bateman
On 14/08/2012 04:11, Frank Ding wrote: On 8/7/2012 1:46 PM, Frank Ding wrote: : Could anybody take a look at my patch below and make comment? http://cr.openjdk.java.net/~youdwei/ojdk-533/webrev.00/ Thanks & Best regards, Frank Hi all, Is there anybody who is interested in the patch and who

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-13 Thread Frank Ding
On 8/7/2012 1:46 PM, Frank Ding wrote: Hi all, In source code "jdk\src\solaris\native\java\net\PlainDatagramSocketImpl.c", there are several macros in the form of #ifdef AF_INET6 #if defined(__solaris__) || defined(MACOSX) // code for solaris and macosx (unix) [1] #endif #ifdef __linux

Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-06 Thread Frank Ding
Hi all, In source code "jdk\src\solaris\native\java\net\PlainDatagramSocketImpl.c", there are several macros in the form of #ifdef AF_INET6 #if defined(__solaris__) || defined(MACOSX) // code for solaris and macosx (unix) [1] #endif #ifdef __linux__ // code for linux #endif #else