Re: Doubt in kernel packet generation

2005-08-12 Thread Evgeniy Polyakov
On Fri, Aug 12, 2005 at 09:33:13AM +0530, varun ([EMAIL PROTECTED]) wrote: Hi all, I have a major doubt regarding how to generate my own icmp packet from the kernel space. That is iam aware of raw sockets and packet sockets but thats from user space. I want one of my kernel module

[PATCH] TCP Offload (TOE) - Chelsio

2005-08-12 Thread Scott Bardone
OPEN TOE submission from Chelsio Communications. The following items have been addressed: - cleaned up indentation. - cleaned up comments. - cleaned up c-styles. - using EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL - removed 2.4 compatibility. - created TCP_OFFLOAD config option. - moved #defines

Re: [PATCH] TCP Offload (TOE) - Chelsio

2005-08-12 Thread David S. Miller
From: Scott Bardone [EMAIL PROTECTED] Date: Thu, 11 Aug 2005 23:16:14 -0700 - static was removed from functions '__tcp_inherit_port' '__tcp_v4_hash' because these are called outside of tcp_ipv4.c from the TOM driver. There is no way you're going to be allowed to call such deep TCP internals

Re: [PATCH] TCP Offload (TOE) - Chelsio

2005-08-12 Thread Mitchell Blank Jr
The networking gurus can comment on the internals of your patch better than I can. Just a few style notes though: +#ifdef CONFIG_TCP_OFFLOAD +#define NETIF_F_TCPIP_OFFLOAD65536 /* Can offload TCP/IP */ +#endif No need to protect this inside CONFIG_* option +/* TOE API */ +#ifdef

Re: [PATCH] TCP Offload (TOE) - Chelsio

2005-08-12 Thread Jeff Garzik
David S. Miller wrote: From: Scott Bardone [EMAIL PROTECTED] Date: Thu, 11 Aug 2005 23:16:14 -0700 - static was removed from functions '__tcp_inherit_port' '__tcp_v4_hash' because these are called outside of tcp_ipv4.c from the TOM driver. There is no way you're going to be allowed to

Re: atheros driver - desc

2005-08-12 Thread Chris Wedgwood
On Sun, Aug 07, 2005 at 05:01:34PM +0200, Harald Welte wrote: I will consult my legal counsel about this. My current naive position on this is that only the actuall process of the re-engineering matters, not the result. Which countries is this advice valid for? Does someone need to chase

Re: [PATCH] TCP Offload (TOE) - Chelsio

2005-08-12 Thread Mitchell Blank Jr
I'm fairly pessimistic about full TOE also, I just want to see the patch cleaned up a bit so we can see the exact impact it would have. The RX optimization work presented in the Neterion and Intel papers at OLS sounds a lot more interesting to me though. However, I do want to comment on one

[PATCH] Fix NET/ROM queue length

2005-08-12 Thread Ralf Baechle
NET/ROM uses virtual interfaces so setting a queue length is wrong. Signed-off-by: Ralf Baechle DL5RB [EMAIL PROTECTED] net/netrom/nr_dev.c |1 - 1 files changed, 1 deletion(-) Index: linux-cvs/net/netrom/nr_dev.c === ---

[PATCH 1/6][IPV6] Generalise the tcp_v6_lookup routines

2005-08-12 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ This is based on the discussions we had on the [EMAIL PROTECTED] about fully generalising tcp_diag, that is accomplished in this series of changesets without breaking

[PATCH 2/6][INET6_HASHTABLES] Move inet6_lookup functions to net/ipv4/inet6_hashtables.c

2005-08-12 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ This is based on the discussions we had on the [EMAIL PROTECTED] about fully generalising tcp_diag, that is accomplished in this series of changesets without breaking

[PATCH 3/6][TCPDIAG] Introduce inet_diag_{register,unregister}

2005-08-12 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ This is based on the discussions we had on the [EMAIL PROTECTED] about fully generalising tcp_diag, that is accomplished in this series of changesets without breaking

[PATCH 4/6][TCPDIAG] Just rename everything to inet_diag

2005-08-12 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ This is based on the discussions we had on the [EMAIL PROTECTED] about fully generalising tcp_diag, that is accomplished in this series of changesets without breaking

[PATCH 5/6][INET_DIAG] Rename tcp_diag.[ch] to inet_diag.[ch]

2005-08-12 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ This is based on the discussions we had on the [EMAIL PROTECTED] about fully generalising tcp_diag, that is accomplished in this series of changesets without breaking

[PATCH 6/6][INET_DIAG] Move the tcp_diag interface to the proper place

2005-08-12 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ This is based on the discussions we had on the [EMAIL PROTECTED] about fully generalising tcp_diag, that is accomplished in this series of changesets without breaking

Re: argh... ;/

2005-08-12 Thread John W. Linville
On Thu, Aug 11, 2005 at 10:36:34PM -0700, Chris Wedgwood wrote: On Fri, Aug 05, 2005 at 01:20:59PM -0400, John W. Linville wrote: Yes. Opening attachments makes them harder to review. Lots of people can't inline patches because they are inflicted with crappy MUAs --- I would much prefer

Re: [PATCH] add new iptables ipt_connbytes match

2005-08-12 Thread Patrick McHardy
Andi Kleen wrote: David S. Miller [EMAIL PROTECTED] writes: Won't work in x86 -- x86_64 compat environments. Thanks for catching it. The aligned u64 trick probably will #define aligned_u64 unsigned long long __attribute__((aligned(8))) It just forces i386 to be aligned too. Then

Re: atheros driver - desc

2005-08-12 Thread Harald Welte
On Fri, Aug 12, 2005 at 12:37:55AM -0700, Chris Wedgwood wrote: On Sun, Aug 07, 2005 at 05:01:34PM +0200, Harald Welte wrote: I will consult my legal counsel about this. My current naive position on this is that only the actuall process of the re-engineering matters, not the result.

Re: [PATCH] add new iptables ipt_connbytes match

2005-08-12 Thread Harald Welte
On Fri, Aug 12, 2005 at 04:52:49AM +0200, Patrick McHardy wrote: This functions looks broken. I feared it... Divisor and divident are mixed up, the shifted result variable is not used in the actual division, the first bit has to be 32 assumption is wrong and num_shift is calculated

Re: [PATCH 2/6][INET6_HASHTABLES] Move inet6_lookup functions to net/ipv4/inet6_hashtables.c

2005-08-12 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 12, 2005 at 09:09:53PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ escreveu: In article [EMAIL PROTECTED] (at Fri, 12 Aug 2005 08:40:24 -0300), [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) says: [INET6_HASHTABLES] Move inet6_lookup functions to net/ipv4/inet6_hashtables.c

Re: [PATCH 2/6][INET6_HASHTABLES] Move inet6_lookup functions to net/ipv4/inet6_hashtables.c

2005-08-12 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 12, 2005 at 09:12:36AM -0300, Arnaldo Carvalho de Melo escreveu: Em Fri, Aug 12, 2005 at 09:09:53PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ escreveu: In article [EMAIL PROTECTED] (at Fri, 12 Aug 2005 08:40:24 -0300), [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) says:

Re: Strange uses of netif_start_queue

2005-08-12 Thread Thomas Graf
* Ralf Baechle [EMAIL PROTECTED] 2005-08-12 14:39 On Fri, Aug 12, 2005 at 02:27:59PM +0100, Ralf Baechle wrote: Something I noticed doing the tty work. the 6pack driver calls netif_start_queue() before it calls register_netdev. I'm curious if this is allowed ? As part of adding

Re: argh... ;/

2005-08-12 Thread Chris Wedgwood
On Fri, Aug 12, 2005 at 07:44:28AM -0400, John W. Linville wrote: Don't use crappy MUAs? Well, plenty of people do. It's almost the norm so crappy probably isn't very fair. It does seem that most if the GUI-base MUAs though by default have problematic settings (Mozilla, Thunderbird,

[OT] Re: [PATCH] xfrm: do not use large arrays in BSS

2005-08-12 Thread Harald Welte
On Thu, Aug 11, 2005 at 02:44:11PM +0200, Balazs Scheidler wrote: On Thu, 2005-08-11 at 22:31 +1000, Herbert Xu wrote: Balazs Scheidler [EMAIL PROTECTED] wrote: I've attached a revised patch, this time with complete error checking, and propagating the error code to the caller.

Re: [PATCH 4/6][TCPDIAG] Just rename everything to inet_diag

2005-08-12 Thread James Morris
On Fri, 12 Aug 2005, Arnaldo Carvalho de Melo wrote: Please do NOT apply these changes to the SELinux code. These values are automatically generated and must be synchronized with userland policy. diff --git a/security/selinux/include/av_inherit.h b/security/selinux/include/av_inherit.h ---

Re: [PATCH 4/6][TCPDIAG] Just rename everything to inet_diag

2005-08-12 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 12, 2005 at 11:42:11AM -0400, James Morris escreveu: On Fri, 12 Aug 2005, Arnaldo Carvalho de Melo wrote: Please do NOT apply these changes to the SELinux code. These values are automatically generated and must be synchronized with userland policy. diff --git

Re: [PATCH 4/6][TCPDIAG] Just rename everything to inet_diag

2005-08-12 Thread James Morris
On Fri, 12 Aug 2005, Arnaldo Carvalho de Melo wrote: Here I go regenerating the tree, at least this one is closer to the end of the series... I'll just remove _all_ of the selinux related bits, OK? Lesson learned :-) Ok, and I'll send a patch to make SELinux compile again :-) - James --

Re: [PATCH] add new iptables ipt_connbytes match

2005-08-12 Thread Harald Welte
On Fri, Aug 12, 2005 at 02:03:20PM +0200, Andi Kleen wrote: Unfortunately one of the iptables structures which is needed to get the ruleset in the kernel (ipt_replace) is differently sized when compiled for 32/64 bit. IIRC it doesn't work at all currently. Yes that's the old bug and

Fw: [Bug 5050] New: KERNEL: assertion (cnt = tp-packets_out) failed at net/ipv4/tcp_input.c (1476)

2005-08-12 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 12 Aug 2005 06:14:57 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bug 5050] New: KERNEL: assertion (cnt = tp-packets_out) failed at net/ipv4/tcp_input.c (1476) http://bugzilla.kernel.org/show_bug.cgi?id=5050 Summary: KERNEL:

Re: [OT] Re: [PATCH] xfrm: do not use large arrays in BSS

2005-08-12 Thread Harald Welte
On Fri, Aug 12, 2005 at 06:14:39PM +0200, Balazs Scheidler wrote: Whenever I want to sync the upstream tree, i ln -sf .git/refs/heads/master .git/HEAD; cg-update origin Sorry, there is a cg-reset missing between the ln and the cg-update -- - Harald Welte [EMAIL PROTECTED]

Re: [PATCH] TCP Offload (TOE) - Chelsio

2005-08-12 Thread David S. Miller
From: Dimitris Michailidis [EMAIL PROTECTED] Date: Fri, 12 Aug 2005 10:22:47 -0700 This is true. There is nothing fundamentally preventing both passive and active opens to check netfilter before OKing a connection. Once a connection is established, it's rather impractical to run each of its

Re: [PATCH] add new iptables ipt_connbytes match

2005-08-12 Thread Andi Kleen
I don't think that we're ever going to fix that bug in the old {get,set}sockopt interface, but rather introduce a netlink interface when pkt_tables matures. All new interfaces should be emulation clean, so that if the old interface is replaced later it should eventually work. The best way to

Re: [PATCH] TCP Offload (TOE) - Chelsio

2005-08-12 Thread David S. Miller
From: Dimitris Michailidis [EMAIL PROTECTED] Date: Fri, 12 Aug 2005 10:00:12 -0700 On 8/12/05, David S. Miller [EMAIL PROTECTED] wrote: This would mean that every time we wish to change the data structures and interfaces for TCP socket lookup, your drivers would need to change. I think

Re: [PATCH 4/6][TCPDIAG] Just rename everything to inet_diag

2005-08-12 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Fri, 12 Aug 2005 13:17:36 -0300 Just checked: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Has the reworked, not touching selinux tree We might have to reneg on changing things from tcpdiag to inetdiag,

Re: [PATCH] add new iptables ipt_connbytes match

2005-08-12 Thread Harald Welte
On Fri, Aug 12, 2005 at 08:23:55PM +0200, Andi Kleen wrote: I don't think that we're ever going to fix that bug in the old {get,set}sockopt interface, but rather introduce a netlink interface when pkt_tables matures. All new interfaces should be emulation clean, so that if the old

Re: [PATCH 4/6][TCPDIAG] Just rename everything to inet_diag

2005-08-12 Thread Arnaldo Carvalho de Melo
On 8/12/05, David S. Miller [EMAIL PROTECTED] wrote: From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Fri, 12 Aug 2005 13:17:36 -0300 Just checked: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Has the reworked, not touching selinux tree We might

Re: [PATCH] add new iptables ipt_connbytes match

2005-08-12 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Fri, 12 Aug 2005 21:03:43 +0200 Ok, I hope everyone is fine with this patch: It is, but I did not add the connbytes patch into my tree so I can't use this patch as-is. That's why I replied this is broken, fix u64 alignment to the connbytes patch

[PATCH 2.6.13-rc6 1/2]netdevice ethtool: Add support for getting the permanent hardware address (resend)

2005-08-12 Thread Jon Wetzel
Adds a new field to net device to hold the permanent hardware address, and adds a new generic ethtool_op function to get that address. Signed-off-by: Jon Wetzel [EMAIL PROTECTED] Signed-off-by: John W. Linville [EMAIL PROTECTED] --- linux-2.6.13-rc6/include/linux/netdevice.h 2005-08-12

Re: [PATCH 2.6.13-rc6 1/2]netdevice ethtool: Add support for getting the permanent hardware address (resend)

2005-08-12 Thread David S. Miller
From: Jon Wetzel [EMAIL PROTECTED] Date: Fri, 12 Aug 2005 15:52:28 -0500 Adds a new field to net device to hold the permanent hardware address, and adds a new generic ethtool_op function to get that address. Signed-off-by: Jon Wetzel [EMAIL PROTECTED] Signed-off-by: John W. Linville [EMAIL

[PATCH 2.6.13-rc6 2/2]e1000: Add support for getting the permanent hardware address (correction)

2005-08-12 Thread Jon Wetzel
Accidentally sent an old version of this patch. This is the current one. e1000 driver updated to fill in the new field in netdevice and use the new ethtool, get_perm_addr. Signed-off-by: Jon Wetzel [EMAIL PROTECTED] Signed-off-by: John W. Linville [EMAIL PROTECTED] ---

Re: [PATCH 4/6][TCPDIAG] Just rename everything to inet_diag

2005-08-12 Thread Arnaldo Carvalho de Melo
On 8/12/05, David S. Miller [EMAIL PROTECTED] wrote: From: James Morris [EMAIL PROTECTED] Date: Fri, 12 Aug 2005 15:00:49 -0400 (EDT) Just do what you think is right for the core networking and we'll adjust SELinux accordingly. Ok, I've pulled in Arnaldo's changes, as-is. Thanks! -

Re: skb-pkt_type

2005-08-12 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 10 Aug 2005 02:18:46 +0200 BTW, an idea to make room for ipvs_property would be to place the three nfctinfo bits in the lower three bits of the nfct pointer. I'm not sure if it guarantees 8 byte alignemnt, which would be required for this to

Re: Fw: [Bug 5050] New: KERNEL: assertion (cnt = tp-packets_out) failed at net/ipv4/tcp_input.c (1476)

2005-08-12 Thread Herbert Xu
On Fri, Aug 12, 2005 at 09:15:44AM -0700, Stephen Hemminger wrote: Steps to reproduce: System is running 2 days and after that time produce this message KERNEL: assertion (cnt = tp-packets_out) failed at net/ipv4/tcp_input.c (1476) KERNEL: assertion (cnt = tp-packets_out) failed at

[RFC NETLINK 0/8]: Support dynamic number of groups

2005-08-12 Thread Patrick McHardy
Hi, besides a small bugfix, this patchset adds support for dynamic number of groups to netlink. To support an arbitary number of groups a couple of changes had to me made, I'll explain them below. The patches are only sent to netdev to avoid spamming your inboxes. The destination groups of a

[NETLINK 1/8]: Fix module refcounting problems

2005-08-12 Thread Patrick McHardy
[NETLINK]: Fix module refcounting problems Use-after-free: the struct proto_ops containing the module pointer is freed when a socket with pid=0 is released, which besides for kernel sockets is true for all unbound sockets. Module refcount leak: when the kernel socket is closed before all user

[NETLINK 4/8]: Convert netlink users to use group numbers instead of bitmasks

2005-08-12 Thread Patrick McHardy
[NETLINK]: Convert netlink users to use group numbers instead of bitmasks Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit a8a8c74ef1b37254f920103a6ce70237a6a55dab tree c8decf70f15805fc7c23bee441b2ce8b14e7b264 parent 5c34a3fbc1e62fc90db80f148e07ea7817013dca author Patrick McHardy

[NETLINK 2/8]: Remove unused groups member from struct netlink_skb_parms

2005-08-12 Thread Patrick McHardy
[NETLINK]: Remove unused groups member from struct netlink_skb_parms Signed-off-by: Patrick McHardy [EMAIL PROTECTED],net --- commit 910f9b156d87a1d9d013985ce3973b9a0d27dbd6 tree a430be569a7d7c79088d7b830a57e31c98f95060 parent 1f74632caaf6f2bf31cf02ac28c5087e4224b02e author Patrick McHardy

[NETLINK 6/8]: Support dynamic number of multicast groups per netlink family

2005-08-12 Thread Patrick McHardy
[NETLINK]: Support dynamic number of multicast groups per netlink family Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit a5314b2c777dc032b93f4f068ab1759f5610999f tree 68571754baf232d5c76b15ec7e270b4af058867a parent 2b1cc05d6484d70aae14d869730f8ce959ed7bdd author Patrick McHardy

[NETLINK 8/8]: Add groups argument to netlink_kernel_create

2005-08-12 Thread Patrick McHardy
[NETLINK]: Add groups argument to netlink_kernel_create Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 5719d60b114683e7c1bf1aa9a553efb641184e1b tree c6a56c893ae404e6767f3cefbebd2a88a2981775 parent c366740a65d35924ee4efce970db8a738dd4b384 author Patrick McHardy [EMAIL PROTECTED]

[NETLINK 5/8]: Return -EPROTONOSUPPORT in netlink_create() if no kernel socket is registered

2005-08-12 Thread Patrick McHardy
[NETLINK]: Return -EPROTONOSUPPORT in netlink_create() if no kernel socket is registered This is necessary for dynamic number of netlink groups to make sure we know the number of possible groups before bind() is called. With this change pure userspace communication using unused netlink protocols

skb-stamp conversion missing from latest net-2.6.14

2005-08-12 Thread Patrick McHardy
Hi Dave, I just wanted to make the patch to break compilation for unconverted code for the skb-stamp change and noticed that the patch is missing from your latest net-2.6.14 tree. Is this deliberate or did it get lost? - To unsubscribe from this list: send the line unsubscribe netdev in the body