Re: [Netlink] virtual interface

2006-01-25 Thread Robert Iakobashvili
Hi Mathieu, > Here is a patch that add a netlink virtual interface. > Through a hook in af_netlink.c every packets are duplicated and sent to > that interface. Thus userspace sniffers can capture them. Looks like an interesting direction. Do you think, that such approach may be extended to unix-

Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-25 Thread Stefan Rompf
Am Mittwoch 25 Januar 2006 07:18 schrieb Zhu Yi: > > This is what leads to the high ksoftirqd usage I reported October 2005 > > into the ipw bugzilla > > (http://www.bughost.org/bugzilla/show_bug.cgi?id=825). > > Sorry, I'm not aware of this bug since I'm not on the cc list. Hmm, frankly the ipw

Re: e100 oops on resume

2006-01-25 Thread Olaf Kirch
On Wed, Jan 25, 2006 at 12:21:42AM +0100, Mattia Dongili wrote: > I experienced the same today, I was planning to get a photo tomorrow :) > I'm running 2.6.16-rc1-mm2 and the last working kernel was 2.6.15-mm4 > (didn't try .16-rc1-mm1 being scared of the reiserfs breakage). I think that's because

Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-25 Thread Stefan Rompf
Am Mittwoch 25 Januar 2006 07:55 schrieb James Ketrenos: > The purpose for this code ever coming into existence within ieee80211 > was based on discussions at OLS this past year in how to support for the > ability to start/stop independent Tx queues within a single net device > in order to support

Re: [Netlink] virtual interface

2006-01-25 Thread Mathieu Geli
> Do you think, that such approach may be extended to unix-domain > traffic as well, or there are other ways to sniff such packets? I don't know if similar things exists or have existed for UNIX sockets. That could be useful having an infrastructure that'll enable to redirect certain socket type t

Re: Fw: [Bugme-new] [Bug 5936] New: Openswan tunnels + netfilter problem

2006-01-25 Thread Patrick McHardy
Herbert Xu wrote: > Patrick McHardy <[EMAIL PROTECTED]> wrote: > >>Andrew Morton wrote: >> >>>http://bugzilla.kernel.org/show_bug.cgi?id=5936 >> >>Please post your iptables rules and the full list of loaded modules. > > > The problem is caused by SNAT on a dst that already has an xfrm set. > Whe

Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-25 Thread Patrick McHardy
Stefan Rompf wrote: > Am Mittwoch 25 Januar 2006 07:55 schrieb James Ketrenos: > > >>The purpose for this code ever coming into existence within ieee80211 >>was based on discussions at OLS this past year in how to support for the >>ability to start/stop independent Tx queues within a single net d

Re: [Patch 2.6.15] starfire: Implement suspend/resume

2006-01-25 Thread Stefan Rompf
Am Dienstag 17 Januar 2006 22:52 schrieb Stefan Rompf: > This patch implements suspend and resume methods for the starfire driver. > It allows me to put my desktop PC with a starfire dual board into S4. Jeff, all email addresses of Ionut Badulescu I am aware of (<[EMAIL PROTECTED]> and <[EMAIL P

Re: Fw: [Bugme-new] [Bug 5936] New: Openswan tunnels + netfilter problem

2006-01-25 Thread Herbert Xu
On Wed, Jan 25, 2006 at 10:25:27AM +0100, Patrick McHardy wrote: > > I don't like adding this special behaviour for NAT, people need > to adjust their rulesets for filtering etc. anyway. We could stop > rerouting packets in between transforms (when both dst->xfrm and > IPSKB_XFRM_TRANSFORMED are s

Re: driver skb reuse

2006-01-25 Thread jamal
On Tue, 2006-24-01 at 14:23 +0100, Robert Olsson wrote: > Hello! > We disussed the resue of skb's some time ago. > > Below some code to examine how skb's can be reused if upper layer (RX > softirq) > can consume the skb so we with in NAPI path can detect and reuse the skb. It > can give new po

Re: e100 oops on resume

2006-01-25 Thread Olaf Kirch
On Wed, Jan 25, 2006 at 10:02:40AM +0100, Olaf Kirch wrote: > I'm not sure what the right fix would be. e100_resume would probably > have to call e100_alloc_cbs early on, while e100_up should avoid > calling it a second time if nic->cbs_avail != 0. A tentative patch > for testing is attached. Repo

Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-25 Thread jamal
On Wed, 2006-25-01 at 10:24 +0100, Stefan Rompf wrote: > Am Mittwoch 25 Januar 2006 07:55 schrieb James Ketrenos: > > > Jamal indicated we should just return NETDEV_TX_BUSY and the stack would > > take care of rescheduling... > > well so even Jamal can be wrong sometimes ;-) > I am never wron

Re: [PATCH] sky2: allow setting MAC address w/o reinitializing PHY

2006-01-25 Thread John W. Linville
On Wed, Jan 25, 2006 at 10:08:26AM -0500, John W. Linville wrote: > Using the sky2 driver with bonding can result in oopses related to > reinitializing the PHY when the MAC address is changed (which bonding > is wont to do). This patch changes sky2_set_mac_address to take less > drastic measures.

[PATCH] sky2: allow setting MAC address w/o reinitializing PHY

2006-01-25 Thread John W. Linville
Using the sky2 driver with bonding can result in oopses related to reinitializing the PHY when the MAC address is changed (which bonding is wont to do). This patch changes sky2_set_mac_address to take less drastic measures. This is analagous to the skge patch here: http://lkml.org/lkml/2

Re: [PATCH] Additional options for resetting packet statistics

2006-01-25 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Tue, 24 Jan 2006 16:38:26 -0800), "Kris Katterjohn" <[EMAIL PROTECTED]> says: > + if (optlen != sizeof val) sizeof(val) Please use "sizeof(foo)" instead of "sizeof foo". > --- x/include/linux/if_packet.h

Re: [softmac-dev] [PATCH] ieee80211_rx_any: filter out packets, call ieee80211_rx or ieee80211_rx_mgt

2006-01-25 Thread Stuffed Crust
On Mon, Jan 23, 2006 at 03:32:32PM +0100, Johannes Berg wrote: > Shouldn't you BSS-filter management packets too? Filtering on BSSID is necessary for management frames, especially when multicast management frames are thrown into the mix. For example, STAs are supposed to respect broadcast disa

Re: [PATCH] Additional options for resetting packet statistics

2006-01-25 Thread Kris Katterjohn
From: YOSHIFUJI Hideaki Sent: 1/25/2006 7:32:09 AM > Hello. > > In article <[EMAIL PROTECTED]> (at Tue, 24 Jan 2006 16:38:26 -0800), "Kris > Katterjohn" <[EMAIL PROTECTED]> says: > > > + if (optlen != sizeof val) > sizeof(val) > > Please use "sizeof(foo)"

Strange cwnd history

2006-01-25 Thread Baruch Even
Hi, I'm testing Linux 2.6.16-rc1-git4 on a 500Mbps line with 220ms rtt. I'm getting a very strange cwnd history and was wondering if anyone noticed it before and knows why it happens. A graph is attached and you can find a resizable version at http://hamilton.ie/person/baruch/linet/ The changes I

IPv6: to take care of permanent routes

2006-01-25 Thread Jean-Mickael Guerin
Hi, When adding a route, expiration attribute may be 0. In my understanding, it means the route never expires and rt6i_expires should be 0, and not the current time. If right, attached patch should fix the issue. Regards, Jean-Mickael Signed-off-by: [EMAIL PROTECTED] --- route.c.orig

Re: [PATCH] sky2: fix hang on Yukon-EC (0xb6) rev 1

2006-01-25 Thread Carl-Daniel Hailfinger
Carl-Daniel Hailfinger schrieb: > Stephen Hemminger schrieb: > >>On Tue, 24 Jan 2006 14:19:56 +0100 >>Carl-Daniel Hailfinger <[EMAIL PROTECTED]> wrote: >> >> >> >>>This patch for sky2 fixes a hang on Yukon-EC (0xb6) rev 1 >>>where suddenly no more interrupts were delivered. >>> >>>I don't know the

Re: e100 oops on resume

2006-01-25 Thread Jesse Brandeburg
On 1/25/06, Olaf Kirch <[EMAIL PROTECTED]> wrote: > On Wed, Jan 25, 2006 at 10:02:40AM +0100, Olaf Kirch wrote: > > I'm not sure what the right fix would be. e100_resume would probably > > have to call e100_alloc_cbs early on, while e100_up should avoid > > calling it a second time if nic->cbs_avai

[PATCH 2.6.16-rc1] S2io: Large Receive Offload (LRO) feature(v2) for Neterion (s2io) 10GbE Xframe PCI-X and PCI-E NICs

2006-01-25 Thread Ravinandan Arakali
Hi, Below is a patch for the Large Receive Offload feature. Please review and let us know your comments. LRO algorithm was described in an OLS 2005 presentation, located at ftp.s2io.com user: linuxdocs password: HALdocs The same ftp site has Programming Manual for Xframe-I ASIC. LRO feature is su

Re: driver skb reuse

2006-01-25 Thread Benjamin LaHaise
On Tue, Jan 24, 2006 at 10:35:06PM +0100, Robert Olsson wrote: > I splitted alloc_skb in two parts to get the memset() part even done > in the driver just before passing the skb to the stack. > > I did expect a big win in but I didn't see any gain. Strange but the code > was bad so it might

Re: driver skb reuse

2006-01-25 Thread Robert Olsson
jamal writes: > > Here we process (drop) about 13% packets more when skb'a get reued. > > > Very cool. > Robert, it would be interesting to see something more interesting > (longer code path) such as udp. You can still use a packetgen to shoot > at the box (netperf is a wimp), send it to

[PATCH] ipv6 tcp_v6_send_synack: release the destination

2006-01-25 Thread Eric W. Biederman
This patch fix dst reference counting in tcp_v6_send_synack Analysis: Currently tcp_v6_send_synack is never called with a dst entry so dst always comes in as NULL. ip6_dst_lookup calls ip6_route_output which calls dst_hold before it returns the dst entry. Neither xfrm_lookup nor tcp_make_synac

[PATCH] ipv6: addrconf_ifdown fix dst refcounting.

2006-01-25 Thread Eric W. Biederman
By bringing down the routes before we bring down the addresses we leak the dst cache entries held by the addresses. For address on an interface there is an associated input route. When we bring that address down we call ipv6_ifa_notify(RTM_DELADDR, ifa). ipv6_ifa_notify will then call ip6_del_r

wireless-2.6 status (25 January 2006)

2006-01-25 Thread John W. Linville
All, This note is just to let you know what is going-on w/ the wireless-2.6 tree, now available here: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git You may have seen the pull requests I have sent to Jeff Garzik. I am actively merging patches for the code already

Re: e100 oops on resume

2006-01-25 Thread Olaf Kirch
On Wed, Jan 25, 2006 at 11:37:40AM -0800, Jesse Brandeburg wrote: > its an interesting patch, but it raises the question why does > e100_init_hw need to be called at all in resume? I looked back > through our history and that init_hw call has always been there. I > think its incorrect, but its ta

Re: [PATCH] ipv6: addrconf_ifdown fix dst refcounting.

2006-01-25 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 13:12:02 -0700), [EMAIL PROTECTED] (Eric W. Biederman) says: > By bringing down the routes before we bring down the addresses we leak > the dst cache entries held by the addresses. : > Fix this by simply moving rt6_ifdown where we flush the rout

Re: [PATCH] Additional options for resetting packet statistics

2006-01-25 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 09:13:26 -0800), "Kris Katterjohn" <[EMAIL PROTECTED]> says: > + > + case PACKET_ACCUMULATE_STATISTICS: > + { > + int val; > + > + if (optlen != sizeof(val)) > + return -EINVAL; I thi

[PATCH (ready to apply?)] Additional options for resetting packet statistics

2006-01-25 Thread Kris Katterjohn
From: YOSHIFUJI Hideaki Sent: 1/25/2006 1:34:19 PM > Hello. > > In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 09:13:26 -0800), "Kris > Katterjohn" <[EMAIL PROTECTED]> says: > > > > + > > + case PACKET_ACCUMULATE_STATISTICS: > > + { > > + int val; > > + > > + if (op

Re: driver skb reuse

2006-01-25 Thread Robert Olsson
Benjamin LaHaise writes: > Right. Btw, looking over your changes for skb reuse and how the e1000 > lays out its data structures, I think there is still some room for > improvement: currently you still touch the skb that the e1000 used to > allocate the receive buffers in. That cacheline

Re: [PATCH 2.6.15-git9a] aoe [1/1]: do not stop retransmit timer when device goes down

2006-01-25 Thread Al Boldi
Ed L. Cashin wrote: > This patch is a bugfix that follows and depends on the > eight aoe driver patches sent January 19th. Will they also fix this? Or is this an md bug? It only happens with aoe. Also, why is aoe slower than nbd? md: bind [ cut here ] kernel BUG at fs/sysf

Re: e100 oops on resume

2006-01-25 Thread Jesse Brandeburg
On 1/25/06, Olaf Kirch <[EMAIL PROTECTED]> wrote: > On Wed, Jan 25, 2006 at 11:37:40AM -0800, Jesse Brandeburg wrote: > > its an interesting patch, but it raises the question why does > > e100_init_hw need to be called at all in resume? I looked back > > through our history and that init_hw call h

Re: RCU latency regression in 2.6.16-rc1

2006-01-25 Thread Lee Revell
On Wed, 2006-01-25 at 23:56 +0100, Ingo Molnar wrote: > > yes, that would be a nice test. (I'm busy now with mutex stuff to be > able to do a working softirq-preemption patch, but i sent you my > current patches off-list - if you want to give it a shot. Be warned > though, there will likely be qu

Re: e1000 question

2006-01-25 Thread Jesse Brandeburg
On 1/23/06, JaniD++ <[EMAIL PROTECTED]> wrote: > Hello, list, > > I using some servers on the same network, and the new (6.2.15) driver works > better for me. > But i have one (and most important) server, that cannot use this driver, > because need to booting from it. > > First i think the initrd ,

Re: e100 oops on resume

2006-01-25 Thread Jesse Brandeburg
On 1/25/06, Jesse Brandeburg <[EMAIL PROTECTED]> wrote: > On 1/25/06, Olaf Kirch <[EMAIL PROTECTED]> wrote: > > On Wed, Jan 25, 2006 at 10:02:40AM +0100, Olaf Kirch wrote: > > > I'm not sure what the right fix would be. e100_resume would probably > > > have to call e100_alloc_cbs early on, while e1

[PATCH 7/9] sky2: let irq add to entropy

2006-01-25 Thread Stephen Hemminger
The sky2 interrupt can be used to add entropy. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-1.0.orig/drivers/net/sky2.c +++ sky2-1.0/drivers/net/sky2.c @@ -3165,7 +3165,8 @@ static int __devinit sky2_probe(struct p } } - err = request_irq(pdev->irq, sky2_intr, SA_S

[PATCH 2/9] sky2: suspend/resume fix up

2006-01-25 Thread Stephen Hemminger
Fix suspend/resume for sky2. The status ring was getting reallocated and a bunch of other mistakes. Also, check return from power_state on resume. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-1.0.orig/drivers/net/sky2.c +++ sky2-1.0/drivers/net/sky2.c @@ -26,7 +26,6 @@ /* * TOTE

[PATCH 8/9] sky2: use MSI

2006-01-25 Thread Stephen Hemminger
This hardware supports Message Signaled interrupts so use them. Signed-off-by: Stephen Hemminger --- git-2.6.orig/drivers/net/sky2.c 2006-01-25 10:42:16.0 -0800 +++ git-2.6/drivers/net/sky2.c 2006-01-25 12:59:30.0 -0800 @@ -3165,6 +3165,9 @@ } } + if (pci_enab

[PATCH 4/9] sky2: transmit irq clear ordering

2006-01-25 Thread Stephen Hemminger
Move the interrupt clear to before processing, this avoids a possible transmit races. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-1.0.orig/drivers/net/sky2.c +++ sky2-1.0/drivers/net/sky2.c @@ -1833,6 +1833,8 @@ static int sky2_poll(struct net_device * u16 hwidx; u16 tx_done[2]

[PATCH 0/9] sky2: version 0.14

2006-01-25 Thread Stephen Hemminger
Mostly a collection of bug fixes. The most critical is the pci express fix. Also adds Message Signaled Interrupt and entropy support. -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[PATCH 9/9] sky2: version 0.14

2006-01-25 Thread Stephen Hemminger
Speed setting has been tested, and label this bundle. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- git-2.6.orig/drivers/net/sky2.c 2006-01-25 16:21:43.0 -0800 +++ git-2.6/drivers/net/sky2.c 2006-01-25 16:22:06.0 -0800 @@ -23,11 +23,6 @@ * Foundation, Inc., 675 M

[PATCH 3/9] sky2: rx_coalesce_usecs_irq parameter

2006-01-25 Thread Stephen Hemminger
This fixes setting rx_coalesce_usecs_irq via ethtool in sky2. The write was directed to the wrong register. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]> --- sky2-1.0.orig/drivers/net/sky2.c +++ sky2-1.0/drivers/net/sky2.c @@ -2827,

[PATCH 6/9] sky2: set mac address fix

2006-01-25 Thread Stephen Hemminger
Using the sky2 driver with bonding can result in oopses related to reinitializing the PHY when the MAC address is changed (which bonding is wont to do). This patch changes sky2_set_mac_address to take less drastic measures. This is analagous to the skge patch here: http://lkml.org/lkml/2005/9/29

[PATCH 5/9] sky2: minor cleanup in power_state and remove dead code

2006-01-25 Thread Stephen Hemminger
Minor optimization and cleanup. Local pointer in one place, and remove now dead inline. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-1.0.orig/drivers/net/sky2.c +++ sky2-1.0/drivers/net/sky2.c @@ -188,6 +188,7 @@ static u16 gm_phy_read(struct sky2_hw *h static int sky2_set_pow

[PATCH 1/9] sky2: pci express config register access

2006-01-25 Thread Stephen Hemminger
The sky2 driver attempts to clear PCI express errors on boot, but the PCI subsystem sometimes won't let the sky2 driver write to PCI express registers. It depends on the phase of the moon and number of goats sacrificed (actually it probably is ACPI). Until the PCI subsystem is fixed, this patch u

Re: [PATCH] ipv6 tcp_v6_send_synack: release the destination

2006-01-25 Thread Herbert Xu
Eric W. Biederman <[EMAIL PROTECTED]> wrote: > > This patch fix dst reference counting in tcp_v6_send_synack > > Analysis: > Currently tcp_v6_send_synack is never called with a dst entry > so dst always comes in as NULL. Thanks for the bug fix. BTW, why don't we get rid of the dst argument to r

Re: [PATCH (ready to apply?)] Additional options for resetting packet statistics

2006-01-25 Thread Herbert Xu
Kris Katterjohn <[EMAIL PROTECTED]> wrote: > > @@ -1021,6 +1025,7 @@ static int packet_create(struct socket * >po = pkt_sk(sk); >sk->sk_family = PF_PACKET; >po->num = protocol; > + po->accumulate_stats = 0; This is unnecessary as sk_alloc zeros the whole structure. C

Re: [PATCH (ready to apply?)] Additional options for resetting packet statistics

2006-01-25 Thread jamal
On Wed, 2006-25-01 at 13:57 -0800, Kris Katterjohn wrote: > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> > > --- x/net/packet/af_packet.c 2006-01-25 15:48:17.0 -0600 > +++ y/net/packet/af_packet.c 2006-01-25 15:48:12.0 -0600 > @@ -41,6 +41,9 @@ > *

Re: [PATCH (ready to apply?)] Additional options for resettingpacket statistics

2006-01-25 Thread Kris Katterjohn
From: Herbert Xu Sent: 1/25/2006 6:45:50 PM > Kris Katterjohn <[EMAIL PROTECTED]> wrote: > > > > @@ -1021,6 +1025,7 @@ static int packet_create(struct socket * > >po = pkt_sk(sk); > >sk->sk_family = PF_PACKET; > >po->num = protocol; > > + po->accumulate_stats = 0; > >

Re: [PATCH (ready to apply?)] Additional options for resettingpacket statistics

2006-01-25 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 19:46:07 -0800), "Kris Katterjohn" <[EMAIL PROTECTED]> says: > @@ -1399,6 +1423,17 @@ static int packet_getsockopt(struct sock > return -EINVAL; > > switch(optname) { > + case PACKET_ACCUMULATE_STATISTICS:

Re: [PATCH (ready to apply?)] Additional options forresettingpacket statistics

2006-01-25 Thread Kris Katterjohn
From: YOSHIFUJI Hideaki Sent: 1/25/2006 7:50:55 PM > In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 19:46:07 -0800), "Kris > Katterjohn" <[EMAIL PROTECTED]> says: > > > @@ -1399,6 +1423,17 @@ static int packet_getsockopt(struct sock > > return -EINVAL; > > > > sw

Re: [PATCH (ready to apply?)] Additional options forresettingpacket statistics

2006-01-25 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 20:25:56 -0800), "Kris Katterjohn" <[EMAIL PROTECTED]> says: > Okey-dokey. > > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > --- x/net/packet/af_packet.c 2006-01-25 22:18:41.