Re: TSO & chelsio T210 problems with 2.6.15

2006-01-31 Thread Ben Greear
Ben Greear wrote: There is most likely a problem with the chelsio T210 driver (not in kernel yet) and/or the TSO support in 2.6.15. Ok, maybe it isn't TSO. I tried MTU of 4000 just for grins, and it had the same lockup and ACK storm, even though TSO was off. -- Ben Greear <[EMAIL PROTECTED]>

Re: net-2.6.17.git crashes

2006-01-31 Thread Andrew Morton
"David S. Miller" <[EMAIL PROTECTED]> wrote: > > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Sat, 28 Jan 2006 17:22:40 -0800 > > > David, your tree > > git+ssh://master.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.17.git > > is oopsing all over the place. Reverting "[NET]: Do not los

TSO & chelsio T210 problems with 2.6.15

2006-01-31 Thread Ben Greear
There is most likely a problem with the chelsio T210 driver (not in kernel yet) and/or the TSO support in 2.6.15. I built 2.6.15 with only my send-to-self patch included to enable my tests: http://www.candelatech.com/oss/sts.patch I am running two connections at about 500Mbps tx and rx between t

Re: 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error

2006-01-31 Thread Denis Vlasenko
On Wednesday 01 February 2006 00:16, Adrian Bunk wrote: > > > > CONFIG_ACX=y > > > > # CONFIG_ACX_PCI is not set > > > > # CONFIG_ACX_USB is not set > > > > > > > > This won't fly. You must select at least one. > > > > > > > > Attached patch will check for this and #error out. > > > > Andrew, do

Re: sungem PHY changes break sparc64

2006-01-31 Thread Benjamin Herrenschmidt
On Tue, 2006-01-31 at 17:07 -0800, David S. Miller wrote: > Sun GEM's die with your recent sungem driver changes. > > I'm talking about: > > [SUNGEM]: Make PM of PHYs more reliable (#2) > > On my latest laptop, I've had occasional PHY dead on wakeup from > sleep... the PHY would be t

Re: [PATCH 3/4] bnx2: Support larger rx ring sizes

2006-01-31 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 31 Jan 2006 21:58:23 -0800 > How about 1024 (actually 1020)? tg3 has a max. of 511 standard plus > 255 jumbo rx descriptors. bnx2 runs at a higher maximum line speed > of 2.5Gbps so I think it's reasonable to allow a little more for bnx2. Ok. -

Re: [PATCH 3/4] bnx2: Support larger rx ring sizes

2006-01-31 Thread Michael Chan
Rick Jones wrote: > rx_64_or_less_octet_packets: 86 > rx_65_to_127_octet_packets: 821370383 > rx_128_to_255_octet_packets: 630 > rx_256_to_511_octet_packets: 3035 You're doing small packet test. > dma_writeq_full: 140800 This usually means overruning host rx buffer

Re: [PATCH 3/4] bnx2: Support larger rx ring sizes

2006-01-31 Thread Michael Chan
David S. Miller wrote: > How about we compromise and cap the limit at 512 (or 511) max > RX descriptors? > > How about 1024 (actually 1020)? tg3 has a max. of 511 standard plus 255 jumbo rx descriptors. bnx2 runs at a higher maximum line speed of 2.5Gbps so I think it's reasonable to allow a li

Re: [RFC] Poor Network Performance with e1000 on 2.6.14.3

2006-01-31 Thread Ashutosh Naik
On 2/1/06, Ben Greear <[EMAIL PROTECTED]> wrote: > Ashutosh Naik wrote: > > Now, I assume that on Gigabit ethernet, I should be getting Line Rate, > > which is around 220 MBps. Even the CPU is not getting max-ed out here > > and I am at a loss to understand this behaviour. > > Make sure you are run

Re: [RFC] Poor Network Performance with e1000 on 2.6.14.3

2006-01-31 Thread Ben Greear
Ashutosh Naik wrote: My configuration is two Dell Optiplex PCs ( /proc/cpuinfo attached) connected back to back.. I am using the vanilla 2.6.14.3 kernel, and using the e1000 driver for the onboard Intel PRO 1000 Ethernet Card on both machines. I am performing both Full and Half Duplex Data Trans

Re: [PATCH]ip_options_fragment() has no effect on fragmentation

2006-01-31 Thread Wei Yongjun
Resend Patch: --- linux-2.6.15.1/net/ipv4/ip_options.c.orig 2006-01-27 09:14:33.463612696 +0900 +++ linux-2.6.15.1/net/ipv4/ip_options.c2006-01-27 09:12:21.857619848 +0900 @@ -207,7 +207,7 @@ void ip_options_fragment(struct sk_buff * skb) { - unsigned char * optptr = skb->nh.ra

[RFC] Poor Network Performance with e1000 on 2.6.14.3

2006-01-31 Thread Ashutosh Naik
My configuration is two Dell Optiplex PCs ( /proc/cpuinfo attached) connected back to back.. I am using the vanilla 2.6.14.3 kernel, and using the e1000 driver for the onboard Intel PRO 1000 Ethernet Card on both machines. I am performing both Full and Half Duplex Data Transfer and the figures wh

[PATCH] Remove suprious use of goto out: in icmp_reply

2006-01-31 Thread Horms
This seems to be an artifact of the follwoing commit in February '02. http://www.kernel.org/git/?p=linux/kernel/git/tglx/history.git;a=history;h=e7e173af42dbf37b1d946f9ee00219cb3b2bea6a;f=net/ipv4/icmp.c In a nutshell, goto out and return actually do the same thing, and both are called in this fun

Re: [PATCH] 1/1 net/core: use USEC_PER_SEC and line spacing

2006-01-31 Thread Herbert Xu
Ian McDonald <[EMAIL PROTECTED]> wrote: > > --- a/net/core/sock.c > +++ b/net/core/sock.c > @@ -162,7 +162,8 @@ static int sock_set_timeout(long *timeo_ >if (tv.tv_sec == 0 && tv.tv_usec == 0) >return 0; >if (tv.tv_sec < (MAX_SCHEDULE_TIMEOUT/HZ - 1)) > -

Re: [PATCH] ipv6 tcp_v6_send_synack: release the destination

2006-01-31 Thread Eric W. Biederman
"David S. Miller" <[EMAIL PROTECTED]> writes: > From: [EMAIL PROTECTED] (Eric W. Biederman) > Date: Wed, 25 Jan 2006 13:08:53 -0700 > >> Analysis: >> Currently tcp_v6_send_synack is never called with a dst entry >> so dst always comes in as NULL. >> >> ip6_dst_lookup calls ip6_route_output which

Re: [RFC] TCP/IPV4 and e1000 does not grow window

2006-01-31 Thread David S. Miller
From: Jesse Brandeburg <[EMAIL PROTECTED]> Date: Tue, 31 Jan 2006 18:59:37 -0800 (Pacific Standard Time) > 21: rcv_ssthresh = 63712 window_clamp: 98464 > winfrmspc: 1404 <= skblen: 1448 incr: 2896 > 21: rcv_ssthresh = 66608 window_clamp: 98464 > winfrmspc: 1404 <= skblen: 1448 incr: 2896 > 21: rcv

Re: [RFC] TCP/IPV4 and e1000 does not grow window

2006-01-31 Thread Jesse Brandeburg
On Tue, 31 Jan 2006, David S. Miller wrote: From: Jesse Brandeburg <[EMAIL PROTECTED]> Date: Tue, 31 Jan 2006 16:27:59 -0800 (Pacific Standard Time) > Assuming a 1500 mtu, This appears to be due to e1000 allocating 2k buffers > for hardware + 2 bytes of alignment to align the ip header (NET_IP_A

[PATCH] 1/1 net/core: use USEC_PER_SEC and line spacing

2006-01-31 Thread Ian McDonald
This puts in a constant for USEC_PER_SEC instead of 100. Also fixing > 80 character lines in a couple of places Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> diff --git a/net/core/sock.c b/net/core/sock.c index 6e00811..1d06ec9 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -162,

[PATCH] 0/1 net/core: use USEC_PER_SEC and line spacing

2006-01-31 Thread Ian McDonald
Hi there Dave, Good to meet you last week and hope you had a good trip back (see I listened to your keynote on social interaction) Please find in next message patch to put in USEC_PER_SEC and fix a couple of > 80 char lines. This is against your net 2.6.17 Ian -- Ian McDonald http://wand.ne

Re: [PATCH 3/4] bnx2: Support larger rx ring sizes

2006-01-31 Thread Rick Jones
David S. Miller wrote: From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 31 Jan 2006 15:30:05 -0800 Agreed in general. That's why the default is still 100 with one ring of 255 descriptors. Most users will not change this default setting. How about we compromise and cap the limit at 512 (o

Re: [PATCH] bridge: fix device delete race.

2006-01-31 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 1 Feb 2006 12:53:45 +1100 > Sorry which original fix is this? The very first one is still open > to the same race that started this thread. The one adding the deleted flag and removing the del_timer_sync() calls which you said was fine. - To unsubsc

Re: [PATCH] ipv6 tcp_v6_send_synack: release the destination

2006-01-31 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 1 Feb 2006 12:53:02 +1100 > In that case, every rtx_syn_ack function needs to do a dst_release > on the supplied dst if it's not NULL. So we need Eric's fix plus > the same fix applied to dccp6. I've done that in my net-2.6 tree. - To unsubscribe f

Re: [PATCH] ipv6 tcp_v6_send_synack: release the destination

2006-01-31 Thread David S. Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 25 Jan 2006 13:08:53 -0700 > Analysis: > Currently tcp_v6_send_synack is never called with a dst entry > so dst always comes in as NULL. > > ip6_dst_lookup calls ip6_route_output which calls dst_hold > before it returns the dst entry. Neith

Re: [PATCH] bridge: fix device delete race.

2006-01-31 Thread Herbert Xu
On Tue, Jan 31, 2006 at 05:43:46PM -0800, David S. Miller wrote: > > I'm going to apply Stephen's original fix, and I'd like you guys > to work on a more comprehensive version of the bridge netfilter > race fix, ok? Sorry which original fix is this? The very first one is still open to the same rac

Re: [PATCH] ipv6 tcp_v6_send_synack: release the destination

2006-01-31 Thread Herbert Xu
On Tue, Jan 31, 2006 at 05:34:16PM -0800, David S. Miller wrote: > > Actually, we can't kill off that arg so simply. > TCP ipv4 sends in a non-NULL dst to it's tcp_v4_send_synack() > via tcp_v4_conn_request() when timewait recycling is enabled. Oops I only grepped for rtx_syn_ack as opposed to th

Re: [PATCH] net: do not export inet_bind_bucket_create twice

2006-01-31 Thread David S. Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Mon, 23 Jan 2006 21:14:51 +0100 > inet_bind_bucket_create was exported twice. > Keep the export in the file where inet_bind_bucket_create is defined. > > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Applied, thanks Sam. - To unsubscribe from this l

Re: [PATCH] bridge: fix device delete race.

2006-01-31 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 1 Feb 2006 12:05:58 +1100 > On Tue, Jan 31, 2006 at 04:19:11PM -0800, Stephen Hemminger wrote: > > > > This should close a race where bridge interface is deleted while CPU > > was away doing it's netfilter stuff... > > This patch looks good to me.

Re: [PATCH] ipv6 tcp_v6_send_synack: release the destination

2006-01-31 Thread David S. Miller
From: "David S. Miller" <[EMAIL PROTECTED]> Date: Tue, 31 Jan 2006 17:29:10 -0800 (PST) > Regardless, since everyone passes NULL as the dst argument > to ->rtx_syn_ack() I am going to kill that argument off now > before it causes any troubles and then put in Eric's fix > (after thinking about it s

Re: [PATCH] ipv6 tcp_v6_send_synack: release the destination

2006-01-31 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 26 Jan 2006 13:42:02 +1100 > Eric W. Biederman <[EMAIL PROTECTED]> wrote: > > > > This patch fix dst reference counting in tcp_v6_send_synack > > > > Analysis: > > Currently tcp_v6_send_synack is never called with a dst entry > > so dst always come

Re: [PATCH 3/4] bnx2: Support larger rx ring sizes

2006-01-31 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 31 Jan 2006 15:30:05 -0800 > Agreed in general. That's why the default is still 100 with one ring of > 255 descriptors. Most users will not change this default setting. How about we compromise and cap the limit at 512 (or 511) max RX descriptors

Re: [PATCH 3/4] bnx2: Support larger rx ring sizes

2006-01-31 Thread Michael Chan
On Tue, 2006-01-31 at 16:48 -0800, David S. Miller wrote: > Why? > We have an OEM customer who finds the current rx limit of 255 descriptors too low. IIRC, they are doing some distribution of real-time data and occasionally they get a big burst of incoming 300-byte packets. > To me, anything la

sungem PHY changes break sparc64

2006-01-31 Thread David S. Miller
Sun GEM's die with your recent sungem driver changes. I'm talking about: [SUNGEM]: Make PM of PHYs more reliable (#2) On my latest laptop, I've had occasional PHY dead on wakeup from sleep... the PHY would be totally unresponsive even to toggling the hard reset line until the ma

Re: [PATCH] bridge: fix device delete race.

2006-01-31 Thread Herbert Xu
On Tue, Jan 31, 2006 at 04:19:11PM -0800, Stephen Hemminger wrote: > > This should close a race where bridge interface is deleted while CPU > was away doing it's netfilter stuff... This patch looks good to me. BTW, there are a lot more places where we enter netfilter in the bridging code (especi

Re: [PATCH] ARP: Update Kconfig to allow configuration of CONFIG_IP_ACCEPT_UNSOLICITED_ARP

2006-01-31 Thread David S. Miller
From: "David S. Miller" <[EMAIL PROTECTED]> Date: Tue, 31 Jan 2006 16:51:12 -0800 (PST) replying to myself... > Kill this config option, and instead use a sysctl and make it > off by default. People can twiddle /etc/sysctl.conf if they > want this on and everyone is happy. Note that this probab

Re: [PATCH] ARP: Update Kconfig to allow configuration of CONFIG_IP_ACCEPT_UNSOLICITED_ARP

2006-01-31 Thread David S. Miller
From: Neil Horman <[EMAIL PROTECTED]> Date: Tue, 31 Jan 2006 15:05:54 -0500 > Patch to add CONFIG_IP_ACCEPT_UNSOLICITED_ARP to Kconfig. Currently > we have code in place to accept gratuitous arp replies, but the code > is disabled by the above config option, and there is no way to turn > it on.

Re: [PATCH 3/4] bnx2: Support larger rx ring sizes

2006-01-31 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 31 Jan 2006 13:09:41 -0800 > Increase maximum receive ring size from 255 to 4080 by supporting > up to 16 linked pages of receive descriptors. To accomodate the > higher memory usage, each physical descriptor page is allocated > separately and th

Re: [RFC] TCP/IPV4 and e1000 does not grow window

2006-01-31 Thread David S. Miller
From: Jesse Brandeburg <[EMAIL PROTECTED]> Date: Tue, 31 Jan 2006 16:27:59 -0800 (Pacific Standard Time) > Assuming a 1500 mtu, This appears to be due to e1000 allocating 2k buffers > for hardware + 2 bytes of alignment to align the ip header (NET_IP_ALIGN), > to which then dev_alloc_skb adds 16

[RFC] TCP/IPV4 and e1000 does not grow window

2006-01-31 Thread Jesse Brandeburg
We've recently run into a problem with performance due to what appears to be the socket buffer accounting based on skb->truesize. NOTE: detailed analysis follows, please bear with me... This code in tcp_input.c is preventing growth of the window when e1000 pci/pci-x is a client. This in turn

Re: [PATCH] bridge: fix device delete race.

2006-01-31 Thread Stephen Hemminger
> BTW, can NF_BR_PRE_ROUTING return with NF_QUEUE? If it can, then we'll > need to recheck the validity of br_port in br_handle_frame_finish. This should close a race where bridge interface is deleted while CPU was away doing it's netfilter stuff... Untested.. --- sky2-1.0.orig/net/bridge/br_

Re: [GIT PULL] bcm43xx: Update B6PHY initialization

2006-01-31 Thread Jeff Garzik
On Wed, Feb 01, 2006 at 01:06:04AM +0100, Danny van Dyk wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi John, > > I'm slowly trying to get accustomed to git, so I'll try a short patch > as a first step. So please > > git pull rsync://pitr.amd64.dev.gentoo.org/kugelfang/wireless-2

Re: 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error

2006-01-31 Thread Adrian Bunk
On Tue, Jan 31, 2006 at 04:58:09PM +0200, Denis Vlasenko wrote: > On Tuesday 31 January 2006 16:54, John W. Linville wrote: > > On Tue, Jan 31, 2006 at 02:16:05PM +0200, Denis Vlasenko wrote: > > > > > CONFIG_ACX=y > > > # CONFIG_ACX_PCI is not set > > > # CONFIG_ACX_USB is not set > > > > > > Th

[GIT PULL] bcm43xx: Update B6PHY initialization

2006-01-31 Thread Danny van Dyk
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi John, I'm slowly trying to get accustomed to git, so I'll try a short patch as a first step. So please git pull rsync://pitr.amd64.dev.gentoo.org/kugelfang/wireless-2.6.git I hope I did set up everything correctly :-) Danny - -- Danny van Dyk

Re: e1000 jumbo question

2006-01-31 Thread Jesse Brandeburg
On 1/31/06, JaniD++ <[EMAIL PROTECTED]> wrote: > Hello, list, > > I use the new driver (16-rc1-git4). > > The ifconfig eth3 mtu 9000 refuse to set mtu. > > e1000: eth3: e1000_change_mtu: Jumbo Frames not supported. > > The documenation: > " The driver supports Jumbo Frames for all adapters except 8

Re: [PATCH] bridge: fix device delete race.

2006-01-31 Thread Herbert Xu
On Tue, Jan 31, 2006 at 02:41:13PM -0800, Stephen Hemminger wrote: > This is a simpler fix for the two races in bridge device removal. > The Xen race of delif and notify is managed now by a new deleted flag. > No need for barriers or other locking because of rtnl mutex. > > The del_timer_sync()'s

[PATCH 4/4] bnx2: Update version

2006-01-31 Thread Michael Chan
Update version to 1.4.36. Add missing flush_scheduled_work() in bnx2_suspend as noted by Jeff Garzik. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index a2c8067..93a0be8 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -14,8 +14

[PATCH 2/4] bnx2: Add ethtool -d support

2006-01-31 Thread Michael Chan
Add ETHTOOL_GREGS support. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index af80b04..7560893 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -4540,6 +4540,64 @@ bnx2_get_drvinfo(struct net_device *dev, info->fw_version

[PATCH 3/4] bnx2: Support larger rx ring sizes

2006-01-31 Thread Michael Chan
Increase maximum receive ring size from 255 to 4080 by supporting up to 16 linked pages of receive descriptors. To accomodate the higher memory usage, each physical descriptor page is allocated separately and the software ring that keeps track of the SKBs and the DMA addresses is allocated using vm

[PATCH 1/4] bnx2: Reduce register test size

2006-01-31 Thread Michael Chan
Eliminate some of the registers in ethtool register test to reduce driver size. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index a24200d..af80b04 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -3506,74 +3506,9 @@ bnx2_test_re

[PATCH] bridge: fix device delete race.

2006-01-31 Thread Stephen Hemminger
This is a simpler fix for the two races in bridge device removal. The Xen race of delif and notify is managed now by a new deleted flag. No need for barriers or other locking because of rtnl mutex. The del_timer_sync()'s are unnecessary, because br_stp_disable_port delete's the timers, and they wi

Re: Can I do a regular read to simulate prefetch instruction?

2006-01-31 Thread Jesse Brandeburg
On 1/30/06, John Smith <[EMAIL PROTECTED]> wrote: > Hi, > > I find out some network card drivers (e.g. e1000 driver) use prefetch > instruction to reduce memory access latency and speed up data operation. > > My question is: > Suppose we want to pre-read a skb buffer into the cache, what is the > d

Re: sky2 rx error (was: Re: sky2 freezes the system)

2006-01-31 Thread Stephen Hemminger
On Tue, 31 Jan 2006 22:41:51 +0200 Pekka Pietikainen <[EMAIL PROTECTED]> wrote: > On Tue, Jan 24, 2006 at 06:36:29PM +0200, Pekka Pietikainen wrote: > > On Mon, Jan 23, 2006 at 08:03:15PM +0200, Pekka Pietikainen wrote: > > > The box is a Nexcom NSA 1086 with 4x skge ports and 4x sky2. acpi=off ma

Re: [Patch 1/6] IPSEC: core updates

2006-01-31 Thread KOVACS Krisztian
Hi, On Monday 30 January 2006 22:33, jamal wrote: > > We implemented partial ISAKMP SA synchronization in racoon. That > Unfortunately this would also mean dependency on racoon. Is there any > other way to do it without having to change racoon? example the phase1 > scripts or racoonctl? > It

[PATCH] acenic.c: whitespace, use pr_debug, don't shift and mask multiple times

2006-01-31 Thread Joe Perches
whitespace use pr_debug don't use tmp for different types in a single function don't shift and mask MAC address multiple times Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/drivers/net/acenic.c b/drivers/net/acenic.c index b508812..3f2fa86 100644 --- a/drivers/net/acenic.c +++ b/dri

Re: sky2 rx error (was: Re: sky2 freezes the system)

2006-01-31 Thread Pekka Pietikainen
On Tue, Jan 24, 2006 at 06:36:29PM +0200, Pekka Pietikainen wrote: > On Mon, Jan 23, 2006 at 08:03:15PM +0200, Pekka Pietikainen wrote: > > The box is a Nexcom NSA 1086 with 4x skge ports and 4x sky2. acpi=off made > > the driver work apparently, haven't used it with much load yet, though. > Ran th

[PATCH] ARP: Update Kconfig to allow configuration of CONFIG_IP_ACCEPT_UNSOLICITED_ARP

2006-01-31 Thread Neil Horman
Patch to add CONFIG_IP_ACCEPT_UNSOLICITED_ARP to Kconfig. Currently we have code in place to accept gratuitous arp replies, but the code is disabled by the above config option, and there is no way to turn it on. This patch adds the ability to turn this option on. Tested successfully by me. Than

[PATCH wireless-2.6] softmac: remove dead code

2006-01-31 Thread Johannes Berg
This patch removes ieee80211softmac_reassoc which is neither implemented nor used nor necessary. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> diff --git a/net/ieee80211/softmac/ieee80211softmac_assoc.c b/net/ieee80211/softmac/ieee80211softmac_assoc.c index c6124fc..c788377 100644 --- a/net/i

Re: 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error

2006-01-31 Thread Carlos Martín
On Tuesday 31 January 2006 19:34, Gabriel C. wrote: > > I'm not a kernel hacker :-) and mabye I'm wrong but why not auto select > ACX_{PCI,USB} ? They can still be both unselected, and that's where the problem lies. Would it work if you added '&& (ACX_USB || ACX_PCI)' to the end of the 'depends

[PATCH wireless-2.6] softmac: add reassociation code

2006-01-31 Thread Johannes Berg
This patch adds handling of reassociation to softmac when the AP requests it. Patch from Larry Finger. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> diff --git a/net/ieee80211/softmac/ieee80211softmac_assoc.c b/net/ieee80211/softmac/ieee80211softmac_assoc.c index 755b612..c6124fc 100644 --- a

[PATCH wireless-2.6] softmac: update deauth handler to quiet warning

2006-01-31 Thread Johannes Berg
Recently the deauth packet handler was updated to use a deauth packet struct (identical to the auth packet struct) and this now gives a warning. This patch updates the code to properly use a deauth struct and deauth variable. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> diff --git a/net/ieee8

[PATCH wireless-2.6] trivial fixes to softmac

2006-01-31 Thread Johannes Berg
This patch removes a blank line that shouldn't be there and fixes a spelling error in softmac. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> diff --git a/net/ieee80211/softmac/ieee80211softmac_auth.c b/net/ieee80211/softmac/ieee80211softmac_auth.c index ccbb51c..dd5fb0f 100644 --- a/net/ieee8

[PATCH wireless-2.6] update copyright in softmac

2006-01-31 Thread Johannes Berg
This patch updates the copyright statements in softmac that I erroneously added for 2005 only (when we already had 2006). Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> diff --git a/net/ieee80211/softmac/ieee80211softmac_assoc.c b/net/ieee80211/softmac/ieee80211softmac_assoc.c index b29fb1c..7

Re: 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error

2006-01-31 Thread Gabriel C.
On Tue, 31 Jan 2006 16:58:09 +0200 Denis Vlasenko <[EMAIL PROTECTED]> wrote: > On Tuesday 31 January 2006 16:54, John W. Linville wrote: > > On Tue, Jan 31, 2006 at 02:16:05PM +0200, Denis Vlasenko wrote: > > > > > CONFIG_ACX=y > > > # CONFIG_ACX_PCI is not set > > > # CONFIG_ACX_USB is not set >

Re: [PATCH] RealTek RTL-8169 Full Duplex Patch

2006-01-31 Thread Francois Romieu
Andy Gospodarek <[EMAIL PROTECTED]> : > Allow the r8129 driver to set devices to be full-duplex only when > auto-negotiate is disabled. s/8129/8169 and added to the branch 'for-jeff' at git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git -- Ueimor - To unsubscribe from this list: send the

Re: [Netlink] virtual interface

2006-01-31 Thread Robert Iakobashvili
Hi, On 1/31/06, jamal <[EMAIL PROTECTED]> wrote: > On Tue, 2006-31-01 at 16:26 +0100, Harald Welte wrote: > > On Tue, Jan 24, 2006 at 09:19:02PM +0100, Mathieu Geli wrote: > > > > > Here is a patch that add a netlink virtual interface. > > > > I really like the possibility that it offers. In fact

Re: d80211 patches

2006-01-31 Thread John W. Linville
On Mon, Jan 30, 2006 at 02:53:20PM +0100, Jiri Benc wrote: > Following patches to d80211 can be obtained from > > git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git up This is available in the 'dscape-all' and 'domesday' branches of wireless-2.6. Thanks! John -- John W. Linville [E

Re: 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error

2006-01-31 Thread Denis Vlasenko
On Tuesday 31 January 2006 16:54, John W. Linville wrote: > On Tue, Jan 31, 2006 at 02:16:05PM +0200, Denis Vlasenko wrote: > > > CONFIG_ACX=y > > # CONFIG_ACX_PCI is not set > > # CONFIG_ACX_USB is not set > > > > This won't fly. You must select at least one. > > > > Attached patch will check f

Re: IPSec DUMP issue

2006-01-31 Thread Patrick McHardy
jamal wrote: > On Tue, 2006-31-01 at 11:42 -0500, Venkat Yekkirala wrote: > > > >>I gather this is a known issue and was wondering about possible/acceptable >>solutions as I would like to help resolve this problem. >> > > > Pseudo-known issue. The challenge is pfkey which doesnt scale well. >

[PATCH RESEND] s2io: set_multicast_list bug

2006-01-31 Thread Arthur Kepner
The mac_addr variable doesn't get reset between (re)additions of multicast addresses. One byte of all multicast addresses (except the first) can be incorrect. Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> -- Arthur --- linux-2.6.orig/drivers/net/s2io.c 2006-01-24 04:26:09.425074105 -0800 +

Re: IPSec DUMP issue

2006-01-31 Thread jamal
On Tue, 2006-31-01 at 11:42 -0500, Venkat Yekkirala wrote: > I gather this is a known issue and was wondering about possible/acceptable > solutions as I would like to help resolve this problem. > Pseudo-known issue. The challenge is pfkey which doesnt scale well. Try dumping with iproute2 ip xf

Re: Please pull 'upstream-fixes' branch of wireless-2.6

2006-01-31 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 4a99ac3a9ee7e1b90ebc3ddbb44db75eef5c41e6: Zhu Yi: ieee80211: Fix A band min and max channel definitions are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fi

Re: Please pull 'upstream' branch of wireless-2.6

2006-01-31 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 747af1e154545566d04f647f86fc3ae512439fab: John W. Linville: Merge branch 'upstream-fixes' are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream Adrian Bunk:

IPSec DUMP issue

2006-01-31 Thread Venkat Yekkirala
Hello, When there is a lot (thousands) of IPSec policy rules in the kernel, a dump request from user land would currently cause most of the policy rules to not make it to the socket receive buffer depending on what value sk_rcvbuf has. Using setkey to load a bunch of policy rules, then trying to d

Please pull 'upstream' branch of wireless-2.6

2006-01-31 Thread John W. Linville
The following changes since commit 747af1e154545566d04f647f86fc3ae512439fab: John W. Linville: Merge branch 'upstream-fixes' are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream Adrian Bunk: net/: fix the WIRELESS

Re: Sendfile implementation details

2006-01-31 Thread Chase Douglas
David S. Miller wrote: From: Chase Douglas <[EMAIL PROTECTED]> Date: Mon, 30 Jan 2006 13:55:21 -0500 I have a question about the implementation of sendfile. In my current configuration of a server, when requests are made for a file, a new thread is spawned and sendfile is called to complet

Re: [2.6 patch] PCMCIA=m, HOSTAP_CS=y is not a legal configuration

2006-01-31 Thread John W. Linville
On Mon, Jan 30, 2006 at 07:23:17PM +0100, Adrian Bunk wrote: > CONFIG_PCMCIA=m, CONFIG_HOSTAP_CS=y doesn't compile. > > Reported by "Gabriel C." <[EMAIL PROTECTED]>. Applied to upstream-fixes branch of wireless-2.6. Thanks, John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this

Please pull 'upstream-fixes' branch of wireless-2.6

2006-01-31 Thread John W. Linville
The following changes since commit 4a99ac3a9ee7e1b90ebc3ddbb44db75eef5c41e6: Zhu Yi: ieee80211: Fix A band min and max channel definitions are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fixes Adrian Bunk: PC

Re: [PATCH 5/6] ipw2100: Fix a gcc compile warning

2006-01-31 Thread John W. Linville
On Tue, Jan 24, 2006 at 01:49:26PM +0800, Zhu Yi wrote: > > [PATCH] ipw2100: Fix a gcc compile warning > > drivers/net/wireless/ipw2100.c:2236: warning: `ipw2100_match_buf' defined > but not used Applied to upstream-fixes branch of wireless-2.6. Thanks, John -- John W. Linville [EMAIL PROTECT

Re: [PATCH 02/18] ipw2200: Fix "iwspy ethx off" causes kernel panic

2006-01-31 Thread John W. Linville
On Tue, Jan 24, 2006 at 04:36:22PM +0800, Zhu Yi wrote: > > [PATCH] ipw2200: Fix "iwspy ethx off" causes kernel panic. Applied to upstream-fixes branch of wireless-2.6. Thanks, John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH 14/18] ipw2200: Fix a variable referenced after kfree() bug

2006-01-31 Thread John W. Linville
On Tue, Jan 24, 2006 at 04:37:41PM +0800, Zhu Yi wrote: > > [PATCH] ipw2200: Fix a variable referenced after kfree() bug. Applied to upstream-fixes branch of wireless-2.6. Thanks, John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH 6/6] ipw2100: Fix setting txpower failed problem

2006-01-31 Thread John W. Linville
On Tue, Jan 24, 2006 at 01:49:32PM +0800, Zhu Yi wrote: > [PATCH] ipw2100: Fix setting txpower failed problem > > The ipw2100 driver misunderstood the parameter of txpower. > Tx Power off means turn off the radio, but the driver interpret it as > "can't set txpower". So when getting the txpower,

Re: [PATCH 03/18] ipw2200: Fix sw_reset doesn't clear the static essid problem

2006-01-31 Thread John W. Linville
On Tue, Jan 24, 2006 at 04:36:31PM +0800, Zhu Yi wrote: > > [PATCH] ipw2200: Fix sw_reset doesn't clear the static essid problem Applied to upstream-fixes branch of wireless-2.6. Thanks, John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netd

[2.6 patch] wrong firmware location in IPW2100 Kconfig entry

2006-01-31 Thread Adrian Bunk
From: Jesper Juhl <[EMAIL PROTECTED]> Firmware should go into /lib/firmware, not /etc/firmware. Found by Alejandro Bonilla. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was sent by Jesper Juhl on: - 6 Sep 2005 --- linux-2.6.13-m

Re: [Netlink] virtual interface

2006-01-31 Thread jamal
On Tue, 2006-31-01 at 16:26 +0100, Harald Welte wrote: > On Tue, Jan 24, 2006 at 09:19:02PM +0100, Mathieu Geli wrote: > > > Here is a patch that add a netlink virtual interface. > > I really like the possibility that it offers. In fact, I always wanted > something like a 'promiscuous netlink so

Re: [Netlink] virtual interface

2006-01-31 Thread Patrick McHardy
Harald Welte wrote: > On Tue, Jan 24, 2006 at 09:19:02PM +0100, Mathieu Geli wrote: > > >>Here is a patch that add a netlink virtual interface. > > > I really like the possibility that it offers. In fact, I always wanted > something like a 'promiscuous netlink socket'. > Whether it is the righ

Re: [patch] SFQ "noports" and "nosrcip" support and hash revamp

2006-01-31 Thread jamal
On Tue, 2006-31-01 at 01:16 +0100, Patrick McHardy wrote: > David S. Miller wrote: > > From: dean gaudet <[EMAIL PROTECTED]> > > Date: Sat, 17 Dec 2005 18:22:40 -0800 (PST) > > > > > >>let me know what you think... i'd like to get something like this patch > >>included upstream so i can eliminate

Re: wireless-2.6 status (25 January 2006)

2006-01-31 Thread Harald Welte
On Fri, Jan 27, 2006 at 07:33:05AM -0500, John W. Linville wrote: > On Fri, Jan 27, 2006 at 09:17:50AM +, Christoph Hellwig wrote: > > > Folks, please stop these stupid ideas. There's a free driver, let's improve > > and merge it. That's a thousand times better than any half-free driver > >

Re: [RFC,NETLINK]: (v3) Add netlink_has_listeners() for checking for multicast listeners

2006-01-31 Thread jamal
On Tue, 2006-31-01 at 02:27 +0100, Patrick McHardy wrote: > Patrick McHardy wrote: > > Thinking about it .. using RCU seems entirely unneccessary, assuming > > callers don't close the kernel socket and call netlink_has_listeners() > > afterwards, the pointer is always valid. > > Latest version wit

Re: [Netlink] virtual interface

2006-01-31 Thread Harald Welte
On Tue, Jan 24, 2006 at 09:19:02PM +0100, Mathieu Geli wrote: > Here is a patch that add a netlink virtual interface. I really like the possibility that it offers. In fact, I always wanted something like a 'promiscuous netlink socket'. Whether it is the right thing to add a full-blown net_devic

Re: 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error

2006-01-31 Thread John W. Linville
On Tue, Jan 31, 2006 at 02:16:05PM +0200, Denis Vlasenko wrote: > CONFIG_ACX=y > # CONFIG_ACX_PCI is not set > # CONFIG_ACX_USB is not set > > This won't fly. You must select at least one. > > Attached patch will check for this and #error out. > Andrew, do not apply to -mm, I'll send you bigger

Re: 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error

2006-01-31 Thread Denis Vlasenko
On Tuesday 31 January 2006 11:03, Gabriel C. wrote: > > > > I got this compile error with 2.6.16-rc1-mm4 , config attached. > > > > > > > > > > > > LD .tmp_vmlinux1 > > > > drivers/built-in.o: In function > > > > `acx_l_transmit_authen1':common.c:(.text+0x6cd62): undefined > > > > referen

Re: ip_conntrack related slab error (Re: Fw: Re: 2.6.16-rc1-mm3)

2006-01-31 Thread Patrick McHardy
Reuben Farrelly wrote: > tornado.reub.net login: BUG: unable to handle kernel paging request at > virtual address 00200200 This means ct->nat.info.bysource was already removed from the list, which can only happen if the conntrack entry is destroyed twice. I can't find how this could have happened

[2.6 patch] AIRO{,_CS} <-> CRYPTO fixes

2006-01-31 Thread Adrian Bunk
CRYPTO is a helper variable, and to make it easier for users, it should therefore select'ed and not be listed in the dependencies. drivers/net/wireless/airo.c requires CONFIG_CRYPTO for compilations. Therefore, AIRO_CS also has to CRYPTO. Additionally, this patch removes the #ifdef's for the no

Re: [BUG] 8139too fails for ip autoconfig and nfsroot

2006-01-31 Thread Knut Petersen
Knut Petersen wrote: but found none. Skipping ip autoconfig is no solution, the kernel then fails trying rpc lookup. Then I tried to netboot another system with the same kernel + via rhine driver, same server config. Voila, dhcp ip autoconfig and rpc port lookup is not a problem on this syst

Re: ip_conntrack related slab error (Re: Fw: Re: 2.6.16-rc1-mm3)

2006-01-31 Thread Harald Welte
On Tue, Jan 31, 2006 at 11:05:43PM +1300, Reuben Farrelly wrote: > >>slab error in kmem_cache_destroy(): cache `ip_conntrack': Can't free all > >>objects > >> [] show_trace+0xd/0xf > >> [] dump_stack+0x17/0x19 > >> [] kmem_cache_destroy+0x9b/0x1a9 > >> [] ip_conntrack_cleanup+0x5d/0x10e [ip_c

Re: ip_conntrack related slab error (Re: Fw: Re: 2.6.16-rc1-mm3)

2006-01-31 Thread Reuben Farrelly
On 31/01/2006 10:24 p.m., Harald Welte wrote: Begin forwarded message: Date: Sat, 28 Jan 2006 00:47:06 +1300 From: Reuben Farrelly <[EMAIL PROTECTED]> To: Andrew Morton <[EMAIL PROTECTED]> Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: 2.6.16-rc1-mm3 Just triggered this

Re: ip_conntrack related slab error (Re: Fw: Re: 2.6.16-rc1-mm3)

2006-01-31 Thread Reuben Farrelly
On 31/01/2006 10:24 p.m., Harald Welte wrote: Begin forwarded message: Date: Sat, 28 Jan 2006 00:47:06 +1300 From: Reuben Farrelly <[EMAIL PROTECTED]> To: Andrew Morton <[EMAIL PROTECTED]> Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: 2.6.16-rc1-mm3 Just triggered this o

Re: [NETFILTER] NAT sequence adjustment: Save eight bytes per conntrack

2006-01-31 Thread Harald Welte
On Tue, Jan 31, 2006 at 09:50:52AM +0100, Balazs Scheidler wrote: > > - int32_t offset_before, offset_after; > > + int16_t offset_before, offset_after; > > Am I missing something or is it only 4 bytes? I knew someone would ask that question ;) we have that structure as part of an IP_CT_DIR_

ip_conntrack related slab error (Re: Fw: Re: 2.6.16-rc1-mm3)

2006-01-31 Thread Harald Welte
> Begin forwarded message: > > Date: Sat, 28 Jan 2006 00:47:06 +1300 > From: Reuben Farrelly <[EMAIL PROTECTED]> > To: Andrew Morton <[EMAIL PROTECTED]> > Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org > Subject: Re: 2.6.16-rc1-mm3 > > Just triggered this one, which had a fairly bad eff

Re: [PATCH] [NETFILTER] nfnetlink_log: add sequence numbers for log events

2006-01-31 Thread Harald Welte
On Tue, Jan 31, 2006 at 12:32:21AM +0100, Patrick McHardy wrote: > Harald Welte wrote: > > Hi Dave, > > > > please apply, thanks! > > > > [NETFILTER] nfnetlink_log: add sequence numbers for log events > > > > By using a sequence number for every logged netfilter event, we can > > determine from

Re: [NETFILTER] NAT sequence adjustment: Save eight bytes per conntrack

2006-01-31 Thread Balazs Scheidler
On Tue, 2006-01-31 at 00:22 +0100, Harald Welte wrote: > --- > commit 94d3d40c84672b74e59ea5252f61602610e1513e > tree 63e5ae5174af9f982be6d8d1bbe11e750e4ace32 > parent e3c7a1f99300fbd6de35a40fcd9c4dc1b0fbfee2 > author Harald Welte <[EMAIL PROTECTED]> Fri, 27 Jan 2006 16:03:45 +0100 > committer Har

  1   2   >