[NETFILTER]: Fix skb->nf_bridge lifetime issues

2006-02-19 Thread Patrick McHardy
Bart, can you please have a look at this patch and ACK/NACK it? We have a bugreport in the netfilter bugzilla of broken conntrack with tunnels on top of bridge devices (#448), which should be cured by this patch. There is also another report of broken conntrack with vlan on top of bridge devices (

Re: [PATCH] [NET]: NETFILTER: remove duplicated operation and fix order in skb_clone().

2006-02-19 Thread David S. Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Fri, 17 Feb 2006 21:51:01 +0900 (JST) > [NET]: NETFILTER: remove duplicated lines and fix order in skb_clone(). > > Some of netfilter-related members are initalized / copied twice in > skb_clone(). Remove one. Pointed out by Olivier MATZ <[EMAIL P

Re: [PATCH] IrDA: irda-usb bug fixes

2006-02-19 Thread David S. Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Sat, 18 Feb 2006 19:19:13 +0200 > This patch fixes 2 bugs in the USB-IrDA code. > > The first one is a buffer overrun in the RX path. We are now using > IRDA_SKB_MAX_MTU when initializing the Rx URB. > > The second one is a potential stack recursion

Re: [Patch 1/6] IPSEC: core updates

2006-02-19 Thread David S. Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Mon, 20 Feb 2006 14:29:47 +0900 (JST) > > +struct xfrm_aevent_id { > > + __u32 flags; > > + struct xfrm_usersa_id sa_id; > > +}; > > + > > struct xfrm_userspi_info { > > struct xfrm_usersa_info i

Re: [XFRM 2.6.16]: Fix policy double put

2006-02-19 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 20 Feb 2006 07:16:38 +0100 > David S. Miller wrote: > > Applied, thanks. > > > > I think this is -stable material, agreed? > > It was only introduced recently by the "[IPSEC]: Fix strange IPsec > freeze." patch. Ok, thanks for the clarificati

Re: [XFRM 2.6.16]: Fix policy double put

2006-02-19 Thread Patrick McHardy
David S. Miller wrote: > Applied, thanks. > > I think this is -stable material, agreed? It was only introduced recently by the "[IPSEC]: Fix strange IPsec freeze." patch. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordo

Re: [XFRM 2.6.16]: Fix policy double put

2006-02-19 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 20 Feb 2006 07:00:03 +0100 > Herbert Xu wrote: > > On Mon, Feb 20, 2006 at 06:13:03AM +0100, Patrick McHardy wrote: > > > >>[XFRM]: Fix policy double put > >> > >>The policy is put once immediately and once at the error label, which > >>result

Re: [XFRM 2.6.16]: Fix policy double put

2006-02-19 Thread Patrick McHardy
Herbert Xu wrote: > On Mon, Feb 20, 2006 at 06:13:03AM +0100, Patrick McHardy wrote: > >>[XFRM]: Fix policy double put >> >>The policy is put once immediately and once at the error label, which results >>in the following Oops: > > > Looks good to me. Thanks for catching this Patrick. It caught

Re: [XFRM 2.6.16]: Fix policy double put

2006-02-19 Thread Herbert Xu
On Mon, Feb 20, 2006 at 06:13:03AM +0100, Patrick McHardy wrote: > > [XFRM]: Fix policy double put > > The policy is put once immediately and once at the error label, which results > in the following Oops: Looks good to me. Thanks for catching this Patrick. -- Visit Openswan at http://www.open

Can't pull updates from softmac-all branch

2006-02-19 Thread Denis Vlasenko
Hi, This was working before, but today it does not: # cg-update r-softmac-all Recovering from a previously interrupted fetch... WARNING: The rsync access method is DEPRECATED and will be REMOVED in the future! Fetching head... MOTD: MOTD: Welcome to the Linux Kernel Archive. MOTD: MOTD: Due

Re: [Patch 1/6] IPSEC: core updates

2006-02-19 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 27 Jan 2006 08:05:23 -0500), jamal <[EMAIL PROTECTED]> says: > diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h > index 82fbb75..b54a129 100644 > --- a/include/linux/xfrm.h > +++ b/include/linux/xfrm.h : > @@ -235,6 +258,11 @@ struct xfrm_usersa_id

[XFRM 2.6.16]: Fix policy double put

2006-02-19 Thread Patrick McHardy
[XFRM]: Fix policy double put The policy is put once immediately and once at the error label, which results in the following Oops: kernel BUG at net/xfrm/xfrm_policy.c:250! invalid opcode: [#2] PREEMPT [...] CPU:0 EIP:0060:[]Not tainted VLI EFLAGS: 00210246 (2.6.16-rc3 #39) EI

Re: [PKT_SCHED 04/05]: Convert sch_red to a classful qdisc

2006-02-19 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 15 Feb 2006 09:54:57 +0100 (MET) > [PKT_SCHED]: Convert sch_red to a classful qdisc > > Convert sch_red to a classful qdisc. All qdiscs that maintain accurate > backlog counters are eligible as child qdiscs. When a queue limit larger > than zer

Re: [PKT_SCHED 00/05]: net/sched patches for 2.6.17

2006-02-19 Thread David S. Miller
From: jamal <[EMAIL PROTECTED]> Date: Sun, 19 Feb 2006 20:14:26 -0500 > I think I have sufficiently expressed my views and progress needs to be > made; therefore I ACK the patch. > > Note the definition of "work" is very highly debatable as to be just > constrained to producing code but i think t

Re: [DOC]: xfrm sync

2006-02-19 Thread David S. Miller
From: jamal <[EMAIL PROTECTED]> Date: Sun, 19 Feb 2006 20:43:33 -0500 > Something i wrote around the time of coding the sync stuff. > Just so i dont loose it - here it is attached ;-> Why don't we put this under Documentation/networking/ as "xfrm_sync.txt"? If you agree, please give me a Signed-

Re: [RFC] [PATCH 1/2] Driver to remember ethernet MAC values: maclist

2006-02-19 Thread Adrian Bunk
On Mon, Feb 20, 2006 at 03:01:46AM +0100, Alessandro Zummo wrote: > On Mon, 20 Feb 2006 02:47:35 +0100 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > Some Ethernet hardware implementations have no built-in storage for > > > allocated MAC values - an example is the Intel IXP420 chip which has > >

Re: [RFC] [PATCH 1/2] Driver to remember ethernet MAC values: maclist

2006-02-19 Thread Alessandro Zummo
On Mon, 20 Feb 2006 02:47:35 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > > Some Ethernet hardware implementations have no built-in storage for > > allocated MAC values - an example is the Intel IXP420 chip which has > > support for Ethernet but no defined way of storing allocated MAC values. >

Re: [RFC] [PATCH 1/2] Driver to remember ethernet MAC values: maclist

2006-02-19 Thread Adrian Bunk
On Mon, Feb 20, 2006 at 01:01:13AM +, Martin Michlmayr wrote: > From: John Bowler <[EMAIL PROTECTED]> > > Some Ethernet hardware implementations have no built-in storage for > allocated MAC values - an example is the Intel IXP420 chip which has > support for Ethernet but no defined way of sto

[DOC]: xfrm sync

2006-02-19 Thread jamal
Something i wrote around the time of coding the sync stuff. Just so i dont loose it - here it is attached ;-> cheers, jamal The sync patches work is based on initial patches from Krisztian <[EMAIL PROTECTED]> and others. The end goal is to be able to insert attributes + generate events so tha

Re: [PKT_SCHED 00/05]: net/sched patches for 2.6.17

2006-02-19 Thread jamal
On Sun, 2006-19-02 at 00:42 -0800, David S. Miller wrote: > From: jamal <[EMAIL PROTECTED]> > Date: Thu, 16 Feb 2006 07:56:44 -0500 > > > [1]I have to put a disclaimer: I am always a stickler as far as RED > > is concerned (Thomas can testify to that) because it is very > > delicate (not the code

[RFC] [PATCH 2/2] Driver to remember ethernet MAC values: NSLU2 support

2006-02-19 Thread Martin Michlmayr
From: John Bowler <[EMAIL PROTECTED]> Implement maclist support for the Linksys NSLU2. The MAC address is read from the RedBoot partition in flash. Signed-off-by: John Bowler <[EMAIL PROTECTED]> Signed-off-by: Martin Michlmayr <[EMAIL PROTECTED]> Signed-off-by: Alessandro Zummo <[EMAIL PROTECTED

[RFC] [PATCH 1/2] Driver to remember ethernet MAC values: maclist

2006-02-19 Thread Martin Michlmayr
From: John Bowler <[EMAIL PROTECTED]> Some Ethernet hardware implementations have no built-in storage for allocated MAC values - an example is the Intel IXP420 chip which has support for Ethernet but no defined way of storing allocated MAC values. With such hardware different board level implement

Re: Diff between Linus' and linux-mips git: declance

2006-02-19 Thread Martin Michlmayr
Remove delta between Linus' and linux-mips git trees in declance There are two changes between the Linus' and linux-mips git trees regarding the declaner driver. The first change is certainly correct (as it is consistent with the rest of the file) and should be applied to mainline; the other chan

[PATCH] Improve wording of MV643XX_ETH in Kconfig

2006-02-19 Thread Martin Michlmayr
Slightly improve the wording of the description of MV643XX_ETH in Kconfig. This difference was found between the mainline and linux-mips kernel trees. Signed-off-by: Martin Michlmayr <[EMAIL PROTECTED]> --- linux-2.6.16-rc4/drivers/net/Kconfig2006-02-19 20:09:06.0 + +++ mip

Re: [RFT] sky2 0.16

2006-02-19 Thread Ian Kumlien
On Sun, 2006-02-19 at 14:20 +0100, Wolfgang Hoffmann wrote: > On Saturday 18 February 2006 18:00, Carl-Daniel Hailfinger wrote: > > Hi, > > > > Stephen Hemminger schrieb: > > > Could everyone who has problems with hangs try the > > > following patch (against current 2.6.16-rc3 version) > > > > If S

Re: Merging Skylark's IOC3 patch

2006-02-19 Thread Martin Michlmayr
* Martin Michlmayr <[EMAIL PROTECTED]> [2006-02-19 21:15]: > Can you please review and/or merge Skylark's IOC3 patch from > ftp://ftp.linux-mips.org/pub/linux/mips/people/skylark/linux-mips-2.6.14-ioc3-r26.patch.bz2 > > From my basic understanding I believe that this patch needs to be split up > a

Re: (usagi-users 03611) Re: IPv6 setsockopt software MTU patch

2006-02-19 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Sun, 19 Feb 2006 15:54:13 +0100), [EMAIL PROTECTED] says: > Yes, Hugo Santos suggested me to use the minimum of both, the new > patch is available there : > > http://clarinet.u-strasbg.fr/~hoerdt/ip6_output.c.softfrag.patch2 Do you mean like this? Signed-off-

Re: [PATCH] keep track of network interface renaming

2006-02-19 Thread Francois Romieu
Christoph Hellwig <[EMAIL PROTECTED]> : [...] > the about to rename part is really noisy. Yes. @@ -730,7 +731,11 @@ int dev_change_name(struct net_device *d else if (__dev_get_by_name(newname)) return -EEXIST; else + { -> a cleanup patch may be avoided if th

Re: (usagi-users 03610) Re: IPv6 setsockopt software MTU patch

2006-02-19 Thread hoerdt
Yes, Hugo Santos suggested me to use the minimum of both, the new patch is available there : http://clarinet.u-strasbg.fr/~hoerdt/ip6_output.c.softfrag.patch2 Thanks, Hoerdt Mickaël On Sun, Feb 19, 2006 at 11:13:44PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote: > In article <[EMAIL PROTECTED]

Re: [RFT] sky2 0.16

2006-02-19 Thread Ian Kumlien
On Sun, 2006-02-19 at 14:20 +0100, Wolfgang Hoffmann wrote: > On Saturday 18 February 2006 18:00, Carl-Daniel Hailfinger wrote: > > Hi, > > > > Stephen Hemminger schrieb: > > > Could everyone who has problems with hangs try the > > > following patch (against current 2.6.16-rc3 version) > > > > If S

Re: IPv6 setsockopt software MTU patch

2006-02-19 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Sun, 19 Feb 2006 14:47:09 +0100), [EMAIL PROTECTED] says: > The fix is very simple, it only grab the value of frag_size and > use it in ip6_fragment file, could you please review the patch which > fix that problem at : > > http://clarinet.u-strasbg.fr/~hoerdt/i

IPv6 setsockopt software MTU patch

2006-02-19 Thread hoerdt
Hi, In my precedent mails, i pointed out that IPV6_MTU setsockopt was ineffective because the field frag_size was not used further in the ipv6 fragment code of the kernel. You can check out that this is the case by this simple proof of concept code : http://clarinet.u-strasbg.fr/~hoerdt/mtu.c Th

Re: [RFT] sky2 0.16

2006-02-19 Thread Wolfgang Hoffmann
On Saturday 18 February 2006 18:00, Carl-Daniel Hailfinger wrote: > Hi, > > Stephen Hemminger schrieb: > > Could everyone who has problems with hangs try the > > following patch (against current 2.6.16-rc3 version) > > If Stephen's patch doesn't work for you, could you try replacing > sky2.c and sk

Re: [PATCH] keep track of network interface renaming

2006-02-19 Thread Olaf Hering
On Sat, Feb 18, Jeff Garzik wrote: > Fix Xen network support not to do such stupid stuff... No Xen due to lack of A20 gates. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-

Re: [Patch 0/7] IPSEC: Sync series

2006-02-19 Thread David S. Miller
From: jamal <[EMAIL PROTECTED]> Date: Fri, 03 Feb 2006 08:58:56 -0500 > Thanks for everyone who has provided comments thus far. If you have any > more comments please shoot, else Dave this is for 2.6.17 tree. All looks good Jamal, applied. Thanks a lot. - To unsubscribe from this list: send the

Re: [PKT_SCHED 00/05]: net/sched patches for 2.6.17

2006-02-19 Thread David S. Miller
From: jamal <[EMAIL PROTECTED]> Date: Thu, 16 Feb 2006 07:56:44 -0500 > [1]I have to put a disclaimer: I am always a stickler as far as RED > is concerned (Thomas can testify to that) because it is very > delicate (not the code rather the algorithm) and i have suffered a > lot in the past getting

Re: [PKT_SCHED 05/05]: Keep backlog counter in sch_sfq

2006-02-19 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 15 Feb 2006 09:54:59 +0100 (MET) > [PKT_SCHED]: Keep backlog counter in sch_sfq > > Keep backlog counter in SFQ qdisc to make it usable as child qdisc with > RED. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied. - To unsubscrib

Re: [PKT_SCHED 02/05]: Dump child qdisc handle in sch_{atm,dsmark}

2006-02-19 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 15 Feb 2006 09:54:54 +0100 (MET) > [PKT_SCHED]: Dump child qdisc handle in sch_{atm,dsmark} > > A qdisc should set tcm_info to the child qdisc handle in its class dump > function. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied

Re: [PKT_SCHED 01/05]: Qdisc drop operation is optional

2006-02-19 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 15 Feb 2006 09:54:53 +0100 (MET) > [PKT_SCHED]: Qdisc drop operation is optional > > The drop operation is optional and qdiscs must check if childs support it. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied, thanks. - To unsub

Re: [PATCH 5/5] IrDA: pci_register_driver conversion

2006-02-19 Thread David S. Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Tue, 14 Feb 2006 00:15:48 +0200 > This patch converts 2 IrDA drivers pci_module_init() calls to > pci_register_driver(). > > Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> > Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> > Signed-off-by: Samuel O

Re: [PATCH 4/5] IrDA: sti/cli removal from EP7211 IrDA driver

2006-02-19 Thread David S. Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Tue, 14 Feb 2006 00:15:38 +0200 > This patch replaces the deprecated sti/cli routines with the corresponding > spin_lock ones. > > Signed-off-by: David chosrova <[EMAIL PROTECTED]> > Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> Applied. - To unsubs

Re: [PATCH 3/5] IrDA: nsc-ircc: support for yet another Thinkpad IrDA chipset

2006-02-19 Thread David S. Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Tue, 14 Feb 2006 00:15:21 +0200 > This patch simply adds support for a variation of the nsc-ircc PC8739x > chipset, found in some IBM Thinkpad laptops. > > Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> > Signed-off-by: Samuel Ortiz <[EMAIL PROTEC

Re: [PATCH 2/5] IrDA: nsc-ircc: PM update

2006-02-19 Thread David S. Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Tue, 14 Feb 2006 00:15:09 +0200 > This patch brings the nsc-ircc code to a more up to date power management > scheme, following the current device model. > > Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> > Signed-off-by: Rudolf Marek <[EMAIL PROTE

Re: [PATCH 1/5] IrDA: nsc-ircc: ISAPnP support

2006-02-19 Thread David S. Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Tue, 14 Feb 2006 00:14:43 +0200 > This enables PnP support for the nsc-ircc chipset. > Since we can't fetch the chipset cfg_base from the PnP layer, we just use > the PnP information as one more hint when probing the chip. > > Signed-off-by: Jean Tourr

Re: [NETLINK]: Add netlink_has_listeners for avoiding unneccessary event message generation

2006-02-19 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 16 Feb 2006 02:43:58 +0100 > This is a simplified version of the netlink_has_listeners patch > to let netlink multicast senders check for listeners before > generating messages. The last version also had a bug that made > the mask only contain t