patch for caching TCP options with syncookies

2006-03-15 Thread jensen galan
greetings! this is my first creation of a patch for the linux kernel. if you have time, could you please take a look at it and give me some feedback. this patch creates a syn_cache for caching TCP options when syn_cookies are in use (by default, all TCP options are lost when using syncookies). a

Re: patch for caching TCP options with syncookies

2006-03-15 Thread Arnaldo Carvalho de Melo
On 3/15/06, jensen galan <[EMAIL PROTECTED]> wrote: > greetings! > > this is my first creation of a patch for the linux > kernel. if you have time, could you please take a look > at it and give me some feedback. > > this patch creates a syn_cache for caching TCP options > when syn_cookies are in us

MR. Kings Roger

2006-03-15 Thread paris.r
MR. Kings Roger Standard Bank Plc Johannesburg, South Africa ID Number: 0092-042 UNTERSTÜTZUNG Dringend GESCHAEFTSANGEBOT Mein Name ist Kings Roger und ich bin der Leiter des Corporate Affairs Committee in der Standard Bank of South-Africa PLC in Südafrika. Zur Zeit halte ich mich in Deutsch

MR. Kings Roger

2006-03-15 Thread paris.r
MR. Kings Roger Standard Bank Plc Johannesburg, South Africa ID Number: 0092-042 UNTERSTÜTZUNG Dringend GESCHAEFTSANGEBOT Mein Name ist Kings Roger und ich bin der Leiter des Corporate Affairs Committee in der Standard Bank of South-Africa PLC in Südafrika. Zur Zeit halte ich mich in Deutsch

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-15 Thread jamal
On Tue, 2006-14-03 at 15:05 +1000, Russell Stuart wrote: > On Mon, 2006-03-13 at 22:39 -0500, jamal wrote: [..] > OK. But what I can replace "sample" with is directly > specifying the hash using the ht option. This requires > me to manually calculate the hash. Since "sample" hasn't > worked si

Re: [2.6 patch] hostap_{pci,plx}.c: fix memory leaks

2006-03-15 Thread Adrian Bunk
On Tue, Mar 14, 2006 at 07:16:25PM -0800, Jouni Malinen wrote: > On Mon, Mar 13, 2006 at 11:28:41PM +0100, Adrian Bunk wrote: > > This patch fixes two memotry leaks spotted by the Coverity checker. > > Thanks. I'll make a bit different patch to resolve this and related PCI > "leaks" in one change.

[2.6 patch] ieee80211_wx.c: remove dead code

2006-03-15 Thread Adrian Bunk
Since sec->key_sizes[] is an u8, len can't be < 0. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.16-rc6-mm1-full/net/ieee80211/ieee80211_wx.c.old 2006-03-14 03:01:43.0 +0100 +++ linux-2.6.16-rc6-mm1-full/net/ieee80211/ieee80211_wx.c

Re: [RFC/PATCH 3/13] d80211: non-shared interface types

2006-03-15 Thread Jouni Malinen
On Mon, Mar 06, 2006 at 04:44:23PM +0100, Jiri Benc wrote: > This patch removes "iwmode" variable (local->conf.mode) shared by all > interfaces. Instead, every interface has its own type (STA/IBSS/AP/WDS). > Index: dscape/include/net/d80211.h >

Re: [RFC/PATCH 3/13] d80211: non-shared interface types

2006-03-15 Thread Jiri Benc
On Wed, 15 Mar 2006 09:40:52 -0800, Jouni Malinen wrote: > This breaks bcm43xx-d80211 build. Do you happen to have a patch to fix > it? Yes, I do. Sorry for not posting it. This is a first part; it's just ugly and quick (but working) fix. Index: dscape/drivers/net/wireless/bcm43xx-d80211/bcm43xx

Re: [RFC/PATCH 3/13] d80211: non-shared interface types

2006-03-15 Thread Jiri Benc
On Wed, 15 Mar 2006 18:47:40 +0100, Jiri Benc wrote: > On Wed, 15 Mar 2006 09:40:52 -0800, Jouni Malinen wrote: > > This breaks bcm43xx-d80211 build. Do you happen to have a patch to fix > > it? > > Yes, I do. Sorry for not posting it. > > This is a first part; it's just ugly and quick (but worki

Re: [RFC/PATCH 1/13] d80211: allow WDS remote to by set by WE

2006-03-15 Thread Jouni Malinen
On Mon, Mar 06, 2006 at 04:44:21PM +0100, Jiri Benc wrote: > Setting of address of WDS remote peer wasn't possible by a WE call. Remote > WDS peer can be understood as a remote AP and SIOCSIWAP/SIOCGIWAP are unused > in WDS mode, so let's use them. This sounds good, but I was unable to get this wo

Re: [RFC/PATCH 3/13] d80211: non-shared interface types

2006-03-15 Thread Jiri Benc
On Wed, 15 Mar 2006 09:40:52 -0800, Jouni Malinen wrote: > The same issue showed up with our low-level driver. How was the > low-level driver supposed to get this information with this change? >From struct ieee80211_if_conf in add_interface callback. > d80211 part is likely fine, since it has the

Re: [RFC/PATCH 3/13] d80211: non-shared interface types

2006-03-15 Thread Jouni Malinen
On Wed, Mar 15, 2006 at 06:47:40PM +0100, Jiri Benc wrote: > On Wed, 15 Mar 2006 09:40:52 -0800, Jouni Malinen wrote: > > This breaks bcm43xx-d80211 build. Do you happen to have a patch to fix > > it? > > Yes, I do. Sorry for not posting it. > > This is a first part; it's just ugly and quick (but

Re: [RFC/PATCH 3/13] d80211: non-shared interface types

2006-03-15 Thread Jouni Malinen
On Wed, Mar 15, 2006 at 06:59:53PM +0100, Jiri Benc wrote: > On Wed, 15 Mar 2006 09:40:52 -0800, Jouni Malinen wrote: > > The same issue showed up with our low-level driver. How was the > > low-level driver supposed to get this information with this change? > > From struct ieee80211_if_conf in add

Re: [RFC/PATCH 1/13] d80211: allow WDS remote to by set by WE

2006-03-15 Thread Jiri Benc
On Wed, 15 Mar 2006 09:52:26 -0800, Jouni Malinen wrote: > This sounds good, but I was unable to get this working. I created a WDS > link with initial peer address 00:01:02:03:04:05. This added the netdev > and STA entry correctly. However, when I run "iwconfig wds0 ap > 00:11:22:33:44:55", I do no

Re: [RFC/PATCH 3/13] d80211: non-shared interface types

2006-03-15 Thread Ivo van Doorn
On Wednesday 15 March 2006 19:02, Jouni Malinen wrote: > On Wed, Mar 15, 2006 at 06:47:40PM +0100, Jiri Benc wrote: > > On Wed, 15 Mar 2006 09:40:52 -0800, Jouni Malinen wrote: > > > This breaks bcm43xx-d80211 build. Do you happen to have a patch to fix > > > it? > > > > Yes, I do. Sorry for not p

Re: [PATCH netdev-2.6 ] e100: Fix eeh on pseries during ethtool -t

2006-03-15 Thread Jesse Brandeburg
On 3/11/06, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Jeff Kirsher wrote: > > Jeff - should a patch be made for 2.6.16 also? > > Yes, since this is a small fix and there aren't a ton of e100 changes, I > would prefer that you create a 'git pull' against 2.6.16-rc (latest > Linus git tree), and I wil

[PATCH 2.6.16-rc6] e1000: update the readme with the latest text

2006-03-15 Thread Jesse Brandeburg
From: Jesse Brandeburg <[EMAIL PROTECTED]> The text of the e1000.txt file is a little stale, lets freshen it up. (update) removed some non-kernel specific text Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> --- Documentation/networking/e1000.txt | 634 +++-

Re: [PATCH 2.6.16-rc6 0/3] MAINTAINERS, e100 and e1000 text file updates

2006-03-15 Thread Jesse Brandeburg
On 3/14/06, Jesse Brandeburg <[EMAIL PROTECTED]> wrote: > okay, here goes... these patches are against Linus's current tree. They only > update text files, no code updates. The large change to e1000.txt includes > whitespace changes, and some content. They could be included with 2.6.16 > as they

Re: [PATCH] ieee80211: Fix CCMP decryption problem when QoS is enabled

2006-03-15 Thread John W. Linville
On Wed, Mar 08, 2006 at 10:49:19AM +0800, Zhu Yi wrote: > > From: Zhu Yi <[EMAIL PROTECTED]> > Date: Tue, 28 Feb 2006 07:06:43 + (+0800) > > [PATCH] ieee80211: Fix CCMP decryption problem when QoS is enabled > > Use the correct STYPE for Qos data. Merged to the 'upstream-fixes' branch of wi

Please pull 'upstream-fixes' branch of wireless-2.6

2006-03-15 Thread John W. Linville
The following changes since commit f13b83580acef03a36c785dccc534ccdd7e43084: Adrian Bunk: fs/namespace.c:dup_namespace(): fix a use after free are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fixes Hong Liu: i

Re: [PATCH] ieee80211: Fix QoS is not active problem

2006-03-15 Thread John W. Linville
On Wed, Mar 08, 2006 at 10:50:20AM +0800, Zhu Yi wrote: > > From: Hong Liu <[EMAIL PROTECTED]> > Date: Wed, 8 Mar 2006 02:28:01 + (+0800) > > [PATCH] ieee80211: Fix QoS is not active problem > > Fix QoS is not active even the network and the card is QOS enabled. > The problem is we pass the

[PATCH]: e1000 endianness bugs

2006-03-15 Thread David S. Miller
return -E_NO_BIG_ENDIAN_TESTING; [E1000]: Fix 4 missed endianness conversions on RX descriptor fields. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 5b7d0f4..1d91117 100644 --- a/drivers/net/e1000/e1

Re: [PATCH]: e1000 endianness bugs

2006-03-15 Thread Jesse Brandeburg
On 3/15/06, David S. Miller <[EMAIL PROTECTED]> wrote: > > return -E_NO_BIG_ENDIAN_TESTING; > > [E1000]: Fix 4 missed endianness conversions on RX descriptor fields. > > Signed-off-by: David S. Miller <[EMAIL PROTECTED]> Yep, those look like bugs to me, thanks and congratulations, you're t

TSO still shuts-off on retrans?

2006-03-15 Thread Rick Jones
Just wanted to ask if TSO still shuts-off on a connection at the first retransmission? thanks, rick jones - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: TSO still shuts-off on retrans?

2006-03-15 Thread David S. Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Wed, 15 Mar 2006 15:32:11 -0800 > Just wanted to ask if TSO still shuts-off on a connection at the first > retransmission? No, it will not. All of the code paths that clear the NETIF_F_TSO bit in response to loss have been removed. - To unsubscribe fro

Re: TSO still shuts-off on retrans?

2006-03-15 Thread Rick Jones
David S. Miller wrote: From: Rick Jones <[EMAIL PROTECTED]> Date: Wed, 15 Mar 2006 15:32:11 -0800 Just wanted to ask if TSO still shuts-off on a connection at the first retransmission? No, it will not. Excellent! All of the code paths that clear the NETIF_F_TSO bit in response to loss h

Re: TSO still shuts-off on retrans?

2006-03-15 Thread David S. Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Wed, 15 Mar 2006 15:41:04 -0800 > David S. Miller wrote: > > All of the code paths that clear the NETIF_F_TSO bit in response > > to loss have been removed. > > When did that go-in? 2.6.14 I think. But best to test with current sources because there ha

Re: [PATCH]: e1000 endianness bugs

2006-03-15 Thread David S. Miller
From: "Jesse Brandeburg" <[EMAIL PROTECTED]> Date: Wed, 15 Mar 2006 15:33:43 -0800 > Yep, those look like bugs to me, thanks and congratulations, you're > the first person to test our PCI Express adapters in a big endian > system (they haven't been available before, and we don't have one, > yet)

Re: [RFC/PATCH 1/13] d80211: allow WDS remote to by set by WE

2006-03-15 Thread Jouni Malinen
On Wed, Mar 15, 2006 at 07:24:05PM +0100, Jiri Benc wrote: > On Wed, 15 Mar 2006 09:52:26 -0800, Jouni Malinen wrote: > > This sounds good, but I was unable to get this working. I created a WDS > > link with initial peer address 00:01:02:03:04:05. This added the netdev > > and STA entry correctly.

Re: [RFC/PATCH 6/13] d80211: remove obsolete stuff

2006-03-15 Thread Jouni Malinen
On Mon, Mar 06, 2006 at 04:44:26PM +0100, Jiri Benc wrote: > Because any number of interfaces may be added, bss_devs and sta_devs arrays > cannot be fixed-size arrays. We can make them linked lists, but they are > needed for optimalization only (and even that is questionable with > subsequent patc

RE: [RFC/PATCH 6/13] d80211: remove obsolete stuff

2006-03-15 Thread Simon Barber
The more natural way for beacons to flow from the 80211.o to the low level driver would be for beacons to be passed down just like any other 802.11 frame is passed down - rather than having a special case for beacons and buffered MC data, where they are pulled. I would suggest making the qdisc awar

Re: [RFC/PATCH 6/13] d80211: remove obsolete stuff

2006-03-15 Thread Jouni Malinen
On Wed, Mar 15, 2006 at 04:41:56PM -0800, Simon Barber wrote: > The more natural way for beacons to flow from the 80211.o to the low > level driver would be for beacons to be passed down just like any other > 802.11 frame is passed down - rather than having a special case for > beacons and buffered

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-15 Thread Russell Stuart
On Wed, 2006-03-15 at 10:21 -0500, jamal wrote: > It could - if it can proven to maintain backward compatibility. I > think backward compatibility would probably be fine to be defined as "it > works with one byte". > But you are right. It is a pain. One suggestion Stephen Hemminger had > was to tra

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-15 Thread Stephen Hemminger
On Thu, 16 Mar 2006 10:52:03 +1000 Russell Stuart <[EMAIL PROTECTED]> wrote: > On Wed, 2006-03-15 at 10:21 -0500, jamal wrote: > > It could - if it can proven to maintain backward compatibility. I > > think backward compatibility would probably be fine to be defined as "it > > works with one byte"

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-15 Thread jamal
On Thu, 2006-16-03 at 10:52 +1000, Russell Stuart wrote: > On Wed, 2006-03-15 at 10:21 -0500, jamal wrote: > > > I dont agree with reverting the 2.6.x change. In the future if you do prove > > that the old one is better or a newer one is better then we will revisit > > given the definition we hav

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-15 Thread Russell Stuart
Much discussion bashing this issue to death. (sorry, jamal - this one is CC'ed to lartc.) Here is are revised versions of the 2 as yet unapplied patches. PATCH 1 === [Has been applied.] PATCH 2 === In tc, the u32 sample clause uses the 2.4 hashing algorithm. The hashing algorithm use

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-15 Thread jamal
taken out lartc. On Thu, 2006-16-03 at 11:43 +1000, Russell Stuart wrote: [..] > PATCH 2 > === > > In tc, the u32 sample clause uses the 2.4 hashing algorithm. > The hashing algorithm used by the kernel changed in 2.6, > consequently "sample" hasn't work since then. > > This patch makes the

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-15 Thread Russell Stuart
On Wed, 2006-03-15 at 20:28 -0500, jamal wrote: > The variables again are: > a) the mask/mask size > b) the size of the buckets available example if you are masking on 2 > bits, then it doesnt matter if you have 256 buckets - only 4 get used. > So creating more than 4 is a waste of memory. > c) Th

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-15 Thread Russell Stuart
On Wed, 2006-03-15 at 20:56 -0500, jamal wrote: > I dont think Stephen would like that #if 0; however, this is not why > i am speaking up;-> I put it in there so it would be easy for someone using 2.4 to revert the patch, if they felt so inclined. Stephen let me know if you want it removed. > Yo

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-15 Thread jamal
On Thu, 2006-16-03 at 12:37 +1000, Russell Stuart wrote: > On Wed, 2006-03-15 at 20:28 -0500, jamal wrote: > > The variables again are: > > a) the mask/mask size > > b) the size of the buckets available example if you are masking on 2 > > bits, then it doesnt matter if you have 256 buckets - only

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-15 Thread jamal
On Thu, 2006-16-03 at 12:45 +1000, Russell Stuart wrote: > However, before anyone commits it, I would like to hear > your comments on my "compromise" hashing algorithm. I > would be a shame to have to patch it twice. > Refer to my other email - I think a lot more work is needed before reaching

2.6.15 localhost performance hit

2006-03-15 Thread Skunk Worx
Hello, I've taken a performance hit over localhost between kernels 2.6.14 and 2.6.15 in my client/server application. I'm trying to gut things down to a simple test case, in the meantime, this is what I've been discussing with the people at the fedora test list : This is only over localhost

Re: 2.6.15 localhost performance hit

2006-03-15 Thread Stephen Hemminger
On Wed, 15 Mar 2006 20:13:01 -0800 Skunk Worx <[EMAIL PROTECTED]> wrote: > Hello, > > I've taken a performance hit over localhost between kernels 2.6.14 and > 2.6.15 in my client/server application. > > I'm trying to gut things down to a simple test case, in the meantime, > this is what I've b

Re: 2.6.15 localhost performance hit

2006-03-15 Thread Stephen Hemminger
On Wed, 15 Mar 2006 20:13:01 -0800 Skunk Worx <[EMAIL PROTECTED]> wrote: > Hello, > > I've taken a performance hit over localhost between kernels 2.6.14 and > 2.6.15 in my client/server application. > > I'm trying to gut things down to a simple test case, in the meantime, > this is what I've b

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-15 Thread Russell Stuart
On Wed, 2006-03-15 at 22:07 -0500, jamal wrote: > Suppose you pick octet 3 of the dst IP address and we assume the full > range of that octet i.e a range of values 0-255 > (the details are a lot more complicated of where this byte belongs, > example this could be part of an IPV6 address and we tak

Re: [PATCH]: e1000 endianness bugs

2006-03-15 Thread Christoph Hellwig
On Wed, Mar 15, 2006 at 02:26:28PM -0800, David S. Miller wrote: > > return -E_NO_BIG_ENDIAN_TESTING; > > [E1000]: Fix 4 missed endianness conversions on RX descriptor fields. Could the e1000 maintainers please add endianess annotations so that sparse will catch such things in the future?