Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Greg KH
On Mon, Jun 05, 2006 at 09:18:18PM -0400, Jeff Garzik wrote: > On Mon, Jun 05, 2006 at 01:53:09PM -0700, Greg KH wrote: > > Why not just use the proper pci interface? Why poke around in another > > pci device to steal an irq, when that irq might not even be valid? > > (irqs are not valid until pci

Re: [NET]: Add netif_tx_lock

2006-06-05 Thread Roland Dreier
David> As long as you never take priv->lock while ->xmit_lock is David> held your patch should be OK. Duh ... unfortunately priv->lock is taken from interrupt context so that patch isn't safe. A correct fix would be the following, which leads to a trivial conversion to using netif_tx_lock

Re: [PATCH 1/1] LSM-IPsec SELinux Authorize (with minor fix)

2006-06-05 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Tue, 6 Jun 2006 01:37:04 -0400 (EDT) > On Tue, 6 Jun 2006, Catherine Zhang wrote: > > > Minor fix per James' comment. > > Can you also add a Signed-off-by line? > > I can't recall if you were the original author. If not, we also need a > From line

Re: [linux-usb-devel] [PATCH RFC] ZyDAS ZD1211 USB-WLAN driver

2006-06-05 Thread David Brownell
On Saturday 03 June 2006 3:25 pm, Oliver Neukum wrote: > Am Samstag, 3. Juni 2006 21:35 schrieb Daniel Drake: > > Oliver Neukum wrote: > > > +static int read_mac_addr(struct zd_chip *chip, u8 *mac_addr) > > > +{ > > > + static const zd_addr_t addr[2] = { CR_MAC_ADDR_P1, CR_MAC_ADDR_P2 }; > > > + re

Re: Linux kernel and laws

2006-06-05 Thread Evgeniy Polyakov
On Mon, Jun 05, 2006 at 04:02:26PM +0200, Adrian Bunk ([EMAIL PROTECTED]) wrote: > > Far too many people have a careless "U.S.A. laws suck, merge it anyway" > > attitude. > If someone would state a submission to the kernel might have issues > according to Chinese laws, or Iranian laws, or Russian

Re: [PATCH 1/1] LSM-IPsec SELinux Authorize (with minor fix)

2006-06-05 Thread James Morris
On Tue, 6 Jun 2006, Catherine Zhang wrote: > Minor fix per James' comment. Can you also add a Signed-off-by line? I can't recall if you were the original author. If not, we also need a >From line (per Documentation/SubmittingPatches). Thanks, -- James Morris <[EMAIL PROTECTED]> - To unsub

Re: [PATCH 2.6.18 1/3] tg3: Remove unnecessary tx_lock

2006-06-05 Thread Michael Chan
Herbert Xu wrote: > The paths where full lock is preceded by netif_tx_disable are > obviously > safe (well, once you take off the LLTX flag anyway). > However, there are > paths that don't do netif_tx_disable (e.g., tg3_set_rx_mode), are they > safe as well? > In places where we don't call tg

Re: [NET]: Add netif_tx_lock

2006-06-05 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Mon, 05 Jun 2006 21:57:51 -0700 > Roland> You know, looking at the ipoib code, I can't even recreate > Roland> why xmit_lock is taken in the set_multicast_list method > Roland> anyway, or how it works at all -- it seems > Roland> set_mu

Re: [NET]: Add netif_tx_lock

2006-06-05 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Mon, 05 Jun 2006 22:04:34 -0700 > Am I right in thinking that dev->xmit_lock still serializes mc_list > operations, even for LLTX drivers? Correct. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: [NET]: Add netif_tx_lock

2006-06-05 Thread Roland Dreier
David> Isn't the IPOIB driver LLTX and therefore the upper layers David> are not taking the xmit_lock? Yeah, but I think that should be OK. If I'm remembering the intention of the code correctly, the reason xmit_lock is being taken there is just to protect dev->mc_list -- and this is need

Re: [NET]: Add netif_tx_lock

2006-06-05 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Mon, 05 Jun 2006 21:50:11 -0700 > Roland> Sorry, I haven't followed this thread closely. Can you > Roland> expand on what the bug in ipoib's multicast locking is? > > You know, looking at the ipoib code, I can't even recreate why > xmit_lock

Re: [NET]: Add netif_tx_lock

2006-06-05 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Mon, 05 Jun 2006 21:44:01 -0700 > > IPOIB is going to BUG() with this change. Because now, in their > > multicast code, you're going to local_bh_disable() via > > netif_tx_unlock() with hw IRQs disabled which is illegal. > > > > It shows a bug h

Re: [NET]: Add netif_tx_lock

2006-06-05 Thread Roland Dreier
Roland> You know, looking at the ipoib code, I can't even recreate Roland> why xmit_lock is taken in the set_multicast_list method Roland> anyway, or how it works at all -- it seems Roland> set_multicast_list will always be called with xmit_lock Roland> already held. What the h

Re: [PATCH 1/1] LSM-IPsec SELinux Authorize (with minor fix)

2006-06-05 Thread James Morris
On Tue, 6 Jun 2006, Catherine Zhang wrote: > Minor fix per James' comment. Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Re: [NET]: Add netif_tx_lock

2006-06-05 Thread Roland Dreier
Roland> Sorry, I haven't followed this thread closely. Can you Roland> expand on what the bug in ipoib's multicast locking is? You know, looking at the ipoib code, I can't even recreate why xmit_lock is taken in the set_multicast_list method anyway, or how it works at all -- it seems set_

Re: [NET]: Add netif_tx_lock

2006-06-05 Thread Roland Dreier
> IPOIB is going to BUG() with this change. Because now, in their > multicast code, you're going to local_bh_disable() via > netif_tx_unlock() with hw IRQs disabled which is illegal. > > It shows a bug here in the locking of the IPOIB driver. Sorry, I haven't followed this thread closely.

[PATCH 1/1] LSM-IPsec SELinux Authorize (with minor fix)

2006-06-05 Thread Catherine Zhang
Hi, Minor fix per James' comment. thanks, Catherine -- This patch contains a fix for the previous patch that adds security contexts to IPsec policies and security associations. In the previous patch, no authorization (besides the check for write permissions to SAD and SPD) is required to delete

Re: [NET]: Add netif_tx_lock

2006-06-05 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 1 Jun 2006 21:15:04 +1000 > On Thu, Jun 01, 2006 at 10:25:25AM +1000, herbert wrote: > > > > > I think this netpoll wrinkle means we also have to make > > > sure to set the xmit_lock_owner across the board. > > > > You're right. In fact this can d

Re: [PATCH] unsigned long => __be32 in icmp_redirect()

2006-06-05 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Sun, 28 May 2006 01:29:25 +0400 > ip_rt_redirect() expects __be32 as second arg, so... > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> I'm going to cure this by simple killing the 'ip' variable altogether. It is assigned once, to iph->daddr

Re: [PATCH] Right prototype of __raw_v4_lookup()

2006-06-05 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Sun, 28 May 2006 01:09:32 +0400 > All users pass 32-bit values as addresses and internally they're compared with > 32-bit entities. So, change "laddr" and "raddr" types to __be32. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. Doe

Re: [PATCH] Fixup struct ip_mc_list::multiaddr type

2006-06-05 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Fri, 26 May 2006 23:30:09 +0400 > All users except two expect 32-bit big-endian value. One is of > > ->multiaddr = ->multiaddr > > variety. And last one is "%08lX". > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks Alex

Re: [PATCH] hush noisy ieee80211 CCMP printks

2006-06-05 Thread Jouni Malinen
On Mon, Jun 05, 2006 at 12:03:35PM -0400, Jason Lunz wrote: > If these are a real problem, I'll gladly help debug it. I'm using > 2.6.17-rc5's bcm43xx and the in-kernel ieee80211 softmac stack. I'm > using wpa/ccmp/aes with an openwrt AP. Do you happen to have a wireless sniffer that you could use

Re: [PATCH 2.6.18 1/3] tg3: Remove unnecessary tx_lock

2006-06-05 Thread Herbert Xu
On Mon, Jun 05, 2006 at 12:47:23PM -0700, Michael Chan wrote: > Remove tx_lock where it is unnecessary. tg3 runs lockless and so it > requires interrupts to be disabled and sync'ed, netif_queue and NAPI > poll to be stopped before the device can be reconfigured. After > stopping everything, it is n

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Jeff Garzik
On Mon, Jun 05, 2006 at 01:53:09PM -0700, Greg KH wrote: > Why not just use the proper pci interface? Why poke around in another > pci device to steal an irq, when that irq might not even be valid? > (irqs are not valid until pci_enable_device() is called on them...) Answered this question the la

Re: [PATCH 2.6.18 2/3] tg3: Convert to non-LLTX

2006-06-05 Thread Michael Chan
On Mon, 2006-06-05 at 17:31 -0700, Stephen Hemminger wrote: > On Mon, 05 Jun 2006 14:29:45 -0700 > "Michael Chan" <[EMAIL PROTECTED]> wrote: > > > On Mon, 2006-06-05 at 15:58 -0700, Stephen Hemminger wrote: > > > > > > > > Since you are going more lockless, you probably need memory barriers. > >

Re: [PATCH 2.6.18 2/3] tg3: Convert to non-LLTX

2006-06-05 Thread Stephen Hemminger
On Mon, 05 Jun 2006 14:29:45 -0700 "Michael Chan" <[EMAIL PROTECTED]> wrote: > On Mon, 2006-06-05 at 15:58 -0700, Stephen Hemminger wrote: > > > > > Since you are going more lockless, you probably need memory barriers. > > No, we're not going more lockless. We're simply replacing the private >

Re: [PATCH 2/2] e1000: remove risky prefetch on next_skb->data

2006-06-05 Thread Brandeburg, Jesse
On Mon, 5 Jun 2006, Rick Jones wrote: > Brandeburg, Jesse wrote: > > Hi Rick, according to our reporter, receives break. The prefetch (not > > always, but sometimes) lets the processor get junk from the prefetched > > area. Apparently this version of arm doesn't quite do as strict > > enforcement

Re: [PATCH 2/2] e1000: remove risky prefetch on next_skb->data

2006-06-05 Thread Andi Kleen
> Bear with me, I'm a software guy :) I interpret that to mean that the > processor is basically broken? If so, wouldn't it be the case that > prefetch() needs to become a noop on that processor? I would agree with Rick - if prefetch() is broken on Xscale it should be disabled in the archite

Re: [PATCH 2/2] e1000: remove risky prefetch on next_skb->data

2006-06-05 Thread Rick Jones
Brandeburg, Jesse wrote: On Mon, 5 Jun 2006, Rick Jones wrote: Kok, Auke wrote: It was brought to our attention that the prefetches break e1000 traffic on xscale/arm architectures. Remove them for now. We'll let them stay in mm for a while, or find a better solution to enable. Out of curio

Re: [PATCH 2/2] e1000: remove risky prefetch on next_skb->data

2006-06-05 Thread Brandeburg, Jesse
On Mon, 5 Jun 2006, Rick Jones wrote: > > Kok, Auke wrote: > > It was brought to our attention that the prefetches break e1000 traffic > > on xscale/arm architectures. Remove them for now. We'll let them > > stay in mm for a while, or find a better solution to enable. > > Out of curiousity, wh

Re: [PATCH] TCP changes for 2.6.18

2006-06-05 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 5 Jun 2006 11:03:31 -0700 > Dave, please consider adding these for the 2.6.18. I'll pick these into my tree by extracting out the patches. Your tree wasn't based upon the net-2.6.18 tree, so if I just pull it into mine I'll get all the upstre

[PATCH 1/2] PHYLIB: Add get_link ethtool helper function

2006-06-05 Thread Nathaniel Case
This adds a phy_ethtool_get_link() function along the same lines as phy_ethtool_gset(). This provides drivers utilizing PHYLIB an alternative to using ethtool_op_get_link(). This is more desirable since the "Link detected" field in ethtool would actually reflect the state of the PHY register. Pa

[PATCH 2/2] PHYLIB/gianfar: Use phy_ethtool_get_link() for get_link op

2006-06-05 Thread Nathaniel Case
This patch makes the gianfar ethtool code use phy_ethtool_get_link() instead of ethtool_op_get_link(). Patch depends on previous one (1/2). Signed-off-by: Nate Case <[EMAIL PROTECTED]> --- --- a/drivers/net/gianfar_ethtool.c 2006-06-05 11:27:19.0 -0500 +++ b/drivers/net/gianfar_etht

[PATCH 0/2] PHYLIB: Fix forcing mode reduction

2006-06-05 Thread Nathaniel Case
On Mon, 2006-06-05 at 17:08 -0500, Andy Fleming wrote: > Looks good. Feel free to send these patches to > netdev@vger.kernel.org (you may need to subscribe), and copy Jeff > Garzik <[EMAIL PROTECTED]>. This fixes a problem seen when a port without a cable connected would repeatedly print out

Re: [PATCH v3] bridge: fix locking and memory leak in br_add_bridge

2006-06-05 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 27 May 2006 09:45:28 -0700 > There are several bugs in error handling in br_add_bridge: > - when dev_alloc_name fails, allocated net_device is not freed > - unregister_netdev is called when rtnl lock is held > - free_netdev is called before ne

Re: MIB "ipInHdrErrors" error

2006-06-05 Thread David Miller
From: Wei Dong <[EMAIL PROTECTED]> Date: Thu, 25 May 2006 16:37:42 +0800 > When I test linux kernel 2.6.9-34, and find that kernel statistics > about ipInHdrErrors which exsits in file /proc/net/snmp doesn't increase > correctly. The criteria conform to RFC2011: > > ipInHdrErrors OBJECT-TYPE

Re: [patch 06/17] neighbour.c, pneigh_get_next() skips published entry

2006-06-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 01 Jun 2006 20:32:26 -0700 > From: "Jari Takkala" <[EMAIL PROTECTED]> > > Fix a problem where output from /proc/net/arp skips a record when the full > output does not fit into the users read() buffer. > > To reproduce: publish a large number of ARP entries (mor

Re: [PATCH 2/2] e1000: remove risky prefetch on next_skb->data

2006-06-05 Thread Rick Jones
Kok, Auke wrote: It was brought to our attention that the prefetches break e1000 traffic on xscale/arm architectures. Remove them for now. We'll let them stay in mm for a while, or find a better solution to enable. Out of curiousity, what breaks? rick jones - To unsubscribe from this list:

Re: [PATCH 2.6.18 2/3] tg3: Convert to non-LLTX

2006-06-05 Thread Michael Chan
On Mon, 2006-06-05 at 15:58 -0700, Stephen Hemminger wrote: > > Since you are going more lockless, you probably need memory barriers. No, we're not going more lockless. We're simply replacing the private tx_lock with dev->xmit_lock by dropping the LLTX feature flag. The amount of locking is exac

[PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-05 Thread Kok, Auke
Netpoll was broken due to the earlier addition of multiqueue. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000/e1000

[PATCH 0/2] e1000: fixes for netpoll+NAPI, ARM

2006-06-05 Thread Kok, Auke
Hi, This patch series implements two e1000 fixes: 1: fix netpoll with NAPI 2: fix ARM prefetch failure by removing risky prefetches These changes are available through git: git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream-fixes these patches are against netdev-2.6#upstream-fixes c

Re: [PATCH 2.6.18 2/3] tg3: Convert to non-LLTX

2006-06-05 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 5 Jun 2006 15:58:34 -0700 > Perhaps there is something simpler that could be done with a ring > model and some atomic primitives like cmpxchg()? cmpxchg() is something not available natively on many platforms, you can't even emulate it %100 p

[PATCH 2/2] e1000: remove risky prefetch on next_skb->data

2006-06-05 Thread Kok, Auke
It was brought to our attention that the prefetches break e1000 traffic on xscale/arm architectures. Remove them for now. We'll let them stay in mm for a while, or find a better solution to enable. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> -

Re: [PATCH] TCP: removal of unused label

2006-06-05 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 5 Jun 2006 16:02:40 -0700 > rtattr_failure is used inside __RTA_PUT() macro. It's gross, but there are > those who love it.. Yes, it was clear that this patch wasn't build tested. And GCC usually warns very loudly about truly unused labels.

Re: [PATCH] TCP: removal of unused label

2006-06-05 Thread Stephen Hemminger
On Mon, 5 Jun 2006 21:55:49 +0200 Francois Romieu <[EMAIL PROTECTED]> wrote: > > Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> > > diff --git a/net/ipv4/tcp_compound.c b/net/ipv4/tcp_compound.c > index bc54f7e..a3c36c0 100644 > --- a/net/ipv4/tcp_compound.c > +++ b/net/ipv4/tcp_compound.c >

Re: [PATCH 2.6.18 2/3] tg3: Convert to non-LLTX

2006-06-05 Thread Stephen Hemminger
On Mon, 05 Jun 2006 12:47:32 -0700 "Michael Chan" <[EMAIL PROTECTED]> wrote: > Herbert Xu pointed out that it is unsafe to call netif_tx_disable() > from LLTX drivers because it uses dev->xmit_lock to synchronize > whereas LLTX drivers use private locks. > > Convert tg3 to non-LLTX to fix this is

Re: [PATCH 1/1] LSM-IPsec SELinux Authorize

2006-06-05 Thread James Morris
On Mon, 5 Jun 2006, Catherine Zhang wrote: Looks ok to me, except for one minor nit: > + if (ctx) { > + rc = avc_has_perm(tsec->sid, ctx->ctx_sid, > + SECCLASS_ASSOCIATION, > + ASSOCIATION__SETCONTEXT, NULL); > + } you don't need the braces here (simi

Please pull 'upstream' branch of wireless-2.6

2006-06-05 Thread John W. Linville
This pull is intended for 2.6.18. Thanks, John --- The following changes since commit f6882a0688ea83db5fc2f3491ac9fcdce0834cc7: John W. Linville: Merge branch 'upstream-fixes' into upstream are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/

Please pull 'upstream-fixes' branch of wireless-2.6

2006-06-05 Thread John W. Linville
This pull is intended for 2.6.17 if at all possible. Thanks, John --- The following changes since commit 672c6108a51bf559d19595d9f8193dfd81f0f752: Linus Torvalds: Merge master.kernel.org:/.../jejb/scsi-rc-fixes-2.6 are found in the git repository at: git://git.kernel.org/pub/scm/l

[PATCH 2.6.18 3/3] tg3: Add tg3_netif_stop() in vlan funtions

2006-06-05 Thread Michael Chan
Add tg3_netif_stop() when changing the vlgrp (vlan group) pointer. It is necessary to quiesce the device before changing that pointer. Update version to 3.60 Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index f085890..d97cded 100644 --- a/dr

[PATCH 2.6.18 1/3] tg3: Remove unnecessary tx_lock

2006-06-05 Thread Michael Chan
Remove tx_lock where it is unnecessary. tg3 runs lockless and so it requires interrupts to be disabled and sync'ed, netif_queue and NAPI poll to be stopped before the device can be reconfigured. After stopping everything, it is no longer necessary to get the tx_lock. Signed-off-by: Michael Chan <[

[PATCH 2.6.18 2/3] tg3: Convert to non-LLTX

2006-06-05 Thread Michael Chan
Herbert Xu pointed out that it is unsafe to call netif_tx_disable() from LLTX drivers because it uses dev->xmit_lock to synchronize whereas LLTX drivers use private locks. Convert tg3 to non-LLTX to fix this issue. tg3 is a lockless driver where hard_start_xmit and tx completion handling can run c

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Jiri Slaby
Greg KH napsal(a): > On Mon, Jun 05, 2006 at 10:20:07PM +0200, Jiri Slaby wrote: >> bcm43xx avoid pci_find_device >> >> Change pci_find_device to safer pci_get_device with support for more >> devices. >> >> Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> >> >> --- >> commit 4b73c16f5411d97360d5f26f29

Re: [PATCH] Changes to ieee80211.h for user space regulatory daemon

2006-06-05 Thread Larry Finger
John W. Linville wrote: @@ -968,6 +968,7 @@ #define IEEE80211_52GHZ_CHANNELS (IEEE80 enum { IEEE80211_CH_PASSIVE_ONLY = (1 << 0), + IEEE80211_CH_80211H_RULES = (1 << 1), IEEE80211_CH_B_ONLY = (1 << 2), IEEE80211_CH_NO_IBSS = (1 << 3), IEEE80211_CH_UNIFORM_S

Re: [PATCH 3/3] pci: gt96100eth avoid pci_find_device

2006-06-05 Thread Jiri Slaby
Jiri Slaby napsal(a): > gt96100eth avoid pci_find_device > > Change pci_find_device to safer pci_get_device with support for more > bridges. > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> > > --- > commit fd863b81ac491faf783ff7f2dcf6032177c5ab7f > tree d7eb59f897505230023754f19ad7227eec39e676

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Greg KH
On Mon, Jun 05, 2006 at 10:20:07PM +0200, Jiri Slaby wrote: > bcm43xx avoid pci_find_device > > Change pci_find_device to safer pci_get_device with support for more > devices. > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> > > --- > commit 4b73c16f5411d97360d5f26f292ffddeb670ff75 > tree 6e43c

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Jiri Slaby
Michael Buesch napsal(a): > On Monday 05 June 2006 22:18, Jiri Slaby wrote: >> bcm43xx avoid pci_find_device >> >> Change pci_find_device to safer pci_get_device with support for more >> devices. > > I am wondering about the reference count. > From docbook: > > 256 * pci_get_device - begin or co

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Michael Buesch
On Monday 05 June 2006 22:18, Jiri Slaby wrote: > bcm43xx avoid pci_find_device > > Change pci_find_device to safer pci_get_device with support for more > devices. I am wondering about the reference count. >From docbook: 256 * pci_get_device - begin or continue searching for a PCI device by ve

[PATCH 0/3 #3] avoid pci_find_device

2006-06-05 Thread Jiri Slaby
Hello, there are some patches to avoid pci_find_device in drivers. I will make a bcm43xx patch against wireless git too. Take #3. It's against 2.6.17-rc5-mm3 tree. 01-i2c-scx200-acb-avoid-pci-find-device.patch 02-bcm43xx-avoid-pci-find-device.patch 03-gt96100eth-avoid-pci-find-device.patch i2

Re: [PATCH,RFT] bcm43xx: use softmac-suggested TX rate

2006-06-05 Thread John W. Linville
On Mon, Jun 05, 2006 at 08:48:39PM +0100, Daniel Drake wrote: > Michael Buesch wrote: > >On Monday 05 June 2006 21:17, John W. Linville wrote: > >>OK, I will now 'officially' forget about this patch, and wait for you > >>to endorse it by re-sending it to me. :-) > > > >Ok, but it depends on this pa

[PATCH] TCP: removal of unused label

2006-06-05 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> diff --git a/net/ipv4/tcp_compound.c b/net/ipv4/tcp_compound.c index bc54f7e..a3c36c0 100644 --- a/net/ipv4/tcp_compound.c +++ b/net/ipv4/tcp_compound.c @@ -401,6 +401,7 @@ static void tcp_compound_cong_avoid(stru static void tcp_compound_get_in

[PATCH 1/1] LSM-IPsec SELinux Authorize

2006-06-05 Thread Catherine Zhang
Hi, This is resubmit of the LSM-IPsec fix patch rebased against Linux version 2.6.17-rc4-mm3. As always, comments are welcome! Catherine --- This patch contains a fix for the previous patch that adds security contexts to IPsec policies and security associations. In the previous patch, no au

Re: [PATCH,RFT] bcm43xx: use softmac-suggested TX rate

2006-06-05 Thread Daniel Drake
Michael Buesch wrote: On Monday 05 June 2006 21:17, John W. Linville wrote: OK, I will now 'officially' forget about this patch, and wait for you to endorse it by re-sending it to me. :-) Ok, but it depends on this patch, which does not seem to be in your tree, yet. http://marc.theaimsgroup.co

Re: [PATCH 2.6.17-rc5] support for TSO over IPv6.

2006-06-05 Thread Stephen Hemminger
On Mon, 5 Jun 2006 15:09:45 -0400 (EDT) Ananda Raju <[EMAIL PROTECTED]> wrote: > Hi, > Neterion Xframe adapter supports TSO over IPv6 but the linux kernel > don't support TSO over Ipv6. This patch will allow TCP > Segmentation Offload (TSO) packets to be created over IPv6. >

Re: [PATCH,RFT] bcm43xx: use softmac-suggested TX rate

2006-06-05 Thread John W. Linville
On Mon, Jun 05, 2006 at 09:28:55PM +0200, Michael Buesch wrote: > On Monday 05 June 2006 21:17, John W. Linville wrote: > > OK, I will now 'officially' forget about this patch, and wait for you > > to endorse it by re-sending it to me. :-) > > Ok, but it depends on this patch, which does not seem

Re: [PATCH,RFT] bcm43xx: use softmac-suggested TX rate

2006-06-05 Thread Michael Buesch
On Monday 05 June 2006 21:17, John W. Linville wrote: > OK, I will now 'officially' forget about this patch, and wait for you > to endorse it by re-sending it to me. :-) Ok, but it depends on this patch, which does not seem to be in your tree, yet. http://marc.theaimsgroup.com/?l=linux-netdev&m=11

Re: [PATCH] hush noisy ieee80211 CCMP printks

2006-06-05 Thread John W. Linville
On Mon, Jun 05, 2006 at 12:03:35PM -0400, Jason Lunz wrote: > If the messages are actually useful, and unusual, then they should > probably stay. But I get a LOT of them, and my wireless is working just > fine. I'm dropping this patch, based on Jouni's comments. If you want to reformulate a patc

Re: [PATCH,RFT] bcm43xx: use softmac-suggested TX rate

2006-06-05 Thread John W. Linville
On Mon, Jun 05, 2006 at 09:15:54PM +0200, Michael Buesch wrote: > On Monday 05 June 2006 20:51, John W. Linville wrote: > > On Fri, May 19, 2006 at 08:32:46PM +0200, Michael Buesch wrote: > > > On Friday 19 May 2006 20:44, you wrote: > > > > John W. Linville wrote: > > > > > Do you intend for this

Re: [PATCH,RFT] bcm43xx: use softmac-suggested TX rate

2006-06-05 Thread Michael Buesch
On Monday 05 June 2006 20:51, John W. Linville wrote: > On Fri, May 19, 2006 at 08:32:46PM +0200, Michael Buesch wrote: > > On Friday 19 May 2006 20:44, you wrote: > > > John W. Linville wrote: > > > > Do you intend for this to be merged? Given recent miscommunication, > > > > I figured I should a

[PATCH 2.6.17-rc5] support for TSO over IPv6.

2006-06-05 Thread Ananda Raju
Hi, Neterion Xframe adapter supports TSO over IPv6 but the linux kernel don't support TSO over Ipv6. This patch will allow TCP Segmentation Offload (TSO) packets to be created over IPv6. The following table shows there is significant improvement in

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread Jiri Slaby
John W. Linville napsal(a): > On Fri, May 26, 2006 at 01:29:12PM +0159, Jiri Slaby wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Jeff Garzik napsal(a): >>> Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): > The point i

Re: orinoco encodeext + auth patch on lkml

2006-06-05 Thread John W. Linville
On Fri, Jun 02, 2006 at 01:38:05AM -0400, Pavel Roskin wrote: > Hello, Dan! > > On Wed, 2006-05-31 at 08:03 -0400, Dan Williams wrote: > > Pavel, > > > > Unsure if you saw this. Slightly annoying he didn't send to netdev, but > > would be good to take a look at and possibly integrate. Looks san

Re: [PATCH] Changes to ieee80211.h for user space regulatory daemon

2006-06-05 Thread John W. Linville
On Tue, May 30, 2006 at 11:55:42AM -0500, Larry Finger wrote: > Attached are two small patches for include/net/ieee80211.h to prepare for > later submission of code to implement a user-space daemon that supplies > 802.11 regulatory information. > > The first change adds a bit indicating that 802

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-06-05 Thread John W. Linville
On Fri, May 26, 2006 at 01:29:12PM +0159, Jiri Slaby wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Jeff Garzik napsal(a): > > Jiri Slaby wrote: > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA1 > >> > >> Jeff Garzik napsal(a): > >>> The point is that you don't need to loop ove

Re: 2.6.17-rc5-mm3

2006-06-05 Thread Andrew Morton
On Mon, 5 Jun 2006 18:56:37 +0100 [EMAIL PROTECTED] (Mel Gorman) wrote: > > I am seeing more networking-related funniness with 2.6.17-rc5-mm3 on the > same machine previously fixed by git-net-llc-fix.patch. The console log is > below. I've done no investigation work in case it's a known problem.

Re: [PATCH,RFT] bcm43xx: use softmac-suggested TX rate

2006-06-05 Thread John W. Linville
On Fri, May 19, 2006 at 08:32:46PM +0200, Michael Buesch wrote: > On Friday 19 May 2006 20:44, you wrote: > > John W. Linville wrote: > > > Do you intend for this to be merged? Given recent miscommunication, > > > I figured I should ask... :-) > > > > Nobody has tested it yet, so no, but thanks f

Re: [PATCH, RTF/RFC] bcm43xx: Enable local IRQs while executing periodic work

2006-06-05 Thread John W. Linville
On Tue, May 23, 2006 at 05:23:09PM +0200, Michael Buesch wrote: > I would like to get this into wireless-2.6, but before that > happens I would like to have a few regression tests by people. > Please apply this and run high network traffic for 10-15 minutes. > Please enable kernel spinlock lockup

[PATCH 1/2] bcm43xx: redesign locking

2006-06-05 Thread Michael Buesch
John, please queue for 2.6.18. -- Redesign the bcm43xx locking. This is pre-work to get a preemptible periodic work handler. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/bcm43xx/bcm43xx.h =

[PATCH 2/2] bcm43xx: preemptible periodic work

2006-06-05 Thread Michael Buesch
John, please queue for 2.6.18. This patch depends on [PATCH 1/2] bcm43xx: redesign locking -- Make the heavy periodic work preemptible to avoid disabling local IRQs for several msecs. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/bcm43xx/bcm43xx_main

[PATCH] TCP changes for 2.6.18

2006-06-05 Thread Stephen Hemminger
Dave, please consider adding these for the 2.6.18. The following changes since commit 672c6108a51bf559d19595d9f8193dfd81f0f752: Linus Torvalds: Merge master.kernel.org:/.../jejb/scsi-rc-fixes-2.6 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/shemm

[PATCH] net.ipv4.ip_autoconfig sysctl removal

2006-06-05 Thread Stephen Hemminger
The sysctl net.ipv4.ip_autoconfig is a legacy value that is not used. Can it finally go in 2.6.18 or do we need to go through the whole feature-removal process? Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> diff --git a/include/net/ip.h b/include/net/ip.h index 3d2e5ca..ead233c 100644 --

Re: [RFC] TCP limited slow start

2006-06-05 Thread Stephen Hemminger
On Sat, 03 Jun 2006 12:46:57 -0400 John Heffner <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > Rolled my sleeve's up and gave this a try... > > > > This is a implementation of Sally Floyd's Limited Slow Start > > for Large Congestion Windows. > > Limited slow start is useful as a work

Re: TCP Westwood Patch

2006-06-05 Thread Stephen Hemminger
On Wed, 24 May 2006 18:20:06 +0200 Luca De Cicco <[EMAIL PROTECTED]> wrote: > Hi there to the list. > > I'm Luca De Cicco a PhD student working on TCP Westwood+ at Politecnico > di Bari. > > I have attached a patch (it applies to 2.6.16.18 but it has been also > tested on 2.6.15 too) for the TCP

Re: move zd1201 where it belongs

2006-06-05 Thread Greg KH
On Mon, Jun 05, 2006 at 10:47:26AM -0400, John W. Linville wrote: > On Mon, Jun 05, 2006 at 04:29:12PM +0200, Pavel Machek wrote: > > > > Did you mean to only copy Jiri and LKML? > > > > Yes, because this should go in as a git patch (so it is move, not > > create new file), and I was hoping for J

Re: wireless (was Re: 2.6.18 -mm merge plans)

2006-06-05 Thread Alan Cox
Ar Llu, 2006-06-05 am 09:27 -0400, ysgrifennodd John W. Linville: > Does not the Signed-off-by: line on a patch submission give us some > level of "good faith" protection? > > I'm tempted to take contributors at their word, that they have produced > their own work and not copied from others. What

Re: [PATCH] hush noisy ieee80211 CCMP printks

2006-06-05 Thread Jason Lunz
On Mon, Jun 05, 2006 at 06:31:48AM -0700, Jouni Malinen wrote: > These are not normal, i.e., they should not really show up unless > something goes wrong. If these are a real problem, I'll gladly help debug it. I'm using 2.6.17-rc5's bcm43xx and the in-kernel ieee80211 softmac stack. I'm using wpa

Re: move zd1201 where it belongs

2006-06-05 Thread Jiri Benc
On Mon, 5 Jun 2006 16:29:12 +0200, Pavel Machek wrote: > Yes, because this should go in as a git patch (so it is move, not > create new file), and I was hoping for Jiri to generate proper > git-patch :-). The proper person for this is maintainer of wireless or USB. > Here it is, still > > Signed

Re: move zd1201 where it belongs

2006-06-05 Thread John W. Linville
On Mon, Jun 05, 2006 at 04:29:12PM +0200, Pavel Machek wrote: > > Did you mean to only copy Jiri and LKML? > > Yes, because this should go in as a git patch (so it is move, not > create new file), and I was hoping for Jiri to generate proper > git-patch :-). Ah, I see. Well, I can handle this j

Re: move zd1201 where it belongs

2006-06-05 Thread Pavel Machek
Hi! > > > > zd1201 is wifi adapter, yet it is hiding in drivers/usb/net where > > > > noone can find it. This moves Kconfig/Makefile to right place; you > > > > still need to manually move .c and .h files. > > > > do you think it should at least depend in some form or another on > > > CONFIG_USB

Re: Linux kernel and laws

2006-06-05 Thread linux-os \(Dick Johnson\)
On Mon, 5 Jun 2006, Adrian Bunk wrote: > On Mon, Jun 05, 2006 at 08:52:35AM -0400, Jeff Garzik wrote: >> ... >>> Paying attention to proper reverse engineering is good. Being >>> overzealous is not. >> >> Being overzealous about merging drivers without first checking the legal >> ramifications is

Re: move zd1201 where it belongs

2006-06-05 Thread John W. Linville
On Mon, Jun 05, 2006 at 01:33:33PM +0200, Pavel Machek wrote: > On Po 05-06-06 13:15:20, Arjan van de Ven wrote: > > On Mon, 2006-06-05 at 12:39 +0200, Pavel Machek wrote: > > > zd1201 is wifi adapter, yet it is hiding in drivers/usb/net where > > > noone can find it. This moves Kconfig/Makefile to

Linux kernel and laws

2006-06-05 Thread Adrian Bunk
On Mon, Jun 05, 2006 at 08:52:35AM -0400, Jeff Garzik wrote: >... > > Paying attention to proper reverse engineering is good. Being > > overzealous is not. > > Being overzealous about merging drivers without first checking the legal > ramifications is a good way to torpedo Linux. > > Far too many

Re: wireless (was Re: 2.6.18 -mm merge plans)

2006-06-05 Thread Arjan van de Ven
> Of course, I didn't know there were serious concerns about this > driver's origin. I hope we aren't confusing this with the atheros > driver...? > > > Please don't let this reverse engineering idiocy hinder wireless driver > > adoption, we're already falling far behind openbsd who are very suc

Re: [PATCH] hush noisy ieee80211 CCMP printks

2006-06-05 Thread Jouni Malinen
On Sun, Jun 04, 2006 at 08:12:09PM -0400, Jason Lunz wrote: > Don't swamp syslog with > CCMP: decrypt failed: STA=00:12:17:3a:e2:c7 > and > CCMP: replay detected: STA=00:12:17:3a:e2:c7 previous PN 0004 > received PN 0004 > messages. > > These both seem to be completely normal in

Re: wireless (was Re: 2.6.18 -mm merge plans)

2006-06-05 Thread Christoph Hellwig
On Mon, Jun 05, 2006 at 09:27:37AM -0400, John W. Linville wrote: > Actually, I was planning to merge the softmac-based version for 2.6.18. > It looks like I may want some of Andrew's patches on top (ia64, alpha, etc). duh, didn't know that wasn't in -mm. we want the softmac version of course. -

Re: wireless (was Re: 2.6.18 -mm merge plans)

2006-06-05 Thread John W. Linville
On Mon, Jun 05, 2006 at 09:54:51AM +0100, Christoph Hellwig wrote: > On Sun, Jun 04, 2006 at 09:06:36PM -0400, Jeff Garzik wrote: > > On Sun, Jun 04, 2006 at 01:50:11PM -0700, Andrew Morton wrote: > > > acx1xx-wireless-driver.patch > > > fix-tiacx-on-alpha.patch > > > tiacx-fix-attribute-packed-war

Re: wireless (was Re: 2.6.18 -mm merge plans)

2006-06-05 Thread Jeff Garzik
On Mon, Jun 05, 2006 at 02:48:27PM +0200, Arjan van de Ven wrote: > Why is it a good thing you are blocking this driver? Do you have ANY > indication AT ALL that there is anything fishy about it? Yes. > Paying attention to proper reverse engineering is good. Being > overzealous is not. Being ov

Re: wireless (was Re: 2.6.18 -mm merge plans)

2006-06-05 Thread Arjan van de Ven
> > It's a good thing I pay attention to this issue, too, Mr. Just Go Ahead > And Merge It. dude, name calling is way out of line here. Why is it a good thing you are blocking this driver? Do you have ANY indication AT ALL that there is anything fishy about it? (and don't say "they didn't follo

Re: wireless (was Re: 2.6.18 -mm merge plans)

2006-06-05 Thread Jeff Garzik
On Mon, Jun 05, 2006 at 09:54:51AM +0100, Christoph Hellwig wrote: > On Sun, Jun 04, 2006 at 09:06:36PM -0400, Jeff Garzik wrote: > > On Sun, Jun 04, 2006 at 01:50:11PM -0700, Andrew Morton wrote: > > > acx1xx-wireless-driver.patch > > > fix-tiacx-on-alpha.patch > > > tiacx-fix-attribute-packed-war

Re: wireless (was Re: 2.6.18 -mm merge plans)

2006-06-05 Thread Alan Cox
Ar Llu, 2006-06-05 am 12:35 +0200, ysgrifennodd Arjan van de Ven: > And to be fair the pwc camera driver was just a guy with a personality > problem rather than any real legal standing. I must disagree there having reviewed the code in question and been directly involved in the fallout. Alan -

  1   2   >