Re: [patch 1/7] net_device list cleanup: core

2006-07-09 Thread Andrey Savochkin
On Sat, Jul 08, 2006 at 01:48:13AM +0900, YOSHIFUJI Hideaki / [EMAIL PROTECTED](B wrote: > In article <[EMAIL PROTECTED]> (at Fri, 7 Jul 2006 11:54:25 +0400), Andrey > Savochkin <[EMAIL PROTECTED]> says: > > > On Fri, Jul 07, 2006 at 01:34:34PM +0900, YOSHIFUJI Hideaki / [EMAIL > > PROTECTED](B

Re: [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on()

2006-07-09 Thread Stefan Rompf
[Trimmed CC list as we're off topic] Am Sonntag, 9. Juli 2006 22:05 schrieb Krzysztof Halasa: > >> ... and where the maintainer doesn't seem to care to use it now that the > >> infrastructure is there. Sigh. > > This is very different from what I proposed and doesn't fit very well. > We've been d

Re: [2.6 patch] netfilter: fix SYSCTL=n compile

2006-07-09 Thread Patrick McHardy
Adrian Bunk wrote: > This patch fixes the following compile errors with CONFIG_SYSCTL=n > introduced by commit 39a27a35c5c1b5be499a0576a35c45a011788bf8: Thanks, applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordo

Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-09 Thread Dan Williams
On Mon, 2006-07-10 at 00:23 +0200, Robert Schulze wrote: > Hi, > > ok lets keep that message to be visible to anybody, but put it into one line. > Thanks for your comments. > Now, I will track down what causes the error on my machine, I think it has > something todo with pcmcia... Looks good. T

Re: [IPV4] inetpeer: Get rid of volatile from peer_total

2006-07-09 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 10 Jul 2006 09:07:11 +1000 > [IPV4] inetpeer: Get rid of volatile from peer_total > > The variable peer_total is protected by a lock. The volatile marker > makes no sense. This shaves off 20 bytes on i386. > > Signed-off-by: Herbert Xu <[EMAIL PR

Re: [PKT_SCHED]: act_api: Fix module leak while flushing actions

2006-07-09 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Sun, 9 Jul 2006 21:57:34 +0200 > * David Miller <[EMAIL PROTECTED]> 2006-07-09 11:38 > > I'll try to cons something up when I get a chance. The current > > situation is too error prone. > > I agree, that's why the new netlink api offers label free > me

Re: [AX.25] Get rid of the last volatile.

2006-07-09 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Sun, 9 Jul 2006 23:37:45 +0100 > This volatile makes no sense - not even wearing pink shades ... > > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied, thanks Ralf :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on()

2006-07-09 Thread David Miller
From: Krzysztof Halasa <[EMAIL PROTECTED]> Date: Sun, 09 Jul 2006 22:05:43 +0200 > I'm a single developer BTW. So am I, and I've been keeping the core networking and the sparc64 port afloat for more than 10 years. In comparison, very little is being asked of you. - To unsubscribe from this list:

[2.6 patch] netfilter: fix SYSCTL=n compile

2006-07-09 Thread Adrian Bunk
On Sun, Jul 09, 2006 at 05:37:35AM +0200, Patrick McHardy wrote: > Adrian Bunk wrote: > > This patch fixes the following compile error with CONFIG_SYSCTL=n > > introduced by commit 39a27a35c5c1b5be499a0576a35c45a011788bf8: > > My fault I guess. > > > <-- snip --> > > > > ... > > LD .tm

[IPV4] inetpeer: Get rid of volatile from peer_total

2006-07-09 Thread Herbert Xu
Hi Dave: Just joining on the fun on volatile :) [IPV4] inetpeer: Get rid of volatile from peer_total The variable peer_total is protected by a lock. The volatile marker makes no sense. This shaves off 20 bytes on i386. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Cheers, -- Visit Openswan

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-09 Thread Jamal Hadi Salim
On Sun, 2006-09-07 at 17:54 +0200, Thomas Graf wrote: > Look at where dev->queue_lock is taken, whenever a qdisc or > filter is added, modified or deleted the lock is taken. Using > your approach packets get dropped while such an operation is > taking place. True, this will be bad for devices th

Re: [PATCH] d80211: make sleeping in hw->config possible

2006-07-09 Thread Michael Buesch
On Sunday 09 July 2006 20:47, you wrote: > === > --- wireless-dev-dscapeports.orig/net/d80211/ieee80211.c 2006-06-17 > 21:26:10.0 +0200 > +++ wireless-dev-dscapeports/net/d80211/ieee80211.c 2006-07-09 > 20:01:42.00

[AX.25] Get rid of the last volatile.

2006-07-09 Thread Ralf Baechle
This volatile makes no sense - not even wearing pink shades ... Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/net/ax25/ax25_in.c b/net/ax25/ax25_in.c index 4cf8754..e9d9429 100644 --- a/net/ax25/ax25_in.c +++ b/net/ax25/ax25_in.c @@ -102,8 +102,8 @@ static int ax25_rx_fragment(ax25

Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-09 Thread Robert Schulze
Hi, ok lets keep that message to be visible to anybody, but put it into one line. Thanks for your comments. Now, I will track down what causes the error on my machine, I think it has something todo with pcmcia... with kind regards, Robert Schulze --- linux-2.6.17.1/drivers/net/wireless/airo.c

Re: [PATCH] d80211: make sleeping in hw->config possible

2006-07-09 Thread Ivo Van Doorn
Hi, Please apply this to wireless-dev. -- This patch makes sleeping in the hw->config callback possible by removing the only atomic caller. The atomic caller was a timer and is replaced by a workqueue. In general, allowing to sleep in the config callback is a good thing. bcm43xx must be able

Re: [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on()

2006-07-09 Thread Krzysztof Halasa
David Miller <[EMAIL PROTECTED]> writes: >> > Not really. The flag code last major change was to do the dormant >> > stuff that HDLC wanted. >> >> ... and where the maintainer doesn't seem to care to use it now that the >> infrastructure is there. Sigh. This is very different from what I propos

Re: [PKT_SCHED]: act_api: Fix module leak while flushing actions

2006-07-09 Thread Thomas Graf
* David Miller <[EMAIL PROTECTED]> 2006-07-09 11:38 > From: Thomas Graf <[EMAIL PROTECTED]> > Date: Sun, 9 Jul 2006 16:20:43 +0200 > > > Module reference needs to be given back if message header > > construction fails. > > > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> > > Applied, thanks Th

Re: [AX.25] Use kzalloc

2006-07-09 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Sun, 9 Jul 2006 02:52:00 +0100 > Replace kzalloc instead of kmalloc + memset. > > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied, thanks Ralf. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EM

Re: [2.6 patch] net/atm/clip.c: fix PROC_FS=n compile

2006-07-09 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sat, 8 Jul 2006 22:20:01 +0200 > This patch fixes the following compile error with CONFIG_PROC_FS=n by > reverting commit dcdb02752ff13a64433c36f2937a58d93ae7a19e: Applied, thanks Adrian. - To unsubscribe from this list: send the line "unsubscribe netd

[PATCH] d80211: make sleeping in hw->config possible

2006-07-09 Thread Michael Buesch
Hi John, Please apply this to wireless-dev. -- This patch makes sleeping in the hw->config callback possible by removing the only atomic caller. The atomic caller was a timer and is replaced by a workqueue. In general, allowing to sleep in the config callback is a good thing. bcm43xx must be ab

Re: [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on()

2006-07-09 Thread David Miller
From: Stefan Rompf <[EMAIL PROTECTED]> Date: Sun, 9 Jul 2006 10:49:31 +0200 > Am Freitag, 7. Juli 2006 23:33 schrieb Stephen Hemminger: > > > Not really. The flag code last major change was to do the dormant > > stuff that HDLC wanted. > > ... and where the maintainer doesn't seem to care to use

Re: [PKT_SCHED]: act_api: Fix module leak while flushing actions

2006-07-09 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Sun, 9 Jul 2006 16:20:43 +0200 > Module reference needs to be given back if message header > construction fails. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied, thanks Thomas. This reminds me of something, not only are non-networking devel

Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-09 Thread Michael Tokarev
Robert Schulze wrote: > Hi, > > Dan Williams schrieb: >> This message will only happen if the card hangs up and stops responding >> to commands anyway, so we don't necessarily care about making the >> message decipherable to anyone other than developers. > > Well, I get this message each time I i

[2.6 patch] drivers/net/wireless/zd1211rw/: possible cleanups

2006-07-09 Thread Adrian Bunk
This patch contains the following possible cleanups: - make needlessly global functions static - #if 0 unused functions Please review which of these functions do make sense and which do conflict with pending patches. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/wireless/zd12

Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-09 Thread Robert Schulze
Hi, Dan Williams schrieb: > This message will only happen if the card hangs up and stops responding > to commands anyway, so we don't necessarily care about making the > message decipherable to anyone other than developers. Well, I get this message each time I insert my Cisco Aironet 350 PCMCIA

Re: rtl8139: NETDEV WATCHDOG: eth0: transmit timed out

2006-07-09 Thread Marcus Better
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thomas Hellström wrote: > Strange. I've also seen the i915 sending false interrupts on its own > line, though. Here's the interrupt table with i915 loaded: ~$ cat /proc/interrupts CPU0 0: 401031 XT-PIC timer 1: 3681

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-09 Thread Thomas Graf
* Jamal Hadi Salim <[EMAIL PROTECTED]> 2006-07-09 11:00 > If you mean that the device will also try to grab the qlock there, then > that is fine still for the serialization. It all starts at > dev_queue_xmit. Look at where dev->queue_lock is taken, whenever a qdisc or filter is added, modified or

[PATCH RFC]rfkill - Hardware button support for Wireless cards

2006-07-09 Thread Ivo Van Doorn
Hi, I have been quite busy lately, hence the reason for this late continuance of the Hardware button support for Wireless cards discussion. I have CC'ed the people who discussed this in earlier threads. With the suggestions made by Vojtech Pavlik I have created the rfkill driver, for which I wou

Re: skge error; hangs w/ hardware memory hole

2006-07-09 Thread Anthony DeRobertis
Andi Kleen wrote: > Is that a board with VIA chipset? Yep. > > VIA doesn't seem to support PCI accesses with addresses >4GB and they also > don't have a working GART IOMMU. > > It will likely work with iommu=force I'll give this a try I do get a line in dmesg which reads: PCI-DMA: Disabl

Re: [RFC 1/4] kevent: core files.

2006-07-09 Thread Evgeniy Polyakov
On Sun, Jul 09, 2006 at 05:59:42PM +0300, Pekka Enberg ([EMAIL PROTECTED]) wrote: > On 7/9/06, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > >+struct kevent *kevent_alloc(gfp_t mask) > >+{ > >+ struct kevent *k; > >+ > >+ if (kevent_cache) > >+ k = kmem_cache_alloc(kevent

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-09 Thread Jamal Hadi Salim
On Sun, 2006-09-07 at 16:19 +0200, Thomas Graf wrote: > * Jamal Hadi Salim <[EMAIL PROTECTED]> 2006-07-09 10:03 > > On Sun, 2006-09-07 at 15:33 +0200, Thomas Graf wrote: > > > That's not gonna work, dev->queue_lock may be held legimitately > > > by someone else than an underlying dev_queue_xmit() c

Re: [RFC 1/4] kevent: core files.

2006-07-09 Thread Pekka Enberg
On 7/9/06, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: +struct kevent *kevent_alloc(gfp_t mask) +{ + struct kevent *k; + + if (kevent_cache) + k = kmem_cache_alloc(kevent_cache, mask); + else + k = kzalloc(sizeof(struct kevent), mask); + + retur

Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-09 Thread Dan Williams
On Sat, 2006-07-08 at 17:59 +0200, Robert Schulze wrote: > I don't think that messages like > > airo(eth1): cmd= 111 > > airo(eth1): status= 7f11 > > airo(eth1): Rsp0= 2 > > airo(eth1): Rsp1= 0 > > airo(eth1): Rsp2= 0 > > are interesting to normal users, so switch them from airo_print_err() t

[PKT_SCHED]: act_api: Fix module leak while flushing actions

2006-07-09 Thread Thomas Graf
Module reference needs to be given back if message header construction fails. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.git/net/sched/act_api.c === --- net-2.6.git.orig/net/sched/act_api.c +++ net-2.6.git/net/sche

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-09 Thread Thomas Graf
* Jamal Hadi Salim <[EMAIL PROTECTED]> 2006-07-09 10:03 > On Sun, 2006-09-07 at 15:33 +0200, Thomas Graf wrote: > > That's not gonna work, dev->queue_lock may be held legimitately > > by someone else than an underlying dev_queue_xmit() call. > > > > If there is a legitimate reason then it wont wo

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-09 Thread Jamal Hadi Salim
On Sun, 2006-09-07 at 15:33 +0200, Thomas Graf wrote: > * Jamal Hadi Salim <[EMAIL PROTECTED]> 2006-07-09 08:52 [..] > > Another simpler approach is to check for recursion right in > > It's very interesting that you change from "there is no easy way" > to "another simpler approach..." in just one

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-09 Thread Thomas Graf
* Jamal Hadi Salim <[EMAIL PROTECTED]> 2006-07-09 08:52 > On Sun, 2006-09-07 at 01:46 +0200, Thomas Graf wrote: > > * Jamal Hadi Salim <[EMAIL PROTECTED]> 2006-07-08 10:14 > [..] > > > There is no easy way to detect such a deadlock. I think it reduces to > > > the same case as eth0->eth0, i.e: > >

[RFC 4/4] kevent: generic poll and timer notifications.

2006-07-09 Thread Evgeniy Polyakov
This patch includes generic poll/select and timer notifications. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/kernel/kevent/kevent_poll.c b/kernel/kevent/kevent_poll.c new file mode 100644 index 000..4950e7c --- /dev/null +++ b/kernel/kevent/kevent_poll.c @@ -0,0 +1,223 @@

[RFC 2/4] kevent: network notifications.

2006-07-09 Thread Evgeniy Polyakov
This patchset includes socket notifications and network asynchronous IO. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/include/asm-i386/socket.h b/include/asm-i386/socket.h index 802ae76..3473f5c 100644 --- a/include/asm-i386/socket.h +++ b/include/asm-i386/socket.h @@ -49,4 +4

[RFC 3/4] kevent: fs/aio notifications.

2006-07-09 Thread Evgeniy Polyakov
This patch includes asynchronous propagation of file's data into VFS cache and aio_sendfile() implementation. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/fs/bio.c b/fs/bio.c index 6a0b9ad..a3ee530 100644 --- a/fs/bio.c +++ b/fs/bio.c @@ -119,7 +119,7 @@ void bio_free(struct b

[RFC 1/4] kevent: core files.

2006-07-09 Thread Evgeniy Polyakov
This patch includes core kevent files: - userspace controlling - kernelspace interfaces - initialisation - notification state machines It might also inlclude parts from other subsystem (like network related syscalls so it is possible that it will not compile without other patches applied). Si

[RFC 0/4] kevent: generic kernel event processing subsystem.

2006-07-09 Thread Evgeniy Polyakov
Hello developers. I'm pleased to announce in linux-kernel@ mail list kevent subsystem which incorporates several AIO/kqueue design notes and ideas. Kevent can be used both for edge and level notifications. It supports socket notifications, network AIO (aio_send(), aio_recv() and aio_sendfile()),

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-09 Thread Jamal Hadi Salim
On Sun, 2006-09-07 at 08:52 -0400, Jamal Hadi Salim wrote: Ok, didnt complete my thought there .. > I dont like it, like i said, because it adds one more check > in the first path. I was contemplating at some point even not doing the ".. not doing the " check for device up and just shove the p

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-09 Thread Jamal Hadi Salim
On Sun, 2006-09-07 at 01:46 +0200, Thomas Graf wrote: > * Jamal Hadi Salim <[EMAIL PROTECTED]> 2006-07-08 10:14 [..] > > There is no easy way to detect such a deadlock. I think it reduces to > > the same case as eth0->eth0, i.e: > > It's very simple. Just use the same method and add a flag if a mi

[AX.25] Use kzalloc

2006-07-09 Thread Ralf Baechle
Replace kzalloc instead of kmalloc + memset. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/ax25/af_ax25.c |3 +-- net/ax25/ax25_dev.c|4 +--- net/netrom/af_netrom.c |4 +--- net/rose/af_rose.c |3 +-- 4 files changed, 4 insertions(+), 10 deletions(-) Index: lin

Re: 2.6.17-mm3

2006-07-09 Thread Herbert Xu
Michal Piotrowski <[EMAIL PROTECTED]> wrote: > > It was moved, sorry. I fail to spot any relevant backtraces for skge or indeed any part of the networking stack. Ingo/Arjan, perhaps you guys can figure out what's wrong here. In future perhaps you should consider posting the dmesg to the list di

Re: [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on()

2006-07-09 Thread Stefan Rompf
Am Freitag, 7. Juli 2006 23:33 schrieb Stephen Hemminger: > Not really. The flag code last major change was to do the dormant > stuff that HDLC wanted. ... and where the maintainer doesn't seem to care to use it now that the infrastructure is there. Sigh. > IMHO VLAN device's should mirror the

Re: rtl8139: NETDEV WATCHDOG: eth0: transmit timed out

2006-07-09 Thread Thomas Hellström
Marcus Better wrote: It appears to be on a different IRQ: ~$ cat /proc/interrupts CPU0 0: 202574 XT-PIC timer 1: 2649 XT-PIC i8042 2: 0 XT-PIC cascade 8: 0 XT-PIC rtc 9: 0 XT-PIC acpi 10:

Re: rtl8139: NETDEV WATCHDOG: eth0: transmit timed out

2006-07-09 Thread Marcus Better
Thomas Hellström wrote: > I guess you got the wrong commit, and the correct one should be the one > where Dave adds vblank interrupts. It should be close to the one you > listed. I thought I double-checked that it was the right commit, but will check again. > If the network sits on the same IRQ l