Re: (usagi-core 30280) Re: [PATCH 10/23] [PATCH] [XFRM]: Trace which secpath state is reject factor.

2006-08-02 Thread Masahide NAKAMURA
David Miller wrote: From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Sat, 29 Jul 2006 18:30:29 +0900 @@ -272,6 +272,9 @@ #define XFRM_TYPE_NON_FRAGMENT 1 void(*destructor)(struct xfrm_state *); int (*input)(struct xfrm_state *, struct

Re: [RFC] gre: transparent ethernet bridging

2006-08-02 Thread Philip Craig
Stephen Hemminger wrote: I am not against making the bridge code smarter to handle other encapsulation. Here's an updated patch that fixes all issues I am aware of. It generates a random mac address for gre ports, and also stores a copy of the mac address for ethernet ports, rather than

[Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread Catherine Zhang
Hi, all, Enclosed please find the updated patch incorporating comments from Stephen and Dave. Again thanks for your help! Catherine -- From: [EMAIL PROTECTED] This patch implements a cleaner fix for the memory leak problem of the original unix datagram getpeersec patch. Instead of creating

Re: [take2 1/4] kevent: core files.

2006-08-02 Thread Evgeniy Polyakov
On Tue, Aug 01, 2006 at 04:56:59PM -0700, Zach Brown ([EMAIL PROTECTED]) wrote: OK, here's some of my reactions to the core part. Thanks. +#define KEVENT_SOCKET 0 +#define KEVENT_INODE 1 +#define KEVENT_TIMER 2 +#define KEVENT_POLL

Re: [take2 1/4] kevent: core files.

2006-08-02 Thread Evgeniy Polyakov
On Tue, Aug 01, 2006 at 05:01:38PM -0700, David Miller ([EMAIL PROTECTED]) wrote: From: Zach Brown [EMAIL PROTECTED] Date: Tue, 01 Aug 2006 16:56:59 -0700 Even if we only have one syscall with a cmd multiplexer (which I'm not thrilled with), we should at least make these arguments

Re: [patch] RFC: matching interface groups

2006-08-02 Thread Balazs Scheidler
On Tue, 2006-08-01 at 21:18 +0200, Sven Schuster wrote: Hi Phil, On Tue, Aug 01, 2006 at 11:46:55AM -0700, Phil Oester told us: Since in this scenario userspace is able to determine ppp vs pptp, could you not also do something like have an inbound_ppp and inbound_pptp chain, then jump

Re: [patch] RFC: matching interface groups

2006-08-02 Thread Balazs Scheidler
On Tue, 2006-08-01 at 11:29 -0700, Stephen Hemminger wrote: On Tue, 01 Aug 2006 19:10:09 +0200 Balazs Scheidler [EMAIL PROTECTED] wrote: Hi, I would like to easily match a set of dynamically created interfaces from my packet filter rules. The attached patch forms the basis of my

Re: e1000 speed/duplex error

2006-08-02 Thread a1
Hi, Auke. Auke Kok wrote: AK Here's that part of the driver documentation: AK $ modprobe e1000 AutoNeg=0x08 AK e1000: :00:00.0: e1000_validate_option: AutoNeg advertising 100/FD AK 99 /* Auto-negotiation Advertisement Override AK 100 * AK 101 * Valid Range: 0x01-0x0F, 0x20-0x2F

Re: [RFC] gre: transparent ethernet bridging

2006-08-02 Thread Lennert Buytenhek
On Mon, Jul 31, 2006 at 10:08:22PM -0700, Stephen Hemminger wrote: Why not use existing bridge code? It does use the existing bridge code. Perhaps the name is misleading. All it does is encapsulate the full ethernet header in a gre packet, rather than only layer 3. That is,

Re: e1000 speed/duplex error

2006-08-02 Thread Jeff Kirsher
On 8/2/06, a1 [EMAIL PROTECTED] wrote: Hi, Auke. Auke Kok wrote: AK Here's that part of the driver documentation: AK $ modprobe e1000 AutoNeg=0x08 AK e1000: :00:00.0: e1000_validate_option: AutoNeg advertising 100/FD AK 99 /* Auto-negotiation Advertisement Override AK 100 * AK 101 *

Re: [take2 1/4] kevent: core files.

2006-08-02 Thread David Miller
From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Wed, 2 Aug 2006 10:39:18 +0400 u64 is not aligned, so I prefer to use u32 as much as possible. We have aligned_u64 exactly for this purpose, netfilter makes use of it to avoid the x86_64 vs. x86 u64 alignment discrepency. - To unsubscribe from this

Re: [take2 1/4] kevent: core files.

2006-08-02 Thread Evgeniy Polyakov
On Wed, Aug 02, 2006 at 12:25:05AM -0700, David Miller ([EMAIL PROTECTED]) wrote: From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Wed, 2 Aug 2006 10:39:18 +0400 u64 is not aligned, so I prefer to use u32 as much as possible. We have aligned_u64 exactly for this purpose, netfilter makes

Re: [RFC] Mobile IPv6 introduction

2006-08-02 Thread Ville Nuorvala
Hugo Santos wrote: David, On Tue, Aug 01, 2006 at 05:35:35PM -0700, David Miller wrote: This is partly why the multiple routing table code is being added as the initial infrastrucutre, so that source based things are possible. There have been other approaches for partial source-based

Re: [PATCH 1/23] [PATCH] [XFRM]: Add XFRM_MODE_xxx for future use.

2006-08-02 Thread Masahide NAKAMURA
Herbert Xu wrote: Please rebase your tree on something that's more recent. We've had xfrm modes for more than two months now. OK, I use rebase to catch up with the latest tree. (This tree is just for review then it is not against the latest but 2.6.17.) -- Masahide NAKAMURA - To unsubscribe

Re: [PATCH 0/20][IPV6/XFRM] MIPv6 CN (part B)

2006-08-02 Thread Masahide NAKAMURA
David Miller wrote: From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Sat, 29 Jul 2006 18:37:04 +0900 Here is Part B patches, following this mail. Part B is also available as mip6cn-20060716-review branch at: git://git.skbuff.net:9419/gitroot/nakam/linux-2.6-mip6cn This tree includes part

Re: [PATCH 7/23] [PATCH] [XFRM] STATE: Add a hook to find where to be inserted header in outbound.

2006-08-02 Thread Masahide NAKAMURA
David Miller wrote: From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Wed, 02 Aug 2006 11:20:30 +0900 David Miller wrote: I see a dangerous pattern of adding many, many, many methods to the xfrm_type structure which are only used by ipv6. But I cannot suggest another method. Sometimes this

Re: e1000 speed/duplex error

2006-08-02 Thread a1
Hi, Jeff. JK On 8/2/06, a1 [EMAIL PROTECTED] wrote: Hi, Auke. Auke Kok wrote: AK Here's that part of the driver documentation: AK $ modprobe e1000 AutoNeg=0x08 AK e1000: :00:00.0: e1000_validate_option: AutoNeg advertising 100/FD AK 99 /* Auto-negotiation Advertisement Override

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-02 Thread Christophe Devriese
On Tuesday 01 August 2006 19:21, you wrote: John W. Linville wrote: I'm just not sure that cleverness is worth the headache, especially since the most clever things usually only work by accident... Or, work by solid, modular design and small tweaks! Point taken.  But stashing little

Re: [patch] RFC: matching interface groups

2006-08-02 Thread Amin Azez
* Balazs Scheidler wrote, On 02/08/06 08:04: On Tue, 2006-08-01 at 21:18 +0200, Sven Schuster wrote: as this would require the complete chain (say, INPUT or OUTPUT) to be downloaded to userspace, modified and then again uploaded to the kernel. At least until iptables redesign to allow

Re: [RFC] Mobile IPv6 introduction

2006-08-02 Thread Hugo Santos
Hi, Thanks for the reply, however: On Wed, Aug 02, 2006 at 12:24:30PM +0900, Masahide NAKAMURA wrote: Our patch is similar as you said. Our design is that kernel does nothing as possible about validation which can be done by user-space. As you mentioned ICMPv6 error is hard to be sent by

Re: [RFC] Mobile IPv6 introduction

2006-08-02 Thread Hugo Santos
Hi Ville, On Wed, Aug 02, 2006 at 10:58:49AM +0300, Ville Nuorvala wrote: To name just one issue: the chicken and egg problem of source address selection and source address based routing. I solved this problem by letting policy rules (with a source prefix) add additional constraints to the

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread Stephen Smalley
On Wed, 2006-08-02 at 02:47 -0400, Catherine Zhang wrote: Hi, all, Enclosed please find the updated patch incorporating comments from Stephen and Dave. Note that this patch is intended for 2.6.18 as a bug fix for the memory leak introduced by the original dgram peersec patches. Again

RE: [RFC 2/3] secid reconciliation on inbound: add LSM hooks

2006-08-02 Thread Venkat Yekkirala
- if (err) - goto out; + /* if (err) */ + /* goto out; */ - err = selinux_xfrm_sock_rcv_skb(sksec-sid, skb, ad); -out: + /* err = selinux_xfrm_sock_rcv_skb(sksec-sid, skb, ad); */ +out: return err; } Did you mean to leave

RE: [RFC 1/3] secid reconciliation on inbound

2006-08-02 Thread Venkat Yekkirala
On Tue, 1 Aug 2006, James Morris wrote: On Tue, 1 Aug 2006, Venkat Yekkirala wrote: +#define PACKET__COME_THRU 0x0008UL +#define PACKET__GO_THRU 0x0010UL These names seem awkward, and do we really need a separate perm

Re: [RFC] Mobile IPv6 introduction

2006-08-02 Thread Masahide NAKAMURA
Hugo Santos wrote: Although the ICMP-filter approach would be better, it is not flexible enough to handle this situation. We must also send ICMPv6 Parameter Problems when ip6mh_proto isn't IPPROTO_NONE. I don't think it is too I don't think IPPROTO_NONE case is a suitable example here (it

[PATCH] DECnet Fix for DECnet routing bug

2006-08-02 Thread Patrick Caulfield
This patch fixes a bug in the DECnet routing code where we were selecting a loopback device in preference to an outward facing device even when the destination was known non-local. This patch should fix the problem. Signed-off-by: Patrick Caulfield [EMAIL PROTECTED] Signed-off-by: Steven

RE: [NET]: Fix ___pskb_trim when entire frag_list needs dropping

2006-08-02 Thread Marco Berizzi
Herbert Xu wrote: On Thu, Jul 13, 2006 at 07:03:41PM +1000, herbert wrote: This needs to go into stable as well. In fact, there is another unrelated bug with exactly the same symptoms which was inadvertently fixed by the GSO patches. So I'll send a simpler fix for that to stable.

Re: e1000 speed/duplex error

2006-08-02 Thread Auke Kok
a1 wrote: JK I agree. Although ethtool does not have that functionality as of yet. JK Feel free to provide a patch to the ethtool maintainer (Jeff Garzik) JK if you would like. I will put it on my plate of things to do, but I JK will admit that it is near the bottom of the list of items to

Re: [PATCH] Fix more per-cpu typos

2006-08-02 Thread Alexey Dobriyan
On Wed, Aug 02, 2006 at 05:02:11AM +0200, Andi Kleen wrote: --- a/arch/x86_64/kernel/smp.c +++ b/arch/x86_64/kernel/smp.c @@ -203,7 +203,7 @@ int __cpuinit init_smp_flush(void) { int i; for_each_cpu_mask(i, cpu_possible_map) { -

Re: [PATCH 20/23] [PATCH] [XFRM] POLICY: sub policy support.

2006-08-02 Thread James Morris
On Sat, 29 Jul 2006, Masahide NAKAMURA wrote: Sub policy is introduced. Main and sub policy are applied the same flow. (Policy that current kernel uses is named as main.) It is required another transformation policy management to keep IPsec and Mobile IPv6 lives separate. Policy which lives

Re: [PATCH] ipv4: don't call upper-layer disconnect function if not connected

2006-08-02 Thread Brian Haley
The socket could have been bind()'d to, in which case it will not move to connected state and we still need to invoke the disconnect methods such as udp_disconnect() to clear out that binding. Ok. You seem to be groveling in random areas of the ipv4 and ipv6 stack, what are you working on?

Re: [PATCH] IPv6: only set err in rawv6_bind() when necessary

2006-08-02 Thread Brian Haley
Every other path going from this location in rawv6_bind() will clear err to zero, so your patch also doesn't fix any bug. I knew it didn't fix a bug, I just hadn't noticed the C idiom you pointed-out until I knew to look for it. rawv6_bind() even does this, duh. -Brian - To unsubscribe

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread Michal Piotrowski
Hi Catherine, On 02/08/06, Catherine Zhang [EMAIL PROTECTED] wrote: Hi, all, Enclosed please find the updated patch incorporating comments from Stephen and Dave. Thanks! Again thanks for your help! Catherine -- Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group

Re: [2.6.18-rc2][e1000][swsusp] - Regression - Suspend to disk and resume breaks e1000 - RESOLVED Bug #6867

2006-08-02 Thread Auke Kok
Shawn Starr wrote: On Sunday 16 July 2006 12:33 pm, Auke Kok wrote: [adding netdev to the cc] unfortunately I didn't. e1000 has a special e1000_pci_save_state/e1000_pci_restore_state set of routines that save and restore the configuration space. the fact that it works for suspend to memory to

Re: e1000 speed/duplex error

2006-08-02 Thread Auke Kok
a1 wrote: Hi, Auke. Auke Kok wrote: AK Here's that part of the driver documentation: AK $ modprobe e1000 AutoNeg=0x08 AK e1000: :00:00.0: e1000_validate_option: AutoNeg advertising 100/FD AK 99 /* Auto-negotiation Advertisement Override AK 100 * AK 101 * Valid Range: 0x01-0x0F,

[PATCH 2.6.16.19 2/2] LARTC: trace control for netem: kernelspace

2006-08-02 Thread Rainer Baumann
Trace Control for Netem: Emulate network properties such as long-dependency and self-similarity of cross-traffic. The delay, drop, duplication and corruption values are readout in user space and sent to kernel space via procfs. The kernel determines the time when new values should be sent by the

[PATCH 2.6.16.19 1/2] LARTC: trace control for netem: userspace

2006-08-02 Thread Rainer Baumann
Trace Control for Netem: Emulate network properties such as long-dependency and self-similarity of cross-traffic. The directory tc/netem was split in two parts, one containing the original distributions and the other the tools to generate trace files as well as the program responsible for reading

[PATCH 2.6.16.19 0/2] LARTC: trace control for netem

2006-08-02 Thread Rainer Baumann
Hi, We developed an extension to the network emulator netem, that provides emulation of long term network properties such as long-range dependence and self-similarity of cross-traffic. It is not possible to emulate these properties with the statistical tables for the packet delay values used by

Re: [RFC] gre: transparent ethernet bridging

2006-08-02 Thread Stephen Hemminger
On Wed, 02 Aug 2006 16:17:42 +1000 Philip Craig [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: I am not against making the bridge code smarter to handle other encapsulation. Here's an updated patch that fixes all issues I am aware of. It generates a random mac address for gre

means to artificially alter the bandwidth of a system

2006-08-02 Thread Irfan Habib
Hi, For research purposes we are considering to develop a program to alter the bandwidth of a system via the software, so instance: a machine has 100 MB/s and we change it to 1MB/s. Does something like this already exist? Or is there a way to do this without creating a program/kernel module

Re: Stackable devices.

2006-08-02 Thread Ben Greear
Stephen Hemminger wrote: On Wed, 2 Aug 2006 11:02:20 +0200 Christophe Devriese [EMAIL PROTECTED] wrote: On Tuesday 01 August 2006 19:21, you wrote: John W. Linville wrote: I'm just not sure that cleverness is worth the headache, especially since the most clever things usually only work by

Stackable devices.

2006-08-02 Thread Stephen Hemminger
On Wed, 2 Aug 2006 11:02:20 +0200 Christophe Devriese [EMAIL PROTECTED] wrote: On Tuesday 01 August 2006 19:21, you wrote: John W. Linville wrote: I'm just not sure that cleverness is worth the headache, especially since the most clever things usually only work by accident... Or, work

Re: [PATCH 2.6.16.19 0/2] LARTC: trace control for netem

2006-08-02 Thread Stephen Hemminger
On Wed, 02 Aug 2006 19:21:27 +0200 Rainer Baumann [EMAIL PROTECTED] wrote: Hi, We developed an extension to the network emulator netem, that provides emulation of long term network properties such as long-range dependence and self-similarity of cross-traffic. It is not possible to emulate

Re: [PATCH][SECURITY] secmark: nul-terminate secdata

2006-08-02 Thread Chris Wright
* James Morris ([EMAIL PROTECTED]) wrote: cc'd Chris Wright, as this patch seems like a candidate for the stable tree. Would be, but I thought secmark went in post 2.6.17. And I expect Dave will push this well before 2.6.18. thanks, -chris - To unsubscribe from this list: send the line

Re: [bug] e100: checksum mismatch on 82551ER rev10

2006-08-02 Thread Auke Kok
[cc-ing netdev] [adding original thread authors back, please do not strip CC] Charlie Brady wrote: Molle Bestefich wrote: The NICs are working perfectly. How can you tell? Do you know if jumbo frames work correctly? Is the device properly checksumming? is flow control working properly? These

Re: [bug] e100: checksum mismatch on 82551ER rev10

2006-08-02 Thread Charlie Brady
On Wed, 2 Aug 2006, Auke Kok wrote: [cc-ing netdev] [adding original thread authors back, please do not strip CC] [There were no Cc's visible in the lkml archive I used as source of my quotes.] Charlie Brady wrote: Let's assume that these things are all true, and the NIC currently does

Re: [bug] e100: checksum mismatch on 82551ER rev10

2006-08-02 Thread Auke Kok
Charlie Brady wrote: Let's assume that these things are all true, and the NIC currently does not work perfectly, just imperfectly, but acceptably. With the recent driver change, it now does not work at all. That's surely a bug in the driver. There is no logic in that sentence at all. You're

Re: [PATCH 2.6.16.19 0/2] LARTC: trace control for netem

2006-08-02 Thread Rainer Baumann
Thanx for your feedback! We will try to fix this. Rainer Stephen Hemminger wrote: On Wed, 02 Aug 2006 19:21:27 +0200 Rainer Baumann [EMAIL PROTECTED] wrote: Hi, We developed an extension to the network emulator netem, that provides emulation of long term network properties such as

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2006-08-02 Thread Steve . Glendinning
Hi John, Thanks for all your feedback. +/* waits for MAC not busy, with timeout. Assumes MacPhyAccessLock has + * already been acquired */ +static int smsc911x_mac_notbusy(struct smsc911x_data *pdata) +{ +int i; + +for (i = 0; i 40; i++) { +

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2006-08-02 Thread Steve . Glendinning
Hi Francois, Thanks again for all your feedback. I have implemented most of your suggestions, /* Enable phy clocks to the MAC */ hwcfg = (~HW_CFG_PHY_CLK_SEL_); hwcfg |= HW_CFG_PHY_CLK_SEL_EXT_PHY_;

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2006-08-02 Thread John W. Linville
On Wed, Aug 02, 2006 at 08:23:40PM +0100, [EMAIL PROTECTED] wrote: Does this need the magic for (addr=1; addr =32; addr++) trick that has become idiomatic for PHY discovery in our drivers? I don't understand the question - surely 32 is not a valid PHY address? That's why it is magic! :-)

Re: [patch 0/1]SNMPv2 ipv6IfStatsInHdrErrors counter error

2006-08-02 Thread David Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Mon, 31 Jul 2006 18:36:25 +0900 (JST) Hello. Next time, please put your Signed-off-by line before the patch. Thank you. In article [EMAIL PROTECTED] (at Tue, 01 Aug 2006 05:45:33 -0400), weidong [EMAIL PROTECTED] says:

Re: means to artificially alter the bandwidth of a system

2006-08-02 Thread Ian McDonald
Hi, For research purposes we are considering to develop a program to alter the bandwidth of a system via the software, so instance: a machine has 100 MB/s and we change it to 1MB/s. Does something like this already exist? Or is there a way to do this without creating a program/kernel module Of

Re: means to artificially alter the bandwidth of a system

2006-08-02 Thread Hagen Paul Pfeifer
* Irfan Habib | 2006-08-02 23:04:41 [+0500]: Hi, For research purposes we are considering to develop a program to alter the bandwidth of a system via the software, so instance: a machine has 100 MB/s and we change it to 1MB/s. Does something like this already exist? Or is there a way to do this

Re: [patch 1/1]SNMPv2 ipv6IfStatsOutFragCreates counter error

2006-08-02 Thread David Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Mon, 31 Jul 2006 18:43:14 +0900 (JST) The patch seems sane to me. In article [EMAIL PROTECTED] (at Tue, 01 Aug 2006 05:45:39 -0400), weidong [EMAIL PROTECTED] says: signed-off-by: Wei Dong [EMAIL PROTECTED] Acked-by: YOSHIFUJI Hideaki

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-02 Thread David Miller
From: Christophe Devriese [EMAIL PROTECTED] Date: Mon, 31 Jul 2006 10:15:40 +0200 Thanks for the detailed explanation. If you bond 2 vlan subinterfaces, the patch is not necessary at all. In that case also the source device will be changed from eth0.vlan to bondx. So that's correct behavior

Re: neigh_lookup lockdep bug.

2006-08-02 Thread David Miller
From: Arjan van de Ven [EMAIL PROTECTED] Date: Wed, 02 Aug 2006 04:26:49 +0200 fwiw the patch is at http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/lockdep-split-the-skb_queue_head_init-lock-class.patch and a followup cleanup at

Re: [PATCH] NET: fix kernel panic from no dev-hard_header_len space

2006-08-02 Thread Krzysztof Halasa
David Miller [EMAIL PROTECTED] writes: I think Alexey is saying that setting -hard_header() creates an agreement between the device and IP that IP will make sure that dev-hard_header_len bytes are available in the header area. I think I now understand it: hard_header_len is guaranteed while

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2006-08-02 Thread Francois Romieu
[EMAIL PROTECTED] [EMAIL PROTECTED] : Mezigues : [...] Does the platform guarantees that the register write has actually reached the real register when the udelay is issued ? I think so, but maybe you can help me check. The LAN911x device is always directly connected to a simple

Re: [RFC] Mobile IPv6 introduction

2006-08-02 Thread David Miller
From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Wed, 02 Aug 2006 22:03:16 +0900 If there is much requirement to add new type number without any modification of kernel code at all I would support ICMPv6 filter approach, too. There is no such requirement, please just continue to prepare your

Re: [NET]: Fix ___pskb_trim when entire frag_list needs dropping

2006-08-02 Thread David Miller
From: Marco Berizzi [EMAIL PROTECTED] Date: Wed, 02 Aug 2006 17:01:17 +0200 The problem is fixed now. I have applied this patch to 2.6.18-rc2 Many thanks Herbert for all the time spent to debug this problem. Thank you for testing. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] DECnet Fix for DECnet routing bug

2006-08-02 Thread David Miller
From: Patrick Caulfield [EMAIL PROTECTED] Date: Wed, 02 Aug 2006 15:19:24 +0100 This patch fixes a bug in the DECnet routing code where we were selecting a loopback device in preference to an outward facing device even when the destination was known non-local. This patch should fix the

Please pull 'upstream-fixes' branch of wireless-2.6

2006-08-02 Thread John W. Linville
The following changes since commit 49b1e3ea19b1c95c2f012b8331ffb3b169e4c042: Linus Torvalds: Merge branch 'merge' of git://git.kernel.org/.../paulus/powerpc are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fixes

Re: [PATCH 2/6] zd1211rw: Pass more management frame types up to host

2006-08-02 Thread John W. Linville
On Tue, Aug 01, 2006 at 11:43:31PM +0200, Ulrich Kunitz wrote: From: Daniel Drake [EMAIL PROTECTED] We'll be needing these at some point... This one doesn't really seem like a fix. But since the later fixes seem to depend on it, I guess it makes sense to take it. I just didn't want you to

Re: [PATCH 20/23] [PATCH] [XFRM] POLICY: sub policy support.

2006-08-02 Thread David Miller
From: James Morris [EMAIL PROTECTED] Date: Wed, 2 Aug 2006 12:04:31 -0400 (EDT) Why can't IPSec MIP transforms be bundled on the same policy? At the first year of netconf, Yoshifuji went into detail as to why the IPSEC and MIP transformations had to live seperately. It's partly a side effect

Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-08-02 Thread Francois Romieu
Martin Michlmayr [EMAIL PROTECTED] : [...] Sorry, to pester you, but I was wondering if you had a chance to look at the register dump. No problem. It would have been easier with a decoded output of the register dump though (see Lennert dump below). Lines prefixed by '' come from Realtek's

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread David Miller
Catherine you really must begin to remember to add proper Signed-off-by: lines to your patch submissions. I'll sign off on this bug fix, but in the future I will not do so for you any more as you've been told at least 3 or 4 times about this. Thank you. - To unsubscribe from this list: send

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread Xiaolan Zhang
David, I will remember this in the future, I promise. thank you, Catherine David Miller [EMAIL PROTECTED] wrote on 08/02/2006 05:11:03 PM: Catherine you really must begin to remember to add proper Signed-off-by: lines to your patch submissions. I'll sign off on this bug fix, but in the

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread David Miller
From: Xiaolan Zhang [EMAIL PROTECTED] Date: Wed, 2 Aug 2006 17:14:31 -0400 I will remember this in the future, I promise. Can you also remember to test your patches with CONFIG_SECURITY disabled, as you also promised in the past several times?!??!?! In file included from init/main.c:34:

orinoco driver causes *lots* of lockdep spew

2006-08-02 Thread Dave Jones
Wow. Nearly 400 lines of debug spew, from a simple 'ifup eth1'. Dave ADDRCONF(NETDEV_UP): eth1: link is not ready eth1: New link status: Disconnected (0002) == [ INFO: hard-safe - hard-unsafe lock order detected ]

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread Xiaolan Zhang
David, I did test it with CONFIG_SECURITY disabled, but did not catch the warning -- I verified that the build completes with a valid vmlinux image. There are many warnings (device drivers, and others) during the build and I didn't do a grep to find which one is specific to my patch. Next

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread David Miller
From: Xiaolan Zhang [EMAIL PROTECTED] Date: Wed, 2 Aug 2006 18:18:07 -0400 I did test it with CONFIG_SECURITY disabled, but did not catch the warning -- I verified that the build completes with a valid vmlinux image. There are many warnings (device drivers, and others) during the build and

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread Xiaolan Zhang
I see. The build was fine under x86 and there are so many warnings that a -Werror probably won't work for me. thanks, Catherine David Miller [EMAIL PROTECTED] wrote on 08/02/2006 06:19:06 PM: From: Xiaolan Zhang [EMAIL PROTECTED] Date: Wed, 2 Aug 2006 18:18:07 -0400 I did test it with

[PATCH v4 0/2][RFC] iWARP Core Support

2006-08-02 Thread Steve Wise
Roland, Here is the iWARP Core Support patchset merged to your latest for-2.6.19 branch. It has gone through 3 reviews on lklm and netdev a while ago, and I think its ready to be pulled in. Steve. This patchset defines the modifications to the Linux infiniband subsystem to support

[PATCH v4 2/2] iWARP Core Changes.

2006-08-02 Thread Steve Wise
This patch contains modifications to the existing rdma header files, core files, drivers, and ulp files to support iWARP. V2 Review updates: V1 Review updates: - copy_addr() - rdma_copy_addr() - dst_dev_addr param in rdma_copy_addr to const. - various spacing nits with recasting - include

[PATCH v4 1/2] iWARP Connection Manager.

2006-08-02 Thread Steve Wise
This patch provides the new files implementing the iWARP Connection Manager. This module is a logical instance of the xx_cm where xx is the transport type (ib or iw). The symbols exported are used by the transport independent rdma_cm module, and are available also for transport dependent ULPs.

[PATCH 3/6] htb: if HTB_HYSTERIS cleanup

2006-08-02 Thread Stephen Hemminger
Change the conditional compilation around HTB_HYSTERSIS since code was splitting mid expression. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/sched/sch_htb.c | 27 +-- 1 files changed, 17 insertions(+), 10 deletions(-) diff --git a/net/sched/sch_htb.c

[PATCH 1/6] htb: remove broken debug code

2006-08-02 Thread Stephen Hemminger
The HTB network scheduler had debug code that wouldn't compile and confused and obfuscated the code, remove it. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/sched/sch_htb.c | 302 ++- 1 files changed, 34 insertions(+), 268

[PATCH 6/6] htb: rbtree cleanup

2006-08-02 Thread Stephen Hemminger
Add code to initialize rb tree nodes, and check for double deletion. This is not a real fix, but I can make it trap sometimes and may be a bandaid for: http://bugzilla.kernel.org/show_bug.cgi?id=6681 Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/sched/sch_htb.c | 34

[PATCH 5/6] htb: use hlist for hash lists.

2006-08-02 Thread Stephen Hemminger
Use hlist instead of list for the hash list. This saves space, and we can check for double delete better. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/sched/sch_htb.c | 49 +++-- 1 files changed, 27 insertions(+), 22 deletions(-) diff

[PATCH 0/6] htb: cleanup

2006-08-02 Thread Stephen Hemminger
The HTB scheduler code is a mess, this patch set does some basic house cleaning. The first four should cause no code change, but the last two need more testing. -- Stephen Hemminger [EMAIL PROTECTED] And in the Packet there writ down that doome - To unsubscribe from this list: send the line

[PATCH 2/6] htb: remove lock macro

2006-08-02 Thread Stephen Hemminger
Get rid of the macro's being used to obscure the locking. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/sched/sch_htb.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index 73094e7..c0b80b7 100644

[PATCH 6/6] htb: rbtree cleanup

2006-08-02 Thread Stephen Hemminger
Add code to initialize rb tree nodes, and check for double deletion. This is not a real fix, but I can make it trap sometimes and may be a bandaid for: http://bugzilla.kernel.org/show_bug.cgi?id=6681 Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/sched/sch_htb.c | 34

Re: [PATCH 0/6] htb: cleanup

2006-08-02 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 2 Aug 2006 12:56:36 -0700 The HTB scheduler code is a mess, this patch set does some basic house cleaning. The first four should cause no code change, but the last two need more testing. These patches look fine to me. Once everyone

[PATCH] bridge: netlink status fix

2006-08-02 Thread Stephen Hemminger
Fix code that passes back netlink status messages about bridge changes. Submitted by [EMAIL PROTECTED] Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/bridge/br_netlink.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/bridge/br_netlink.c

Re: [RFC] gre: transparent ethernet bridging

2006-08-02 Thread Philip Craig
Stephen Hemminger wrote: On Wed, 02 Aug 2006 16:17:42 +1000 Philip Craig [EMAIL PROTECTED] wrote: It generates a random mac address for gre ports, and also stores a copy of the mac address for ethernet ports, rather than checking dev-type everywhere. That looks cleaner. I wonder if using a

Re: Bug in IPSEC?

2006-08-02 Thread Herbert Xu
On Wed, Aug 02, 2006 at 05:08:39PM +0200, Louis Croisez wrote: I think that 96 bits for the truncated version of the hmac is not enough with respect to RFC 2104, p5 ?1 : ... We recommend that the output length to be not less than half the length of the hash output ... and not less than 80

Re: [PATCH] Create IP100A Driver

2006-08-02 Thread Jesse Huang
Dear Jeff: I had discuss with our peoples. We decided to use sundance.c to support IP100A. We will also update some bug fix to this driver. Thanks for your suggestion. Best Regards, Jesse Huang - Original Message - From: Jeff Garzik [EMAIL PROTECTED] To: Jesse Huang [EMAIL

[patch] RFC: matching interface groups

2006-08-02 Thread Stephen J. Bevan
Balazs Scheidler writes: I would like to easily match a set of dynamically created interfaces from my packet filter rules. The attached patch forms the basis of my implementation and I would like to know whether something like this is mergeable to mainline. [snip] The implementation:

bonding questions: carrier based link monitoring / slave device state flags

2006-08-02 Thread Or Gerlitz
First, i'd like to verify what is the parameter setting to have the bonding driver use netif_carrier_ok(slave_device) as the means for link detection. Is setting use_carrier = 1 enough or one needs to set miimon to non-zero as well??? (where the value of miimon translates to the link monitoring