Re: [PATCH] [NET] Size listen hash tables using backlog hint

2006-10-18 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 19 Oct 2006 08:34:53 +0200 > My main problem is being able to use a large hash table on big servers. > > With power-of two constraint, plus kmalloc max size constraint, we can use > half the size we could. Switch to vmalloc() at the kmalloc() cu

Re: [PATCH] [NET] Size listen hash tables using backlog hint

2006-10-18 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 19 Oct 2006 07:12:58 +0200 A 66 MHz 486 can perform 1.000.000 divisions per second. Is it a 'slow' cpu ? Sparc and some other embedded chips have no division/modulus integer instruction and do it in software. How many

Re: (usagi-core 31424) Re: [PATCH 7/13] [RFC] [IPV6] Move source address selection into route lookup.

2006-10-18 Thread Ville Nuorvala
On 10/19/06 05:27, Mitsuru Chinen wrote: Hello Mitsuru-san, > At the first Echo Request, its source address is a global address. > > | # ping6 -n -c 1 -i 1 -s 1452 -p 00 -w 2 -I eth1 FF1E: :1:2 > | PATTERN: 0x00 > | PING FF1E::1:2(ff1e::1:2) from 3ffe:501::100:2d0:b7ff:fe9a:455b eth1: > 145

[PATCH wireless-dev] p54: fix stalling in TX queue

2006-10-18 Thread Michael Wu
p54: fix stalling in TX queue This patch makes the p54 TX queue not stall anymore. Probably not the most efficient thing to do, but it's better than stalling. It also adds a small comment to prism54common.h about the origin of the pda definitions and inserts a missing verb in the comment for p5

Re: [IPROUTE] 2nd try

2006-10-18 Thread David Miller
From: Michael Prokop <[EMAIL PROTECTED]> Date: Thu, 19 Oct 2006 08:00:57 +0200 > The lines above are a 1:1 copy of the text by Alexey Kuznetosv I found in > the iproute-doc package at /usr/share/doc/iproute-doc/ss.html > [see http://www.math.ias.edu/doc/iproute-2.6.9/ss.ps]. > Of course feel free

[PATCH wireless-dev] set freq in ieee80211_rx_status

2006-10-18 Thread Michael Wu
set freq in ieee80211_rx_status This patch fixes the RX handler in adm8211 and p54 to report the current frequency and channel. Should probably be handled in d80211 instead, but this will fix things for now. It also eliminates some definitions in adm8211.h that are no longer necessary. Signed-

Re: [PATCH] [NET] Size listen hash tables using backlog hint

2006-10-18 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 19 Oct 2006 07:12:58 +0200 > A 66 MHz 486 can perform 1.000.000 divisions per second. Is it a 'slow' cpu ? Sparc and some other embedded chips have no division/modulus integer instruction and do it in software. > So... what do you prefer : > > 1

Re: [IPROUTE] 2nd try

2006-10-18 Thread Michael Prokop
[Note: I'm the contributor of the manpage] * Stephen Hemminger <[EMAIL PROTECTED]> wrote: > Alexander Wirt wrote: [manpage for ss] >> \fBss\fP is another utility to investigate sockets. Functionally it is >> NOT better than netstat combined with some perl/awk scripts and though it is >> surely f

Re: [IPROUTE] 2nd try

2006-10-18 Thread Stephen Hemminger
On Thu, 19 Oct 2006 07:14:58 +0200 Alexander Wirt <[EMAIL PROTECTED]> wrote: > David Miller schrieb am Mittwoch, den 18. Oktober 2006: > > > From: Alexander Wirt <[EMAIL PROTECTED]> > > Date: Thu, 19 Oct 2006 07:03:07 +0200 > > > > > Stephen Hemminger schrieb am Mittwoch, den 18. Oktober 2006: >

Re: [PATCH] [NET] reduce sizeof(struct flow)

2006-10-18 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 18 Oct 2006 15:32:22 +0200 OK then. Even on a distro kernel (allyesconfig), size(flow) would shrink by 20 bytes. For the time being, why don't we just kill off the unused dnports bits entirely. Once the support code to

Re: [IPROUTE] 2nd try

2006-10-18 Thread Alexander Wirt
David Miller schrieb am Mittwoch, den 18. Oktober 2006: > From: Alexander Wirt <[EMAIL PROTECTED]> > Date: Thu, 19 Oct 2006 07:03:07 +0200 > > > Stephen Hemminger schrieb am Mittwoch, den 18. Oktober 2006: > > > > > Alexander Wirt wrote: > > > >I need more sleep this time hopefully with the manp

Re: [PATCH] [NET] Size listen hash tables using backlog hint

2006-10-18 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet Hi <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 14:58:37 +0200 reqsk_queue_alloc() goal is to use a power of two size for the whole listen_sock structure, to avoid wasting memory for large backlogs, meaning the hash table nr_table_entries is not anymore a

Re: [IPROUTE] 2nd try

2006-10-18 Thread David Miller
From: Alexander Wirt <[EMAIL PROTECTED]> Date: Thu, 19 Oct 2006 07:03:07 +0200 > Stephen Hemminger schrieb am Mittwoch, den 18. Oktober 2006: > > > Alexander Wirt wrote: > > >I need more sleep this time hopefully with the manpage attached. > > > Amusing but hardly in keeping with the style and

Re: [IPROUTE] 2nd try

2006-10-18 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 18 Oct 2006 21:55:41 -0700 > Alexander Wirt wrote: > > \fBss\fP is another utility to investigate sockets. Functionally it is > > NOT better than netstat combined with some perl/awk scripts and though it is > > surely faster it is not enough t

Re: [PATCH] [NET] Size listen hash tables using backlog hint

2006-10-18 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 18 Oct 2006 21:54:08 -0700 > Reminds me, anyone know why GCC is too stupid to convert modulus of a > constant power of 2 into a mask operation? If the computation ends up being signed it can't perform this optimization. - To unsubscribe from

Re: [IPROUTE] 2nd try

2006-10-18 Thread Alexander Wirt
Stephen Hemminger schrieb am Mittwoch, den 18. Oktober 2006: > Alexander Wirt wrote: > >I need more sleep this time hopefully with the manpage attached. > Amusing but hardly in keeping with the style and tone of other man pages. Much better than nothing - just my 2 cent. Alex - To unsubscrib

Re: [IPROUTE] 2nd try

2006-10-18 Thread Stephen Hemminger
Alexander Wirt wrote: I need more sleep this time hopefully with the manpage attached. Alex .TH SS 8 .SH NAME ss \- another utility to investigate sockets .SH SYNOPSIS .B ss .RI [ options ] " [ FILTER ]" .SH DESCRIPT

Re: [PATCH] [NET] Size listen hash tables using backlog hint

2006-10-18 Thread Stephen Hemminger
David Miller wrote: From: Eric Dumazet Hi <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 14:58:37 +0200 reqsk_queue_alloc() goal is to use a power of two size for the whole listen_sock structure, to avoid wasting memory for large backlogs, meaning the hash table nr_table_entries is not anymore a

[IPROUTE] 2nd try

2006-10-18 Thread Alexander Wirt
I need more sleep this time hopefully with the manpage attached. Alex .TH SS 8 .SH NAME ss \- another utility to investigate sockets .SH SYNOPSIS .B ss .RI [ options ] " [ FILTER ]" .SH DESCRIPTION This manual page documents briefly the .B ss command. .PP \fBss\fP is another utility to investiga

[IPROUTE] manpage for ss

2006-10-18 Thread Alexander Wirt
Hi, one of my users was so kind to provide a manpage for ss. Would be great if it can be applied to the next release. Alex - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [RFC] Ethernet Cheap Cryptography

2006-10-18 Thread Stephen J. Bevan
Dawid Ciezarkiewicz writes: > You're right. I'll add such documentation. For now - short version: as a > company dealing with wifi regularly we often come to a problem - using wifi > bridges with strengths like price, "CE included", easy integration, good > bandwidth, distance etc. - that th

Re: [PATCH, resent] [NET] reduce per cpu ram used for loopback stats

2006-10-18 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 18 Oct 2006 19:00:03 +0200 > Sorry David, the previous attachment had a missing / in one filename Hehe, and I read this after replying to you about that :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messa

Re: [PATCH] [NET] reduce per cpu ram used for loopback stats

2006-10-18 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 18 Oct 2006 18:35:48 +0200 Applied Eric, but the file paths in your patch were bogus and needed to be fixed up: > --- linux/drivers/net/loopback.c 2006-10-18 17:28:20.0 +0200 > +++ linux-eddrivers/net/loopback.c2006-10-18 18:26:41

Re: [PATCH] [NET] reduce sizeof(struct flow)

2006-10-18 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 18 Oct 2006 15:32:22 +0200 > OK then. Even on a distro kernel (allyesconfig), size(flow) would > shrink by 20 bytes. For the time being, why don't we just kill off the unused dnports bits entirely. Once the support code to use those bits is writt

Re: [IPv6] route: Fix prohibit and blackhole routing decision

2006-10-18 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 18 Oct 2006 12:06:19 +0200 > Lookups resolving to ip6_blk_hole_entry must result in silently > discarding the packets whereas an ip6_pkt_prohibit_entry is > supposed to cause an ICMPV6_ADM_PROHIBITED message to be sent. > > Thanks to Kim Nordlund <

Re: [DECNET] Fix input routing bug

2006-10-18 Thread David Miller
From: Steven Whitehouse <[EMAIL PROTECTED]> Date: Wed, 18 Oct 2006 09:38:17 +0100 > This patch fixes a silly bug that has been in the input routing code > for some time. It results in trying to send to a node directly when > the origin of the packet is via the default router. > > Its been tested

Re: [PATCH] [NET] inet_peer : group together avl_left, avl_right, v4daddr to speedup lookups on some CPUS

2006-10-18 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 18 Oct 2006 09:38:38 +0200 > Lot of routers still use CPUS with 32 bytes cache lines. (Intel PIII) > It make sense to make sure fields used at lookup time are in the same cache > line, to reduce cache footprint and speedup lookups. > > Signed-off

Re: [PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel)

2006-10-18 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 09:07:24 -0400 > ACKed-by: Jamal Hadi Salim > > When Patrick has his patch ready after this goes in we can revisit. If anything it's too late to put this into 2.6.19 so I'll likely therefore toss it into net-2.6.20 whenever I open that tree

Re: [PATCH] Bound TSO defer time (resend)

2006-10-18 Thread David Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 08:22:11 -0400 > That's actually how I originally coded it. :) But then it occurred to > me that if you've already been waiting for a full clock tick, the > marginal CPU savings of waiting longer will not be great. Which is why > I

Re: [PATCH] [NET] Size listen hash tables using backlog hint

2006-10-18 Thread David Miller
From: Eric Dumazet Hi <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 14:58:37 +0200 > reqsk_queue_alloc() goal is to use a power of two size for the whole > listen_sock structure, to avoid wasting memory for large backlogs, > meaning the hash table nr_table_entries is not anymore a power of > two. (He

Re: [IPv4] fib: Remove unused fib_config members

2006-10-18 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 16:11:14 +0200 > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied, thanks Thomas. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vge

[RFT] netpoll: fully initialize skb

2006-10-18 Thread Stephen Hemminger
This stops the protocol is buggy, dev eth0 messages from occurring when netpoll decides to queue packets. It fully initializes the protocol fields. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> If you want to wait on including it, I intend to rollup all the netpoll patches in

Re: [Madwifi-devel] d80211: ANNOUNCE: DadWifi, a port of MadWifi to d80211

2006-10-18 Thread Matt Brown
Jim Thompson wrote: > d80211 bought you nothing here. Assuming we were able to move our development and production environments to a BSD this might be true. But for a plethora of reasons we use Linux and the costs of shifting to *BSD are far too high. Given this scenario, for *us* standardisin

Re: [Madwifi-devel] d80211: ANNOUNCE: DadWifi, a port of MadWifi to d80211

2006-10-18 Thread Jim Thompson
On Oct 18, 2006, at 3:18 PM, Matt Brown wrote: Christoph Hellwig wrote: Guys, why do you waste your time on doing stuff that's useless for most of us, and that people can't even legally redistribute. Well that may be your opinion, but it's certainly not mine. We had just discussed star

[patch] Add ethtool -i interface to Prism54

2006-10-18 Thread Kai Engert
Attached is a small patch that will add support for ethtool -i to the prism54 driver. ethtool -i queries the specified ethernet device for associated driver information. This helps tools like Fedora's system-config-network to provide GUI management of network devices. I learned how to write

Re: [Madwifi-devel] d80211: ANNOUNCE: DadWifi, a port of MadWifi to d80211

2006-10-18 Thread Matt Brown
Christoph Hellwig wrote: > Guys, why do you waste your time on doing stuff that's useless for most > of us, and that people can't even legally redistribute. Well that may be your opinion, but it's certainly not mine. We had just discussed starting an in-house project to port the HAL to the d80211

[PATCH 3/7] I/OAT: Remove the wrappers around read(bwl)/write(bwl) in ioatdma

2006-10-18 Thread Chris Leech
Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c| 60 +++ drivers/dma/ioatdma_io.h | 118 -- 2 files changed, 28 insertions(+), 150 deletions(-) diff --git a/drivers/dma/ioatdma.c b/drivers/dma/ioatdma

[PATCH 4/7] I/OAT: Remove the use of writeq from the ioatdma driver

2006-10-18 Thread Chris Leech
There's only one now anyway, and it's not in a performance path, so make it behave the same on 32-bit and 64-bit CPUs. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/dma/ioatdma.c

[PATCH 2/7] drivers/dma: handle sysfs errors

2006-10-18 Thread Chris Leech
From: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/dmaengine.c | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dma

[PATCH 5/7] I/OAT: Add documentation for the tcp_dma_copybreak sysctl

2006-10-18 Thread Chris Leech
Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- Documentation/networking/ip-sysctl.txt |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index fd3c0c0..e9ee102 100644 --- a/Documentatio

[PATCH 0/7] drivers/dma & I/OAT fixes

2006-10-18 Thread Chris Leech
Various fixes for the hardware memcpy engine code and ioatdma Most of these I've posted before, except for the patch to handle sysfs errors from Jeff Garzik. I've dropped the controversial change to not offload loopback traffic. These changes can be pulled from git://lost.foo-projects.or

[PATCH 7/7] I/OAT: Only offload copies for TCP when there will be a context switch

2006-10-18 Thread Chris Leech
The performance wins come with having the DMA copy engine doing the copies in parallel with the context switch. If there is enough data ready on the socket at recv time just use a regular copy. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- net/ipv4/tcp.c | 10 +++--- 1 files changed,

[PATCH 1/7] I/OAT: Push pending transactions to hardware more frequently

2006-10-18 Thread Chris Leech
Every 20 descriptors turns out to be to few append commands with newer/faster CPUs. Pushing every 4 still cuts down on MMIO writes to an acceptable level without letting the DMA engine run out of work. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c |4 ++-- 1 files

[PATCH 6/7] I/OAT: Add entries to MAINTAINERS for the DMA memcpy subsystem and ioatdma

2006-10-18 Thread Chris Leech
Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- MAINTAINERS | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5305dd6..533adbe 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -915,6 +915,12 @@ M: [EMAIL PROTECTED] L: linux-k

netpoll causes malformed protocol message

2006-10-18 Thread Stephen Hemminger
Now that I know what this is, perhaps others should know. > Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > > Since I've been re-testing the Apple Intel Mac Mini suspend/resume due to > > a USB problem, I thought I might as well see if this rings any bells.. > > > > On resume, networking d

[patch] d80211: fix kernel doc for ieee80211_get_buffered_bc

2006-10-18 Thread David Kimdon
ieee80211_beacon_get() was already described. The doc entry in question describes ieee80211_get_buffered_bc(). Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h === --- wireless-dev.orig/include

[take2 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-10-18 Thread David Kimdon
All one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TXCTL_* definitions. The multiple bit members were converted to u8, s8 or u16 as appropriate. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h

[take2 0/5] d80211: remove bitfields from include/net/d80211.h

2006-10-18 Thread David Kimdon
Continue d80211 bitfield removal. In general, compilers have difficulty generating efficient code for bitfields. This patchset removes all bitfields from include/net/d80211.h. I converted the 1 bit bitfields into a bit in a u32/u16 or u8 flags structure member. Larger bitfields I converted into

[take2 2/5] d80211: remove bitfields from ieee80211_tx_status

2006-10-18 Thread David Kimdon
Both one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TX_STATUS_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h === --- wireless

[take2 3/5] d80211: remove bitfields from ieee80211_key_conf

2006-10-18 Thread David Kimdon
All three one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_KEY_* definitions. The 8 bit keyidx bitfield is converted to type s8. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c =

[take2 5/5] d80211: remove bitfields from ieee80211_conf

2006-10-18 Thread David Kimdon
All four one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_CONF_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h === --- wireless-

[take2 4/5] d80211: remove bitfields from ieee80211_hw

2006-10-18 Thread David Kimdon
All twelve one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_HW_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/adm8211/adm8211.c

Re: [PATCH] bcm43xx: Readd dropped assignment

2006-10-18 Thread Larry Finger
Michael Buesch wrote: On Wednesday 18 October 2006 01:12, Daniel Drake wrote: Larry Finger pointed out a problem with my ieee80211 IV/ICV stripping patch, which I forgot about. Sorry about that. The patch readds the frame_ctl assignment which was accidently dropped. Signed-off-by: Daniel Drake

[PATCH] netpoll: netpoll_send_skb local optimization

2006-10-18 Thread Stephen Hemminger
This cleans up netpoll_send_skb: * np and np->dev are always non-null given the local callers * get device into a local variable Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- orig/net/core/netpoll.c 2006-10-18 13:44:27.0 -0700 +++ new/net/core/netpoll.c 2006-10-18 13

[PATCH] netpoll: don't send packets to detached device

2006-10-18 Thread Stephen Hemminger
Netpoll shouldn't send packets to devices that have detached themselves. This can happen during shutdown or suspend. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/core/netpoll.c2006-10-18 13:41:49.0 -0700 +++ b/net/core/netpoll.c2006-10-18 13:43:44.00

[PATCH] sky2: netpoll on dual port cards

2006-10-18 Thread Stephen Hemminger
The sky2 driver uses a single NAPI poll routine for both ports on dual ported cards (because there is a single IRQ and status ring). Netpoll makes assumptions about the relationship between network device and NAPI that aren't correct on the second port, this will cause the port to never clear work.

Re: 2.6.19rc2 XFRM does too large direct mapping allocations for hashes

2006-10-18 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Wed, 18 Oct 2006 13:50:22 +0200 > I got this while restarting ipsec on a 2.6.19rc2 system that was > up for a few days. It's been fixed already in current GIT. The xfrm state counters weren't being maintained correctly, so they'd go "negative" and the h

[PATCH] netpoll: retry memory leak

2006-10-18 Thread Stephen Hemminger
If netpoll uses up it's retries, it should drop the skb not leak memory. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/core/netpoll.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index ead5920..c375fde 10064

[PATCH 1/3] ethtool: sky2 GMAC decode

2006-10-18 Thread Stephen Hemminger
Add decoding of GMAC bits. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- marvell.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/marvell.c b/marvell.c index 16147a9..244bb69 100644 --- a/marvell.c +++ b/marvell.c @@ -113,6 +113,31

Re: [PATCH] d80211: ieee80211_hw handlers should be allowed to sleep

2006-10-18 Thread Jan Kiszka
Ivo van Doorn wrote: > On Wednesday 18 October 2006 15:06, Jiri Benc wrote: >> On Sat, 7 Oct 2006 11:23:15 +0200, Ivo van Doorn wrote: >>> --- a/net/d80211/ieee80211.c >>> +++ b/net/d80211/ieee80211.c >>> @@ -2075,15 +2075,15 @@ void ieee80211_if_shutdown(struct net_de >>> case IEEE80211_IF_TYP

Re: [take1 0/5] d80211 patches

2006-10-18 Thread David Kimdon
On Wed, Oct 18, 2006 at 07:23:14PM +0200, Ivo van Doorn wrote: > On Wednesday 18 October 2006 19:20, David Kimdon wrote: > > On Wed, Oct 18, 2006 at 06:01:31PM +0200, Jiri Benc wrote: > > > On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote: > > > > Continue d80211 bitfield removal. In general

[PATCH 3/3] ethtool: dump_registers post mortem

2006-10-18 Thread Stephen Hemminger
This patch allows: ethtool -d eth0 raw on >saved_regs and later ethtool -d eth0 file saved_regs Selfish motive is to be able to take register dumps from users and and decode later, possibly adding more output as needed. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- eth

[PATCH 2/3] ethtool: sky2 more decode

2006-10-18 Thread Stephen Hemminger
Dump even more GMAC/GPHY state Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- marvell.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/marvell.c b/marvell.c index 244bb69..e867521 100644 --- a/marvell.c +++ b/marvell.c @@ -113,7 +113,7 @@ static

[PATCH wireless-2.6] ieee80211: don't flood log with errors

2006-10-18 Thread Jiri Benc
The "ieee80211: Workaround malformed 802.11 frames from AP" patch (see http://kernel.org/git/?p=linux/kernel/git/linville/wireless-2.6.git;a=commit;h=f09fc44d8c25f22c4d985bb93857338ed02feac6 ) fixes the problem with some buggy APs but also converts debug message into an error one. This floods the

Re: [take1 0/5] d80211 patches

2006-10-18 Thread Ivo van Doorn
On Wednesday 18 October 2006 19:20, David Kimdon wrote: > On Wed, Oct 18, 2006 at 06:01:31PM +0200, Jiri Benc wrote: > > On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote: > > > Continue d80211 bitfield removal. In general, compilers have > > > difficulty generating efficient code for bitfiel

Re: [PATCH] d80211: ieee80211_hw handlers should be allowed to sleep

2006-10-18 Thread Ivo van Doorn
On Wednesday 18 October 2006 15:06, Jiri Benc wrote: > On Sat, 7 Oct 2006 11:23:15 +0200, Ivo van Doorn wrote: > > --- a/net/d80211/ieee80211.c > > +++ b/net/d80211/ieee80211.c > > @@ -2075,15 +2075,15 @@ void ieee80211_if_shutdown(struct net_de > > case IEEE80211_IF_TYPE_STA: > > case IEEE

Re: [take1 0/5] d80211 patches

2006-10-18 Thread David Kimdon
On Wed, Oct 18, 2006 at 06:01:31PM +0200, Jiri Benc wrote: > On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote: > > Continue d80211 bitfield removal. In general, compilers have > > difficulty generating efficient code for bitfields. This patchset > > removes all bitfields from include/net/d8

[PATCH 4/6] net: use bitrev8

2006-10-18 Thread Akinobu Mita
Use bitrev8 for bmac, mace, macmace, macsonic, and skfp drivers. Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Paul Mackerras <[EMAIL PROTECTED]> Cc: Mirko Lindner <[EMAIL PROTECTED]> Cc: Thomas Bogendoerfer <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> drivers/net/Kconfig

[PATCH] [NET] reduce per cpu ram used for loopback stats

2006-10-18 Thread Eric Dumazet
We dont need a full struct net_device_stats (currently 23 long : 184 bytes on x86_64) per possible CPU, but only two counters : bytes and packets We save few CPU cycles too in loopback_xmit() not updating 4 fields, but 2. Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> --- linux/drivers/net/loo

Re: BCM5461 phy issue in 10M/Full duplex

2006-10-18 Thread Rick Jones
Kumar Gala wrote: I was wondering if anyone has had any issues when trying to force a BCM5461 phy into 10M/full duplex. I seem to be having an issue in the two managed switches I've tried this on but autoneg to 10/half. This causes a problem in that I start seeing a large number of frame

[PATCH, resent] [NET] reduce per cpu ram used for loopback stats

2006-10-18 Thread Eric Dumazet
Sorry David, the previous attachment had a missing / in one filename [NET] reduce per cpu ram used for loopback device stats We dont need a full struct net_device_stats (currently 23 long : 184 bytes on x86_64) per possible CPU, but only two counters : bytes and packets We save few CPU cycles t

Re: [PATCH,RFC] bridge: call eth_type_trans() in br_pass_frame_up()

2006-10-18 Thread Stephen Hemminger
On Wed, 18 Oct 2006 11:14:45 +0200 Lennert Buytenhek <[EMAIL PROTECTED]> wrote: > Hi, > > I've been seeing a failure to reply to incoming ARP packets on a bridge > interface until after the first few packets have been transmitted over > that interface, and the patch below seems to fix the issue,

Re: [PATCH] Bound TSO defer time (resend)

2006-10-18 Thread Stephen Hemminger
On Wed, 18 Oct 2006 17:37:36 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > On Tuesday 17 October 2006 06:18, John Heffner wrote: > > Stephen Hemminger wrote: > > > On Mon, 16 Oct 2006 20:53:20 -0400 (EDT) > > > John Heffner <[EMAIL PROTECTED]> wrote: > > > > >> This patch limits the amount of tim

[PATCH] rt2x00: Remove xr_end references

2006-10-18 Thread Ivo van Doorn
This removes the xr_end references from rt2500usb and rt71usb. The rt2x00 pci drivers were already fixed by David Kimdon. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wireless/d80211/rt2x00/rt2500usb.c b/drivers/net/wireless/d80211/rt2x00/rt2500usb.c index 5d119

Re: [patch] d80211: remove initialization of unused xr structure members

2006-10-18 Thread Ivo van Doorn
Hi, > > The structure member xr_end was removed from d80211.h. > > John, please apply this after you pull from my tree (perhaps with a > rt2x00 prefix in the subject instead of d80211?). The patch itself looked good, but it doesn't fix rt2500usb and rt73usb, I will send a patch to fix the rt2x00

[PATCH 12/18] d80211: remove rate limit code

2006-10-18 Thread Jiri Benc
From: Elliot Schwartz <[EMAIL PROTECTED]> Remove unused and more or less pointless rate limiting code. This would have just dropped multicast frames arbitrarily when the limit is reached which is quite useless and does not really belong to 802.11 code. Signed-off-by: Elliot Schwartz <[EMAIL PROTE

[PATCH 2/18] d80211: add missing rtnl_unlock()

2006-10-18 Thread Jiri Benc
Add forgotten rtnl_unlock() in the error path of ieee80211_register_hw. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) 693ca0e679ae17dd34f5392886f99ba36f68940c diff --git a/net/d80211/ieee80211.c b/net/d8021

[PATCH 11/18] d80211: remove unused xr structure members, interface, etc.

2006-10-18 Thread Jiri Benc
From: Elliot Schwartz <[EMAIL PROTECTED]> This is all unused. Signed-off-by: Elliot Schwartz <[EMAIL PROTECTED]> Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- include/net/d80211.h |9 - include/net/d80211_mgmt.h|4 include/net/d80211_shared.h |

Re: [take1 0/5] d80211 patches

2006-10-18 Thread Jiri Benc
On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote: > Continue d80211 bitfield removal. In general, compilers have > difficulty generating efficient code for bitfields. This patchset > removes all bitfields from include/net/d80211.h. Thanks for the patches! At first I intended to ask you to

Re: [patch] d80211: remove initialization of unused xr structure members

2006-10-18 Thread Jiri Benc
On Fri, 13 Oct 2006 12:34:57 -0700, David Kimdon wrote: > The structure member xr_end was removed from d80211.h. John, please apply this after you pull from my tree (perhaps with a rt2x00 prefix in the subject instead of d80211?). Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this

[PATCH 14/18] d80211: allow wireless vlan interface to have same MAC an AP interface

2006-10-18 Thread Jiri Benc
From: David Kimdon <[EMAIL PROTECTED]> Wireless vlan interfaces need to have the same mac address as AP interfaces. The STA must not see the change when it is bound to a specific vlan, so the address of the vlan interface must be the same as the address of the AP interface the station associated

[PATCH 3/18] d80211: del sta timer on interface close

2006-10-18 Thread Jiri Benc
Delete sta timer when the corresponding network interface is brought down. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c | 24 net/d80211/ieee80211_i.h |1 + net/d80211/ieee80211_iface.c | 12 +++- net/d80211/ieee80211

[PATCH 5/18] d80211: proper rate_control loading

2006-10-18 Thread Jiri Benc
Fix locking issues with loading of rate_control modules. This still doesn't allow changing of the modules on the fly. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/Makefile |1 net/d80211/ieee80211.c | 108 ++- net/d80211/

[PATCH 8/18] d80211: allow changing of the rate control algorithm

2006-10-18 Thread Jiri Benc
Allow changing of the rate control algorithm. This has some limitations: - The rate control algorithm can be set per-wiphy only. - All of network interfaces of the wiphy have to be down to change the algorithm. - All sta entries are flushed when the algorithm is succesfully changed. - The add_st

[PATCH 1/18] d80211: fix is_ieee80211_device

2006-10-18 Thread Jiri Benc
The is_ieee80211_device function must ensure that the passed net_device belongs to the hardware device we are working with. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) 54bac502265add95b8ca098ccf62c1d

[PATCH 9/18] d80211: rate_control: do not use atomic allocations when not necessary

2006-10-18 Thread Jiri Benc
Allow GFP_KERNEL to be used for allocations of sta entries triggered from the user space. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211_ioctl.c |2 +- net/d80211/ieee80211_rate.h |7 --- net/d80211/ieee80211_sta.c |4 ++-- net/d80211/rc80211_simple.c

[PATCH 7/18] d80211: proper rate control structures freeing

2006-10-18 Thread Jiri Benc
Add a reference counting to the rate control algorithm structure. This prevents unloading of the rate control module when there still exists a sta entry which uses that module. To achieve this some other things need to be done in this patch as well: - The new rate_control_ref structure is introdu

[PATCH 17/18] d80211: Fix TX/RX rates

2006-10-18 Thread Jiri Benc
From: Modestas Vainius <[EMAIL PROTECTED]> This patch correctly initializes the force_unicast_rateidx and max_ratectrl_rateidx. This was not done previously and caused a bug in rf80211_simple where when rate_control_simple_get_rate() was called, the incorrect rate was selected from the list. Sign

[PATCH 10/18] d80211: Fix overflow when creating AVS header

2006-10-18 Thread Jiri Benc
From: David Kimdon <[EMAIL PROTECTED]> Fix overflow when converting timespec to microseconds. Without this patch you can get an overflow during the multiplication which can result in a negative number. hostime is define here: 4.4 hosttime The hosttime field is set to the current value of the ho

[PATCH 6/18] d80211: rename rate_control.c to rc80211_simple.c

2006-10-18 Thread Jiri Benc
To support changing of the rate control modules on the fly we need well-defined names of the modules. Let it be rc80211_*. Rename the only one rate control module (rate_control.c) into rc80211_simple.c. The module alias for the default module is changed to rc80211_default. Signed-off-by: Jiri Ben

[PATCH 18/18] d80211: remove unused Super AG definitions, purge comment

2006-10-18 Thread Jiri Benc
From: David Kimdon <[EMAIL PROTECTED]> Remove unused Super AG structure members, enums. In struct ieee80211_tx_status the queue_length and queue_number could be useful outside the context of Super AG, so remove the comment and leave the members. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Si

[PATCH 4/18] d80211: rename rate_control.h to ieee80211_rate.h

2006-10-18 Thread Jiri Benc
rate_control.h is not a header for rate_control.c as the name suggests. Furthermore, we want to introduce ieee80211_rate.c which implements some things defined in rate_control.h. This patch renames rate_control.h to ieee80211_rate.h. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/

[PATCH 13/18] d80211: retain PS frames for at least STA listen interval

2006-10-18 Thread Jiri Benc
From: Jouni Malinen <[EMAIL PROTECTED]> Start using 2 * listen_int * beacon_int as a timeout for PS buffered unicast frames if that is longer than 10 seconds. Previously, we used fixed 10 second limit regardless of the listen interval. This fixes power saving for STAs that request very long liste

[PATCH 16/18] d80211: silence sparse warning: bad constant expression

2006-10-18 Thread Jiri Benc
From: David Kimdon <[EMAIL PROTECTED]> Sparse does not figure out that algs[] isn't really a variable length array. The message is: net/d80211/ieee80211_sta.c:934:12: error: bad constant expression This switches algs[] to be obviously a constant array, and derives the value of num_algs algs[].

[PATCH 0/18] d80211: pull request

2006-10-18 Thread Jiri Benc
Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git up to obtain following patches: David Kimdon: d80211: Fix overflow when creating AVS header d80211: allow wireless vlan interface to have same MAC an AP interface d80211: use FCS_LEN instead of hardco

[PATCH 15/18] d80211: use FCS_LEN instead of hardcoded number.

2006-10-18 Thread Jiri Benc
From: David Kimdon <[EMAIL PROTECTED]> Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) 22acdd71c90cc4123d3df59a07919d432847e3e7 diff --git a/net/d80211/ieee8021

Re: [PATCH] d80211: Fix TX/RX rates

2006-10-18 Thread Jiri Benc
On Sun, 15 Oct 2006 20:14:07 +0200, Ivo van Doorn wrote: > This patch correctly initializes the force_unicast_rateidx > and max_ratectrl_rateidx. This was not done previously > and caused a bug in rf80211_simple where when > rate_control_simple_get_rate() was called, the incorrect > rate was select

Re: d80211: ANNOUNCE: DadWifi, a port of MadWifi to d80211

2006-10-18 Thread Jiri Benc
On Wed, 18 Oct 2006 11:16:05 +0100, Christoph Hellwig wrote: > Guys, why do you waste your time on doing stuff that's useless for most > of us, and that people can't even legally redistribute. I dislike HAL too. But I don't think this effort is useless. It's a great base for a future fully open At

Re: [patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-18 Thread Jiri Benc
On Wed, 18 Oct 2006 08:12:27 -0700, David Kimdon wrote: > I actually think the code reads slightly cleaner using num_algs, but > don't have a strong preference. I'd be happy to make the change if > removing num_algs is preferred. Don't know. But nobody except me objected for more than a week so I

Re: [PATCH] Bound TSO defer time (resend)

2006-10-18 Thread Andi Kleen
On Tuesday 17 October 2006 06:18, John Heffner wrote: > Stephen Hemminger wrote: > > On Mon, 16 Oct 2006 20:53:20 -0400 (EDT) > > John Heffner <[EMAIL PROTECTED]> wrote: > > >> This patch limits the amount of time you will defer sending a TSO segment > >> to less than two clock ticks, or the time

  1   2   >