On Mon, May 14, 2007 at 07:41:48PM +0200, Patrick McHardy wrote:
> Janusz Krzysztofik wrote:
> > Patrick McHardy wrote:
> >
> >> Janusz Krzysztofik wrote:
> >>
> >>> ... ICMP port unreachable messages are not generated inside
> >>> IPVS code, they are just sent, with help of the patch in question,
On Sun, May 13, 2007 at 11:39:37PM -0700, David Miller wrote:
> From: Jarek Poplawski <[EMAIL PROTECTED]>
> Date: Mon, 14 May 2007 08:07:00 +0200
>
> > After sending this patch I was a little confused, when next
> > lockdep warning report appeared, and I thought - since this is
> > not enough, th
On Mon, May 14, 2007 at 12:20:34PM -0700, Michael Chan ([EMAIL PROTECTED])
wrote:
> > > This problem never happend before, but suddenly appeared after quite
> > > long suspend to disk (several month I think).
> > > Nothing was changed in hardware.
> > > Both 2.6.18 and 2.6.21-rc3 have the same iss
I failed to cc some of the people on the cc list ... so am resending.
--linas
On Mon, May 14, 2007 at 06:37:30PM -0500, Linas Vepstas wrote:
>
> This patch adds PCI error recovery support to the
> s2io 10-Gigabit ethernet device driver. Third revision,
> blocks interrupts and the watchdog.
>
>
s2io cleanup suggestions, per discussion on mailing lists.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/s2io.c |2 --
drivers/net/s2io.h |1 -
2 files changed, 3 deletions(-)
Index: linux-2.6.22-rc1/drivers/net/s2io.c
===
This patch adds PCI error recovery support to the
s2io 10-Gigabit ethernet device driver. Third revision,
blocks interrupts and the watchdog.
Tested, seems to work well.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
Acked-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
Cc: Raghavendra Koushik <[EMAI
On Mon, 14 May 2007 09:16:11 +0200
Gabor Burjan <[EMAIL PROTECTED]> wrote:
> On Sat, May 12, 2007 at 05:05:51PM +0200, Patrick McHardy wrote:
> > Gabor Burjan wrote:
> > > EIP is at destroy_conntrack+0x52/0x127 [nf_conntrack]
> > >
> > >>>nmblookup
> > >>>cat /proc/net/ip_conntrack
> > >>>
> > >>
8:46pm Patrick McHardy said:
James Morris wrote:
-- Forwarded message --
Date: Mon, 14 May 2007 08:15:50 -0700 (PDT)
From: Curtis Doty <[EMAIL PROTECTED]>
To: Linux Kernel <[EMAIL PROTECTED]>
Subject: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr
Summa
> Incoporating last comments from Patrick.
> Dave, I think this is ready to apply - against net-2.6 from
> this morning.
Aside from the whitespace changes, I've run this patch over the weekend
with no issue under moderate stress. Looks fine to me.
Thx,
-PJ Waskiewicz
-
To unsubscribe from thi
On Mon, 14 May 2007 00:53:42 -0400
Florin Malita <[EMAIL PROTECTED]> wrote:
> Hi Stephen,
>
> Stephen Hemminger wrote:
> > Use DMI to add a blacklist of broken board. For now only one is known
> > bad. Gentoo users report driver works on other motherboards (strange).
> [snip]
> > +
Align the PHY setup of the sky2 driver with the vendor sk98lin (10.0.4.3)
driver. The PHY register settings are mostly black magic, even with access
to the documentation it isn't clear what the right values are. The changes
are mostly comments, the code change only affects the Yukon FE (100 mbit on
Do some memory barrier changes for safety/perfomance:
Don't need read after update to index, mmiowb() followed by read at end
of irq is sufficient.
Signed-off-by: Stephn Hemminger <[EMAIL PROTECTED]>
---
drivers/net/sky2.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
The problems with Gigabyte motherboards are system configuration dependent.
Since it works fine for some users, it doesn't make sense to deprive
them.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/sky2.c | 30 --
1 file changed, 30 deletions(-
These are less serious than the last group, and are mostly
one liners. I decided to give up blacklisting the 88e8056
problem in the driver, if the driver can't identify what configuration
is good/bad, then it has no business trying to enforce the policy.
--
Stephen Hemminger <[EMAIL PROTECTED]>
When driver can't allocate receive buffer it drops incoming
packet. Keep a counter.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/sky2.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- 2.6.21-rc1.orig/drivers/net/sky2.c 2007-05-14 12:10:13.0 -0700
Make sure that if we ever get a MIB counter overflow interrupt (normally
masked off), that the IRQ is cleared.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/sky2.c |6 ++
1 file changed, 6 insertions(+)
--- 2.6.21-rc1.orig/drivers/net/sky2.c 2007-05-14 12:10:16.0
This workaround was added to deal with NAPI core and how
it affected dual port shared polling. It turned out not to
be necessary. Stopping device 0 only doesn't stop NAPI from
working completely after that.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/sky2.c |7 --
2007/5/11, Kumar Gala <[EMAIL PROTECTED]>:
On May 11, 2007, at 8:49 AM, Matvejchikov Ilya wrote:
> 2007/5/11, Kumar Gala <[EMAIL PROTECTED]>:
>>
>> On May 11, 2007, at 5:58 AM, Matvejchikov Ilya wrote:
>>
>> > Signed-off-by: Matvejchikov Ilya <[EMAIL PROTECTED]>
>> > ---
>> >
>> > diff -purN li
Patrick McHardy wrote:
> James Morris wrote:
>
>>-- Forwarded message --
>>Date: Mon, 14 May 2007 08:15:50 -0700 (PDT)
>>From: Curtis Doty <[EMAIL PROTECTED]>
>>To: Linux Kernel <[EMAIL PROTECTED]>
>>Subject: oops in net/ipv4/icmp.c:icmp_send() with
>>icmp_errors_use_inbound_ifadd
On Sun, 13 May 2007 11:55:29 -0400
Daniel Drake <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger wrote:
> > I can use DMI to narrow down to one motherboard.
> > Or just let everything through and let user's discover what's unstable, it
> > fails
> > relatively quickly.
> >
> > Could you please ge
Hi David,
On Mon, May 14, 2007 at 03:20:54AM -0700, David Miller wrote:
> From: Frederik Deweerdt <[EMAIL PROTECTED]>
> Date: Fri, 11 May 2007 17:00:14 +0200
>
> > I think that not unix_state_rlock'ing "other" in
> > unix_dgram_connect may cause it to become NULL while passing it to
> > selinux_s
Note that the high-order bit is set for all ports above 32768, so this
dragon would be stepped on pretty badly by Linux's default (and
indeed, the default for most OS's).
However, by "the very top", I think he was referring to the range
61000-65535, not all ports from 32768 up. Alan Cox clarifie
James Morris wrote:
> -- Forwarded message --
> Date: Mon, 14 May 2007 08:15:50 -0700 (PDT)
> From: Curtis Doty <[EMAIL PROTECTED]>
> To: Linux Kernel <[EMAIL PROTECTED]>
> Subject: oops in net/ipv4/icmp.c:icmp_send() with
> icmp_errors_use_inbound_ifaddr
>
> Summary: On a multi-h
On Mon, 14 May 2007 10:08:43 -0700
Rick Jones <[EMAIL PROTECTED]> wrote:
> >>I think the IANA range is considered too small in most cases; I
> >>suspect there is also a feeling that "there be dragons" near the
> >>very top.
>
> About the only dragons which come to mind would be the very old,
> dec
On Mon, 2007-05-14 at 10:15 -0700, Michael Chan wrote:
> On Mon, 2007-05-14 at 18:54 +0400, Evgeniy Polyakov wrote:
> > This problem never happend before, but suddenly appeared after quite
> > long suspend to disk (several month I think).
> > Nothing was changed in hardware.
> > Both 2.6.18 and 2.6
-- Forwarded message --
Date: Mon, 14 May 2007 08:15:50 -0700 (PDT)
From: Curtis Doty <[EMAIL PROTECTED]>
To: Linux Kernel <[EMAIL PROTECTED]>
Subject: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr
Summary: On a multi-homed box, after turning on
/proc/sys/
Milton Miller wrote:
In fact 6.4.3.4 says 82557 will start dropping frames immediately.
Looking at the descriptions around page 101:
(1) The link pointer, S, and EL is read when hw starts recieving the frame.
(2) Its pretty clear EL overrides S from the order of the descriptions
in the text.
(3
Janusz Krzysztofik wrote:
> Patrick McHardy wrote:
>
>> Janusz Krzysztofik wrote:
>>
>>> ... ICMP port unreachable messages are not generated inside
>>> IPVS code, they are just sent, with help of the patch in question, from
>>> udp_input() or netfilter REJECT.
>>
>>
>> Both use icmp_send(), which
Mark Glines wrote:
(resending to netdev and copying maintainers, at Alan Cox's suggestion. Thanks
Alan!)
On Sat, 12 May 2007 12:12:38 -0700 "H. Peter Anvin" <[EMAIL PROTECTED]> wrote:
Mark Glines wrote:
Well, in that case, is there anything wrong with just using the
range IANA recommends,
On Mon, 2007-05-14 at 18:54 +0400, Evgeniy Polyakov wrote:
> I've cought a problem with my laptop and tg3 driver.
> Suddenly (it was turned off quite for a while) tg3 driver does not start
> up.
>
> Here is dmesg messages (copied by hand, some bits are ommitted):
> acpi: ... // device enbaled in
On Mon, 2007-05-14 at 09:24 -0500, Kumar Gala wrote:
> this was my fix which looks pretty much the same.
[...]
Great, thanks.
johannes
signature.asc
Description: This is a digitally signed message part
On Mon, 14 May 2007 10:20:26 -0400
Michael Stone <[EMAIL PROTECTED]> wrote:
> On Tue, May 08, 2007 at 10:15:18AM -0700, Stephen Hemminger wrote:
> >On Tue, 08 May 2007 08:00:36 -0400
> >Michael Stone <[EMAIL PROTECTED]> wrote:
> >> 2.6.21 seems to have fixed the stability issues I was seeing when
Kenji Kaneshige found this race between device removal and
registration. On unregister it is possible for the old device to
exist, because sysfs file is still open. A new device with 'eth%d'
will select the same name, but sysfs kobject register will fial.
The following changes the shutdown order
Patrick McHardy wrote:
Janusz Krzysztofik wrote:
... ICMP port unreachable messages are not generated inside
IPVS code, they are just sent, with help of the patch in question, from
udp_input() or netfilter REJECT.
Both use icmp_send(), which should always pick a local source, so I
don't unders
On Mon, 14 May 2007 10:33:01 +0900
Kenji Kaneshige <[EMAIL PROTECTED]> wrote:
> Hi Stephen,
>
> Thank you for comments. I'll try your patch.
>
> I have one concern about your patch, though I don't know very much
> about netdev codes.
>
> @@ -3411,6 +3410,9 @@ void unregister_netdevice(struct n
On Mon, May 14, 2007 at 06:54:20PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED])
wrote:
> Hi.
>
> I've cought a problem with my laptop and tg3 driver.
> Suddenly (it was turned off quite for a while) tg3 driver does not start
> up.
> PM: writing back config space on device /* tg3 device pcix id*/ a
Hi.
I've cought a problem with my laptop and tg3 driver.
Suddenly (it was turned off quite for a while) tg3 driver does not start
up.
Here is dmesg messages (copied by hand, some bits are ommitted):
acpi: ... // device enbaled in couple of words
eth0: Tigon3 [partno(BMC5705mA3) rev 3003 PHY(5705
Janusz Krzysztofik wrote:
> David Miller wrote:
>
>>> BTW, there doesn't even seem to be a spot where IPVS calls
>>> ip_route_output with the source address set. What exactly is this
>>> needed for?
>>
>>
>> I suppose he has a patch to make use of it, but was waiting
>> for this route.c change to
On Mon, 14 May 2007, Johannes Berg wrote:
> Simon,
>
> > I don't think that this is quite right, or at least it isn't quite the
> > same as before.
>
> Yeah, I think you're right.
>
> > I think that was is below will toggle
> > SYS_SUPPORTS_APM_EMULATION when PMAC_APM_EMU is selected,
> > which I
David Miller wrote:
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon, 14 May 2007 12:21:34 +0200
This allows any user to send spoofed packets when ip_nonlocal_bind
is set, which is a quite big change in behaviour of this option.
The TPROXY patches include a similar change, but use a flag in
On Tue, May 08, 2007 at 10:15:18AM -0700, Stephen Hemminger wrote:
On Tue, 08 May 2007 08:00:36 -0400
Michael Stone <[EMAIL PROTECTED]> wrote:
2.6.21 seems to have fixed the stability issues I was seeing when using
the skge driver with the older sk98xx dual port fiber cards. There is
still one
Incoporating last comments from Patrick.
Dave, I think this is ready to apply - against net-2.6 from this
morning.
cheers,
jamal
[NET_SCHED]: Cleanup readability of qdisc restart
Over the years this code has gotten hairier. Resulting in many long
discussions over long summer days and patches t
Simon,
> I don't think that this is quite right, or at least it isn't quite the
> same as before.
Yeah, I think you're right.
> I think that was is below will toggle
> SYS_SUPPORTS_APM_EMULATION when PMAC_APM_EMU is selected,
> which I think is what you want. Is it also neccessary to
> add a de
On Mon, May 14, 2007 at 10:08:29AM +0200, Jarek Poplawski wrote:
> On Mon, May 14, 2007 at 09:28:45AM +0200, Jarek Poplawski wrote:
> > On Sun, May 13, 2007 at 11:39:37PM -0700, David Miller wrote:
> ...
> > > For each unique netdev type, use a different locking class.
> > >
> > > That will fix th
jamal wrote:
> On Mon, 2007-14-05 at 12:40 +0200, Patrick McHardy wrote:
>>>+if (unlikely (ret != NETDEV_TX_BUSY && net_ratelimit()))
>>>+printk(KERN_DEBUG " BUG %s code %d qlen %d\n",dev->name, ret,
>>>q->q.qlen);
>
> What whitespace issue?
Space between unlikely and '(', missi
On Mon, 2007-14-05 at 12:40 +0200, Patrick McHardy wrote:
> Two final suggestions, sorry for not mentioning this earlier.
np
> > + printk(KERN_DEBUG
> > + "Dead loop on netdevice %s, fix it urgently!\n",
> > + dev->name);
>
> >
Make the call state names array available even if CONFIG_PROC_FS is disabled
as it's used in other places (such as debugging statements) too.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
net/rxrpc/ar-call.c | 19 +++
net/rxrpc/ar-proc.c | 19 ---
2 fil
Add a dependency for CONFIG_AF_RXRPC on CONFIG_INET. This fixes this error:
net/built-in.o: In function `rxrpc_get_peer':
(.text+0x42824): undefined reference to `ip_route_output_key'
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
net/rxrpc/Kconfig |2 +-
1 files changed, 1 insertion
jamal wrote:
> Ok, I am upgrading this to last call after taking in Patricks feedback.
> Speak now - or send patches against it later.
> Dave, just let it simmer down for a day or two, then if no complaints,
> go ahead and apply it. It is against net-2.6
> Many thanks to Thomas, Peter and Patrick
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon, 14 May 2007 12:21:34 +0200
> This allows any user to send spoofed packets when ip_nonlocal_bind
> is set, which is a quite big change in behaviour of this option.
> The TPROXY patches include a similar change, but use a flag in
> struct flowi th
Linux Kernel Mailing List wrote:
> Gitweb:
> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2d771cd86d4c3af26f34a7bcdc1b87696824cad9
> Commit: 2d771cd86d4c3af26f34a7bcdc1b87696824cad9
>
> [IPV4] LVS: Allow to send ICMP unreachable responses when real-s
From: Frederik Deweerdt <[EMAIL PROTECTED]>
Date: Fri, 11 May 2007 17:00:14 +0200
> I think that not unix_state_rlock'ing "other" in
> unix_dgram_connect may cause it to become NULL while passing it to
> selinux_socket_unix_may_send. With the following patch applied, I've
> seen no oops so far (1-
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]>
Date: Sat, 12 May 2007 01:19:49 +0900 (JST)
> In article <[EMAIL PROTECTED]> (at Sat, 12 May 2007 01:10:04 +0900), Mitsuru
> Chinen <[EMAIL PROTECTED]> says:
>
> > [IPV4] SNMP: Display new statistics at /proc/net/netstat
> >
> > This displays t
From: Dave Johnson <[EMAIL PROTECTED]>
Date: Sat, 12 May 2007 12:36:47 -0400
>
> While testing adding/deleting large numbers of interfaces, I found
> rt_run_flush() was the #1 cpu user in a kernel profile by far.
>
> The below patch changes rt_run_flush() to only take each spinlock
> protecting
On Mon, May 14, 2007 at 02:18:31AM -0700, David Miller wrote:
> From: Jarek Poplawski <[EMAIL PROTECTED]>
> Date: Mon, 14 May 2007 09:28:45 +0200
>
> > Yes, this is very good idea, and I wonder, why you didn't try
> > this yourself (after my "ignore").
>
> Because you are a skilled programmer and
From: David Stevens <[EMAIL PROTECTED]>
Date: Sat, 12 May 2007 17:21:10 -0700
> Your patch looks correct to me.
>
> +-DLS
>
> Signed-off-by: David L Stevens <[EMAIL PROTECTED]>
Patch applied, thanks Corey and David for reviewing.
I'll push this to -stable too.
-
To unsu
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 14 May 2007 17:39:41 +1000
> [IPSEC]: Check validity of direction in xfrm_policy_byid
>
> The function xfrm_policy_byid takes a dir argument but finds the policy
> using the index instead. We only use the dir argument to update the
> policy count f
From: Jarek Poplawski <[EMAIL PROTECTED]>
Date: Mon, 14 May 2007 09:28:45 +0200
> Yes, this is very good idea, and I wonder, why you didn't try
> this yourself (after my "ignore").
Because you are a skilled programmer and you might find some
flaw in my suggestion :-)
-
To unsubscribe from this li
Hi,
> How about the following (untested), instead. It hold a removes the sysfs
> entries earlier (on unregister_netdevice), but holds a kobject reference.
> Then when todo runs the actual last put free happens.
I've confirmed the problem is fixed by Stephen's patch on my reproduction
environment.
On Mon, May 14, 2007 at 09:28:45AM +0200, Jarek Poplawski wrote:
> On Sun, May 13, 2007 at 11:39:37PM -0700, David Miller wrote:
...
> > For each unique netdev type, use a different locking class.
> >
> > That will fix this forever, anything else is a situation specific
> > band-aid (but then agai
On Friday 11 May 2007 19:13:41 Patrick McHardy wrote:
> Joakim Koskela wrote:
> > I'm running a system where there might be multiple simultenously
> > active ipsec states between two hosts (ipv6, but guess it applies to
> > v4 as well) where the outer ip is the same for all states, but the
> > inne
On Mon, May 14, 2007 at 05:27:55PM +1000, Herbert Xu wrote:
>
> In fact that's a clue. If you add them all up they come out at the
> same value. So we're getting the directions mixed up...
Found the problem. It was my own fault in a way :)
[IPSEC]: Check validity of direction in xfrm_policy_b
On Mon, May 14, 2007 at 05:26:57PM +1000, Herbert Xu wrote:
> On Mon, May 14, 2007 at 05:07:33PM +1000, Herbert Xu wrote:
> >
> > Good point. A bit of dd-ing shows that I've got a negative value
> > in xfrm_policy_count[0] (0xfff6).
>
> In fact the other two directions are bogus too, OUT say
On Mon, May 14, 2007 at 05:07:33PM +1000, Herbert Xu wrote:
>
> Good point. A bit of dd-ing shows that I've got a negative value
> in xfrm_policy_count[0] (0xfff6).
In fact the other two directions are bogus too, OUT says 10 and FWD
says 5. The actual values are IN == 2, OUT == 2, FWD == 1.
On Sun, May 13, 2007 at 11:39:37PM -0700, David Miller wrote:
> From: Jarek Poplawski <[EMAIL PROTECTED]>
> Date: Mon, 14 May 2007 08:07:00 +0200
>
> > After sending this patch I was a little confused, when next
> > lockdep warning report appeared, and I thought - since this is
> > not enough, th
On Sat, May 12, 2007 at 05:05:51PM +0200, Patrick McHardy wrote:
> Gabor Burjan wrote:
> > EIP is at destroy_conntrack+0x52/0x127 [nf_conntrack]
> >
> >>>nmblookup
> >>>cat /proc/net/ip_conntrack
> >>>
> >>>sleep 3
> >>>
> >>>rmmod nf_conntrack_netbios_ns
>
> Thanks for the report and good testca
On Sun, May 13, 2007 at 11:36:35PM -0700, David Miller wrote:
>
> Thanks I'll add the warning fix, but there must be some counter
> bug if it tried to grow to order-7, that really shouldn't
> be happening.
Good point. A bit of dd-ing shows that I've got a negative value
in xfrm_policy_count[0] (
67 matches
Mail list logo
