Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-10 Thread David Miller
From: Miklos Szeredi <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 08:41:30 +0200 > This may seem low priority and irrelevant, but it _is_ a bug, and it's > affecting a real world application. So please take that into > consideration. I'm not the only person who hasn't reviewed your latest patch ye

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-10 Thread Miklos Szeredi
> > But myself, nor any other developers, are going to review your work > > any faster if you do things like try to slip things in behind the > > maintainer's back as you attempted to do yesterday by asking Andrew to > > put your AF_UNIX garbage collector rewrite directly into his -mm tree. > > mm

Re: [PATCH] [2.6.22] Remove unneeded pointer idev from addrconf_cleanup() in net/ipv6/addrconf.c

2007-07-10 Thread David Miller
From: "Micah Gruber" <[EMAIL PROTECTED]> Date: Mon, 9 Jul 2007 11:30:46 +0800 > This trivial patch removes the unneeded pointer idev returned from > __in6_dev_get(), which is never used. The check for NULL can be simply > done by if (__in6_dev_get(dev) == NULL). > > Signed-off-by: Micah Gruber <

Re: [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code

2007-07-10 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 06 Jul 2007 15:31:56 +0200 > Rémi Denis-Courmont wrote: > > On Thursday 05 July 2007 20:25:50 ext James Chapman wrote: > > > >>Rémi Denis-Courmont wrote: > >> > >>>By the way, couldn't encap_type be remove altogether (using two slightly > >>>di

Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets

2007-07-10 Thread Satyam Sharma
Hi Joel, On Tue, 10 Jul 2007, Joel Becker wrote: > On Wed, Jul 11, 2007 at 03:47:09AM +0530, Satyam Sharma wrote: > > Hmm, I put it in there because I expected that the user must have had > > at least one target configured (added to target_list) if he's got the > > module loaded/built-in (and netc

Re: [PATCH] [NET]: Another unnecessary net/tcp.h inclusion in net/dn.h

2007-07-10 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Sun, 8 Jul 2007 18:26:26 +0300 (EEST) > No longer needed. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied, thanks a lot! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] make all initialized struct seq_operations const

2007-07-10 Thread David Miller
From: Philippe De Muyter <[EMAIL PROTECTED]> Date: Fri, 6 Jul 2007 15:25:43 +0200 > Make all initialized struct seq_operations in net/ const > > Signed-off-by: Philippe De Muyter <[EMAIL PROTECTED]> Applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: Races in net_rx_action vs netpoll?

2007-07-10 Thread David Miller
From: Olaf Kirch <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 12:44:31 +0200 > On Tuesday 10 July 2007 00:27, David Miller wrote: > > I'm happy to entertain this kind of solution, but we really > > need to first have an interface to change multiple bits > > at a time in one atomic operation, because

Re: [GIT PATCH] Updates for RH0 deprecation.

2007-07-10 Thread David Miller
IL PROTECTED]> > > Date: Tue, 10 Jul 2007 02:29:01 +0900 (JST) > > > > > Changesets are available at > > > git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git/ > > > on the branch named > > > linux-2.6.22_deprecate-rh0-20070710 > &

Re: [PATCH v2 -mm 4/9] netconsole: Add some useful tips to documentation

2007-07-10 Thread Satyam Sharma
On Tue, 10 Jul 2007, Joel Becker wrote: > On Wed, Jul 11, 2007 at 03:40:22AM +0530, Satyam Sharma wrote: > > IMHO something that mentions /proc/sys/kernel/printk would be better. > > > > You don't need to have built with SysRq support for that, it's clearly > > more flexible than the ignore_loglev

Re: [PATCH][NET_SCHED] Make HTB scheduler work with TSO.

2007-07-10 Thread David Miller
From: "Ranjit Manomohan" <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 15:02:16 -0700 > On 7/9/07, David Miller <[EMAIL PROTECTED]> wrote: > > From: Ranjit Manomohan <[EMAIL PROTECTED]> > > Date: Tue, 12 Jun 2007 16:53:21 -0700 (PDT) > > > > > Currently the HTB scheduler does not correctly account fo

Re: [NET]: Update comments for skb checksums

2007-07-10 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 09:33:53 +0800 > Hi Dave: > > [NET]: Update comments for skb checksums > > Rusty (whose comments we should all study and emulate :) pointed > out that our comments for skb checksums are no longer up-to-date. > So here is a patch to > >

Re: [patch 2/8] Make some network-related proc files use seq_list_xxx helpers

2007-07-10 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 17:20:52 -0700 > On Wed, 11 Jul 2007 09:05:13 +0900 (JST) > Yasuyuki KOZAKAI <[EMAIL PROTECTED]> wrote: > > > > > I've met compile error on net-2.6.23 tree. > > > > net/built-in.o: In function `proto_seq_next': > > sock.c:(.text+0x3

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 22:12:24 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > But myself, nor any other developers, are going to review your work > any faster if you do things like try to slip things in behind the > maintainer's back as you attempted to do yesterday by asking Andrew to > put

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-10 Thread David Miller
Just to make it clear Miklos. I have seen your patch as has everyone else. But myself, nor any other developers, are going to review your work any faster if you do things like try to slip things in behind the maintainer's back as you attempted to do yesterday by asking Andrew to put your AF_UNIX

Re: [Cbe-oss-dev] [PATCH] spidernet: improve interrupt handling

2007-07-10 Thread Ishizaki Kou
Linas-san, > On Mon, Jul 09, 2007 at 05:48:08PM +0900, Ishizaki Kou wrote: > > We intend this patch to improve spidernet interrupt handling to be > > more strict. We had following problem and this patch solves it. > > Looks reasonable to me. I'll forward it upstream. In the future, Thank you.

[PATCH v2 (updated) -mm 4/9] netconsole: Add some useful tips to documentation

2007-07-10 Thread Satyam Sharma
[4/9 (updated)] netconsole: Add some useful tips to documentation Add some useful general-purpose tips. Also suggest solution for the frequent problem of console_loglevel set too low numerically (i.e. for high priority messages only) on the sender. Cc: Matt Mackall <[EMAIL PROTECTED]> Cc: Jesper

Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets

2007-07-10 Thread Joel Becker
On Wed, Jul 11, 2007 at 03:47:09AM +0530, Satyam Sharma wrote: > Hmm, I put it in there because I expected that the user must have had > at least one target configured (added to target_list) if he's got the > module loaded/built-in (and netconsole registered), which is when this > function would be

Re: [PATCH v2 -mm 4/9] netconsole: Add some useful tips to documentation

2007-07-10 Thread Joel Becker
On Wed, Jul 11, 2007 at 03:40:22AM +0530, Satyam Sharma wrote: > IMHO something that mentions /proc/sys/kernel/printk would be better. > > You don't need to have built with SysRq support for that, it's clearly > more flexible than the ignore_loglevel option and wouldn't require a > reboot either.

Re: [PATCH v2 -mm 4/9] netconsole: Add some useful tips to documentation

2007-07-10 Thread Satyam Sharma
Hi Jesper, On Tue, 10 Jul 2007, Jesper Juhl wrote: > On Tuesday 10 July 2007 11:41:43 Matt Mackall wrote: > > On Tue, Jul 10, 2007 at 02:49:41PM +0530, Satyam Sharma wrote: > > > From: Satyam Sharma <[EMAIL PROTECTED]> > > > > > > [4/9] netconsole: Add some useful tips to documentation > > > > > >

Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets

2007-07-10 Thread Satyam Sharma
Hi, On Tue, 10 Jul 2007, Duane Griffin wrote: > On 10/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > + /* Avoid taking lock and disabling interrupts unnecessarily */ > > + if (unlikely(list_empty(&target_list))) > > + return; > > Is the unlikely a good idea here? No

[ANNOUNCE] iproute2 2.6.22-070710

2007-07-10 Thread Stephen Hemminger
This is an update to iproute2 utilities including bug fixes and features related to 2.6.22 kernel. This package tries to be source compatible across releases. The same source should build on older systems, but obviously the newer kernel features won't be available. It can be downloaded from: ht

[NET]: Update comments for skb checksums

2007-07-10 Thread Herbert Xu
Hi Dave: [NET]: Update comments for skb checksums Rusty (whose comments we should all study and emulate :) pointed out that our comments for skb checksums are no longer up-to-date. So here is a patch to 1) add the case of partial checksums on input; 2) update partial checksum case to mention csu

Re: [patch 2/8] Make some network-related proc files use seq_list_xxx helpers

2007-07-10 Thread Yasuyuki KOZAKAI
I've met compile error on net-2.6.23 tree. net/built-in.o: In function `proto_seq_next': sock.c:(.text+0x3008): undefined reference to `seq_list_next' net/built-in.o: In function `proto_seq_start': sock.c:(.text+0x3079): undefined reference to `seq_list_start_head' make: *** [.tmp_vmlinux1] Error

Re: Fwd: r8169 driver supporting the 8167 dev ID

2007-07-10 Thread Jonathan Larsen
The patchkit from 2.6.18 to (almost) current contains 47 patches. git is a wonderful tool for endless nights of S&M backporting but I'd appreciate to understand why you can not use a more recent kernel before engaging. Not a problem, sorry i didn't mention it before. i am using smoothwall 3. it

Re: [patch 2/8] Make some network-related proc files use seq_list_xxx helpers

2007-07-10 Thread Andrew Morton
On Wed, 11 Jul 2007 09:05:13 +0900 (JST) Yasuyuki KOZAKAI <[EMAIL PROTECTED]> wrote: > > I've met compile error on net-2.6.23 tree. > > net/built-in.o: In function `proto_seq_next': > sock.c:(.text+0x3008): undefined reference to `seq_list_next' > net/built-in.o: In function `proto_seq_start': >

[PATCH 2/5] net: use numa_node in net_devcice->dev instead of parent

2007-07-10 Thread Yinghai Lu
[PATCH 2/5] net: use numa_node in net_devcice->dev instead of parent Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 27cfe5f..005cc1c 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -217,7 +217,7 @@ nodata: struct sk_buff *__netdev_

[PATCH 0/5] more about numa_node with struct device

2007-07-10 Thread Yinghai Lu
these are revised or new patch with numa_node in struct device in addition to andrew already sent to andi x86_64-get-mp_bus_to_node-as-early.patch it will make all pci_dev->dev.numa_node correctly. still in -mm, and andrew will re-review for 2.6.23 dma-make-dma-pool-to-use-kmalloc_node.patch in

[PATCH 4/5] net: show numa_node for net_device in /sys

2007-07-10 Thread Yinghai Lu
[PATCH 4/5] net: show numa_node for net_device in /sys Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 5c19b06..45b87a5 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -230,6 +230,14 @@ static ssize_t store_weight(struc

[PATCH 5/5] dma: use dev_to_node to get node for device in dma_alloc_pages

2007-07-10 Thread Yinghai Lu
[PATCH 5/5] dma: use dev_to_node to get node for device in dma_alloc_pages Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> diff --git a/arch/x86_64/kernel/pci-dma.c b/arch/x86_64/kernel/pci-dma.c index 9f80aad..6dbf1c9 100644 --- a/arch/x86_64/kernel/pci-dma.c +++ b/arch/x86_64/kernel/pci-dma.c @@

[PATCH 1/5] try parent numa_node at first before using default

2007-07-10 Thread Yinghai Lu
[PATCH 1/5] try parent numa_node at first before using default For pci_device, pcibios_scan_root and pci_scan_root will call pci_device_add. pci_device_add will call device_initialize and set_dev_node(&dev->dev, pcibus_to_node(bus)). other device such as netdev, and usb_device, set_dev_node is nev

Re: No network on Asus P5B (r8169)

2007-07-10 Thread Francois Romieu
Clemens Brunner <[EMAIL PROTECTED]> : [...] > I just found out that everything is working just fine with a 64-bit Linux > kernel. I hope this helps you hunt down the error in the 32-bit version. > https://bugzilla.novell.com/show_bug.cgi?id=288406 Does your setup exclude the "wake up" issue descr

Re: [PATCH] Fix kernel unaligned access with r8169 on sparc64

2007-07-10 Thread Francois Romieu
Francois Romieu <[EMAIL PROTECTED]> : [...] > - try http://www.fr.zoreil.com/people/francois/backport/r8169/20070604-00 > It is a backport against 2.6.18 which should bring you quite close to > 2.6.23-git wrt r8169. Regarding the backport option, it was initially more a compiled-ok-untested-

Re: [PATCH][NET_SCHED] Make HTB scheduler work with TSO.

2007-07-10 Thread Ranjit Manomohan
On 7/9/07, David Miller <[EMAIL PROTECTED]> wrote: From: Ranjit Manomohan <[EMAIL PROTECTED]> Date: Tue, 12 Jun 2007 16:53:21 -0700 (PDT) > Currently the HTB scheduler does not correctly account for TSO packets > which causes large inaccuracies in the bandwidth control when using TSO. > This pat

Re: Fwd: r8169 driver supporting the 8167 dev ID

2007-07-10 Thread Francois Romieu
Jonathan Larsen <[EMAIL PROTECTED]> : > I've been looking for the r8169 driver that is for the 2.6.x kernel > and also supports the device id 8167, 10ec. chipset is the 8110sc. > im sure someone is familiar with this. It is not the most used chipset in the 816x family but there are some known use

Re: [PATCH] Fix kernel unaligned access with r8169 on sparc64

2007-07-10 Thread Francois Romieu
Philip Craig <[EMAIL PROTECTED]> : [...] > Try the patches at http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.22-rc6/ > I think patches 0012 and/or 0017 will fix this. They should but they will not apply directly against 2.6.18-something. Florian, can you consider one of the option below: - try c

Re: ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Andrew Morton
On Wed, 11 Jul 2007 00:31:23 +0400 Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > Hello. > > Andrew Morton wrote: > > > 3x59x-fix-pci-resource-management.patch: you wrote it ;) I have a comment > > No, I did, almost a year ago already. :-) I thought that was odd. I fixed the attribution.

Re: ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Sergei Shtylyov
Hello. Andrew Morton wrote: 3x59x-fix-pci-resource-management.patch: you wrote it ;) I have a comment No, I did, almost a year ago already. :-) here: - I don't remember the story with cardbus either. Presumably once upon a time the cardbus layer was claiming IO regions on behalf of

Re: [2.6 patch] the scheduled sk98lin removal

2007-07-10 Thread Chris Stromsoe
On Tue, 10 Jul 2007, Chris Stromsoe wrote: On Tue, 10 Jul 2007, Stephen Hemminger wrote: On Tue, 10 Jul 2007 12:44:35 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Adrian Bunk wrote: This patch contains the scheduled removal of the sk98lin driver. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]

Re: [2.6 patch] the scheduled sk98lin removal

2007-07-10 Thread Chris Stromsoe
On Tue, 10 Jul 2007, Stephen Hemminger wrote: On Tue, 10 Jul 2007 12:44:35 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Adrian Bunk wrote: This patch contains the scheduled removal of the sk98lin driver. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Stephen -- ACK? Yes. Existing driver

Re: ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Sergei Shtylyov
Hello. Jeff Garzik wrote: 3x59x-fix-pci-resource-management.patch Now that the fix for CONFIG_PCI=n has been merged, what's left is to test this on EISA (at least Andrew wanted it :-). netdev patches which are stuck in limbo land. ? I don't think I've seen these. You should h

Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

2007-07-10 Thread Jean Tourrilhes
On Tue, Jul 10, 2007 at 02:25:12PM -0500, Larry Finger wrote: > Jean, > > Jean Tourrilhes wrote: > > Hi, > > > > SoftMAC output the channel twice in the scan output. It should > >display frequency and channel, but only once for each. > >-

Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

2007-07-10 Thread Larry Finger
Jean, Jean Tourrilhes wrote: Hi, SoftMAC output the channel twice in the scan output. It should display frequency and channel, but only once for each. Cell 02 - Address: A2:00:04:XX:XX:XX ESSI

Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-07-10 Thread John W. Linville
The following changes since commit 71780f59e127bb281a9302d430495ca9586c14e7: Linus Torvalds (1): Merge branch 'for-linus' of git://git.kernel.org/.../ieee1394/linux1394-2.6 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git up

Re: ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Jeff Garzik
Andrew Morton wrote: On Tue, 10 Jul 2007 13:42:16 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: (just to provide my indicator of status) Thanks. libata-add-irq_flags-to-struct-pata_platform_info-fix.patch are other pata_platform people happy with this? I don't know embedded well enough to

Re: ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread James Bottomley
On Tue, 2007-07-10 at 11:24 -0700, Andrew Morton wrote: > > > ata-ahci-alpm-store-interrupt-value.patch > > > ata-ahci-alpm-expose-power-management-policy-option-to-users.patch > > > ata-ahci-alpm-enable-link-power-management-for-ata-drivers.patch > > > ata-ahci-alpm-enable-aggressive-link-power-ma

Re: [PATCH re-resend] fix race in AF_UNIX garbage collector

2007-07-10 Thread Miklos Szeredi
> > On Tue, 10 Jul 2007 11:50:30 +0200 Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > > > > Can you please add this to -mm. Sometimes that has wonderful effect > > > on the willingness of people to look at a patch. > > > > sure ;) > > Andrew please don't, it's in my "to review" pile. Yeah, and

Re: [PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2

2007-07-10 Thread Kok, Auke
[EMAIL PROTECTED] wrote: This patch adds support for the Intel(R) 82598 based PCI Express 10GbE adapters. Please find the full driver as a patch to latest linus-2.6 tree here: git-pull git://lost.foo-projects.org/~aveerani/git/linux-2.6 ixgbe Andrew, I rebased this with the new driver cod

[PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

2007-07-10 Thread Jean Tourrilhes
Hi, SoftMAC output the channel twice in the scan output. It should display frequency and channel, but only once for each. Cell 02 - Address: A2:00:04:XX:XX:XX ESSID:"TheESSID"

Re: iproute2 showing wrong number of bytes on 64bit architectures.

2007-07-10 Thread David Miller
From: "Chris Friesen" <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 12:17:12 -0600 > It's rather ironic that the "new-and-improved" way of doing things is > subject to rollover while the "old" way is not. Text is always more flexible, but is hard to extend. We can trivially add "u64" statistics to

Re: iproute2 showing wrong number of bytes on 64bit architectures.

2007-07-10 Thread Chris Friesen
David Miller wrote: It used unsigned long ages ago, and ifconfig gets the bits exported from /proc/net/dev output whereas we have to used fixed data types in whatever we use over netlink so u32 was choosen. It's rather ironic that the "new-and-improved" way of doing things is subject to rollo

Re: ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 13:42:16 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > > (just to provide my indicator of status) Thanks. > > libata-add-irq_flags-to-struct-pata_platform_info-fix.patch > > are other pata_platform people happy with this? I don't know embedded > well enough to know if ad

Re: [PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2

2007-07-10 Thread Jeff Garzik
Veeraiyan, Ayyappan wrote: On 7/10/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: [EMAIL PROTECTED] wrote: Doing both tends to signal that the author hasn't bothered to measure the differences between various approaches, and pick a clear winner. I did pick NAPI in our previous submission based o

Re: [PATCH] ps3: gigabit ethernet driver for PS3, take3

2007-07-10 Thread Jeff Garzik
Masakazu Mokuno wrote: Hi, This is the third submission of the network driver for PS3. The differences from the previous one are: - renamed source file names so that their prefix can match with the module name - added [EMAIL PROTECTED] line for MAINTAINER file - changed some in copyr

[PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-10 Thread Remi Denis-Courmont
ICMPv6 Router Advertisements may now contain informations that is mostly of interest to userland. This currently mostly consists of recursive DNS server addresses (though one should expect other stuff to come). This patch adds a setsockopt to ICMPv6 sockets to only deliver Router Advertisements if

RE: [PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2

2007-07-10 Thread Veeraiyan, Ayyappan
On 7/10/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > Doing both tends to signal that the author hasn't bothered to measure > the differences between various approaches, and pick a clear winner. > I did pick NAPI in our previous submission based on various tests. But

Re: iproute2 showing wrong number of bytes on 64bit architectures.

2007-07-10 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 08:56:40 -0700 > Looks like net_device_stats should have always used u32? It used unsigned long ages ago, and ifconfig gets the bits exported from /proc/net/dev output whereas we have to used fixed data types in whatever we use ov

Re: [PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2

2007-07-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: 7. NAPI mode uses sigle Rx queue and so fake netdev usage is removed. 8. Non-NAPI mode is added. Honestly I'm not sure about drivers that have both NAPI and non-NAPI paths. Several existing drivers do this, and in almost every case, I tend to feel the driver would ben

Re: [PATCH re-resend] fix race in AF_UNIX garbage collector

2007-07-10 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 03:04:43 -0700 > On Tue, 10 Jul 2007 11:50:30 +0200 Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > > Can you please add this to -mm. Sometimes that has wonderful effect > > on the willingness of people to look at a patch. > > sure ;)

Re: [PATCH re-resend] fix race in AF_UNIX garbage collector

2007-07-10 Thread David Miller
From: Miklos Szeredi <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 11:50:30 +0200 > Can you please add this to -mm. Sometimes that has wonderful effect > on the willingness of people to look at a patch. No, I will merge this into my networking tree when I get the chance to review your patch and it

No network on Asus P5B (r8169)

2007-07-10 Thread Clemens Brunner
Hi! I just found out that everything is working just fine with a 64-bit Linux kernel. I hope this helps you hunt down the error in the 32-bit version. https://bugzilla.novell.com/show_bug.cgi?id=288406 Clemens - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

[PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2

2007-07-10 Thread Ayyappan . Veeraiyan
This patch adds support for the Intel(R) 82598 based PCI Express 10GbE adapters. Please find the full driver as a patch to latest linus-2.6 tree here: git-pull git://lost.foo-projects.org/~aveerani/git/linux-2.6 ixgbe Changes from the last submission... 1. Suspend, resume support is added 2.

ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Jeff Garzik
(just to provide my indicator of status) Andrew Morton wrote: libata-config_pm=n-compile-fix.patch that's for a branch that you don't get via libata-dev#ALL, #mv-ahci-pata. pata_acpi-restore-driver.patch see Alan's comments. I've been ignoring pata_acpi for a while, because IMO it alwa

Re: [PATCH] ethtool: new ID to decode the registers of the 8101E (realtek)

2007-07-10 Thread Jeff Garzik
Francois Romieu wrote: Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Rolf Eike Beer <[EMAIL PROTECTED]> --- realtek.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [E

Re: [PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-07-10 Thread Jeff Garzik
Vitaly Bordug wrote: device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a release() function, it i

Re: [PATCH 2/2] eHEA: Receive SKB Aggregation

2007-07-10 Thread Jeff Garzik
Jan-Bernd Themann wrote: This patch enables the receive side processing to aggregate TCP packets within the HEA device driver. It analyses the packets already received after an interrupt arrived and forwards these as chains of SKBs for the same TCP connection with modified header field. We have s

Re: [PATCH 1/2] eHEA: Capability flag for DLPAR support

2007-07-10 Thread Jeff Garzik
Jan-Bernd Themann wrote: This patch introduces a capability flag that is used by the DLPAR userspace tool to check which DLPAR features are supported by the eHEA driver. Missing goto has been included. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> applied - To unsubscribe from this l

Re: [2.6 patch] the scheduled sk98lin removal

2007-07-10 Thread Stephen Hemminger
On Tue, 10 Jul 2007 12:44:35 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Adrian Bunk wrote: > > This patch contains the scheduled removal of the sk98lin driver. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Stephen -- ACK? Yes. Existing driver is dead, if there are any ancient

Re: [patch 2/7] Blackfin: on-chip ethernet MAC controller driver

2007-07-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: "Wu, Bryan" <[EMAIL PROTECTED]> This patch implements the driver necessary use the Analog Devices Blackfin processor's on-chip ethernet MAC controller. Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[E

[RFT] via-velocity: use standard VLAN infrastructure

2007-07-10 Thread Stephen Hemminger
The via-velocity is using a non-standard VLAN acceleration interface. This patch converts it to use standard API. Compile tested only. The module parameter method of VLAN configuration is removed, use vconfig instead. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/via-velo

Re: [linux-usb-devel] [PATCH]: cdc-subset to support new vendor/product ID

2007-07-10 Thread Jeff Garzik
jing xiang wrote: Hi, This patch is for cdc subset to support Mavell vendor/product ID. Jing Xiang Signed-off-by: Jing Xiang<[EMAIL PROTECTED]> diff -uNpr linux-2.6.21.5/driver/usb/net/cdc_subset.c linux-2.6.21.5.t/driver/usb/net/cdc_subset.c --- linux-2.6.21.5/driver/usb/net/cdc_subset.c 20

Re: [2,6 patch] sunhme.c:quattro_pci_find() must be __devinit

2007-07-10 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes the following section mismatch: <-- snip --> ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x272f8b): Section mismatch: reference to .init.text:quattro_pci_find (between 'happy_meal_pci_probe' and 'happy_meal_pci_remove') ... <-- snip --> Si

Re: [2.6 patch] the scheduled sk98lin removal

2007-07-10 Thread Jeff Garzik
Adrian Bunk wrote: This patch contains the scheduled removal of the sk98lin driver. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Stephen -- ACK? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://

Re: [PATCH] bonding / ipv6: no addrconf for slaves separately from master

2007-07-10 Thread Jeff Garzik
Jay Vosburgh wrote: At present, when a device is enslaved to bonding, if ipv6 is active then addrconf will be initated on the slave (because it is closed then opened during the enslavement processing). This causes DAD and RS packets to be sent from the slave. These packets in turn can c

Re: [PATCH] atl1: remove write-only var in tx handler

2007-07-10 Thread Jeff Garzik
Alexey Dobriyan wrote: Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mor

Re: macmace: use "unsigned long flags;"

2007-07-10 Thread Jeff Garzik
Alexey Dobriyan wrote: Code will do local_irq_save() on it. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- drivers/net/macmace.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/macmace.c +++ b/drivers/net/macmace.c @@ -577,7 +577,7 @@ static irqreturn_t mace

Re: [PATCH] Cleanup usbnet_probe() return value handling

2007-07-10 Thread Jeff Garzik
Peter Korsgaard wrote: "David" == David Brownell <[EMAIL PROTECTED]> writes: Hi, David> I'd rather see the later test updated to match this one. David> (Good catch!) David> The return convention is "negative means error". There's David> code in USB which has multiple nonnegative success

Re: [PATCH 2.6.22-rc7] 8139cp: dev->tx_timeout

2007-07-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: (Resending the patch against 2.6.22-rc7) This patch implements the missing dev->tx_timeout for 8139cp driver Signed-off-by: Mika Lansirinne <[EMAIL PROTECTED]> ACK but still fails to apply - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [PATCH] netxen: deinline and sparse fix

2007-07-10 Thread Jeff Garzik
Stephen Hemminger wrote: Get rid of dubious casts to (void *) which causes a sparse warning. And move largeish function from inline to the one file that uses the code, the compiler can then decide to inline it. Compile tested only. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied

Re: [PATCH] [1/2] phylib: cleanup marvell.c a bit

2007-07-10 Thread Jeff Garzik
Olof Johansson wrote: Simplify the marvell driver init a bit: Make the supported devices an array instead of explicitly registering each structure. This makes it considerably easier to add new devices down the road. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied 1-2 - To unsubscr

Re: [PATCH] AX88796 network driver

2007-07-10 Thread Jeff Garzik
Ben Dooks wrote: Support for the Asix AX88796 network controller, an NE2000 compatible 10/100 ethernet device with internal PHY. The driver supports PHY settings via either ioctl() or the ethtool driver ops. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> applied - To unsubscribe from this l

Re: [PATCH] 7990 : Various fixes and cleanups

2007-07-10 Thread Jeff Garzik
Philippe De Muyter wrote: This patch - avoids 7990 blocking when no tx buffer is available, [...] diff -r 6c0a10cc415a drivers/net/7990.c --- a/drivers/net/7990.cThu Jul 5 16:10:16 2007 -0700 +++ b/drivers/net/7990.cFri Jul 6 11:27:20 2007 +0200 [...] @@ -541,9 +546,6 @@ int

Re: [IOC3] Switch to pci refcounting safe APIs

2007-07-10 Thread Jeff Garzik
Ralf Baechle wrote: From: Alan Cox <[EMAIL PROTECTED]> Convert the IOC3 driver to use ref counting pci interfaces so that we can obsolete the (usually unsafe) pci_find_{slot/device} interfaces and avoid future authors writing hotplug-unsafe device drivers. Signed-off-by: Alan Cox <[EMAIL PROT

Re: [PATCH] QE Ethernet driver writes to wrong register to mask interrupts

2007-07-10 Thread Jeff Garzik
Timur Tabi wrote: The QE Ethernet driver was writing to the wrong register to mask interrupts. In ucc_geth_stop(), it was clearing UCCE instead of UCCM. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) applied

Re: [PATCH] e100: Fix Tyan motherboard e100 not receiving IPMI commands

2007-07-10 Thread Jeff Garzik
Auke Kok wrote: From: David Graham <[EMAIL PROTECTED]> The 82550 & 51 parts have an extended configuration block that includes a bit "GMRC", required to enable the expected TCO behavior, in config byte offset 22d. The config block sent by the failing driver does include the extension area, but

Re: [2.6 patch] rrunner.c:rr_init() must be __devinit

2007-07-10 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes the following section mismatch: <-- snip --> ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x26e3f2): Section mismatch: reference to .init.text:rr_init (between 'rr_init_one' and 'rr_remove_one') ... <-- snip --> Signed-off-by: Adrian Bunk <[

Re: [2.6 patch] sis900_mii_probe() must be __devinit

2007-07-10 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes the following section mismatch: <-- snip --> ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x298170): Section mismatch: reference to .init.text:sis900_mii_probe (between 'sis900_probe' and 'sis900_default_phy') ... <-- snip --> Signed-off-by:

Re: [2.6 patch] tokenring/3c359.c:xl_init() must be __devinit

2007-07-10 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes the following section mismatch: <-- snip --> ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x361ef1): Section mismatch: reference to .init.text:xl_init (between 'xl_probe' and 'xl_hw_reset') ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL

Re: [PATCH] Fix typo in drivers/net/s2io.c

2007-07-10 Thread Jeff Garzik
Rolf Eike Beer wrote: Introduced in d796fdb708fc5b10112934cba43e832c36ce4923. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- commit 58056c2424917e90b86ca11c2c5d3fd35313d7b6 tree 854d63a14f96416aad64d12ea71cb331acfcc7db parent 87a2df362631d53fdc169a5d76969365aff69c10 author Rolf Eike Beer

Re: [PATCH] spidernet: improve interrupt handling

2007-07-10 Thread Jeff Garzik
Linas Vepstas wrote: From: Ishizaki Kou <[EMAIL PROTECTED]> We intend this patch to improve spidernet interrupt handling to be more strict. We had following problem and this patch solves it. -when CONFIG_DEBUG_SHIRQ=y, request_irq() calls handler(). -when spider_net_open() is called, it call

Re: [PATCH] PCMCIA: add Socket Ethernet card into pcnet_cs

2007-07-10 Thread Jeff Garzik
Marcin Juszkiewicz wrote: From: Marcin Juszkiewicz <[EMAIL PROTECTED]> One card submitted by Ångström user. Signed-off-by: Marcin Juszkiewicz <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More ma

Re: [patch 3/7] atari_pamsnet.c: old declaration ritchie style fix

2007-07-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Yoann Padioleau <[EMAIL PROTECTED]> Use consistent function declaration style. Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/atari_pamsnet.c | 62 -- 1 files changed, 22 insertions(+), 40 deletions(-) appli

Re: Does the Netxen driver work?

2007-07-10 Thread Chuck Ebbert
On 07/10/2007 12:33 AM, Dhananjay Phadke wrote: > The MSI error wasn't fatal, so it was suppressed in recent fixes for > 2.6.22-rc7. The driver in 2.6.21 had many bugs, but I ain't sure if > recent fixes are going to be pulled in Fedora kernel. > Fedora 6/7 are moving to kernel 2.6.22 very soon.

Re: [PATCH 01/12] sky2: restore workarounds for lost interrupts

2007-07-10 Thread Jeff Garzik
Stephen Hemminger wrote: This patch restores a couple of workarounds from 2.6.16: * restart transmit moderation timer in case it expires during IRQ routine * default to having 10 HZ watchdog timer. At this point it more important not to hang than to worry about the power cost. Signed-off-by: S

[IOC3] Switch to pci refcounting safe APIs

2007-07-10 Thread Ralf Baechle
From: Alan Cox <[EMAIL PROTECTED]> Convert the IOC3 driver to use ref counting pci interfaces so that we can obsolete the (usually unsafe) pci_find_{slot/device} interfaces and avoid future authors writing hotplug-unsafe device drivers. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Build fixes:

Fw: iproute2 showing wrong number of bytes on 64bit architectures.

2007-07-10 Thread Stephen Hemminger
Looks like net_device_stats should have always used u32? Too late to change it now. Begin forwarded message: Date: Tue, 10 Jul 2007 13:58:51 +0200 From: Andreas Henriksson <[EMAIL PROTECTED]> To: netdev@vger.kernel.org Cc: [EMAIL PROTECTED] Subject: iproute2 showing wrong number of bytes on 64bit

[PATCH] e100: Fix Tyan motherboard e100 not receiving IPMI commands

2007-07-10 Thread Auke Kok
From: David Graham <[EMAIL PROTECTED]> The 82550 & 51 parts have an extended configuration block that includes a bit "GMRC", required to enable the expected TCO behavior, in config byte offset 22d. The config block sent by the failing driver does include the extension area, but this bit is not in

Re: [PATCH 2.6] WE : Fix get 32 char ESSID

2007-07-10 Thread John W. Linville
On Mon, Jul 09, 2007 at 03:13:22PM -0700, Jean Tourrilhes wrote: > A little bug was introduced a few months ago that prevent > reading ESSID with 32 character. Philippe Teuwen was the first one to > report that, followed by the MadWifi team : > http://madwifi.org/ticket/930 >

Re: + gen_estimator-fix-locking-and-timer-related-bugs.patch added to -mm tree

2007-07-10 Thread Jarek Poplawski
On Tue, Jul 10, 2007 at 03:10:34PM +0200, Jarek Poplawski wrote: > On Tue, Jul 10, 2007 at 02:20:12PM +0200, Patrick McHardy wrote: > > Jarek Poplawski wrote: > > > On Tue, Jul 10, 2007 at 01:09:07PM +0300, Ranko Zivojnovic wrote: > > > > > >>However I decided not to use _rcu based iteration neith

iproute2 showing wrong number of bytes on 64bit architectures.

2007-07-10 Thread Andreas Henriksson
Hello! While investigating the problems reported in Debian bug #199054 (http://bugs.debian.org/199054), stating that the RX/TX bytes differ between ifconfig and ip(route2) I came across this: include/linux/if_link.h (used in kernel and iproute2 source): /* The struct should be in sync with struct

  1   2   >