Just checked this in locally...
The hooks -self_test_count() and -get_stats_count() are now unused
in the main tree.
(based off of latest davem/net-2.6.24.git)
drivers/net/3c59x.c | 11 +++-
drivers/net/8139cp.c| 11 +++-
drivers/net/8139too.c
Hi Jeff.
You wrote:
The hooks -self_test_count() and -get_stats_count() are now unused
in the main tree.
So I'm suprised to see more lines added than deleted:
35 files changed, 346 insertions(+), 246 deletions(-)
Puzzled - may need a bit more coffee (morning here)..
Sam
-
To
On Sep 15, 2007, at 13:24:46, Andreas Dilger wrote:
On Sep 15, 2007 16:29 +0400, Evgeniy Polyakov wrote:
Yes, block device itself is not able to scale well, but it is the
place for redundancy, since filesystem will just fail if
underlying device does not work correctly and FS actually does
Sam Ravnborg wrote:
Hi Jeff.
You wrote:
The hooks -self_test_count() and -get_stats_count() are now unused
in the main tree.
So I'm suprised to see more lines added than deleted:
35 files changed, 346 insertions(+), 246 deletions(-)
Puzzled - may need a bit more coffee (morning here)..
Michael Wu wrote:
On Saturday 15 September 2007 20:56, Jeff Garzik wrote:
+ if (flags IFF_PROMISC)
+ dev-flags |= IEEE80211_HW_RX_INCLUDES_FCS;
+ else
+ dev-flags = ~IEEE80211_HW_RX_INCLUDES_FCS;
why does promisc dictate inclusion of FCS?
Because
Steve Wise wrote:
RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery.
Calling arp_send() to initiate neighbour discovery (ND) doesn't do the
full ND protocol. Namely, it doesn't handle retransmitting the arp
request if it is dropped. The function neigh_event_send() does all this.
[EMAIL PROTECTED] wrote:
The patch titled
revert 8139too: clean up I/O remapping
has been removed from the -mm tree. Its filename was
revert-8139too-clean-up-i-o-remapping.patch
This patch was dropped because it was merged into mainline or a subsystem tree
Roland Dreier wrote:
With 2.6.24 probably opening in the not-too-distant future, it's
probably a good time to review what my plans are for when the merge
window opens.
Core:
- Sean's QoS changes. These look fine at first glance, and I just
plan to understand the backwards compatibility
On Sat, Sep 15, 2007 at 11:24:46AM -0600, Andreas Dilger ([EMAIL PROTECTED])
wrote:
When Chris Mason announced btrfs, I found that quite a few new ideas
are already implemented there, so I postponed project (although
direction of the developement of the btrfs seems to move to the zfs side
I wanted to get rid of the extrenous cpu arguement and ended moving this
to the header files since it looks common enough an operation that could
be used elsewhere.
It is a trivial change - i could resend with leaving it in dev.c and
just getting rid of the cpu arguement.
cheers,
jamal
[NET]:
While trying to port my batching changes to net-2.6.24 from this morning
i realized this is something i had wanted to probe people on
Challenge:
For N Cpus, with full throttle traffic on all N CPUs, funneling traffic
to the same ethernet device, the devices queue lock is contended by all
N
From: Ed Swierk [EMAIL PROTECTED]
Date: Wed, 12 Sep 2007 09:54:35 -0700
On 9/11/07, Herbert Xu [EMAIL PROTECTED] wrote:
Please make it 65535 without an Ethernet header and 65521
with an Ethernet header.
Here is a revised patch that allows MTUs up to 65535 for tap
interfaces and up to
Hello.
With latest git tree, bcm43xx driver does not work.
By bisect, I've found the commit 4cf92a3c is the first bad commit.
[PATCH] softmac: Fix ESSID problem
Victor Porton reported that the SoftMAC layer had random problem when
setting the ESSID :
From: jamal [EMAIL PROTECTED]
Date: Sun, 16 Sep 2007 11:48:45 -0400
I wanted to get rid of the extrenous cpu arguement and ended moving this
to the header files since it looks common enough an operation that could
be used elsewhere.
It is a trivial change - i could resend with leaving it in
From: jamal [EMAIL PROTECTED]
Date: Sun, 16 Sep 2007 12:14:34 -0400
Changes:
I made changes to the code path as defined in the patch included to
and noticed a slight increase (2-3%) in performance with both e1000 and
tg3; which was a relief because i thought the spinlock_irq (which is
James Chapman wrote:
Kok, Auke wrote:
James Chapman wrote:
Kok, Auke wrote:
rx_long_byte_count: 34124849453
Are these long frames expected in your network? What is the MTU of
the transmitting clients? Perhaps this might explain why reads work
(because data is coming from the Linux
On Sun, 2007-16-09 at 12:28 -0700, David Miller wrote:
The only reason the cpu argument is superfluous is because
we don't provide a way to pass it on down to netif_tx_lock().
So instead netif_tx_lock() recomputes that value in this case which is
extra unnecessary work.
I would instead
On Sun, 2007-16-09 at 12:31 -0700, David Miller wrote:
From: jamal [EMAIL PROTECTED]
Date: Sun, 16 Sep 2007 12:14:34 -0400
So - what side effects do people see in doing this? If none, i will
clean it up and submit.
I tried this 4 years ago, it doesn't work. :-)
;-
[good reasons
On Sun, 2007-16-09 at 16:41 -0400, jamal wrote:
indeed.
Ok, maybe i am thinking too hard with that patch, so help me out:-
Ok, that was probably too much of an explanation. What i should say is
if i grabbed the lock explicitly without disabling irqs it wont be much
different than what is done
On Sun, 2007-16-09 at 16:28 -0400, jamal wrote:
sounds much better - will resend after a simple test.
Ok, heres the revised version
cheers,
jamal
[NET]: migrate HARD_TX_LOCK to header file
HARD_TX_LOCK micro is a nice aggregation that could be used
in other spots. move it to netdevice.h
On Sun, 2007-16-09 at 16:52 -0400, jamal wrote:
What i should say is
if i grabbed the lock explicitly without disabling irqs it wont be much
different than what is done today and should always work.
No?
And to be more explicit, heres a patch using the macros from previous
patch. So far
erp, changes in the net-2.6.24 tree breaks this.
drivers/net/tehuti.c: In function 'bdx_isr_napi':
drivers/net/tehuti.c:268: error: too few arguments to function
'netif_rx_schedule_prep'
drivers/net/tehuti.c:269: error: too few arguments to function
'__netif_rx_schedule'
drivers/net/tehuti.c:
On Sat, 2007-09-15 at 21:27 +0100, Chris Rankin wrote:
--- Dan Williams [EMAIL PROTECTED] wrote:
On Wed, 2007-09-12 at 19:23 +0100, Chris Rankin wrote:
Hmm, apparently not. The light on the card goes out though, so could this
just be a lack of
driver
support?
Likely, yes.
From: jamal [EMAIL PROTECTED]
Date: Sun, 16 Sep 2007 16:57:14 -0400
On Sun, 2007-16-09 at 16:28 -0400, jamal wrote:
sounds much better - will resend after a simple test.
Ok, heres the revised version
Applied, thanks Jamal.
-
To unsubscribe from this list: send the line unsubscribe
From: Jiri Kosina [EMAIL PROTECTED]
Date: Thu, 13 Sep 2007 00:56:00 +0200 (CEST)
From: Jiri Kosina [EMAIL PROTECTED]
[PATCH] IPV6: fix source address selection
The commit 95c385 broke proper source address selection for cases in which
there is a address which is makred 'deprecated'. The
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 13 Sep 2007 09:59:05 -0600
This replaces the void * parameter with a struct net_device * which
is what is actually required.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
Applied to net-2.6.24, thanks Eric.
-
To unsubscribe from
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 13 Sep 2007 13:12:08 -0600
The final blocker to having multiple useful instances of network
namespaces is the loopback device. We recognize the network namespace
of incoming packets by looking at dev-nd_net. Which means for
packets to
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Thu, 13 Sep 2007 15:34:35 -0400
Thanks to Sridhar Samudral and Paul McKenney for all the help and comments.
I think this is a final version, unless someone else can spot more problems.
I've ran this under heavy load and it the patches behaves well.
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Thu, 13 Sep 2007 17:03:45 -0400
The sctp_[rw]mem definitions should really be in protocol.c
since that is where they are initialized. This also allows
one to build a kernel without sysctl support.
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED]
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 31 Aug 2007 17:08:49 +0800
[PPP] pppoe: Fix skb_unshare_check call position
The skb_unshare_check call needs to be made before pskb_may_pull,
not after.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
Patch applied, thanks Herbert.
-
To
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 31 Aug 2007 17:09:04 +0800
[PPP] pppoe: Fix data clobbering in __pppoe_xmit and return value
The function __pppoe_xmit modifies the skb data and therefore it needs
to copy and skb data if it's cloned.
In fact, it currently allocates a new skb
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 31 Aug 2007 17:09:12 +0800
[PPP] pppoe: Fill in header directly in __pppoe_xmit
This patch removes the hdr variable (which is copied into the skb)
and instead sets the header directly in the skb.
It also uses __skb_push instead of skb_push
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 31 Aug 2007 17:09:14 +0800
[BRIDGE]: Kill clone argument to br_flood_*
The clone argument is only used by one caller and that caller can clone
the packet itself. This patch moves the clone call into the caller and
kills the clone argument.
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 31 Aug 2007 17:09:15 +0800
[NET] skbuff: Add skb_cow_head
This patch adds an optimised version of skb_cow that avoids the copy if
the header can be modified even if the rest of the payload is cloned.
This can be used in encapsulating paths
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 31 Aug 2007 17:09:17 +0800
[PPP] generic: Fix receive path data clobbering non-linear handling
This patch adds missing pskb_may_pull calls to deal with non-linear
packets that may arrive from pppoe or pppol2tp.
It also copies cloned packets
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 31 Aug 2007 20:09:30 +0800
Hi Dave:
[NETLINK]: Avoid pointer in netlink_run_queue
I was looking at Patrick's fix to inet_diag and it occured
to me that we're using a pointer argument to return values
unnecessarily in netlink_run_queue.
From: Herbert Xu [EMAIL PROTECTED]
Date: Sat, 1 Sep 2007 09:13:33 +0800
Hi Dave:
[SKBUFF]: Fix up csum_start when head room changes
Thanks for noticing the bug where csum_start is not updated
when the head room changes.
This patch fixes that. It also moves the csum/ip_summed
copying
From: Denis Cheng [EMAIL PROTECTED]
Date: Sun, 2 Sep 2007 03:45:59 +0800
if the table is always fixed size with MAX_LINKS entries, why not use a
statically
allocated table straightforwardly?
Signed-off-by: Denis Cheng [EMAIL PROTECTED]
I made the explicit decision to dynamically allocate
From: Denis Cheng [EMAIL PROTECTED]
Date: Sun, 2 Sep 2007 18:30:17 +0800
Signed-off-by: Denis Cheng [EMAIL PROTECTED]
You already submitted the net/ipv4/af_inet.c case
seperately, so I had to remove it from this patch for
it to apply properly.
Please keep your patches straight to avoid
David Miller [EMAIL PROTECTED] writes:
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Thu, 13 Esp 2007 13:12:08 -0600
The final blocker to having multiple useful instances of network
namespaces is the loopback device. We recognize the network namespace
of incoming packets by looking at
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 22:07:14 +0200
Could we just make it so dev-init is not allowed to fail? Then it
can be a void function and the nasty unwind code can go?
Someone (not me :-) need to do an audit to find all current
users of this function and
From: David Stevens [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 15:25:32 -0600
Background: RFC 4293 deprecates existing individual, named ICMP
type counters to be replaced with the ICMPMsgStatsTable. This table
includes entries for both IPv4 and IPv6, and requires counting of all
ICMP types,
David Miller [EMAIL PROTECTED] writes:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 22:07:14 +0200
Could we just make it so dev-init is not allowed to fail? Then it
can be a void function and the nasty unwind code can go?
Someone (not me :-) need to do an audit to find
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Sun, 16 Sep 2007 18:06:00 -0600
I did that audit when I replied to Stephen the first time and I just
redid it to verify myself. We are calling functions that can fail
from the init function (kmalloc in the most common). So the
init function
On Sun, 2007-16-09 at 16:17 -0700, David Miller wrote:
The only major complaint I have about this patch series is that
the IPoIB part should just be one big changeset.
Dave, you do realize that i have been investing my time working on
batching as well, right?
cheers,
jamal
-
To
From: jamal [EMAIL PROTECTED]
Date: Sun, 16 Sep 2007 20:29:18 -0400
On Sun, 2007-16-09 at 16:17 -0700, David Miller wrote:
The only major complaint I have about this patch series is that
the IPoIB part should just be one big changeset.
Dave, you do realize that i have been investing my
On Sun, 2007-16-09 at 18:02 -0700, David Miller wrote:
I do.
And I'm reviewing and applying several hundred patches a day.
What's the point? :-)
Reading the commentary made me think you were about to swallow that with
one more change by the time i wake up;-
I still think this work -
From: jamal [EMAIL PROTECTED]
Date: Sun, 16 Sep 2007 22:14:21 -0400
I still think this work - despite my vested interest - needs more
scrutiny from a performance perspective.
Absolutely.
There are tertiary issues I'm personally interested in, for example
how well this stuff works when we
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 14:44:52 -0400
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED]
Applied to net-2.6.24
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 14:44:53 -0400
This patch implements the internals operations of the AUTH, such as
key computation and storage. It also adds necessary variables to
the SCTP data structures.
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED]
Applied
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 14:44:54 -0400
The patch initializes AUTH related members of the generic SCTP
structures and provides a way to enable/disable auth extension.
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED]
Applied to net-2.6.24
-
To unsubscribe
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 14:44:55 -0400
Implement processing for the CHUNKS, RANDOM, and HMAC parameters and
deal with how this parameters are effected by association restarts.
In particular, during unexpeted INIT processing, we need to reply with
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 14:44:56 -0400
SCTP-AUTH, Section 6.2:
Endpoints MUST send all requested chunks authenticated where this has
been requested by the peer. The other chunks MAY be sent
authenticated or not. If endpoint pair shared keys
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 14:44:57 -0400
This patch implements the receive path needed to process authenticated
chunks. Add ability to process the AUTH chunk and handle edge cases
for authenticated COOKIE-ECHO as well.
Signed-off-by: Vlad Yasevich [EMAIL
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 14:44:58 -0400
Add SCTP-AUTH API. The API implemented here was
agreed to between implementors at the 9th SCTP Interop.
It will be documented in the next revision of the
SCTP socket API spec.
Signed-off-by: Vlad Yasevich [EMAIL
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 14:44:59 -0400
ADD-IP spec requires AUTH. It is, in fact, dangerous without AUTH.
So, disable ADD-IP functionality if the peer claims to support
ADD-IP, but not AUTH.
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED]
Applied to
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Fri, 14 Sep 2007 15:14:50 -0400
[.. forgot to refresh the patch, the other version has compile problems ..]
ADD-IP spec requires AUTH. It is, in fact, dangerous without AUTH.
So, disable ADD-IP functionality if the peer claims to support
ADD-IP,
On Sat 15 Sep 2007 22:57, Bryan Wu pondered:
- add MDIO functions and register mdio bus
- add phy abstraction layer (PAL) functions and use PAL API
- test on STAMP537 board
Today, the Kconfig for the Blackfin just includes:
config BFIN_MAC
tristate Blackfin 536/537 on-chip mac
On Sun, 2007-16-09 at 19:25 -0700, David Miller wrote:
There are tertiary issues I'm personally interested in, for example
how well this stuff works when we enable software GSO on a non-TSO
capable card.
In such a case the GSO segment should be split right before we hit the
driver and then
From: jamal [EMAIL PROTECTED]
Date: Sun, 16 Sep 2007 23:01:43 -0400
I think GSO is still useful on top of this.
In my patches anything with gso gets put into the batch list and shot
down the driver. Ive never considered checking whether the nic is TSO
capable, that may be something worth
On Sun, 2007-09-16 at 22:51 -0400, Robin Getz wrote:
On Sat 15 Sep 2007 22:57, Bryan Wu pondered:
- add MDIO functions and register mdio bus
- add phy abstraction layer (PAL) functions and use PAL API
- test on STAMP537 board
Today, the Kconfig for the Blackfin just includes:
Most if not all of my 2 week backlog of patches is in the net-2.6.24
and net-2.6 tree now. And any relevant -stable fixes will be
submitted in the next day or two.
Tomorrow (Monday) I want to rebase the net-2.6.24 tree one more time
to deal with all of the conflicts which exist between
Since we are adding requirement for the PHYLIB for this driver, there should be
a select for that
Cc: Robin Getz [EMAIL PROTECTED]
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
drivers/net/Kconfig |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig
Hi Evgeniy,
Evgeniy Polyakov [EMAIL PROTECTED] wrote on 09/14/2007 05:45:19 PM:
+ if (skb-next) {
+ int count = 0;
+
+ do {
+struct sk_buff *nskb = skb-next;
+
+skb-next = nskb-next;
+__skb_queue_tail(dev-skb_blist, nskb);
Hi Evgeniy,
Evgeniy Polyakov [EMAIL PROTECTED] wrote on 09/14/2007 06:16:38 PM:
+ if (dev-features NETIF_F_BATCH_SKBS) {
+ /* Driver supports batching skb */
+ dev-skb_blist = kmalloc(sizeof *dev-skb_blist, GFP_KERNEL);
+ if (dev-skb_blist)
+
Hi Evgeniy,
Evgeniy Polyakov [EMAIL PROTECTED] wrote on 09/14/2007 06:17:14 PM:
if (unlikely(skb-len = 0)) {
dev_kfree_skb_any(skb);
- return NETDEV_TX_OK;
+ return NETDEV_TX_DROPPED;
}
This changes could actually go as own patch, although not sure it is
Hi Dave,
David Miller [EMAIL PROTECTED] wrote on 09/17/2007 04:47:48 AM:
The only major complaint I have about this patch series is that
the IPoIB part should just be one big changeset. Otherwise the
tree is not bisectable, for example the initial ipoib header file
change breaks the build.
Hi Randy,
Randy Dunlap [EMAIL PROTECTED] wrote on 09/15/2007 12:07:09 AM:
+ To fix this problem, error cases where driver xmit gets called with
a
+ skb must code as follows:
+ 1. If driver xmit cannot get tx lock, return NETDEV_TX_LOCKED
+ as usual. This allows qdisc to
David Miller wrote:
We've touched so much in net-2.6.24 that we really should be auditing
the thing and fixing any bugs that have been added. If you're bored
and looking for something to do, pick an odd NAPI driver and audit it
in the net-2.6.24 tree.
You could try that weird post patches on
Please remove me from the CC list.
I get this via netdev, and not having said a single thing in the thread,
I don't feel the need to be CC'd on every email.
The CC list is pretty massive as it is, anyway.
Jeff
-
To unsubscribe from this list: send the line unsubscribe netdev in
Dave,
Thanks. That rev2 was for v6-only; I didn't see anythng about the
v4 patch (below, in case it fell through the cracks).
+-DLS
- Forwarded by David Stevens/Beaverton/IBM on 09/16/2007 09:02 PM
-
David
[Removing Jeff as requested from thread :) ]
Hi Dave,
David Miller [EMAIL PROTECTED] wrote on 09/17/2007 07:55:02 AM:
From: jamal [EMAIL PROTECTED]
Date: Sun, 16 Sep 2007 22:14:21 -0400
I still think this work - despite my vested interest - needs more
scrutiny from a performance
72 matches
Mail list logo
