bind and O_NONBLOCK

2007-09-21 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Some time back Alan asked about adding O_NONBLOCK support to bind in the POSIX spec. I brought this up and the following text will be in the next revision of the POSIX spec: === If the socket address cannot be assigned

Re: [PATCH RESEND] 2.6.22.6 networking [ipv4]: fix wrong destination when reply packetes

2007-09-21 Thread lepton
Now icmp_reply is only called by icmp_echo and icmp_timestamp ip_send_reply is only called by tcp_v4_send_reset and tcp_v4_send_ack I think in all situations the ip_hdr(skb)-saddr is set and should be the destination of reply packets. If using rt-rt_src as destination is correct in some

Re: Pull request for 'r8169-for-jeff-20070919' branch

2007-09-21 Thread Francois Romieu
Chuck Ebbert [EMAIL PROTECTED] : [...] Looking again, it may not be r8169's fault, but it is involved. It Sort of: [...] * Hung when moving data off a physical disk in an LVM. Twice during night. * Hung when adding a disk to a software Raid. Once. used to hang and could be restarted by pulling

Re: Please pull 'iwlwifi' branch of wireless-2.6

2007-09-21 Thread Christoph Hellwig
On Fri, Sep 21, 2007 at 09:20:30AM +0800, Zhu Yi wrote: The depends on m for CONFIG_IWL4965 and CONFIG_IWL3945 needs to go, we don't put drivers int that need to be modular. Since we splited the code base for 3945 and 4965 by a simple fork of file iwl-base.c, some non-static functions

change the way e1000 is handling short VLAN frames

2007-09-21 Thread Emil Micek
Hello list, I'd like to change behaviour of e1000 module when transmiting short ethernet frames (shorter then 64 bytes) trough VLAN interface. Current e1000 (according to our observations) first appends 4 bytes of VLAN tag and then pads the frame to 64 bytes with zeroes if necessary before

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrently run softirq network code on SMP

2007-09-21 Thread John Ye
David, Thanks for your reply. I understand it's not worth to do. I have made it a loadable module to fulfill the function. it mainly for busy NAT gateway server with SMP to speed up. John Ye - Original Message - From: David Miller [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc:

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-21 Thread Urs Thuermann
Joe Perches [EMAIL PROTECTED] writes: On Thu, 2007-09-20 at 20:43 +0200, Urs Thuermann wrote: +#define DBG(...) (debug 1 ? \ + (printk(KERN_DEBUG can-%s %s: , \ + IDENT, __func__), printk(args)) : 0) +#define

[PATCH 2/2] bnx2: move gzip unpacker to zlib

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 12:01, Denys Vlasenko wrote: I will move this code out of the driver and into zlib in follow-on patch. No, I won't. I accidentally attached both patches to first email, you can find it there. Sorry. -- vda - To unsubscribe from this list: send the line unsubscribe

Re: [LARTC] ifb and ppp

2007-09-21 Thread jamal
On Thu, 2007-20-09 at 17:26 +0200, Patrick McHardy wrote: I don't see a good solution for this that allows to keep the iptables rules, I'd suggest to switch to ematches. One approach could be to use ipt action: --- tc filter add dev ppp0 parent : protocol ip u32 match

[PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
Hi Jeff, This patch modifies gzip unpacking code in bnx2 driver so that it does not depend on bnx2 internals. I will move this code out of the driver and into zlib in follow-on patch. It can be useful in other drivers which need to store firmwares or any other relatively big binary blobs -

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrently run softirq network code on SMP

2007-09-21 Thread jamal
On Fri, 2007-21-09 at 07:43 -0400, jamal wrote: one cpu in either bottom/top half has to be slightly loaded and you loose the ordering where incoming doesnt match outgoing packet order. Actually in your case it gets worse because (if i read that code correctly) you randomly select the CPUs.

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrently run softirq network code on SMP

2007-09-21 Thread jamal
On Fri, 2007-21-09 at 17:25 +0800, John Ye wrote: David, Thanks for your reply. I understand it's not worth to do. I have made it a loadable module to fulfill the function. it mainly for busy NAT gateway server with SMP to speed up. John, It was a little hard to read your code;

[PATCH] sb1250-mac: Driver model phylib update

2007-09-21 Thread Maciej W. Rozycki
A driver model and phylib update. It includes the following changes: 1. Removal of unused module options. 2. Phylib support and the resulting removal of generic bits for handling the PHY. 3. Proper reserving of device resources and using ioremap()ped handles to access MAC registers

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread jamal
On Fri, 2007-21-09 at 09:31 +0200, Emil Micek wrote: Hello list, I'd like to change behaviour of e1000 module when transmiting short ethernet frames (shorter then 64 bytes) trough VLAN interface. Current e1000 (according to our observations) first appends 4 bytes of VLAN tag and then pads

Re: [LARTC] ifb and ppp

2007-09-21 Thread Patrick McHardy
jamal wrote: On Thu, 2007-20-09 at 17:26 +0200, Patrick McHardy wrote: I don't see a good solution for this that allows to keep the iptables rules, I'd suggest to switch to ematches. One approach could be to use ipt action: --- tc filter add dev ppp0 parent :

Re: [LARTC] ifb and ppp

2007-09-21 Thread jamal
On Fri, 2007-21-09 at 13:56 +0200, Patrick McHardy wrote: This doesn't help much since he uses the iptables marks for classification on the ifb device, so he might as well just classify directly using u32. true. I think it would be nice to have an ematch equivalent to the ipt action for

Re: wrong arp query with policy routing

2007-09-21 Thread jamal
On Fri, 2007-21-09 at 11:08 +0200, Marco Berizzi wrote: thanks for the reply. I have tried to 'echo 1 /proc/sys/net/ipv4/conf/eth0', but the 'arp whos-has' behaviour doesn't change. Other hints? Give a man a fish and he'll eat for a day Documentation/networking/ip-sysctl.txt cheers,

[RFC/PATCH 0/3] UDP memory usage accounting

2007-09-21 Thread Satoshi OSHIMA
This patch set try to introduce memory usage accounting for UDP(currently ipv4 only). Currently, memory usage of UDP can be observed as the sam of usage of tx_queue and rx_queue. But I believe that the system wide accounting is usefull when heavy loaded condition. In the next step, I would like

[RFC/PATCH 3/3] UDP memory usage accounting: measurement

2007-09-21 Thread Satoshi OSHIMA
This patch introduces memory usage measurement for UDP. signed-off-by: Satoshi Oshima [EMAIL PROTECTED] signed-off-by: Hideo Aoki [EMAIL PROTECTED] Index: 2.6.23-rc7-udp_limit/net/ipv4/ip_output.c === ---

[RFC/PATCH 1/3] UDP memory usage accounting: fix send buffer check

2007-09-21 Thread Satoshi OSHIMA
This patch introduces sndbuf size check before memory allcation for send buffer. signed-off-by: Satoshi Oshima [EMAIL PROTECTED] signed-off-by: Hideo Aoki [EMAIL PROTECTED] Index: 2.6.23-rc7-udp_limit/net/ipv4/ip_output.c === ---

[RFC/PATCH 2/3] UDP memory usage accounting: accounting unit and variable

2007-09-21 Thread Satoshi OSHIMA
This patch introduces global variable for UDP memory accounting. The unit is page. signed-off-by: Satoshi Oshima [EMAIL PROTECTED] signed-off-by: Hideo Aoki [EMAIL PROTECTED] Index: 2.6.23-rc3-udp_limit/include/net/sock.h === ---

Re: [RFC PATCH] 2.6.22.6 netfilter: sk_setup_caps in ip_make_route_harder

2007-09-21 Thread Patrick McHardy
lepton wrote: Yes, you are right. What do you think about this: For all packets can be sent out, we just disable all things in sk_route_caps in ip_route_me_harder Whats the point of doing that? Is rerouting breaking anything for you? - To unsubscribe from this list: send the line

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread Emil Micek
On Fri, 2007-09-21 at 07:59 -0400, jamal wrote: Current e1000 (according to our observations) first appends 4 bytes of VLAN tag and then pads the frame to 64 bytes with zeroes if necessary before transmiting it. Which would make it a bug. AFAIK, the minimum VLAN tagged packet going out

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-09-21 Thread Maciej W. Rozycki
On Thu, 20 Sep 2007, Andrew Morton wrote: You always put boring, crappy, insufficient text in the for-the-changelog section and interesting, useful, sufficient text in the not-for-the-changelog section. I'll swap the sections in the future then. ;-) Frankly I was not sure whether the

Re: [PATCH 3/7] CAN: Add raw protocol

2007-09-21 Thread Patrick McHardy
Urs Thuermann wrote: +config CAN_RAW_USER + bool Allow non-root users to access Raw CAN Protocol sockets If you plan to remove this option, it should happen before merging since it affects userspace visible behaviour. - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-21 Thread Patrick McHardy
Urs Thuermann wrote: +static int can_create(struct net *net, struct socket *sock, int protocol) +{ + ... + + spin_lock(proto_tab_lock); + cp = proto_tab[protocol]; + if (cp !try_module_get(cp-prot-owner)) + cp = NULL; + spin_unlock(proto_tab_lock); + +

Re: wrong arp query with policy routing

2007-09-21 Thread Marco Berizzi
jamal wrote: On Fri, 2007-21-09 at 11:08 +0200, Marco Berizzi wrote: thanks for the reply. I have tried to 'echo 1 /proc/sys/net/ipv4/conf/eth0', but the 'arp whos-has' behaviour doesn't change. Other hints? Give a man a fish and he'll eat for a day

Re: [RFC/PATCH 0/3] UDP memory usage accounting

2007-09-21 Thread Evgeniy Polyakov
Hi. On Fri, Sep 21, 2007 at 09:18:07PM +0900, Satoshi OSHIMA ([EMAIL PROTECTED]) wrote: This patch set try to introduce memory usage accounting for UDP(currently ipv4 only). Currently, memory usage of UDP can be observed as the sam of usage of tx_queue and rx_queue. But I believe that the

Re: [RFC/PATCH 2/3] UDP memory usage accounting: accounting unit and variable

2007-09-21 Thread Andi Kleen
Satoshi OSHIMA [EMAIL PROTECTED] writes: This patch introduces global variable for UDP memory accounting. The unit is page. The global variable doesn't seem to be very MP scalable, especially if you change it for each packet. This will be a very hot cache line, in the worst case bouncing

Re: wrong arp query with policy routing

2007-09-21 Thread Marco Berizzi
Marco Berizzi wrote: inet 1.1.1.1/32 scope global eth0 ^^ Sorry, my fault. Apologies for all the noise. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread jamal
On Fri, 2007-21-09 at 14:50 +0200, Emil Micek wrote: On Fri, 2007-09-21 at 07:59 -0400, jamal wrote: Which would make it a bug. AFAIK, the minimum VLAN tagged packet going out is 68 bytes. Are you sure about this? This is what i have always seen. Double checked with google and she gave me

Re: [PATCH 1/2] David Miller's rbtree patches for 2.6.22.6

2007-09-21 Thread Ilpo Järvinen
On Wed, 19 Sep 2007, Tom Quetchenbach wrote: Patch 1: David Miller's red-black tree code, tweaked for 2.6.22.6, with some bugfixes It would help if you would leave the original changes as is (rb-tree and fack_count separated) and add your work on top of that... diff -ur

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread jamal
On Fri, 2007-21-09 at 09:37 -0400, jamal wrote: On Fri, 2007-21-09 at 14:50 +0200, Emil Micek wrote: On Fri, 2007-09-21 at 07:59 -0400, jamal wrote: Which would make it a bug. AFAIK, the minimum VLAN tagged packet going out is 68 bytes. Are you sure about this? This is what i have

Re: [PATCH 2/2] David Miller's rbtree patches for 2.6.22.6

2007-09-21 Thread Ilpo Järvinen
On Wed, 19 Sep 2007, Tom Quetchenbach wrote: Patch 2: fixes to fack_counts and enhancement of SACK fast path ...Usually these are not combined in patches but a separate patch per change. diff -ur linux-2.6.22.6-rbtree-davem-fixed/include/net/tcp.h

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread Francesco Fondelli
On 9/21/07, jamal [EMAIL PROTECTED] wrote: Hope that makes sense. [cut] cheers, jamal Hi all, as far as I understand ieee docs both 64 and 68 approaches are fine... --- Std 802.1Q-2005, 6.5.1 --- On receipt of an M_UNITDATA.request primitive that represents a tagged frame, the implementation

Re: [RFC PATCH] 2.6.22.6 netfilter: sk_setup_caps in ip_make_route_harder

2007-09-21 Thread lepton
Yes. My situation is: The default route device is a e1000 network card that can do TSO. So the tcp stack will try send big skb to netfilter frame work. But after rerouting, the packtes will go out from a device that can not do TSO. the packet is just get dropped.. I thinks if we can't get a way

Re: [PATCH 0/2] David Miller's rbtree patches for 2.6.22.6

2007-09-21 Thread Ilpo Järvinen
On Wed, 19 Sep 2007, Tom Quetchenbach wrote: Here are a couple of patches against 2.6.22.6. The first one is just David's patches tweaked for 2.6.22.6, with a couple of minor bugfixes to get it to compile and not crash. Why did you combine original patches to a single larger one, I think Dave

[PATCH] note that NETIF_F_LLTX is deprecated (was: [kvm-devel][PATCH 3/6] virtio net driver)

2007-09-21 Thread Christian Borntraeger
Am Freitag, 21. September 2007 schrieb Herbert Xu: Please don't use LLTX in new drivers. We're trying to get rid of it since it's 1) unnecessary; 2) causes problems with AF_PACKET seeing things twice. I suggest to document that LLTX is deprecated. Signed-off-by: Christian Borntraeger

Re: [RFC PATCH] 2.6.22.6 netfilter: sk_setup_caps in ip_make_route_harder

2007-09-21 Thread Patrick McHardy
lepton wrote: My situation is: The default route device is a e1000 network card that can do TSO. So the tcp stack will try send big skb to netfilter frame work. But after rerouting, the packtes will go out from a device that can not do TSO. the packet is just get dropped.. I thinks if we

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread Ben Greear
jamal wrote: On Fri, 2007-21-09 at 09:37 -0400, jamal wrote: On Fri, 2007-21-09 at 14:50 +0200, Emil Micek wrote: On Fri, 2007-09-21 at 07:59 -0400, jamal wrote: Which would make it a bug. AFAIK, the minimum VLAN tagged packet going out is 68 bytes. Are you sure about

Re: SFQ qdisc crashes with limit of 2 packets

2007-09-21 Thread Alexey Kuznetsov
Hello! Remove artificial limitation for sfq queue limit. This is followup to Patrick's patch. A little optimization to enqueue routine allows to remove artificial limitation on queue length. Plus, testing showed that hash function used by SFQ is too bad or even worse. It does not even sweep the

Re: [PATCH v2] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts.

2007-09-21 Thread Steve Wise
Evgeniy Polyakov wrote: Hi Steve. On Mon, Sep 17, 2007 at 10:25:04AM -0500, Steve Wise ([EMAIL PROTECTED]) wrote: Does creating the whole new netdevice is a too big overhead, or is it considered bad idea? I think its too big overhead, and pretty invasive on the low level cxgb3 driver. I

want same order in /sys/class/net/eth as /sys/bus/pci/devices

2007-09-21 Thread John Reiser
I'd like to see the same order of devices in /sys/class/net/eth* as in /sys/bus/pci/devices. This would make administration easier. On Fedora 8 tests, the order I see is reversed: http://bugzilla.redhat.com/show_bug.cgi?id=291431 Perhaps the reversal is a result of the alias order listed in

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread David Miller
From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 12:01:24 +0100 Hi Jeff, BNX2 and TG3 patches goes through Michael Chan and myself, and I usually merge them in instead of Jeff. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: net-2.6.24 - build failure

2007-09-21 Thread Michael Buesch
On Thursday 20 September 2007 00:17:12 David Miller wrote: From: Joe Perches [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 14:53:22 -0700 drivers/net/wireless/b43legacy/built-in.o: In function `tsf_read_file': drivers/net/wireless/b43legacy/debugfs.c:80: multiple definition of

[PATCH] e1000e: Do not allow requeue of freed skb

2007-09-21 Thread Auke Kok
From: Krishna Kumar [EMAIL PROTECTED] Returning BUSY will make qdisc_restart enqueue the skb which was already freed. The bad skb was correctly freed and we should return NETDEV_TX_OK. First spotted by Jeff Garzik on 08/13/07. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] Signed-off-by: Auke

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-21 Thread Joe Perches
On Fri, 2007-09-21 at 12:35 +0200, Urs Thuermann wrote: I didn't find a way with gcc-2.95 to make the format string a separate macro argument (which I also wanted). The old 2.x GCC workaround was to use #define DBG(fmt, arg) printk(fmt , ## arg) adding a space before the last comma. I

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 17:14, David Miller wrote: From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 12:01:24 +0100 Hi Jeff, BNX2 and TG3 patches goes through Michael Chan and myself, and I usually merge them in instead of Jeff. Didn't know that, sorry. Do patches look

RE: change the way e1000 is handling short VLAN frames

2007-09-21 Thread Brandeburg, Jesse
Emil Micek wrote: What is the right behaviour according to specification? In iee802.3, minFrameSize is 64bytes. I've never seen any document which'd say that VLAN frames should be 68 bytes minimum. e1000 only hardware pads to 64 bytes, but if you use the vlan module and turn off the hardware

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-21 Thread Davide Libenzi
On Thu, 20 Sep 2007, Nagendra Tomar wrote: That's not what POLLOUT means in the Unix meaning. POLLOUT indicates the ability to write, and it is not meant as to signal every time a packet (skb) is sent on the wire (and the buffer released). Aren't they both the same ? Everytime an

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread David Miller
From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 18:03:55 +0100 Do patches look ok to you? I'm travelling so I haven't looked closely yet :-) Michael can take a look and I'll try to do so as well tonight. - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 18:49, David Miller wrote: From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 18:03:55 +0100 Do patches look ok to you? I'm travelling so I haven't looked closely yet :-) Michael can take a look and I'll try to do so as well tonight. Good. I

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-21 Thread Urs Thuermann
Patrick McHardy [EMAIL PROTECTED] writes: You drop the module reference again when leaving this function. So sock-ops might contain a stale pointer if the module is unloaded after this. You need to either keep the module reference while the socket is alive or remove stale references when

[updated PATCH] forcedeth: power down phy when interface is down

2007-09-21 Thread Ed Swierk
On 9/19/07, Ayaz Abdulla [EMAIL PROTECTED] wrote: It seems that you are powering down the phy even if WOL is enabled. Right; I've updated the patch to skip powering down the phy when wol is enabled. Secondly, can you powerdown the phy at the same time you start performing autoneg restart?

Re: e1000 driver and samba

2007-09-21 Thread Bruce Cole
L F wrote: Aha. This doesn't seem to be in mr. Romieu's patch above: should it go in on top of that? His newer 0002-r8169-workaround-against-ignored-TxPoll-writes-8168.patch does the same thing as the older quoted version, and is also included in the roll-up patch he pointed you to. I

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex filename 17653 109968 240 127861 1f375 drivers/net/acenic.o 6628 120448 4 127080

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-09-21 Thread Andrew Morton
On Fri, 21 Sep 2007 13:51:12 +0100 (BST) Maciej W. Rozycki [EMAIL PROTECTED] wrote: On Thu, 20 Sep 2007, Andrew Morton wrote: You always put boring, crappy, insufficient text in the for-the-changelog section and interesting, useful, sufficient text in the not-for-the-changelog

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex filename 17653 109968 240

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 20:18:06 BST, Denys Vlasenko said: On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: Should this be redone to use the existing firmware loading framework to load the firmware instead? Not in every case. For example, bnx2 maintainer says that driver and

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Krzysztof Oledzki
On Fri, 21 Sep 2007, Denys Vlasenko wrote: On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex

Re: [PATCH] sb1250-mac: Driver model phylib update

2007-09-21 Thread Andrew Morton
On Fri, 21 Sep 2007 12:52:10 +0100 (BST) Maciej W. Rozycki [EMAIL PROTECTED] wrote: A driver model and phylib update. akpm:/usr/src/25 diffstat patches/git-net.patch | tail -n 1 1013 files changed, 187667 insertions(+), 23587 deletions(-) Sorry, but raising networking patches against Linus's

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Andi Kleen
Denys Vlasenko [EMAIL PROTECTED] writes: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex filename 17653 109968 240 127861 1f375 drivers/net/acenic.o 6628 120448 4 127080 1f068

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Roland Dreier
Just change the makefiles to always install gzip'ed modules modutils knows how to unzip them on the fly. But that leaves the uncompressed firmware blobs in .data that ends up in unswappable kernel memory. - R. - To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Alan Cox
For example, bnx2 maintainer says that driver and firmware are closely tied for his driver. IOW: you upgrade kernel and your NIC is not working anymore. Another argument is to make kernel be able to bring up NICs without needing firmware images in initramfs/initrd/hard drive. dgrs should

Re: [PATCH 3/7] CAN: Add raw protocol

2007-09-21 Thread Urs Thuermann
Patrick McHardy [EMAIL PROTECTED] writes: Urs Thuermann wrote: +config CAN_RAW_USER + bool Allow non-root users to access Raw CAN Protocol sockets If you plan to remove this option, it should happen before merging since it affects userspace visible behaviour. We have discussed this

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread jamal
On Fri, 2007-21-09 at 08:43 -0700, Ben Greear wrote: I just re-read the spec, and a bridge *may* pad up to 68, but it is not required. On page 166, it says equipment must be able to handle 64 byte minimums. See page 22 (section 7.2) of this document:

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread Ben Greear
jamal wrote: On Fri, 2007-21-09 at 08:43 -0700, Ben Greear wrote: I just re-read the spec, and a bridge *may* pad up to 68, but it is not required. On page 166, it says equipment must be able to handle 64 byte minimums. See page 22 (section 7.2) of this document:

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread Kok, Auke
jamal wrote: On Fri, 2007-21-09 at 08:43 -0700, Ben Greear wrote: I just re-read the spec, and a bridge *may* pad up to 68, but it is not required. On page 166, it says equipment must be able to handle 64 byte minimums. See page 22 (section 7.2) of this document:

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread Chris Leech
On 9/21/07, jamal [EMAIL PROTECTED] wrote: On Fri, 2007-21-09 at 08:43 -0700, Ben Greear wrote: I just re-read the spec, and a bridge *may* pad up to 68, but it is not required. On page 166, it says equipment must be able to handle 64 byte minimums. See page 22 (section 7.2) of this

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread jamal
On Fri, 2007-21-09 at 14:18 -0700, Ben Greear wrote: As for using the software stack, I don't think we are padding to 68 in the soft vlans either... Should be much easier than changing firmware or an ASIC. It would be nice to have an ethtool to turn off hw vlans for other reasons, like

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread Kok, Auke
jamal wrote: AFAIK the RX side is fully covered so you can handle both 64B and 68B? I never saw any bugreports about e1000 not being able to accept vlan packets because of this, so I'm quite certain it works OK, feel free to find me a case where this isn't so :) Auke - To unsubscribe from

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread jamal
On Fri, 2007-21-09 at 14:34 -0700, Kok, Auke wrote: I never saw any bugreports about e1000 not being able to accept vlan packets because of this, so I'm quite certain it works OK, feel free to find me a case where this isn't so :) If you tell me it can be done on the rx, i will take your word

Re: e1000 driver and samba

2007-09-21 Thread Francois Romieu
Bruce Cole [EMAIL PROTECTED] : If you look for it on the Realtek cards, there had been sporadic Nissues up to late 2005. The solution posted universally was 'change card'. Yes, that *was* the common recommendation. There was no such thing as a universal solution to sporadic issues. [...]

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread jamal
On Fri, 2007-21-09 at 14:27 -0700, Chris Leech wrote: Inserting the VLAN tag in software will not change the behavior in the way you want anyway, short frames will still be padded to 64 bytes. You'd have to do short packet padding in software to 68 bytes. Or do software padding to 64 bytes

Re: e1000 driver and samba

2007-09-21 Thread Bruce Cole
Francois Romieu wrote: Bruce Cole [EMAIL PROTECTED] : If you look for it on the Realtek cards, there had been sporadic Nissues up to late 2005. The solution posted universally was 'change card'. Yes, that *was* the common recommendation. There was no such thing as a universal

Re: [stable] [PATCH] cfg80211: fix initialisation if built-in

2007-09-21 Thread Johannes Berg
On Fri, 2007-09-21 at 15:02 -0700, Greg KH wrote: When this goes into Linus's tree, please resend it to the [EMAIL PROTECTED] address so we can add it to our queue. It's on the way, sitting in net-2.6.24 right now but I don't know whether it's scheduled for .23. I'm no longer sure if it really

Re: ?^?H?G Re: [linux-usb-devel] Please pull 'ssb-drivers' branch of wireless-2.6 -- aln.

2007-09-21 Thread Greg KH
On Fri, Sep 21, 2007 at 10:58:37AM +0800, [EMAIL PROTECTED] wrote: Hi Greh, hm, I don't know of anyone by that name :) You might not want to take over a totally different thread for your question, it doesn't make much sense that way... I donot know how to ask question to u, so use

Re: change the way e1000 is handling short VLAN frames

2007-09-21 Thread Chris Leech
On 9/21/07, jamal [EMAIL PROTECTED] wrote: On Fri, 2007-21-09 at 14:34 -0700, Kok, Auke wrote: I never saw any bugreports about e1000 not being able to accept vlan packets because of this, so I'm quite certain it works OK, feel free to find me a case where this isn't so :) If you tell

Re: [stable] [PATCH] cfg80211: fix initialisation if built-in

2007-09-21 Thread Greg KH
On Mon, Sep 10, 2007 at 01:44:45PM +0200, Johannes Berg wrote: When cfg80211 is built into the kernel it needs to init earlier so that device registrations are run after it has initialised. Signed-off-by: Johannes Berg [EMAIL PROTECTED] When this goes into Linus's tree, please resend it to

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Jeff Garzik
Alan Cox wrote: For example, bnx2 maintainer says that driver and firmware are closely tied for his driver. IOW: you upgrade kernel and your NIC is not working anymore. Another argument is to make kernel be able to bring up NICs without needing firmware images in initramfs/initrd/hard drive.

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 21:13, Andi Kleen wrote: Denys Vlasenko [EMAIL PROTECTED] writes: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex filename 17653 109968 240 127861 1f375

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Alan Cox
According to an earlier thread, dgrs was never really maintained, written for hardware that was never really distributed widely, and very likely hasn't had users in years... if ever. If that picture is accurate (it's a story I was told), then I am definitely queueing up a deletion patch.

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 20:33, Krzysztof Oledzki wrote: On Fri, 21 Sep 2007, Denys Vlasenko wrote: On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following drivers' firmware, if

Re: e1000 driver and samba

2007-09-21 Thread Francois Romieu
Bruce Cole [EMAIL PROTECTED] : Francois Romieu wrote: [...] Can you be more specific ? Yes per the reference I gave: http://www.spinics.net/lists/netdev/msg40384.html [...] Ok, I wondered if you had found something between the start_xmit and the Tx completion code. [...] I could

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Jeff Garzik
Denys Vlasenko wrote: On Friday 21 September 2007 20:33, Krzysztof Oledzki wrote: On Fri, 21 Sep 2007, Denys Vlasenko wrote: On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread maximilian attems
On Fri, Sep 21, 2007 at 11:48:05PM +0100, Alan Cox wrote: According to an earlier thread, dgrs was never really maintained, written for hardware that was never really distributed widely, and very likely hasn't had users in years... if ever. If that picture is accurate (it's a story I

Re: [PATCH] note that NETIF_F_LLTX is deprecated (was: [kvm-devel][PATCH 3/6] virtio net driver)

2007-09-21 Thread Herbert Xu
On Fri, Sep 21, 2007 at 04:59:54PM +0200, Christian Borntraeger wrote: I suggest to document that LLTX is deprecated. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] This looks good to me. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Michael Chan
On Fri, 2007-09-21 at 10:49 -0700, David Miller wrote: From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 18:03:55 +0100 Do patches look ok to you? I'm travelling so I haven't looked closely yet :-) Michael can take a look and I'll try to do so as well tonight. I've