Re: iproute2: resend of patches from Debian.

2007-10-11 Thread Alexander Wirt
David Miller schrieb am Donnerstag, den 11. Oktober 2007: Hi David, > > If you want me to STFU please just say so and I'll give you all my > > sincere appologies and go back to the status quo of no fixes shared > > with others. > > I applaud your efforts, it's not what the problem is. > > I ju

Re: authenc compile warnings in current net-2.6.24

2007-10-11 Thread Oliver Hartkopp
Hi Dave, this compile fix seems not to be applied (maybe my compiler is the only one who complains ;-) Acked-by: Oliver Hartkopp <[EMAIL PROTECTED]> Thanks! On Thu, Oct 11, 2007 at 11:23:30AM +0800, Herbert Xu wrote: Yeah I've added a fix in the cryptodev tree. Oh and here's the actual

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread Alexander Wirt
Lennart Sorensen schrieb am Donnerstag, den 11. Oktober 2007: > On Thu, Oct 11, 2007 at 08:25:32PM +0200, Andreas Henriksson wrote: > > Patch from debian iproute package. > > > > diff -urNad iproute-20060323~/ip/iplink.c iproute-20060323/ip/iplink.c > > --- iproute-20060323~/ip/iplink.c 2006-03

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread Paul Mackerras
David Miller writes: > Here is the patch I'm putting through some paces, let me know if > it solves the powerpc problem. Looks fine to me. Acked-by: Paul Mackerras <[EMAIL PROTECTED]> Thanks! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: [PATCH] tg3: Fix APE induced regression

2007-10-11 Thread Kyle McMartin
On Thu, Oct 11, 2007 at 06:43:50PM -0700, Matt Carlson wrote: > This patch fixes a bug caused by the recent APE support added for 5761 > devices. > > Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> > Woot, thanks! This just bit me as I was testing git head on some of my parisc boxes. Cheers,

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-11 Thread Al Boldi
Patrick McHardy wrote: > Please send mails discussing netfilter to netfilter-devel. Ok. I just found out this changed to vger. But [EMAIL PROTECTED] is bouncing me. > Al Boldi wrote: > > With the existence of the mangle table, how useful is the filter table? > > > > Other than requiring the RE

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 21:54:29 -0700 (PDT) > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 21:25:39 -0700 > > > On Fri, 12 Oct 2007 13:52:14 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote: > > > > > So Andrew, what do you think is better

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 21:25:39 -0700 > On Fri, 12 Oct 2007 13:52:14 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote: > > > So Andrew, what do you think is better - arch/powerpc/boot having its > > own copies of the zlib_inflate stuff, or #ifdefs of some kin

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-11 Thread Patrick McHardy
Patrick McHardy wrote: > Please send mails discussing netfilter to netfilter-devel. Correct address CCed and unrelated lists removed .. stupid auto-completion :) > Al Boldi wrote: > >>With the existence of the mangle table, how useful is the filter table? >> >>Other than requiring the REJECT tar

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-11 Thread Patrick McHardy
Please send mails discussing netfilter to netfilter-devel. Al Boldi wrote: > With the existence of the mangle table, how useful is the filter table? > > Other than requiring the REJECT target to be ported to the mangle table, is > the filter table faster than the mangle table? There are some mi

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread Andrew Morton
On Fri, 12 Oct 2007 13:52:14 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote: > So Andrew, what do you think is better - arch/powerpc/boot having its > own copies of the zlib_inflate stuff, or #ifdefs of some kind in > lib/zlib_inflate/*.c? The latter - copying code is evil. Keeping the existing

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread Paul Mackerras
Andrew Morton writes: > arch/powerpc/boot/inflate.c:920:19: errno.h: No such file or directory > arch/powerpc/boot/inflate.c:921:18: slab.h: No such file or directory > arch/powerpc/boot/inflate.c:922:21: vmalloc.h: No such file or directory We used to have our own copies of inflate.c etc. for th

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread Paul Mackerras
David Miller writes: > The only thing we touched in zlib is in the patch below. > > I suspect the lib/zlib_inflate/inflate.c changes, I had no idea that > some pieces of code try to use this into userspace. Not userspace; the zImage wrapper uses inflate.c to gunzip the compressed kernel image.

Re: [PATCH] rtnl: Simplify ASSERT_RTNL

2007-10-11 Thread Eric W. Biederman
David, all. My apologies. I'm tired and I don't have the energy to grok yet another part of the kernel right now. So I can not productively participate in this discussion. I do agree that the locking below dev_unicast_add() that was exposed by the macvlan driver is unmaintainable even if it is

Re: [PATCH] tg3: Fix APE induced regression

2007-10-11 Thread David Miller
From: "Matt Carlson" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 18:43:50 -0700 > This patch fixes a bug caused by the recent APE support added for 5761 > devices. > > Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Thanks for this fix Matt, I'll apply it soon. - To unsubscribe from this list: se

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 19:22:33 -0700 > With net-2.6.24 (pulled yesterday) applied: > > g5:/usr/src/25> ml arch/powerpc/boot/inflate.o > Using ARCH=powerpc CROSS_COMPILE= > CHK include/linux/version.h > CHK include/linux/utsrelease.h > CALL

[PATCH] forcedeth: Fix MAC address detection on network card (regression in 2.6.23)

2007-10-11 Thread Michael Pyne
Partially revert a change to mac address detection introduced to the forcedeth driver. The change was intended to correct mac address detection for newer nVidia chipsets where the mac address was stored in reverse order. One of those chipsets appears to still have the mac address in reverse or

Re: Regression in net-2.6.24?

2007-10-11 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 20:17:16 -0700 > On Thu, 2007-10-11 at 18:14 -0700, David Miller wrote: > > + while (1) { > > + work_done = tg3_poll_work(tp, work_done, budget); > > + > > + if (unlikely(tp->tg3_flags & TG3_FLAG_TX_R

net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread Andrew Morton
With net-2.6.24 (pulled yesterday) applied: g5:/usr/src/25> ml arch/powerpc/boot/inflate.o Using ARCH=powerpc CROSS_COMPILE= CHK include/linux/version.h CHK include/linux/utsrelease.h CALLscripts/checksyscalls.sh BOOTCC arch/powerpc/boot/inflate.o arch/powerpc/boot/inflate.c

Re: Regression in net-2.6.24?

2007-10-11 Thread Michael Chan
On Thu, 2007-10-11 at 18:14 -0700, David Miller wrote: > + while (1) { > + work_done = tg3_poll_work(tp, work_done, budget); > + > + if (unlikely(tp->tg3_flags & TG3_FLAG_TX_RECOVERY_PENDING)) > + goto tx_recovery; > + > + if (un

[PATCH] tg3: Fix APE induced regression

2007-10-11 Thread Matt Carlson
This patch fixes a bug caused by the recent APE support added for 5761 devices. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index d2b30fb..e978a79 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -6966,9 +6966,10 @@ static int tg3_re

Re: [PATCH 1/6] sky2: status polling loop (post merge)

2007-10-11 Thread Stephen Hemminger
On Thu, 11 Oct 2007 18:31:46 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 18:29:21 -0700 > > > Handle the corner case where budget is exhausted correctly. > > And save unnecessary read of index register. > > > > Signed

Re: [PATCH 1/6] sky2: status polling loop (post merge)

2007-10-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 18:29:21 -0700 > Handle the corner case where budget is exhausted correctly. > And save unnecessary read of index register. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. You can submit the rest later, I delet

Re: Question on TSO maximum segment sizes.

2007-10-11 Thread Ben Greear
John Heffner wrote: Ben Greear wrote: I just tried turning off my explicit SO_SNDBUF/SO_RCVBUG settings in my app, and the connection ran very poorly through a link with even a small bit of latency (~2-4ms I believe). I often run at full gigabit or faster with latencies of 100+ ms. Can you

[PATCH 1/6] sky2: status polling loop (post merge)

2007-10-11 Thread Stephen Hemminger
Handle the corner case where budget is exhausted correctly. And save unnecessary read of index register. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-10-11 18:26:56.0 -0700 +++ b/drivers/net/sky2.c2007-10-11 18:27:12.0 -0700 @@

Re: Regression in net-2.6.24?

2007-10-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 18:22:59 -0700 > Please use the version I just sent, it saves another non-cached read. No, rather, please send me fixed relative to that. I'm trying to get the net-2.6.24 merge out the door. - To unsubscribe from this list: send

Re: [PATCH 1/6] sky2: status polling loop

2007-10-11 Thread Stephen Hemminger
On Thu, 11 Oct 2007 18:23:58 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 18:19:52 -0700 > > > Handle the corner case where budget is exhausted correctly. > > > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> >

Re: Question on TSO maximum segment sizes.

2007-10-11 Thread John Heffner
Ben Greear wrote: I just tried turning off my explicit SO_SNDBUF/SO_RCVBUG settings in my app, and the connection ran very poorly through a link with even a small bit of latency (~2-4ms I believe). I often run at full gigabit or faster with latencies of 100+ ms. Can you give a bit more detai

Re: Regression in net-2.6.24?

2007-10-11 Thread Stephen Hemminger
On Thu, 11 Oct 2007 18:14:49 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > > Here is what I'm checking into net-2.6 for now: > > commit 6f535763165331bb91277d7519b507fed22034e5 > Author: David S. Miller <[EMAIL PROTECTED]> > Date: Thu Oct 11 18:08:29 2007 -0700 > > [NET]: Fix NAPI

Re: [PATCH 1/6] sky2: status polling loop

2007-10-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 18:19:52 -0700 > Handle the corner case where budget is exhausted correctly. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Doesn't apply, I checked in my fixed version of your original patch already. You had to have s

[PATCH 6/6] sky2: version 1.19

2007-10-11 Thread Stephen Hemminger
Update version to keep track of new changes. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-10-11 18:13:02.0 -0700 +++ b/drivers/net/sky2.c2007-10-11 18:14:25.0 -0700 @@ -52,7 +52,7 @@ #include "sky2.h" #define DRV_NAME

[PATCH 2/6] sky2: ethtool register reserved area blackout

2007-10-11 Thread Stephen Hemminger
Make sure and not dump reserved areas of device space. Touching some of these causes machine check exceptions on boards like D-Link DGE-550SX. Coding note, used a complex switch statement rather than bitmap because it is easier to relate the block values to the documentation rather than looking a

[PATCH 5/6] sky2: use netdevice stats struct

2007-10-11 Thread Stephen Hemminger
Use builtin statistics structure from net device. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-10-11 18:13:01.0 -0700 +++ b/drivers/net/sky2.c2007-10-11 18:13:02.0 -0700 @@ -1635,8 +1635,8 @@ static void sky2_tx_complete(struct

[PATCH 0/6] sky2 patches for net-2.6

2007-10-11 Thread Stephen Hemminger
Includes: * fix for new NAPI status loop * use internal net_stats * fixes for fiber PHY power -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ke

[PATCH 4/6] sky2: fiber advertise bits initialization (trivial)

2007-10-11 Thread Stephen Hemminger
Put initialization in sequential order (same as other constants). Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-10-11 18:13:00.0 -0700 +++ b/drivers/net/sky2.c2007-10-11 18:13:01.0 -0700 @@ -296,10 +296,10 @@ static const u16 cop

[PATCH 1/6] sky2: status polling loop

2007-10-11 Thread Stephen Hemminger
Handle the corner case where budget is exhausted correctly. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-10-11 18:11:44.0 -0700 +++ b/drivers/net/sky2.c2007-10-11 18:12:50.0 -0700 @@ -2245,15 +2245,13 @@ static inline void sky2_

[PATCH 3/6] sky2: fix power settings on Yukon XL

2007-10-11 Thread Stephen Hemminger
Make sure PCI register for PHY power gets set correctly. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-10-11 18:12:56.0 -0700 +++ b/drivers/net/sky2.c2007-10-11 18:13:00.0 -0700 @@ -606,20 +606,19 @@ static void sky2_phy_power(s

Re: Regression in net-2.6.24?

2007-10-11 Thread David Miller
Here is what I'm checking into net-2.6 for now: commit 6f535763165331bb91277d7519b507fed22034e5 Author: David S. Miller <[EMAIL PROTECTED]> Date: Thu Oct 11 18:08:29 2007 -0700 [NET]: Fix NAPI completion handling in some drivers. In order for the list handling in net_rx_action() t

Re: Regression in net-2.6.24?

2007-10-11 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 18:00:31 -0700 (PDT) > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 17:50:59 -0700 > > > On Thu, 11 Oct 2007 17:40:26 -0700 (PDT) > > David Miller <[EMAIL PROTECTED]> wrote: > > > > > From: Stephen Hemminger <[

Re: Regression in net-2.6.24?

2007-10-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 17:50:59 -0700 > On Thu, 11 Oct 2007 17:40:26 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > Date: Thu, 11 Oct 2007 17:31:49 -0700 > > > > > You don't need to re-read t

APE changes cause tg3 regressions...

2007-10-11 Thread David Miller
On my onboard SunBlade1500 5703 chips, which lack firmware, the APE changes introduce bus timeouts while bringing the chip up, specifically I get crashes in tg3_write_sig_post_reset() such as: [ 36.066603] eth1: Tigon3 [partno(BCM95703A30U) rev 1002 PHY(5703)] (PCI:33MHz:64-bit) 10/100/1000Bas

Re: Regression in net-2.6.24?

2007-10-11 Thread Stephen Hemminger
On Thu, 11 Oct 2007 17:40:26 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 17:31:49 -0700 > > > You don't need to re-read the status register and process the PHY irq's > > inside loop. > > Try this: > > Are you sure?

Re: Regression in net-2.6.24?

2007-10-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 17:31:49 -0700 > You don't need to re-read the status register and process the PHY irq's > inside loop. > Try this: Are you sure? What if a PHY interrupt comes in during the loop? I'm just preserving the semantics of the driver

Re: [PATCH 7/7] [TCP]: Limit processing lost_retrans loop to work-to-do cases

2007-10-11 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 14:41:07 +0300 > This addition of lost_retrans_low to tcp_sock might be > unnecessary, it's not clear how often lost_retrans worker is > executed when there wasn't work to do. > > Cc: TAKANO Ryousei <[EMAIL PROTECTED]> > Signed-off-

Re: [PATCH net-2.6 0/7] TCP: small changes/fixes + lost_retrans brokeness fix

2007-10-11 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 14:41:00 +0300 > Dave, please apply at will. Done. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/7] [TCP]: Fix lost_retrans loop vs fastpath problems

2007-10-11 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 14:41:06 +0300 > Detection implemented with lost_retrans must work also when > fastpath is taken, yet most of the queue is skipped including > (very likely) those retransmitted skb's we're interested in. > This problem appeared when

Re: [PATCH 5/7] [TCP]: No need to re-count fackets_out/sacked_out at RTO

2007-10-11 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 14:41:05 +0300 > Both sacked_out and fackets_out are directly known from how > parameter. Since fackets_out is accurate, there's no need for > recounting (sacked_out was previously unnecessarily counted > in the loop anyway). > > Si

Re: [PATCH 4/7] [TCP]: Extract tcp_match_queue_to_sack from sacktag code

2007-10-11 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 14:41:04 +0300 > This is necessary for upcoming DSACK bugfix. Reduces sacktag > length which is not very sad thing at all... :-) > > Notice that there's a need to handle out-of-mem at caller's > place. > > Signed-off-by: Ilpo Järvi

Re: [PATCH 3/7] [TCP]: Kill almost unused variable pcount from sacktag

2007-10-11 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 14:41:03 +0300 > It's on the way for future cutting of that function. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EM

Re: [PATCH 2/7] [TCP]: Fix mark_head_lost to ignore R-bit when trying to mark L

2007-10-11 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 14:41:02 +0300 > This condition (plain R) can arise at least in recovery that > is triggered after tcp_undo_loss. There isn't any reason why > they should not be marked as lost, not marking makes in_flight > estimator to return too l

Re: Regression in net-2.6.24?

2007-10-11 Thread Stephen Hemminger
On Thu, 11 Oct 2007 17:17:43 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 16:55:48 -0700 > > > On Thu, 11 Oct 2007 16:48:27 -0700 (PDT) > > David Miller <[EMAIL PROTECTED]> wrote: > > > > > Alternatively we could loop

Re: [PATCH 1/7] [TCP]: Add bytes_acked (ABC) clearing to FRTO too

2007-10-11 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 14:41:01 +0300 > I was reading tcp_enter_loss while looking for Cedric's bug and > noticed bytes_acked adjustment is missing from FRTO side. > > Since bytes_acked will only be used in tcp_cong_avoid, I think > it's safe to assume RT

Re: [PATCH] rtnl: Simplify ASSERT_RTNL

2007-10-11 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 11 Oct 2007 10:33:39 -0600 > Having ASSERT_RTNL warn if you were sleeping does not seem > intuitive from the name. > > This instance of convoluted locking seems like a complete > one off to me, and if it will warn about other constructs > cur

Re: Question on TSO maximum segment sizes.

2007-10-11 Thread David Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 17:17:48 -0700 > Was the auto-tuning put in after 2.6.20? If not, has this > been tested through a higher latency link? Or, am I confused > and you are talking about some other setsockopt? It's been there for quite some time. - To unsu

Re: Regression in net-2.6.24?

2007-10-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 16:55:48 -0700 > On Thu, 11 Oct 2007 16:48:27 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > Alternatively we could loop in tg3_poll() until either budget > > is exhausted or tg3_has_work() returns false. Actually, t

Re: Question on TSO maximum segment sizes.

2007-10-11 Thread Ben Greear
Waskiewicz Jr, Peter P wrote: From: Rick Jones <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 16:50:46 -0700 For just messing about, might it be possible to tweak the socket buffer sizes and tcp_tso_win_divisor to kludge things for a short while? Couldn't ship that way certainly, but assuming Pe

RE: Question on TSO maximum segment sizes.

2007-10-11 Thread Waskiewicz Jr, Peter P
> From: Rick Jones <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 16:50:46 -0700 > > > For just messing about, might it be possible to tweak the socket > > buffer sizes and tcp_tso_win_divisor to kludge things for a short > > while? Couldn't ship that way certainly, but assuming > Peter's going

Re: Question on TSO maximum segment sizes.

2007-10-11 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 16:50:46 -0700 > For just messing about, might it be possible to tweak the socket buffer sizes > and tcp_tso_win_divisor to kludge things for a short while? Couldn't ship > that > way certainly, but assuming Peter's going to get his b

Re: Non-linear SKBs

2007-10-11 Thread David Miller
From: Kristian Evensen <[EMAIL PROTECTED]> Date: Fri, 12 Oct 2007 00:54:37 +0200 > I have developed a small patch for the TCP code in 2.6.19 and it works > flawlessly. A couple of days ago I decided to make it compatible with > 2.6.22.5 and have stumbled upon a problem I cannot solve. > > In 2.

Re: Question on TSO maximum segment sizes.

2007-10-11 Thread Rick Jones
David Miller wrote: From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 16:27:14 -0700 I'm having an issue with TSO right vs. hardware that can't take the maximum segment size sent from the stack. I've been told that the maximum packet size that can be sent to the hardwa

Re: Regression in net-2.6.24?

2007-10-11 Thread Stephen Hemminger
On Thu, 11 Oct 2007 16:48:27 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: TAKANO Ryousei <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 22:51:46 +0900 (JST) > > > Modules linked in: 8021q tcp_bic netconsole evdev joydev sg st sr_mod > > ohci_hcd i2c_amd756 i2c_amd8111 i2c_core ipv6

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread Stephen Hemminger
On Thu, 11 Oct 2007 14:48:43 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Andreas Henriksson <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 23:22:12 +0200 > > > Copying Alexander Wirt here again, as I think this is his patch. > > It is important that whoever is the package maintaine

Non-linear SKBs

2007-10-11 Thread Kristian Evensen
Hello, I have developed a small patch for the TCP code in 2.6.19 and it works flawlessly. A couple of days ago I decided to make it compatible with 2.6.22.5 and have stumbled upon a problem I cannot solve. In 2.6.19 it seems that all packets (at least the ones my patch work with) are linear,

Re: Regression in net-2.6.24?

2007-10-11 Thread David Miller
From: TAKANO Ryousei <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 22:51:46 +0900 (JST) > Modules linked in: 8021q tcp_bic netconsole evdev joydev sg st sr_mod > ohci_hcd i2c_amd756 i2c_amd8111 i2c_core ipv6 tg3 usbhid usbcore ff_memless > dm_mod ext3 jbd sata_sil libata sd_mod scsi_mod ... > RIP

Re: Question on TSO maximum segment sizes.

2007-10-11 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 16:27:14 -0700 > I'm having an issue with TSO right vs. hardware that can't take the > maximum segment size sent from the stack. I've been told that the > maximum packet size that can be sent to the hardware today is 64k, b

Re: bytes received from recvmsg doesn't match FIONREAD

2007-10-11 Thread David Stevens
Questions of this sort should normally be directed to linux-net mailing list. >From the code you quoted, I see at least one case where it will fail -- when the allocated buffer you pass to recvmsg is smaller than "value" (ie. the datagram is too big for the read buffer). If that's not the proble

Re: bytes received from recvmsg doesn't match FIONREAD

2007-10-11 Thread David Miller
From: Steven Dake <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 16:08:15 -0700 > I wanted to verify that the size of a multicast UDP message received > with recvmsg matches the size of the message the kernel thinks the > message is. > > So I went about using the FIONREAD ioctl as follows: > > res =

Question on TSO maximum segment sizes.

2007-10-11 Thread Waskiewicz Jr, Peter P
I'm having an issue with TSO right vs. hardware that can't take the maximum segment size sent from the stack. I've been told that the maximum packet size that can be sent to the hardware today is 64k, but my hardware can only take 32k in certain modes per queue due to hardware limitations. I have

Re: e100 problems in .23rc8 ?

2007-10-11 Thread Herbert Xu
On Thu, Oct 11, 2007 at 09:10:34AM -0700, Kok, Auke wrote: > >> > >> commit 416b5d10afdc797c21c457ade3714e8f2f75edd9 > >> Author: Auke Kok <[EMAIL PROTECTED]> > >> Date: Fri Jun 1 10:22:39 2007 -0700 > >> > >> e1000: disable polling before registering netdevice > > this patch actually called

bytes received from recvmsg doesn't match FIONREAD

2007-10-11 Thread Steven Dake
I wanted to verify that the size of a multicast UDP message received with recvmsg matches the size of the message the kernel thinks the message is. So I went about using the FIONREAD ioctl as follows: res = ioctl (fd, FIONCREAD, &value); assert (res != -1); bytes_received = recvmsg (fd, &msg_recv

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread David Miller
From: Andreas Henriksson <[EMAIL PROTECTED]> Date: Fri, 12 Oct 2007 00:35:07 +0200 > If you want me to STFU please just say so and I'll give you all my > sincere appologies and go back to the status quo of no fixes shared > with others. I applaud your efforts, it's not what the problem is. I jus

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread Andreas Henriksson
On tor, 2007-10-11 at 14:48 -0700, David Miller wrote: > From: Andreas Henriksson <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 23:22:12 +0200 > > > Copying Alexander Wirt here again, as I think this is his patch. > > It is important that whoever is the package maintainer for an > upstream piece o

Re: [PATCH] IB/ipoib: Bound the net device to the ipoib_neigh structue

2007-10-11 Thread Jay Vosburgh
Roland Dreier <[EMAIL PROTECTED]> wrote: [...] >Yes, two napi_disable()s in a row without a matching napi_enable() >will deadlock. I guess the question is why the ipoib interface is >being stopped twice. > >If you just take the net-2.6.24 tree (without bonding patches), does >bonding for ethernet

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread David Miller
From: Andreas Henriksson <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 23:22:12 +0200 > Copying Alexander Wirt here again, as I think this is his patch. It is important that whoever is the package maintainer for an upstream piece of code in any distribution: 1) Completely understands the patches he

Re: [PATCH][BNX2X] round three

2007-10-11 Thread David Miller
From: "Eliezer Tamir" <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 19:53:39 +0200 > Will it be OK if we replace it with 4-5 headers so we can maintain them > better manually. (I'm asking what is the upper bound to the number of > header files you would consider reasonable for this driver.) It's not

Re: [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493, try2

2007-10-11 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 10:49:14 -0700 > Acked-by: David L Stevens <[EMAIL PROTECTED]> Applied, thanks everyone! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://

[RFD] iptables: mangle table obsoletes filter table

2007-10-11 Thread Al Boldi
With the existence of the mangle table, how useful is the filter table? Other than requiring the REJECT target to be ported to the mangle table, is the filter table faster than the mangle table? If not, then shouldn't the filter table be obsoleted to avoid confusion? Thanks! -- Al - To unsub

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread Andreas Henriksson
On tor, 2007-10-11 at 22:30 +0200, Patrick McHardy wrote: > Andreas Henriksson wrote: > > Abort flush after 10 seconds. > > This should be optional IMO. Copying Alexander Wirt here again, as I think this is his patch. I'll skip this patch in my next resend... > > > Add references to lartc, als

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread Patrick McHardy
Andreas Henriksson wrote: > Add mpath to ip manpage. > > From: Norbert Buchmuller <[EMAIL PROTECTED]> > > The 'mpath' parameter of 'ip route' is not documented in the manual page > nor in ip-cref.tex. > > ...huge part of the text in the patch was taken from the net/ipv4/Kconfig > file in the Lin

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread Andreas Henriksson
On tor, 2007-10-11 at 13:11 -0700, Stephen Hemminger wrote: > Since there are so many. Please send them as git separate emails to me and > make sure they are in the proper format for importing into git. If you really > want to make it easy, just put them in git yourself and then use 'git > format

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread Patrick McHardy
Andreas Henriksson wrote: > Abort flush after 10 seconds. This should be optional IMO. > Add references to lartc, also drop bogus reference to tc-filters There's a bad habit of reporting bugs on lartc that belong to netdev, please also make it perfectly clear that lartc is not for bug-reports.

Re: [PATCH] IB/ipoib: Bound the net device to the ipoib_neigh structue

2007-10-11 Thread Roland Dreier
> It happens only when ib interfaces are slaves of a bonding device. > I thought before that the stuck is in napi_disable() but it's almost right. > I put prints before and after call to napi_disable and see that it is called > twice. > I'll try to investigate in this direction. > > ib0: s

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread Stephen Hemminger
On Thu, 11 Oct 2007 20:25:32 +0200 Andreas Henriksson <[EMAIL PROTECTED]> wrote: > Hello all! > > Posting this set of patches again, since there where no reaction last time I > sent them. > > Regards, > Andreas Henriksson > Since there are so many. Please send them as git separate emails to

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread Andreas Henriksson
On tor, 2007-10-11 at 15:25 -0400, Lennart Sorensen wrote: > On Thu, Oct 11, 2007 at 08:25:32PM +0200, Andreas Henriksson wrote: > > Patch from debian iproute package. > > > > diff -urNad iproute-20060323~/ip/iplink.c iproute-20060323/ip/iplink.c > > --- iproute-20060323~/ip/iplink.c 2006-03-22

Re: [RFC/PATCH 4/4] UDP memory usage accounting (take 4): memory limitation

2007-10-11 Thread Stephen Hemminger
On Thu, 11 Oct 2007 21:51:14 +0900 Satoshi OSHIMA <[EMAIL PROTECTED]> wrote: > Hi Stephen, > > Thank you for your comment. > > >>{ > >> + .ctl_name = NET_UDP_MEM, > >> + .procname = "udp_mem", > >> + .data = &sysctl_udp_mem, > >> + .m

Re: iproute2: resend of patches from Debian.

2007-10-11 Thread Lennart Sorensen
On Thu, Oct 11, 2007 at 08:25:32PM +0200, Andreas Henriksson wrote: > Patch from debian iproute package. > > diff -urNad iproute-20060323~/ip/iplink.c iproute-20060323/ip/iplink.c > --- iproute-20060323~/ip/iplink.c 2006-03-22 00:57:50.0 +0100 > +++ iproute-20060323/ip/iplink.c 20

Re: e100 problems in .23rc8 ?

2007-10-11 Thread Eric Sandeen
Eric/David, the Fedora 8 RPM version 2.6.23-6.fc8 will have this if you want to give it a shot too. It'll be at http://people.redhat.com/davej/kernels/Fedora/f7.92/ when it's done building in an hour or so. Dave Thanks, I'll give it a whirl this evening. I put a new net card in that

iproute2: resend of patches from Debian.

2007-10-11 Thread Andreas Henriksson
Hello all! Posting this set of patches again, since there where no reaction last time I sent them. Regards, Andreas Henriksson Hello Stephen Hemminger and the rest of the people on the nevdev list! I'm posting a bunch of patches for iproute2. A few I've written myself and have a Signed-

Re: [PATCH][BNX2X] round three

2007-10-11 Thread Eliezer Tamir
On Wed, 2007-10-10 at 17:59 -0700, David Miller wrote: ... > I was going to add this to the tree for 2.6.24 but there is simply > too much super-ugly stuff in this driver for me to do so. We will rewrite bnx2x_hsi.h bnx2x_init.h and bnx2x_init_vlaues.h. Does bnx2x_asm.h look OK? > Look, there

Re: [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493, try2

2007-10-11 Thread David Stevens
Acked-by: David L Stevens <[EMAIL PROTECTED]> > > Signed-off-by: Brian Haley <[EMAIL PROTECTED]> > diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c > index 532425d..1334fc1 100644 > --- a/net/ipv6/ipv6_sockglue.c > +++ b/net/ipv6/ipv6_sockglue.c > @@ -539,12 +539,15 @@ done: >

[IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493, try2

2007-10-11 Thread Brian Haley
Hi, From RFC 3493, Section 5.2: IPV6_MULTICAST_IF Set the interface to use for outgoing multicast packets. The argument is the index of the interface to use. If the interface index is specified as zero, the system selects the interface (for example, b

Re: e100 problems in .23rc8 ?

2007-10-11 Thread Dave Jones
On Thu, Oct 11, 2007 at 09:10:34AM -0700, Kok, Auke wrote: > Herbert Xu wrote: > > On Wed, Oct 10, 2007 at 08:36:38PM -0400, Dave Jones wrote: > >> The e1000 changes you reference above, is this the changeset you mean? > >> > >> commit 416b5d10afdc797c21c457ade3714e8f2f75edd9 > >> Author: Auk

Re: [PATCH][NETNS] Make ifindex generation per-namespace

2007-10-11 Thread Eric W. Biederman
Johannes Berg <[EMAIL PROTECTED]> writes: > On Wed, 2007-10-10 at 13:51 -0600, Eric W. Biederman wrote: > >> Yes. Netlink sockets are per-namespace and you can use the namespace >> of a netlink socket to look up a netdev. > > Ok, thanks. I still haven't really looked into the wireless vs. net > n

Re: [PATCH][BNX2X] round three - sparse warnings.

2007-10-11 Thread Eliezer Tamir
On Wed, 2007-10-10 at 18:54 -0700, Stephen Hemminger wrote: > Please fix these... > Thanks, All that code is going to be rewritten, as per Dave's request, but I will make sure to test the new code with sparse. Eliezer - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH][BNX2X] round three

2007-10-11 Thread Eliezer Tamir
[added Andy Whitcroft, who is listed as a CHECKPATCH maintainer] Stephen Hemminger wrote: Minor formatting nits reported by checkpatch.pl script: Thanks, I Will fix them. ... WARNING: no space between function name and open parenthesis '(' #777: FILE: drivers/net/bnx2x.c:722: + case

[PATCH] [PPC] Compile fix for 8xx CPM Ehernet driver

2007-10-11 Thread Jochen Friedrich
Add #include for flush_dcache_range to make the driver compile again. CC arch/ppc/8xx_io/enet.o arch/ppc/8xx_io/enet.c: In function 'scc_enet_start_xmit': arch/ppc/8xx_io/enet.c:240: error: implicit declaration of function 'flush_dcache_range' make[1]: *** [arch/ppc/8xx_io/enet.o] Error 1

Re: Fwd: [PATCH#2 3/4] [PPC] Compile fix for 8xx CPM Ehernet driver

2007-10-11 Thread Jochen Friedrich
Hi Jeff, Kumar Gala wrote: Begin forwarded message: From: Jochen Friedrich <[EMAIL PROTECTED]> Date: September 24, 2007 12:15:35 PM CDT To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED], Marcelo Tosatti <[EMAIL PROTECTED]> Subject: [PATCH#2 3/4] [PPC] Compile fix for 8xx CPM Ehernet driver

Re: authenc compile warnings in current net-2.6.24

2007-10-11 Thread Oliver Hartkopp
Sebastian Siewior wrote: * David Miller | 2007-10-10 16:25:28 [-0700]: From: Sebastian Siewior <[EMAIL PROTECTED]> Date: Wed, 10 Oct 2007 21:53:37 +0200 * Oliver Hartkopp | 2007-10-10 19:53:53 [+0200]: CC [M] crypto/authenc.o crypto/authenc.c: In function ?crypto_authenc_hash

Re: [PATCH] rtnl: Simplify ASSERT_RTNL

2007-10-11 Thread Eric W. Biederman
Herbert Xu <[EMAIL PROTECTED]> writes: > Well thanks to that warning we're on our way of improving the > code that triggered it in such a way that this warning will soon > go silent. > > That's precisely the reason why I object to having this warning > removed. Now you have a good point that this

Re: [PATCH]race between open and disconnect in irda-usb

2007-10-11 Thread Jean Tourrilhes
On Thu, Oct 11, 2007 at 05:45:28PM +0200, Oliver Neukum wrote: > Hi, > Hi, You need to cc Samuel Ortiz and the IrDA mailing list if you want any meaningful response. > it seems to me that irda_usb_net_open() must set self->netopen > under spinlock or disconnect() may fail to kil

  1   2   >