Re: RE: is it useful testing __LINK_STATE_RX_SCHED in dev_close()?

2007-11-21 Thread Herbert Xu
On Wed, Nov 21, 2007 at 03:09:52PM +0800, [EMAIL PROTECTED] wrote: > > __LINK_STATE_RX_SCHED still exist in kernel 2.6.23.8. You'll find that it's gone in 2.6.24-rc3. In any case, the code was racy but it's too unlikely (and the fix too intrusive) to be worth fixing in 2.6.23 at this stage. T

Re: 2.6.24-rc3: find complains about /proc/net

2007-11-21 Thread Pavel Emelyanov
Eric W. Biederman wrote: > Below is a preliminary patch. It solves the directory issue but it doesn't > play well with proc_mnt and proc_flush_task. It works by simply caching the > network namespace when we mount proc so we don't have to be fancy and dynamic. Nice... Where should we apply this

Re: HTB/HSFC shaping precision

2007-11-21 Thread Jarek Poplawski
On 20-11-2007 22:21, Denys Fedoryshchenko wrote: ... > If traffic is dropped - it will be resent, a lot of energy will be wasted for > nothing. Same bytes will pass all long way around earth just because i am not > able to manage my QoS box :-) Sure, but you'll use probably almost every bit you'

[RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread Ryousei Takano
This patch includes the PSPacer (Precise Software Pacer) qdisc module, which achieves precise transmission bandwidth control. You can find more information at the project web page (http://www.gridmpi.org/gridtcp.jsp). Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]> --- include/linux/pkt_sched.h

[RFC][PATCH 2/3] TC: PSPacer qdisc module

2007-11-21 Thread Ryousei Takano
This patch includes the PSPacer (Precise Software Pacer) qdisc tc part, which achieves precise transmission bandwidth control. You can find more information at the project web page (http://www.gridmpi.org/gridtcp.jsp). Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]> --- include/linux/pkt_sched.

[RFC][PATCH 3/3] TC: PSPacer man page

2007-11-21 Thread Ryousei Takano
This patch includes the man page of the PSPacer (Precise Software Pacing) qdisc module. Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]> --- man/man8/tc-psp.8 | 166 + 1 files changed, 166 insertions(+), 0 deletions(-) create mode 100644 man/

Re: HTB/HSFC shaping precision

2007-11-21 Thread Denys Fedoryshchenko
On Wed, 21 Nov 2007 10:47:10 +0100, Jarek Poplawski wrote > > But, if you have full control on your side, it looks like a kind of > realtime traffic, and then HFSC should be more appropriate for this > (but I only 'heard' about this). One message later, thats what i dreamed about :-) Subject: [RF

Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread Patrick McHardy
Ryousei Takano wrote: This patch includes the PSPacer (Precise Software Pacer) qdisc module, which achieves precise transmission bandwidth control. You can find more information at the project web page (http://www.gridmpi.org/gridtcp.jsp). Looks good, but please run checkpatch over it. A few m

[PATCH] Add packet filtering based on process's security context.

2007-11-21 Thread Tetsuo Handa
Hello. This patch comes from a thread at http://lkml.org/lkml/2007/11/16/155 . I want to use IP/port based access control for incoming connections/datagrams. This idea was discussed for several times, but there is no approach that satisfies both "it can decide based on the recipient's process"

[RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread Jeff Garzik
SO_NO_CHECK support for IPv6 appeared to be missing. This is presented, based on a reading of net/ipv4/udp.c. I wonder if IPv4's CHECKSUM_PARTIAL check from udp_push_pending_frames() also needs to be copied to IPv6? Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- net/ipv6/udp.c | 10 ++

[PATCH] amd8111e: don't call napi_enable if configured w/o NAPI

2007-11-21 Thread Jiri Bohac
The amd8111e network driver was broken by bea3348eef27e6044b6161fd04c3152215f96411, which makes the driver call napi_enable() and napi_disable() even if the driver had been configured without CONFIG_AMD8111E_NAPI, and thus netif_napi_add() had not been called on initialization. This triggers a BU

Re: ZD1211RW unaligned accesses...

2007-11-21 Thread Shaddy Baddah
Hi David, David Miller wrote: Shaddy I attach a hack patch that you can use which should get rid of the warnings. It hasn't seemed to. I patched the source (confirming the patched lines are in), compiled, installed and rebooted to effect the changes. My zd1211rw modules timestamp indicates t

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 21 Nov 2007 07:45:32 -0500), Jeff Garzik <[EMAIL PROTECTED]> says: > > SO_NO_CHECK support for IPv6 appeared to be missing. This is presented, > based on a reading of net/ipv4/udp.c. Disagree. UDP checksum is mandatory in IPv6. --yoshfuji - To unsubscrib

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread Herbert Xu
On Wed, Nov 21, 2007 at 01:20:51PM +, YOSHIFUJI Hideaki / 吉藤英明 wrote: > In article <[EMAIL PROTECTED]> (at Wed, 21 Nov 2007 07:45:32 -0500), Jeff > Garzik <[EMAIL PROTECTED]> says: > > > > > SO_NO_CHECK support for IPv6 appeared to be missing. This is presented, > > based on a reading of net

[PATCH] dm9000 - fix spinlock issue, updated

2007-11-21 Thread dmitry pervushin
The patch below fixes the problem with dm9000_timeout function: it calls dm9000_init under the spin_lock db->lock, which was going to be acquired again in dm9000_hash_table. From the other hand, dm9000_hash_table has to be called with db->lock held Signed-off-by: dmitry pervushin <[EMAIL PROTECTED

Re: [PATCH 1/2] [LIB]: Introduce struct pcounter

2007-11-21 Thread Herbert Xu
On Wed, Nov 07, 2007 at 04:16:15PM +, Arnaldo Carvalho de Melo wrote: > This just generalises what was introduced by Eric Dumazet for the struct proto > inuse field in 286ab3d46058840d68e5d7d52e316c1f7e98c59f: > > [NET]: Define infrastructure to keep 'inuse' changes in an efficent > SMP/N

[PATCH] smc911x: Fix unused variable warning.

2007-11-21 Thread Peter Korsgaard
The smc911x_local pointer in smc911x_rcv is only used in the SMC_USE_DMA case. Move it under the #ifdef so GCC doesn't generate a warning in the non-DMA case. --- drivers/net/smc911x.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc

[PATCH] smc911x: Fix undefined CONFIG_ symbol warning

2007-11-21 Thread Peter Korsgaard
elif defined(CONFIG_*) should be used instead of elif CONFIG_* so GCC doesn't give warnings about undefined symbols when the config option is disabled. --- drivers/net/smc911x.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/smc911x.h b/drivers/net/smc911x.h

[PATCH] smc911x: Fix undefined CONFIG_ symbol warning

2007-11-21 Thread Peter Korsgaard
elif defined(CONFIG_*) should be used instead of elif CONFIG_* so GCC doesn't give warnings about undefined symbols when the config option is disabled. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- Sigh, forgot --signoff :/ drivers/net/smc911x.h |2 +- 1 files changed, 1 insertions(

[PATCH] smc911x: Fix unused variable warning.

2007-11-21 Thread Peter Korsgaard
The smc911x_local pointer in smc911x_rcv is only used in the SMC_USE_DMA case. Move it under the #ifdef so GCC doesn't generate a warning in the non-DMA case. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/smc911x.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: HTB/HSFC shaping precision

2007-11-21 Thread jamal
On Wed, 2007-21-11 at 12:31 +0200, Denys Fedoryshchenko wrote: > On Wed, 21 Nov 2007 10:47:10 +0100, Jarek Poplawski wrote > > > > But, if you have full control on your side, it looks like a kind of > > realtime traffic, and then HFSC should be more appropriate for this > > (but I only 'heard' abo

Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread jamal
On Wed, 2007-21-11 at 19:18 +0900, Ryousei Takano wrote: > This patch includes the PSPacer (Precise Software Pacer) qdisc > module, which achieves precise transmission bandwidth control. > You can find more information at the project web page > (http://www.gridmpi.org/gridtcp.jsp). Good stuff. I h

Re: [PATCH 1/8] ibm_newemac: Fix possible lockup on close

2007-11-21 Thread Christoph Hellwig
On Wed, Nov 21, 2007 at 05:06:39PM +1100, Benjamin Herrenschmidt wrote: > It's a bad idea to call flush_scheduled_work from within a > netdev->stop because the linkwatch will occasionally take the > rtnl lock from a workqueue context, and thus that can deadlock. > > This reworks things a bit in th

Re: [PATCH 1/8] ibm_newemac: Fix possible lockup on close

2007-11-21 Thread Josh Boyer
On Wed, 21 Nov 2007 16:41:23 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Wed, Nov 21, 2007 at 05:06:39PM +1100, Benjamin Herrenschmidt wrote: > > It's a bad idea to call flush_scheduled_work from within a > > netdev->stop because the linkwatch will occasionally take the > > rtnl lock f

Re: [PATCHv6 0/3] Interface group patches

2007-11-21 Thread Balazs Scheidler
On Wed, 2007-11-21 at 01:25 +0100, Patrick McHardy wrote: > David Miller wrote: > > From: Laszlo Attila Toth <[EMAIL PROTECTED]> > > Date: Tue, 20 Nov 2007 14:52:12 +0100 > > > >> Jan Engelhardt írta: > >>> On Nov 20 2007 14:14, Laszlo Attila Toth wrote: > This is the 6th version of our inte

Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread Eric Dumazet
Ryousei Takano a écrit : This patch includes the PSPacer (Precise Software Pacer) qdisc module, which achieves precise transmission bandwidth control. You can find more information at the project web page (http://www.gridmpi.org/gridtcp.jsp). Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]>

[RFC PATCH 0/2]: TCP MTUprobe fixes

2007-11-21 Thread Ilpo Järvinen
Hi all, Here are two other things in MTU probe code that caught my attention while attempting to figure out the sk_send_head usage there (sent patch to that earlier). The latter here is not strictly speaking a fix but the original code has striking complexity to perform a query which

[RFC PATCH 2/2] [TCP] MTUprobe: Cleanup send queue check (no need to loop)

2007-11-21 Thread Ilpo Järvinen
The original code has striking complexity to perform a query which can be reduced to a very simple compare. FIN seqno may be included to write_seq but it should not make any significant difference here compared to skb->len which was used previously. One won't end up there with SYN still queued. U

[RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & data available checks fixed

2007-11-21 Thread Ilpo Järvinen
It seems that the checked range for receiver window check should begin from the first rather than from the last skb that is going to be included to the probe. And that can be achieved without reference to skbs at all, snd_nxt and write_seq provides the correct seqno already. Plus, it SHOULD account

[PATCH][IRDA] Compilation for CONFIG_INET=n case

2007-11-21 Thread Pavel Emelyanov
Found this occasionally. The CONFIG_INET=n is hardly ever set, but if it is the irlan_eth_send_gratuitous_arp() compilation should produce a warning about unused variable in_dev. Too pedantic? :) Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/irda/irlan/irlan_eth.c

Re: [RFC PATCH 2/2] [TCP] MTUprobe: Cleanup send queue check (no need to loop)

2007-11-21 Thread John Heffner
Ilpo Järvinen wrote: The original code has striking complexity to perform a query which can be reduced to a very simple compare. FIN seqno may be included to write_seq but it should not make any significant difference here compared to skb->len which was used previously. One won't end up there wi

Re: [RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & data available checks fixed

2007-11-21 Thread John Heffner
Ilpo Järvinen wrote: It seems that the checked range for receiver window check should begin from the first rather than from the last skb that is going to be included to the probe. And that can be achieved without reference to skbs at all, snd_nxt and write_seq provides the correct seqno already.

[PATCH 2/2][2.6.24] ehea: Reworked rcv queue handling to log only fatal errors

2007-11-21 Thread Thomas Klein
Prevent driver from brawly logging packet checksum errors. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c | 11 +-- drivers/net/ehea/ehea_qmr.h |4 ++-- 3 files changed, 8 insertions(+), 9 deletions(-) diff

[PATCH 1/2][2.6.24] ehea: Improve tx packets counting

2007-11-21 Thread Thomas Klein
Using own tx_packets counter instead of firmware counters. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |9 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ehea/ehea.h b/drivers/n

Re: [PATCH,RFC] ep93xx_eth: conversion to phylib framework

2007-11-21 Thread Andy Fleming
On Nov 16, 2007, at 03:38, Herbert Valerio Riedel wrote: Currently, the ep93xx_eth driver doesn't care about the PHY state, but it should, in order to tell the MAC when full duplex operation is required; failure to do so causes degraded performance on full duplex links. This patch implements pr

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-11-21 Thread Anil Veerabhadrappa
> >> The sysfs bits related to the hba should be use one of the scsi sysfs > >> facilities or if they are related to iscsi bits and are generic then > >> through the iscsi hba > > > > bnx2i needs 2 sysfs entries - > > 1. QP size info - this is used to size per connection shared data > > structu

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-11-21 Thread James Smart
Anil Veerabhadrappa wrote: It's a chicken & egg issue to put "port mapper" sysfs entry in scsi host attributes. Application won't see sysfs unless initiator creates an iSCSI session and driver can't create an iSCSI session without a tcp port. I was wondering if there is a better way than using I

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed, 21 Nov 2007 07:45:32 -0500 > > SO_NO_CHECK support for IPv6 appeared to be missing. This is presented, > based on a reading of net/ipv4/udp.c. > > I wonder if IPv4's CHECKSUM_PARTIAL check from udp_push_pending_frames() > also needs to be copied t

Re: Routing tables associated with VLANs dissappear when parent ethX down/up

2007-11-21 Thread Ben Greear
For consideration, this patch seems to work for me. I'm not sure why we ever listed to these events. I've only tested on a NIC that doesn't support hw-accel at the moment..will test with e1000 later. Thanks, Ben -- Ben Greear <[EMAIL PROTECTED]> Candela Technologies Inc http://www.candelatech

[PATCH] cassini: NAPI configuration

2007-11-21 Thread Stephen Hemminger
The Cassini driver has NAPI support, but it not possible to configure it. Compile tested only, no idea if it works (no hardware). Get rid of warning from lefover variable in now visible code. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/Kconfig 2007-11-19 18:56:12.

Re: [PATCH 1/8] ibm_newemac: Fix possible lockup on close

2007-11-21 Thread Benjamin Herrenschmidt
On Wed, 2007-11-21 at 16:41 +0100, Christoph Hellwig wrote: > On Wed, Nov 21, 2007 at 05:06:39PM +1100, Benjamin Herrenschmidt wrote: > > It's a bad idea to call flush_scheduled_work from within a > > netdev->stop because the linkwatch will occasionally take the > > rtnl lock from a workqueue cont

Re: Routing tables associated with VLANs dissappear when parent ethX down/up

2007-11-21 Thread Stephen Hemminger
On Wed, 21 Nov 2007 11:51:43 -0800 Ben Greear <[EMAIL PROTECTED]> wrote: > For consideration, this patch seems to work for me. I'm not sure > why we ever listed to these events. I've only tested on a NIC that > doesn't support hw-accel at the moment..will test with e1000 later. > > Thanks, > Be

Re: Routing tables associated with VLANs dissappear when parent ethX down/up

2007-11-21 Thread Patrick McHardy
Stephen Hemminger wrote: On Wed, 21 Nov 2007 11:51:43 -0800 Ben Greear <[EMAIL PROTECTED]> wrote: For consideration, this patch seems to work for me. I'm not sure why we ever listed to these events. I've only tested on a NIC that doesn't support hw-accel at the moment..will test with e1000

Re: Routing tables associated with VLANs dissappear when parent ethX down/up

2007-11-21 Thread Ben Greear
Patrick McHardy wrote: Stephen Hemminger wrote: On Wed, 21 Nov 2007 11:51:43 -0800 Ben Greear <[EMAIL PROTECTED]> wrote: For consideration, this patch seems to work for me. I'm not sure why we ever listed to these events. I've only tested on a NIC that doesn't support hw-accel at the momen

Re: Routing tables associated with VLANs dissappear when parent ethX down/up

2007-11-21 Thread Patrick McHardy
Ben Greear wrote: Patrick McHardy wrote: Stephen Hemminger wrote: But then if you are doing bonding or bridging of vlan's and you bring down the root network device, the upper layer is not notified (for failover). operstate should be enough for this I guess. Ben, what does iproute show

Missing audit information in xfrm_audit_common_policyinfo()?

2007-11-21 Thread Paul Moore
I just noticed that the IPsec auditing code does not appear to audit the netmask for the selector source and destination addresses in xfrm_audit_common_policyinfo(). Before I threw a patch together I thought I would check to see if there was a reason for this that I am missing ... -- paul moo

Re: Routing tables associated with VLANs dissappear when parent ethX down/up

2007-11-21 Thread Ben Greear
Patrick McHardy wrote: Ben Greear wrote: Patrick McHardy wrote: Stephen Hemminger wrote: But then if you are doing bonding or bridging of vlan's and you bring down the root network device, the upper layer is not notified (for failover). operstate should be enough for this I guess. Ben,

Inconsistent lock state and possible irq lock inversion dependency detected in ax25.ko

2007-11-21 Thread Bernard Pidoux
Hi, I am practicing intensively AX25 packet radio that uses ax25.ko together with mkiss, crc16, netrom, and rose modules using two PIII CPU Linux machines with 2.6.23.8 kernel. On the first Linux machine I did not validate kernel hacking and AX25 applications are running 100% of the time wit

Re: BUG: skge ethernet breakage (PCI: Unable to reserve mem region)

2007-11-21 Thread Stephen Hemminger
On Wed, 19 Sep 2007 22:57:49 +0200 Jan Gukelberger <[EMAIL PROTECTED]> wrote: > Hi, > > seems as if there are currently no more ideas? > > So shall I perhaps open a bug in Kernel Bugzilla? > > Thanks, > Jan > > On Tue, 2007-09-11 at 15:39 +0200, Jan Gukelberger wrote: > > On Tue, 2007-09-11 at

Re: Routing tables associated with VLANs dissappear when parent ethX down/up

2007-11-21 Thread Patrick McHardy
Ben Greear wrote: Patrick McHardy wrote: That comes from iproute itself, but the missing LOWER-UP flag indicates it and that should be enough for bridging and bonding. I'm unsure about this though since its still a big difference in userspace visible behaviour, people might just as well manuall

[PATCH] sky2: disable rx checksum on Yukon XL

2007-11-21 Thread Stephen Hemminger
The Marvell Yukon XL chipset appears to have a hardware glitch where it will repeat the checksum of the last packet. Of course, this is timing sensitive and only happens sometimes... More info: http://bugzilla.kernel.org/show_bug.cgi?id=9381 As a workaround just disable hardware checksumming by d

[patch 3/4] tlan list is subscribers-only

2007-11-21 Thread akpm
From: Gabriel C <[EMAIL PROTECTED]> Your mail to 'Tlan-devel' with the subject drivers/net/tlan question Is being held until the list moderator can review it for approval. The reason it is being held: Post by non-member to a members-only list Signed-off-by: Gabriel Craciunescu <[EMAIL

[patch 4/4] Net: sunrpc, remove SPIN_LOCK_UNLOCKED

2007-11-21 Thread akpm
From: Jiri Slaby <[EMAIL PROTECTED]> sunrpc, remove SPIN_LOCK_UNLOCKED SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- net/sunrpc/xprt.c |

[patch 1/4] pfkey: sending an SADB_GET responds with an SADB_GET

2007-11-21 Thread akpm
From: Charles Hardin <[EMAIL PROTECTED]> Kernel needs to respond to an SADB_GET with the same message type to conform to the RFC 2367 Section 3.1.5 Cc: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- net/key/af_key.c |2 +- 1 file changed, 1 insert

[patch 2/4] make sunrpc/xprtsock.c:xs_setup_{udp,tcp}() static

2007-11-21 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> xs_setup_{udp,tcp}() can now become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- include/linux/sunrpc/xprtsock.h |6 -- net/sunrpc/xprtsock.c |4 ++-- 2 files changed, 2 in

[patch 5/8] pcmcia net: use roundup_pow_of_two() macro instead of grotesque loop

2007-11-21 Thread akpm
From: "Robert P. J. Day" <[EMAIL PROTECTED]> Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Dominik Brodowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/pcmcia/pcnet_cs.c |4 ++-- 1 file changed, 2 inserti

[patch 8/8] forcedeth boot delay fix

2007-11-21 Thread akpm
From: Ayaz Abdulla <[EMAIL PROTECTED]> Fix a long boot delay in the forcedeth driver. During initialization, the timeout for the handshake between mgmt unit and driver can be very long. The patch reduces the timeout by eliminating a extra loop around the timeout logic. Addresses http://bugzilla

[patch 3/8] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

2007-11-21 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Cc: Emil Medve <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Kumar Gala <[EMAIL PROTECTED]> Cc: Li Yang <[EMAIL PROTECTED]> Cc: Paul Mackerras <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PR

[patch 4/8] drivers/net/chelsio/: #if 0 unused functions

2007-11-21 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch #if 0's the following unused functions: - espi.c:t1_espi_set_misc_ctrl() - sge.c:t1_sched_set_max_avail_bytes() - sge.c:t1_sched_set_drain_bits_per_us() Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-b

[patch 2/8] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2007-11-21 Thread akpm
From: Michael Pyne <[EMAIL PROTECTED]> Partially revert a change to mac address detection introduced to the forcedeth driver. The change was intended to correct mac address detection for newer nVidia chipsets where the mac address was stored in reverse order. One of those chipsets appears to sti

[patch 7/8] Net: ibm_newemac, remove SPIN_LOCK_UNLOCKED

2007-11-21 Thread akpm
From: Jiri Slaby <[EMAIL PROTECTED]> SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/debug.c |2 +- 1 file changed, 1

[patch 6/8] forcedeth: new mcp79 device ids

2007-11-21 Thread akpm
From: Ayaz Abdulla <[EMAIL PROTECTED]> Add new device ids and features for mcp79 devices into the forcedeth driver. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Manfred Spraul <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMA

[patch 2/5] bluetooth: uninlining

2007-11-21 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> Remove all those inlines which were either a) unneeded or b) increased code size. textdata bss dec hex filename before: 6997 74 870791ba7 net/bluetooth/hidp/core.o after:6492 74 8657419ae

[patch 1/5] bluetooth: hidp_process_hid_control remove unnecessary parameter dealing

2007-11-21 Thread akpm
From: Dave Young <[EMAIL PROTECTED]> According to the bluetooth HID spec v1.0 chapter 7.4.2 "This code requests a major state change in a BT-HID device. A HID_CONTROL request does not generate a HANDSHAKE response." "A HID_CONTROL packet with a parameter of VIRTUAL_CABLE_UNPLUG is the only HID_

[patch 5/5] bluetooth: blacklist another Broadcom BCM2035 device

2007-11-21 Thread akpm
From: Andy Shevchenko <[EMAIL PROTECTED]> This device is recognized as bluetooth, but still not works. Signed-off-by: Andy Shevchenko <[EMAIL PROTECTED]> Cc: Marcel Holtmann <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/bluetooth/hci_usb.c |1 + 1 file cha

[patch 4/5] drivers/bluetooth/btsdio.c: fix double-free

2007-11-21 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch fixes a double-free spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/bluetooth/btsdio.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[patch 3/5] drivers/bluetooth/bpa10x.c: fix memleak

2007-11-21 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch fixea a memleak spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/bluetooth/bpa10x.c |1 + 1 file changed, 1 insertion(+) diff -puN drivers/bluetooth/

[PATCH] napi: conditional NAPI in drivers

2007-11-21 Thread Stephen Hemminger
There has been a pattern of bugs in the 2.6.24 conversion where a driver is broken if NAPI is not configured. Change all drivers that have conditional NAPI option to have the datastructure missing so these bugs are caught at compile time. Compile tested only (but that's the point). Signed-off-by

[patch 1/8] forcedeth: power down phy when interface is down

2007-11-21 Thread akpm
From: "Ed Swierk" <[EMAIL PROTECTED]> Bring the physical link down when the interface is down by placing the PHY in power-down state, unless WOL is enabled. This mirrors the behavior of other drivers including e1000 and tg3. Signed-off-by: Ed Swierk <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PR

Re: [PATCH 4/5] udp: memory limitation by using udp_mem

2007-11-21 Thread Hideo AOKI
David Miller wrote: > From: Hideo AOKI <[EMAIL PROTECTED]> > Date: Thu, 15 Nov 2007 16:50:14 -0500 > >> +static inline int __ip_check_max_skb_pages(struct sock *sk, int size) >> +{ >> +switch(sk->sk_protocol) { >> +case IPPROTO_UDP: >> +if (atomic_read(sk->sk_prot->memory_alloc

RE: [patch 2/8] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2007-11-21 Thread Ayaz Abdulla
The solution is to get the OEM to update their BIOS (instead of integrating this patch) since the MCP61 specs indicate that the MAC Address should be in correct order from BIOS. By changing the feature DEV_HAS_CORRECT_MACADDR to all MCP61 boards, it could cause it to break on other OEM systems who

Re: [patch 2/8] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2007-11-21 Thread Andrew Morton
On Wed, 21 Nov 2007 15:34:52 -0800 "Ayaz Abdulla" <[EMAIL PROTECTED]> wrote: > The solution is to get the OEM to update their BIOS (instead of > integrating this patch) since the MCP61 specs indicate that the MAC > Address should be in correct order from BIOS. > > By changing the feature DEV_HAS_

Re: [patch 2/8] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2007-11-21 Thread Michael Pyne
On Wednesday 21 November 2007, Andrew Morton wrote: > On Wed, 21 Nov 2007 15:34:52 -0800 > > "Ayaz Abdulla" <[EMAIL PROTECTED]> wrote: > > The solution is to get the OEM to update their BIOS (instead of > > integrating this patch) since the MCP61 specs indicate that the MAC > > Address should be in

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread Jeff Garzik
YOSHIFUJI Hideaki / 吉藤英明 wrote: In article <[EMAIL PROTECTED]> (at Wed, 21 Nov 2007 07:45:32 -0500), Jeff Garzik <[EMAIL PROTECTED]> says: SO_NO_CHECK support for IPv6 appeared to be missing. This is presented, based on a reading of net/ipv4/udp.c. Disagree. UDP checksum is mandatory in IPv6

Re: [patch 2/8] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2007-11-21 Thread Jesper Juhl
On 22/11/2007, Michael Pyne <[EMAIL PROTECTED]> wrote: > On Wednesday 21 November 2007, Andrew Morton wrote: > > On Wed, 21 Nov 2007 15:34:52 -0800 > > > > "Ayaz Abdulla" <[EMAIL PROTECTED]> wrote: > > > The solution is to get the OEM to update their BIOS (instead of > > > integrating this patch) s

Re: HTB/HSFC shaping precision

2007-11-21 Thread Ryousei Takano
Hi jamal and denys, > > One message later, thats what i dreamed about :-) > > Subject: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module > > On website they have very good explanation... > > http://www.gridmpi.org/gridtcp.jsp > > That looks interesting - without reading the papers a few questions a

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread Herbert Xu
On Wed, Nov 21, 2007 at 07:17:40PM -0500, Jeff Garzik wrote: > > For those interested, I am dealing with a UDP app that already does very > strong checksumming and encryption, so additional software checksumming > at the lower layers is quite simply a waste of CPU cycles. Hardware > checksummin

[PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-21 Thread Andi Kleen
There seems to be rough consensus that the kernel currently has too many exported symbols. A lot of these exports are generally usable utility functions or important driver interfaces; but another large part are functions intended by only one or two very specific modules for a very specific purp

[PATCH RFC] [2/9] Fix duplicate symbol check to also check future gpl and unused symbols

2007-11-21 Thread Andi Kleen
This seems to have been forgotten earlier. Right now it was possible for a normal symbol to override a future gpl symbol and similar. I restructured the code a bit to avoid too much duplicated code. --- kernel/module.c | 45 - 1 file changed, 24 inse

[PATCH RFC] [4/9] modpost: Fix format string warnings

2007-11-21 Thread Andi Kleen
Fix wrong format strings in modpost exposed by the previous patch. Including one missing argument -- some random data was printed instead. --- scripts/mod/modpost.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Index: linux/scripts/mod/modpost.c ===

[PATCH RFC] [5/9] modpost: Fix a buffer overflow in modpost

2007-11-21 Thread Andi Kleen
When passing an file name > 1k the stack could be overflowed. Not really a security issue, but still better plugged. --- scripts/mod/modpost.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux/scripts/mod/modpost.c =

[PATCH RFC] [6/9] Implement namespace checking in modpost

2007-11-21 Thread Andi Kleen
This checks the namespaces at build time in modpost --- scripts/mod/modpost.c | 344 ++ 1 file changed, 317 insertions(+), 27 deletions(-) Index: linux/scripts/mod/modpost.c === ---

[PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-11-21 Thread Andi Kleen
This way gcc can warn for wrong format strings --- scripts/mod/modpost.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: linux/scripts/mod/modpost.c === --- linux.orig/scripts/mod/modpost.c +++ linux/scripts

[PATCH RFC] [9/9] Add a inet namespace

2007-11-21 Thread Andi Kleen
Shared by IP, IPv6, DCCP, UDPLITE, SCTP. The symbols used by tunnel modules weren't put into any name space because there are quite a lot of them. --- net/core/fib_rules.c|9 -- net/ipv4/af_inet.c | 52 net/ipv4/arp.c

[PATCH RFC] [8/9] Put UDP exports into a namespace

2007-11-21 Thread Andi Kleen
The UDP exports are only used by UDPv6 and UDP lite. They are internal functions not supposed to be used by anybody else. So turn them into a name space that only allows those. --- net/ipv4/udp.c | 27 +++ net/ipv4/udplite.c |6 +++--- 2 files changed, 18 inser

[PATCH RFC] [7/9] Convert TCP exports into namespaces

2007-11-21 Thread Andi Kleen
I defined two namespaces: tcp for TCP internals which are only used by tcp_ipv6.ko And tcpcong for exports used by the TCP congestion modules No need to export any TCP internals to anybody else. So express this in a namespace. I admit I'm not 100% sure tcpcong makes sense -- there might be a l

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 22 Nov 2007 10:34:03 +0800), Herbert Xu <[EMAIL PROTECTED]> says: > On Wed, Nov 21, 2007 at 07:17:40PM -0500, Jeff Garzik wrote: > > > > For those interested, I am dealing with a UDP app that already does very > > strong checksumming and encryption, so add

Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread Ryousei Takano
Hi jamal, > Good stuff. > I have not read your paper - There are NICs out there (chelsio comes to > mind) which claim to do pacing and have shown impressive numbers with > TCP. Is your approach similar? Are there patents involved by some of > these hardware vendors? (It would not be suprising if t

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-21 Thread Arjan van de Ven
On Thu, 22 Nov 2007 03:43:06 +0100 (CET) Andi Kleen <[EMAIL PROTECTED]> wrote: > > There seems to be rough consensus that the kernel currently has too > many exported symbols. A lot of these exports are generally usable > utility functions or important driver interfaces; but another large > part

Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread TAKANO Ryousei
I am sorry I send an unfinished mail. > > Also, the idea of using a PAUSE frame to add gaps is interesting, but > > you should note that in linux a qdisc may be attached to any network > > device and this for example maybe a PPP device etc. What would you use > > for gaps in that case? > You are

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-21 Thread Andi Kleen
> I like this concept in general; I have one minor comment; right now > your namespace argument is like > > EXPORT_SYMBOL_NS(foo, some_symbol); > > from a language-like pov I kinda wonder if it's nicer to do > > EXPORT_SYMBOL_NS("foo", some_symbol); > > because foo isn't something in C scope,

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-21 Thread Dave Jones
On Thu, Nov 22, 2007 at 03:43:06AM +0100, Andi Kleen wrote: > There seems to be rough consensus that the kernel currently has too many > exported symbols. A lot of these exports are generally usable utility > functions or important driver interfaces; but another large part are > functions

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-21 Thread Rusty Russell
On Thursday 22 November 2007 13:43:06 Andi Kleen wrote: > There seems to be rough consensus that the kernel currently has too many > exported symbols. A lot of these exports are generally usable utility > functions or important driver interfaces; but another large part are > functions intended by o

Re: [README] away until Dec 3rd

2007-11-21 Thread Herbert Xu
On Tue, Nov 20, 2007 at 08:29:21PM -0800, David Miller wrote: > > During this time Herbert Xu (CC:'d) will take care of both the net-2.6 > stable tree and the net-2.6.25 devel tree. For this duration please use the net-2.6.25 tree at this location for basing your patches: git://git.kernel.org/pu

[RFC][PATCH 0/3] PSPacer qdisc module

2007-11-21 Thread Ryousei Takano
Hi all, I sent this mail yesterday, but it did not be delivered. So I resend it. I am sorry if you receive duplicate mails. What is PSPacer? PSPacer (Precise Software Pacer) is a qdisc module which realizes precise transmission bandwidth control. It makes bursty traffic which is often generate

[RFC][PATCH] bonding layer2+3 xmit_hash_policy

2007-11-21 Thread Glenn Griffin
I posted this 2 weeks ago on the bonding-devel list, but didn't receive any feedback so thought I would bring it up to a larger audience. Included is a patch for a new xmit_hash_policy for the bonding driver that selects slaves based on MAC and IP information. This is a middle ground between what