[PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread sfeldma
From: Scott Feldman Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged port does not support switchdec_port_attr_set op. Don't BUG() if -EOPNOTSUPP is returned. Signed-off-by: Scott Feldman Reported-by: Brenden Blanco --- net/switchdev/switchdev.c |2 +- 1 file ch

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread Andy Gospodarek
On Wed, Jun 10, 2015 at 01:56:02PM -0700, sfel...@gmail.com wrote: > From: Scott Feldman > > Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged > port does not support switchdec_port_attr_set op. Don't BUG() if > -EOPNOTSUPP is returned. > > Signed-off-by: Scott Feldman

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread David Ahern
On 6/10/15 2:56 PM, sfel...@gmail.com wrote: From: Scott Feldman Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged port does not support switchdec_port_attr_set op. Don't BUG() if -EOPNOTSUPP is returned. Signed-off-by: Scott Feldman Reported-by: Brenden Blanco ---

Re: Weird DHCP related problems with net-next

2015-06-10 Thread Scott Feldman
On Tue, Jun 9, 2015 at 5:12 PM, Florian Fainelli wrote: > I see the problem now, DSA does not implement a port_obj_add callback, > so when net/ipv4/fib_trie.c::switchdev_fib_ipv4_add() gets to call > switchdev_port_obj_add, we return -EOPNOTSUPP, and take the error path > in fib_table_insert thu

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 2:25 PM, David Ahern wrote: > On 6/10/15 2:56 PM, sfel...@gmail.com wrote: >> >> From: Scott Feldman >> >> Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged >> port does not support switchdec_port_attr_set op. Don't BUG() if >> -EOPNOTSUPP is retu

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread David Ahern
On 6/10/15 3:47 PM, Scott Feldman wrote: Should that be WARN_ON instead of BUG_ON? I think I had it as WARN when we were working on the initial patches, but we changed it to BUG_ON because we should only get an error here if the driver screwed something up between PREPARE phase and COMMIT phase

Re: [PATCH v3] ipv6: Fix protocol resubmission

2015-06-10 Thread Josh Hunt
On 06/10/2015 10:16 AM, YOSHIFUJI Hideaki wrote: Hi, Josh Hunt wrote: On 06/09/2015 11:24 PM, Hajime Tazaki wrote: Hello Josh, Dave, my mobile ipv6 test on libos failed with this commit. This commit makes a destination option header handling (i.e., ipprot->handler == ipv6_destopt_rcv) faile

Re: /net/mpls/conf/ethX//input duplicate entry

2015-06-10 Thread roopa
On 6/10/15, 1:43 PM, Scott Feldman wrote: I'm getting this dump_stack when reloading rocker driver. Did some sysctl MPLS nodes not get cleaned up on NETDEV_UNREGISTER? Steps to repro: load rocker (on system) with rocker device, rmmod rocker, and then modprobe rocker. I doubt this is specific t

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 2:47 PM, Scott Feldman wrote: > On Wed, Jun 10, 2015 at 2:25 PM, David Ahern wrote: >> On 6/10/15 2:56 PM, sfel...@gmail.com wrote: >>> >>> From: Scott Feldman >>> >>> Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged >>> port does not support swi

[PATCH v6 1/2] Renesas Ethernet AVB driver proper

2015-06-10 Thread Sergei Shtylyov
Ethernet AVB includes an Gigabit Ethernet controller (E-MAC) that is basically compatible with SuperH Gigabit Ethernet E-MAC. Ethernet AVB has a dedicated direct memory access controller (AVB-DMAC) that is a new design compared to the SuperH E-DMAC. The AVB-DMAC is compliant with 3 standards for

[PATCH v6 2/2] Renesas Ethernet AVB PTP clock driver

2015-06-10 Thread Sergei Shtylyov
Ethernet AVB device includes the gPTP timer, so we can implement a PTP clock driver. We're doing that in a separate file, with the main Ethernet driver calling the PTP driver's [de]initialization and interrupt handler functions. Unfortunately, the clock seems tightly coupled with the AVB-DMAC, s

Re: Weird DHCP related problems with net-next

2015-06-10 Thread Florian Fainelli
On 10/06/15 14:44, Scott Feldman wrote: > On Tue, Jun 9, 2015 at 5:12 PM, Florian Fainelli wrote: > > >> I see the problem now, DSA does not implement a port_obj_add callback, >> so when net/ipv4/fib_trie.c::switchdev_fib_ipv4_add() gets to call >> switchdev_port_obj_add, we return -EOPNOTSUPP,

Re: [PATCH v3] ipv6: Fix protocol resubmission

2015-06-10 Thread David Miller
From: Josh Hunt Date: Wed, 10 Jun 2015 16:57:25 -0500 > Can you please revert this change? > > commit 0243508edd317ff1fa63b495643a7c192fbfcd92 > Author: Josh Hunt > Date: Mon Jun 8 12:00:59 2015 -0400 > > ipv6: Fix protocol resubmission Done, thanks. -- To unsubscribe from this list: se

Re: /net/mpls/conf/ethX//input duplicate entry

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 2:58 PM, roopa wrote: > On 6/10/15, 1:43 PM, Scott Feldman wrote: >> >> I'm getting this dump_stack when reloading rocker driver. Did some >> sysctl MPLS nodes not get cleaned up on NETDEV_UNREGISTER? >> >> Steps to repro: load rocker (on system) with rocker device, rmmod

[PATCH net-next] switchdev: fix handling for drivers not supporting IPv4 fib add/del ops

2015-06-10 Thread sfeldma
From: Scott Feldman If CONFIG_NET_SWITCHDEV is enabled, but port driver does not implement support for IPv4 FIB add/del ops, don't fail route add/del offload operations. Route adds will not be marked as OFFLOAD. Routes will be installed in the kernel FIB, as usual. This was report/fixed by Flo

Re: [PATCH net-next] switchdev: fix handling for drivers not supporting IPv4 fib add/del ops

2015-06-10 Thread Florian Fainelli
On 10/06/15 17:04, sfel...@gmail.com wrote: > From: Scott Feldman > > If CONFIG_NET_SWITCHDEV is enabled, but port driver does not implement > support for IPv4 FIB add/del ops, don't fail route add/del offload > operations. Route adds will not be marked as OFFLOAD. Routes will be > installed in

[PATCH next v0] bonding: Display LACP info only to CAP_SYS_ADMIN capable user

2015-06-10 Thread Mahesh Bandewar
Actor and Partner details can be accessed via proc-fs and sys-fs entries. These interfaces are world readable at this moment. The earlier patch-series made the LACP communication secure to avoid nuisance attack from within the same L2 domain but it did not prevent "someone unprivileged" looking at

Re: Problem with patch "make nlmsg_end() and genlmsg_end() void"

2015-06-10 Thread David Woodhouse
On Tue, 2015-06-09 at 17:49 -0700, Eric Dumazet wrote: > > I've added some debugging, and it seems that when it deadlocks, glibc > > doesn't get *any* response to its RTM_GETADDR request. I know we'd get > > ENOBUFS is a *response* was dropped... but what about when the request > > itself is droppe

Fw: [Bug 99191] New: ARP monitoring with bonding module uses interface alias for ARP request

2015-06-10 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 29 May 2015 17:59:33 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 99191] New: ARP monitoring with bonding module uses interface alias for ARP request https://bugzilla.kernel.org/show_bug.cgi?id=991

[PATCH v2] net, swap: Remove a warning and clarify why sk_mem_reclaim is required when deactivating swap

2015-06-10 Thread Jeff Layton
From: Mel Gorman Jeff Layton reported the following; [ 74.232485] [ cut here ] [ 74.233354] WARNING: CPU: 2 PID: 754 at net/core/sock.c:364 sk_clear_memalloc+0x51/0x80() [ 74.234790] Modules linked in: cts rpcsec_gss_krb5 nfsv4 dns_resolver nfs fscache xfs libc

[PATCH net-next 0/5] net: phy: broadcom: define pseudo-PHY address

2015-06-10 Thread Florian Fainelli
Hi David, This patch series converts existing in-tree users of the Broadcom pseudo-PHY address (30) used to configure MDIO-connected switches to share a constant in a shared header files. Thanks! Florian Fainelli (5): net: phy: broadcom: include phy.h for brcmphy.h net: phy: broadcom: define

[PATCH net-next 2/5] net: phy: broadcom: define Broadcom pseudo-PHY address in brcmphy.h

2015-06-10 Thread Florian Fainelli
Define the pseudo-PHY address (30) which is used by all Broadcom Ethernet switches in a shared header file. Signed-off-by: Florian Fainelli --- include/linux/brcmphy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h index abb6106f839d..6

[PATCH net-next 1/5] net: phy: broadcom: include phy.h for brcmphy.h

2015-06-10 Thread Florian Fainelli
We utilize inline functions from the PHY library, make sure that we do include phy.h in brcmphy.h in order for the code including brcmphy.h not to have to resolve this inclusion dependency. Fixes: 705314797b8b ("net: phy: broadcom: move shadow 0x1C register accessors to brcmphy.h") Signed-off-by:

[PATCH net-next 4/5] bgmac: Utilize BRCM_PSEUDO_PHY_ADDR

2015-06-10 Thread Florian Fainelli
What BGMAC defines as BGMAC_PHY_NOREGS is in fact the Broadcom Ethernet switches' pseudo-PHY address (30), utilize the newly introduced constant from brcmphy.h Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bgmac.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH net-next 3/5] b44: Utilize BRCM_PSEUDO_PHY_ADDR

2015-06-10 Thread Florian Fainelli
What B44 has been locally using as B44_PHY_ADDR_NO_LOCAL_PHY is in fact the Broadcom Ethernet switches pseudo-PHY address (30). Update the header to use the newly introduced constant and update comments so they are within 80 columns and consistent. Signed-off-by: Florian Fainelli --- drivers/net

[PATCH net-next 5/5] net: dsa: bcm_sf2: Utilize BRCM_PSEUDO_PHY_ADDR

2015-06-10 Thread Florian Fainelli
Utilize the newly introduced BRCM_PSEUDO_PHY_ADDR constant from brcmphy.h instead of open-coding the Broadcom Ethernet switches pseudo-PHY address (30). Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/driver

Re: [PATCH net-next 2/3 v2] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-10 Thread Scott Feldman
On Tue, Jun 9, 2015 at 11:47 PM, Andy Gospodarek wrote: > /* /proc/sys/net/ipv4/netfilter */ > diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c > index 7e7746a..c9d0a0e 100644 > --- a/kernel/sysctl_binary.c > +++ b/kernel/sysctl_binary.c > @@ -253,6 +253,7 @@ static const struct bin_

Re: [PATCH net-next 2/3 v2] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 7:12 PM, Scott Feldman wrote: > On Tue, Jun 9, 2015 at 11:47 PM, Andy Gospodarek > wrote: > >> /* /proc/sys/net/ipv4/netfilter */ >> diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c >> index 7e7746a..c9d0a0e 100644 >> --- a/kernel/sysctl_binary.c >> +++ b/kern

Re: [PATCH net-next 2/3 v2] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-10 Thread Andy Gospodarek
On Wed, Jun 10, 2015 at 07:18:59PM -0700, Scott Feldman wrote: > On Wed, Jun 10, 2015 at 7:12 PM, Scott Feldman wrote: > > On Tue, Jun 9, 2015 at 11:47 PM, Andy Gospodarek > > wrote: > > > >> /* /proc/sys/net/ipv4/netfilter */ > >> diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c > >

[PATCH net-next 0/3 v3] changes to make ipv4 routing table aware of next-hop link status

2015-06-10 Thread Andy Gospodarek
This series adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an interface that was serving as a gateway for some systems could result in tho

[PATCH net-next 3/3 v3] iproute2: add support to print 'linkdown' nexthop flag

2015-06-10 Thread Andy Gospodarek
Signed-off-by: Andy Gospodaerk Signed-off-by: Dinesh Dutt --- ip/iproute.c | 4 1 file changed, 4 insertions(+) diff --git a/ip/iproute.c b/ip/iproute.c index 3795baf..3369c49 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -451,6 +451,8 @@ int print_route(const struct sockaddr_nl *who, s

[PATCH net-next 2/3 v3] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-10 Thread Andy Gospodarek
This feature is only enabled with the new per-interface or ipv4 global sysctls called 'ignore_routes_with_linkdown'. net.ipv4.conf.all.ignore_routes_with_linkdown = 0 net.ipv4.conf.default.ignore_routes_with_linkdown = 0 net.ipv4.conf.lo.ignore_routes_with_linkdown = 0 ... When the above sysctls

[PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-10 Thread Andy Gospodarek
Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are reachable via an interface where carrier is off. No action is taken, but additional flags are passed to userspace to indicate carrier status. This also includes a cleanup to fib_disable_ip to more clearly indicate what event made

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek wrote: > @@ -1129,7 +1142,15 @@ int fib_sync_down_dev(struct net_device *dev, int > force) > dead++; > else if (nexthop_nh->nh_dev == dev && > nexthop_nh->nh_

Re: [PATCH net-next 2/3 v2] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 7:23 PM, Andy Gospodarek wrote: > On Wed, Jun 10, 2015 at 07:18:59PM -0700, Scott Feldman wrote: >> On Wed, Jun 10, 2015 at 7:12 PM, Scott Feldman wrote: >> > On Tue, Jun 9, 2015 at 11:47 PM, Andy Gospodarek >> > wrote: >> > >> >> /* /proc/sys/net/ipv4/netfilter */ >> >>

Re: [PATCH net-next 2/3 v3] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-10 Thread YOSHIFUJI Hideaki
Hi, Andy Gospodarek wrote: > This feature is only enabled with the new per-interface or ipv4 global > sysctls called 'ignore_routes_with_linkdown'. > > net.ipv4.conf.all.ignore_routes_with_linkdown = 0 > net.ipv4.conf.default.ignore_routes_with_linkdown = 0 > net.ipv4.conf.lo.ignore_routes_with_l

Re: [PATCH net-next 2/3 v3] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 7:57 PM, YOSHIFUJI Hideaki wrote: > Hi, > > Andy Gospodarek wrote: >> This feature is only enabled with the new per-interface or ipv4 global >> sysctls called 'ignore_routes_with_linkdown'. >> >> net.ipv4.conf.all.ignore_routes_with_linkdown = 0 >> net.ipv4.conf.default.ign

Re: [PATCH net-next 3/3 v3] iproute2: add support to print 'linkdown' nexthop flag

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek wrote: > Signed-off-by: Andy Gospodaerk > Signed-off-by: Dinesh Dutt > > --- > ip/iproute.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/ip/iproute.c b/ip/iproute.c > index 3795baf..3369c49 100644 > --- a/ip/iproute.c > +++ b/ip/i

Re: [PATCH net-next 0/3 v3] changes to make ipv4 routing table aware of next-hop link status

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek wrote: > There was also a request for switchdev support for this, but that will be > posted as a followup as switchdev does not currently handle dead > next-hops in a multi-path case and I felt that infra needed to be added > first. That's not tru

Re: [PATCH net-next 3/3 v3] iproute2: add support to print 'linkdown' nexthop flag

2015-06-10 Thread Andy Gospodarek
On Wed, Jun 10, 2015 at 08:02:26PM -0700, Scott Feldman wrote: > On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek > wrote: > > Signed-off-by: Andy Gospodaerk > > Signed-off-by: Dinesh Dutt > > > > --- > > ip/iproute.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/ip/iproute

Re: [PATCH net-next 0/3 v3] changes to make ipv4 routing table aware of next-hop link status

2015-06-10 Thread Andy Gospodarek
On Wed, Jun 10, 2015 at 08:07:10PM -0700, Scott Feldman wrote: > On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek > wrote: > > > There was also a request for switchdev support for this, but that will be > > posted as a followup as switchdev does not currently handle dead > > next-hops in a multi-

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-10 Thread Andy Gospodarek
On Wed, Jun 10, 2015 at 07:53:59PM -0700, Scott Feldman wrote: > On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek > wrote: > > > @@ -1129,7 +1142,15 @@ int fib_sync_down_dev(struct net_device *dev, int > > force) > > dead++; > > else if (ne

Re: [PATCH net-next 0/3 v3] changes to make ipv4 routing table aware of next-hop link status

2015-06-10 Thread Andy Gospodarek
On Wed, Jun 10, 2015 at 11:19:29PM -0400, Andy Gospodarek wrote: > On Wed, Jun 10, 2015 at 08:07:10PM -0700, Scott Feldman wrote: > > On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek > > wrote: > > > > > There was also a request for switchdev support for this, but that will be > > > posted as a f

Re: [PATCH net-next 2/3 v3] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-10 Thread Andy Gospodarek
On Wed, Jun 10, 2015 at 08:00:14PM -0700, Scott Feldman wrote: > On Wed, Jun 10, 2015 at 7:57 PM, YOSHIFUJI Hideaki > wrote: > > Hi, > > > > Andy Gospodarek wrote: > >> This feature is only enabled with the new per-interface or ipv4 global > >> sysctls called 'ignore_routes_with_linkdown'. > >> >

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 8:28 PM, Andy Gospodarek wrote: > On Wed, Jun 10, 2015 at 07:53:59PM -0700, Scott Feldman wrote: >> On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek >> wrote: >> >> > @@ -1129,7 +1142,15 @@ int fib_sync_down_dev(struct net_device *dev, int >> > force) >> >

Re: [PATCH net-next 2/3 v3] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-10 Thread David Miller
From: Andy Gospodarek Date: Wed, 10 Jun 2015 23:36:21 -0400 > On Wed, Jun 10, 2015 at 08:00:14PM -0700, Scott Feldman wrote: >> On Wed, Jun 10, 2015 at 7:57 PM, YOSHIFUJI Hideaki >> wrote: >> > Hi, >> > >> > Andy Gospodarek wrote: >> >> This feature is only enabled with the new per-interface or

Re: pull-request: can-next 2015-05-06

2015-06-10 Thread David Miller
From: Marc Kleine-Budde Date: Tue, 9 Jun 2015 09:45:29 +0200 > this is a pull request of a two patches for net-next. > > The first patch is by Tomas Krcka, he fixes the (currently unused) > register address for acceptance filters. Oliver Hartkopp contributes a > patch for the cangw, where an opt

Re: [PATCH net-next] bridge: make br_fdb_delete also check if the port matches

2015-06-10 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 9 Jun 2015 03:34:13 -0700 > Before this patch the user-specified bridge port was ignored when > deleting an fdb entry and thus one could delete an entry that belonged > to any port. > Example (eth0 and eth1 are br0 ports): > bridge fdb add 00:11:22:33:44:55 d

Re: [PATCH 1/1] bna: remove obsolete use of EXTRA_CFLAGS

2015-06-10 Thread David Miller
From: Jiri Slaby Date: Tue, 9 Jun 2015 14:24:43 +0200 > EXTRA_CFLAGS should be used on the command line only. > > Since EXTRA_CFLAGS here add only a non-existant path to compiler > include paths (by -I), remove EXTRA_CFLAGS completely. > > Signed-off-by: Jiri Slaby Applied to net-next, thank

Re: [PATCH net-next 0/3] Add cim_ma_la, cim_pif_la and tx_rate debugfs entry

2015-06-10 Thread David Miller
From: Hariprasad Shenai Date: Tue, 9 Jun 2015 18:27:49 +0530 > This patch series adds the following. > Add debugfs entry to dump CIM MA logic analyzer and CIM PIF logic analyzer > logs. > Also adds support to dump tx rate of the channels in the adapter > > This patch series has been created ag

Re: [PATCH net-next 0/5] net: phy: broadcom: define pseudo-PHY address

2015-06-10 Thread Rafał Miłecki
On 11 June 2015 at 03:07, Florian Fainelli wrote: > This patch series converts existing in-tree users of the Broadcom pseudo-PHY > address (30) used to configure MDIO-connected switches to share a constant in > a > shared header files. Looks OK, thanks. -- Rafał -- To unsubscribe from this lis

Re: [PATCH] tipc: disconnect socket directly after probe failure

2015-06-10 Thread David Miller
From: Date: Tue, 9 Jun 2015 17:27:12 +0200 > From: Erik Hugne > > If the TIPC connection timer expires in a probing state, a > self abort message is supposed to be generated and delivered > to the local socket. This is currently broken, and the abort > message is actually sent out to the peer n

Re: [PATCH 1/1 linux-next] ath5k: use swap() in ath5k_hw_get_median_noise_floor()

2015-06-10 Thread Fabian Frederick
> On 10 June 2015 at 22:29 Julia Lawall wrote: > > > > > On Wed, 10 Jun 2015, Fabian Frederick wrote: > > > > > > > > On 10 June 2015 at 21:52 Joe Perches wrote: > > > > > > > > > On Wed, 2015-06-10 at 18:33 +0200, Fabian Frederick wrote: > > > > Use kernel.h macro definition. > > > > > > > > T

Re: [PATCH net-next] net/ethtool: Add current supported tunable options

2015-06-10 Thread David Miller
From: Hadar Hen Zion Date: Tue, 9 Jun 2015 18:29:54 +0300 > Add strings array of the current supported tunable options. > > Signed-off-by: Hadar Hen Zion > Reviewed-by: Amir Vadai > --- > include/uapi/linux/ethtool.h | 6 ++ > net/core/ethtool.c | 12 > 2 files ch

Re: [PATCH net v2] bridge: fix multicast router rlist endless loop

2015-06-10 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 9 Jun 2015 10:23:57 -0700 > From: Nikolay Aleksandrov > > Since the addition of sysfs multicast router support if one set > multicast_router to "2" more than once, then the port would be added to > the hlist every time and could end up linking to itself and

[PATCH net-next] net: tcp: dctcp_update_alpha() fixes.

2015-06-10 Thread Eric Dumazet
From: Eric Dumazet dctcp_alpha can be read by from dctcp_get_info() without synchro, so use WRITE_ONCE() to prevent compiler from using dctcp_alpha as a temporary variable. Also, playing with small dctcp_shift_g (like 1), can expose an overflow with 32bit values shifted 9 times before divide. U

Re: [net-next 00/18][pull request] Intel Wired LAN Driver Updates 2015-06-09

2015-06-10 Thread David Miller
From: Jeff Kirsher Date: Tue, 9 Jun 2015 18:10:11 -0700 > This series contains updates to ixgbe only. > > The series adds additional support for x550 support, such as WoL and > auto-negotiation of flow control. Adds new PHY support (external PHY) > for x550, as well as the new methods/function

Re: [PATCH net-next v8] Add support of Cavium Liquidio ethernet adapters

2015-06-10 Thread David Miller
From: Raghu Vatsavayi Date: Tue, 9 Jun 2015 18:15:23 -0700 > Following patch V8 adds support for Cavium Liquidio pci express > based 10Gig ethernet adapters. > 1) Consolidated all debug macros to either call dev_* or >netdev_* macros directly, feedback from previous patch. > 2) Changed soft c

Re: [PATCH] atm: idt77105: Use setup_timer

2015-06-10 Thread David Miller
From: Vaishali Thakkar Date: Wed, 10 Jun 2015 11:10:05 +0530 > Use the timer API function setup_timer instead of structure field > assignments to initialize a timer. > > A simplified version of the Coccinelle semantic patch that performs > this transformation is as follows: > > @change@ > expre

Re: [PATCH net-next] net/unix: support SCM_SECURITY for stream sockets

2015-06-10 Thread David Miller
From: Stephen Smalley Date: Wed, 10 Jun 2015 08:44:59 -0400 > SCM_SECURITY was originally only implemented for datagram sockets, > not for stream sockets. However, SCM_CREDENTIALS is supported on > Unix stream sockets. For consistency, implement Unix stream support > for SCM_SECURITY as well.

Re: pull-request: mac80211-next 2015-06-10

2015-06-10 Thread David Miller
From: Johannes Berg Date: Wed, 10 Jun 2015 16:07:08 +0200 > On Wed, 2015-06-10 at 15:09 +0200, Johannes Berg wrote: > >> The following changes since commit c3eee1fb1d308564ada5f7ea57bc51efc6130b37: >> >> Merge tag 'batman-adv-for-davem' of git://git.open-mesh.org/linux-merge >> (2015-06-09 2

Re: [PATCH] batman-adv:Make the function batadv_is_my_mac bool

2015-06-10 Thread Antonio Quartulli
Nicholas, On 11/06/15 04:25, Nicholas Krause wrote: > This makes the function batadv_is_my_mac bool now due > to this particular function only returning either one > or zero as its return value. > > Signed-off-by: Nicholas Krause NAK. we already have ("batman-adv: main, Convert is_my_mac() to

Re: [PATCH v2] net, swap: Remove a warning and clarify why sk_mem_reclaim is required when deactivating swap

2015-06-10 Thread David Miller
From: Jeff Layton Date: Wed, 10 Jun 2015 21:02:04 -0400 > From: Mel Gorman > > Jeff Layton reported the following; > > [ 74.232485] [ cut here ] > [ 74.233354] WARNING: CPU: 2 PID: 754 at net/core/sock.c:364 > sk_clear_memalloc+0x51/0x80() > [ 74.234790] Modul

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek wrote: > Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are > reachable via an interface where carrier is off. No action is taken, > but additional flags are passed to userspace to indicate carrier status. Andy, it seems now RTNH_

Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

2015-06-10 Thread Jiri Pirko
Thu, Jun 11, 2015 at 12:00:47AM CEST, sfel...@gmail.com wrote: >On Wed, Jun 10, 2015 at 2:47 PM, Scott Feldman wrote: >> On Wed, Jun 10, 2015 at 2:25 PM, David Ahern wrote: >>> On 6/10/15 2:56 PM, sfel...@gmail.com wrote: From: Scott Feldman Fix a BUG() where CONFIG_NET_SWITC

[PATCH net 1/3] enic: unlock napi busy poll before unmasking intr

2015-06-10 Thread Govindarajulu Varadarajan
There is a small window between vnic_intr_unmask() and enic_poll_unlock_napi(). In this window if an irq occurs and napi is scheduled on different cpu, it tries to acquire enic_poll_lock_napi() and hits the following WARN_ON message. Fix is to unlock napi_poll before unmasking the interrupt. [ 7

[PATCH net 2/3] enic: check return value for stat dump

2015-06-10 Thread Govindarajulu Varadarajan
We do not check the return value of enic_dev_stats_dump(). If allocation fails, we will hit NULL pointer reference. Return only if memory allocation fails. For other failures, we return the previously recorded values. Signed-off-by: Govindarajulu Varadarajan <_gov...@gmx.com> --- drivers/net/eth

[PATCH net 3/3] enic: fix memory leak in rq_clean

2015-06-10 Thread Govindarajulu Varadarajan
When incoming packet qualifies for rx_copybreak, we copy the data to newly allocated skb. We do not free/unmap the original buffer. At this point driver assumes this buffer is unallocated. When enic_rq_alloc_buf() is called for buffer allocation, it checks if buf->os_buf is NULL. If its not NULL th

Re: [PATCH net-next] net: tcp: dctcp_update_alpha() fixes.

2015-06-10 Thread David Miller
From: Eric Dumazet Date: Wed, 10 Jun 2015 22:11:17 -0700 > From: Eric Dumazet > > dctcp_alpha can be read by from dctcp_get_info() without > synchro, so use WRITE_ONCE() to prevent compiler from using > dctcp_alpha as a temporary variable. > > Also, playing with small dctcp_shift_g (like 1), c

Re: [PATCH net-next 0/5] net: phy: broadcom: define pseudo-PHY address

2015-06-10 Thread David Miller
From: Florian Fainelli Date: Wed, 10 Jun 2015 18:07:56 -0700 > This patch series converts existing in-tree users of the Broadcom pseudo-PHY > address (30) used to configure MDIO-connected switches to share a constant in > a > shared header files. This looks fine, series applied, thanks. -- To u

Re: [PATCH net 2/3] enic: check return value for stat dump

2015-06-10 Thread David Miller
From: Govindarajulu Varadarajan <_gov...@gmx.com> Date: Thu, 11 Jun 2015 11:52:55 +0530 > We do not check the return value of enic_dev_stats_dump(). If allocation > fails, we will hit NULL pointer reference. > > Return only if memory allocation fails. For other failures, we return the > previousl

Re: [PATCH net 1/3] enic: unlock napi busy poll before unmasking intr

2015-06-10 Thread David Miller
From: Govindarajulu Varadarajan <_gov...@gmx.com> Date: Thu, 11 Jun 2015 11:52:54 +0530 > There is a small window between vnic_intr_unmask() and > enic_poll_unlock_napi(). > In this window if an irq occurs and napi is scheduled on different cpu, it > tries > to acquire enic_poll_lock_napi() and

Re: [PATCH net 3/3] enic: fix memory leak in rq_clean

2015-06-10 Thread David Miller
From: Govindarajulu Varadarajan <_gov...@gmx.com> Date: Thu, 11 Jun 2015 11:52:56 +0530 > When incoming packet qualifies for rx_copybreak, we copy the data to newly > allocated skb. We do not free/unmap the original buffer. At this point driver > assumes this buffer is unallocated. When enic_rq_al

Re: [PATCH net-next] switchdev: fix handling for drivers not supporting IPv4 fib add/del ops

2015-06-10 Thread David Miller
From: sfel...@gmail.com Date: Wed, 10 Jun 2015 17:04:49 -0700 > From: Scott Feldman > > If CONFIG_NET_SWITCHDEV is enabled, but port driver does not implement > support for IPv4 FIB add/del ops, don't fail route add/del offload > operations. Route adds will not be marked as OFFLOAD. Routes wil

Re: [PATCH RFC] net: phy: Introduced the PHY_AN_PENDING state

2015-06-10 Thread Keng Soon Cheah
Resending as I didn't reply all. On Tue, Jun 09, 2015 at 10:17:59PM -0700, Florian Fainelli wrote: > > The typical way to work around these problems are to fix them at the PHY > driver level, see below. > My first attempt of work around is to target on the PHY driver but I couldn't figure out a

Re: [PATCH WIP RFC 0/3] mpls: support for ler

2015-06-10 Thread roopa
On 6/8/15, 3:58 PM, Thomas Graf wrote: I'll immediately ACK any series that supports both models and rebase my patches on top of it. I think we are on the right track overall. I am trying to get my code on github to collaborate better. Stay tuned (hopefully end of day today). Robert/Thomas,

RE: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet

2015-06-10 Thread Madalin-Cristian Bucur
Hi Eric, Can you please tell us if this change would be for the better? I was about to say yes to this request but checked and no other Ethernet driver seems to use the queue trans_start. I was able to find your patch "net: tx scalability works : trans_start" [ http://patchwork.ozlabs.org/patch

Re: [PATCH] NET: Add ezchip ethernet driver

2015-06-10 Thread Paul Bolle
Just a nit and a question. On Tue, 2015-06-09 at 15:44 +0300, Noam Camus wrote: > --- /dev/null > +++ b/drivers/net/ethernet/ezchip/Kconfig > +config NET_VENDOR_EZCHIP > + bool "EZchip devices" > + default y > + ---help--- > + If you have a network (Ethernet) device belonging to

Re: [PATCH] net, swap: Remove a warning and clarify why sk_mem_reclaim is required when deactivating swap

2015-06-10 Thread Leon Romanovsky
On Tue, Jun 9, 2015 at 9:40 PM, Jeff Layton wrote: > From: Mel Gorman > > Jeff Layton reported the following; > > [ 74.232485] [ cut here ] > [ 74.233354] WARNING: CPU: 2 PID: 754 at net/core/sock.c:364 > sk_clear_memalloc+0x51/0x80() > [ 74.234790] Modules linke

jewelry and watches

2015-06-10 Thread Tonny
Dear Sir/Madam: Attached pls kindly find our new design . Best regards! Tonny

[PATCH 3.10.y 2/2] ipv6: update ip6_rt_last_gc every time GC is run

2015-06-10 Thread Konstantin Khlebnikov
From: Michal Kubeček commit 49a18d86f66d33a20144ecb5a34bba0d1856b260 upstream As pointed out by Eric Dumazet, net->ipv6.ip6_rt_last_gc should hold the last time garbage collector was run so that we should update it whenever fib6_run_gc() calls fib6_clean_all(), not only if we got there from ip6_

[PATCH 3.10.y 0/2] ipv6: avoid soft lockups in fib6_run_gc()

2015-06-10 Thread Konstantin Khlebnikov
Two patches from 3.11 which are missing in 3.10.y I've just seen livelock in 3.10.69+ where all cpus are stuck in fib6_run_gc() <4>[2919865.977745] Call Trace: <4>[2919865.977748] <4>[2919865.977754] [] _raw_spin_lock_bh+0x1e/0x30 <4>[2919865.977759] [] fib6_run_gc+0x28/0x100 <4>[2919865.977

[PATCH 3.10.y 1/2] ipv6: prevent fib6_run_gc() contention

2015-06-10 Thread Konstantin Khlebnikov
From: Michal Kubeček commit 2ac3ac8f86f2fe065d746d9a9abaca867adec577 upstream On a high-traffic router with many processors and many IPv6 dst entries, soft lockup in fib6_run_gc() can occur when number of entries reaches gc_thresh. This happens because fib6_run_gc() uses fib6_gc_lock to allow o

[PATCH net-next] net/unix: support SCM_SECURITY for stream sockets

2015-06-10 Thread Stephen Smalley
SCM_SECURITY was originally only implemented for datagram sockets, not for stream sockets. However, SCM_CREDENTIALS is supported on Unix stream sockets. For consistency, implement Unix stream support for SCM_SECURITY as well. Also clean up the existing code and get rid of the superfluous UNIXSID

pull-request: mac80211-next 2015-06-10

2015-06-10 Thread Johannes Berg
Hi Dave, For -next, I have another set of changes, mostly small fixes for there and a few cleanups. Kalle and I also decided to put in a big API change that I'd been planning for a while and that required modifying all the drivers, for that I pulled in your net-next tree before (re-)applying that

Re: [PATCH v3] ipv6: Fix protocol resubmission

2015-06-10 Thread Josh Hunt
On 06/09/2015 11:24 PM, Hajime Tazaki wrote: Hello Josh, Dave, my mobile ipv6 test on libos failed with this commit. This commit makes a destination option header handling (i.e., ipprot->handler == ipv6_destopt_rcv) failed since ipv6_destopt_rcv() seems to return a positive value to indicate t

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-10 Thread Marcelo Ricardo Leitner
On Tue, Jun 09, 2015 at 04:32:59PM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Jun 09, 2015 at 07:36:38AM -0400, Neil Horman wrote: > > On Mon, Jun 08, 2015 at 05:37:05PM +0200, Hannes Frederic Sowa wrote: > > > On Mo, 2015-06-08 at 11:19 -0400, Neil Horman wrote: > > > > On Mon, Jun 08, 2015 a

Re: pull-request: mac80211-next 2015-06-10

2015-06-10 Thread Johannes Berg
On Wed, 2015-06-10 at 15:09 +0200, Johannes Berg wrote: > The following changes since commit c3eee1fb1d308564ada5f7ea57bc51efc6130b37: > > Merge tag 'batman-adv-for-davem' of git://git.open-mesh.org/linux-merge > (2015-06-09 20:23:52 -0700) > > are available in the git repository at: > > g

Re: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet

2015-06-10 Thread Eric Dumazet
On Wed, 2015-06-10 at 07:38 +, Madalin-Cristian Bucur wrote: > Hi Eric, > > Can you please tell us if this change would be for the better? > > I was about to say yes to this request but checked and no other Ethernet > driver seems to use the queue trans_start. > I was able to find your patch

[PATCH net-next 03/13] net/mlx4_core: Add sink counter

2015-06-10 Thread Or Gerlitz
From: Eran Ben Elisha Reserve the last valid counter index for "sink" counter, when a new counter cannot be allocated, the driver will use this counter. In order to avoid allocating this counter on any other flow, fix the indices bitmap allocation range, and reserve the sink counter index. Add

[PATCH net-next 04/13] net/mlx4_core: Remove counters table allocation from VF flow

2015-06-10 Thread Or Gerlitz
From: Eran Ben Elisha Since virtual functions get their counters indices allocation from the PF, allocate counters indices bitmap only in case the function isn't virtual. Also, check that the device has counters to allocate before creating the indices bitmap table. Signed-off-by: Eran Ben Elish

[PATCH net-next 01/13] net/mlx4_core: Check before cleaning counters bitmap

2015-06-10 Thread Or Gerlitz
From: Eran Ben Elisha If counters are not supported by the device. The indices bitmap table is not allocated during initialization. Add the symmetrical check before cleaning the counters bitmap table or freeing a counter. Signed-off-by: Eran Ben Elisha Signed-off-by: Hadar Hen Zion Signed-off-

[PATCH net-next 06/13] net/mlx4_core: Add port attribute when tracking counters

2015-06-10 Thread Or Gerlitz
From: Eran Ben Elisha Counter will get its port attribute within the resource tracker when the first QP attached to it is modified to RTR. If a QP is counter-less, an attempt to create a new counter with assigned port will be made. Signed-off-by: Eran Ben Elisha Signed-off-by: Hadar Hen Zion S

[PATCH net-next 00/13] mlx4 driver update (+ new VF ndo)

2015-06-10 Thread Or Gerlitz
Hi Dave, This series from Eran and Hadar is further dealing with traffic counters in the mlx4 driver, this time mostly around SRIOV. We added a new ndo to read the VF counters through the PF netdev netlink infrastructure plus mlx4 implementation for that ndo. Or. Eran Ben Elisha (13): net/m

[PATCH net-next 05/13] net/mlx4_core: Adjust counter grant policy in the resource tracker

2015-06-10 Thread Or Gerlitz
From: Eran Ben Elisha Each physical function has a guarantee of two counters per port, one for a default counter and one for the IB driver. Each virtual function has a guarantee of one counter per port. All other counters are free and can be obtained on demand. This is a preparation step for su

[PATCH net-next 02/13] net/mlx4_core: Reset counters data when freed

2015-06-10 Thread Or Gerlitz
From: Eran Ben Elisha Add resetting the counter data to the free counter flow, so the counter's data won't be accessible anymore if querying the counter. Also, on next counter allocation (to another VM for example), it will be fresh and clear. Signed-off-by: Eran Ben Elisha Signed-off-by: Hadar

[PATCH net-next 13/13] net/mlx4_en: Support ndo_get_vf_stats

2015-06-10 Thread Or Gerlitz
From: Eran Ben Elisha Implement function to gather vf statistics through the PF. The function is provided in the master net device ops. All VFs counters are stored in list per slave, run over the slave's list and collect all statistics. Signed-off-by: Eran Ben Elisha Signed-off-by: Hadar Hen Z

[PATCH net-next 11/13] net/mlx4_en: Show PF own statistics via ethtool

2015-06-10 Thread Or Gerlitz
From: Eran Ben Elisha Allow the user to observe the PF own statistics using ethtool with pf_ prefixed counter names. Those counters are the PF statistics out of the overall port statistics. Every PF QP is attached to a counter and the summary of those counters is the PF statistics. Signed-off-b

[PATCH net-next 08/13] IB/mlx4: Add RoCE/IB dedicated counters

2015-06-10 Thread Or Gerlitz
From: Eran Ben Elisha This is an infrastructure step to attach all the QPs opened from the IB driver to a counter in order to collect VF stats from the PF using those counters. If the port's type is Ethernet, the counter policy demands two counters per port (one for RoCE and one for Ethernet). T

[PATCH net-next 07/13] net/mlx4_core: Allocate default counter per port

2015-06-10 Thread Or Gerlitz
From: Eran Ben Elisha Default counter per port will be allocated at the mlx4 core driver load. Every QP opened by the Ethernet driver will be attached to the port's default counter. This is an infrastructure step to collect VF statistics from the PF. Signed-off-by: Eran Ben Elisha Signed-off-

  1   2   >