On Freitag, 31. März 2017 22:33:34 CEST Philippe Reynes wrote:
> > Do you know if anyone already prepared the get_link_ksettings support for
> > kernels older than 4.6 for backports.git?
>
> Sorry, I don't know this repo. Do you have an url please ?
> But I suppose that nobody works on such backpo
On 3/31/17 10:32 PM, Wangnan (F) wrote:
OK. Then let your patch be merged first then let me do the code cleanup.
Thanks!
Once these two lib/bpf patches applied to net-next we can apply
the same to tip and there will be no conflicts during the merge
window.
I'm also planning to fix few things
Yeah, seems quite a bit like VLAN (from a workflow perspective, not
quite as much from a protocol one) and I think the same workflow could
work for this too. Would be nice to eventually get qmi_wwan onto the
same base, if possible (though we'd need to preserve the 802.3
capability somehow for dev
On 2017/4/1 11:18, Alexei Starovoitov wrote:
On 3/31/17 7:29 PM, Wangnan (F) wrote:
On 2017/3/31 12:45, Alexei Starovoitov wrote:
expose bpf_program__set_type() to set program type
Signed-off-by: Alexei Starovoitov
Acked-by: Daniel Borkmann
Acked-by: Martin KaFai Lau
---
tools/lib/bpf
On 2017年03月31日 22:31, Michael S. Tsirkin wrote:
On Fri, Mar 31, 2017 at 11:52:24AM +0800, Jason Wang wrote:
On 2017年03月30日 21:53, Michael S. Tsirkin wrote:
On Thu, Mar 30, 2017 at 03:22:24PM +0800, Jason Wang wrote:
This patch introduce a batched version of consuming, consumer can
dequeue mo
From: Gao Feng
Define one new macro TCP_MAX_WSCALE instead of literal number '14',
and use U16_MAX instead of 65535 as the max value of TCP window.
There is another minor change, use rounddown(space, mss) instead of
(space / mss) * mss;
Signed-off-by: Gao Feng
---
include/net/tcp.h | 3 +++
On 3/31/17 7:29 PM, Wangnan (F) wrote:
On 2017/3/31 12:45, Alexei Starovoitov wrote:
expose bpf_program__set_type() to set program type
Signed-off-by: Alexei Starovoitov
Acked-by: Daniel Borkmann
Acked-by: Martin KaFai Lau
---
tools/lib/bpf/libbpf.c | 3 +--
tools/lib/bpf/libbpf.h | 2 +
Add IFLA_EVENT handling so that event types can be viewed with
'moniotr' command. This gives a little more information for why
a given message was recevied.
V2: Adds all events recently proposed. This way all currently supported
events can be viewed.
Signed-off-by: Vladislav Yasevich
---
inc
On 2017/3/31 12:45, Alexei Starovoitov wrote:
expose bpf_program__set_type() to set program type
Signed-off-by: Alexei Starovoitov
Acked-by: Daniel Borkmann
Acked-by: Martin KaFai Lau
---
tools/lib/bpf/libbpf.c | 3 +--
tools/lib/bpf/libbpf.h | 2 ++
2 files changed, 3 insertions(+), 2
When netdev events happen, a rtnetlink_event() handler will send
messages for every event in it's white list. These messages contain
current information about a particular device, but they do not include
the iformation about which event just happened. The consumer of
the message has to try to inf
This series came out of the conversation that started as a result
my first attempt to add netdevice event info to netlink messages.
This series converts event processing to a 'white list', where
we explicitely permit events to generate netlink messages. This
is meant to make people take a closer
The rtnetlink_event currently functions as a blacklist where
we block cerntain netdev events from being sent to user space.
As a result, events have been added to the system that userspace
probably doesn't care about.
This patch converts the implementation to the white list so that
newly events wo
From: Andrei Vagin
A name of an abstract socket can contain zero characters.
Now we replace only the first character. If a name contains more
than one zero character, the ss tool shows only a part of the name:
u_str UNCONN00 @1931097 * 0
the output with
drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of 0/1
in function 'hns_enable_serdes_lb' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
CC: lipeng
Signed-
Hi lipeng,
[auto build test WARNING on net/master]
url:
https://github.com/0day-ci/linux/commits/Salil-Mehta/net-hns-Misc-HNS-Bug-Fixes-Code-Improvements/20170401-060153
coccinelle warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: retur
In case, if TX watchdog is fired some or all netdev TX queues will be
stopped and as part of recovery it is required not only to drain and
reinitailize CPSW TX channeles, but also wake up stoppted TX queues what
doesn't happen now and netdevice will stop transmiting data until
reopenned.
Hence, ad
On Fri, 2017-03-31 at 14:59 -0700, Eric Dumazet wrote:
> From: Eric Dumazet
>
> It seems the code does not match the intent.
>
> This broke packetdrill, and probably other programs.
>
> Fixes: 6c7c98bad488 ("sock: avoid dirtying sk_stamp, if possible")
> Signed-off-by: Eric Dumazet
> Cc: Paolo
On 3/31/17 12:49 AM, Wangnan (F) wrote:
Hi Alexei,
Please see the patch I sent. Since we export bpf_program__set_type(),
bpf_program__set_xxx() should be built based on it.
Replied to your patch. I still think simply adding
#include here like I did in this patch is much cleaner.
That's the wh
On Fri, 2017-03-31 at 12:51 -0700, Tom Herbert wrote:
> Hi netdev,
>
> I'm forwarding this problem report from Ulrich Speidel.
>
> The correlation to FDs would seem to point to application always
> reading for FDs in order and it seems unlikely that FDs have any
> relevance in the networking stac
On Fri, 2017-03-24 at 18:49 -0600, Subash Abhinov Kasiviswanathan
wrote:
> > (re-sending from an address that's actually subscribed to
> > netdev@...)
> >
> > The first thing that jumps out at me is "why isn't this using
> > rtnl_link_ops?"
> >
> > To me (and perhaps I'm completely wrong) the str
On Fri, 31 Mar 2017 10:08:39 -0400
Steven Rostedt wrote:
> On Fri, 31 Mar 2017 15:20:24 +0200
> Alban Crequy wrote:
>
> > When a kretprobe is installed on a kernel function, there is a maximum
> > limit of how many calls in parallel it can catch (aka "maxactive"). A
> > kernel module could call
From: Eric Dumazet
It seems the code does not match the intent.
This broke packetdrill, and probably other programs.
Fixes: 6c7c98bad488 ("sock: avoid dirtying sk_stamp, if possible")
Signed-off-by: Eric Dumazet
Cc: Paolo Abeni
---
include/net/sock.h |2 +-
1 file changed, 1 insertion(+)
> They are incremental, but some of them are trivial and in the end
> it's the end result that matters but yes I could probably split some
> misc stuff, rx path, tx path, and more misc.
Hi Ben
Trivial patches are good. They are easy to review. You should be
aiming for patches which are obviously
Good catch, thanks again Julia!
Mickaël
On 29/03/2017 17:14, Julia Lawall wrote:
> Size is unsigned, so not negative.
>
> julia
>
> -- Forwarded message --
> Date: Wed, 29 Mar 2017 23:06:01 +0800
> From: kbuild test robot
> To: kbu...@01.org
> Cc: Julia Lawall
> Subject: Re:
On 29/03/2017 12:35, Djalal Harouni wrote:
> On Wed, Mar 29, 2017 at 1:46 AM, Mickaël Salaün wrote:
>> @@ -25,6 +30,9 @@ struct seccomp_filter;
>> struct seccomp {
>> int mode;
>> struct seccomp_filter *filter;
>> +#if defined(CONFIG_SECCOMP_FILTER) && defined(CONFIG_SECURITY_L
On Fri, 2017-03-31 at 15:52 +0200, Andrew Lunn wrote:
> > We're running some more testing tonight, if it's all solid I'll shoot
> > it out tomorrow or sunday. Dave, it's ok to just spam the list with a
> > 55 patches series like that ?
>
> Hi Ben
>
> Is there a good reason to spam the list with 5
Hi Sven,
On 3/31/17, Sven Eckelmann wrote:
> On Donnerstag, 30. März 2017 23:01:27 CEST Philippe Reynes wrote:
>> The ethtool api {get|set}_settings is deprecated.
>> We move this driver to new api {get|set}_link_ksettings.
>>
>> I've only compiled this change. If someone may test it,
>> it would
КЛИЕНТСКИЕ БАЗЫ для всех кто много продает (для юрлиц и физлиц)! Узнайте
подробнее! Skype: prodawez390 Email: prodawez...@gmail.com Whatsapp:
+79139230330 Viber: +79139230330 Telegram: +79139230330
From: Andrew Morton
Subject: drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: fix build with
gcc-4.4.4
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: In function
'mlx5e_set_rxfh':
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:1067: error: unknown field
'rss' specified in ini
From: Andrew Morton
Subject: drivers/net/ethernet/mellanox/mlx5/core/en_main.c: fix build with
gcc-4.4.4
drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function
'mlx5e_redirect_rqts':
drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2210: error: unknown field
'rqn' specified in initial
On 3/28/2017 7:25 AM, Daniel Jurgens wrote:
> On 3/28/2017 4:11 AM, Saeed Mahameed wrote:
>> On Tue, Mar 28, 2017 at 2:45 AM, Goel, Sameer wrote:
>>> Stack frame:
>>> [ 1744.418958] [] get_nic_state+0x24/0x40 [mlx5_core]
>>> [ 1744.425273] [] health_recover+0x28/0x80 [mlx5_core]
>>> [ 1744.43149
Hi netdev,
I'm forwarding this problem report from Ulrich Speidel.
The correlation to FDs would seem to point to application always
reading for FDs in order and it seems unlikely that FDs have any
relevance in the networking stack below the file IO for sockets. Some
of the stack experts might hav
Hello,
Linux 4.11-rc4 contains the following code in function
__skb_flow_dissect(), file net/core/flow_dissector.c:
const struct arphdr *arp;
struct arphdr *_arp;
arp = __skb_header_pointer(skb, nhoff, sizeof(_arp), data,
hlen, &_arp);
I am not sure if it is same issue, but panics still happen, but much
less. Same server, nat.
I will upgrade to latest 4.10.x build, because for this one i dont have
files anymore (for symbols and etc).
[864288.511464] Modules linked in: nf_conntrack_netlink nf_nat_pptp
nf_nat_proto_gre xt_TCP
On Fri, Mar 31, 2017 at 05:57:28PM +0800, Xin Long wrote:
> Since sctp reconf was added in sctp, the real cnt of in/out stream
> have not been c.sinit_max_instreams and c.sinit_num_ostreams any
> more.
>
> This patch is to replace them with stream->in/outcnt.
>
> Signed-off-by: Xin Long
Acked-b
ping
Le 19/03/2017 à 18:03, Romain Perier a écrit :
> The current PCI pool API are simple macro functions direct expanded to
> the appropriate dma pool functions. The prototypes are almost the same
> and semantically, they are very similar. I propose to use the DMA pool
> API directly and get rid
On Fri, Mar 31, 2017 at 06:14:09PM +0800, Xin Long wrote:
> Before when implementing sctp prsctp, SCTP_PR_STREAM_STATUS wasn't
> added, as it needs to save abandoned_(un)sent for every stream.
>
> After sctp stream reconf is added in sctp, assoc has structure
> sctp_stream_out to save per stream i
This patch set introduces various HNS bug fixes, optimizations and code
improvements.
Daode Huang (1):
net: hns: bug fix of ethtool show the speed
Kejian Yan (7):
net: hns: Remove the redundant adding and deleting mac function
net: hns: Remove redundant mac_get_id()
net: hns: Remove redun
From: lipeng
This patch fixes the implementation of the IRQ affinity
function. This function is used to create the cpu mask
which eventually is used to initialize the cpu<->queue
association for XPS(Transmit Packet Steering).
Signed-off-by: lipeng
Signed-off-by: Kejian Yan
Reviewed-by: Yisen Z
From: lipeng
This patch reduces GMAC TX threshold value to avoid gmac
hang-up with speed 100M/duplex half.
Signed-off-by: lipeng
Signed-off-by: JinchuanTian
Reviewed-by: Yisen Zhuang
Signed-off-by: Salil Mehta
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 6 ++
drivers/net/et
From: lipeng
This patch optimises the init configuration code leg
for gmac pad and crc set interface.
Signed-off-by: lipeng
Signed-off-by: JinchuanTian
Reviewed-by: Yisen Zhuang
Signed-off-by: Salil Mehta
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 36 ++
1
From: lipeng
Because all members of desc_cb is assigned when xmit one package, so it
can delete in hnae_free_buffer, as follows:
- "dma, priv, length, type" are assigned in fill_v2_desc.
- "page_offset, reuse_flag, buf" are not used in tx direction.
Signed-off-by: lipeng
Signed-
From: lipeng
After polling less than buget packages, we need check again. If
there are still some packages, we call napi_schedule add softirq
queue, this is not better way. So we return buget value instead
of napi_schedule.
Signed-off-by: lipeng
reviewed-by: Yisen Zhuang
Signed-off-by: Salil M
From: Daode Huang
When run ethtool ethX on hns driver, the speed will show
as "Unknown". The base.speed is not correct assigned,
this patch fix this bug.
Signed-off-by: Daode Huang
Reviewed-by: Yisen Zhuang
Signed-off-by: Salil Mehta
---
drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 2 +
From: lipeng
Because buf_size of ring set to 2048, the process of rx_poll_one
can reuse the page, therefore the performance of XGE can improve.
But the chip only supports three bds in one package, so the max mtu
is 6K when it sets to 2048. For better performane in litter mtu, we
need change buf_s
From: lipeng
netif_tx_lock is a global spin lock, it will take affect
in all rings in the netdevice. In tx_poll_one process, it can
only lock the current ring, in this case, we define a spin lock
in hnae_ring struct for it.
Signed-off-by: lipeng
reviewed-by: Yisen Zhuang
Signed-off-by: Salil M
From: Kejian Yan
There is a mac_id in mac control block structure, so the callback
function mac_get_id() is useless. Here we remove this function.
Reported-by: Weiwei Deng
Signed-off-by: Kejian Yan
Reviewed-by: Salil Mehta
Signed-off-by: Salil Mehta
---
drivers/net/ethernet/hisilicon/hns/hn
From: Kejian Yan
This patch cleans the redundant code from hns_mdio.c.
Reported-by: Ping Zhang
Signed-off-by: Kejian Yan
Reviewed-by: Salil Mehta
Signed-off-by: Salil Mehta
---
drivers/net/ethernet/hisilicon/hns_mdio.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/
From: lipeng
This patch fixes below ethtool configuration error:
localhost:~ # ethtool -X eth0 hkey XX:XX:XX...
Cannot set Rx flow hash configuration: Operation not supported
Signed-off-by: lipeng
Reviewed-by: Yisen Zhuang
Signed-off-by: Salil Mehta
---
drivers/net/ethernet/hisilicon/hns/hn
From: Kejian Yan
This patch removes redundant functions used only for debugging
purposes.
Reported-by: Weiwei Deng
Signed-off-by: Kejian Yan
Reviewed-by: Salil Mehta
Signed-off-by: Salil Mehta
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 160 -
drivers/net/et
From: Kejian Yan
We need to free all ppe submodule if it fails to initialize ppe by
any fault, so this patch will free all ppe resource before
hns_ppe_init() returns exception situation
Reported-by: JinchuanTian
Signed-off-by: Kejian Yan
Reviewed-by: Salil Mehta
Signed-off-by: Salil Mehta
--
From: Kejian Yan
The functions (hns_dsaf_set_mac_mc_entry() and hns_mac_del_mac()) are
not called by any functions. They are dead code in hns. And the same
features are implemented by the patch (the id is 66355f5).
Reported-by: Weiwei Deng
Signed-off-by: Kejian Yan
Reviewed-by: Salil Mehta
Si
From: Kejian Yan
This patch fixes the code to clear pclint warning/info.
Reported-by: Ping Zhang
Signed-off-by: Kejian Yan
Reviewed-by: Salil Mehta
Signed-off-by: Salil Mehta
---
drivers/net/ethernet/hisilicon/hns_mdio.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff
From: lipeng
There is a bug on Hip06 that tx ring interrupts packets count will be
clear when drivers send data to tx ring, so that the tx packets count
will never upgrade to packets line, and cause the interrupts engendered
was delayed.
Sometimes, it will cause sending performance lower than exp
On Fri, Mar 31, 2017 at 10:45 AM, Joe Perches wrote:
> On Fri, 2017-03-31 at 10:34 -0700, Steve deRosier wrote:
>> On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote:
>> > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote:
>> > > On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote:
>> > >
This patch fixes some checkpatch.pl script caught errors and
warnings during the compilation time.
Signed-off-by: Salil Mehta
---
Patch V3: https://lkml.org/lkml/2017/3/31/538
Adressed the comment by Joe Perches
---
drivers/net/ethernet/hisilicon/hns/hnae.h | 1 -
drivers/net
From: Kejian Yan
HNS needs SMB Buffers to store at least two packets after sending
pause frame because of the link delay. The MTU of HNS is 9728. As
the processor user manual described, the SBM buffer threshold should
be modified.
Reported-by: Ping Zhang
Signed-off-by: Kejian Yan
Reviewed-by:
On Fri, 2017-03-31 at 10:34 -0700, Steve deRosier wrote:
> On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote:
> > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote:
> > > On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote:
> > > > Fix fallout too.
> >
> > []
> > > My only question is why
On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote:
> On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote:
>> On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote:
>> > Fix fallout too.
> []
>> My only question is why bother doing a format check on something
>> that's going to be compiled out
Hi Andrew,
Andrew Lunn writes:
> I don't like the idea of leaking frames.
I don't like it neither. That's why this patch series is out there. It
improves the security on PVT-capable Marvell switches by programming the
tables correctly on bridging events.
A next step can be to warn the user abo
On Fri, Mar 31, 2017 at 01:02:30PM +0200, Guillaume Nault wrote:
> Callers of l2tp_nl_session_find() need to hold a reference on the
> returned session since there's no guarantee that it isn't going to
> disappear from under them.
>
> Relying on the fact that no l2tp netlink message may be process
On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote:
> On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote:
> > Fix fallout too.
[]
> My only question is why bother doing a format check on something
> that's going to be compiled out anyway?
To avoid introducing defects when writing new code
an
On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote:
> Fix fallout too.
>
> Signed-off-by: Joe Perches
> ---
> drivers/net/wireless/ath/ath6kl/debug.h| 2 ++
> drivers/net/wireless/ath/ath6kl/htc_pipe.c | 2 +-
> drivers/net/wireless/ath/ath6kl/wmi.c | 2 +-
> 3 files changed, 4 insertio
On Fri, Mar 31, 2017 at 12:55:03PM -0400, Vivien Didelot wrote:
> Hi Andrew,
>
> Andrew Lunn writes:
>
> > On Thu, Mar 30, 2017 at 05:37:15PM -0400, Vivien Didelot wrote:
> >> Implement the DSA cross-chip bridging operations by remapping the local
> >> ports an external source port can egress fr
On Fri, Mar 31, 2017 at 9:52 AM, Cong Wang wrote:
>
> Please submit your patch formally and with a man page patch too.
BTW, and probably IPv6 too.
Às 5:57 PM de 3/31/2017, David Miller escreveu:
> From: Joao Pinto
> Date: Fri, 31 Mar 2017 11:43:38 +0100
>
>> @David: Could you please create a branch in your git tree for us to work on
>> it
>> until the multiple buffers get stable for everyone? This way the patches
>> could
>> circulate in
From: Joao Pinto
Date: Fri, 31 Mar 2017 11:43:38 +0100
> @David: Could you please create a branch in your git tree for us to work on it
> until the multiple buffers get stable for everyone? This way the patches could
> circulate in the mailing-list with a different target, like stmmac-next or
>
From: Benjamin Herrenschmidt
Date: Fri, 31 Mar 2017 20:59:27 +1100
> We're running some more testing tonight, if it's all solid I'll shoot
> it out tomorrow or sunday. Dave, it's ok to just spam the list with a
> 55 patches series like that ?
Please send about a dozen at a time, thank you. Grou
Hi Andrew,
Andrew Lunn writes:
> On Thu, Mar 30, 2017 at 05:37:15PM -0400, Vivien Didelot wrote:
>> Implement the DSA cross-chip bridging operations by remapping the local
>> ports an external source port can egress frames to, when this cross-chip
>> port joins or leaves a bridge.
>>
>> The PVT
> Actually we do not, because netdev_uses_dsa() returns true only when
> dst->rcv is different from NULL. When dst->rcv is NULL we completely
> bypass the DSA hook in eth_type_trans() and everything is well, the
> master network device is the one receiving packets.
static inline bool netdev_uses_d
On Thu, Mar 30, 2017 at 5:02 PM, Eric Dumazet wrote:
> On Thu, 2017-03-30 at 16:36 -0700, Cong Wang wrote:
>> On Tue, Mar 28, 2017 at 5:52 PM, Eric Dumazet wrote:
>> > On Tue, 2017-03-28 at 16:11 -0700, Eric Dumazet wrote:
>> >
>> >> Yes, this looks better.
>> >>
>> >> Although you probably need
> -Original Message-
> From: Joe Perches [mailto:j...@perches.com]
> Sent: Friday, March 31, 2017 4:45 PM
> To: Salil Mehta; da...@davemloft.net
> Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com;
> netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Linuxarm
> Subject: Re: [PATCH V2 n
Hi Andrew,
On 03/31/2017 09:06 AM, Andrew Lunn wrote:
> Hi Florian
>
>> +static enum dsa_tag_protocol dsa_loop_get_protocol(struct dsa_switch *ds)
>> +{
>> +dev_dbg(ds->dev, "%s\n", __func__);
>> +
>> +return DSA_TAG_PROTO_NONE;
>> +}
>
> I'm wondering how safe this is:
>
> static const
On Thu, Mar 30, 2017 at 05:37:15PM -0400, Vivien Didelot wrote:
> Implement the DSA cross-chip bridging operations by remapping the local
> ports an external source port can egress frames to, when this cross-chip
> port joins or leaves a bridge.
>
> The PVT is no longer configured with all ones al
On Thu, Mar 30, 2017 at 05:37:09PM -0400, Vivien Didelot wrote:
> The Cross-chip Port Based VLAN Table (PVT) is currently initialized with
> all ones, allowing any external ports to egress frames on local ports.
>
> This commit implements the PVT access functions and programs the PVT
> with all on
> +/* Offset 0x1D: Misc Register */
> +
> +static int mv88e6xxx_g2_misc_5_bit_port(struct mv88e6xxx_chip *chip,
> + bool port_5_bit)
> +{
> + u16 val;
> + int err;
> +
> + err = mv88e6xxx_g2_read(chip, GLOBAL2_MISC, &val);
> + if (err)
> +
On Thu, Mar 30, 2017 at 05:37:10PM -0400, Vivien Didelot wrote:
> The current code allocates DSA_MAX_PORTS ports for a Marvell dsa_switch
> structure. Provide the exact number of ports so the corresponding
> ds->num_ports is accurate.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
On Fri, Mar 31, 2017 at 12:04:55PM +0800, Jason Wang wrote:
>
>
> On 2017年03月30日 22:32, Michael S. Tsirkin wrote:
> > On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote:
> > >
> > > On 2017年03月30日 04:48, Michael S. Tsirkin wrote:
> > > > We are going to add more parameters to find_vqs, l
Please do not top post on netdev
On Mon, 2017-03-27 at 18:08 -0700, Chris Kuiper wrote:
> Sorry, I have been transferring jobs and had no time to look at this.
>
> Josh Hunt's change seems to solve a different problem. I was looking
> for something that works the same way as SO_RXQ_OVERFL, provid
Hi Florian
> +static enum dsa_tag_protocol dsa_loop_get_protocol(struct dsa_switch *ds)
> +{
> + dev_dbg(ds->dev, "%s\n", __func__);
> +
> + return DSA_TAG_PROTO_NONE;
> +}
I'm wondering how safe this is:
static const struct dsa_device_ops none_ops = {
.xmit = dsa_slave_notag_x
On Fri, 2017-03-31 at 12:20 +0100, Salil Mehta wrote:
> This patch fixes some checkpatch.pl script caught errors and
> warnings during the compilation time.
[]
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
[]
> @@ -512,7 +512,8 @@ st
On Fri, 2017-03-31 at 08:09 -0700, Eric Dumazet wrote:
> On Fri, 2017-03-31 at 16:33 +0200, Paolo Abeni wrote:
>
> > I did the above to avoid increasing the udp_sock struct size; this will
> > costs more than a whole cacheline.
>
> Yes, but who cares :)
>
> Also note that we discussed about havi
On Fri, 2017-03-31 at 15:03 +, David Laight wrote:
> Is that really sensible on systems with large cache lines?
Yes it is.
We mostly do our perf analysis on x86, and it turns out that linux
networking on PowerPC is not great because of this.
struct dst_entry is showing problems, simply beca
On Fri, 2017-03-31 at 16:33 +0200, Paolo Abeni wrote:
> I did the above to avoid increasing the udp_sock struct size; this will
> costs more than a whole cacheline.
Yes, but who cares :)
Also note that we discussed about having a secondary receive queue in
the future, to decouple the fact that p
From: Eric Dumazet
> Sent: 31 March 2017 14:25
> On Fri, 2017-03-31 at 11:47 +0200, Paolo Abeni wrote:
> > In the udp_sock struct, the 'forward_deficit' and 'pcflag' fields
> > share the same cacheline. While the first is dirtied by
> > udp_recvmsg, the latter is read, possibly several times, by th
Hello.
I know this means of communication may not be morally right to you as a person
but I also have had a great thought about it and I have come to this conclusion
which I am about to share with you.
INTRODUCTION:I am the Credit Manager U. B. A Bank of Burkina Faso Ouagadougou
and in one way
On Fri, 2017-03-31 at 06:25 -0700, Eric Dumazet wrote:
> On Fri, 2017-03-31 at 11:47 +0200, Paolo Abeni wrote:
> > In the udp_sock struct, the 'forward_deficit' and 'pcflag' fields
> > share the same cacheline. While the first is dirtied by
> > udp_recvmsg, the latter is read, possibly several time
On Fri, Mar 31, 2017 at 11:52:24AM +0800, Jason Wang wrote:
>
>
> On 2017年03月30日 21:53, Michael S. Tsirkin wrote:
> > On Thu, Mar 30, 2017 at 03:22:24PM +0800, Jason Wang wrote:
> > > This patch introduce a batched version of consuming, consumer can
> > > dequeue more than one pointers from the r
Move labels to the end of mpls_nh as a 0-sized array and within mpls_route
move the via for a nexthop after the mpls_nh. The new layout becomes:
+--+
| mpls_route |
+--+
| mpls_nh 0|
+--+
| alignmen
Limit memory allocation size for mpls_route to 4096.
Signed-off-by: David Ahern
---
v3
- no change
v2
- new patch in v2 of set
net/mpls/af_mpls.c | 31 +--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index
Increase the maximum number of new labels for MPLS routes from 2 to 30.
To keep memory consumption in check, the labels array is moved to the end
of mpls_nh and mpls_iptunnel_encap structs as a 0-sized array. Allocations
use the maximum number of labels across all nexthops in a route for LSR
and t
The number of alive nexthops for a route (rt->rt_nhn_alive) and the
flags for a next hop (nh->nh_flags) are modified by netdev event
handlers. The event handlers run with rtnl_lock held so updates are
always done with the lock held. The packet path accesses the fields
under the rcu lock. Since thos
Alow users to push down more labels per MPLS encap. Similar to LSR case,
move label array to the end of mpls_iptunnel_encap and allocate based on
the number of labels for the route.
For consistency with the LSR case, re-use the same maximum number of
labels.
Signed-off-by: David Ahern
---
v3
- n
Allow users to push down more labels per MPLS route. With the previous
patches, no memory allocations are based on MAX_NEW_LABELS; the limit
is only used to keep userspace in check.
At this point MAX_NEW_LABELS is only used for mpls_route_config (copying
route data from userspace) and processing n
Number of nexthops and number of alive nexthops are tracked using an
unsigned int. A route should never have more than 255 nexthops so
convert both to u8. Update all references and intermediate variables
to consistently use u8 as well.
Shrinks the size of mpls_route from 32 bytes to 24 bytes with
On Fri, Mar 31, 2017 at 02:57:52PM +0200, Corentin Labbe wrote:
> This patch add a generic testsuite for testing ethernet network device driver.
>
> Signed-off-by: Corentin Labbe
> ---
> tools/testing/selftests/net/Makefile | 2 +-
> tools/testing/selftests/net/netdevice.sh | 185
> ++
On Fri, 31 Mar 2017 15:20:24 +0200
Alban Crequy wrote:
> When a kretprobe is installed on a kernel function, there is a maximum
> limit of how many calls in parallel it can catch (aka "maxactive"). A
> kernel module could call register_kretprobe() and initialize maxactive
> (see example in sample
> We're running some more testing tonight, if it's all solid I'll shoot
> it out tomorrow or sunday. Dave, it's ok to just spam the list with a
> 55 patches series like that ?
Hi Ben
Is there a good reason to spam the list with 55 patches? The patches
should be incremental, so getting them review
On March 31, 2017 3:27:59 PM CEST, Greg Ungerer wrote:
>On 31/03/17 18:48, Bjørn Mork wrote:
>
>>> +void usbnet_get_stats64(struct net_device *net, struct
>rtnl_link_stats64 *stats)
>>> +{
>>> + struct usbnet *dev = netdev_priv(net);
>>> + unsigned int start;
>>> + int cpu;
>>> +
>>> + n
On Fri, Mar 31, 2017 at 11:44:52AM +0200, Tobias Regnery wrote:
> After commit 96567d5dacf4 ("net: dsa: dsa2: Add basic support of devlink")
> I see the following link error with CONFIG_NET_DSA=y and CONFIG_NET_DEVLINK=m:
>
> net/built-in.o: In function 'dsa_register_switch':
> (.text+0xe226b): un
1 - 100 of 159 matches
Mail list logo
