Re: [PATCH] vmalloc: respect the GFP_NOIO and GFP_NOFS flags

On Fri, 30 Jun 2017, Andreas Dilger wrote: > On Jun 29, 2017, at 8:25 PM, Mikulas Patocka wrote: > > > > The __vmalloc function has a parameter gfp_mask with the allocation flags, > > however it doesn't fully respect the GFP_NOIO and GFP_NOFS flags. The > > pages are

Re: [PATCH] vmalloc: respect the GFP_NOIO and GFP_NOFS flags

On Jun 29, 2017, at 8:25 PM, Mikulas Patocka wrote: > > The __vmalloc function has a parameter gfp_mask with the allocation flags, > however it doesn't fully respect the GFP_NOIO and GFP_NOFS flags. The > pages are allocated with the specified gfp flags, but the pagetables

[PATCH net-next v6 08/16] bpf: Add TCP connection BPF callbacks

Added callbacks to BPF SOCK_OPS type program before an active connection is intialized and after a passive or active connection is established. The following patch demostrates how they can be used to set send and receive buffer sizes. Signed-off-by: Lawrence Brakmo ---

[PATCH net-next v6 06/16] bpf: Sample bpf program to set initial window

The sample bpf program, tcp_rwnd_kern.c, sets the initial advertized window to 40 packets in an environment where distinct IPv6 prefixes indicate that both hosts are not in the same data center. Signed-off-by: Lawrence Brakmo Acked-by: Daniel Borkmann ---

[PATCH net-next v6 05/16] bpf: Support for setting initial receive window

This patch adds suppport for setting the initial advertized window from within a BPF_SOCK_OPS program. This can be used to support larger initial cwnd values in environments where it is known to be safe. Signed-off-by: Lawrence Brakmo --- include/net/tcp.h| 10 ++

[PATCH net-next v6 04/16] bpf: Sample bpf program to set SYN/SYN-ACK RTOs

The sample BPF program, tcp_synrto_kern.c, sets the SYN and SYN-ACK RTOs to 10ms when both hosts are within the same datacenter (i.e. small RTTs) in an environment where common IPv6 prefixes indicate both hosts are in the same data center. Signed-off-by: Lawrence Brakmo Acked-by:

[PATCH net-next v6 16/16] bpf: update tools/include/uapi/linux/bpf.h

Update tools/include/uapi/linux/bpf.h to include changes related to new bpf sock_ops program type. Signed-off-by: Lawrence Brakmo --- tools/include/uapi/linux/bpf.h | 66 +- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git

[PATCH net-next v6 11/16] bpf: Sample BPF program to set congestion control

Sample BPF program that sets congestion control to dctcp when both hosts are within the same datacenter. In this example that is assumed to be when they have the first 5.5 bytes of their IPv6 address are the same. Signed-off-by: Lawrence Brakmo --- samples/bpf/Makefile|

[PATCH net-next v6 15/16] bpf: Sample bpf program to set sndcwnd clamp

Sample BPF program, tcp_clamp_kern.c, to demostrate the use of setting the sndcwnd clamp. This program assumes that if the first 5.5 bytes of the host's IPv6 addresses are the same, then the hosts are in the same datacenter and sets sndcwnd clamp to 100 packets, SYN and SYN-ACK RTOs to 10ms and

[PATCH net-next v6 09/16] bpf: Sample BPF program to set buffer sizes

This patch contains a BPF program to set initial receive window to 40 packets and send and receive buffers to 1.5MB. This would usually be done after doing appropriate checks that indicate the hosts are far enough away (i.e. large RTT). Signed-off-by: Lawrence Brakmo ---

[PATCH net-next v6 14/16] bpf: Adds support for setting sndcwnd clamp

Adds a new bpf_setsockopt for TCP sockets, TCP_BPF_SNDCWND_CLAMP, which sets the initial congestion window. It is useful to limit the sndcwnd when the host are close to each other (small RTT). Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 1 + net/core/filter.c

[PATCH net-next v6 13/16] bpf: Sample BPF program to set initial cwnd

Sample BPF program that assumes hosts are far away (i.e. large RTTs) and sets initial cwnd and initial receive window to 40 packets, send and receive buffers to 1.5MB. In practice there would be a test to insure the hosts are actually far enough away. Signed-off-by: Lawrence Brakmo

[PATCH net-next v6 03/16] bpf: Support for per connection SYN/SYN-ACK RTOs

This patch adds support for setting a per connection SYN and SYN_ACK RTOs from within a BPF_SOCK_OPS program. For example, to set small RTOs when it is known both hosts are within a datacenter. Signed-off-by: Lawrence Brakmo --- include/net/tcp.h| 11 +++

[PATCH net-next v6 00/16] bpf: Adds support for sock_ops

Created a new BPF program type, BPF_PROG_TYPE_SOCK_OPS, and a corresponding struct that allows BPF programs of this type to access some of the socket's fields (such as IP addresses, ports, etc.) and setting connection parameters such as buffer sizes, initial window, SYN/SYN-ACK RTOs, etc. Unlike

[PATCH net-next v6 02/16] bpf: program to load and attach sock_ops BPF progs

The program load_sock_ops can be used to load sock_ops bpf programs and to attach it to an existing (v2) cgroup. It can also be used to detach sock_ops programs. Examples: load_sock_ops [-l] Load and attaches a sock_ops program at the specified cgroup. If "-l" is used, the

[PATCH net-next v6 12/16] bpf: Adds support for setting initial cwnd

Adds a new bpf_setsockopt for TCP sockets, TCP_BPF_IW, which sets the initial congestion window. This can be used when the hosts are far apart (large RTTs) and it is safe to start with a large inital cwnd. Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 2 ++

[PATCH net-next v6 01/16] bpf: BPF support for sock_ops

Created a new BPF program type, BPF_PROG_TYPE_SOCK_OPS, and a corresponding struct that allows BPF programs of this type to access some of the socket's fields (such as IP addresses, ports, etc.). It uses the existing bpf cgroups infrastructure so the programs can be attached per cgroup with full

[PATCH net-next v6 10/16] bpf: Add support for changing congestion control

Added support for changing congestion control for SOCK_OPS bpf programs through the setsockopt bpf helper function. It also adds a new SOCK_OPS op, BPF_SOCK_OPS_NEEDS_ECN, that is needed for congestion controls, like dctcp, that need to enable ECN in the SYN packets. Signed-off-by: Lawrence

[PATCH net-next v6 07/16] bpf: Add setsockopt helper function to bpf

Added support for calling a subset of socket setsockopts from BPF_PROG_TYPE_SOCK_OPS programs. The code was duplicated rather than making the changes to call the socket setsockopt function because the changes required would have been larger. The ops supported are: SO_RCVBUF SO_SNDBUF

Re: [PATCH net-next v5 07/16] bpf: Add setsockopt helper function to bpf

On 6/30/17, 5:01 PM, "Daniel Borkmann" wrote: On 06/30/2017 10:06 PM, Lawrence Brakmo wrote: [...] > @@ -2672,6 +2673,69 @@ static const struct bpf_func_proto bpf_get_socket_uid_proto = { > .arg1_type = ARG_PTR_TO_CTX, > }; > >

Re: [RFC/RFT PATCH 2/4] net: ethernat: ti: cpts: enable irq

On Tue, Jun 13, 2017 at 06:16:21PM -0500, Grygorii Strashko wrote: > There are two reasons for this change: > 1) enabling of HW_TS_PUSH events as suggested by Richard Cochran and > discussed in [1] > 2) fixing an TX timestamping miss issue which happens with low speed > ethernet connections and

Re: [PATCH] vmalloc: respect the GFP_NOIO and GFP_NOFS flags

On Fri, 30 Jun 2017, Michal Hocko wrote: > On Fri 30-06-17 14:11:57, Mikulas Patocka wrote: > > > > > > On Fri, 30 Jun 2017, Michal Hocko wrote: > > > > > On Thu 29-06-17 22:25:09, Mikulas Patocka wrote: > > > > The __vmalloc function has a parameter gfp_mask with the allocation > > > >

Re: [PATCH net-next v5 07/16] bpf: Add setsockopt helper function to bpf

On 06/30/2017 10:06 PM, Lawrence Brakmo wrote: [...] @@ -2672,6 +2673,69 @@ static const struct bpf_func_proto bpf_get_socket_uid_proto = { .arg1_type = ARG_PTR_TO_CTX, }; +BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock, + int, level, int, optname, char

Re: [PATCH net-next v5 06/16] bpf: Sample bpf program to set initial window

On 06/30/2017 10:06 PM, Lawrence Brakmo wrote: The sample bpf program, tcp_rwnd_kern.c, sets the initial advertized window to 40 packets in an environment where distinct IPv6 prefixes indicate that both hosts are not in the same data center. Signed-off-by: Lawrence Brakmo

Re: [PATCH net-next v5 04/16] bpf: Sample bpf program to set SYN/SYN-ACK RTOs

On 06/30/2017 10:06 PM, Lawrence Brakmo wrote: The sample BPF program, tcp_synrto_kern.c, sets the SYN and SYN-ACK RTOs to 10ms when both hosts are within the same datacenter (i.e. small RTTs) in an environment where common IPv6 prefixes indicate both hosts are in the same data center.

Re: [PATCH net-next v5 02/16] bpf: program to load and attach sock_ops BPF progs

On 06/30/2017 10:06 PM, Lawrence Brakmo wrote: The program load_sock_ops can be used to load sock_ops bpf programs and to attach it to an existing (v2) cgroup. It can also be used to detach sock_ops programs. Examples: load_sock_ops [-l] Load and attaches a sock_ops program at

Re: [PATCH net-next v5 01/16] bpf: BPF support for sock_ops

On 06/30/2017 10:06 PM, Lawrence Brakmo wrote: Created a new BPF program type, BPF_PROG_TYPE_SOCK_OPS, and a corresponding struct that allows BPF programs of this type to access some of the socket's fields (such as IP addresses, ports, etc.). It uses the existing bpf cgroups infrastructure so

Re: [PATCH iproute2 1/1] tc: updated ife man page.

On Wed, 28 Jun 2017 13:05:04 -0400 Roman Mashak wrote: > Explain when skbmark encoding may fail. > > Signed-off-by: Roman Mashak Applied

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

On Fri, Jun 30, 2017 at 02:13:39PM +0100, Will Deacon wrote: > On Fri, Jun 30, 2017 at 05:38:15AM -0700, Paul E. McKenney wrote: > > On Fri, Jun 30, 2017 at 10:19:29AM +0100, Will Deacon wrote: > > > On Thu, Jun 29, 2017 at 05:01:16PM -0700, Paul E. McKenney wrote: > > > > There is no agreed-upon

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

On 23-06-17 23:53, Luis R. Rodriguez wrote: > On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: >> On 16-5-2017 1:13, Luis R. Rodriguez wrote: >>> Since no upstream delta is needed for firmwared I'd like to first encourage >>> evaluating the above. While distributions don't carry

[PATCH net-next] net/packet: Fix Tx queue selection for AF_PACKET

When PACKET_QDISC_BYPASS is not used, Tx queue selection will be done before the packet is enqueued, taking into account any mappings set by a queuing discipline such as mqprio without hardware offloading. This selection may be affected by a previously saved queue_mapping, either on the Rx path,

Re: [PATCH] vmalloc: respect the GFP_NOIO and GFP_NOFS flags

On Fri 30-06-17 14:11:57, Mikulas Patocka wrote: > > > On Fri, 30 Jun 2017, Michal Hocko wrote: > > > On Thu 29-06-17 22:25:09, Mikulas Patocka wrote: > > > The __vmalloc function has a parameter gfp_mask with the allocation flags, > > > however it doesn't fully respect the GFP_NOIO and

Re: nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID

Florian, Am 30.06.2017 um 21:55 schrieb Florian Westphal: >>> Why not use a hash of the address? >> >> Would also work. Or xor it with a random number. >> >> On the other hand, for user space it would be more useful when the conntrack >> id >> does not repeat that often. That's why I favor the

Re: [PATCH RFC 02/26] task_work: Replace spin_unlock_wait() with lock/unlock pair

On Fri, Jun 30, 2017 at 01:02:48PM -0700, Paul E. McKenney wrote: > On Fri, Jun 30, 2017 at 09:21:23PM +0200, Oleg Nesterov wrote: > > On 06/30, Paul E. McKenney wrote: > > > > > > On Fri, Jun 30, 2017 at 05:20:10PM +0200, Oleg Nesterov wrote: > > > > > > > > I do not think the overhead will be

[PATCH net-next v5 07/16] bpf: Add setsockopt helper function to bpf

Added support for calling a subset of socket setsockopts from BPF_PROG_TYPE_SOCK_OPS programs. The code was duplicated rather than making the changes to call the socket setsockopt function because the changes required would have been larger. The ops supported are: SO_RCVBUF SO_SNDBUF

[PATCH net-next v5 05/16] bpf: Support for setting initial receive window

This patch adds suppport for setting the initial advertized window from within a BPF_SOCK_OPS program. This can be used to support larger initial cwnd values in environments where it is known to be safe. Signed-off-by: Lawrence Brakmo --- include/net/tcp.h| 10 ++

[PATCH net-next v5 13/16] bpf: Sample BPF program to set initial cwnd

Sample BPF program that assumes hosts are far away (i.e. large RTTs) and sets initial cwnd and initial receive window to 40 packets, send and receive buffers to 1.5MB. In practice there would be a test to insure the hosts are actually far enough away. Signed-off-by: Lawrence Brakmo

[PATCH net-next v5 14/16] bpf: Adds support for setting sndcwnd clamp

Adds a new bpf_setsockopt for TCP sockets, TCP_BPF_SNDCWND_CLAMP, which sets the initial congestion window. It is useful to limit the sndcwnd when the host are close to each other (small RTT). Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 1 + net/core/filter.c

[PATCH net-next v5 16/16] bpf: update tools/include/uapi/linux/bpf.h

Update tools/include/uapi/linux/bpf.h to include changes related to new bpf sock_ops program type. Signed-off-by: Lawrence Brakmo --- tools/include/uapi/linux/bpf.h | 66 +- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git

[PATCH net-next v5 06/16] bpf: Sample bpf program to set initial window

The sample bpf program, tcp_rwnd_kern.c, sets the initial advertized window to 40 packets in an environment where distinct IPv6 prefixes indicate that both hosts are not in the same data center. Signed-off-by: Lawrence Brakmo --- samples/bpf/Makefile| 1 +

[PATCH net-next v5 09/16] bpf: Sample BPF program to set buffer sizes

This patch contains a BPF program to set initial receive window to 40 packets and send and receive buffers to 1.5MB. This would usually be done after doing appropriate checks that indicate the hosts are far enough away (i.e. large RTT). Signed-off-by: Lawrence Brakmo ---

[PATCH net-next v5 01/16] bpf: BPF support for sock_ops

Created a new BPF program type, BPF_PROG_TYPE_SOCK_OPS, and a corresponding struct that allows BPF programs of this type to access some of the socket's fields (such as IP addresses, ports, etc.). It uses the existing bpf cgroups infrastructure so the programs can be attached per cgroup with full

[PATCH net-next v5 15/16] bpf: Sample bpf program to set sndcwnd clamp

Sample BPF program, tcp_clamp_kern.c, to demostrate the use of setting the sndcwnd clamp. This program assumes that if the first 5.5 bytes of the host's IPv6 addresses are the same, then the hosts are in the same datacenter and sets sndcwnd clamp to 100 packets, SYN and SYN-ACK RTOs to 10ms and

[PATCH net-next v5 00/16] bpf: Adding support for sock_ops

Created a new BPF program type, BPF_PROG_TYPE_SOCK_OPS, and a corresponding struct that allows BPF programs of this type to access some of the socket's fields (such as IP addresses, ports, etc.) and setting connection parameters such as buffer sizes, initial window, SYN/SYN-ACK RTOs, etc. Unlike

[PATCH net-next v5 08/16] bpf: Add TCP connection BPF callbacks

Added callbacks to BPF SOCK_OPS type program before an active connection is intialized and after a passive or active connection is established. The following patch demostrates how they can be used to set send and receive buffer sizes. Signed-off-by: Lawrence Brakmo ---

[PATCH net-next v5 12/16] bpf: Adds support for setting initial cwnd

Adds a new bpf_setsockopt for TCP sockets, TCP_BPF_IW, which sets the initial congestion window. This can be used when the hosts are far apart (large RTTs) and it is safe to start with a large inital cwnd. Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 2 ++

[PATCH net-next v5 10/16] bpf: Add support for changing congestion control

Added support for changing congestion control for SOCK_OPS bpf programs through the setsockopt bpf helper function. It also adds a new SOCK_OPS op, BPF_SOCK_OPS_NEEDS_ECN, that is needed for congestion controls, like dctcp, that need to enable ECN in the SYN packets. Signed-off-by: Lawrence

[PATCH net-next v5 04/16] bpf: Sample bpf program to set SYN/SYN-ACK RTOs

The sample BPF program, tcp_synrto_kern.c, sets the SYN and SYN-ACK RTOs to 10ms when both hosts are within the same datacenter (i.e. small RTTs) in an environment where common IPv6 prefixes indicate both hosts are in the same data center. Signed-off-by: Lawrence Brakmo ---

[PATCH net-next v5 11/16] bpf: Sample BPF program to set congestion control

Sample BPF program that sets congestion control to dctcp when both hosts are within the same datacenter. In this example that is assumed to be when they have the first 5.5 bytes of their IPv6 address are the same. Signed-off-by: Lawrence Brakmo --- samples/bpf/Makefile|

[PATCH net-next v5 03/16] bpf: Support for per connection SYN/SYN-ACK RTOs

This patch adds support for setting a per connection SYN and SYN_ACK RTOs from within a BPF_SOCK_OPS program. For example, to set small RTOs when it is known both hosts are within a datacenter. Signed-off-by: Lawrence Brakmo --- include/net/tcp.h| 11 +++

[PATCH net-next v5 02/16] bpf: program to load and attach sock_ops BPF progs

The program load_sock_ops can be used to load sock_ops bpf programs and to attach it to an existing (v2) cgroup. It can also be used to detach sock_ops programs. Examples: load_sock_ops [-l] Load and attaches a sock_ops program at the specified cgroup. If "-l" is used, the

Re: [PATCH RFC 02/26] task_work: Replace spin_unlock_wait() with lock/unlock pair

On Fri, Jun 30, 2017 at 03:50:33PM -0400, Alan Stern wrote: > On Fri, 30 Jun 2017, Oleg Nesterov wrote: > > > On 06/30, Paul E. McKenney wrote: > > > > > > On Fri, Jun 30, 2017 at 05:20:10PM +0200, Oleg Nesterov wrote: > > > > > > > > I do not think the overhead will be noticeable in this

Re: [PATCH RFC 02/26] task_work: Replace spin_unlock_wait() with lock/unlock pair

On Fri, Jun 30, 2017 at 09:21:23PM +0200, Oleg Nesterov wrote: > On 06/30, Paul E. McKenney wrote: > > > > On Fri, Jun 30, 2017 at 05:20:10PM +0200, Oleg Nesterov wrote: > > > > > > I do not think the overhead will be noticeable in this particular case. > > > > > > But I am not sure I understand

Re: nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID

Richard Weinberger wrote: > Florian, > > Am 30.06.2017 um 21:35 schrieb Florian Westphal: > > Richard Weinberger wrote: > >> Hi! > >> > >> I noticed that nf_conntrack leaks kernel addresses, it uses the memory > >> address > >> as identifier used for generating

Re: [PATCH RFC 02/26] task_work: Replace spin_unlock_wait() with lock/unlock pair

On Fri, 30 Jun 2017, Oleg Nesterov wrote: > On 06/30, Paul E. McKenney wrote: > > > > On Fri, Jun 30, 2017 at 05:20:10PM +0200, Oleg Nesterov wrote: > > > > > > I do not think the overhead will be noticeable in this particular case. > > > > > > But I am not sure I understand why do we want to

Re: nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID

Florian, Am 30.06.2017 um 21:35 schrieb Florian Westphal: > Richard Weinberger wrote: >> Hi! >> >> I noticed that nf_conntrack leaks kernel addresses, it uses the memory >> address >> as identifier used for generating conntrack and expect ids.. >> Since these ids are also

Re: nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID

Richard Weinberger wrote: > Hi! > > I noticed that nf_conntrack leaks kernel addresses, it uses the memory address > as identifier used for generating conntrack and expect ids.. > Since these ids are also visible to unprivileged users via network namespaces > I suggest reverting

nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID

Hi! I noticed that nf_conntrack leaks kernel addresses, it uses the memory address as identifier used for generating conntrack and expect ids.. Since these ids are also visible to unprivileged users via network namespaces I suggest reverting these commits: commit

Re: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build for FPGA

On Fri, Jun 30, 2017 at 8:58 PM, Ilan Tayari wrote: >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Makefile >> b/drivers/net/ethernet/mellanox/mlx5/core/Makefile >> index ca367445f864..50fe9e3c5dc2 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/Makefile >>

Re: [PATCH RFC 02/26] task_work: Replace spin_unlock_wait() with lock/unlock pair

On 06/30, Paul E. McKenney wrote: > > On Fri, Jun 30, 2017 at 05:20:10PM +0200, Oleg Nesterov wrote: > > > > I do not think the overhead will be noticeable in this particular case. > > > > But I am not sure I understand why do we want to unlock_wait. Yes I agree,

Re: [CRIU] BUG: Dentry ffff9f795a08fe60{i=af565f, n=lo} still in use (1) [unmount of proc proc]

On Thu, Jun 29, 2017 at 08:42:23PM -0500, Eric W. Biederman wrote: > Andrei Vagin writes: > > > On Thu, Jun 29, 2017 at 12:06 PM, Eric W. Biederman > > wrote: > >> Andrei Vagin writes: > >> > >>> Hello, > >>> > >>> We run CRIU tests on

RE: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build for FPGA

> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Subject: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build > for FPGA > > Both the ethernet and FPGA portions of MLX5 now require the wq functions, > and we get a link error when CONFIG_MLX5_CORE_EN is

RE: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Subject: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> > "Allocating" > > From: Colin Ian King > > Trivial fix to spelling mistake in mlx5_core_dbg debug message > >

Re: [PATCH v3 net-next 00/12] bpf: rewrite value tracking in verifier

On 6/30/17 9:44 AM, Edward Cree wrote: I haven't measured the test_progs ones, because I *still* haven't gotten around to actually setting up a BPF toolchain (it doesn't help that I'm building everything on a test server that gets reimaged every night to run our nightly tests...). then

Re: [PATCH] vmalloc: respect the GFP_NOIO and GFP_NOFS flags

On Fri, 30 Jun 2017, Michal Hocko wrote: > On Thu 29-06-17 22:25:09, Mikulas Patocka wrote: > > The __vmalloc function has a parameter gfp_mask with the allocation flags, > > however it doesn't fully respect the GFP_NOIO and GFP_NOFS flags. The > > pages are allocated with the specified gfp

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

"Baxter, Jim" writes: > I tested this with printk's to show when the low memory code was triggered > and the value of ctx->tx_low_mem_val and ctx->tx_low_mem_max_cnt. > I created a workqueue that slowly used up the atomic memory until the > code is triggered. > > I could

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

> Jim Baxter writes: > >> The CDC-NCM driver can require large amounts of memory to create >> skb's and this can be a problem when the memory becomes fragmented. >> >> This especially affects embedded systems that have constrained >> resources but wish to maximise the

Re: CAN-FD Transceiver Limitations

Hi Kurt, On 06/30/2017 03:09 AM, Kurt Van Dijck wrote: >> On 06/29/2017 05:36 PM, Kurt Van Dijck wrote: >> >> mcan@0 { >> ... >> fixed-transceiver { >>max-canfd-speed = <2000> >> }; >> ... >> }; >>> >>> Since when would a transceiver support different

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

Jim Baxter writes: > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects embedded systems that have constrained > resources but wish to maximise the throughput of

[TEST PATCH] bpf/verifier: roll back ptr handling, and fix signed bounds

I'm far from sure that my adjust_reg_min_max_vals() code remains correct in the face of maybe-signed-maybe-not bounds, even with the checks I've added in. So this probably has security leaks in it; but it should suffice for measuring the effect on pruning. The treat_as_signed part is loosely

[PATCH v3] sctp: Add peeloff-flags socket option

Based on a request raised on the sctp devel list, there is a need to augment the sctp_peeloff operation while specifying the O_CLOEXEC and O_NONBLOCK flags (simmilar to the socket syscall). Since modifying the SCTP_SOCKOPT_PEELOFF socket option would break user space ABI for existing programs,

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

On 06/30/2017 02:25 AM, Alvaro Gamez Machado wrote: > This IP core has support for mii connectivity to the phy, so be ready to > connect to it when this is the case. > > Signed-off-by: Alvaro Gamez Machado > --- > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6

Re: [PATCH RFC 12/26] arm64: Remove spin_unlock_wait() arch-specific definitions

On Fri, Jun 30, 2017 at 10:20:57AM +0100, Will Deacon wrote: > On Thu, Jun 29, 2017 at 05:01:20PM -0700, Paul E. McKenney wrote: > > There is no agreed-upon definition of spin_unlock_wait()'s semantics, > > and it appears that all callers could do just as well with a lock/unlock > > pair. This

Re: [PATCH RFC 02/26] task_work: Replace spin_unlock_wait() with lock/unlock pair

On Fri, Jun 30, 2017 at 09:16:07AM -0700, Paul E. McKenney wrote: > On Fri, Jun 30, 2017 at 05:20:10PM +0200, Oleg Nesterov wrote: > > On 06/30, Paul E. McKenney wrote: > > > > > > > > + raw_spin_lock_irq(>pi_lock); > > > > > + raw_spin_unlock_irq(>pi_lock); > > > > > > I

Re: [PATCH v4 0/4] PTP support for macb driver

From: Rafal Ozieblo Date: Thu, 29 Jun 2017 07:08:46 +0100 > This patch series adds support for PTP synchronization protocol > in Cadence GEM driver based on PHC. Series applied, thanks Rafal.

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

From: David S. Miller (da...@davemloft.net) Sent: Fri, 30 Jun 2017 12:59:53 -0400 To: jim_bax...@mentor.com Cc: linux-...@vger.kernel.org, netdev@vger.kernel.org, linux-ker...@vger.kernel.org, oli...@neukum.org,

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

From: Jim Baxter Date: Wed, 28 Jun 2017 21:35:29 +0100 > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects embedded systems that have constrained > resources

Re: [PATCH net-next 00/11] sctp: remove typedefs from structures part 1

On Fri, Jun 30, 2017 at 11:52:11AM +0800, Xin Long wrote: > As we know, typedef is suggested not to use in kernel, even checkpatch.pl > also gives warnings about it. Now sctp is using it for many structures. > > All this kind of typedef's using should be removed. As the 1st part, this > patchset

Re: [PATCH net-next] sctp: remove an unnecessary check from sctp_endpoint_destroy

On Thu, Jun 29, 2017 at 05:28:06PM +0800, Xin Long wrote: > ep->base.sk gets it's value since sctp_endpoint_new, nowhere > will change it. So there's no need to check if it's null, as > it can never be null. > > Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner

Re: [PATCH v3 net-next 00/12] bpf: rewrite value tracking in verifier

On 28/06/17 22:37, Alexei Starovoitov wrote: > Increasing the limit is must have, since pruning suffered so much. > Going from 53k to 76k is pretty substantial. > What is the % increase for tests in selftests/ ? When I tried to measure the test_verifier tests, they changed hardly at all, only a

WARN_ON_ONCE(work > weight) in napi_poll()

I occasionally hit WARN_ON_ONCE(work > weight); in napi_poll() on a laptop with ath10k card. [37207.593370] [ cut here ] [37207.593380] WARNING: CPU: 0 PID: 7 at ../net/core/dev.c:5274 net_rx_action+0x258/0x360 [37207.593381] Modules linked in: snd_hda_codec_realtek

Re: [PATCH v2] sctp: Add peeloff-flags socket option

On Fri, Jun 30, 2017 at 11:35:54AM -0400, Neil Horman wrote: > Based on a request raised on the sctp devel list, there is a need to > augment the sctp_peeloff operation while specifying the O_CLOEXEC and > O_NONBLOCK flags (simmilar to the socket syscall). Since modifying the >

[PATCH v2] Documentation: fix wrong example command

In the IPVLAN documentation there is an example command line where the master and slave interface names are inverted. Fix the command line and also add the optional `name' keyword to better describe what the command is doing. v2: added commit message Signed-off-by: Matteo Croce

Re: [PATCH RFC 02/26] task_work: Replace spin_unlock_wait() with lock/unlock pair

On Fri, Jun 30, 2017 at 05:20:10PM +0200, Oleg Nesterov wrote: > On 06/30, Paul E. McKenney wrote: > > > > > > + raw_spin_lock_irq(>pi_lock); > > > > + raw_spin_unlock_irq(>pi_lock); > > > > I agree that the spin_unlock_wait() implementations would avoid the > >

Re: [PATCH 00/29] Netfilter updates for net-next

From: Pablo Neira Ayuso Date: Fri, 30 Jun 2017 00:52:58 +0200 > The following patchset contains Netfilter updates for your net-next > tree. This batch contains connection tracking updates for the cleanup > iteration path, patches from Florian Westphal: ... > You can pull

Re: [PATCH net-next 1/6] net: add new netdevice feature for tunnel offloading

On Fri, 30 Jun 2017 15:19:45 +0200, Sabrina Dubroca wrote: > This adds a new netdevice feature, so that tunnel offloading can be > disabled by the administrator on some netdevices, using the > "tunnel-offload" ethtool feature. > > This feature is set for all devices that provide

[PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build for FPGA

Both the ethernet and FPGA portions of MLX5 now require the wq functions, and we get a link error when CONFIG_MLX5_CORE_EN is disabled: drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.o: In function `mlx5_fpga_conn_create_cq': conn.c:(.text+0x10b3): undefined reference to `mlx5_cqwq_create'

[PATCH v2] sctp: Add peeloff-flags socket option

Based on a request raised on the sctp devel list, there is a need to augment the sctp_peeloff operation while specifying the O_CLOEXEC and O_NONBLOCK flags (simmilar to the socket syscall). Since modifying the SCTP_SOCKOPT_PEELOFF socket option would break user space ABI for existing programs,

Re: [PATCH RFC 02/26] task_work: Replace spin_unlock_wait() with lock/unlock pair

On 06/30, Paul E. McKenney wrote: > > > > + raw_spin_lock_irq(>pi_lock); > > > + raw_spin_unlock_irq(>pi_lock); > > I agree that the spin_unlock_wait() implementations would avoid the > deadlock with an acquisition from an interrupt handler, while also > avoiding the need to

Re: [PATCH v2] netfilter: nfnetlink: Improve input length sanitization in nfnetlink_rcv

On Thu, Jun 29, 2017 at 6:22 PM, Pablo Neira Ayuso wrote: > On Tue, Jun 27, 2017 at 07:05:27PM +0200, Pablo Neira Ayuso wrote: >> On Tue, Jun 27, 2017 at 05:58:25PM +0200, Pablo Neira Ayuso wrote: >> > On Wed, Jun 07, 2017 at 03:50:38PM +0200, Mateusz Jurczyk wrote: >> > >

[PATCH net-next 2/2] sfc: correct comment on efx_mcdi_process_event

Fix out-of-date comment. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/mcdi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c index 00cd6a2..3df872f 100644 ---

[PATCH net-next 1/2] sfc: change Unknown MCDI event message to print full event.

From: Jon Cooper Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/mcdi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c index b942245..00cd6a2 100644

[PATCH net-next 0/2] sfc: small MCDI cleanups

Giving the full MCDI event rather than just the code can aid in debugging. While fixing this I noticed an outdated comment. Edward Cree (1): sfc: correct comment on efx_mcdi_process_event Jon Cooper (1): sfc: change Unknown MCDI event message to print full event.

Re: [PATCH net-next v3 1/9] net: switchdev: add SET_SWITCHDEV_OPS helper

On 29.6.2017 22:08, Simon Horman wrote: > Add a helper to allow switchdev ops to be set if NET_SWITCHDEV is configured > and do nothing otherwise. This allows for slightly cleaner code which > uses switchdev but does not select NET_SWITCHDEV. > > Signed-off-by: Simon Horman

[PATCH net-next] vxlan: correctly set vxlan->net when creating the device in a netns

Commit a985343ba906 ("vxlan: refactor verification and application of configuration") modified vxlan device creation, and replaced the assignment of vxlan->net to src_net with dev_net(netdev) in ->setup(). But dev_net(netdev) is not the same as src_net. At the time ->setup() is called, dev_net

Re: [PATCH net-next v3 1/2] cxgb4: Add PTP Hardware Clock (PHC) support

Having the get-ts patch extra is fine, but still this one can and should be broken down into 2 patches: 1. Transmit hardware SO_TIMESTAMPING 2. PHC support Let me explain ... On Fri, Jun 30, 2017 at 05:17:55PM +0530, Atul Gupta wrote: > @@ -2475,18 +2485,69 @@ static int cxgb_ioctl(struct

Re: [PATCH NET V5 2/2] net: hns: Use phy_driver to setup Phy loopback

> Any idea? Maybe consider what the self test is good for. My guess is, self test was added when a network interface card was a full size VME card, and had a couple of hundred components or more. They did break during there life, due to heat, mechanism stresses, causing parts to pop off the PCB,

[PATCH net-next 3/6] net: add infrastructure to un-offload UDP tunnel port

This adds a new NETDEV_UDP_TUNNEL_DROP_INFO event, similar to NETDEV_UDP_TUNNEL_PUSH_INFO, to signal to un-offload ports. This also adds udp_tunnel_drop_rx_port(), which calls ndo_udp_tunnel_del. Signed-off-by: Sabrina Dubroca --- include/linux/netdevice.h | 1 +

[PATCH net-next 4/6] net: call udp_tunnel_get_rx_info when NETIF_F_TUNNEL_OFFLOAD is toggled

NETIF_F_TUNNEL_OFFLOAD is special, in that we need to do more than just flip the bit in dev->features. When disabling we must also clear currently offloaded ports from the device, and when enabling we must tell the device to offload the ports it can. Because vxlan stores its sockets in a

[PATCH net-next 6/6] geneve/vxlan: offload ports on register/unregister events

This improves consistency of handling when moving a netdev to another netns. Most drivers currently do a full reset when the device goes up, so that will flush the offload state anyway. Signed-off-by: Sabrina Dubroca --- drivers/net/geneve.c | 7 ++-

  1   2   >