[PATCH] net: ipv6: sysctl to specify IPv6 ND traffic class

2017-11-07 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Add a per-device sysctl to specify the default traffic class to use for kernel originated IPv6 Neighbour Discovery packets. Currently this includes: - Router Solicitation (ICMPv6 type 133) ndisc_send_rs() -> ndisc_send_skb() -> ip6_nd_hdr() - Neighbour Solicit

regression: UFO removal breaks kvm live migration

2017-11-07 Thread Michal Kubecek
Hello, I just received this bug report: https://bugzilla.suse.com/show_bug.cgi?id=1066757 The reporter runs a live migration of a kvm guest from a host with kernel supporting UFO (openSUSE 42.2 or 42.3, based on 4.4) to a host with kernel with UFO support removed (SLE15 or openSUSE 15.0 pre-re

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

2017-11-07 Thread Alexei Starovoitov
On 11/7/17 12:55 AM, Naveen N. Rao wrote: I thought such struct shouldn't change layout. If it is we need to fix include/linux/compiler-clang.h to do that anon struct as well. We considered that, but it looked to be very dependent on the version of gcc used to build the kernel. But, this may be

Re: [PATCH] libceph: don't WARN() if user tries to add invalid key

2017-11-07 Thread Ilya Dryomov
On Tue, Nov 7, 2017 at 6:57 AM, Eric Biggers wrote: > From: Eric Biggers > > The WARN_ON(!key->len) in set_secret() in net/ceph/crypto.c is hit if a > user tries to add a key of type "ceph" with an invalid payload as > follows (assuming CONFIG_CEPH_LIB=y): > > echo -e -n '\x01\x00\x00\x00\x00

Re: [PATCH v2] can: Use common error handling code in vxcan_newlink()

2017-11-07 Thread Marc Kleine-Budde
On 11/01/2017 03:16 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 1 Nov 2017 14:56:15 +0100 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle software. > > Signed-o

RE: [EXT] Re: [PATCH net-next v2] net: mvpp2: add ethtool GOP statistics

2017-11-07 Thread Stefan Chulski
> -Original Message- > From: Miquel RAYNAL [mailto:miquel.ray...@free-electrons.com] > Sent: Tuesday, November 07, 2017 12:45 AM > To: Stefan Chulski > Cc: Thomas Petazzoni ; Antoine Tenart > ; David S. Miller > ; netdev@vger.kernel.org > Subject: [EXT] Re: [PATCH net-next v2] net: mvpp2

[PATCH net-next 2/2] tcp: Namespace-ify sysctl_tcp_rmem and sysctl_tcp_wmem

2017-11-07 Thread Eric Dumazet
Note that when a new netns is created, it inherits its sysctl_tcp_rmem and sysctl_tcp_wmem from initial netns. This change is needed so that we can refine TCP rcvbuf autotuning, to take RTT into consideration. Signed-off-by: Eric Dumazet Cc: Wei Wang --- include/net/netns/ipv4.h | 2 ++ inc

[PATCH net-next 1/2] net: allow per netns sysctl_rmem and sysctl_wmem for protos

2017-11-07 Thread Eric Dumazet
As we want to gradually implement per netns sysctl_rmem and sysctl_wmem on per protocol basis, add two new fields in struct proto, and two new helpers : sk_get_wmem0() and sk_get_rmem0() First user will be TCP. Then UDP and SCTP can be easily converted, while DECNET probably wont get this support.

[PATCH net-next 0/2] net: Namespace-ify sysctl_tcp_rmem and sysctl_tcp_wmem

2017-11-07 Thread Eric Dumazet
We need to get per netns sysctl for sysctl_[proto]_rmem and sysctl_[proto]_wmem This patch series adds the basic infrastructure allowing per proto conversion, and takes care of TCP. Eric Dumazet (2): net: allow per netns sysctl_rmem and sysctl_wmem for protos tcp: Namespace-ify sysctl_tcp_rme

[PATCH net-next 1/2] ip_gre: add the support for i/o_flags update via netlink

2017-11-07 Thread Xin Long
Now ip_gre is using ip_tunnel_changelink to update it's properties, but ip_tunnel_changelink in ip_tunnel doesn't update i/o_flags as a common function. o_flags updates would cause that tunnel->tun_hlen / hlen and dev->mtu / needed_headroom need to be recalculated, and dev->(hw_)features need to b

[PATCH net-next 0/2] ip_gre: add support for i/o_flags update

2017-11-07 Thread Xin Long
ip_gre is using as many ip_tunnel apis as possible, newlink works fine as gre would do it's own part in .ndo_init. But when changing link, ip_tunnel_changelink doesn't even update i/o_flags, and also the update of these flags would cause some other gre's properties need to be updated or recalculate

[PATCH net-next 2/2] ip_gre: add the support for i/o_flags update via ioctl

2017-11-07 Thread Xin Long
As patch 'ip_gre: add the support for i/o_flags update via netlink' did for netlink, we also need to do the same job for these update via ioctl. This patch is to update i/o_flags and call ipgre_link_update to recalculate these gre properties after ip_tunnel_ioctl does the common update. Signed-of

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

2017-11-07 Thread Naveen N. Rao
Alexei Starovoitov wrote: On 11/7/17 12:55 AM, Naveen N. Rao wrote: I thought such struct shouldn't change layout. If it is we need to fix include/linux/compiler-clang.h to do that anon struct as well. We considered that, but it looked to be very dependent on the version of gcc used to build t

Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module

2017-11-07 Thread Peter Zijlstra
On Tue, Nov 07, 2017 at 07:11:56AM +0100, Florian Westphal wrote: > Peter Zijlstra wrote: > > On Mon, Nov 06, 2017 at 11:51:07AM +0100, Florian Westphal wrote: > > > @@ -180,6 +164,12 @@ int __rtnl_register(int protocol, int msgtype, > > > rcu_assign_pointer(rtnl_msg_handlers[protocol],

Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module

2017-11-07 Thread Peter Zijlstra
On Tue, Nov 07, 2017 at 10:10:04AM +0100, Peter Zijlstra wrote: > On Tue, Nov 07, 2017 at 07:11:56AM +0100, Florian Westphal wrote: > > Peter Zijlstra wrote: > > > On Mon, Nov 06, 2017 at 11:51:07AM +0100, Florian Westphal wrote: > > > > @@ -180,6 +164,12 @@ int __rtnl_register(int protocol, int m

[rht_deferred_worker] watchdog: BUG: soft lockup - CPU#0 stuck for 23s! [kworker/0:1:15]

2017-11-07 Thread Fengguang Wu
Hello, FYI this happens in v4.14-rc8 -- it's not necessarily a new bug. [ 485.097496] rcu-torture: Reader Pipe: 2 0 0 0 0 0 0 0 0 0 0 [ 485.317082] rcu-torture: Reader Batch: 0 2 0 0 0 0 0 0 0 0 0 [ 485.809530] rcu-torture: Free-Block Circulation: 0 0 0 0 0 0 0 0 0 0 0 [ 486.097071] ??? Wr

Re: [PATCH 2/2] net: macb: add of_node_put to error paths

2017-11-07 Thread Nicolas Ferre
On 06/11/2017 at 12:10, Michael Grzeschik wrote: > We add the call of_node_put(bp->phy_node) to all associated error > paths for memory clean up. > > Signed-off-by: Michael Grzeschik > --- > drivers/net/ethernet/cadence/macb_main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dri

Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module

2017-11-07 Thread Florian Westphal
Peter Zijlstra wrote: > > rtnetlink_rcv_msg: > > > > 4406 dumpit = READ_ONCE(handlers[type].dumpit); > > 4407 if (!dumpit) > > 4408 goto err_unlock; > > 4409 owner = READ_ONCE(handlers[type].ow

Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac

2017-11-07 Thread Chris Zhong
On 2017年11月07日 15:54, Vladimir Zapolskiy wrote: Hello Chris, On 11/07/2017 04:49 AM, Chris Zhong wrote: The ethernet phy of rk3066a-rayeager has a reset pin, it controlled by GPIO1_D6, this pin should be pull down then pull up to reset the phy. Add a phy-reset property in emac, make the phy c

Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module

2017-11-07 Thread Florian Westphal
Peter Zijlstra wrote: > Something like the below would go some way toward sanitizing this stuff; > rcu_assign_pointer() is a store-release, meaning it happens after > everything coming before. > > Therefore, when you observe that tab (through rcu_dereference) you're > guaranteed to see the thing

Re: [PATCH 2/2] net: macb: add of_node_put to error paths

2017-11-07 Thread Michael Grzeschik
On Tue, Nov 07, 2017 at 10:27:20AM +0100, Nicolas Ferre wrote: > On 06/11/2017 at 12:10, Michael Grzeschik wrote: > > We add the call of_node_put(bp->phy_node) to all associated error > > paths for memory clean up. > > > > Signed-off-by: Michael Grzeschik > > --- > > drivers/net/ethernet/cadence

[PATCH v2] net: macb: add of_node_put to error paths

2017-11-07 Thread Michael Grzeschik
We add the call of_node_put(bp->phy_node) to all associated error paths for memory clean up. Signed-off-by: Michael Grzeschik --- v1 -> v2: removed extra of_node_put from macb_remove drivers/net/ethernet/cadence/macb_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ether

[PATCH][V2] netfilter: remove redundant assignment to e

2017-11-07 Thread Colin King
From: Colin Ian King The assignment to variable e is redundant since the same assignment occurs just a few lines later, hence it can be removed. Cleans up clang warning for arp_tables, ip_tables and ip6_tables: warning: Value stored to 'e' is never read Signed-off-by: Colin Ian King --- net/

Re: [PATCH v3 net-next 5/5] net: dsa: switch: Don't add CPU port to an mdb by default

2017-11-07 Thread Sergei Shtylyov
Hello! On 11/7/2017 2:26 AM, Andrew Lunn wrote: Now that the host indicates when a multicast group should be forwarded from the switch to the host, don't do it by default. Signed-off-by: Andrew Lunn --- net/dsa/switch.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/

[rht_deferred_worker] BUG: workqueue lockup - pool cpus=0 node=0 flags=0x0 nice=0 stuck for 33s!

2017-11-07 Thread Fengguang Wu
06:44:05 CST 2017 [0.00] Command line: ip=vm-lkp-os-openwrt-ia32-11::dhcp root=/dev/ram0 user=lkp job=/lkp/scheduled/vm-lkp-os-openwrt-ia32-11/boot-1-openwrt-i386-2016-03-16.cgz-39dae59d66acd86d1de24294bd2f343fd5e7a625-20171107-3579-gel5jo-0.yaml ARCH=x86_64 kconfig=x86_64-randconfig

[PATCH v4] scripts: add leaking_addresses.pl

2017-11-07 Thread Tobin C. Harding
Currently we are leaking addresses from the kernel to user space. This script is an attempt to find some of those leakages. Script parses `dmesg` output and /proc and /sys files for hex strings that look like kernel addresses. Only works for 64 bit kernels, the reason being that kernel addresses o

[PATCH] net/tcp: track all ipv4/tcp state transition in tcp_set_state

2017-11-07 Thread Yafang Shao
When I hooked the function tcp_set_state with kprobe to track the ipv4/tcp state transistion, I found state transition from TCP_LISTEN to TCP_SYN_RECV is missed. I think it is better to use the helper to do state transition instead of assigning the state to sk_state directly. Then we can monitor t

[PATCH] pktgen: document 32-bit timestamp overflow

2017-11-07 Thread Arnd Bergmann
Timestamps in pktgen are currently retrieved using the deprecated do_gettimeofday() function that wraps its signed 32-bit seconds in 2038 (on 32-bit architectures) and requires a division operation to calculate microseconds. The pktgen header is also defined with the same limitations, hardcoding t

Re: [PATCH v4] scripts: add leaking_addresses.pl

2017-11-07 Thread Greg KH
On Tue, Nov 07, 2017 at 09:32:11PM +1100, Tobin C. Harding wrote: > Currently we are leaking addresses from the kernel to user space. This > script is an attempt to find some of those leakages. Script parses > `dmesg` output and /proc and /sys files for hex strings that look like > kernel addresses

[PATCH net] bonding: fix slave stuck in BOND_LINK_FAIL state

2017-11-07 Thread Jay Vosburgh
The bonding miimon logic has a flaw, in that a failure of the rtnl_trylock can cause a slave to become permanently stuck in BOND_LINK_FAIL state. The sequence of events to cause this is as follows: 1) bond_miimon_inspect finds that a slave's link is down, and so calls bond

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Pravin Shelar
On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) >> > +{ >> > + struct nshhdr *nh; >> > + size_t length = nsh_hdr_len(pushed_nh); >> > + u8 next_proto

Re: [PATCH v2] net: macb: add of_node_put to error paths

2017-11-07 Thread Nicolas Ferre
On 07/11/2017 at 10:59, Michael Grzeschik wrote: > We add the call of_node_put(bp->phy_node) to all associated error > paths for memory clean up. > > Signed-off-by: Michael Grzeschik Thanks for your quick update: Acked-by: Nicolas Ferre Best regards, Nicolas > --- > v1 -> v2: removed extra

[PATCH net] Fixed NULL ptr deref in enqueue_to_backlog().

2017-11-07 Thread Stefan Kratochwil
Hey folks, I replaced the free_skb() call wit a dev_free_skb_any() and performed a few regression tests on the machines available to me. I was neither able to reproduce the crash while upping/downing can interfaces during operation, nor could I observe problems with ethernet connections on my targ

[PATCH] af_netlink: give correct bounds to dump skb for NLMSG_DONE

2017-11-07 Thread Jason A. Donenfeld
The way people generally use netlink_dump is that they fill in the skb as much as possible, breaking when nla_put returns an error. Then, they get called again and start filling out the next skb, and again, and so forth. The mechanism at work here is the ability for the iterative dumping function t

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Yang, Yi
On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: > >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) > >> > +{ > >> > + struct nshhdr *nh; > >> >

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Pravin Shelar
On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: >> > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: >> >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Yang, Yi
On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > >> > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote:

Re: [PATCH v3 01/21] grace: replace BUG_ON by WARN_ONCE in exit_net hook

2017-11-07 Thread Alexey Dobriyan
> - BUG_ON(!list_empty(grace_list)); > + WARN_ONCE(!list_empty(grace_list), > + "net %x %s: grace_list is not empty\n", > + net->ns.inum, __func__); * printing __func__ is unnecessary as it will be on top of the stacktrace anyway, * message duplicates condition

Re: [sock_def_readable] WARNING: bad unlock balance detected!

2017-11-07 Thread Fengguang Wu
Sorry please ignore this report -- according to Peter: This is fixed by commit: 02a7c234e540 ("rcu: Suppress lockdep false-positive ->boost_mtx complaints") The problem is that RCU boosting was mixing futex and !futex rt_mutex ops. On Tue, Nov 07, 2017 at 12:34:15PM +0800, Fengguang Wu wrote:

Re: [PATCH net-next V3 2/3] tools: bpftool: show filenames of pinned objects

2017-11-07 Thread Jakub Kicinski
On Mon, 6 Nov 2017 15:06:31 +0900, Prashant Bhole wrote: > Added support to show filenames of pinned objects. > ... > Signed-off-by: Prashant Bhole Thanks for the changes, a couple more nit picks, sorry for not spotting them earlier. > v2: > - Dynamically identify bpf-fs moutpoint > - Close f

[PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

2017-11-07 Thread Kristian Evensen
When we receive a packet on a QMI device in raw IP mode, we should call skb_reset_mac_header() to ensure that skb->mac_header contains a valid offset in the packet. While it shouldn't really matter, the packets have no MAC header and the interface is configured as-such, it seems certain parts of th

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Pravin Shelar
On Tue, Nov 7, 2017 at 3:55 AM, Yang, Yi wrote: > On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: >> On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: >> > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: >> >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: >> >> > O

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

2017-11-07 Thread Bjørn Mork
Kristian Evensen writes: > When we receive a packet on a QMI device in raw IP mode, we should call > skb_reset_mac_header() to ensure that skb->mac_header contains a valid > offset in the packet. While it shouldn't really matter, the packets have > no MAC header and the interface is configured as

[PATCH net-next v17] openvswitch: enable NSH support

2017-11-07 Thread Yi Yang
v16->17 - Fixed disputed check code: keep them in nsh_push and nsh_pop but also add them in __ovs_nla_copy_actions v15->v16 - Add csum recalculation for nsh_push, nsh_pop and set_nsh pointed out by Pravin - Move nsh key into the union with ipv4 and ipv6 and add check for nsh key in mat

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Yang, Yi
On Tue, Nov 07, 2017 at 05:01:28AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:55 AM, Yang, Yi wrote: > > On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > >> On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > >> > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar w

Re: [PATCH] netfilter: mark expected switch fall-throughs

2017-11-07 Thread Gustavo A. R. Silva
Hello Pablo, Quoting Pablo Neira Ayuso : Hi Gustavo, On Thu, Oct 19, 2017 at 09:06:16AM -0500, Gustavo A. R. Silva wrote: diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index cf84f7b..72f654a 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfil

[PATCH net-next v7 0/3] nfp act_vlan: Rewrite of the TC vlan action to use the RCU, and incorporated review comments

2017-11-07 Thread Manish Kurup
This commit consists of 3 patches: patch1 (1/3): The VLAN action maintains one set of stats across all cores, and uses a spinlock to synchronize updates to it from the same. Changed this to use a per-CPU stats context instead. This change will result in better performance. patch2 (2/3): Modified

[PATCH net-next v7 1/3] act_vlan: Change stats update to use per-core stats

2017-11-07 Thread Manish Kurup
The VLAN action maintains one set of stats across all cores, and uses a spinlock to synchronize updates to it from the same. Changed this to use a per-CPU stats context instead. This change will result in better performance. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko Signed-off-by: Manish K

[PATCH net-next v7 2/3] nfp flower action: Modified to use VLAN helper functions

2017-11-07 Thread Manish Kurup
Modified netronome nfp flower action to use VLAN helper functions instead of accessing/referencing TC act_vlan private structures directly. Reviewed-by: Pieter Jansen van Vuuren Signed-off-by: Manish Kurup --- drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++--- 1 file changed, 2 inser

RE: [PATCH v4] scripts: add leaking_addresses.pl

2017-11-07 Thread David Laight
From: Tobin C. Harding > Sent: 07 November 2017 10:32 > > Currently we are leaking addresses from the kernel to user space. This > script is an attempt to find some of those leakages. Script parses > `dmesg` output and /proc and /sys files for hex strings that look like > kernel addresses. ... May

[PATCH] [net-next] netfilter: add ifdef around ctnetlink_proto_size

2017-11-07 Thread Arnd Bergmann
This function is no longer marked 'inline', so we now get a warning when it is unused: net/netfilter/nf_conntrack_netlink.c:536:15: error: 'ctnetlink_proto_size' defined but not used [-Werror=unused-function] We could mark it inline again, mark it __maybe_unused, or add an #ifdef around the defi

[PATCH v2] netfilter: mark expected switch fall-throughs

2017-11-07 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1128839 Addresses-Coverity-ID: 1128840 Addresses-Coverity-ID: 115120 Addresses-Coverity-ID: 115121 Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Replace cod

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

2017-11-07 Thread Kristian Evensen
Hei, On Tue, Nov 7, 2017 at 2:02 PM, Bjørn Mork wrote: > And his should probably go to stable as well? with a > > Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode") Yes, I forgot to add the fixes-tag + comment about stable. Should I submit a v2? -Kristian

Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module

2017-11-07 Thread Peter Zijlstra
On Tue, Nov 07, 2017 at 10:47:51AM +0100, Florian Westphal wrote: > I would expect this to trigger all the time, due to > > rtnl_register(AF_INET, RTM_GETROUTE, ... > rtnl_register(AF_INET, RTM_GETADDR, ... Ah, sure, then something like so then... There's bound to be bugs there too, as I pretty

[PATCH RFC v1] caif: Use common error handling code in cfdgml_receive()

2017-11-07 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 7 Nov 2017 11:30:25 +0100 * Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. * Adjust two condition checks. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v

Re: mlx5 broken affinity

2017-11-07 Thread Thomas Gleixner
On Sun, 5 Nov 2017, Sagi Grimberg wrote: > > > > This wasn't to start a debate about which allocation method is the > > > > perfect solution. I am perfectly happy with the new default, the part > > > > that is broken is to take away the user's option to reassign the > > > > affinity. That is a bug

[PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

2017-11-07 Thread Fabrizio Castro
Document "renesas,can-r8a7743" and "renesas,can-r8a7745" compatible strings. Since the fallback compatible string ("renesas,rcar-gen2-can") activates the right code in the driver, no driver change is needed. Signed-off-by: Fabrizio Castro Reviewed-by: Biju Das --- Documentation/devicetree/bindi

[PATCH 0/8] Add CAN support to iwg2[02]d

2017-11-07 Thread Fabrizio Castro
Hello, this series delivers all of the changes necessary to add CAN bus support to the: * iW-RainboW-G22D SODIMM, and * iW-RainboW-G20M-Qseven-RZG1M development platforms, including documentation, pinctrl driver, SoC specific device trees, and board specific device trees. This work has been based

[PATCH net-next v7 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update

2017-11-07 Thread Manish Kurup
Using a spinlock in the VLAN action causes performance issues when the VLAN action is used on multiple cores. Rewrote the VLAN action to use RCU read locking for reads and updates instead. All functions now use an RCU dereferenced pointer to access the VLAN action context. Modified helper functions

Re: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

2017-11-07 Thread Geert Uytterhoeven
On Tue, Nov 7, 2017 at 4:10 PM, Fabrizio Castro wrote: > Document "renesas,can-r8a7743" and "renesas,can-r8a7745" compatible > strings. Since the fallback compatible string ("renesas,rcar-gen2-can") > activates the right code in the driver, no driver change is needed. > > Signed-off-by: Fabrizio C

[PULL] virtio: last minute bugfix

2017-11-07 Thread Michael S. Tsirkin
We had a lot of trouble agreeing on a fix, but apparently there's finally a consensus. The following changes since commit 39dae59d66acd86d1de24294bd2f343fd5e7a625: Linux 4.14-rc8 (2017-11-05 13:05:14 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/gi

[PATCH net] rds: ib: Fix NULL pointer dereference in debug code

2017-11-07 Thread Håkon Bugge
rds_ib_recv_refill() is a function that refills an IB receive queue. It can be called from both the CQE handler (tasklet) and a worker thread. Just after the call to ib_post_recv(), a debug message is printed with rdsdebug(): ret = ib_post_recv(ic->i_cm_id->qp, &recv->r_wr, &failed_wr

[PATCH] net: vxge: remove redundant assignments and pointers

2017-11-07 Thread Colin King
From: Colin Ian King There are several pointers that are being assigned but never read so remove these as they are redundant. Also remove an assignment to function_mode that is never read. Cleans up several clang warnings: vxge-main.c:1139:2: warning: Value stored to 'hldev' is never read vxge-

Re: [PATCH v4] scripts: add leaking_addresses.pl

2017-11-07 Thread Petr Mladek
On Tue 2017-11-07 21:32:11, Tobin C. Harding wrote: > Currently we are leaking addresses from the kernel to user space. This > script is an attempt to find some of those leakages. Script parses > `dmesg` output and /proc and /sys files for hex strings that look like > kernel addresses. > > Only wo

Fwd: [PATCH RESEND] Fix segfault on "lldptool -t -i eth2 -V PFC -c enabled"

2017-11-07 Thread Sowmini Varadhan
We are trying to use DCBX via lldpad for some of our applications, and finding/fixing bugs and enhancements as we go. However our attempts to upstream these fixes is encountering silence from the lldp-devel list e.g., http://lists.open-lldp.org/pipermail/lldp-devel/2017-October/001252.html An

[PATCH] ip_gre: fix ip-config error reported by lkp-robot

2017-11-07 Thread William Tu
lkp-robot reports the following two errors: IP-Config: Failed to open gretap0 IP-Config: Failed to open erspan0 due to device's mac address is zero. Fix it by assigning a random Ethernet address. Signed-off-by: William Tu --- net/ipv4/ip_gre.c | 6 ++ 1 file changed, 6 insertions(+) di

Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac

2017-11-07 Thread Andrew Lunn
> As a side question, which is mainly addressed to Sergei and Roger, > I don't quite understand why PHY properties were initially added to > MAC/MDIO bus device tree nodes, in my opinion they must be moved under > PHY device tree nodes. If you look at the implementation, they are not actually PHY

Re: [mdiobus_free] BUG: KASAN: slab-out-of-bounds in _copy_from_user+0x5d/0x8f

2017-11-07 Thread Linus Torvalds
On Tue, Nov 7, 2017 at 4:15 AM, Fengguang Wu wrote: > Sorry please ignore this report -- according to Andrey, old gcc may > well generate false KASAN reports. Oh wow, this gcc is even older than the other one that caused slob problems.. >> Linux version 4.14.0-rc8 (kbuild@intel11) (gcc version 4

[PATCH RFC v1] 9p/trans_fd: Use common error handling code in p9_fd_create_tcp()

2017-11-07 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 7 Nov 2017 10:05:20 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v1 - Request for comments: I can offer

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-07 Thread Linus Torvalds
On Tue, Nov 7, 2017 at 2:21 AM, Fengguang Wu wrote: > > FYI this happens in v4.14-rc8 -- it's not necessarily a new bug. Probably not. Looks like a use-after-free bug in vlan_device_event() judging by the base pointer: ECX: 6b6b6b6b this is one of those circumstances where having the faddr

[PATCH net] i40e: fix the calculation of VFs mac addresses

2017-11-07 Thread Nicolas Dichtel
From: Zijie Pan num_mac should be increased only after the call to i40e_add_mac_filter(). Fixes: 5f527ba962e2 ("i40e: Limit the number of MAC and VLAN addresses that can be added for VFs") CC: Anjali Singhai Jain CC: Andrew Bowers Signed-off-by: Zijie Pan Signed-off-by: Nicolas Dichtel ---

[PATCH 0/2] kbuild: remove all "obj- := dummy.o" tricks

2017-11-07 Thread Masahiro Yamada
This clean-up was prompted by Sam when I refactored DT building: https://patchwork.kernel.org/patch/10041881/ If you want to test this series, apply the following 3 patches: https://patchwork.kernel.org/patch/10037891/ https://patchwork.kernel.org/patch/10041877/ https://patchwork.kernel.org/patc

[PATCH v3 1/2] selftests: bpf: test_kmod.sh: check the module path before insmod

2017-11-07 Thread naresh . kamboju
From: Naresh Kamboju test_kmod.sh reported false failure when module not present. Instead check test_bpf.ko is present in the path before loading it. Signed-off-by: Naresh Kamboju --- tools/testing/selftests/bpf/test_kmod.sh | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff -

[PATCH v3 2/2] selftests: bpf: test_kmod.sh: use modprobe on target device

2017-11-07 Thread naresh . kamboju
From: Naresh Kamboju On ARM and ARM64 devices kernel source tree is not available so insmod "$SRC_TREE/lib/test_bpf.ko" is not working. On these target devices the test_bpf.ko is installed under /lib/modules/`uname -r`/kernel/lib/ so use modprobe dry run to check for missing test_bpf.ko module a

[PATCH 2/2] kbuild: remove all dummy assignments to obj-

2017-11-07 Thread Masahiro Yamada
Now kbuild core scripts create empty built-in.o where necessary. Remove "obj- := dummy.o" tricks. Signed-off-by: Masahiro Yamada --- arch/arm/mach-uniphier/Makefile | 1 - arch/mips/boot/dts/brcm/Makefile | 3 --- arch/mips/boot/dts/cavium-octeon/Makefile | 3 --- arch/mips/b

Re: [PATCH net] rds: ib: Fix NULL pointer dereference in debug code

2017-11-07 Thread Santosh Shilimkar
On 11/7/2017 7:33 AM, Håkon Bugge wrote: rds_ib_recv_refill() is a function that refills an IB receive queue. It can be called from both the CQE handler (tasklet) and a worker thread. Just after the call to ib_post_recv(), a debug message is printed with rdsdebug(): ret = ib_post_r

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-07 Thread Fengguang Wu
On Tue, Nov 07, 2017 at 08:25:03AM -0800, Linus Torvalds wrote: On Tue, Nov 7, 2017 at 2:21 AM, Fengguang Wu wrote: FYI this happens in v4.14-rc8 -- it's not necessarily a new bug. Probably not. Looks like a use-after-free bug in vlan_device_event() judging by the base pointer: ECX: 6b6

Re: [PATCH net-next v6 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update

2017-11-07 Thread Alexander Duyck
On Mon, Nov 6, 2017 at 10:37 AM, Pieter Jansen van Vuuren wrote: > On Fri, 3 Nov 2017 11:50:47 -0400 > Manish Kurup wrote: > >> Using a spinlock in the VLAN action causes performance issues when the VLAN >> action is used on multiple cores. Rewrote the VLAN action to use RCU read >> locking for

Re: [PATCH v3 1/2] selftests: bpf: test_kmod.sh: check the module path before insmod

2017-11-07 Thread Shuah Khan
On 11/07/2017 09:35 AM, naresh.kamb...@linaro.org wrote: > From: Naresh Kamboju Odd to see this From: line in the patch. Could you take a look and see where this is coming from? Your gitconfig perhaps. I have to fix this up when I apply the patch which I would like to avoid. > > test_kmod.sh r

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-07 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > Then starts the work passing down to the hardware that the host has > joined/left a group. The existing switchdev mdb object cannot be used, > since the semantics are different. The existing > SWITCHDEV_OBJ_ID_PORT_MDB is used to indicate a specific multicast > g

Re: [PATCH net-next v6 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update

2017-11-07 Thread Pieter Jansen van Vuuren
On Tue, 7 Nov 2017 08:54:20 -0800 Alexander Duyck wrote: > On Mon, Nov 6, 2017 at 10:37 AM, Pieter Jansen van Vuuren > wrote: > > On Fri, 3 Nov 2017 11:50:47 -0400 > > Manish Kurup wrote: > > > >> Using a spinlock in the VLAN action causes performance issues when > >> the VLAN action is used

Re: [PATCH v3 2/2] selftests: bpf: test_kmod.sh: use modprobe on target device

2017-11-07 Thread Shuah Khan
On 11/07/2017 09:35 AM, naresh.kamb...@linaro.org wrote: > From: Naresh Kamboju Odd to see this From: line in the patch. Could you take a look and see where this is coming from? Your gitconfig perhaps. I have to fix this up when I apply the patch which I would like to avoid. > > On ARM and ARM

Re: [PULL] virtio: last minute bugfix

2017-11-07 Thread Linus Torvalds
On Tue, Nov 7, 2017 at 7:28 AM, Michael S. Tsirkin wrote: > We had a lot of trouble agreeing on a fix, but apparently there's > finally a consensus. This is big and doesn't have a sign-off on the commit itself, even if you then do it in the tag. That's not how this is all supposed to work. I gu

Re: [PULL] virtio: last minute bugfix

2017-11-07 Thread Linus Torvalds
On Tue, Nov 7, 2017 at 9:23 AM, Linus Torvalds wrote: > > I guess I'll take it, but please don't do things like this to me. Oh no I wont. The garbage you sent me doesn't even compile cleanly, and is utter shite. Not acceptable for last-minute bugfixes, and you're now on my shit-list.

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-07 Thread Egil Hjelmeland
On 07. nov. 2017 00:26, Andrew Lunn wrote: The linux bridge supports IGMP snooping. It will listen to IGMP reports on bridge ports and keep track of which groups have been joined on an interface. It will then forward multicast based on this group membership. When the bridge adds or removed group

Re: [PATCH net-next 1/2] ip_gre: add the support for i/o_flags update via netlink

2017-11-07 Thread William Tu
On Tue, Nov 7, 2017 at 12:33 AM, Xin Long wrote: > Now ip_gre is using ip_tunnel_changelink to update it's properties, but > ip_tunnel_changelink in ip_tunnel doesn't update i/o_flags as a common > function. > > o_flags updates would cause that tunnel->tun_hlen / hlen and dev->mtu / > needed_headr

Re: [PATCH net-next 2/2] ip_gre: add the support for i/o_flags update via ioctl

2017-11-07 Thread William Tu
On Tue, Nov 7, 2017 at 12:33 AM, Xin Long wrote: > As patch 'ip_gre: add the support for i/o_flags update via netlink' > did for netlink, we also need to do the same job for these update > via ioctl. > > This patch is to update i/o_flags and call ipgre_link_update to > recalculate these gre proper

[PATCH net-next] sfc: don't warn on successful change of MAC

2017-11-07 Thread Bert Kenward
From: Robert Stonehouse Fixes: 535a61777f44e ("sfc: suppress handled MCDI failures when changing the MAC address") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/e

[PATCH net-next v4] net: mvpp2: add ethtool GOP statistics

2017-11-07 Thread Miquel Raynal
Add ethtool statistics support by reading the GOP statistics from the hardware counters. Also implement a workqueue to gather the statistics every second or some 32-bit counters could overflow. Suggested-by: Stefan Chulski Signed-off-by: Miquel Raynal Reviewed-by: Andrew Lunn --- Hi, Stefan s

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-07 Thread Andrew Lunn
On Tue, Nov 07, 2017 at 12:03:54PM -0500, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > Then starts the work passing down to the hardware that the host has > > joined/left a group. The existing switchdev mdb object cannot be used, > > since the semantics are different. The exi

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-07 Thread Andrew Lunn
> Hi Andrew! > > I tested this series today on my board with lan9303, and it does seem to > work. But no extensive testing though. Cool, thanks. I've only been able to test on Marvell hardware. > Some observations, not meant to delay the series: > > When local application join multicast; the dr

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-07 Thread Florian Fainelli
Hi Andrew, On 11/07/2017 09:42 AM, Andrew Lunn wrote: > On Tue, Nov 07, 2017 at 12:03:54PM -0500, Vivien Didelot wrote: >> Hi Andrew, >> >> Andrew Lunn writes: >> >>> Then starts the work passing down to the hardware that the host has >>> joined/left a group. The existing switchdev mdb object can

Re: [PULL] virtio: last minute bugfix

2017-11-07 Thread Michael S. Tsirkin
On Tue, Nov 07, 2017 at 09:29:59AM -0800, Linus Torvalds wrote: > On Tue, Nov 7, 2017 at 9:23 AM, Linus Torvalds > wrote: > > > > I guess I'll take it, but please don't do things like this to me. > > Oh no I wont. > > The garbage you sent me doesn't even compile cleanly, and is utter shite. > >

Re: [PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

2017-11-07 Thread Richard Cochran
On Mon, Nov 06, 2017 at 06:55:46AM -0800, Richard Cochran wrote: > When I run with Layer2 transport and the switch as master, it seems to > work. Any other combination of role + transport fails. Oops, I had "slaveOnly" set in my PC's configuration. So layer2 seems to work as expected. Have you

Re: [PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

2017-11-07 Thread Richard Cochran
On Mon, Nov 06, 2017 at 04:04:22PM +0100, Andrew Lunn wrote: > I assume you have tested basic networking? You can ping the other > machines in the network? Yes, I ssh into the device via the external switch port interface. Thanks, Richard

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-07 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> > Then starts the work passing down to the hardware that the host has >> > joined/left a group. The existing switchdev mdb object cannot be used, >> > since the semantics are different. The existing >> > SWITCHDEV_OBJ_ID_PORT_MDB is used to indicate a specific m

Re: [PATCH net] i40e: fix the calculation of VFs mac addresses

2017-11-07 Thread Tushar Dave
On 11/07/2017 08:32 AM, Nicolas Dichtel wrote: From: Zijie Pan num_mac should be increased only after the call to i40e_add_mac_filter(). Fixes: 5f527ba962e2 ("i40e: Limit the number of MAC and VLAN addresses that can be added for VFs") CC: Anjali Singhai Jain CC: Andrew Bowers Signed-off-

Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac

2017-11-07 Thread Florian Fainelli
On 11/07/2017 01:51 AM, Chris Zhong wrote: > > > On 2017年11月07日 15:54, Vladimir Zapolskiy wrote: >> Hello Chris, >> >> On 11/07/2017 04:49 AM, Chris Zhong wrote: >>> The ethernet phy of rk3066a-rayeager has a reset pin, it controlled by >>> GPIO1_D6, this pin should be pull down then pull up to r

Re: [patch net-next 3/9] net_sch: cbs: Change TC_SETUP_CBS to TC_SETUP_QDISC_CBS

2017-11-07 Thread Vinicius Costa Gomes
Hi, Jiri Pirko writes: > From: Nogah Frankel > > Change TC_SETUP_CBS to TC_SETUP_QDISC_CBS to match the new convention.. > > Signed-off-by: Nogah Frankel > Signed-off-by: Jiri Pirko > --- > drivers/net/ethernet/intel/igb/igb_main.c | 2 +- > include/linux/netdevice.h | 2 +- >

[PATCH] zd1201: remove unused variable framelen

2017-11-07 Thread Colin King
From: Colin Ian King Variable framelen is assigned but never read, hence it is redundant and can be removed. Cleans up clang warning: drivers/net/wireless/zydas/zd1201.c:234:3: warning: Value stored to 'framelen' is never read Signed-off-by: Colin Ian King --- drivers/net/wireless/zydas/zd120

  1   2   3   4   >