[PATCH V2 6/8] net: stmmac: add dwmac-4.20a compatible

Manage dwmac-4.20a version from synopsys Signed-off-by: Christophe Roullier --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac

Re: [PATCH] net: stmmac: Avoid VLA usage

On 05/02/2018 04:07 PM, Jose Abreu wrote: On 02-05-2018 13:36, Kees Cook wrote: On Wed, May 2, 2018 at 1:54 AM, Jose Abreu wrote: Hi Kees, On 01-05-2018 22:01, Kees Cook wrote: In the quest to remove all stack VLAs from the kernel[1], this switches the "status" stack buffer to use the ex

Re: [PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

On 05/02/2018 10:17 AM, Michael S. Tsirkin wrote: > On Wed, May 02, 2018 at 10:00:14AM -0400, Vlad Yasevich wrote: >> On 05/02/2018 09:46 AM, Michael S. Tsirkin wrote: >>> On Wed, May 02, 2018 at 09:27:00AM -0400, Vlad Yasevich wrote: On 05/01/2018 11:24 PM, Michael S. Tsirkin wrote: > On

Re: [PATCH v2] net/mlx4_en: fix potential use-after-free with dma_unmap_page

From: Tariq Toukan Date: Wed, 2 May 2018 16:50:28 +0300 > This patch fixes an issue existing in old kernels. It is not relevant > per latest code. > > So I'm not sure about the process. After I review it, do I just submit > it again for -stable? If that's the case, yes that is what you do, just

Re: [PATCH] Revert "vhost: make msg padding explicit"

From: "Michael S. Tsirkin" Date: Wed, 2 May 2018 17:19:05 +0300 > This reverts commit 93c0d549c4c5a7382ad70de6b86610b7aae57406. > > Unfortunately the padding will break 32 bit userspace. > Ouch. Need to add some compat code, revert for now. > > Signed-off-by: Michael S. Tsirkin Applied, thank

Re: [PATCH RFC iproute2-next 2/2] rdma: print provider resource attributes

On Wed, 2 May 2018 16:38:52 +0300 Leon Romanovsky wrote: > On Mon, Apr 30, 2018 at 08:25:24AM -0700, Stephen Hemminger wrote: > > On Mon, 30 Apr 2018 07:36:18 -0700 > > Steve Wise wrote: > > > > > +#define nla_type(attr) ((attr)->nla_type & NLA_TYPE_MASK) > > > + > > > +void newline(struct rd

Re: [PATCH V2 net-next 1/6] virtio: Add support for SCTP checksum offloading

On Wed, May 02, 2018 at 05:21:38PM +0300, Michael S. Tsirkin wrote: > On Wed, May 02, 2018 at 11:14:13AM -0300, Marcelo Ricardo Leitner wrote: > > On Wed, May 02, 2018 at 06:16:45AM +0300, Michael S. Tsirkin wrote: > > > On Tue, May 01, 2018 at 10:07:34PM -0400, Vladislav Yasevich wrote: > > > > To

Re: [PATCH V2 net-next 2/6] sctp: Handle sctp packets with CHECKSUM_PARTIAL

On Tue, May 01, 2018 at 10:07:35PM -0400, Vladislav Yasevich wrote: > With SCTP checksum offload available in virtio, it is now > possible for virtio to receive a sctp packet with CHECKSUM_PARTIAL > set (guest-to-guest traffic). SCTP doesn't really have a > partial checksum like TCP does, because

Re: [PATCH] vhost: make msg padding explicit

On Wed, May 02, 2018 at 05:19:27PM +0300, Michael S. Tsirkin wrote: > On Wed, May 02, 2018 at 10:04:46AM -0400, David Miller wrote: > > From: "Michael S. Tsirkin" > > Date: Wed, 2 May 2018 16:36:37 +0300 > > > > > Ouch. True - and in particular the 32 bit ABI on 64 bit kernels doesn't > > > work

Re: [PATCH V2 6/8] net: stmmac: add dwmac-4.20a compatible

Hi Christophe, On 02-05-2018 15:18, Christophe Roullier wrote: > Manage dwmac-4.20a version from synopsys > > Just being curious: Can you tell me which HW features do you have on your NIC? Thanks and Best Regards, Jose Miguel Abreu

Re: [PATCH net-next 0/4] net/smc: fixes 2018/04/30

On 05/01/2018 03:03 AM, David Miller wrote: > From: Ursula Braun > Date: Mon, 30 Apr 2018 16:51:15 +0200 > >> From: Ursula Braun >> >> Dave, >> >> here are 4 smc patches for net-next covering different areas: >>* link health check >>* diagnostics for IPv6 smc sockets >>* ioctl >>

Re: [PATCH V2 net-next 4/6] tun: Add support for SCTP checksum offload

On Tue, May 01, 2018 at 10:07:37PM -0400, Vladislav Yasevich wrote: > Adds a new tun offload flag to allow for SCTP checksum offload. > The flag has to be set by the user and defaults to "no offload". I'm confused here: > +++ b/drivers/net/tun.c > @@ -216,7 +216,7 @@ struct tun_struct { > s

[PATCH net 1/1] net/smc: restrict non-blocking connect finish

The smc_poll code tries to finish connect() if the socket is in state SMC_INIT and polling of the internal CLC-socket returns with EPOLLOUT. This makes sense for a select/poll call following a connect call, but not without preceding connect(). With this patch smc_poll starts connect logic only, if

Re: [PATCH V2 net-next 4/6] tun: Add support for SCTP checksum offload

On Wed, May 02, 2018 at 11:53:47AM -0300, Marcelo Ricardo Leitner wrote: > On Tue, May 01, 2018 at 10:07:37PM -0400, Vladislav Yasevich wrote: > > Adds a new tun offload flag to allow for SCTP checksum offload. > > The flag has to be set by the user and defaults to "no offload". > > I'm confused he

[PATCH net-next v2 3/4] net/smc: handle ioctls SIOCINQ, SIOCOUTQ, and SIOCOUTQNSD

SIOCINQ returns the amount of unread data in the RMB. SIOCOUTQ returns the amount of unsent or unacked sent data in the send buffer. SIOCOUTQNSD returns the amount of data prepared for sending, but not yet sent. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 33 ++

[PATCH net-next v2 4/4] net/smc: determine vlan_id of stacked net_device

An SMC link group is bound to a specific vlan_id. Its link uses the RoCE-GIDs established for the specific vlan_id. This patch makes sure the appropriate vlan_id is determined for stacked scenarios like for instance a master bonding device with vlan devices enslaved. Signed-off-by: Ursula Braun -

[PATCH net-next v2 1/4] net/smc: periodic testlink support

From: Karsten Graul Add periodic LLC testlink support to ensure the link is still active. The interval time is initialized using the value of sysctl_tcp_keepalive_time. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 6 -- net/smc/smc_core.c | 2 ++ net

[PATCH net-next v2 0/4] net/smc: small features 2018/04/30

From: Ursula Braun Dave, here are 4 smc patches for net-next covering small new features in different areas: * link health check * diagnostics for IPv6 smc sockets * ioctl * improvement for vlan determination v2 changes: * better title * patch 2 - remove compile problem for di

[PATCH net-next v2 2/4] net/smc: ipv6 support for smc_diag.c

From: Karsten Graul Update smc_diag.c to support ipv6 addresses on the diagnosis interface. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- net/smc/smc_diag.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/net/smc/smc_

Re: [PATCH net-next] udp: Complement partial checksum for GSO packet

From: Willem de Bruijn Date: Wed, 2 May 2018 11:25:43 +0200 > On Tue, May 1, 2018 at 12:06 PM, Willem de Bruijn > wrote: >> On Tue, May 1, 2018 at 2:01 AM, Sean Tranchetti >> wrote: >>> Using the udp_v4_check() function to calculate the pseudo header >>> for the newly segmented UDP packets res

Re: [PATCH net-next v2 00/15] ARM: sun8i: r40: Add Ethernet support

From: Chen-Yu Tsai Date: Wed, 2 May 2018 00:12:12 +0800 > This is v2 of my R40 Ethernet support series. There are a lot of non-networking changes in here, in particular DTS changes and modifications to clock drivers. Are all parties involved OK with the entire series going into net-next? Than

Re: [PATCH net-next v2 00/15] ARM: sun8i: r40: Add Ethernet support

From: Chen-Yu Tsai Date: Wed, 2 May 2018 00:33:45 +0800 > I should've mentioned that patches 3 ~ 10, and only these, should go > through net-next. sunxi will handle the remaining clk, device tree, and > soc driver patches. Ok, I just noticed this. Why don't you just post those patches separatel

Re: [PATCH net-next] liquidio VF: indicate that disabling rx vlan offload is not allowed

From: Felix Manlunas Date: Tue, 1 May 2018 10:32:10 -0700 > From: Raghu Vatsavayi > > NIC firmware does not support disabling rx vlan offload, but the VF driver > incorrectly indicates that it is supported. The PF driver already does the > correct indication by clearing the NETIF_F_HW_VLAN_CTA

Re: [PATCH] net: ethernet: ti: cpsw: fix packet leaking in dual_mac mode

From: Grygorii Strashko Date: Tue, 1 May 2018 12:41:22 -0500 > In dual_mac mode packets arrived on one port should not be forwarded by > switch hw to another port. Only Linux Host can forward packets between > ports. The below test case (reported in [1]) shows that packet arrived on > one port ca

[PATCH net-next v7 5/7] sch_cake: Add DiffServ handling

This adds support for DiffServ-based priority queueing to CAKE. If the shaper is in use, each priority tier gets its own virtual clock, which limits that tier's rate to a fraction of the overall shaped rate, to discourage trying to game the priority mechanism. CAKE defaults to a simple, three-tier

[PATCH net-next v7 6/7] sch_cake: Add overhead compensation support to the rate shaper

This commit adds configurable overhead compensation support to the rate shaper. With this feature, userspace can configure the actual bottleneck link overhead and encapsulation mode used, which will be used by the shaper to calculate the precise duration of each packet on the wire. This feature is

[PATCH net-next v7 7/7] sch_cake: Conditionally split GSO segments

At lower bandwidths, the transmission time of a single GSO segment can add an unacceptable amount of latency due to HOL blocking. Furthermore, with a software shaper, any tuning mechanism employed by the kernel to control the maximum size of GSO segments is thrown off by the artificial limit on ban

[PATCH net-next v7 4/7] sch_cake: Add NAT awareness to packet classifier

When CAKE is deployed on a gateway that also performs NAT (which is a common deployment mode), the host fairness mechanism cannot distinguish internal hosts from each other, and so fails to work correctly. To fix this, we add an optional NAT awareness mode, which will query the kernel conntrack me

[PATCH net-next v7 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20

Re: [PATCH] net: stmmac: Avoid VLA usage

From: Kees Cook Date: Tue, 1 May 2018 14:01:30 -0700 > In the quest to remove all stack VLAs from the kernel[1], this switches > the "status" stack buffer to use the existing small (8) upper bound on > how many queues can be checked for DMA, and adds a sanity-check just to > make sure it doesn't

[PATCH net-next v7 2/7] sch_cake: Add ingress mode

The ingress mode is meant to be enabled when CAKE runs downlink of the actual bottleneck (such as on an IFB device). The mode changes the shaper to also account dropped packets to the shaped rate, as these have already traversed the bottleneck. Enabling ingress mode will also tune the AQM to alway

[PATCH net-next v7 3/7] sch_cake: Add optional ACK filter

The ACK filter is an optional feature of CAKE which is designed to improve performance on links with very asymmetrical rate limits. On such links (which are unfortunately quite prevalent, especially for DSL and cable subscribers), the downstream throughput can be limited by the number of ACKs capab

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

On Wed, May 02, 2018 at 04:51:01PM +0300, Michael S. Tsirkin wrote: > On Wed, May 02, 2018 at 03:28:19PM +0800, Tiwei Bie wrote: > > On Wed, May 02, 2018 at 10:51:06AM +0800, Jason Wang wrote: > > > On 2018年04月25日 13:15, Tiwei Bie wrote: > > > > This commit introduces the event idx support in packe

Re: [PATCH net] tcp_bbr: fix to zero idle_restart only upon S/ACKed data

From: Neal Cardwell Date: Tue, 1 May 2018 21:45:41 -0400 > Previously the bbr->idle_restart tracking was zeroing out the > bbr->idle_restart bit upon ACKs that did not SACK or ACK anything, > e.g. receiving incoming data or receiver window updates. In such > situations BBR would forget that this

[PATCH net-next v7 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

This patch series adds the CAKE qdisc, and has been split up to ease review. I have attempted to split out each configurable feature into its own patch. The first commit adds the base shaper and packet scheduler, while subsequent commits add the optional features. The full userspace API and most d

[PATCH v2 1/2] net: phy: broadcom: add support for BCM89610 PHY

It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) transceiver which is used in P3310 Tegra186 platform. Signed-off-by: Bhadram Varka --- drivers/net/phy/broadcom.c | 10 ++ include/linux/brcmphy.h| 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/net/phy/broad

Re: [PATCH net] sctp: use the old asoc when making the cookie-ack chunk in dupcook_d

From: Xin Long Date: Wed, 2 May 2018 13:39:46 +0800 > When processing a duplicate cookie-echo chunk, for case 'D', sctp will > not process the param from this chunk. It means old asoc has nothing > to be updated, and the new temp asoc doesn't have the complete info. > > So there's no reason to

Re: [PATCH net] sctp: init active key for the new asoc in dupcook_a and dupcook_b

From: Xin Long Date: Wed, 2 May 2018 13:37:44 +0800 > When processing a duplicate cookie-echo chunk, for case 'A' and 'B', > after sctp_process_init for the new asoc, if auth is enabled for the > cookie-ack chunk, the active key should also be initialized. > > Otherwise, the cookie-ack chunk ma

Re: [PATCH net] sctp: fix the issue that the cookie-ack with auth can't get processed

From: Xin Long Date: Wed, 2 May 2018 13:45:12 +0800 > When auth is enabled for cookie-ack chunk, in sctp_inq_pop, sctp > processes auth chunk first, then continues to the next chunk in > this packet if chunk_end + chunk_hdr size < skb_tail_pointer(). > Otherwise, it will go to the next packet or

Re: [PATCH RFC iproute2-next 1/2] rdma: update rdma_netlink.h to get provider attrs

On 4/30/18 8:36 AM, Steve Wise wrote: > Signed-off-by: Steve Wise > --- > rdma/include/uapi/rdma/rdma_netlink.h | 37 > ++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/rdma/include/uapi/rdma/rdma_netlink.h > b/rdma/include/uapi/rdma/rdma_n

RE: [PATCH V2 6/8] net: stmmac: add dwmac-4.20a compatible

Hi Jose, >Just being curious: Can you tell me which HW features do you have on your NIC? Nothing specific to SNPS 4.20a, it is just to be align with our SNPS IP in our NIC ;-) BR Christophe. -Original Message- From: Jose Abreu [mailto:jose.ab...@synopsys.com] Sent: mercredi 2 mai 2018

Re: [PATCH iproute2-next] Add tc-BPF example for a TCP pure ack recognizer

On 5/1/18 10:51 PM, Dave Taht wrote: > On Tue, May 1, 2018 at 9:12 PM, David Ahern wrote: >> On 5/1/18 12:32 PM, Dave Taht wrote: >>> ack_recognize can shift pure tcp acks into another flowid. >>> --- >>> examples/bpf/ack_recognize.c | 98 >>> >>> 1 f

Re: [PATCH net-next v2 1/2] mlxsw: spectrum_router: Return an error for non-default FIB rules

On 5/2/18 1:17 AM, Ido Schimmel wrote: > Since commit 9776d32537d2 ("net: Move call_fib_rule_notifiers up in > fib_nl_newrule") it is possible to forbid the installation of > unsupported FIB rules. > > Have mlxsw return an error for non-default FIB rules in addition to the > existing extack messag

Re: [PATCH net-next v2 2/2] mlxsw: spectrum_router: Return an error for routes added after abort

On 5/2/18 1:17 AM, Ido Schimmel wrote: > We currently do not perform accounting in the driver and thus can't > reject routes before resources are exceeded. > > However, in order to make users aware of the fact that routes are no > longer offloaded we can return an error for routes configured after

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On 5/2/2018 12:50 AM, Jiri Pirko wrote: Wed, May 02, 2018 at 02:20:26AM CEST, sridhar.samudr...@intel.com wrote: On 4/30/2018 12:20 AM, Jiri Pirko wrote: Now I try to change mac of the failover master: [root@test1 ~]# ip link set ens3 addr 52:54:00:b2:a7:f3 RTNETLINK answers: Operation not supp

Re: [RFC v2 bpf-next 8/9] bpf: Provide helper to do lookups in kernel FIB table

On 5/2/18 5:27 AM, Jesper Dangaard Brouer wrote: > On Sun, 29 Apr 2018 11:07:51 -0700 > David Ahern wrote: > >> Initial performance numbers collected by Jesper, forwarded packets/sec: >> >>Full stackXDP FIB lookupXDP Direct lookup >> IPv4 1,947,969 7,074,156 7,415

Re: [RFC v2 bpf-next 9/9] samples/bpf: Add examples of ipv4 and ipv6 forwarding in XDP

On 5/2/18 5:13 AM, Jesper Dangaard Brouer wrote: > > On Sun, 29 Apr 2018 11:07:52 -0700 David Ahern wrote: > >> +/* verify egress index has xdp support */ >> +// TO-DO bpf_map_lookup_elem(&tx_port, &key) fails with >> +// cannot pass map_type 14 into func bpf_map_lookup_elem#1:

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

On Wed, May 02, 2018 at 11:12:55PM +0800, Tiwei Bie wrote: > On Wed, May 02, 2018 at 04:51:01PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 02, 2018 at 03:28:19PM +0800, Tiwei Bie wrote: > > > On Wed, May 02, 2018 at 10:51:06AM +0800, Jason Wang wrote: > > > > On 2018年04月25日 13:15, Tiwei Bie w

Re: [PATCH v3 2/3] selftests/bpf: Makefile: add include path

On 05/02/2018 01:05 PM, Sirio Balmelli wrote: > On some systems selftests fail to build, missing the following headers: > > asm/byteorder.h > asm/socket.h > asm/swab.h > > In the specific case of Ubuntu, this is because the files are in > '/usr/include/x86_64-linux-gnu' (see

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On Wed, May 02, 2018 at 09:50:21AM +0200, Jiri Pirko wrote: > Wed, May 02, 2018 at 02:20:26AM CEST, sridhar.samudr...@intel.com wrote: > >On 4/30/2018 12:20 AM, Jiri Pirko wrote: > >> > >> > > Now I try to change mac of the failover master: > >> > > [root@test1 ~]# ip link set ens3 addr 52:54:00:b

Re: [PATCH bpf-next v2] bpf: relax constraints on formatting for eBPF helper documentation

On 05/02/2018 03:20 PM, Quentin Monnet wrote: > The Python script used to parse and extract eBPF helpers documentation > from include/uapi/linux/bpf.h expects a very specific formatting for the > descriptions (single dot represents a space, '>' stands for a tab): > > /* > ... > *.int

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

Wed, May 02, 2018 at 05:47:27PM CEST, m...@redhat.com wrote: >On Wed, May 02, 2018 at 09:50:21AM +0200, Jiri Pirko wrote: >> Wed, May 02, 2018 at 02:20:26AM CEST, sridhar.samudr...@intel.com wrote: >> >On 4/30/2018 12:20 AM, Jiri Pirko wrote: >> >> >> >> > > Now I try to change mac of the failover

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

Wed, May 02, 2018 at 05:34:44PM CEST, sridhar.samudr...@intel.com wrote: >On 5/2/2018 12:50 AM, Jiri Pirko wrote: >> Wed, May 02, 2018 at 02:20:26AM CEST, sridhar.samudr...@intel.com wrote: >> > On 4/30/2018 12:20 AM, Jiri Pirko wrote: >> > > > > Now I try to change mac of the failover master: >> >

Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

Sat, Apr 28, 2018 at 11:06:01AM CEST, j...@resnulli.us wrote: >Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote: [...] >>+ >>+ err = netdev_rx_handler_register(slave_dev, net_failover_handle_frame, >>+ failover_dev); >>+ if (err

Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops

On 01/09/2018 07:43 PM, David Ahern wrote: > On 1/9/18 7:40 AM, Ido Schimmel wrote: >> Before we convert IPv6 to use hash-threshold instead of modulo-N, we >> first need each nexthop to store its region boundary in the hash >> function's output space. >> >> The boundary is calculated by dividing

Re: [PATCH bpf-next 1/2] bpf: enable stackmap with build_id in nmi context

> On May 2, 2018, at 2:21 AM, Peter Zijlstra wrote: > > On Tue, May 01, 2018 at 05:02:19PM -0700, Song Liu wrote: >> @@ -267,17 +285,27 @@ static void stack_map_get_build_id_offset(struct >> bpf_stack_build_id *id_offs, >> { >> int i; >> struct vm_area_struct *vma; >> +bool in_nm

Re: [RFC v2 bpf-next 8/9] bpf: Provide helper to do lookups in kernel FIB table

From: David Ahern Date: Wed, 2 May 2018 09:37:21 -0600 > To share numbers from recent testing I did using Vincent's modules, > lookup times in nsec (using local_clock) with MULTIPLE_TABLES config > disabled for IPv4 and IPv6 > > IPv4IPv6-dstIPv6-fib6 > baseline 49

Re: [PATCH bpf-next 0/3] bpf: cleanups on managing subprog information

On 01/05/2018 23:22, Alexei Starovoitov wrote: ... [ 27.784931] ? bpf_int_jit_compile+0x7ac/0xab0 [ 27.785475] bpf_int_jit_compile+0x2b6/0xab0 [ 27.786001] ? do_jit+0x6020/0x6020 [ 27.786428] ? kasan_kmalloc+0xa0/0xd0 [ 27.786885] bpf_check+0x2c05/0x4c40 [ 27.787346] ? fixup_bpf

Re: [PATCH net-next] cxgb4: add new T5 device id's

From: Ganesh Goudar Date: Wed, 2 May 2018 11:47:15 +0530 > Add device id's 0x5019, 0x501a and 0x501b for T5 > cards. > > Signed-off-by: Ganesh Goudar Applied, thanks.

[PATCH net] net_sched: fq: take care of throttled flows before reuse

Normally, a socket can not be freed/reused unless all its TX packets left qdisc and were TX-completed. However connect(AF_UNSPEC) allows this to happen. With commit fc59d5bdf1e3 ("pkt_sched: fq: clear time_next_packet for reused flows") we cleared f->time_next_packet but took no special action if

Re: [PATCH net] ipv4: fix fnhe usage by non-cached routes

From: Julian Anastasov Date: Wed, 2 May 2018 09:41:19 +0300 > Allow some non-cached routes to use non-expired fnhe: ... > Fixes: 839da4d98960 ("net: ipv4: set orig_oif based on fib result for local > traffic") > Fixes: d6d5e999e5df ("route: do not cache fib route info on local routes with > o

Re: [PATCH RFC net-next] net: ipvs: Adjust gso_size for IPPROTO_TCP

On Wed, May 02, 2018 at 09:38:43AM +0300, Julian Anastasov wrote: > > Hello, > > On Thu, 19 Apr 2018, Martin KaFai Lau wrote: > > > This patch is not a proper fix and mainly serves for discussion purpose. > > It is based on net-next which I have been using to debug the issue. > > > > The

Re: [PATCH net-next v2 0/2] mlxsw: Reject unsupported FIB configurations

From: Ido Schimmel Date: Wed, 2 May 2018 10:17:33 +0300 > Recently it became possible for listeners of the FIB notification chain > to veto operations such as addition of routes and rules. > > Adjust the mlxsw driver to take advantage of it and return an error for > unsupported FIB rules and fo

Re: [PATCH V2 net-next 4/6] tun: Add support for SCTP checksum offload

On 05/02/2018 10:56 AM, Marcelo Ricardo Leitner wrote: > On Wed, May 02, 2018 at 11:53:47AM -0300, Marcelo Ricardo Leitner wrote: >> On Tue, May 01, 2018 at 10:07:37PM -0400, Vladislav Yasevich wrote: >>> Adds a new tun offload flag to allow for SCTP checksum offload. >>> The flag has to be set by

Re: [PATCH] change the comment of ip6gre_tnl_addr_conflict

From: Sun Lianwen Date: Wed, 2 May 2018 17:06:08 +0800 > The comment of ip6gre_tnl_addr_conflict() is wrong. which use > ip6_tnl_addr_conflict instead of ip6gre_tnl_addr_conflict. > > Signed-off-by: Sun Lianwen Please format your Subject line properly. If should start with "[PATCH X] " where

Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops

On Wed, May 02, 2018 at 09:43:50AM -0700, Eric Dumazet wrote: > > > On 01/09/2018 07:43 PM, David Ahern wrote: > > On 1/9/18 7:40 AM, Ido Schimmel wrote: > >> Before we convert IPv6 to use hash-threshold instead of modulo-N, we > >> first need each nexthop to store its region boundary in the hash

Re: [PATCH net-next] net: phy: broadcom: add support for BCM89610 PHY

Please remove the email footer from your postings here that talks about confidential information and whatnot. That is expressly inappropriate for this mailing list, and any such postings shall be ignored in their entirety. Thank you.

Re: [PATCH] 8139too: Use disable_irq_nosync() in rtl8139_poll_controller()

From: Sebastian Andrzej Siewior Date: Wed, 2 May 2018 13:30:57 +0200 > From: Ingo Molnar > > Use disable_irq_nosync() instead of disable_irq() as this might be > called in atomic context with netpoll. > > Signed-off-by: Ingo Molnar > Signed-off-by: Thomas Gleixner > Signed-off-by: Sebastian

Re: [PATCH bpf-next 0/3] bpf: cleanups on managing subprog information

On 05/02/2018 09:59 AM, Jiong Wang wrote: > On 01/05/2018 23:22, Alexei Starovoitov wrote: > ... >> [   27.784931]  ? bpf_int_jit_compile+0x7ac/0xab0 >> [   27.785475]  bpf_int_jit_compile+0x2b6/0xab0 >> [   27.786001]  ? do_jit+0x6020/0x6020 >> [   27.786428]  ? kasan_kmalloc+0xa0/0xd0 >> [   27.7

[RFC] inet: add bound ports statistic

This adds a number of bound ports which fixes socket summary command. The ss -s has been broken since changes to slab info and this is one way to recover the missing value by adding a field onto /proc/net/sockstat. Since this is an informational value only, there is no need for locking. Signed-

Re: [PATCH net 1/1] net/smc: restrict non-blocking connect finish

From: Ursula Braun Date: Wed, 2 May 2018 16:53:56 +0200 > The smc_poll code tries to finish connect() if the socket is in > state SMC_INIT and polling of the internal CLC-socket returns with > EPOLLOUT. This makes sense for a select/poll call following a connect > call, but not without preceding

Re: [PATCH net-next v2 0/4] net/smc: small features 2018/04/30

From: Ursula Braun Date: Wed, 2 May 2018 16:56:43 +0200 > here are 4 smc patches for net-next covering small new features > in different areas: >* link health check >* diagnostics for IPv6 smc sockets >* ioctl >* improvement for vlan determination > > v2 changes: >* better t

Re: [PATCH bpf-next 1/2] bpf: enable stackmap with build_id in nmi context

On Wed, May 02, 2018 at 04:48:32PM +, Song Liu wrote: > > It's broken though, I've bet you've never actually ran this with lockdep > > enabled for example. > > I am not following here. I just run the new selftest with CONFIG_LOCKDEP on, > and got no warning for this. Weird, I would be expec

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote: > On 2018年05月02日 13:12, Michael Chan wrote: >> >> On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote: >> >>> diff --git a/drivers/net/ethernet/broadcom/tg3.h >>> b/drivers/net/ethernet/broadcom/tg3.h >>> index 3b5e98e..c61d83c 100644 >>> --- a/dri

Re: [RFC] inet: add bound ports statistic

From: Stephen Hemminger Date: Wed, 2 May 2018 10:25:31 -0700 > diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c > index 881ac6d046f2..8a70465c240c 100644 > --- a/net/ipv4/inet_connection_sock.c > +++ b/net/ipv4/inet_connection_sock.c > @@ -309,6 +309,7 @@ int inet_c

[bpf PATCH 0/3] sockmap error path fixes

When I added the test_sockmap to selftests I mistakenly changed the test logic a bit. The result of this was on redirect cases we ended up choosing the wrong sock from the BPF program and ended up sending to a socket that had no receive handler. The result was the actual receive handler, running on

[bpf PATCH 1/3] bpf: sockmap, fix scatterlist update on error path in send with apply

When the call to do_tcp_sendpage() fails to send the complete block requested we either retry if only a partial send was completed or abort if we receive a error less than or equal to zero. Before returning though we must update the scatterlist length/offset to account for any partial send complete

[bpf PATCH 2/3] bpf: sockmap, zero sg_size on error when buffer is released

When an error occurs during a redirect we have two cases that need to be handled (i) we have a cork'ed buffer (ii) we have a normal sendmsg buffer. In the cork'ed buffer case we don't currently support recovering from errors in a redirect action. So the buffer is released and the error should _not

[bpf PATCH 3/3] bpf: sockmap, fix error handling in redirect failures

When a redirect failure happens we release the buffers in-flight without calling a sk_mem_uncharge(), the uncharge is called before dropping the sock lock for the redirecte, however we missed updating the ring start index. When no apply actions are in progress this is OK because we uncharge the ent

Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

On 5/2/2018 9:15 AM, Jiri Pirko wrote: Sat, Apr 28, 2018 at 11:06:01AM CEST, j...@resnulli.us wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote: [...] + + err = netdev_rx_handler_register(slave_dev, net_failover_handle_frame, +

Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops

On Wed, May 02, 2018 at 08:21:06PM +0300, Ido Schimmel wrote: > On Wed, May 02, 2018 at 09:43:50AM -0700, Eric Dumazet wrote: > > > > > > On 01/09/2018 07:43 PM, David Ahern wrote: > > > On 1/9/18 7:40 AM, Ido Schimmel wrote: > > >> Before we convert IPv6 to use hash-threshold instead of modulo-N

Re: [PATCH bpf-next] bpf/verifier: enable ctx + const + 0.

On Wed, May 2, 2018 at 1:29 AM, Daniel Borkmann wrote: > On 05/02/2018 06:52 AM, Alexei Starovoitov wrote: >> On Tue, May 01, 2018 at 09:35:29PM -0700, William Tu wrote: >>> How did you test this patch? >>> Without the patch, the test case will fail. >>> With the patch, the test case pas

INFO: rcu detected stall in __schedule

Hello, syzbot found the following crash on: HEAD commit:f2125992e7cb Merge tag 'xfs-4.17-fixes-1' of git://git.kern... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?id=4755940087693312 kernel config: https://syzkaller.appspot.com/x/.config?id=64935577

Re: [PATCH bpf-next 1/2] bpf: enable stackmap with build_id in nmi context

> On May 2, 2018, at 10:30 AM, Peter Zijlstra wrote: > > On Wed, May 02, 2018 at 04:48:32PM +, Song Liu wrote: >>> It's broken though, I've bet you've never actually ran this with lockdep >>> enabled for example. >> >> I am not following here. I just run the new selftest with CONFIG_LOCKDE

[PATCH bpf 0/2] Two x86 BPF JIT fixes

Fix two memory leaks in x86 JIT. For details, please see individual patches in this series. Thanks! Daniel Borkmann (2): bpf, x64: fix memleak when not converging after image bpf, x64: fix memleak when not converging on calls arch/x86/net/bpf_jit_comp.c | 6 +++--- 1 file changed, 3 insertio

[PATCH bpf 2/2] bpf, x64: fix memleak when not converging on calls

The JIT logic in jit_subprogs() is as follows: for all subprogs we allocate a bpf_prog_alloc(), populate it (prog->is_func = 1 here), and pass it to bpf_int_jit_compile(). If a failure occurred during JIT and prog->jited is not set, then we bail out from attempting to JIT the whole program, and pun

[PATCH bpf 1/2] bpf, x64: fix memleak when not converging after image

While reviewing x64 JIT code, I noticed that we leak the prior allocated JIT image in the case where proglen != oldproglen during the JIT passes. Prior to the commit e0ee9c12157d ("x86: bpf_jit: fix two bugs in eBPF JIT compiler") we would just break out of the loop, and using the image as the JITe

Re: [PATCH net-next v9 0/4] Prerequisites for Cavium OCTEON-III network driver.

On 04/29/2018 07:33 PM, David Miller wrote: > > I don't know if we really want all of these MIPS specific changes to > go via the net-next tree. > > The right way to do this is probably getting this series into the MIPS > architecture tree. > David, Correct, and I should have been clearer about

Re: [PATCH net-next] net: phy: broadcom: add support for BCM89610 PHY

HI David, On 5/2/2018 10:51 PM, David Miller wrote: Please remove the email footer from your postings here that talks about confidential information and whatnot. That is expressly inappropriate for this mailing list, and any such postings shall be ignored in their entirety. I Understand thi

Re: [bpf PATCH 2/3] bpf: sockmap, zero sg_size on error when buffer is released

From: John Fastabend Date: Wed, 02 May 2018 10:47:32 -0700 > When an error occurs during a redirect we have two cases that need > to be handled (i) we have a cork'ed buffer (ii) we have a normal > sendmsg buffer. > > In the cork'ed buffer case we don't currently support recovering from > errors

Re: [bpf PATCH 1/3] bpf: sockmap, fix scatterlist update on error path in send with apply

From: John Fastabend Date: Wed, 02 May 2018 10:47:27 -0700 > When the call to do_tcp_sendpage() fails to send the complete block > requested we either retry if only a partial send was completed or > abort if we receive a error less than or equal to zero. Before > returning though we must update t

Re: [bpf PATCH 3/3] bpf: sockmap, fix error handling in redirect failures

From: John Fastabend Date: Wed, 02 May 2018 10:47:37 -0700 > When a redirect failure happens we release the buffers in-flight > without calling a sk_mem_uncharge(), the uncharge is called before > dropping the sock lock for the redirecte, however we missed updating > the ring start index. When no

Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops

On Wed, May 02, 2018 at 08:52:44PM +0300, Ido Schimmel wrote: > On Wed, May 02, 2018 at 08:21:06PM +0300, Ido Schimmel wrote: > > On Wed, May 02, 2018 at 09:43:50AM -0700, Eric Dumazet wrote: > > > > > > > > > On 01/09/2018 07:43 PM, David Ahern wrote: > > > > On 1/9/18 7:40 AM, Ido Schimmel wrot

Re: [PATCH bpf 1/2] bpf, x64: fix memleak when not converging after image

From: Daniel Borkmann Date: Wed, 2 May 2018 20:12:22 +0200 > While reviewing x64 JIT code, I noticed that we leak the prior allocated > JIT image in the case where proglen != oldproglen during the JIT passes. > Prior to the commit e0ee9c12157d ("x86: bpf_jit: fix two bugs in eBPF JIT > compiler"

Re: [PATCH bpf 2/2] bpf, x64: fix memleak when not converging on calls

From: Daniel Borkmann Date: Wed, 2 May 2018 20:12:23 +0200 > The JIT logic in jit_subprogs() is as follows: for all subprogs we > allocate a bpf_prog_alloc(), populate it (prog->is_func = 1 here), > and pass it to bpf_int_jit_compile(). If a failure occurred during > JIT and prog->jited is not s

Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops

On 5/2/18 12:53 PM, Ido Schimmel wrote: > > So this fixes the issue for me. To reproduce: > > # ip -6 address add 2001:db8::1/64 dev dummy0 > # ip -6 address add 2001:db8::1/64 dev dummy1 > > This reproduces the issue because due to above commit both local routes > are considered siblings... :/

Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops

On Wed, May 02, 2018 at 12:58:56PM -0600, David Ahern wrote: > On 5/2/18 12:53 PM, Ido Schimmel wrote: > > > > So this fixes the issue for me. To reproduce: > > > > # ip -6 address add 2001:db8::1/64 dev dummy0 > > # ip -6 address add 2001:db8::1/64 dev dummy1 > > > > This reproduces the issue b

RE: [PATCH 2/3] mlx4: Don't bother using skb_tx_hash in mlx4_en_select_queue

>-Original Message- >From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- >ow...@vger.kernel.org] On Behalf Of Alexander Duyck >Sent: Friday, April 27, 2018 2:07 PM >To: netdev@vger.kernel.org; da...@davemloft.net >Cc: linux-r...@vger.kernel.org; Dalessandro, Dennis >; Vishwanathapura

Re: [PATCH bpf-next 0/3] bpf: cleanups on managing subprog information

On 02/05/2018 18:24, John Fastabend wrote: On 05/02/2018 09:59 AM, Jiong Wang wrote: On 01/05/2018 23:22, Alexei Starovoitov wrote: ... [   27.784931]  ? bpf_int_jit_compile+0x7ac/0xab0 [   27.785475]  bpf_int_jit_compile+0x2b6/0xab0 [   27.786001]  ? do_jit+0x6020/0x6020 [   27.786428]  ? kasa

[PATCH net-next 00/10] r8169: series with further improvements

I thought I'm more or less done with the basic refactoring. But again I stumbled across things that can be improved / simplified. Heiner Kallweit (10): r8169: remove unneeded check in r8168_pll_power_down r8169: remove 810x_phy_power_up/down r8169: merge r810x_pll_power_down/up into r8168_pl

<    1   2   3   4   >