Hi,
We recently noticed a kernel panic in the bnx2x driver when trying to set
rx-flow-hash parameters via ethtool during if-pre-up.d. I am running kernel
v4.17.2 from ubuntu-mainline-ppa. I have added the stack trace below:
[ 18.280209] BUG: unable to handle kernel NULL pointer dereference at
From: Kevin Yang
Date: Wed, 20 Jun 2018 16:07:35 -0400
> From: Eric Dumazet
>
> This commit makes BBR use only the MSS (without any headers) to
> calculate pacing rates when internal TCP-layer pacing is used.
>
> This is necessary to achieve the correct pacing behavior in this case,
> since
From: Joakim Tjernlund
Date: Wed, 20 Jun 2018 18:29:18 +0200
> Signed-off-by: Joakim Tjernlund
> ---
>
> v2 - Reoder varibles according to Dave
> Add call to netdev_reset_queue(dev) open/close
Applied.
From: Shannon Nelson
Date: Tue, 19 Jun 2018 22:42:41 -0700
> A couple of bad behaviors in the ipsec selftest were pointed out
> by Anders Roxell and are addressed here.
>
> Shannon Nelson (2):
> selftests: rtnetlink: hide complaint from terminated monitor
> selftests: rtnetlink: use a
From: Wei Wang
Date: Tue, 19 Jun 2018 21:42:50 -0700
> From: Wei Wang
>
> When receiving multiple packets with the same ts ecr value, only try
> to compute rcv_rtt sample with the earliest received packet.
> This is because the rcv_rtt calculated by later received packets
> could possibly
On 06/19/2018 10:30 PM, David Miller wrote:
> Tested-by: Andreas Schwab
>
> Applied and queued up for -stable, thanks Eric.
>
BTW, removing the FCS also means GRO is going to work, finally on this NIC ;)
GRO does not like packets with padding.
On Thu, Jun 21, 2018 at 7:23 AM, Ursula Braun wrote:
> @@ -605,6 +606,13 @@ static int smc_connect(struct socket *sock, struct
> sockaddr *addr,
>
> smc_copy_sock_settings_to_clc(smc);
> tcp_sk(smc->clcsock->sk)->syn_smc = 1;
> + if (flags & O_NONBLOCK) {
> +
--
I'm soliciting your cooperation in a very important transaction
business that will benefit you and i, please i need your trust reply
for more details.
Kind regards.
On 06/21/2018 07:02 PM, Yonghong Song wrote:
> On one of our production test machine, when running
> bpf selftest test_sockmap, I got the following error:
> # sudo ./test_sockmap
> libbpf: failed to create map (name: 'sock_map'): Operation not permitted
> libbpf: failed to load object
From: Paolo Abeni
Date: Thu, 21 Jun 2018 20:02:16 +0200
> If flower filter is created without the skip_sw flag, fl_mask_put()
> can race with fl_classify() and we can destroy the mask rhashtable
> while a lookup operation is accessing it.
...
> Fix the above waiting for a RCU grace period
From: Eric Dumazet
Date: Thu, 21 Jun 2018 14:16:02 -0700
> We should put copy_skb in receive_queue only after
> a successful call to virtio_net_hdr_from_skb().
>
> syzbot report :
...
> Fixes: 58d19b19cd99 ("packet: vnet_hdr support for tpacket_rcv")
> Signed-off-by: Eric Dumazet
>
From: Daniel Borkmann
Date: Thu, 21 Jun 2018 23:03:09 +0200
> On 06/21/2018 06:08 AM, Eric Dumazet wrote:
>> On 06/20/2018 08:46 PM, David Miller wrote:
>>> From: Eric Dumazet
>>> Date: Wed, 20 Jun 2018 17:24:09 -0700
>>>
After commit 9facc336876f ("bpf: reject any prog that failed
On Thu, Jun 21, 2018 at 08:34:40PM +0200, Andrew Lunn wrote:
> > Hi Andrew,
>
> Adding Guenter Roeck, the HWMON maintainer.
>
> > The temperature of each individual module can be obtained
> > through ethtool.
>
> You mean via --module-info?
>
> FYI: I plan to add hwmon support to the kernel
We should put copy_skb in receive_queue only after
a successful call to virtio_net_hdr_from_skb().
syzbot report :
BUG: KASAN: use-after-free in __skb_unlink include/linux/skbuff.h:1843 [inline]
BUG: KASAN: use-after-free in __skb_dequeue include/linux/skbuff.h:1863 [inline]
BUG: KASAN:
On 06/21/2018 01:57 PM, Julian Anastasov wrote:
Hello,
Hi.
I think so
Okay.
I'll do some more digging.
You can search on net. I have some old docs on these issues, they should
be actual:
http://ja.ssi.bg/dgd-usage.txt
"DGD" or "Dead Gateway Detection" sounds very familiar. I
On 06/20/2018 08:42 PM, Jakub Kicinski wrote:
> Hi!
>
> Two small fixes for error handling in bpftool prog load, first patch
> removes a duplicated message, second one frees resources correctly.
> Multiple error messages break JSON:
>
> # bpftool -jp prog load tracex1_kern.o /sys/fs/bpf/a
> {
>
On 06/21/2018 06:08 AM, Eric Dumazet wrote:
> On 06/20/2018 08:46 PM, David Miller wrote:
>> From: Eric Dumazet
>> Date: Wed, 20 Jun 2018 17:24:09 -0700
>>
>>> After commit 9facc336876f ("bpf: reject any prog that failed read-only
>>> lock")
>>> offsetof(struct bpf_binary_header, image) became 3
On Thu, Jun 21, 2018 at 10:11:27AM +0200, Andrew Lunn wrote:
> > I'm trying to figure out how the netdev environment works on large
> > switches. I can't imagine that the kernel network stack is involved in
> > any part of the data plane.
>
> Hi Don
>
> It is involved in the slow path. I.e.
> It means I will have 64 thermal zones for each module (actually for the
> some coming new systems will support 128 modules, plus thermal zone
> for ASIC ambient temperatures.
> And each zone will try to control same PWM.
> As I result PWM will be extremely jumpy and non-effective.
Hi Vadim
> -Original Message-
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Thursday, June 21, 2018 10:49 PM
> To: Vadim Pasternak
> Cc: Guenter Roeck ; da...@davemloft.net;
> netdev@vger.kernel.org; j...@resnulli.us
> Subject: Re: [PATCH v0 03/12] mlxsw: core: Add core environment module
Hello,
On Wed, 20 Jun 2018, Grant Taylor wrote:
> On 06/20/2018 01:00 PM, Julian Anastasov wrote:
> > You can also try alternative routes.
>
> "Alternative routes"? I can't say as I've heard that description as a
> specific technique / feature / capability before.
>
> Is that it's
On Thu, Jun 21, 2018 at 07:17:03PM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Andrew Lunn [mailto:and...@lunn.ch]
> > Sent: Thursday, June 21, 2018 9:35 PM
> > To: Vadim Pasternak ; Guenter Roeck > us.net>
> > Cc: da...@davemloft.net; netdev@vger.kernel.org;
> -Original Message-
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Thursday, June 21, 2018 9:35 PM
> To: Vadim Pasternak ; Guenter Roeck us.net>
> Cc: da...@davemloft.net; netdev@vger.kernel.org; j...@resnulli.us
> Subject: Re: [PATCH v0 03/12] mlxsw: core: Add core environment
> Hi Andrew,
Adding Guenter Roeck, the HWMON maintainer.
> The temperature of each individual module can be obtained
> through ethtool.
You mean via --module-info?
FYI: I plan to add hwmon support to the kernel SFP code. So if you
ever decide to swap to the kernel SFP code, not your own, the
Thu, Jun 21, 2018 at 08:02:16PM CEST, pab...@redhat.com wrote:
>If flower filter is created without the skip_sw flag, fl_mask_put()
>can race with fl_classify() and we can destroy the mask rhashtable
>while a lookup operation is accessing it.
>
> BUG: unable to handle kernel paging request at
> -Original Message-
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Thursday, June 21, 2018 8:11 PM
> To: Vadim Pasternak
> Cc: da...@davemloft.net; netdev@vger.kernel.org; j...@resnulli.us
> Subject: Re: [PATCH v0 03/12] mlxsw: core: Add core environment module for
> port
If flower filter is created without the skip_sw flag, fl_mask_put()
can race with fl_classify() and we can destroy the mask rhashtable
while a lookup operation is accessing it.
BUG: unable to handle kernel paging request at 000911d1
PGD 0 P4D 0
SMP PTI
CPU: 3 PID: 5582 Comm:
On Thu, Jun 21, 2018 at 03:37:55PM +0300, Leon Romanovsky wrote:
> From: Talat Batheesh
>
> Add capability bit in PCAM register and RoCE ICRC error counter
> to PPCNT register.
>
> Signed-off-by: Talat Batheesh
> Reviewed-by: Mark Bloch
> Signed-off-by: Leon Romanovsky
> ---
>
On Thu, Jun 21, 2018 at 03:37:54PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> Hi,
>
> This series exposes RoCE ICRC counter through existing RDMA hw_counters
> sysfs interface.
>
> First patch has all HW definitions in mlx5_ifc.h file and second patch is
> actual counter
On 6/21/2018 9:56 AM, Anders Roxell wrote:
On Thu, 21 Jun 2018 at 02:32, Shannon Nelson wrote:
On 6/20/2018 4:18 PM, Anders Roxell wrote:
On Thu, 21 Jun 2018 at 00:26, Shannon Nelson wrote:
On 6/20/2018 12:09 PM, Anders Roxell wrote:
On Wed, 20 Jun 2018 at 07:42, Shannon Nelson wrote:
> New internal API reads the temperature from all the modules, which are
> equipped with the thermal sensor and exposes temperature according to
> the worst measure. All individual temperature values are normalized to
> pre-defined range.
Hi Vadim
Could you explain this normalization process.
On Wed, Jun 20, 2018 at 08:00:11PM -0700, dsah...@kernel.org wrote:
> From: David Ahern
>
> For ACLs implemented using either FIB rules or FIB entries, the BPF
> program needs the FIB lookup status to be able to drop the packet.
> Since the bpf_fib_lookup API has not reached a released kernel
On one of our production test machine, when running
bpf selftest test_sockmap, I got the following error:
# sudo ./test_sockmap
libbpf: failed to create map (name: 'sock_map'): Operation not permitted
libbpf: failed to load object 'test_sockmap_kern.o'
libbpf: Can't get the 0th fd from
On Thu, 21 Jun 2018 at 02:32, Shannon Nelson wrote:
>
> On 6/20/2018 4:18 PM, Anders Roxell wrote:
> > On Thu, 21 Jun 2018 at 00:26, Shannon Nelson
> > wrote:
> >>
> >> On 6/20/2018 12:09 PM, Anders Roxell wrote:
> >>> On Wed, 20 Jun 2018 at 07:42, Shannon Nelson
> >>> wrote:
>
> A
Dear
I am.Dr.Abdul Fha,Manager Auditing and Accountancy Department,Ecobank,
Burkina Faso.I have a business proposal for you in the tune of 3.5
million usd.If you know you are capable of involving and partaking in
this transaction this will be disbursed or shared between the both of
us. email me
Hi Ursula,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url:
https://github.com/0day-ci/linux/commits/Ursula-Braun/net-smc-coordinate-wait-queues-for-nonblocking-connect/20180620-180901
reproduce:
# apt-get install sparse
make
On Thu, 2018-06-21 at 15:50 +, Fu, Qiaobin wrote:
> The new action inheritdsfield copies the field DS of
> IPv4 and IPv6 packets into skb->priority. This enables
> later classification of packets based on the DS field.
>
> v5:
> *Update the drop counter for TC_ACT_SHOT
Acked-by: Davide
The new action inheritdsfield copies the field DS of
IPv4 and IPv6 packets into skb->priority. This enables
later classification of packets based on the DS field.
v5:
*Update the drop counter for TC_ACT_SHOT
v4:
*Not allow setting flags other than the expected ones.
*Allow dumping the pure
The new action inheritdsfield copies the field DS of
IPv4 and IPv6 packets into skb->priority. This enables
later classification of packets based on the DS field.
v5:
*Update the drop counter for TC_ACT_SHOT.
v4:
*Not allow setting flags other than the expected ones.
*Allow dumping the pure
From
The Desk Of Mrs Mabel Raymond
The International Scammers Crime Worldwide Compensation Financial Unit
Burkina Faso In West Africa..
Attention Beneficiary
My Name Is Mrs Mabel Raymond Staff Of international Scammers Crime
Worldwide Compensation Financial Unit .
I have discovered through our
On Thu, Jun 21, 2018 at 2:45 PM, Ilias Apalodimas
wrote:
> On Thu, Jun 21, 2018 at 02:19:55PM +0200, Ivan Vecera wrote:
> The driver is currently widely used and that's the reason we tried to avoid
> rewriting it. The current driver uses a DTS option to distinguish between two
> existing modes.
On 6/21/18 4:03 AM, Kirill Tkhai wrote:
>> This patch does not remove the BUG, so does not really solve the
>> problem. ie., it is fairly trivial to write a script (32k dev%d named
>> devices in init_net) that triggers it again, so your commit subject and
>> commit log are not correct with the
The commit fb6113e688e0 ("be2net: get rid of custom busy poll code")
replaced custom busy-poll code by the generic one but left several
macros and fields in struct be_eq_obj that are currently unused.
Remove this stuff.
Fixes: fb6113e688e0 ("be2net: get rid of custom busy poll code")
Re-order fields in struct be_eq_obj to ensure that .napi field begins
at start of cache-line. Also the .adapter field is moved to the first
cache-line next to .q field and 3 fields (idx,msi_idx,spurious_intr)
and the 4-bytes hole to 3rd cache-line.
Signed-off-by: Ivan Vecera
---
Before patch:
struct be_tx_obj {
u32db_offset;/* 0 4 */
/* XXX 4 bytes hole, try to pack */
struct be_queue_info q;/* 856 */
/* --- cacheline 1 boundary (64 bytes) --- */
struct
- Unionize two u8 fields where only one of them is used depending on NIC
chipset.
- Move recovery_supported field after that union
These changes eliminate 7-bytes hole in the struct and makes it smaller
by 8 bytes.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be.h | 9
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/emulex/benet/be.h
b/drivers/net/ethernet/emulex/benet/be.h
index 91ca8d132e87..d521364e17cf 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++
The event queue description (be_eq_obj.desc) field is used only to format
string for IRQ name and it is not really needed to hold this value.
Remove it and use local variable to format string for IRQ name.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/emulex/benet/be.h | 1 -
The current position of .rss_flags field in struct rss_info causes
that fields .rsstable and .rssqueue (both 128 bytes long) crosses
cache-line boundaries. Moving it at the end properly align all fields.
Before patch:
struct rss_info {
u64rss_flags;/*
The commit 2632bafd74ae ("be2net: fix adaptive interrupt coalescing")
introduced a separate struct be_aic_obj to hold AIC information but
unfortunately left the old stuff in be_eq_obj. So remove it.
Fixes: 2632bafd74ae ("be2net: fix adaptive interrupt coalescing")
Signed-off-by: Ivan Vecera
---
The series:
- removes unused / unneccessary fields in several be2net structures
- re-order fields in some structures to eliminate holes, cache-lines
crosses
- as result reduces size of main struct be_adapter by 4kB
Ivan Vecera (8):
be2net: remove unused old AIC info
be2net: remove unused
The recent poll change may lead to stalls for non-blocking connecting
SMC sockets, since sock_poll_wait is no longer performed on the
internal CLC socket, but on the outer SMC socket. kernel_connect() on
the internal CLC socket returns with -EINPROGRESS, but the wake up
logic does not work in all
Add new core_env module to allow port temperature reading. This
information has most critical impact on system's thermal monitoring and
is to be used by core_hwmon and core_thermal modules.
New internal API reads the temperature from all the modules, which are
equipped with the thermal sensor and
This patchset extends mlxsw hwmon and thermal modules with ports
temperature reading and adds new hwmon attributes for FAN and
temperature.
Ports temperatures are most critical component in system thermal control
and should be considered by thermal algorithm.
New hwmon attributes, such as FAN
Thermal zone trip points setting is modified for better alignment with
modified thermal algorithm.
The hysteresis thresholds for thermal trips are added in order to avoid
throttling around thermal trip point. If hysteresis temperature is not
considered PWM can have side effect of flip up/down on
Use different thermal monitoring based on bus type.
For I2C bus time is set to 20 seconds, while for PCIe 1 second polling
interval is used.
Signed-off-by: Vadim Pasternak
Acked-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/core_thermal.c | 11 +--
1 file changed, 9
Add new attributes to hwmon object for exposing accumulative ports
temperature input and accumulative port temperature fault (if one of
sensors in untrusted - fault is set.
Signed-off-by: Vadim Pasternak
Acked-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c | 102
Add new FAN hwmon attribute for exposing FAN faults (fault is set in
case FAN tachometer is below allowed minimum).
Signed-off-by: Vadim Pasternak
Acked-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c | 62 +++-
1 file changed, 60 insertions(+), 2
Add low frequency bus capability in order to allow core functionality
separation based on bus type. Driver could run over PCIe, which is
considered as high frequency bus or I2C , which is considered as low
frequency bus. In the last case time setting, for example, for thermal
polling interval,
Name "Fan" is too common name, and such name is misleading, while it's
interpreted by user.
For example name "Fan" could be used by ACPI.
Signed-off-by: Vadim Pasternak
Acked-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/core_thermal.c | 3 ++-
1 file changed, 2 insertions(+), 1
Add MTBR (Management Temperature Bulk Register), which is used for port
temperature reading in a bulk mode.
Signed-off-by: Vadim Pasternak
Acked-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/reg.h | 69 +++
1 file changed, 69 insertions(+)
diff --git
Thermal get_trend method is added in order to notify user in case of
fast temperature downgrade. It could happen in case one or few very hot
port cables are removed. In such situation temperature trend could go
down once, and then could stay in a stable state, while PWM state will
be decreased
Ports temperature has most significant impact on system thermal state
and should be considered by the thermal algorithm. The thermal zone
temperature is extended for reading ports temperatures along with a
chip temperature. The temperature value, provided to the core thermal
algorithm will be
Extend cooling device with cooling levels vector to allow more
flexibility of PWM setting.
Thermal zone algorithm operates with the numerical states for PWM
setting. Each state is the index, defined in range from 0 to 10 and
it's mapped to the relevant duty cycle value, which is written to PWM
Move QSFP EEPROM definitions to common location from the spectrum
driver in order to make them available for other mlxsw modules. They
are common for all kind of chips and have relation to SFF
specifications 8024, 8436, 8472, 8636, rather then to chip type.
Signed-off-by: Vadim Pasternak
On Thu, Jun 21, 2018 at 02:19:55PM +0200, Ivan Vecera wrote:
> On 20.6.2018 20:03, Ilias Apalodimas wrote:
> > Hi Florian,
> >
> > On Wed, Jun 20, 2018 at 10:58:26AM -0700, Florian Fainelli wrote:
> >> On 06/20/2018 10:51 AM, Ilias Apalodimas wrote:
> >>> Hello Ivan,
> >>> On Wed, Jun 20, 2018 at
From: Talat Batheesh
This patch adds support to query the counter that counts the
RoCE packets with corrupted ICRC (Invariant Cyclic Redundancy Code).
This counter will be under
/sys/class/infiniband//ports//hw_counters/
rx_icrc_encapsulated - The number of RoCE packets with ICRC
error.
From: Talat Batheesh
Add capability bit in PCAM register and RoCE ICRC error counter
to PPCNT register.
Signed-off-by: Talat Batheesh
Reviewed-by: Mark Bloch
Signed-off-by: Leon Romanovsky
---
include/linux/mlx5/mlx5_ifc.h | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
From: Leon Romanovsky
Hi,
This series exposes RoCE ICRC counter through existing RDMA hw_counters
sysfs interface.
First patch has all HW definitions in mlx5_ifc.h file and second patch is
actual counter implementation.
Thanks
Talat Batheesh (2):
net/mlx5: Add RoCE RX ICRC encapsulated
On 20.6.2018 20:03, Ilias Apalodimas wrote:
> Hi Florian,
>
> On Wed, Jun 20, 2018 at 10:58:26AM -0700, Florian Fainelli wrote:
>> On 06/20/2018 10:51 AM, Ilias Apalodimas wrote:
>>> Hello Ivan,
>>> On Wed, Jun 20, 2018 at 02:56:48PM +0200, Ivan Vecera wrote:
On 18.6.2018 22:19, Ilias
After recieving MLD querys, we update idev->mc_maxdelay with max_delay
from query header. This make the later unsolicited reports have the same
interval with mc_maxdelay, which means we may send unsolicited reports with
long interval time instead of default configured interval time.
Also as we
Hello Jesse Brandeburg,
The patch 41c445ff0f48: "i40e: main driver core" from Sep 11, 2013,
leads to the following static checker warning:
drivers/net/ethernet/intel/i40e/i40e_main.c:13065 i40e_veb_setup()
warn: potential off by one 'pf->vsi[]' 'vsi_idx == pf->num_alloc_vsi'
On 20.06.2018 20:15, David Ahern wrote:
> On 6/20/18 2:57 AM, Kirill Tkhai wrote:
>> From: Kirill Tkhai
>>
>> The following script makes kernel to crash since it can't obtain
>> a name for a device, when the name is occupied by another device:
>>
>> #!/bin/bash
>> ifconfig eth0 down
>> ifconfig
> I'm trying to figure out how the netdev environment works on large
> switches. I can't imagine that the kernel network stack is involved in
> any part of the data plane.
Hi Don
It is involved in the slow path. I.e. packets from the host out
network ports. BPDU, IGMP, ARP, ND, etc. It can
Hi,
On Wed, 2018-06-20 at 11:06 -0700, Cong Wang wrote:
> On Wed, Jun 20, 2018 at 10:34 AM, Paolo Abeni wrote:
> >
> > +static void fl_mask_free(struct fl_flow_mask *mask)
> > +{
> > + rhashtable_destroy(>ht);
>
> I don't believe you can call rhashtable_destroy() in BH
> context, it
75 matches
Mail list logo
