On Tue, May 12, 2020 at 07:55:36AM +0200, Jiri Pirko wrote:
> Mon, May 11, 2020 at 09:24:22PM CEST, vadym.koc...@plvision.eu wrote:
> >On Mon, May 11, 2020 at 02:57:23PM +0200, Jiri Pirko wrote:
> >> [...]
> >>
> >> >diff --git a/drivers/net/ethernet/marvell/prestera/prestera_dsa.c
> >> >b/driver
Convert the UniPhier AVE4 controller binding to DT schema format.
Signed-off-by: Kunihiko Hayashi
---
Changes since v1:
- Set true to phy-mode and phy-handle instead of $ref
- Add mac-address and local-mac-address for existing dts warning
.../bindings/net/socionext,uniphier-ave4.txt | 6
> -Original Message-
> From: Denis Kirjanov
> Sent: 11 May 2020 18:22
> To: p...@xen.org
> Cc: netdev@vger.kernel.org; bro...@redhat.com; jgr...@suse.com;
> wei@kernel.org;
> ilias.apalodi...@linaro.org
> Subject: Re: [PATCH net-next v9 2/2] xen networking: add XDP offset
> adjustmen
"Gustavo A. R. Silva" wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
> struct foo {
> int
Arnd Bergmann wrote:
> gcc-10 started warning about out-of-bounds access for zero-length
> arrays:
>
> In file included from drivers/net/wireless/ath/ath10k/core.h:18,
> from drivers/net/wireless/ath/ath10k/htt_rx.c:8:
> drivers/net/wireless/ath/ath10k/htt_rx.c: In function
> '
Colin King wrote:
> Pointer info is being assigned twice, once at the start of the function
> and secondly when it is just about to be accessed. Remove the redundant
> initialization and keep the original assignment to info that is close
> to the memcpy that uses it.
>
> Addresses-Coverity: ("Un
"Gustavo A. R. Silva" wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
> struct foo {
> int
Hi Jerome,
On Mon, May 11, 2020 at 5:53 PM Jerome Pouiller
wrote:
> From: Jérôme Pouiller
>
> The struct hif_msg is received from the hardware. So, it declared as
> little endian. However, it is also accessed from many places in the
> driver. Sparse complains about that:
>
> drivers/staging/
Hello!
On 12.05.2020 0:22, Rob Herring wrote:
Sort the items in the compatible string list in increasing number of SoC.
Signed-off-by: Lad Prabhakar
---
Documentation/devicetree/bindings/net/renesas,ether.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
M
This commit move IRQ request and free operations from probe()
to VIRTIO status change handler to comply with VIRTIO spec.
VIRTIO spec 1.1, section 2.1.2 Device Requirements: Device Status Field
The device MUST NOT consume buffers or send any used buffer
notifications to the driver before DRIVER_OK
From: David Miller
> Sent: 12 May 2020 00:10
> From: David Laight
> Date: Mon, 11 May 2020 21:28:18 +
>
> > In this case the "modified in userspace meanwhile" just breaks the
> > application - it isn't any kind of security issue.
>
> The kernel must provide correct behavior based upon the s
On Mon, May 11, 2020 at 04:33:37PM +0200, Andrew Lunn wrote:
> On Mon, May 11, 2020 at 04:13:10PM +0200, Oleksij Rempel wrote:
> > Hi Andrew,
> >
> > First of all, great work! As your cable diagnostic patches are in
> > net-next now and can be used as base for the follow-up discussion.
> >
> > Do
Hello!
On 11.05.2020 14:59, Christoph Hellwig wrote:
Add a variant of CMSG_DATA that operates on user pointer to avoid
sparse warnings about casting to/from user pointers. Also fix up
CMSG_DATA to rely on the gcc extension that allows void pointer
arithmetics to cut down on the amount of casts
On Tue, May 12, 2020 at 06:54:29AM +0100, Guillaume Tucker wrote:
> Please see the bisection report below about a boot failure.
>
> Reports aren't automatically sent to the public while we're
> trialing new bisection features on kernelci.org but this one
> looks valid.
>
> It appears to be due to
Alexei Starovoitov writes:
>> > Currently fentry/fexit/freplace progs have single prog->aux->linked_prog
>> > pointer.
>> > It just needs to become a linked list.
>> > The api extension could be like this:
>> > bpf_raw_tp_open(prog_fd, attach_prog_fd, attach_btf_id);
>> > (currently it's just bp
Hi Arnd,
On 08/05/2020 14:25, Arnd Bergmann wrote:
On Fri, May 8, 2020 at 1:14 PM Grygorii Strashko
wrote:
On 08/05/2020 13:10, Arnd Bergmann wrote:
On Fri, May 8, 2020 at 11:59 AM Grygorii Strashko
That's because TI_CPTS_MOD (which is the symbol gating the _compilation_ of
cpts.c) now dep
On Tue, May 12, 2020 at 10:35 AM Grygorii Strashko
wrote:
>
> Hi Arnd,
>
> On 08/05/2020 14:25, Arnd Bergmann wrote:
> > On Fri, May 8, 2020 at 1:14 PM Grygorii Strashko
> > wrote:
> >> On 08/05/2020 13:10, Arnd Bergmann wrote:
> >>> On Fri, May 8, 2020 at 11:59 AM Grygorii Strashko
> >
> Th
Chen Zhou wrote:
> Fix sparse warning:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2206:5:
> warning: symbol 'brcmf_p2p_get_conn_idx' was not declared. Should it be
> static?
>
> Reported-by: Hulk Robot
> Signed-off-by: Chen Zhou
> Reviewed-by: Wright Feng
Patch applied t
"Gustavo A. R. Silva" wrote:
> caps_buf is always of size sizeof(*caps) because
> sizeof(caps->auth_encr_pair) * 16 is always zero. Notice
> that when using zero-length arrays, sizeof evaluates to zero[1].
>
> So, the code introduced by
> commit 0308383f9591 ("rndis_wlan: get max_num_pmkids fro
Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1785:5-8:
> WARNING: Comparison to bool
>
> Signed-off-by: Jason Yan
> Reviewed-by: Chi-hsien Lin
Patch applied to wireless-drivers-next.git, thanks.
78a6fb42f67c brcmfmac: re
On Tue, May 12, 2020 at 10:22:01AM +0200, Oleksij Rempel wrote:
> > Pair A: OK
> > Pair A: Signal Quality Index class D
>
> At least for automotive, avionics, (rockets till it is deployed :D)
> etc... the cable integrity will probably not change, except we have some
> sudden water infiltration int
Jason Yan wrote:
> This function is dead for more than 10 years. Remove it.
>
> Signed-off-by: Jason Yan
Patch applied to wireless-drivers-next.git, thanks.
f2cd32a443da rndis_wlan: Remove logically dead code
--
https://patchwork.kernel.org/patch/11533111/
https://wireless.wiki.kernel.org/
Pali Rohár wrote:
> Correct name of constant is CLOCK_BOOTTIME and not CLOCK_BOOTIME.
>
> Signed-off-by: Pali Rohár
Patch applied to wireless-drivers-next.git, thanks.
5bb4e125815a ipw2x00: Fix comment for CLOCK_BOOTTIME constant
--
https://patchwork.kernel.org/patch/11537529/
https://wire
When the probe code was failing for any reason ENOTSUP was returned, even
if this was due to no having enough lock space. This patch fixes this by
returning EPERM to the user application, so it can respond and increase
the RLIMIT_MEMLOCK size.
Signed-off-by: Eelco Chaudron
---
v4: Preserve errno
On 11 May 2020, at 22:43, Yonghong Song wrote:
On 5/11/20 5:40 AM, Eelco Chaudron wrote:
When the probe code was failing for any reason ENOTSUP was returned,
even
if this was due to no having enough lock space. This patch fixes this
by
returning EPERM to the user application, so it can resp
Hi Vinicius,
On Tue, 12 May 2020 9:42:23 Vinicius Costa Gomes wrote:
> > +
> > + /* Rate unit is 100 kbps */
> > + cir = DIV_ROUND_UP(cbs_qopt->idleslope, 100);
> > + cir = (cir ? cir : 1);
> > + cir = min_t(u32, GENMASK(14, 0), cir);
>
> Please rename 'cir' to "rate" or "idleslop
On Tuesday 12 May 2020 09:43:34 CEST Geert Uytterhoeven wrote:
> Hi Jerome,
>
> On Mon, May 11, 2020 at 5:53 PM Jerome Pouiller
> wrote:
> > From: Jérôme Pouiller
> >
> > The struct hif_msg is received from the hardware. So, it declared as
> > little endian. However, it is also accessed from man
On 11/05/2020 21:06, Florian Fainelli wrote:
On 5/11/2020 11:29 AM, Russell King - ARM Linux admin wrote:
On Mon, May 11, 2020 at 05:45:02PM +0200, Julien Beraud wrote:
Following commit:
commit 52c956003a9d5bcae1f445f9dfd42b624adb6e87
Author: Russell King
Date: Wed Dec 11 10:56:45 2019
On Tue, 12 May 2020, Toke Høiland-Jørgensen wrote:
> Alexei Starovoitov writes:
>
> >> > Currently fentry/fexit/freplace progs have single prog->aux->linked_prog
> >> > pointer.
> >> > It just needs to become a linked list.
> >> > The api extension could be like this:
> >> > bpf_raw_tp_open(pro
From: Clay McClure
My recent commit b6d49cab44b5 ("net: Make PTP-specific drivers depend on
PTP_1588_CLOCK") exposes a missing dependency in defconfigs that select
TI_CPTS without selecting PTP_1588_CLOCK, leading to linker errors of the
form:
drivers/net/ethernet/ti/cpsw.o: in function `cpsw_nd
On Tue, May 12, 2020 at 12:02 PM Grygorii Strashko
wrote:
>
> From: Clay McClure
>
> My recent commit b6d49cab44b5 ("net: Make PTP-specific drivers depend on
> PTP_1588_CLOCK") exposes a missing dependency in defconfigs that select
> TI_CPTS without selecting PTP_1588_CLOCK, leading to linker err
The PHY Register Accessible Interrupt is enabled by default, so
there's such an interrupt during init. In PHY POLL mode case, the
INTB/PMEB pin is alway active, it is not good. Clear the interrupt by
calling rtl8211f_ack_interrupt().
Signed-off-by: Jisheng Zhang
---
drivers/net/phy/realtek.c | 4
>
>
> On 5/11/20 1:24 PM, Lorenzo Bianconi wrote:
> > xdp_redirect_cpu is currently failing in bpf_prog_load_xattr()
> > allocating cpu_map map if CONFIG_NR_CPUS is less than 64 since
> > cpu_map_alloc() requires max_entries to be less than NR_CPUS.
> > Set cpu_map max_entries according to NR_CPU
Hi,
On 12/05/2020 06:54:29+0100, Guillaume Tucker wrote:
> Please see the bisection report below about a boot failure.
>
> Reports aren't automatically sent to the public while we're
> trialing new bisection features on kernelci.org but this one
> looks valid.
>
> It appears to be due to the fac
Tue, May 12, 2020 at 09:15:52AM CEST, vadym.koc...@plvision.eu wrote:
>On Tue, May 12, 2020 at 07:55:36AM +0200, Jiri Pirko wrote:
>> Mon, May 11, 2020 at 09:24:22PM CEST, vadym.koc...@plvision.eu wrote:
>> >On Mon, May 11, 2020 at 02:57:23PM +0200, Jiri Pirko wrote:
>> >> [...]
>> >>
>> >> >diff
Fix the following warning:
drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c:609:17: warning:
‘rtl8225z2_tx_power_ofdm’ defined but not used
static const u8 rtl8225z2_tx_power_ofdm[] = {
Reported-by: Hulk Robot
Signed-off-by: ChenTao
---
drivers/net/wireless/realtek/rtl818x/rtl8187/rtl82
On Mon, May 11, 2020 at 09:45 PM CEST, Martin KaFai Lau wrote:
> On Mon, May 11, 2020 at 08:52:01PM +0200, Jakub Sitnicki wrote:
>
> [ ... ]
>
>> Performance considerations
>> ==
>>
>> Patch set adds new code on receive hot path. This comes with a cost,
>> especially in a sc
On 5/12/20, Paul Durrant wrote:
>> -Original Message-
>> From: Denis Kirjanov
>> Sent: 11 May 2020 18:22
>> To: p...@xen.org
>> Cc: netdev@vger.kernel.org; bro...@redhat.com; jgr...@suse.com;
>> wei@kernel.org;
>> ilias.apalodi...@linaro.org
>> Subject: Re: [PATCH net-next v9 2/2] xen
On 5/12/20, Jürgen Groß wrote:
> On 11.05.20 19:27, Denis Kirjanov wrote:
>> On 5/11/20, Jürgen Groß wrote:
>>> On 11.05.20 12:22, Denis Kirjanov wrote:
The patch adds a basic XDP processing to xen-netfront driver.
We ran an XDP program for an RX response received from netback
On Tue, May 12, 2020 at 11:28:40AM +0200, Julien Beraud wrote:
>
>
> On 11/05/2020 21:06, Florian Fainelli wrote:
> >
> >
> > On 5/11/2020 11:29 AM, Russell King - ARM Linux admin wrote:
> > > On Mon, May 11, 2020 at 05:45:02PM +0200, Julien Beraud wrote:
> > > > Following commit:
> > > >
> >
On 12.05.20 14:27, Denis Kirjanov wrote:
On 5/12/20, Jürgen Groß wrote:
On 11.05.20 19:27, Denis Kirjanov wrote:
On 5/11/20, Jürgen Groß wrote:
On 11.05.20 12:22, Denis Kirjanov wrote:
The patch adds a basic XDP processing to xen-netfront driver.
We ran an XDP program for an RX response re
The cipso and calipso code can set the MLS_CAT attribute on
successful parsing, even if the corresponding catmap has
not been allocated, as per current configuration and external
input.
Later, selinux code tries to access the catmap if the MLS_CAT flag
is present via netlbl_catmap_getlong(). That
I use two devices, both support 1000M speed, they are directly connected
with a network cable. Two devices enable autoneg, and then do the following
test repeatedly:
ifconfig eth5 down
ifconfig eth5 up
sleep $((RANDOM%6))
ifconfig eth5 down
ifconfig eth5 up
On Tuesday, May 12, 2020 2:36 AM, Alexei Starovoitov
wrote:
> On Mon, May 11, 2020 at 05:12:10PM -0700, s...@google.com wrote:
>
> > On 05/08, Alexei Starovoitov wrote:
> >
> > > From: Alexei Starovoitov a...@kernel.org
> > > [..]
> > > @@ -3932,7 +3977,7 @@ SYSCALL_DEFINE3(bpf, int, cmd, union
On Tue, May 12, 2020 at 2:27 AM Kunihiko Hayashi
wrote:
>
> Convert the UniPhier AVE4 controller binding to DT schema format.
>
> Signed-off-by: Kunihiko Hayashi
> ---
>
> Changes since v1:
> - Set true to phy-mode and phy-handle instead of $ref
> - Add mac-address and local-mac-address for exist
On 11/05/2020 23:36, Jakub Kicinski wrote:
> Also with W=1:
>
> ../drivers/net/ethernet/sfc/siena.c:951:14: warning: symbol
> 'siena_check_caps' was not declared. Should it be static?
> 1a3,5
> ../drivers/net/ethernet/sfc/siena.c:951:14: warning: no previous prototype
> for ‘siena_check_capsâ
Alan Maguire writes:
> On Tue, 12 May 2020, Toke Høiland-Jørgensen wrote:
>
>> Alexei Starovoitov writes:
>>
>> >> > Currently fentry/fexit/freplace progs have single
>> >> > prog->aux->linked_prog pointer.
>> >> > It just needs to become a linked list.
>> >> > The api extension could be like
> > As for getting / setting the threshold, perhaps ETHTOOL_MSG_LINKINFO_GET
> > and ETHTOOL_MSG_LINKINFO_SET. Unless you expect more configurable
> > parameters like this in which case we may want to consider adding new
> > request type (e.g. link params or link management).
>
> Currently in my s
On 5/12/20, Jürgen Groß wrote:
> On 12.05.20 14:27, Denis Kirjanov wrote:
>> On 5/12/20, Jürgen Groß wrote:
>>> On 11.05.20 19:27, Denis Kirjanov wrote:
On 5/11/20, Jürgen Groß wrote:
> On 11.05.20 12:22, Denis Kirjanov wrote:
>> The patch adds a basic XDP processing to xen-netfront
Fix a bug and a build warning introduced in a recent refactor.
Edward Cree (2):
sfc: actually wire up siena_check_caps()
sfc: siena_check_caps() can be static
drivers/net/ethernet/sfc/siena.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Assign it to siena_a0_nic_type.check_caps function pointer.
Fixes: be904b855200 ("sfc: make capability checking a nic_type function")
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/siena.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/sfc/siena.c b/drivers/net
Reported-by: Jakub Kicinski
Reported-by: kbuild test robot
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/siena.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/siena.c b/drivers/net/ethernet/sfc/siena.c
index d8b052979b1b..891e9fb6abec
On 12.05.20 15:21, Denis Kirjanov wrote:
On 5/12/20, Jürgen Groß wrote:
On 12.05.20 14:27, Denis Kirjanov wrote:
On 5/12/20, Jürgen Groß wrote:
On 11.05.20 19:27, Denis Kirjanov wrote:
On 5/11/20, Jürgen Groß wrote:
On 11.05.20 12:22, Denis Kirjanov wrote:
The patch adds a basic XDP proc
On Mon, May 11, 2020 at 10:44 PM CEST, Alexei Starovoitov wrote:
> On Mon, May 11, 2020 at 08:52:06PM +0200, Jakub Sitnicki wrote:
>> Run a BPF program before looking up a listening socket on the receive path.
>> Program selects a listening socket to yield as result of socket lookup by
>> calling b
On Tue, May 12, 2020 at 08:48:21PM +0800, Yonglong Liu wrote:
> I use two devices, both support 1000M speed, they are directly connected
> with a network cable. Two devices enable autoneg, and then do the following
> test repeatedly:
> ifconfig eth5 down
> ifconfig eth5 up
> sleep
Hello,
syzbot found the following crash on:
HEAD commit:21c44613 kmsan: page_alloc: more assuring comment
git tree: https://github.com/google/kmsan.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=1533f00c10
kernel config: https://syzkaller.appspot.com/x/.config
Currently, on MP_JOIN failure we reset the child
socket, but leave the request socket untouched.
tcp_check_req will deal with it according to the
'tcp_abort_on_overflow' sysctl value - by default the
req socket will stay alive.
The above leads to inconsistent behavior on MP JOIN
failure, and bad
Move the steps to prepare an inet_connection_sock for
forced disposal inside a separate helper. No functional
changes inteded, this will just simplify the next patch.
Suggested-by: Christoph Paasch
Signed-off-by: Paolo Abeni
---
include/net/inet_connection_sock.h | 8
net/ipv4/inet_con
MP_JOIN subflows must not land into the accept queue.
Currently tcp_check_req() calls an mptcp specific helper
to detect such scenario.
Such helper leverages the subflow context to check for
MP_JOIN subflows. We need to deal also with MP JOIN
failures, even when the subflow context is not availabl
Currently if we hit an MP_JOIN failure on the third ack, the child socket is
closed with reset, but the request socket is not deleted, causing weird
behaviors.
The main problem is that MPTCP's MP_JOIN code needs to plug it's own
'valid 3rd ack' checks and the current TCP callbacks do not allow tha
On Mon, May 11, 2020 at 10:54 PM CEST, Martin KaFai Lau wrote:
> On Mon, May 11, 2020 at 09:26:02PM +0200, Jakub Sitnicki wrote:
>> On Mon, May 11, 2020 at 08:59 PM CEST, Martin KaFai Lau wrote:
>> > On Mon, May 11, 2020 at 11:08:15AM +0200, Jakub Sitnicki wrote:
>> >> On Fri, May 08, 2020 at 08:39
Hi,
* Grygorii Strashko [200512 10:03]:
> From: Clay McClure
>
> My recent commit b6d49cab44b5 ("net: Make PTP-specific drivers depend on
> PTP_1588_CLOCK") exposes a missing dependency in defconfigs that select
> TI_CPTS without selecting PTP_1588_CLOCK, leading to linker errors of the
> form:
On 5/12/20 3:51 AM, Lorenzo Bianconi wrote:
On 5/11/20 1:24 PM, Lorenzo Bianconi wrote:
xdp_redirect_cpu is currently failing in bpf_prog_load_xattr()
allocating cpu_map map if CONFIG_NR_CPUS is less than 64 since
cpu_map_alloc() requires max_entries to be less than NR_CPUS.
Set cpu_map max
On 5/12/20 2:04 AM, Eelco Chaudron wrote:
When the probe code was failing for any reason ENOTSUP was returned, even
if this was due to no having enough lock space. This patch fixes this by
returning EPERM to the user application, so it can respond and increase
the RLIMIT_MEMLOCK size.
Signed-
Dear Network Core developers!
I've been debugging an issue with Multicast replies from underlying
interface of MACVLAN towards MACVLAN. These SKBs never contain a MAC header
and therefore cannot be properly processed by MACVLAN.
The usecase is following:
eth1 <-- eth1.212 <-- macvlan@eth1.212 (in
On 12/05/2020 17:22, Tony Lindgren wrote:
Hi,
* Grygorii Strashko [200512 10:03]:
From: Clay McClure
My recent commit b6d49cab44b5 ("net: Make PTP-specific drivers depend on
PTP_1588_CLOCK") exposes a missing dependency in defconfigs that select
TI_CPTS without selecting PTP_1588_CLOCK, l
On 5/8/20 11:53 PM, Alexei Starovoitov wrote:
From: Alexei Starovoitov
Implement permissions as stated in uapi/linux/capability.h
In order to do that the verifier allow_ptr_leaks flag is split
into allow_ptr_leaks and bpf_capable flags and they are set as:
env->allow_ptr_leaks = perfmon_capa
On 5/11/20 8:29 PM, Andrii Nakryiko wrote:
On Sat, May 9, 2020 at 10:10 AM Yonghong Song wrote:
On 5/8/20 4:20 PM, Andrii Nakryiko wrote:
While working on BPF ringbuf implementation, testing, and benchmarking, I've
developed a pretty generic and modular benchmark runner, which seems to b
Currently, the kprobe BPF program attachment method for bpf_load is
pretty outdated. The implementation of bpf_load "directly" controls and
manages(create, delete) the kprobe events of DEBUGFS. On the other hand,
using using the libbpf automatically manages the kprobe event.
(under bpf_link interfa
Currently, the kprobe BPF program attachment method for bpf_load is
quite old. The implementation of bpf_load "directly" controls and
manages(create, delete) the kprobe events of DEBUGFS. On the other hand,
using using the libbpf automatically manages the kprobe event.
(under bpf_link interface)
B
BPF tail call uses the BPF_MAP_TYPE_PROG_ARRAY type map for calling
into other BPF programs and this PROG_ARRAY should be filled prior to
use. Currently, samples with the PROG_ARRAY type MAP fill this program
array with bpf_load. For bpf_load to fill this map, kernel BPF program
must specify the se
Because the previous two commit replaced the bpf_load implementation of
the user program with libbpf, the corresponding kernel program's MAP
definition can be replaced with new BTF-defined map syntax.
This commit only updates the samples which uses libbpf API for loading
bpf program not with bpf_l
When running BPF tests I ran into some issues and couldn't get a clean
set of results on the bpf-next master branch. Just wanted to check if anyone
else is seeing any of these failures.
1. Timeouts. When running "make run_tests" in tools/testing/selftests/bpf,
the kselftest runner uses an over-ag
On Mon, May 11, 2020 at 02:57:23PM +0200, Jiri Pirko wrote:
> [...]
>
> >+netdev_tx_t prestera_rxtx_xmit(struct prestera_port *port, struct sk_buff
> >*skb)
>
> Why this has "rx" in the name??
This is just a following of a module prefix which is prestera_rxtx_,
do you think it is better to avoi
* Grygorii Strashko [200512 14:35]:
> On 12/05/2020 17:22, Tony Lindgren wrote:
> > However, there's at least one more issue left that shows up at least
> > on ti81xx dra62x-j5eco-evm on v5.7-rc5 that has commit b46b2b7ba6e1
> > ("ARM: dts: Fix dm814x Ethernet by changing to use rgmii-id mode").
>
On Wed, Apr 29, 2020 at 10:16:34PM +0200, Martin Blumenstingl wrote:
> The PRG_ETHERNET registers on Meson8b and newer SoCs can add an RX
> delay. Add a property with the known supported values so it can be
> configured according to the board layout.
>
> Signed-off-by: Martin Blumenstingl
> ---
>
On Mon, May 11, 2020 at 12:32:22PM +0200, Jiri Pirko wrote:
[...]
>
> This is RCU list. Treat it accordingly.
>
>
> >+spin_unlock(&sw->ports_lock);
>
> I don't follow, why do you need to protect the list by spinlock here?
> More to that, why do you need the port_list reader-writer
> prote
Tue, May 12, 2020 at 04:50:37PM CEST, vadym.koc...@plvision.eu wrote:
>On Mon, May 11, 2020 at 02:57:23PM +0200, Jiri Pirko wrote:
>> [...]
>>
>
>> >+netdev_tx_t prestera_rxtx_xmit(struct prestera_port *port, struct sk_buff
>> >*skb)
>>
>> Why this has "rx" in the name??
>This is just a followin
Tue, May 12, 2020 at 04:53:52PM CEST, vadym.koc...@plvision.eu wrote:
>On Mon, May 11, 2020 at 12:32:22PM +0200, Jiri Pirko wrote:
>
>[...]
>
>>
>> This is RCU list. Treat it accordingly.
>>
>>
>> >+ spin_unlock(&sw->ports_lock);
>>
>> I don't follow, why do you need to protect the list by sp
From: Jérôme Pouiller
Sparse detects that le16_to_cpup() expects a __le16 * as argument.
Change the cast operator to be compliant with sparse.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.c | 2 +-
drivers/staging/wfx/traces.h | 2 +-
2 files changed, 2 insertions(+), 2 delet
From: Jérôme Pouiller
The field 'status' appears in most of structs returned by the hardware.
This field is encoded as little endian. Sparse complains this field is
not always correctly accessed:
drivers/staging/wfx/data_rx.c:53:16: warning: restricted __le32 degrades to
integer
drivers
From: Jérôme Pouiller
The attribute event_id is little-endian. We have to take to the
endianness when we access it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_rx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/st
From: Jérôme Pouiller
The attribute indication_type is little-endian. We have to take to the
endianness when we access it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_rx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wfx/hif_rx.c b/
From: Jérôme Pouiller
The struct hif_rx_stats contains only little endian values. Thus, it is
necessary to fix byte ordering before to use them.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/debug.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/driver
From: Jérôme Pouiller
The field wakeup_period_max from struct hif_mib_beacon_wake_up_period is
a u8. So, assigning it a __le16 produces a nasty bug on big-endian
architectures.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx_mib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
From: Jérôme Pouiller
The struct hif_ind_startup is received from the hardware. So it is
declared as little endian. However, it is also stored in the main driver
structure and used on different places in the driver. Sparse complains
about that:
drivers/staging/wfx/data_tx.c:388:43: warning:
On Tue, May 12, 2020 at 05:03:06PM +0200, Jiri Pirko wrote:
> Tue, May 12, 2020 at 04:53:52PM CEST, vadym.koc...@plvision.eu wrote:
> >On Mon, May 11, 2020 at 12:32:22PM +0200, Jiri Pirko wrote:
> >
> >[...]
> >
> >>
> >> This is RCU list. Treat it accordingly.
> >>
> >>
> >> >+ spin_unlock(&sw-
From: Jérôme Pouiller
The field 'num_tx_confs' from the struct hif_cnf_multi_transmit is a
__le32. Sparse complains this field is not always correctly accessed:
drivers/staging/wfx/hif_rx.c:82:9: warning: restricted __le32 degrades to
integer
drivers/staging/wfx/hif_rx.c:87:29: warning:
On 5/8/20 11:53 PM, Alexei Starovoitov wrote:
From: Alexei Starovoitov
Implement permissions as stated in uapi/linux/capability.h
In order to do that the verifier allow_ptr_leaks flag is split
into allow_ptr_leaks and bpf_capable flags and they are set as:
env->allow_ptr_leaks = perfmon_capa
From: Jérôme Pouiller
Sparse complains about the accesses to the field 'len' from struct hif_msg:
drivers/staging/wfx/bh.c:88:32: warning: restricted __le16 degrades to
integer
drivers/staging/wfx/bh.c:88:32: warning: restricted __le16 degrades to
integer
drivers/staging/wfx/bh.c:9
From: Jérôme Pouiller
The attribute ps_mode_error is little-endian. We have to take to the
endianness when we access it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_rx.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/hif_rx.c b/dri
From: Jérôme Pouiller
The field 'channel_number' from the structs hif_ind_rx and hif_req_start
is a __le32. Sparse complains this field is not always correctly
accessed:
drivers/staging/wfx/data_rx.c:95:55: warning: incorrect type in argument 1
(different base types)
drivers/staging/wfx
From: Jérôme Pouiller
The struct hif_cnf_tx contains only little endian values. Thus, it is
necessary to fix byte ordering before to use them. Especially, sparse
detected wrong access to fields media_delay and tx_queue_delay.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 3
From: Jérôme Pouiller
Sparse detected that le32_to_cpu should be used instead of cpu_to_le32.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hwio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/hwio.c b/drivers/staging/wfx/hwio.c
index d878cb3e
From: Jérôme Pouiller
Hello,
As already discussed here[1], this series improves support for big
endian hosts. All warnings raised by sparse are now fixed.
Note, this series aims to be applied on top of PR named "staging: wfx:
fix Out-Of-Band IRQ"
[1] https://lore.kernel.org/lkml/201920285
From: Jérôme Pouiller
The field packet_id is not interpreted by the device. It is only used as
identifier for the device answer. So it is not necessary to declare it
little endian. It fixes some warnings raised by Sparse without
complexifying the code.
Signed-off-by: Jérôme Pouiller
---
driver
From: Jérôme Pouiller
The structs hif_{req,cnf}_read_mib contain only little endian values.
Thus, it is necessary to fix byte ordering before to use them.
Especially, sparse detected wrong accesses to fields mib_id and length.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx.c | 1
From: Jérôme Pouiller
le32_to_cpu(*x) can be advantageously converted in le32_to_cpup(x).
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c
index ac4ec4
From: Jérôme Pouiller
Update the TODO list associated to the wfx driver with the last
progresses.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/TODO | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/staging/wfx/TODO b/drivers/staging/wfx/TODO
index fca333
Hi,
On Tue, 2020-05-12 at 07:46 -0700, Eric Dumazet wrote:
> On Tue, May 12, 2020 at 7:11 AM Paolo Abeni wrote:
> > MP_JOIN subflows must not land into the accept queue.
> > Currently tcp_check_req() calls an mptcp specific helper
> > to detect such scenario.
> >
> > Such helper leverages the su
1 - 100 of 319 matches
Mail list logo
