Re: [iproute PATCH 0/2] Netns performance improvements

On 07/07/2016 01:28 PM, Rick Jones wrote: On 07/07/2016 09:34 AM, Eric W. Biederman wrote: Rick Jones writes: 300 routers is far from the upper limit/goal. Back in HP Public Cloud, we were running as many as 700 routers per network node (*), and more than four network nodes. (back then it was

Re: [PATCH nf-next 0/9] netfilter: remove per-netns conntrack tables, part 1

On 05/05/2016 06:36 PM, Florian Westphal wrote: Brian Haley wrote: I've seen cases where certain users are attacked, where the CT table is filled such that we start seeing "nf_conntrack: table full, dropping packet" messages (as expected). But other users continue to fu

Re: [PATCH nf-next 0/9] netfilter: remove per-netns conntrack tables, part 1

On 05/05/2016 04:54 PM, Florian Westphal wrote: Brian Haley wrote: Openstack networking creates virtual routers using namespaces for isolation between users. VETH pairs are used to connect the interfaces on these routers to different networks, whether they are internal (private) or external

Re: [PATCH nf-next 0/9] netfilter: remove per-netns conntrack tables, part 1

On 04/28/2016 01:13 PM, Florian Westphal wrote: [ CCing netdev so netns folks can have a look too ] This patch series removes the per-netns connection tracking tables. All conntrack objects are then stored in one global global table. This avoids the infamous 'vmalloc' when lots of namespaces ar

Broadcom 5708 taking a few seconds to get link-up

Hi Michael, I'm working on a system that has two on-board 5708's. We've noticed that it takes about 3 seconds for the link to come up - is this considered normal? I've tried this with the latest davem tree with similar results to older kernels/drivers. # uname -r 2.6.24 # ethtool -i eth3

Re: [PATCH] IPv6 support for NFS server

Aurélien Charbon wrote: Thanks for your comments. Here is the patch with some cleanups. Hi Aurelien, Just two nits. --- a/include/net/ipv6.h +++ b/include/net/ipv6.h @@ -400,6 +400,15 @@ static inline int ipv6_addr_v4mapped(const struct in6_addr *a) a->s6_addr32[2] == htonl

Re: [PATCH] [IPv6]: IPV6_MULTICAST_IF setting is ignored on link-local connect()

tion without error in the multicast case and we can remove the redundant multicast check there. I think that'd be simpler. I don't think we can remove that check since it covers the non-multicast case. -Brian Signed-off-by: Brian Haley <[EMAIL PROTECTED]> --- diff --git a/net/ipv6/d

Re: [PATCH] [IPv6]: IPV6_MULTICAST_IF setting is ignored on link-local connect()

David Stevens wrote: Brian Haley <[EMAIL PROTECTED]> wrote on 12/19/2007 07:35:46 AM: ... if (usin->sin6_scope_id) sk->sk_bound_dev_if = usin->sin6_scope_id; if (!sk->sk_bound_dev_if && (addr_

Re: [PATCH] [IPv6]: IPV6_MULTICAST_IF setting is ignored on link-local connect()

David Stevens wrote: Vlad Yasevich <[EMAIL PROTECTED]> wrote on 12/19/2007 07:20:53 AM: But this still requires either a SO_BINDTODEVICE or sin6_scope_id. This means the an application can call BINDTODEVICE(eth0), MULTICAST_IF(eth1) issue a connect on a UDP socket an succeed? Seems wrong to m

Re: [PATCH] [IPv6]: IPV6_MULTICAST_IF setting is ignored on link-local connect()

t_oif matches sk_bind_dev_if here - it's actually done in the setsockopt() code already when we set it, duplicating it here isn't that big a deal. How about the following patch? It does not set sk_bound_dev_if to mcast_oif, but does allow the connect() to succeed. -Brian Sign

Re: [PATCH] [IPv6]: IPV6_MULTICAST_IF setting is ignored on link-local connect()

David Stevens wrote: Brian Haley <[EMAIL PROTECTED]> wrote on 12/18/2007 12:57:54 PM: Trying to connect() to an IPv6 link-local multicast address by specifying the outgoing multicast interface doesn't work, you have to bind to a device first with an SO_BINDTODEVICE setsockopt() ca

[PATCH] [IPv6]: IPV6_MULTICAST_IF setting is ignored on link-local connect()

used for the connection, as specified in RFC 3493. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> --- diff --git a/net/ipv6/datagram.c b/net/ipv6/datagram.c index 2ed689a..0b1e7eb 100644 --- a/net/ipv6/datagram.c +++ b/net/ipv6/datagram.c @@ -123,9 +123,15 @@ ipv4_connected: goto out;

Re: [PATCH] IPv6 support for NFS server

Hi Aurelien, Aurélien Charbon wrote: Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and modification) In an email back on October 29th I sent-out

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

Aurélien Charbon wrote: Here is a second missing part of the IPv6 support in NFS server code concerning knfd syscall interface. It updates write_getfd and write_getfd to accept IPv6 addresses. Applies on a kernel including ip_map cache modifications Both patches still have bugs, I think the p

Re: Configuring the same IP on multiple addresses

David Miller wrote: From: David Miller <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 15:25:59 -0700 (PDT) Can you guys please just state upfront what virtualization issue is made more difficult by features you want to remove? Sorry, I mentioned "virtualization" because that's been the largest ma

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

accepted. I have only compile-tested this, hoping you can test the functionality. -Brian Add IPv6 support to NFS server ip_map caching code and knfsd syscall interface - write_getfs() and write_getfd() will now accept IPv6 addresses. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --gi

Re: [PATCH 1/2] NFS: change the ip_map cache code to handle IPv6 addresses

Hi Aurelien, I think you're almost there, at least with my comments :) linux-2.6.23-ipmap/include/net/ipv6.h --- linux-2.6.23-haley/include/net/ipv6.h2007-10-22 09:42:58.0 +0200 +++ linux-2.6.23-ipmap/include/net/ipv6.h2007-10-22 10:10:59.0 +0200 @@ -21,6 +21,7 @@ #in

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

Hi Aurelien, Again, a few more comments. I might just modify these in my own tree and send out a patch that combines both into one, it might be less work. @@ -229,9 +229,20 @@ static ssize_t write_getfs(struct file * return -EINVAL; data = (struct nfsctl_fsparm*)buf;

Re: multicast: bug or "feature"

Hi David, David Stevens wrote: From looking at the code, it appears that validate source is failing just because of the rp_filter. Do you have rp_filter set to nonzero? If so, it may do what you want just by setting that to 0: sysctl -w net.ipv4.conf.all.rp_filter=0 rp_filter

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

Hi Aurelien, Comments in-line. Aurélien Charbon wrote: Here is a second missing part of the IPv6 support in NFS server code concerning knfd syscall interface. -struct sockaddr_in *sin; +struct sockaddr_in6 *sin, sin6_storage; Nit, should call this sin6 now. @@ -228,9 +228,20 @@ s

Re: [PATCH 1/2] NFS: change the ip_map cache code to handle IPv6 addresses

Hi Aurelien, There were some of my comments you haven't addressed yet, comments in-line. Aurélien Charbon wrote: Here is a patch for the ip_map caching code part in nfs server. +for (i = 0; i < ncp->cl_naddr; i++) { +/* Mapping address */ +ipv6_addr_v4map(ncp->cl_addrlist

[IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493, try2

, by looking up the address in a routing table and using the resulting interface). This patch adds support for (index == 0) to reset the value to it's original state, allowing the system to choose the best interface. IPv4 already behaves this way. -Brian Signed-off-by: Brian

Re: [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493

David Stevens wrote: What about just checking for 0 in the later test? if (val && __dev_get_by_index(val) == NULL) { We could fail the next check right before that though: if (sk->sk_bound_dev_if && sk->sk_bound_dev_if != val) goto e_inval; I just mimicked

Re: [RFC] more robust inet range checking

ed on-top of yours. -Brian Remove SCTP port_rover and port_alloc_lock as they're no longer required. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h index 448f713..c1a083c 100644 --- a/include/net/sctp/structs.h +++

[IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493

, by looking up the address in a routing table and using the resulting interface). This patch adds support for (index == 0) to reset the value to it's original state, allowing the system to choose the best interface. IPv4 already behaves this way. -Brian Signed-off-by: Brian

Re: [PATCH] division-by-zero in inet_csk_get_port

ff-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index ef4d901..61faa38 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -150,10 +150,11 @@ int __udp_lib_get_port(struct sock *sk, unsigned short snum, int i; int low = sysctl_local_port_range[0];

[IPv6] Fix ICMPv6 redirect handling with target multicast address, try 3

field. I re-ran the TAHI Neighbor Discovery section to make sure Linux passes all 245 tests now. -Brian Signed-off-by: Brian Haley <[EMAIL PROTECTED]> Acked-by: David L Stevens <[EMAIL PROTECTED]> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index 74c4d8d..b761dbe 100644 --- a/net/

Re: [IPv6] Fix ICMPv6 redirect handling with target multicast address

Hi David, David Stevens wrote: ipv6_addr_type() returns a mask, so checking for equality will fail to match if any other (irrelevant) attributes are set. How about using bitwise operators for that? ipv6_addr_type() does return a mask, but there's a lot of code that just checks for

[IPv6] Fix ICMPv6 redirect handling with target multicast address

field. I re-ran the TAHI Neighbor Discovery section to make sure Linux passes all 245 tests now. -Brian Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index 74c4d8d..a0a6406 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -1267,7 +

Re: [IPV6] Fix ICMPv6 redirect handling with target multicast address

Hi, YOSHIFUJI Hideaki / 吉藤英明 wrote: >>> I think it'd also be better if you add the check to be: >>> >>> if (ipv6_addr_type(target) & >>> (IPV6_ADDR_LINKLOCAL|IPV6_ADDR_UNICAST)) >>> >>> or something along those lines, rather than reproducing ipv6_addr_type() >>> code >>> separate

Re: [IPV6] Fix ICMPv6 redirect handling with target multicast address

Hi Yoshifuji, YOSHIFUJI Hideaki / wrote: Dave, Brian, Let me double check this patch. Regards, --yoshfuji In article <[EMAIL PROTECTED]> (at Fri, 28 Sep 2007 17:50:38 -0700), David Stevens <[EMAIL PROTECTED]> says: Brian, A multicast address should never be the target of a ne

[IPV6] Fix ICMPv6 redirect handling with target multicast address

field. I re-ran the TAHI Neighbor Discovery section to make sure Linux passes all 245 tests now. -Brian Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/include/net/ipv6.h b/include/net/ipv6.h index 31b3f1b..4f47d29 100644 --- a/include/net/ipv6.h +++ b/include/net/ipv6.

Re: [PATCH 1/1] NFS: change the ip_map cache code to handle IPv6 addresses

Hi Aurelien, More comments. Aurélien Charbon wrote: This is a small part of missing pieces of IPv6 support for the server. It deals with the ip_map caching code part. /* Insert client into hashtable. */ - for (i = 0; i < ncp->cl_naddr; i++) - auth_unix_add_addr(nc

Re: [IPv6] Add v4mapped address inline

YOSHIFUJI Hideaki / wrote: Please put this just after ipv6_addr_any(), not after ipv6_addr_diff(). Ok, updated patch attached. -Brian Add v4mapped address inline to avoid calls to ipv6_addr_type(). Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/include/net/ip

[IPv6] Add v4mapped address inline

Add v4mapped address inline to avoid calls to ipv6_addr_type(). diff --git a/include/net/ipv6.h b/include/net/ipv6.h index 9059e0e..c2b6c11 100644 --- a/include/net/ipv6.h +++ b/include/net/ipv6.h @@ -418,6 +418,12 @@ static inline int ipv6_addr_diff(const struct in6_addr *a1, const struct in6_add

Re: [PATCH 1/1] NFS: change the ip_map cache code to handle IPv6 addresses

Hi Aurelien, Aurélien Charbon wrote: According to Neil's comments, I have tried to correct the mistakes of my first sending I have some more comments. @@ -1559,6 +1560,7 @@ exp_addclient(struct nfsctl_client *ncp) { struct auth_domain*dom; inti, err; +struct in6_a

Re: [GENETLINK]: Fix race in genl_unregister_mc_groups()

Thomas Graf wrote: @@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group); void genl_unregister_mc_group(struct genl_family *family, struct genl_multicast_group *grp) { - BUG_ON(grp->family != family); genl_lock(); - netlink_clear_multicast_

Re: [patch 4/8] Use menuconfig objects: SCTP

[EMAIL PROTECTED] wrote: diff -puN net/sctp/Kconfig~use-menuconfig-objects-sctp net/sctp/Kconfig --- a/net/sctp/Kconfig~use-menuconfig-objects-sctp +++ a/net/sctp/Kconfig @@ -2,11 +2,9 @@ # SCTP configuration # -menu "SCTP Configuration (EXPERIMENTAL)" - depends on INET && EXPERIMENTAL

Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any()

Eric Dumazet wrote: On 64bit arches, we can speedup some IPV6 addresses compares, using 64 bits fields in struct in6_addr. diff --git a/include/linux/in6.h b/include/linux/in6.h index 2a61c82..a4241a6 100644 --- a/include/linux/in6.h +++ b/include/linux/in6.h @@ -34,10 +34,12 @@ struct in6_ad

Re: [PATCH 4/4] Add loopback address type inline

YOSHIFUJI Hideaki / wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 32c6398..06ee92d 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1067,7 +1067,6 @@ int ip6_route_add(struct fib6_config *cfg) struct net_device *dev = NULL; struct inet6_dev *idev = NUL

Re: [PATCH 1/4] [IPv6] Add link and site-local scope inline

YOSHIFUJI Hideaki / wrote: In article <[EMAIL PROTECTED]> (at Thu, 05 Apr 2007 23:21:05 -0400), Brian Haley <[EMAIL PROTECTED]> says: Add link and site-local scope inline to avoid calls to ipv6_addr_type(). I disagree. Multicast scopes should also be handled appropriate

[PATCH 1/4] [IPv6] Add link and site-local scope inline

Add link and site-local scope inline to avoid calls to ipv6_addr_type(). Signed-off-by: Brian Haley <[EMAIL PROTECTED]> --- include/net/ipv6.h | 10 ++ net/dccp/ipv6.c |2 +- net/ipv6/addrconf.c |6 +++--- net/ipv6/af_i

[PATCH 3/4] Add mapped address type inline

Add mapped address type inline to avoid calls to ipv6_addr_type(). Signed-off-by: Brian Haley <[EMAIL PROTECTED]> --- include/net/ipv6.h |6 ++ net/ipv6/ip6_flowlabel.c |6 ++ net/ipv6/ipv6_sockglue.c |2 +- net/ipv6/tcp_ipv6.c | 13 + net/ipv6

[PATCH 2/4] [IPv6] Add multicast address type inline

Add multicast address type inline to avoid calls to ipv6_addr_type(). Signed-off-by: Brian Haley <[EMAIL PROTECTED]> --- include/net/ipv6.h|5 + net/ipv6/icmp.c | 12 net/ipv6/ip6_tunnel.c |4 ++-- net/ipv6/route.c |4 ++-- 4 files chang

[PATCH 0/4] [IPv6] Add new scope and address type inlines

[sorry if anyone got these multiple times, git-send-email weirdness] This set of patches adds new IPv6 scope and address type inlines to both clean-up the code (inspired by Arnaldo's skb cleanup) and reduce calls to ipv6_addr_type() when we can just compare the address directly. No functionality

[PATCH 4/4] Add loopback address type inline

Add loopback address type inline to avoid calls to ipv6_addr_type(). Signed-off-by: Brian Haley <[EMAIL PROTECTED]> --- include/net/ipv6.h|7 +++ net/ipv6/ip6_output.c |5 +++-- net/ipv6/route.c |8 +++- 3 files changed, 13 insertions(+), 7 deletions(-) diff

Re: [PATCH 3/3] bonding: Improve IGMP join processing

Andy Gospodarek wrote: If we are easily able to differentiate between the multicast addresses in the mc_list as to which are for ipv4 and which are for ipv6 then it would be easy to call-out to something in the ipv6 mcast code when needed instead of always calling out to ipv4 code. I've been un

Re: [PATCH 3/3] bonding: Improve IGMP join processing

Jay Vosburgh wrote: My only concern is that this code assumes all mcast addresses stored in dev->mc-list list are for ipv4 igmp mcast addresses and nothing was done for ipv6. But this is much better than what we have now, so... Agreed, but there's no IPv6 support anywhere in bonding a

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

ves the same as your original. -Brian Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index c341371..ddac8b0 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -593,13 +593,8 @@ ipv6_add_addr(struct inet6_dev *idev, co ifa-

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

Hi Vlad, Vlad Yasevich wrote: Brian Haley wrote: Hi Neil, @@ -830,7 +836,8 @@ retry: ift = !max_addresses || ipv6_count_addresses(idev) < max_addresses ? ipv6_add_addr(idev, &addr, tmp_plen, - ipv6_addr_type(&addr)&IPV6_

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

Hi Neil, @@ -830,7 +836,8 @@ retry: ift = !max_addresses || ipv6_count_addresses(idev) < max_addresses ? ipv6_add_addr(idev, &addr, tmp_plen, - ipv6_addr_type(&addr)&IPV6_ADDR_SCOPE_MASK, IFA_F_TEMPORARY) : NULL; + ipv6_addr_type(&addr)&I

Re: [PATCH 2/4] [SCTP]: Verify some mandatory parameters.

) - goto nomem; This introduced a compiler warning, easily fixed. -Brian Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index fce1f60..fbbc9e6 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@

Re: [Bugme-new] [Bug 7665] New: getsockopt(IPV6_*CAST_HOPS) returns -1

David Miller wrote: I wonder, since the most accurate return value is tied to the route, what is expected of this getsockopt() before a socket's identity (and therefore route) is known? A search for RTAX_HOPLIMIT found very little code that ever sets it, iproute2 was the only important one, so

Re: Fw: [Bugme-new] [Bug 7665] New: getsockopt(IPV6_*CAST_HOPS) returns -1

or a while, so don't know if it will break any existing apps. -Brian Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index 1eafcfc..352690e 100644 --- a/net/ipv6/ipv6_sockglue.c +++ b/net/ipv6/ipv6_sockglue.c @

Re: Fw: [Bugme-new] [Bug 7665] New: getsockopt(IPV6_*CAST_HOPS) returns -1

Andrew Morton wrote: Where fd is a socket (datagram or raw) with IPv6 protocol family, getsockopt(fd, IPPROTO_IPV6, IPV6_UNICAST_HOPS, ...) succeeds, but the returned hop limit is -1. connect()'ing the socket first does not solve the problem. An IPv6 socket's hoplimit value is not set at creat

Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

YOSHIFUJI Hideaki / wrote: Add checksum default defines for mobility header(MH). As the result kernel's behavior is to handle MH checksum as default. I'd like to hold this on. I need to check RFC. That looks correct according to 3775. -Brian - To unsubscribe from this list: send the li

Re: Network virtualization/isolation

Eric W. Biederman wrote: I think for cases across network socket namespaces it should be a matter for the rules, to decide if the connection should happen and what error code to return if the connection does not happen. There is a potential in this to have an ambiguous case where two application

Re: [PATCH] IPv6: only modify checksum for UDP

This is a discussion about Brian's SECOND PATCH which needs fixups. Please forget about the second patch, optimizing this code path isn't worth it if the -1 trick doesn't work in all cases. -Brian - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH] IPv6: optimize echo reply checksum calculation

Al Viro wrote: On Fri, Nov 10, 2006 at 02:04:32PM -0500, Brian Haley wrote: Al Viro wrote: so -= 1 is broken even on ia64 and it's *always* broken on big-endian boxen. It's not broken in ia64, I've tested that, just don't have an x86 for testing right now. Can you please

Re: [PATCH] IPv6: optimize echo reply checksum calculation

Al Viro wrote: so -= 1 is broken even on ia64 and it's *always* broken on big-endian boxen. It's not broken in ia64, I've tested that, just don't have an x86 for testing right now. Can you please apply these changes and prove it's broken? This little trick has been done in other UNIXes for

Re: [PATCH] IPv6: optimize echo reply checksum calculation

Al Viro wrote: On Fri, Nov 10, 2006 at 11:25:53AM -0500, Brian Haley wrote: Since the only difference between echo requests and echo replies is the ICMPv6 type value (which is a difference of 1), just subtracting one from the request checksum will result in the correct checksum for the reply

[PATCH] IPv6: optimize echo reply checksum calculation

Since the only difference between echo requests and echo replies is the ICMPv6 type value (which is a difference of 1), just subtracting one from the request checksum will result in the correct checksum for the reply. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv6/

[PATCH] IPv6: only modify checksum for UDP

Only change upper-layer checksum from 0 to 0x for UDP (as RFC 768 states), not for others as RFC 4443 doesn't require it. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index 81bd45b..dbb9b1f 100644 --- a/net/ipv6/icmp.c +++ b/net/

Re: why do we mangle checksums for v6 ICMP?

Hi Al, Al Viro wrote: AFAICS, the rules are: (1) checksum is 16-bit one's complement of the one's complement sum of relevant 16bit words. (2) for v4 UDP all-zeroes has special meaning - no checksum; if you get it from (1), send all-ones instead. (3) for v6 UDP we have the same remappi

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

Joerg Roedel wrote: Is there something in the RFC that suggests that a byte order other than 'network order' is possible/acceptable there? No. The RFC states nothing at all about byte- or bitorder. That is why the RFC is ambigious at this point. RFC 791 (IPv4) Appendix B does give instruction

[PATCH] make some netfilter globals __read_mostly

Make some netfilter globals __read_mostly at the request of Patrick McHardy. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv4/netfilter/ip_conntrack_core.c b/net/ipv4/netfilter/ip_conntrack_core.c index aa45917..2370245 100644 --- a/net/ipv4/netfilter/ip_conntrack_

Re: [PATCH] change netfilter tunables to __read_mostly

Patrick McHardy wrote: Patrick McHardy wrote: Brian Haley wrote: Change some netfilter tunables to __read_mostly. Also fixed some incorrect file reference comments while I was in there. Please send these kind of patches for netfilter to me so I can make sure they don't clash with

[PATCH] change sctp globals to __read_mostly

Change sctp globals to __read_mostly. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index 5692ef5..d9dd4c4 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c @@ -61,7 +61,7 @@ #include /* Global data structures. */ -

[PATCH] change bridge sysctl tunables to __read_mostly

Change some bridge sysctl tunables to __read_mostly. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c index cf80dd0..ac181be 100644 --- a/net/bridge/br_netfilter.c +++ b/net/bridge/br_netfilter.c @@ -53,10 +53,10 @@

[PATCH] change netfilter tunables to __read_mostly

Change some netfilter tunables to __read_mostly. Also fixed some incorrect file reference comments while I was in there. (this will be my last __read_mostly patch unless someone points out something else that needs it) Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git

[PATCH] change max_dgram_qlen sysctl to __read_mostly

Change AF_UNIX sysctl_unix_max_dgram_qlen to __read_mostly. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 7c91c20..b43a278 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -117,7 +117,7 @@ #include #include

[PATCH] change somaxconn sysctl to __read_mostly

Change sysctl_somaxconn to __read_mostly. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/socket.c b/net/socket.c index f4d143c..e3d67fe 100644 --- a/net/socket.c +++ b/net/socket.c @@ -1336,7 +1336,7 @@ asmlinkage long sys_bind(int fd, struct * ready for lis

Re: [GIT PATCH] IPv6 Updates for net-2.6.19

diff --git a/net/ipv6/route.c b/net/ipv6/route.c index c9f74c1..9b50e0c 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -703,6 +703,7 @@ void ip6_route_input(struct sk_buff *skb .ip6_u = { .daddr = iph->daddr,

Re: [PATCH 22/44] [IPV6]: Find option offset by type.

YOSHIFUJI Hideaki wrote: From: Masahide NAKAMURA <[EMAIL PROTECTED]> This is a helper to search option offset from extension header which can carry TLV option like destination options header. Mobile IPv6 home address option will use it. Based on MIPL2 kernel patch. + /* not_found */ +

[PATCH] Change some sysctl variables to __read_mostly

Change net/core, ipv4 and ipv6 sysctl variables to __read_mostly. Couldn't actually measure any performance increase while testing (.3% I consider noise), but seems like the right thing to do. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/core/neighbour.c

Re: [PATCH] IPv6: only set err in rawv6_bind() when necessary

Every other path going from this location in rawv6_bind() will clear err to zero, so your patch also doesn't fix any bug. I knew it didn't fix a bug, I just hadn't noticed the C idiom you pointed-out until I knew to look for it. rawv6_bind() even does this, duh. -Brian - To unsubscribe fro

Re: [PATCH] ipv4: don't call upper-layer disconnect function if not connected

The socket could have been bind()'d to, in which case it will not move to connected state and we still need to invoke the disconnect methods such as udp_disconnect() to clear out that binding. Ok. You seem to be groveling in random areas of the ipv4 and ipv6 stack, what are you working on?

[PATCH] ipv4: don't call upper-layer disconnect function if not connected

Calling connect() with AF_UNSPEC will disconnect a socket, but we don't need to do any work if the socket isn't currently connected. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index c84a320..b294b92 100644 --- a/net/ipv4

[PATCH] IPv6: only set err in rawv6_bind() when necessary

The variable 'err' is set in rawv6_bind() before the address check fails instead of after, moved inside if() statement. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c index 8a30cd8..072b28b 100644 --- a/net/ipv6/raw.c +++ b/net/ipv6/

Re: [PATCH] s2io: netpoll support

tdump is a Red Hat thing. I can test any changes you'd want to make with this patch if you post the diffs. -Brian -Original Message----- From: Brian Haley [mailto:[EMAIL PROTECTED] Sent: Thursday, June 15, 2006 11:37 AM To: netdev@vger.kernel.org Cc: [EMAIL PROTECTED]; [EMAIL

Re: [PATCH] s2io: netpoll support

This adds netpoll support for things like netconsole/kgdboe to the s2io 10GbE driver. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 79208f4..f2b8dba 100644 --- a/drivers/net/s2io.c +++ b/drivers/net/s2io.c @@ -2575,6 +2575,50 @@

[PATCH] ipv6: order addresses by scope

If IPv6 addresses are ordered by scope, then ipv6_dev_get_saddr() can break-out of the device addr_list for() loop when the candidate source address scope is less than the destination address scope. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv6/addrconf.c b/ne

[PATCH] s2io: netpoll support

This adds netpoll support for things like netconsole/kgdboe to the s2io 10GbE driver. This duplicates some code from s2io_poll() as I wanted to be least-invasive, someone from Neterion might have other thoughts? Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/drivers/net/s2

Re: reminder, 2.6.18 window...

jamal wrote: On Wed, 2006-24-05 at 12:14 -0700, Phil Dibowitz wrote: Right, I'm aware there are other ways of doing this - I've written scripts to record a hundreds of numbers, and then subtract them from each other. But those scripts are work arounds I don't have any problem with Phil's cha

[PATCH] netfilter: cannot build latest kernel with CONFIG_NETFILTER=y/m on IA64

include/net/checksum.h:67: undefined reference to `csum_ipv6_magic' net/built-in.o(.text+0x168892):include/net/checksum.h:67: undefined reference to `csum_ipv6_magic' Patch against today's net-2.6.git tree. -Brian Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net

[PATCH] [IPV6]: fix ipv6_saddr_score struct element

The scope element in the ipv6_saddr_score struct used in ipv6_dev_get_saddr() is an unsigned integer, but __ipv6_addr_src_scope() returns a signed integer (and can return -1). Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c --- a/ne

Re: [GIT PATCH] RFC3484 compliant source address selection

h can be expensive) except when necessary. The line numbers are wrong since I couldn't get to your git:// through our firewall. I'll look at the other diffs more closely later. Thanks, -Brian Signed-off-by: Brian Haley <[EMAIL PROTECTED]> *** adiff.h 2005-11-08 1

Re: [PATCH 1/2] [IPV6]: Support several new sockopt / ancillary data in Advanced API (RFC3542).

bring the Type 0 routing header inline with 3542, but I've left the addr field since it doesn't take up any space and makes the code that uses it cleaner. This of course also requires changes in glibc (?) for /usr/include/netinet/ip6.h, etc. Thanks, -Brian Signed-off-by: Brian Haley [

Re: [PATCH 2/2][NET] cleanup INET_REFCNT_DEBUG code

Arnaldo Carvalho de Melo wrote: --- a/include/net/sock.h +++ b/include/net/sock.h @@ -486,6 +486,8 @@ extern int sk_wait_data(struct sock *sk, struct request_sock_ops; +#undef SOCK_REFCNT_DEBUG + Why are you doing this here? Leftover from debugging? -Brian - To unsubscribe from this li