Hi Niklas
I had a look at this series that looks ok for me.
Acked-by: Giuseppe Cavallaro
On 2/19/2018 6:11 PM, Niklas Cassel wrote:
The DMA engine in dwmac4 can segment a large TSO packet to several
smaller packets of (max) size Maximum Segment Size (MSS).
The DMA engine fetches and saves
). To be as little
invasive as possible, this is only done for gmac1000 when the network
device is DSA-enabled (netdev_uses_dsa() returns true).
Signed-off-by: Florian Fainelli
Acked-by: Giuseppe Cavallaro
---
Changes in v2:
- fixed build failure in dwmac4_core.c
- updated dwmac100_core.c to
Hi Florian
for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC
Stripping, so the
core strips the Pad or FCS on frames if the value of the length field is
< 1536 bytes.
For MAC10-100 there is the Bit 8 (ASTP) of the reg0 that does the same
if len is < 46bytes.
In your patch I
-Original Message-
From: Giuseppe CAVALLARO [mailto:peppe.cavall...@st.com]
Sent: Thursday, November 23, 2017 11:58 AM
To: Bhadram Varka ; joao.pi...@synopsys.com
Cc: linux-netdev
Subject: Re: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out
Hi Bhadram
you said that
TQS/RQS fields
Thanks,
Bhadram.
-Original Message-
From: Giuseppe CAVALLARO [mailto:peppe.cavall...@st.com]
Sent: Monday, November 20, 2017 6:37 PM
To: Bhadram Varka ; joao.pi...@synopsys.com
Cc: linux-netdev
Subject: Re: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out
Hello Bhadram
there are some new patches actually in net/net-next repo that you should
have; for example:
[PATCH net-next v2 0/2] net: stmmac: Improvements for multi-queuing
and for AVB
Let me know if these help you.
Regards
Peppe
On 11/20/2017 7:38 AM, Bhadram Varka wrote:
Hi Joao/Pe
Hello
On 10/27/2017 11:05 AM, Jose Abreu wrote:
I think we should take advantage of the fact that this is working
and ready to be merged. Its just HW configuration but maybe it
can serve as momentum for other drivers to also integrate this?
Let me propose to have it now in the next-next.
This
Yes you need these settings, thx for these patches.
Acked-by: Giuseppe Cavallaro
On 10/13/2017 11:58 AM, Jose Abreu wrote:
Hi,
Two improvements for stmmac: First one corrects the available fifo size per
queue, second one corrects enabling of AVB queues. More info in commit log.
Best
On 10/5/2017 2:50 AM, Kees Cook wrote:
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: netdev
Hi Thomas
On 7/29/2017 9:54 PM, Thomas Petazzoni wrote:
Hello Giuseppe,
On Wed, 28 Jun 2017 16:40:51 +0200, Giuseppe CAVALLARO wrote:
I do not want to change a critical reset function shared among
different platforms where
this problem has never met but you are right that we have to find a
On 7/8/2017 9:46 AM, Christophe JAILLET wrote:
'alloc_dma_[rt]x_desc_resources()' functions look very close.
Remove a useless initialization and use the same label name for error
handling path in order to get them even closer.
Signed-off-by: Christophe JAILLET
Acked-by: Giuseppe
: Christophe JAILLET
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 4322fa4a13e8.
: Christophe JAILLET
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 19bba6281dab.
ter offset (0x1000) but ethtool (stmmac.c) looks for the
DMA registers after the MAC registers which is offset 12.
This patch adds the DMA register offset so that indexing is correct.
Signed-off-by: Thor Thayer
Acked-by: Giuseppe Cavallaro
---
v2 Modify the commit message to specify commit
,
On Mon, 15 May 2017 16:27:34 +0200, Thomas Petazzoni wrote:
On Wed, 10 May 2017 09:18:17 +0200, Thomas Petazzoni wrote:
On Wed, 10 May 2017 09:03:12 +0200, Giuseppe CAVALLARO wrote:
Please, read again my patch and the description of the problem that I
have sent. But basically, any
n send the series with my Acked-by: Giuseppe Cavallaro
Regards
peppe
fprintf(stdout, "Reg%d 0x%08X\n", i, *stmmac_reg++);
return 0;
Status Register
Offset 22 - HW Feature Register
Signed-off-by: Thor Thayer
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c | 4 ++--
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff
Hi Joao
On 6/8/2017 8:02 PM, Joao Pinto wrote:
This patch fixes the description of the DT AVB parameters and gives
an accurate example. It was also included the base values that were
used to get the example' CBS paremeter values.
Signed-off-by: Joao Pinto
---
Documentation/devicetree/binding
reaches the next last descriptor,
which actually has the bit set, the DMA will hang.
When the DMA hangs, we get a tx timeout, however,
since stmmac does not do a complete reset of the IP
in stmmac_tx_timeout, we end up in a state with
completely hung TX.
Signed-off-by: Niklas Cassel
Acked-b
Hi Mario
thanks for your tests, and, at first glance, your patches seem to be
sensible so,
please, send the changes as patches for net.git kernel.
Regards
Peppe
On 6/6/2017 12:11 AM, Mario Molitor wrote:
Dear stmmac maintainer group,
I have found an problem in stmmac driver of linux kernel
On 5/31/2017 9:28 PM, thor.tha...@linux.intel.com wrote:
From: Thor Thayer
Fix NETDEV WATCHDOG timeout on startup by adding missing register
writes that properly setup SGMII.
Signed-off-by: Thor Thayer
Thanks a lot for this fix.
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet
Hi Thomas
On 5/8/2017 9:12 PM, Thomas Petazzoni wrote:
Hello,
On Mon, 8 May 2017 16:28:21 +0200, Giuseppe CAVALLARO wrote:
I just see that GMAC_CONTROL and MAC_CTRL_REG are the same, so why not create a
custom adjust_link for each dwmac type ?
This will permit to call it instead of set_ps
file changed, 10 insertions(+), 12 deletions(-)
Acked-by: Giuseppe Cavallaro
Hello
On 5/3/2017 4:30 PM, Corentin Labbe wrote:
On Wed, May 03, 2017 at 10:13:56AM +0200, Giuseppe CAVALLARO wrote:
Hello Thomas
this was initially set by using the hw->link.port; both the core_init
and adjust callback
should invoke the hook and tuning the PS bit according to the speed
EN;
+ /* Set default number of RX and TX queues to use */
+ plat->tx_queues_to_use = 1;
+ plat->rx_queues_to_use = 1;
+
return 0;
}
For the Series, please consider my
Acked-by: Giuseppe Cavallaro
thx a lot
Hello Thomas
this was initially set by using the hw->link.port; both the core_init
and adjust callback
should invoke the hook and tuning the PS bit according to the speed and
mode.
So maybe the ->set_ps is superfluous and you could reuse the existent hook
let me know
Regards
peppe
On 4/27/2
t;;
+ interrupt-names = "macirq", "eth_wake_irq", "eth_lpi";
mac-address = []; /* Filled in by U-Boot */
max-frame-size = <3800>;
phy-mode = "gmii";
Acked-by: Giuseppe Cavallaro
should be set to the sum of
the buffers contained in:
[ ... ...
], which should be equal to skb->len.
Signed-off-by: Niklas Cassel
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 6 +++---
drivers/net/ethernet/stmicro/stmmac/common.h
Hi Niklas
On 4/10/2017 9:43 AM, Niklas Cassel wrote:
From: Niklas Cassel
The hardware has a LPI interrupt.
There is already code in the stmmac driver to parse and handle the
interrupt. However, this information was missing from the DT binding.
i wonder if we could improve the comments in thi
Hi Niklas
patch looks ok for me, Alex any feedback?
peppe
On 4/10/2017 8:33 PM, Niklas Cassel wrote:
From: Niklas Cassel
Field FL/TPL in register TDES3 is not correctly set on GMAC4.
TX appears to be functional on GMAC 4.10a even if this field is not set,
however, to avoid relying on undefin
Hello Joao
On 4/3/2017 3:12 PM, Joao Pinto wrote:
Yes older cores do not support multiple queues and I tried to isolate the
features not to affect older versions.
ok so we are inline ;-)
Do you think that functions as "ndev = alloc_etherdev_mqs" has some sort of
influence?
I do not think
Hello Joao
On 3/30/2017 6:42 PM, Joao Pinto wrote:
Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu:
On 03/30/2017 04:34 PM, Thierry Reding wrote:
On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote:
On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote:
From: Arnd Bergmann
Hello Alex
do you can check if this has to be done for ST platforms?
I do not remember that it was necessary when build as module so
I cannot expect this should be only for dwmac-sun8i.
Regards
peppe
On 4/3/2017 11:14 AM, Corentin Labbe wrote:
Thoses symbol will be needed for the dwmac-sun8i
Hello Corentin
On 4/3/2017 11:14 AM, Corentin Labbe wrote:
Instead of adding more ifthen logic for adding a new mac_device_info
setup function, it is easier to add a function pointer to the function
needed.
Signed-off-by: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |
Hi Thomas
I tested the SMSC on other platform (+ stmmac), not on SPEAr.
ok for reset, keep the radar on clock. Hmm, can you attach a piece of
log file to see the failure?
Regards
Peppe
On 4/2/2017 11:30 PM, Thomas Petazzoni wrote:
Hello,
On Thu, 23 Mar 2017 11:33:23 +0100, Giuseppe
On 3/23/2017 11:48 AM, Giuseppe CAVALLARO wrote:
Hello
On 3/23/2017 11:20 AM, Corentin Labbe wrote:
I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression.
>Could you please share the iperf cmds you are using in order for me
to reproduce
>in my side?
Joao, you have a
Hello
On 3/23/2017 11:20 AM, Corentin Labbe wrote:
I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression.
>Could you please share the iperf cmds you are using in order for me to
reproduce
>in my side?
Joao, you have a really powerful HW integration with multiple channels
for bot
Hello Thomas
On 3/21/2017 3:50 PM, Thomas Petazzoni wrote:
Hello,
On Thu, 9 Mar 2017 15:56:31 +0100, Giuseppe CAVALLARO wrote:
On 3/9/2017 10:32 AM, Thomas Petazzoni wrote:
OK, I'll have a look. However, I'm still confused by this DMA_RESET bit
that never clears, contrary t
Hello Corentin
yes, bisect process is really good approach to me. Pls give us more details.
Recently the multi DMA channel logic has been added so it could be that
something is needed to allow your platform to manage the new code.
Or we introduced some regression. If I have some other idea, I pin
+ Joao
please Joao, could you do a check if new changes have any impact on that?
peppe
On 3/20/2017 8:54 PM, Corentin Labbe wrote:
Hello
Just pushed next-20170320 to my boards and stmmac stop working on both intree
dwmac-sunxi and my dev dwmac-sun8i.
It seems that interrupts never fire, and
Hello Thomas
On 3/9/2017 10:32 AM, Thomas Petazzoni wrote:
OK, I'll have a look. However, I'm still confused by this DMA_RESET bit
that never clears, contrary to what the datasheet says. Are there some
erratas?
I suggest you to take a look at the tx/rx clocks from PHY.
You have to provide the
Hello
We do not test stmmac on this spear board since many years
and I guess you have to provide parameters from the platform.
In fact, stmmac is recently tested with DT.
IIRC, the mac on spear600 could not have the HW cap register
so it is mandatory to provide all the right parameters and
config
s" to
"fill the reg_space used by ethtool".
Signed-off-by: Corentin Labbe
Thx I find it really useful,
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/common.h | 4 +-
.../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 10 +--
.../net/eth
On 2/15/2017 8:39 AM, Corentin Labbe wrote:
Since all patch in v2 already hit linux-next, I just want to be sure, I can add
"Acked-by and Reviewed-by" to thoses 8 new patchs ?
Right I have just seen the V2 patches are in net-next.
pls consider, for this set, my
Acked-by: Giuseppe
Hello Corentin
On 2/14/2017 8:54 PM, Corentin Labbe wrote:
Hello
This is a follow up of my previous stmmac serie which address some comment
done in v2.
I wonder if you can resend all the patches as V3
please add the Acked-by and Reviewed-by. This will help
on final review and integration.
Th
Hi Joao
On 2/7/2017 8:33 PM, Joao Pinto wrote:
I am seeing tx being performed in all queues, but rx is just being routed to
queue 0. The reason why only queue 0 is processing the packets is because I am
using priority tagged routing for now and iperf is not capable of producing
priority tagged t
On 2/8/2017 9:31 AM, Corentin Labbe wrote:
This patch fix the checkpatch warning about free software address.
Signed-off-by: Corentin Labbe
just wonder if this should be sent separately for net-next instead of
Anyway...
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro
On 2/8/2017 9:31 AM, Corentin Labbe wrote:
The dwmac_dma_reset function use an open coded of readl_poll_timeout().
Replace the open coded handling with the proper function.
Signed-off-by: Corentin Labbe
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 14
On 2/8/2017 9:31 AM, Corentin Labbe wrote:
When a PHY is found, printing which one was found (and which type/model) is
a good information to know.
Signed-off-by: Corentin Labbe
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +---
1 file changed, 1
On 2/8/2017 9:31 AM, Corentin Labbe wrote:
The message about invalid speed does not state 1000 as a valid speed.
It is much simpler to said that the speed is invalid.
Signed-off-by: Corentin Labbe
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3
On 2/8/2017 9:31 AM, Corentin Labbe wrote:
The bus_setup function pointer is not used at all, this patch remove it.
no longer used...
Signed-off-by: Corentin Labbe
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
Hello Alexey
On 1/31/2017 2:24 PM, Alexey Brodkin wrote:
Hi Giuseppe,
On Tue, 2017-01-31 at 10:55 +0100, Giuseppe CAVALLARO wrote:
On 1/27/2017 11:23 AM, Alexey Brodkin wrote:
That's why my initial proposal was to ignore whatever we read from this register
if we have MDIO bus instant
consider my:
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 33 ---
1 file changed, 11 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
This patch fix some typos in comments.
Signed-off-by: Corentin Labbe
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 6 +++---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 16
On 1/31/2017 11:39 AM, Corentin Labbe wrote:
On Tue, Jan 31, 2017 at 11:13:49AM +0100, Giuseppe CAVALLARO wrote:
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
The stmmac_mdio_busy_wait() function do the same job than
readl_poll_timeout().
So is is better to replace it.
Signed-off-by: Corentin
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
Since commit cf32deec16e4 ("stmmac: add tx_skbuff_dma to save descriptors used by
PTP"),
the struct dma_desc *p in stmmac_tx_clean was not used at all.
This patch remove this dead code.
Signed-off-by: Corentin Labbe
Acked-by: Giuseppe
On 1/31/2017 11:23 AM, Joao Pinto wrote:
Hi Peppe,
Às 10:00 AM de 1/31/2017, Giuseppe CAVALLARO escreveu:
Hello Corentin
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
Hello
I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64.
This serie is the result of all minor
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
The stmmac driver run TX completion under NAPI but without checking the
work done by the TX completion function.
This patch add work/budget to the TX completion function.
The visible effect is that it keep the driver longer under NAPI and
boost perfo
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
checkpatch complains about two unsigned without type after.
Since the value return is u32, it is simpler to replace it by u32 instead
of "unsigned int"
Signed-off-by: Corentin Labbe
Acked-by: Giuseppe Cavallaro
---
drivers/ne
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
The u64 x variable in sysfs_display_ring is unused.
This patch remove it.
Signed-off-by: Corentin Labbe
well spot
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ---
1 file changed, 3 deletions
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
When a PHY is found, printing which one was found (and which type/model) is
a good information to know.
Signed-off-by: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/n
Labbe
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/common.h | 2 +-
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 2 +-
drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 2 +-
drivers/net/ethernet/stmicro/stmmac/norm_desc.c | 2 +-
drivers/net
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
Add 1000 as a valid speed in the error message about invalid speed
in stmmac_adjust_link()
Signed-off-by: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driver
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
This patch rewrite two test against NULL value with correct style.
Signed-off-by: Corentin Labbe
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
Checkpatch complains about some code style problem on stmmac_mdio.c.
This patch fix them.
Signed-off-by: Corentin Labbe
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 7 ---
1 file changed, 4 insertions
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
As said by checkpatch ENOSYS means 'invalid syscall nr' and nothing
else.
This patch replace ENOSYS by the more appropriate value EINVAL.
Signed-off-by: Corentin Labbe
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmi
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
the define MAC_RNABLE_RX have a typo, rename it to MAC_ENABLE_RX
Signed-off-by: Corentin Labbe
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro/stmmac/common.h| 2 +-
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 4 ++--
2
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
The bus_setup function pointer is not used at all, this patch remove it.
indeed this was used and documented on some previous kernels where some
ST40/SH4 platforms (w/o DT).
It's ok to remove it in the new MAC generation; I do not think that
ST will
Hello Corentin
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
Hello
I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64.
This serie is the result of all minor problem found in the stmmac driver.
thank for this effort, many changes are to tidy up some part of the code
so
On 1/27/2017 11:23 AM, Alexey Brodkin wrote:
That's why my initial proposal was to ignore whatever we read from this register
if we have MDIO bus instantiated already.
sorry for my late reply, I agree with this approach, according to the
HW and platform configuration the driver has to understan
On 12/18/2016 9:38 PM, Pavel Machek wrote:
Fix up memory barriers in stmmac driver. They are meant to protect
against DMA engine, so smp_ variants are certainly wrong, and dma_
variants are preferable.
Signed-off-by: Pavel Machek
Acked-by: Giuseppe Cavallaro
diff --git a/drivers/net
On 12/15/2016 10:45 AM, Pavel Machek wrote:
Giuseppe, is there documentation available for the chip? Driver says
Documentation available at:
http://www.stlinux.com
but that page does not work for me...
Hi Pavel, yes the page has been removed but all the relevant and
updated driver
Hello Jie
On 12/14/2016 5:05 AM, Jie Deng wrote:
Hi Peppe,
On 2016/12/12 22:17, Giuseppe CAVALLARO wrote:
Hi David
On 12/7/2016 7:06 PM, David Miller wrote:
Giuseppe and Alexandre,
There are a lot of patches and discussions happening around the stammc
driver lately and both of you are
Hello Niklas
On 12/13/2016 10:38 AM, Niklas Cassel wrote:
On 12/13/2016 08:22 AM, Giuseppe CAVALLARO wrote:
On 12/12/2016 5:25 PM, Niklas Cassel wrote:
On 12/12/2016 11:19 AM, Joao Pinto wrote:
Hi,
Às 1:44 AM de 12/10/2016, Florian Fainelli escreveu:
Le 12/09/16 à 16:16, Andy Shevchenko
On 12/13/2016 9:26 AM, Niklas Cassel wrote:
On 12/13/2016 07:47 AM, Giuseppe CAVALLARO wrote:
Hello Niklas, Alex,
my fault and a step behind... Current code is OK
when manage the AAL that, although it is passed from
the axi structure, it is always used to program,
for all the chip versions
On 12/12/2016 5:25 PM, Niklas Cassel wrote:
On 12/12/2016 11:19 AM, Joao Pinto wrote:
Hi,
Às 1:44 AM de 12/10/2016, Florian Fainelli escreveu:
Le 12/09/16 à 16:16, Andy Shevchenko a écrit :
On Sat, Dec 10, 2016 at 12:52 AM, Florian Fainelli wrote:
It's kind of sad that customers of that
Peppe
On 12/12/2016 3:18 PM, Giuseppe CAVALLARO wrote:
Please Niklas
when you send the patch, add my
Acked-by: Giuseppe Cavallaro
On 12/9/2016 10:53 AM, Niklas Cassel wrote:
On 12/09/2016 10:20 AM, Niklas Cassel wrote:
On 12/08/2016 02:36 PM, Alexandre Torgue wrote:
Hi Niklas,
On 12/05
Please Niklas
when you send the patch, add my
Acked-by: Giuseppe Cavallaro
On 12/9/2016 10:53 AM, Niklas Cassel wrote:
On 12/09/2016 10:20 AM, Niklas Cassel wrote:
On 12/08/2016 02:36 PM, Alexandre Torgue wrote:
Hi Niklas,
On 12/05/2016 05:18 PM, Niklas Cassel wrote:
Hello Giuseppe
Hi David
On 12/7/2016 7:06 PM, David Miller wrote:
Giuseppe and Alexandre,
There are a lot of patches and discussions happening around the stammc
driver lately and both of you are listed as the maintainers.
I really need prompt and conclusive reviews of these patch submissions
from you, and p
Hello All.
On 12/12/2016 11:19 AM, Joao Pinto wrote:
Hi,
Às 1:44 AM de 12/10/2016, Florian Fainelli escreveu:
Le 12/09/16 à 16:16, Andy Shevchenko a écrit :
On Sat, Dec 10, 2016 at 12:52 AM, Florian Fainelli wrote:
It's kind of sad that customers of that IP (stmmac, amd-xgbe, sxgbe)
did
Hello
On 12/9/2016 5:06 PM, Alexandre Torgue wrote:
Hi Niklas
On 12/09/2016 10:53 AM, Niklas Cassel wrote:
On 12/09/2016 10:20 AM, Niklas Cassel wrote:
On 12/08/2016 02:36 PM, Alexandre Torgue wrote:
Hi Niklas,
On 12/05/2016 05:18 PM, Niklas Cassel wrote:
Hello Giuseppe
I'm trying to fig
Hi Alex
On 12/2/2016 3:26 PM, Alexandre Torgue wrote:
4.4 has no GMAC4 support.
Alex, do you remember any patches to fix that?
No sorry Peppe.
Pavel,
Sorry but I'm a little bit confused. I'm dropped in some mails without
historic. I see cleanup, coalescence issue and TSO question.
What is yo
Hi Pavel
On 12/2/2016 11:42 AM, Pavel Machek wrote:
Hi!
Anyway... since you asked. I belive I have way to disable NAPI / tx
coalescing in the driver. Unfortunately, locking is missing on the rx
path, and needs to be extended to _irqsave variant on tx path.
I have just replied to a previous t
On 12/2/2016 1:32 PM, Pavel Machek wrote:
Hi!
Well, if you have a workload that sends and receive packets, it tends
to work ok, as you do tx_clean() in stmmac_poll(). My workload is not
like that -- it is "sending packets at 3MB/sec, receiving none". So
the stmmac_tx_timer() is rescheduled and
Hi Pavel
On 12/2/2016 9:45 AM, Pavel Machek wrote:
Hi!
1 HZ, which is the lowest granularity of non-highres timers in the
kernel, is variable as well as already too large of a delay for
effective TX coalescing.
I seriously think that the TX coalescing support should be ripped out
or disabled
On 12/2/2016 9:58 AM, Corentin Labbe wrote:
On Fri, Dec 02, 2016 at 09:44:48AM +0100, Giuseppe CAVALLARO wrote:
Hello Corentin
patches look ok, I just wonder if you tested it in case of
the stmmac is connected to a transceiver. Let me consider it
a critical part of the driver to properly work
Hi Florian
sorry for my delay.
On 11/24/2016 7:23 PM, Florian Fainelli wrote:
+Peppe,
Le 24/11/2016 à 07:38, Andrew Lunn a écrit :
As for enabling advertising and correct working of cpsw do you mean it
would be better to disable EEE in any PHY on cpsw initialization as
long as cpsw doesn't pro
actually expects it to be in the root node,
not in the stmmac-axi-config.
Also added a note about snps,tso only being available on GMAC4 and newer.
Signed-off-by: Niklas Cassel
Acked-by: Giuseppe Cavallaro
---
Documentation/devicetree/bindings/net/stmmac.txt | 6 +++---
1 file changed, 3
mentioned helper hits mainline.
Note that these patches have only been compile tested.
For common and STi part:
Acked-by: Giuseppe Cavallaro
thx
peppe
Johan
Johan Hovold (7):
net: ethernet: stmmac: dwmac-socfpga: fix use-after-free on probe
errors
net: ethernet: stmmac: dwmac-sti
Hello Corentin
patches look ok, I just wonder if you tested it in case of
the stmmac is connected to a transceiver. Let me consider it
a critical part of the driver to properly work.
Regards
Peppe
On 12/1/2016 4:19 PM, Corentin Labbe wrote:
This patch simply rename regValue to value, like it w
+ Lino
On 12/2/2016 9:24 AM, Giuseppe CAVALLARO wrote:
Hello
On 11/24/2016 10:25 PM, Pavel Machek wrote:
Hi!
I'm debugging strange delays during transmit in stmmac driver. They
seem to be present in 4.4 kernel (and older kernels, too). Workload is
burst of udp packets being sent,
On 12/1/2016 11:48 PM, Pavel Machek wrote:
@@ -2771,12 +2771,8 @@ static netdev_features_t stmmac_fix_features(struct
net_device *dev,
features &= ~NETIF_F_CSUM_MASK;
/* Disable tso if asked by ethtool */
- if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) {
-
+ Alex
On 11/30/2016 12:44 PM, Pavel Machek wrote:
Simplify flag assignment.
Signed-off-by: Pavel Machek
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index ed20668..0b706a7 100644
--- a/drivers/net/ethernet/stmicro/stmmac
Hello
On 11/24/2016 10:25 PM, Pavel Machek wrote:
Hi!
I'm debugging strange delays during transmit in stmmac driver. They
seem to be present in 4.4 kernel (and older kernels, too). Workload is
burst of udp packets being sent, pause, burst of udp packets, ...
...
4.9-rc6 still has the delay
On 11/23/2016 12:43 PM, Joao Pinto wrote:
> Rabin Vincent can review and test that the port works properly on our
Artpec-chips that use dwc_eth_qos.c today.
>
> The main porting step is to implement the device tree binding in
bindings/net/snps,dwc-qos-ethernet.txt. Also our chip has a strict re
On 11/24/2016 5:08 PM, Jerome Brunet wrote:
On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote:
Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4
cycle TX clock delay. This seems to work fine for many boards (for
example Odroid-C2 or Amlogic's reference boards) but th
are a certain driver supports, you usually look
at the compatible strings in the struct of_device_id, and not in some
function defined in a completely different file.
No functional change intended.
Signed-off-by: Niklas Cassel
Acked-by: Giuseppe Cavallaro
---
drivers/net/ethernet/stmicro
Hello Joao, Lars.
On 11/22/2016 3:16 PM, Joao Pinto wrote:
Ok, it makes sense.
> Just for curiosity the target setup is the following:
> https://www.youtube.com/watch?v=8V-LB5y2Cos
> but instead of using internal drivers, we desire to use mainline drivers only.
>
> Thanks!
Regarding this subjec
ys helpful.
tools work but indeed should be extended to support more for QoS.
This is another task we have to keep in mind, well spot.
Peppe
Regards,
Ozgur
21.11.2016, 16:38, "Giuseppe CAVALLARO" :
Hello Joao
On 11/21/2016 2:48 PM, Joao Pinto wrote:
Synopsys QoS IP is a separated
On 11/21/2016 4:00 PM, Joao Pinto wrote:
On 21-11-2016 14:36, Giuseppe CAVALLARO wrote:
Hello Joao
On 11/21/2016 2:48 PM, Joao Pinto wrote:
Synopsys QoS IP is a separated hardware component, so it should be reusable by
all implementations using it and so have its own "core driver
1 - 100 of 289 matches
Mail list logo
