Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

On 23.02.2016 13:21, Jiri Pirko wrote: Tue, Feb 23, 2016 at 12:26:00PM CET, han...@stressinduktion.org wrote: Hi Jiri, On 22.02.2016 19:31, Jiri Pirko wrote: From: Jiri Pirko So far, there has been an mlx4-specific sysfs file allowing user to change port type to either

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

Hi Jiri, On 22.02.2016 19:31, Jiri Pirko wrote: From: Jiri Pirko So far, there has been an mlx4-specific sysfs file allowing user to change port type to either Ethernet of InfiniBand. This is very inconvenient. Again, I want to express my concerns regarding all of this

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

On 22.02.2016 20:20, Marc Haber wrote: On Mon, Feb 22, 2016 at 05:15:41PM +0100, Hannes Frederic Sowa wrote: On 22.02.2016 16:47, Marc Haber wrote: Can you reproduce the behavior with accept_ra_from_local =0 as well? Unfortunately, the debugging VM I build works fine, it's just the physical

[PATCH net] ipv4: only create late gso-skb if skb is already set up with CHECKSUM_PARTIAL

iri Benc <jb...@redhat.com> Reported-by: Wakko Warner <wa...@animx.eu.org> Cc: Wakko Warner <wa...@animx.eu.org> Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- net/ipv4/ip_output.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

On 22.02.2016 16:47, Marc Haber wrote: Can you reproduce the behavior with accept_ra_from_local =0 as well? Unfortunately, the debugging VM I build works fine, it's just the physical host showing this behavior. This is really strange. Same here. Debugging VM didn't show this error at all and

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

c1a9a291cee0890eb0f435243f3fb84fefb04348 Author: Hannes Frederic Sowa <han...@stressinduktion.org> Date: Wed Dec 23 22:44:37 2015 +0100 ipv6: honor ifindex in case we receive ll addresses in router advertisements $ git describe --contains c1a9a291cee0890eb0f435243f3fb84fefb04348 v4.4-rc8~5^2~10 ? If you don'

Re: 4.4.1 skb_warn_bad_offload+0xc5/0x110

[full-quote for netdev] Hello, On 16.02.2016 01:08, Wakko Warner wrote: Please keep me in CC. I've been seeing the following on some of my VMs ran under qemu. The VMs do not have internet connectivity. This happened when some files were accessed via NFS to another VM (NOTE: Both VMs throw

Re: https://patchwork.ozlabs.org/patch/579654?

tes the loop as the size is zero without copying the credential information. Just wondering if this might have been lost in the noise ... I think the patch got lost, probably just resending is the easiest solution. ;) For the patch: Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org>

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

Hi, On 08.02.2016 11:55, Jiri Pirko wrote: Mon, Feb 08, 2016 at 11:15:38AM CET, han...@stressinduktion.org wrote: Hello, On 06.02.2016 20:40, Jiri Pirko wrote: Fri, Feb 05, 2016 at 06:38:42PM CET, alexei.starovoi...@gmail.com wrote: On Fri, Feb 05, 2016 at 11:01:22AM +0100, Hannes Frederic

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

Hello, On 06.02.2016 20:40, Jiri Pirko wrote: Fri, Feb 05, 2016 at 06:38:42PM CET, alexei.starovoi...@gmail.com wrote: On Fri, Feb 05, 2016 at 11:01:22AM +0100, Hannes Frederic Sowa wrote: Okay. I see it more as changing mode of operation of hardware and thus has not really anything to do

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

On 04.02.2016 14:26, Jiri Pirko wrote: Thu, Feb 04, 2016 at 02:22:17PM CET, han...@stressinduktion.org wrote: On 03.02.2016 16:17, Daniel Borkmann wrote: On 02/03/2016 02:33 PM, Jiri Pirko wrote: Wed, Feb 03, 2016 at 02:31:33PM CET, bro...@redhat.com wrote: On Wed, 3 Feb 2016 11:47:56 +0100

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

On 03.02.2016 16:17, Daniel Borkmann wrote: On 02/03/2016 02:33 PM, Jiri Pirko wrote: Wed, Feb 03, 2016 at 02:31:33PM CET, bro...@redhat.com wrote: On Wed, 3 Feb 2016 11:47:56 +0100 Jiri Pirko wrote: From: Jiri Pirko [...] It is available here:

Re: [PATCH net] ipv6: fix a lockdep splat

signation, as no barrier is needed. Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org>

Re: [PATCH v3] net:Add sysctl_max_skb_frags

On 03.02.2016 12:25, Herbert Xu wrote: On Wed, Feb 03, 2016 at 09:26:57AM +0100, Hans Westgaard Ry wrote: Devices may have limits on the number of fragments in an skb they support. Current codebase uses a constant as maximum for number of fragments one skb can hold and use. When enabling

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

On 03.02.2016 12:36, Simon McVittie wrote: On 02/02/16 17:34, David Herrmann wrote: Furthermore, with this patch in place, a process better not pass any file-descriptors to an untrusted process. ... Did anyone notify the dbus maintainers of this? They might wanna document this, if not already

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

On 03.02.2016 12:56, David Herrmann wrote: However, with Hannes' revised patch, a different DoS attack against dbus-daemon is possible. Imagine a peer that receives batches of FDs, but never dequeues them. They will be accounted on the inflight-limit of dbus-daemon, as such causing messages of

Re: [PATCH v3] net:Add sysctl_max_skb_frags

On 03.02.2016 13:20, Herbert Xu wrote: On Wed, Feb 03, 2016 at 12:36:21PM +0100, Hannes Frederic Sowa wrote: Agreed that it feels like a hack, but a rather simple one. I would consider this to be just a performance improvement. We certainly need a slow-path when virtio drivers submit gso

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

; Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> Signed-off-by: Willy Tarreau <w...@1wt.eu> --- v2: add reported-by, mitigates and acked-by. It would be nice if (if accepted) it would be backported to -stable as the issue is currently exploitable. --- include/linux/sched

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

On 02.02.2016 20:29, Linus Torvalds wrote: On Tue, Feb 2, 2016 at 10:29 AM, Hannes Frederic Sowa <han...@stressinduktion.org> wrote: Anyway, can someone provide a high-level description of what exactly this patch is supposed to do? Which operation should be limited, who should inflig

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

On 02.02.2016 21:44, Linus Torvalds wrote: On Tue, Feb 2, 2016 at 12:32 PM, Hannes Frederic Sowa <han...@stressinduktion.org> wrote: Unfortunately we never transfer a scm_cookie via the skbs but merely use it to initialize unix_skb_parms structure in skb->cb and destroy it afterwards

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

Hi Willy, On 02.02.2016 21:39, Willy Tarreau wrote: On Tue, Feb 02, 2016 at 09:32:56PM +0100, Hannes Frederic Sowa wrote: But "struct pid *" in unix_skb_parms should be enough to get us to corresponding "struct cred *" so we can decrement the correct counter during skb d

Re: [PATCH] net: drop write-only stack variable

+0100 unix: properly account for FDs passed over unix sockets Signed-off-by: David Herrmann <dh.herrm...@gmail.com> I don't think this specifically needs a Fixes tag. Seems more like a clean-up. Anyway, I also noticed this during review and it can be removed safely. Acked-by: Hannes F

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

On 03.02.2016 01:57, Hannes Frederic Sowa wrote: On 02.02.2016 23:11, Linus Torvalds wrote: But I'm OK with that patch as is if you prefer it that way (maybe you want to use the cred to then test for root separately etc, out maybe there already was done use of cred as cred that I just missed

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

On 02.02.2016 23:11, Linus Torvalds wrote: [ sorry for the html mail, I'm out grocery shopping ] On Feb 2, 2016 13:55, "Hannes Frederic Sowa" <han...@stressinduktion.org> wrote: I slightly tested the attached patch. Looks fine. I do wonder: if the only thing we use t

[PATCH net] unix: correctly track in-flight fds in sending process user_struct

-by: David Herrmann <dh.herrm...@gmail.com> Cc: David Herrmann <dh.herrm...@gmail.com> Cc: Willy Tarreau <w...@1wt.eu> Cc: Linus Torvalds <torva...@linux-foundation.org> Suggested-by: Linus Torvalds <torva...@linux-foundation.org> Signed-off-by: Hannes Frederic Sowa &

Re: [PATCH net] net: Allow flow dissector to handle non 4-byte aligned headers

On 02.02.2016 04:56, Alexander Duyck wrote: @@ -394,7 +407,7 @@ ip_proto_again: data, hlen, &_eth); if (!eth) goto out_bad; - proto = eth->h_proto; +

Re: [PATCH v2] ipv6: addrconf: Fix recursive spin lock call

c addresses useful candidates") Cc: Eric Dumazet <eduma...@google.com> Cc: Erik Kline <e...@google.com> Cc: Hannes Frederic Sowa <han...@stressinduktion.org> Signed-off-by: Subash Abhinov Kasiviswanathan <subas...@codeaurora.org> Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> Definitely a stable candidate, thanks!

Re: [PATCH net v2 2/2] ipv6/udp: use sticky pktinfo egress ifindex on connect()

flowi6_oif in connect() before performing the route lookup. Signed-off-by: Paolo Abeni <pab...@redhat.com> Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org>

Re: [PATCH net v2 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()

ctionality. Signed-off-by: Paolo Abeni <pab...@redhat.com> -- v1 -> v2 move the ip6_route_output() implementation into the header Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org>

Re: [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour

On 29.01.2016 12:30, Paolo Abeni wrote: The kernel has never enforced the egress interface specified via the sticky pktinfo, except briefly between the commits 741a11d9e410 ("net: ipv6: Add RT6_LOOKUP_F_IFACE flag if oif is set") and d46a9d678e4c ("net: ipv6: Dont add RT6_LOOKUP_F_IFACE flag if

Re: [PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()

On 28.01.2016 13:27, Paolo Abeni wrote: On Wed, 2016-01-27 at 19:38 +0100, Hannes Frederic Sowa wrote: On 27.01.2016 14:45, Paolo Abeni wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 3c8834b..973cb73 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1183,11 +1183,10

Re: [PATCH v2] net:Add sysctl_tcp_sg_max_skb_frags

On 27.01.2016 16:15, Eric Dumazet wrote: On Wed, 2016-01-27 at 14:20 +0100, Hans Westgaard Ry wrote: Devices may have limits on the number of fragments in an skb they support. Current codebase uses a constant as maximum for number of fragments one skb can hold and use. When enabling

Re: [PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()

On 27.01.2016 14:45, Paolo Abeni wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 3c8834b..973cb73 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1183,11 +1183,10 @@ static struct rt6_info *ip6_pol_route_output(struct net *net, struct fib6_table return

Re: Has RFC4821 been implemented?

Hi, On 22.01.2016 20:50, Tom Herbert wrote: Found it: tcp_mtu_probing Exactly. On Fri, Jan 22, 2016 at 11:39 AM, Tom Herbert wrote: This came up on in one of the IETF mailing lists in the context that PMTUD doesn't really work on the Internet so PLPMTUD is the way

[PATCH net] pptp: fix illegal memory access caused by multiple bind()s

y.org.uk> Reported-by: Dave Jones <da...@codemonkey.org.uk> Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/ppp/pptp.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/drivers/net/ppp/pptp.c b/drivers

Re: [PATCH net-next] net, sched: add clsact qdisc

Hi Daniel and Alexei, On 07.01.2016 04:53, Alexei Starovoitov wrote: On Wed, Jan 06, 2016 at 02:00:56AM +0100, Daniel Borkmann wrote: I decided to extend the sch_ingress module with clsact functionality so that commonly used code can be reused, the module is being aliased with sch_clsact so

[PATCH net-next 0/2] net: break dependency of drivers on geneve and vxlan

Device drivers which support geneve or vxlan offloading have a dependency on the correlating kernel modules. Thus those drivers automatically loaded the geneve or vxlan modules. Break this dependency with this small series. Hannes Frederic Sowa (2): vxlan: break dependency to network drivers

[PATCH net-next 2/2] geneve: break dependency to network drivers

Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/geneve.c | 30 +++--- include/linux/netdevice.h | 1 + include/net/geneve.h | 7 +++ 3 files changed, 31 insertions(+), 7 deletions(-) diff --git a/drivers/net/gene

[PATCH net-next 1/2] vxlan: break dependency to network drivers

Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/vxlan.c | 17 +++-- include/linux/netdevice.h | 1 + include/net/vxlan.h | 5 + 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/v

Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

On 06.01.2016 19:00, Jesse Gross wrote: On Wed, Jan 6, 2016 at 7:41 AM, Hannes Frederic Sowa <han...@stressinduktion.org> wrote: diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 24b077a32c1c9c..548925d1571cb1 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c +stat

[PATCH net-next v3 2/8] mlx4: add rtnl lock protection in mlx4_en_restart

I don't really understand the use of the state_lock. Can't it be simply replaced by rtnl_lock? It seems a lot of current users depend on rtnl_lock anyway. Anyway, fix this up for the moment. Cc: Eugenia Emantayev <euge...@mellanox.com> Signed-off-by: Hannes Frederic Sow

[PATCH net-next v3 0/8] net: break dependency of drivers on geneve and vxlan

ely NETDEV_REFRESH_OFFLOADS. Otherwise this series is very much the same as v1. Hannes Frederic Sowa (8): qlcnic: protect qlcnic_82xx_io_slot_reset with rtnl lock mlx4: add rtnl lock protection in mlx4_en_restart ixgbe: add rtnl locking in service task around vxlan_get_rx_port benet: add r

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

Hi, On 07.01.2016 00:57, Jesse Gross wrote: On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote: David Miller writes: Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of any size, constrained only by the ability to transmit the

Re: [PATCH net-next v3 8/8] geneve: break dependency to network drivers

Hi Jesse, On 07.01.2016 01:18, Jesse Gross wrote: On Wed, Jan 6, 2016 at 3:39 PM, Hannes Frederic Sowa <han...@stressinduktion.org> wrote: Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/geneve.c | 30 +++--- include/net/g

[PATCH net-next v3 4/8] benet: add rtnl lock protection around be_open in be_resume

Cc: Sathya Perla <sathya.pe...@avagotech.com> Cc: Ajit Khaparde <ajit.khapa...@avagotech.com> Cc: Padmanabh Ratnakar <padmanabh.ratna...@avagotech.com> Cc: Sriharsha Basavapatna <sriharsha.basavapa...@avagotech.com> Signed-off-by: Hannes Frederic Sowa <han...@stressindu

[PATCH net-next v3 1/8] qlcnic: protect qlcnic_82xx_io_slot_reset with rtnl lock

Cc: dept-gelinuxnic...@qlogic.com Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drive

[PATCH net-next v3 5/8] fm10k: add rtnl lock protection in fm10k_io_resume

Cc: Jeff Kirsher <jeffrey.t.kirs...@intel.com> Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet

[PATCH net-next v3 8/8] geneve: break dependency to network drivers

Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/geneve.c | 30 +++--- include/net/geneve.h | 7 +++ 2 files changed, 30 insertions(+), 7 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 24b077a3

[PATCH net-next v3 3/8] ixgbe: add rtnl locking in service task around vxlan_get_rx_port

Protect IXGBE_FLAG2_VXLAN_REREG_NEEDED flag with rtnl_lock as it seems it could be concurrently modified by ixgbe_set_features and ixgbe_del_vxlan_port. Cc: Jeff Kirsher <jeffrey.t.kirs...@intel.com> Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/et

[PATCH net-next v3 7/8] vxlan: break dependency to network drivers

Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/vxlan.c | 17 +++-- include/net/vxlan.h | 5 + 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index fecf7b6c732e96..10f1304d58e1ea

[PATCH net-next v3 6/8] netdev: add netdevice notifier type to trigger a reprogramming of offloads

Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 8d8e5ca951b493..9750e46760695d 100644 --- a/include/linux/netdevice.h +++ b/include

Re: [PATCH v2 net-next] net: Implement fast csum_partial for x86_64

Hi Tom, On 05.01.2016 19:41, Tom Herbert wrote: --- /dev/null +++ b/arch/x86/lib/csum-partial_64.S @@ -0,0 +1,147 @@ +/* Copyright 2016 Tom Herbert + * + * Checksum partial calculation + * + * __wsum csum_partial(const void *buff, int len, __wsum sum) + * + * Computes the

Re: [PATCH net-next] bpf: add skb_postpush_rcsum and fix dev_forward_skb occasions

On 07.01.2016 02:01, Daniel Borkmann wrote: +static inline void skb_postpush_rcsum(struct sk_buff *skb, + const void *start, unsigned int len) +{ + if (skb->ip_summed == CHECKSUM_COMPLETE) + skb->csum = csum_add(skb->csum,

Re: [PATCH v2 net-next] net: Implement fast csum_partial for x86_64

On 07.01.2016 03:36, Tom Herbert wrote: On Wed, Jan 6, 2016 at 5:52 PM, Hannes Frederic Sowa <han...@stressinduktion.org> wrote: Hi Tom, On 05.01.2016 19:41, Tom Herbert wrote: --- /dev/null +++ b/arch/x86/lib/csum-partial_64.S @@ -0,0 +1,147 @@ +/* Copyright 2016 Tom Herb

Re: WARN trace - skb_warn_bad_offload - vxlan - large udp packet - udp checksum disabled

On 15.12.2015 02:35, Nelson, Shannon wrote: Using a slightly modified version of udpspam (see diff below - hopefully not mangled by corporate email servers), where I set the SO_NO_CHECK socket option and can specify a large buffer size, I can reliably get the following WARN trace. I have

[PATCH net-next v2 2/3] vxlan: use netdev_atomic notifier chain to remove dependency from drivers

Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/vxlan.c | 35 ++- include/linux/netdevice.h | 2 +- include/net/vxlan.h | 6 ++ 3 files changed, 33 insertions(+), 10 deletions(-) diff --git a/drivers/net/vxl

[PATCH net-next v2 3/3] geneve: use netdev_atomic notifier chain to remove dependency from drivers

Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/geneve.c | 30 +++--- include/linux/netdevice.h | 1 + include/net/geneve.h | 6 ++ 3 files changed, 30 insertions(+), 7 deletions(-) diff --git a/drivers/net/gene

[PATCH net-next v2 1/3] netdev: add atomic netdev callback chain

This atomic notifier is later used by drivers to deliver callbacks to the core network stack without requireing rtnl lock to be held. Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- include/linux/netdevice.h | 9 + net/core/dev.c

[PATCH net-next v2 0/3] netdev: add netdev atomic callchain to avoid driver depending on vxlan/geneve

:.*(vxlan|geneve)' | wc -l 0 Hannes Frederic Sowa (3): netdev: add atomic netdev callback chain vxlan: use netdev_atomic notifier chain to remove dependency from drivers geneve: use netdev_atomic notifier chain to remove dependency from drivers drivers/net/geneve.c | 30

Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

Hi Jesse, hmpf, I saw your mail too late and send out another series just now. On 06.01.2016 20:52, Jesse Gross wrote: On Wed, Jan 6, 2016 at 10:48 AM, Hannes Frederic Sowa <han...@stressinduktion.org> wrote: On 06.01.2016 19:00, Jesse Gross wrote: On Wed, Jan 6, 2016 at 7:41 AM,

Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

On 06.01.2016 22:01, Jesse Gross wrote: On Wed, Jan 6, 2016 at 12:25 PM, Hannes Frederic Sowa <han...@stressinduktion.org> wrote: The refreshes from each module are completely synchronous and don't get interleaved, so as long as the driver is correctly handling the locking internally rtn

[PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

n <ebied...@xmission.com> Signed-off-by: Eric W. Biederman <ebied...@xmission.com> Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- net/bridge/br_stp_if.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_stp_if.c b/n

Re: [PATCH v2 net-next] net: Implement fast csum_partial for x86_64

Also, Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> Tested with the same test cases as the old patch and showed no problems and same improvements. Tom, did you have a look if it makes sense to add a second carry addition train with the adcx instruction, which does not signa

Re: [PATCH] af_unix: Fix splice-bind deadlock

Hello, On Sun, Jan 3, 2016, at 19:03, Rainer Weikusat wrote: > Rainer Weikusat <r...@doppelsaurus.mobileactivedefense.com> writes: > > > Hannes Frederic Sowa <han...@stressinduktion.org> writes: > >> On 27.12.2015 21:13, Rainer Weikusat wrote: > >>>

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

On 05.01.2016 00:34, Tom Herbert wrote: On Mon, Jan 4, 2016 at 2:36 PM, Eric Dumazet wrote: On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote: \... +402: /* Length 2, align is 1, 3, or 5 */ + movb(%rdi), %al + movb1(%rdi), %ah Looks like a movw

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

nately _addcarry_u64 intrinsics and __int128 for letting the compiler use adc instructions generated even worse code as the current implementation. Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> Thanks Tom! -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] unix: properly account for FDs passed over unix sockets

On 29.12.2015 21:35, Willy Tarreau wrote: On Tue, Dec 29, 2015 at 03:48:45PM +0100, Hannes Frederic Sowa wrote: On 28.12.2015 15:14, Willy Tarreau wrote: It is possible for a process to allocate and accumulate far more FDs than the process' limit by sending them over a unix socket then closing

Re: [PATCH] af_unix: Fix splice-bind deadlock

Hello Rainer, On 27.12.2015 21:13, Rainer Weikusat wrote: -static int unix_mknod(const char *sun_path, umode_t mode, struct path *res) +static int unix_mknod(struct dentry *dentry, struct path *path, umode_t mode, + struct path *res) { - struct dentry *dentry; -

Re: [PATCH] netconsole: Initialize after all core networking drivers

On 29.12.2015 00:21, Cong Wang wrote: On Thu, Dec 24, 2015 at 2:25 AM, Hannes Frederic Sowa <han...@stressinduktion.org> wrote: Hi, On 24.12.2015 00:03, Calvin Owens wrote: This patch addresses the issue cited in 7332a13b038be05c by making vxlan actually check if ipv6 is loaded, and r

Re: [PATCH] unix: properly account for FDs passed over unix sockets

On 28.12.2015 15:14, Willy Tarreau wrote: It is possible for a process to allocate and accumulate far more FDs than the process' limit by sending them over a unix socket then closing them to keep the process' fd count low. This change addresses this problem by keeping track of the number of FDs

Re: [PATCH] unix: properly account for FDs passed over unix sockets

On 28.12.2015 15:14, Willy Tarreau wrote: @@ -1528,10 +1546,8 @@ static int unix_attach_fds(struct scm_cookie *scm, struct sk_buff *skb) if (!UNIXCB(skb).fp) return -ENOMEM; - if (unix_sock_count) { - for (i = scm->fp->count - 1; i >= 0; i--) -

Re: [PATCH] netconsole: Initialize after all core networking drivers

Hi, On 24.12.2015 00:03, Calvin Owens wrote: > On Thursday 12/17 at 17:46 -0800, Calvin Owens wrote: >> On Thursday 12/17 at 17:08 -0800, Eric Dumazet wrote: >>> On Thu, 2015-12-17 at 15:52 -0800, Calvin Owens wrote: With built-in netconsole and IXGBE, configuring netconsole via the kernel

Re: [PATCH net] geneve: initialize needed_headroom

his give a 6% speedup for unsegment traffic on geneve tunnel. > > Signed-off-by: Paolo Abeni <pab...@redhat.com> > Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> (Sorry, just saw this.) > --- > drivers/net/geneve.c | 10 +- > 1 file changed, 9 inserti

[PATCH net] ipv6: honor ifindex in case we receive ll addresses in router advertisements

configuration change. Link: <http://permalink.gmane.org/gmane.linux.network/391348> Reported-by: Marc Haber <mh+net...@zugschlus.de> Cc: Marc Haber <mh+net...@zugschlus.de> Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- net/ipv6/ndisc.c | 4 ++-- 1 fi

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

On 12.12.2015 20:58, Marc Haber wrote: > Any hints would be appreciated. This sysctl should help: accept_ra_from_local - BOOLEAN Accept RA with source-address that is found on local machine if the RA is otherwise proper and able to be accepted. Default is to NOT accept

Re: [PATCH v2 -next 3/3] tcp: honour SO_BINDTODEVICE for TW_RST case too

.210 > F. 1:1(0) ack 1 win 29200 > 0.300 < . 1:1(0) ack 2 win 46 > > // more data while in FIN_WAIT2, expect RST > 1.300 < P. 1:1001(1000) ack 1 win 46 > > // fails without this change -- default route is used > 1.301 > R 1:1(0) win 0 > > Reported-by: Hannes Fre

Re: [RFC PATCH 16/17] calipso: Add validation of CALIPSO option.

On 22.12.2015 17:59, Huw Davies wrote: > On Tue, Dec 22, 2015 at 02:50:20PM +0100, Hannes Frederic Sowa wrote: >> On 22.12.2015 12:46, Huw Davies wrote: >>> >>> +/* CALIPSO RFC 5570 */ >>> + >>> +static bool ipv6_hop_calipso(struct sk_buff *skb, int o

Re: [PATCH -next 2/3] tcp: send_reset: test for non-NULL sk first

k_fullsock(sk)) && hash_location) { > ... > } else { > (sk && sk_fullsock(sk)) tcp_md5_do_lookup() > } > > Switch the two branches: check if we have a socket first, then > fall back to a listener lookup if we saw a md5 option (hash_location). > > Signed-off

Re: [PATCH -next 1/3] net: add inet_sk_transparent() helper

On 21.12.2015 21:29, Florian Westphal wrote: > Avoids cluttering tcp_v4_send_reset when followup patch extends > it to deal with timewait sockets. > > Suggested-by: Eric Dumazet <eduma...@google.com> > Signed-off-by: Florian Westphal <f...@strlen.de> Acked-by

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

Hi Marc, On 22.12.2015 22:28, Marc Haber wrote: > Hi Hannes, > > thanks for your mail. > > On Tue, Dec 22, 2015 at 04:15:14PM +0100, Hannes Frederic Sowa wrote: >> On 12.12.2015 20:58, Marc Haber wrote: >>> Any hints would be appreciated.

Re: [RFC PATCH 08/17] ipv6: Add ipv6_renew_options_kern() that accepts a kernel mem pointer.

On 22.12.2015 12:46, Huw Davies wrote: > The functionality is equivalent to ipv6_renew_options() except > that the newopt pointer is in kernel, not user, memory > > The kernel memory implementation will be used by the CALIPSO network > labelling engine, which needs to be able to set IPv6

Re: [RFC PATCH 16/17] calipso: Add validation of CALIPSO option.

On 22.12.2015 12:46, Huw Davies wrote: > > +/* CALIPSO RFC 5570 */ > + > +static bool ipv6_hop_calipso(struct sk_buff *skb, int optoff) > +{ > + const unsigned char *nh = skb_network_header(skb); > + > + if (nh[optoff + 1] < 8) > + goto drop; > + > + if (nh[optoff + 6] *

Re: [RFC PATCH 13/17] calipso: Allow request sockets to be relabelled by the lsm.

On 22.12.2015 12:46, Huw Davies wrote: > tot_len += sizeof(*opt2); > - opt2 = sock_kmalloc(sk, tot_len, GFP_ATOMIC); > + if (sk) > + opt2 = sock_kmalloc(sk, tot_len, GFP_ATOMIC); > + else > + opt2 = kmalloc(tot_len, GFP_ATOMIC); > if (!opt2) >

Re: net, ipv6: out of bounds access in secret_stable

/ipv6/addrconf.c:5395) > > Looks like we don't initialize the array on stack for write case. > At least other callers always initialize the data for both read > and write. > > Please try the attached patch. Your patch is right. I am surprised you need to initialize the buffer passed

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

Hi all, On 17.12.2015 01:04, David Miller wrote: > From: Hannes Frederic Sowa <han...@stressinduktion.org> > Date: Tue, 15 Dec 2015 21:01:54 +0100 > >> udp tunnel offloads tend to aggregate datagrams based on inner >> headers. gro engine gets notified by tunnel implem

Re: [PATCH] af_unix: Revert 'lock_interruptible' in stream receive code

On 16.12.2015 21:09, Rainer Weikusat wrote: > With b3ca9b02b00704053a38bfe4c31dbbb9c13595d0, the AF_UNIX SOCK_STREAM > receive code was changed from using mutex_lock(>readlock) to > mutex_lock_interruptible(>readlock) to prevent signals from being > delayed for an indefinite time if a thread

Re: [PATCH] af_unix: Revert 'lock_interruptible' in stream receive code

On 17.12.2015 16:28, Rainer Weikusat wrote: > Hannes Frederic Sowa <han...@stressinduktion.org> writes: >> On 16.12.2015 21:09, Rainer Weikusat wrote: >>> With b3ca9b02b00704053a38bfe4c31dbbb9c13595d0, the AF_UNIX SOCK_STREAM >>> receive code was change

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

On 17.12.2015 18:32, Tom Herbert wrote: > On Thu, Dec 17, 2015 at 12:49 AM, Hannes Frederic Sowa > <han...@stressinduktion.org> wrote: >> With user namespaces a normal user can start a new network namespace >> with all privileges and thus add new offloads, letting the

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

On 17.12.2015 21:23, Dan Williams wrote: > On Thu, 2015-12-17 at 15:08 -0500, David Miller wrote: >> From: Dan Williams >> Date: Wed, 16 Dec 2015 11:03:52 -0600 >> >>> On Wed, 2015-12-16 at 17:50 +0800, Xin Long wrote: Add the support for adding expire value to routes,

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

On 17.12.2015 19:10, Tom Herbert wrote: > On Thu, Dec 17, 2015 at 9:40 AM, Hannes Frederic Sowa > <han...@stressinduktion.org> wrote: >> On 17.12.2015 18:32, Tom Herbert wrote: >>> On Thu, Dec 17, 2015 at 12:49 AM, Hannes Frederic Sowa >>> <han...@str

Re: [PATCH net-next] ipv6: addrconf: use stable address generator for ARPHRD_NONE

ode is kept unchanged. If > a known secret is available when the device is created, then the mode > will default to 'stable-privacy' as before. The mode can be manually > set to 'random' but it will behave exactly like 'stable-privacy' in > this case. The secret will not change. > > Cc:

Re: [PATCH iproute2] ipv6: allow setting stable_secret mode

On 16.12.2015 17:56, Bjørn Mork wrote: > > > On December 16, 2015 12:30:08 PM CET, Hannes Frederic Sowa > <han...@stressinduktion.org> wrote: >> Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> >> --- >> ip/iplink.c | 4 +++- >

[PATCH iproute2] ipv6: allow setting stable_secret mode

Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- ip/iplink.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ip/iplink.c b/ip/iplink.c index f30de86d1858a0..e824082f7d8149 100644 --- a/ip/iplink.c +++ b/ip/iplink.c @@ -84,7 +84,7 @@ void iplink

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

ed-off-by: Xin Long <lucien....@gmail.com> Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> Thanks, Xin Long! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH net-next] ipv6: add IPV6_HDRINCL option for raw sockets

Same as in Windows, we miss IPV6_HDRINCL for SOL_IPV6 and SOL_RAW. The SOL_IP/IP_HDRINCL is not available for IPv6 sockets. Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- include/uapi/linux/in6.h | 1 + net/ipv6/raw.c | 20 2 files c

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

On 15.12.2015 23:39, Tom Herbert wrote: > On Tue, Dec 15, 2015 at 12:46 PM, Hannes Frederic Sowa > <han...@stressinduktion.org> wrote: >> On 15.12.2015 21:26, Tom Herbert wrote: >>> On Tue, Dec 15, 2015 at 12:01 PM, Hannes Frederic Sowa >>> <han...@stre

[PATCH iproute2] iproute: print addrgenmode stable_secret and fallback otherwise

Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- ip/ipaddress.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index bc8359eb9fad6c..a495a391a0ecdb 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@ -285,13 +

[PATCH net 2/2] udp: restrict offloads to one namespace

space socket is bound to the same address it will conflict. Cc: Tom Herbert <t...@herbertland.com> Cc: Eric Dumazet <eduma...@google.com> Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- drivers/net/geneve.c | 2 +- drivers/net/vxlan.c| 2 +- incl

[PATCH net 1/2] fou: clean up socket with kfree_rcu

eve. Fixes: 23461551c00628c ("fou: Support for foo-over-udp RX path") Cc: Tom Herbert <t...@herbertland.com> Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> --- net/ipv4/fou.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/fou

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

On 15.12.2015 21:26, Tom Herbert wrote: > On Tue, Dec 15, 2015 at 12:01 PM, Hannes Frederic Sowa > <han...@stressinduktion.org> wrote: >> udp tunnel offloads tend to aggregate datagrams based on inner >> headers. gro engine gets notified by tunnel implementations ab

<    1   2   3   4   5   6   7   8   9   >