Re: [PATCH bpf-next 00/17] Improve BPF syscall command documentation

2021-02-18 Thread Jonathan Corbet
Joe Stringer writes: > Hey Jon, thanks for the feedback. Absolutely, what you say makes > sense. The intent here wasn't to come up with something new. Based on > your prompt from this email (and a quick look at your KR '19 > presentation), I'm hearing a few observations: > * Storing the documenta

Re: [PATCH bpf-next 00/17] Improve BPF syscall command documentation

2021-02-17 Thread Jonathan Corbet
[CC += linux-doc] Joe Stringer writes: > From: Joe Stringer > > The state of bpf(2) manual pages today is not exactly ideal. For the > most part, it was written several years ago and has not kept up with the > pace of development in the kernel tree. For instance, out of a total of > ~35 command

Re: [PATCH v6 00/16] Fix several bad kernel-doc markups

2021-01-21 Thread Jonathan Corbet
On Thu, 14 Jan 2021 09:04:36 +0100 Mauro Carvalho Chehab wrote: > 1) 10 remaining fixup patches from the series I sent back on Dec, 1st: > >parport: fix a kernel-doc markup >rapidio: fix kernel-doc a markup >fs: fix kernel-doc markups >pstore/zone: fix a kernel-doc markup >f

Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-19 Thread Jonathan Corbet
On Tue, 19 Jan 2021 13:07:53 +0800 Xie Yongji wrote: > diff --git a/Documentation/driver-api/vduse.rst > b/Documentation/driver-api/vduse.rst > new file mode 100644 > index ..9418a7f6646b > --- /dev/null > +++ b/Documentation/driver-api/vduse.rst > @@ -0,0 +1,85 @@ > +===

Re: [PATCH 0/3] Fix Kernel-doc warnings introduced on next-20200921

2020-09-22 Thread Jonathan Corbet
On Tue, 22 Sep 2020 20:52:06 +0300 Ville Syrjälä wrote: > Mea culpa. My doc test build was foiled by the sphinx 2 vs. 3 > regression and I was too lazy to start downgrading things. > Any ETA for getting that fixed btw? There's a fix of sorts in docs-next (and thus linux-next) now, has been there

Re: [PATCH] docs: bpf/ringbuf.rst: fix reference to nonexistent document

2020-07-23 Thread Jonathan Corbet
On Sat, 18 Jul 2020 13:51:01 -0300 "Daniel W. S. Almeida" wrote: > Fix the following warnings: > > ringbuf.rst:197: WARNING: Unknown target name: "bench_ringbuf.c" > > There was no target defined for 'bench_ringbuf.c'. Also, the > syntax used was wrong, in the sense that it would not highlight

Re: [PATCH] docs: core-api/printk-formats.rst: use literal block syntax

2020-07-23 Thread Jonathan Corbet
On Sat, 18 Jul 2020 13:51:02 -0300 "Daniel W. S. Almeida" wrote: > Fix the following warning: > > WARNING: Definition list ends without a blank line; > unexpected unindent. > > By switching to the literal block syntax. > > Signed-off-by: Daniel W. S. Almeida > --- > Documentation/core-api/pr

Re: [PATCH] docs: bpf/bpf_devel_QA.rst: fix reference to nonexistent document

2020-07-23 Thread Jonathan Corbet
On Sat, 18 Jul 2020 13:51:00 -0300 "Daniel W. S. Almeida" wrote: > Fix the following sphinx warning: > > bpf_devel_QA.rst:444: WARNING: Unknown target name: > "documentation/bpf/btf.rst" > > No target was defined for 'btf.rst' in the document. Fix it. > > Signed-off-by: Daniel W. S. Almeida >

Re: [PATCH] docs: bpf/index.rst: Add ringbuf.rst

2020-07-23 Thread Jonathan Corbet
On Sat, 18 Jul 2020 13:51:04 -0300 "Daniel W. S. Almeida" wrote: > From: Daniel W. S. Almeida > > Fix the following warning > > Documentation/bpf/ringbuf.rst: WARNING: document isn't > included in any toctree > > By adding it to the index. > > Signed-off-by: Daniel W. S. Almeida > --- > Do

Re: [PATCH] docs: index.rst: Add watch_queue

2020-07-23 Thread Jonathan Corbet
On Sat, 18 Jul 2020 13:51:07 -0300 "Daniel W. S. Almeida" wrote: > From: "Daniel W. S. Almeida" > > Fix the following sphinx warning: > > Documentation/watch_queue.rst: > WARNING: document isn't included in any toctree > > By adding watch_queue.rst to the index. > > Signed-off-by: Daniel W.

Re: [PATCH] docs: core-api/printk-formats.rst: use literal block syntax

2020-07-21 Thread Jonathan Corbet
On Tue, 21 Jul 2020 23:02:46 +0900 Sergey Senozhatsky wrote: > Jonathan, will you route it via the Documentation tree or do > you want it to land in the printk tree? I'm happy either way. I'll grab it unless you tell me you'd rather pick it up. Thanks, jon

Re: [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones

2020-07-20 Thread Jonathan Corbet
On Mon, 20 Jul 2020 17:07:16 +0300 Leon Romanovsky wrote: > > Do *you* want to review that megapatch? The number of issues that have > > come up make it clear that these patches do, indeed, need review... > > Can you point me to the issues? > What can go wrong with such a simple replacement?

Re: [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones

2020-07-20 Thread Jonathan Corbet
On Mon, 20 Jul 2020 07:56:26 +0300 Leon Romanovsky wrote: > > Documentation/networking/rds.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Why can't it be done in one mega-patch? > It is insane to see patch for every file/link. > > We have more than 4k files with http:// in

Re: [PATCH] Replace HTTP links with HTTPS ones: XDP (eXpress Data Path)

2020-07-08 Thread Jonathan Corbet
On Wed, 8 Jul 2020 15:57:37 +0200 "Alexander A. Klimov" wrote: > Documentation/arm/ixp4xx.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) That's not XDP; something went awry in there somewhere. jon

Re: linux-next: manual merge of the jc_docs tree with the vfs and net-next trees

2020-05-18 Thread Jonathan Corbet
On Mon, 18 May 2020 12:30:13 +1000 Stephen Rothwell wrote: > Today's linux-next merge of the jc_docs tree got a conflict in: > > kernel/sysctl.c > > between commit: > > f461d2dcd511 ("sysctl: avoid forward declarations") > > from the vfs tree and commit: > > 2f4c33063ad7 ("docs: sysctl

Re: [PATCH 07/14] docs: add IRQ documentation at the core-api book

2020-05-15 Thread Jonathan Corbet
On Fri, 1 May 2020 17:37:51 +0200 Mauro Carvalho Chehab wrote: > There are 4 IRQ documentation files under Documentation/*.txt. > > Move them into a new directory (core-api/irq) and add a new > index file for it. > > While here, use a title markup for the Debugging section of the > irq-domain.

Re: [PATCH 00/38] net: manually convert files to ReST format - part 1

2020-04-28 Thread Jonathan Corbet
On Tue, 28 Apr 2020 13:11:43 -0700 (PDT) David Miller wrote: > Jon, do you mind if I merge this via the networking tree? Not at all, that's what I was expecting you would do. Thanks, jon

Re: [PATCH net-next 1/2] UDP tunnel encapsulation module for tunnelling different protocols like MPLS,IP,NSH etc.

2019-10-08 Thread Jonathan Corbet
On Tue, 8 Oct 2019 15:18:53 +0530 Martin Varghese wrote: > diff --git a/Documentation/networking/bareudp.txt > b/Documentation/networking/bareudp.txt > new file mode 100644 > index 000..d2530e2 > --- /dev/null > +++ b/Documentation/networking/bareudp.txt > @@ -0,0 +1,23 @@ > +Bare UDP Tunne

Re: [PATCH 0/2] doc: net: ieee802154: move from plain text to rst

2019-02-27 Thread Jonathan Corbet
On Wed, 27 Feb 2019 20:59:12 +0100 Stefan Schmidt wrote: > The patches are based on net-next, but they only touch the networking book so > I > would not expect and trouble. From what I have seen they would go through > Jonathan's tree after being acked by Dave? If you want this patches against a

Re: [PATCH] stable-kernel-rules.rst: add link to networking patch queue

2019-02-01 Thread Jonathan Corbet
On Tue, 22 Jan 2019 19:46:32 +0100 Greg Kroah-Hartman wrote: > The networking maintainer keeps a public list of the patches being > queued up for the next round of stable releases. Be sure to check there > before asking for a patch to be applied so that you do not waste > people's time. > > Sig

Re: [PATCH v2 1/1] doc: networking: integrate scaling document into doc tree

2019-01-21 Thread Jonathan Corbet
On Fri, 18 Jan 2019 21:38:32 +0100 Otto Sabart wrote: > Convert scaling document into reStructuredText and add reference to > scaling document into main table of contents in network documentation. > > There are no semantic changes. > > There are no references to "scaling.txt" file. Whole kernel

Re: [PATCH v5] coding-style: Clarify the expectations around bool

2019-01-21 Thread Jonathan Corbet
On Fri, 18 Jan 2019 15:50:47 -0700 Jason Gunthorpe wrote: > There has been some confusion since checkpatch started warning about bool > use in structures, and people have been avoiding using it. > > Many people feel there is still a legitimate place for bool in structures, > so provide some guid

Re: [PATCH 1/3] doc: networking: prepare scaling document for conversion into RST

2019-01-16 Thread Jonathan Corbet
On Wed, 9 Jan 2019 20:57:22 +0100 Otto Sabart wrote: > Add markups which are necessary for successful conversion into > reStructuredText. > > There are no semantic changes. > > Signed-off-by: Otto Sabart This seems generally good, except: > Documentation/networking/scaling.txt | 131 +++

Re: [PATCH v2 0/4] doc: network: integrate offload documents into doc tree

2019-01-07 Thread Jonathan Corbet
On Mon, 07 Jan 2019 07:30:29 -0800 (PST) David Miller wrote: > Jon, do you want to integrate these? I'm fine with that and I don't > anticiapte > any serious conflicts. I'll do that shortly, thanks. jon

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread Jonathan Corbet
On Fri, 30 Nov 2018 14:12:19 -0800 Jarkko Sakkinen wrote: > As a maintainer myself (and based on somewhat disturbed feedback from > other maintainers) I can only make the conclusion that nobody knows what > the responsibility part here means. > > I would interpret, if I read it like at lawyer at

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread Jonathan Corbet
On Fri, 30 Nov 2018 12:55:21 -0800 Jarkko Sakkinen wrote: > This a direct quote from the CoC: > > "Harassment includes the use of abusive, offensive or degrading > language, intimidation, stalking, harassing photography or recording, > inappropriate physical contact, sexual imagery and unwelcome

Re: [PATCH] Documentation: Add HOWTO Korean translation into BPF and XDP Reference Guide.

2018-09-26 Thread Jonathan Corbet
On Wed, 26 Sep 2018 18:11:42 +0900 Chang-an Song wrote: > > - The original document has a copyright assertion but no associated > >license. Do we know what the license is? I assume it's something > >that is free and GPL-compatible, but that would be good to know for > >sure. > >

Re: [PATCH] Documentation: Add HOWTO Korean translation into BPF and XDP Reference Guide.

2018-09-24 Thread Jonathan Corbet
On Fri, 21 Sep 2018 13:22:38 +0900 Changan Song wrote: > Signed-off-by: Changan Song > --- > Documentation/translations/ko_KR/bpf-xdp.txt | 3511 ++ > 1 file changed, 3511 insertions(+) > create mode 100644 Documentation/translations/ko_KR/bpf-xdp.txt I can't judge the quality

Re: [PATCH net-next 0/2] docs: net: Convert netdev-FAQ to RST

2018-07-25 Thread Jonathan Corbet
On Wed, 25 Jul 2018 13:28:10 +1000 "Tobin C. Harding" wrote: > Since I've already botched it can I ask for guidance here. The problem > is updating the links means making changes that will cause merge > conflicts if they go through net-dev tree (since most references are in > Documentation/*.rst

Re: [PATCH net-next 4/5] tcp: implement mmap() for zero copy receive

2018-04-20 Thread Jonathan Corbet
On Thu, 19 Apr 2018 18:01:32 -0700 Eric Dumazet wrote: > We can keep mmap() nice interface, granted we can add one hook like in > following patch. > > David, do you think such patch would be acceptable by lkml and mm/fs > maintainers ? > > Alternative would be implementing an ioctl() or getso

[PATCH net-next] MAINTAINERS: Direct networking documentation changes to netdev

2018-04-18 Thread Jonathan Corbet
Networking docs changes go through the networking tree, so patch the MAINTAINERS file to direct authors to the right place. Signed-off-by: Jonathan Corbet --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0a1410d5a621..bf4be491d4d9 100644 --- a

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-03-29 Thread Jonathan Corbet
On Thu, 29 Mar 2018 05:01:32 -0400 Richard Guy Briggs wrote: > > A little detail, but still... > > I am understanding that you would prefer more context (as opposed to > operational detail) in the description, laying out the use case for this > patch(set)? No, sorry, "a little detail" was ref

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-03-28 Thread Jonathan Corbet
On Fri, 16 Mar 2018 05:00:28 -0400 Richard Guy Briggs wrote: > Implement the proc fs write to set the audit container ID of a process, > emitting an AUDIT_CONTAINER record to document the event. A little detail, but still... > +static int audit_set_containerid_perm(struct task_struct *task, u64

Re: [PATCH] docs-rst: networking: wire up msg_zerocopy

2018-01-09 Thread Jonathan Corbet
On Tue, 09 Jan 2018 11:50:49 -0500 (EST) David Miller wrote: > From: Mike Rapoport > Date: Mon, 8 Jan 2018 08:50:17 +0200 > > > Fix the following 'make htmldocs' complaint: > > > > Documentation/networking/msg_zerocopy.rst:: WARNING: document isn't > > included in any toctree. > > > > Signe

Re: [PATCH 02/18] Documentation: document nospec helpers

2018-01-08 Thread Jonathan Corbet
On Mon, 8 Jan 2018 17:09:59 + Mark Rutland wrote: > > I have just a couple of overall comments. > > > > - It would be nice if the document were done in RST and placed in the > >core-API manual, perhaps using kerneldoc comments for the macros > >themselves. It's already 99.9% RST no

Re: [PATCH 02/18] Documentation: document nospec helpers

2018-01-08 Thread Jonathan Corbet
On Fri, 05 Jan 2018 17:10:03 -0800 Dan Williams wrote: > Document the rationale and usage of the new nospec*() helpers. I have just a couple of overall comments. - It would be nice if the document were done in RST and placed in the core-API manual, perhaps using kerneldoc comments for the m

Re: [PATCH v7 1/5] add infrastructure for tagging functions as error injectable

2017-11-28 Thread Jonathan Corbet
On Wed, 22 Nov 2017 16:23:30 -0500 Josef Bacik wrote: > From: Josef Bacik > > Using BPF we can override kprob'ed functions and return arbitrary > values. Obviously this can be a bit unsafe, so make this feature opt-in > for functions. Simply tag a function with KPROBE_ERROR_INJECT_SYMBOL in >

Re: [PATCH] New Chapter on CodingStyle .

2017-08-12 Thread Jonathan Corbet
On Sat, 12 Aug 2017 14:23:18 +0300 Corcodel Marian wrote: > --- > Documentation/CodingStyle | 28 > 1 file changed, 28 insertions(+) > > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle > index 9a70ddd..864dd8b 100644 > --- a/Documentation/CodingSt

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-06-01 Thread Jonathan Corbet
On Thu, 01 Jun 2017 09:05:07 +0800 Jia-Ju Bai wrote: > I admit my patches are not well tested, and they may not well fix the bugs. > I am looking forward to opinions and suggestions :) May I politely suggest that sending out untested locking changes is a dangerous thing to do? You really should

Re: [net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

2017-02-07 Thread Jonathan Corbet
On Tue, 7 Feb 2017 21:51:49 +0100 Jesper Dangaard Brouer wrote: > I sounds like Daniel (see other email) have bigger plans for what > Documentation/BPF/ should contain. E.g. consolidating > Documentation/networking/filter.txt which covers the cBPF/eBPF internals. > If that is the case (and I lik

Re: [net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

2017-02-07 Thread Jonathan Corbet
On Tue, 7 Feb 2017 17:09:08 +0100 Jesper Dangaard Brouer wrote: > > > Question: What kernel tree should this go into??? > > > > > > If going through Jonathan Corbet, will it appear sooner here??? > > > https://www.kernel.org/doc/html/latest/ > > W

Re: [net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

2017-02-07 Thread Jonathan Corbet
On Tue, 07 Feb 2017 15:30:11 +0100 Jesper Dangaard Brouer wrote: > Question: What kernel tree should this go into??? > > If going through Jonathan Corbet, will it appear sooner here??? > https://www.kernel.org/doc/html/latest/ > If it will not appear sooner that way, then it&#

Re: [PATCH v9 7/8] thunderbolt: Networking doc

2016-11-10 Thread Jonathan Corbet
On Wed, 9 Nov 2016 17:00:02 +0100 Greg KH wrote: > > Documentation/00-INDEX | 2 + > > Documentation/thunderbolt/networking.txt | 132 > > +++ > > Note, new files should be in .rst format, and live in the new > subdirectory for them (somewhere i

Re: [PATCH v2 0/6] Move runnable code (tests) from Documentation to selftests

2016-09-14 Thread Jonathan Corbet
On Tue, 13 Sep 2016 14:18:39 -0600 Shuah Khan wrote: > Move runnable code (tests) from Documentation to selftests and update > Makefiles to work under selftests. This all seems good to me. Acked-by: Jonathan Corbet jon

Re: [PATCH 0/9] Move runnable code (tests) from Documentation to selftests

2016-09-10 Thread Jonathan Corbet
On Fri, 9 Sep 2016 16:22:41 -0600 Shuah Khan wrote: > Move runnable code (tests) from Documentation to selftests and update > Makefiles to work under selftests. > > Jon Corbet and I discussed this in an email thread and as per that > discussion, this patch series moves all the tests that are un

Re: possible patch

2016-02-10 Thread Jonathan Corbet
On Wed, 10 Feb 2016 19:49:11 -0500 Justin Keller wrote: > I am new to submitting patches, so sorry if I am doing it wrong. My idea was > to change line 147 in drivers/isdn/pcbit/callbacks.c from > if (cbdata->data.setup.CallingPN == NULL) { > > to > > if (cbdata->data.setup.CallingPN == NULL ||

Re: [PATCH RESEND] net: Documentation: Fix default value tcp_limit_output_bytes

2015-11-11 Thread Jonathan Corbet
On Wed, 11 Nov 2015 11:57:24 -0500 (EST) David Miller wrote: > > I left this last time because Dave usually likes to pick up networking > > docs patches himself. This wasn't sent to netdev, though, so that's > > unlikely to happen. I've gone ahead and applied it, since it seems > > clearly corr

Re: [PATCH RESEND] net: Documentation: Fix default value tcp_limit_output_bytes

2015-11-11 Thread Jonathan Corbet
On Mon, 9 Nov 2015 14:58:49 +0100 Niklas Cassel wrote: > Commit c39c4c6abb89 ("tcp: double default TSQ output bytes limit") > updated default value for tcp_limit_output_bytes I left this last time because Dave usually likes to pick up networking docs patches himself. This wasn't sent to netdev,

Re: make mandocs build failure with next-20150407

2015-04-16 Thread Jonathan Corbet
On Thu, 16 Apr 2015 08:33:15 +0900 Masanari Iida wrote: > On Wed, Apr 8, 2015 at 7:41 AM, Jim Davis wrote: > > DOCPROC Documentation/DocBook/80211.xml > > Error(.//include/net/mac80211.h:329): Cannot parse enum! > > Error(.//include/net/mac80211.h:367): Cannot parse enum! > > Warning(.//includ

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Jonathan Corbet
Rusty said: > Well, introduce an EXPORT_SYMBOL_INTERNAL(). It's a lot less code. But > you'd > still need to show that people are having trouble knowing what APIs to use. Might the recent discussion on the exporting of sys_open() and sys_read() be an example here? There would appear to be a

Re: Van Jacobson net channels

2006-02-01 Thread Jonathan Corbet
Andi writes: > But I don't think Van's design is supposed to be exposed to user space. > It's just a better way to implement BSD sockets. Actually, it can, indeed, go all the way to user space - connecting channels to the socket layer was one of the intermediate steps. FWIW, I did an article on

Re: doubt in DMAing

2005-12-14 Thread Jonathan Corbet
> can any1 point me to a good linux memory management stuff. Actually i > want to know the conversion of virtual to physical address and when u > need to do it. The DMA chapter of LDD3 covers this topic in detail: http://lwn.net/Kernel/LDD3/ jon Jonathan Corbet Executi