Hardware should not aggregate any packets when generic XDP is installed.
Cc: Ariel Elior
Cc: everest-linux...@cavium.com
Signed-off-by: Michael Chan
---
net/core/dev.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index bf0149e..5e47779
On Sun, Dec 10, 2017 at 9:02 AM, Alexander Duyck
wrote:
> On Sat, Dec 9, 2017 at 10:40 PM, Michael Chan
> wrote:
>> It is possible that if you have incoming packets 1, 2, 3, 4, 5 for a
>> TCP connection, HW_GRO can aggregate packets 1, 2, 3, but cannot
>> aggregat
On Sat, Dec 9, 2017 at 2:37 PM, Alexander Duyck
wrote:
> On Sat, Dec 9, 2017 at 1:40 PM, Michael Chan
> wrote:
>> On Sat, Dec 9, 2017 at 10:56 AM, Alexander Duyck
>> wrote:
>>> I think these two lines are redundant in dev_disable_lro, since
>>> netdev_
On Sat, Dec 9, 2017 at 2:04 PM, Alexander Duyck
wrote:
> On Sat, Dec 9, 2017 at 1:31 PM, Michael Chan
> wrote:
>> On Sat, Dec 9, 2017 at 10:50 AM, Alexander Duyck
>> wrote:
>>> So I would disagree with it being a subset of NETIF_F_GRO. If anything
>>> it is
On Sat, Dec 9, 2017 at 10:56 AM, Alexander Duyck
wrote:
> On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan
> wrote:
>> Hardware should not aggregate any packets when generic XDP is installed.
>>
>> Cc: Ariel Elior
>> Cc: everest-linux...@cavium.com
>> Signed-
On Sat, Dec 9, 2017 at 10:50 AM, Alexander Duyck
wrote:
> On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan
> wrote:
>> Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware
>> GRO. With this flag, we can now independently turn on or off hardware
>> GRO whe
NETIF_F_GRO_HW in features flag.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index
follow suit since it is a subset of GRO. In other
words, a lower device can independent have GRO/GRO_HW enabled or disabled
and no feature propagation is required. This will preserve the current
GRO behavior.
Cc: Ariel Elior
Cc: everest-linux...@cavium.com
Signed-off-by: Michael Chan
upper and lower devices not
required (see patch 1).
- NETIF_F_GRO_HW depends on NETIF_F_GRO and NETIF_F_RXCSUM.
- Add dev_disable_gro_hw() to disable GRO_HW for generic XDP.
- Use ndo_fix_features() on all 3 drivers to drop GRO_HW when it is not
supported
Michael Chan (5):
net: Introduce NETIF_F_G
Hardware should not aggregate any packets when generic XDP is installed.
Cc: Ariel Elior
Cc: everest-linux...@cavium.com
Signed-off-by: Michael Chan
---
net/core/dev.c | 24
1 file changed, 24 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 6ebd0e7
...@cavium.com
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 19 ---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 4 +++-
2 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
b/drivers
nux...@cavium.com
Acked-by: Manish Chopra
Signed-off-by: Michael Chan
---
drivers/net/ethernet/qlogic/qede/qede.h | 2 ++
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 3 +++
drivers/net/ethernet/qlogic/qede/qede_filter.c | 20 +---
drivers/net/ethernet/qlogic/q
On Fri, Dec 8, 2017 at 2:09 PM, Marcelo Ricardo Leitner
wrote:
> Hi,
>
> On Thu, Dec 07, 2017 at 03:03:35AM -0500, Michael Chan wrote:
>> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> @@ -940,6 +9
_workq_function+0x3c/0x90 [edac_core]
>[] process_one_work+0x19b/0x480
>[] worker_thread+0x6a/0x520
>[] kthread+0xe4/0x100
>[] ret_from_fork+0x22/0x40
>
> This happens because we increment rx_pkts on -ENOMEM and -EIO, resulting
> in rx_pkts > 0. Fix this by on
On Thu, Dec 7, 2017 at 6:36 PM, Alexander Duyck
wrote:
> On Thu, Dec 7, 2017 at 4:05 PM, Michael Chan
> wrote:
>> I see. But this won't happen. Because the bonding driver is not
>> advertising NETIF_F_GRO_HW in its hw_features. It is not advertising
>> NETIF_F_G
On Thu, Dec 7, 2017 at 3:35 PM, Alexander Duyck
wrote:
> On Thu, Dec 7, 2017 at 3:17 PM, Michael Chan
> wrote:
>> I don't get this. I don't see how TSO is related.
>
> It isn't. That is the point. If I change ANY feature it will trigger
> fix_features to
On Thu, Dec 7, 2017 at 2:43 PM, Alexander Duyck
wrote:
> On Thu, Dec 7, 2017 at 2:08 PM, Michael Chan
> wrote:
>> On the bond, you can have LRO enabled and it is propagated to lower
>> devices so that lower devices will enable LRO if it is supported. If
>> LRO is disabl
On Thu, Dec 7, 2017 at 1:35 PM, Alexander Duyck
wrote:
> On Thu, Dec 7, 2017 at 10:44 AM, Michael Chan
> wrote:
>> On Thu, Dec 7, 2017 at 10:13 AM, Alexander Duyck
>> wrote:
>>> On Thu, Dec 7, 2017 at 12:03 AM, Michael Chan
>>> wrote:
>>>>
On Thu, Dec 7, 2017 at 10:13 AM, Alexander Duyck
wrote:
> On Thu, Dec 7, 2017 at 12:03 AM, Michael Chan
> wrote:
>> @@ -7405,6 +7405,23 @@ static netdev_features_t netdev_fix_features(struct
>> net_device *dev,
>> features &
On Thu, Dec 7, 2017 at 1:39 AM, Thomas Bogendoerfer
wrote:
> On Thu, 7 Dec 2017 01:24:43 -0800
> Michael Chan wrote:
>
>> On Thu, Dec 7, 2017 at 1:14 AM, Thomas Bogendoerfer
>> wrote:
>> > well, it will print the forced rate, if there is one configured and -1
&g
On Thu, Dec 7, 2017 at 1:14 AM, Thomas Bogendoerfer
wrote:
> On Wed, 6 Dec 2017 11:27:31 -0800
> Michael Chan wrote:
>
>> On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer
>> wrote:
>> > bnxt driver spams logfiles with
>> >
>> > [ 541.003
disable GRO_HW for generic XDP.
- Use ndo_fix_features() on all 3 drivers to drop GRO_HW when it is not
supported
Michael Chan (5):
net: Introduce NETIF_F_GRO_HW.
net: Disable GRO_HW when generic XDP is installed on a device.
bnxt_en: Use NETIF_F_GRO_HW.
bnx2x: Use NETIF_F_GRO_HW.
qede: Use
...@cavium.com
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 17 ++---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 4 +++-
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
b/drivers
subset of GRO. In other
words, a lower device can independent have GRO/GRO_HW enabled or disabled
and no feature propagation is required. This will preserve the current
GRO behavior.
Cc: Ariel Elior
Cc: everest-linux...@cavium.com
Signed-off-by: Michael Chan
---
Documentation/networking/netdev
nux...@cavium.com
Signed-off-by: Michael Chan
---
drivers/net/ethernet/qlogic/qede/qede.h | 2 ++
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 3 +++
drivers/net/ethernet/qlogic/qede/qede_filter.c | 20 +---
drivers/net/ethernet/qlogic/qede/qede_main.c|
NETIF_F_GRO_HW in features flag.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index
Hardware should not aggregate any packets when generic XDP is installed.
Cc: Ariel Elior
Cc: everest-linux...@cavium.com
Signed-off-by: Michael Chan
---
net/core/dev.c | 24
1 file changed, 24 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 7242e5e
nting it if
we can determine the link speed that is no longer supported. If the
speed is unknown or it is in autoneg mode, skip the warning message.
Reported-by: Thomas Bogendoerfer
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +++---
1 file changed, 7 inser
On Tue, Dec 5, 2017 at 10:10 AM, Marcelo Ricardo Leitner
wrote:
> On Mon, Dec 04, 2017 at 04:07:15PM -0800, Michael Chan wrote:
>> As already pointed out, GRO_HW is a subset of GRO. Packets that
>> cannot be aggregated in hardware (due to hardware resource limitations
>> o
On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer
wrote:
> bnxt driver spams logfiles with
>
> [ 541.003065] bnxt_en :5d:00.1 eth5: Link speed -1 no longer supported
>
> if a direct attached cable (DAC) is plugged into the bnxt card and is
> unplugged on the other side. This patch removes t
can just remove
> the check.
>
> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap
> offload")
> Signed-off-by: Dan Carpenter
Thanks.
Acked-by: Michael Chan
On Tue, Dec 5, 2017 at 4:32 AM, Chopra, Manish wrote:
>
> Since we are now differentiating HW gro with distinct feature bit, I think we
> should consider this feature bit everywhere where driver disables
> HW gro internally [not explicitly using ethtool]. This is not just specific
> to XDP but
On Mon, Dec 4, 2017 at 2:00 PM, Eric Dumazet wrote:
> On Mon, 2017-12-04 at 23:06 +0200, Or Gerlitz wrote:
>> On Mon, Dec 4, 2017 at 8:11 PM, Michael Chan > om> wrote:
>>
>> > All the logic is already in these 3 drivers in the tree. You can
>> > see
&g
On Mon, Dec 4, 2017 at 12:58 PM, Alexander Duyck
wrote:
> On Mon, Dec 4, 2017 at 11:52 AM, Michael Chan
> wrote:
>> NETIF_F_GRO_HW is a flag that depends on NETIF_F_GRO. In some ways,
>> it is similar to a private flag that depends on NETIF_F_LRO. But I
>> think a
On Mon, Dec 4, 2017 at 1:48 PM, Yuval Mintz wrote:
>> Advertise NETIF_F_GRO_HW and turn on or off hardware GRO based on
>> NETIF_F_GRO_FW flag.
>>
>> Cc: Ariel Elior
>> Cc: everest-linux...@cavium.com
>> Signed-off-by: Michael Chan
>> ---
>> dr
On Mon, Dec 4, 2017 at 2:15 PM, Yuval Mintz wrote:
>> @@ -96,6 +98,7 @@ enum {
>> #define NETIF_F_FRAGLIST __NETIF_F(FRAGLIST)
>> #define NETIF_F_FSO __NETIF_F(FSO)
>> #define NETIF_F_GRO __NETIF_F(GRO)
>> +#define NETIF_F_GRO_HW __NETIF_F(GRO_HW)
>> #define
On Mon, Dec 4, 2017 at 10:43 AM, Alexander Duyck
wrote:
> On Mon, Dec 4, 2017 at 10:23 AM, Michael Chan
> wrote:
>> On Mon, Dec 4, 2017 at 8:47 AM, Alexander Duyck
>> wrote:
>>> On Mon, Dec 4, 2017 at 3:12 AM, Michael Chan
>>> wrote:
>>>> Int
On Mon, Dec 4, 2017 at 8:47 AM, Alexander Duyck
wrote:
> On Mon, Dec 4, 2017 at 3:12 AM, Michael Chan
> wrote:
>> Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware
>> GRO. With this flag, we can now independently turn on or off hardware
>> GRO when
On Mon, Dec 4, 2017 at 8:35 AM, Or Gerlitz wrote:
> On Mon, Dec 4, 2017 at 1:12 PM, Michael Chan
> wrote:
>> Advertise NETIF_F_GRO_HW if hardware GRO is supported. Turn on or off
>> hardware GRO based on NETIF_F_GRO_HW.
>
> So the patch only deals with advertisement bi
: everest-linux...@cavium.com
Signed-off-by: Michael Chan
---
Documentation/networking/netdev-features.txt | 7 +++
include/linux/netdev_features.h | 5 -
net/core/dev.c | 13 +
net/core/ethtool.c | 1 +
4 files
Advertise NETIF_F_GRO_HW and turn on or off hardware GRO based on
NETIF_F_GRO_FW flag.
Cc: Ariel Elior
Cc: everest-linux...@cavium.com
Signed-off-by: Michael Chan
---
drivers/net/ethernet/qlogic/qede/qede_filter.c | 9 ++---
drivers/net/ethernet/qlogic/qede/qede_main.c | 4 ++--
2 files
Introduce NETIF_F_GRO_HW feature flag and convert drivers that support
hardware GRO to use the flag.
Michael Chan (4):
net: Introduce NETIF_F_GRO_HW
bnxt_en: Use NETIF_F_GRO_HW.
bnx2x: Use NETIF_F_GRO_HW.
qede: Use NETIF_F_GRO_HW.
Documentation/networking/netdev-features.txt | 7
Advertise NETIF_F_GRO_HW and turn on TPA_MODE_GRO when NETIF_F_GRO_HW
is set.
Cc: Ariel Elior
Cc: everest-linux...@cavium.com
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 10 +++---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 4 +++-
2 files
Advertise NETIF_F_GRO_HW if hardware GRO is supported. Turn on or off
hardware GRO based on NETIF_F_GRO_HW.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt
wrm FW cmds for cfa_encap_record and
decap_filter")
Signed-off-by: Sunil Challa
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
b/drivers/net/et
that have a vxlan decap action, the
fid of the incoming PF interface must be used as the src_fid in
the hwrm_cfa_decap_filter_alloc cmd.
Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap
offload")
Signed-off-by: Sathya Perla
Signed-off-by: Michael Chan
---
d
A shutdown fix for SMARTNIC, 2 fixes related to TC Flower vxlan
filters, and the last one fixes an out-of-scope variable when sending
short firmware messages.
Ray Jui (1):
bnxt_en: Need to unconditionally shut down RoCE in bnxt_shutdown
Sathya Perla (1):
bnxt_en: fix dst/src fid for vxlan enc
xt_en: Support for Short Firmware Message")
Signed-off-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/drivers/net/ethernet/bro
n', it fixes the
above issue
Fixes: 0efd2fc65c92 ("bnxt_en: Add a callback to inform RDMA driver during PCI
shutdown.")
Signed-off-by: Ray Jui
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
di
On Thu, Nov 30, 2017 at 11:36 AM, Scott Branden
wrote:
> Add ETH_RESET_AP support handling to reset the internal
> Application Processor(s) of the SmartNIC card.
>
> Signed-off-by: Scott Branden
Acked-by: Michael Chan
On Tue, Nov 28, 2017 at 7:56 AM, David Miller wrote:
> From: Christophe JAILLET
> Date: Tue, 21 Nov 2017 20:46:49 +0100
>
>> Error code returned by 'bnxt_read_sfp_module_eeprom_info()' is handled a
>> few lines above when reading the A0 portion of the EEPROM.
>> The same should be done when readi
On Mon, Nov 13, 2017 at 4:12 AM, David Binderman wrote:
>
> Hello there,
>
> Source code is
>
> BNXT_FW_TO_ETHTOOL_SPDS(fw_speeds, 0, lk_ksettings, supported);
>
> and
>
> if ((fw_pause) & BNXT_LINK_PAUSE_RX) { \
> ethtool_link_ksettings_add_link_mode(lk_ksettings, nam
On Sun, Nov 5, 2017 at 9:44 PM, Andy Gospodarek wrote:
> From: Andy Gospodarek
>
> This implements the changes needed for the bnxt_en driver to add support
> for adaptive interrupt moderation per ring.
>
> This does add additional counters in the receive path, but testing shows
> that any additio
xt_en: Refactor and simplify coalescing code.")
Reported-by: Andy Gospodarek
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/drivers/net/etherne
There was a typo and missing guard-rail against illegal values in the
recent code clean up. All reported by Andy Gospodarek.
Andy Gospodarek (1):
bnxt_en: fix typo in bnxt_set_coalesce
Michael Chan (1):
bnxt_en: Fix IRQ coalescing regression.
drivers/net/ethernet/broadcom/bnxt/bnxt.c
From: Andy Gospodarek
Recent refactoring of coalesce settings contained a typo that prevents
receive settings from being set properly.
Fixes: 18775aa8a91f ("bnxt_en: Reorganize the coalescing parameters.")
Signed-off-by: Andy Gospodarek
Signed-off-by: Michael Chan
---
drivers/ne
On Sun, Oct 29, 2017 at 11:22 AM, kbuild test robot wrote:
> All warnings (new ones prefixed by >>):
>
>drivers/net//ethernet/broadcom/bnxt/bnxt_tc.c: In function
> 'bnxt_tc_resolve_tunnel_hdrs':
>drivers/net//ethernet/broadcom/bnxt/bnxt_tc.c:882:10: error: implicit
> declaration of fun
On Fri, Oct 27, 2017 at 11:15 PM, Jakub Kicinski wrote:
> On Sat, 28 Oct 2017 14:05:04 +0800, Yunsheng Lin wrote:
>> Hi, Michael
>>
>> On 2017/10/28 13:56, Michael Chan wrote:
>> > Fix undefined symbols when CONFIG_VLAN_8021Q or CONFIG_INET is not set.
>> >
Fix undefined symbols when CONFIG_VLAN_8021Q or CONFIG_INET is not set.
Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap
offload")
Reported-by: Jakub Kicinski
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 6 ++
1 fi
On Fri, Oct 27, 2017 at 8:18 PM, Jakub Kicinski wrote:
> On Thu, 26 Oct 2017 11:51:29 -0400, Michael Chan wrote:
>> From: Sathya Perla
>>
>> This patch adds IPv4 vxlan encap/decap action support to TC-flower
>> offload.
>>
>> For vxlan encap, the dri
less useful interface spec version.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +--
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 30 ---
2 files changed, 18 insertions(+), 16 deletions(-)
diff --git a/drivers/net/ethernet
Return -EINVAL if the length is zero and not proceed to do essentially
nothing.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
b/drivers/net/ethernet
From: Rob Miller
Signed-off-by: Rob Miller
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index a9db4e6
No need to call bnxt_approve_mac() which will send a message to the
PF if the MAC address hasn't changed.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/b
From: Sathya Perla
Add routines for issuing the hwrm_cfa_encap_record_alloc/free
and hwrm_cfa_decap_filter_alloc/free FW cmds needed for
supporting vxlan encap/decap offload.
Signed-off-by: Sathya Perla
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 129
node is added and
a decap_filter_handle is alloc'd via the hwrm_cfa_decap_filter_alloc
cmd. This handle is used as the tunnel_handle while adding the flow.
The code to issue the HWRM FW cmds is introduced in a follow-up patch.
Signed-off-by: Sathya Perla
Signed-off-by: Michael Chan
---
dr
accurately set in hardware. The max_timer
is set to coal_ticks value.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 81 +--
1 file changed, 35 insertions(+), 46 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b
coalescing parameters.
Adjust the default coal_ticks to 14 us and 28 us for RX and TX.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 60 ++-
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 21 +---
drivers/net/ethernet/broadcom
From: Ray Jui
Add new PCIe device ID and chip number for bcm58804
Signed-off-by: Ray Jui
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 ++
2 files changed, 5 insertions(+)
diff --git a/drivers/net/ethernet
From: Sathya Perla
This patch implements periodic querying of cfa flow stats
in batches to compute the 'lastused' attribute of TC flow stats.
Signed-off-by: Sathya Perla
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c| 9 +
drivers/net/ethernet/bro
From: Sathya Perla
TC flower is not enabled on VFs and when there's no FW support.
Alloc the tc_info{} struct at init time only when TC flower is being
enabled.
Signed-off-by: Sathya Perla
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
driver
From: Vasundhara Volam
This is a firmware internal reset after driver is unloaded.
Signed-off-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 37 ++-
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h | 2 ++
2
Vxlan encap/decap filters are added to this firmware spec.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 420 --
1 file changed, 396 insertions(+), 24 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h
b/drivers
This series includes firmware interface update, some optimizations,
some new PCI IDs, new MTU checks, ethtool reset method, interrupt coalescing
code cleanup, and TC flower offload for vxlan encap/decap from Sathya
Perla.
Michael Chan (7):
bnxt_en: Update firmware interface to 1.8.3.1
Some NICs have a firmware enforced maximum MTU setting by management
firmware. Set up netdev->max_mtu accordingly.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 17 +++--
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
2 files changed, 12 inserti
On Tue, Oct 24, 2017 at 10:55 PM, Yuval Mintz wrote:
> ...
>
>> - if (!pci_find_ext_capability(bp->pdev, PCI_EXT_CAP_ID_SRIOV))
>> - return 0;
>> -
>> - if (bp->hwrm_spec_code < 0x10800) {
>> + if ((!pci_find_ext_capability(bp->pdev, PCI_EXT_CAP_ID_SRIOV)) ||
>> +
On Tue, Oct 24, 2017 at 1:12 PM, Steve Lin wrote:
> Implements get and set of configuration parameters using new devlink
> config get/set API. Parameters themselves defined in later patches.
>
> Signed-off-by: Steve Lin
> Acked-by: Andy Gospodarek
> ---
> drivers/net/ethernet/broadcom/bnxt/bnx
In bnxt_sriov_enable(), we calculate to see if we have enough hardware
resources to enable the requested number of VFs. The logic to check
for minimum completion rings and statistics contexts is missing. Add
the required checks so that VF configuration won't fail.
Signed-off-by: Michael
Various bug fixes for the VF/PF link change logic, VF resource checking,
potential firmware response corruption on NVRAM and DCB parameters,
and reading the wrong register for PCIe link speed on the VF.
Michael Chan (4):
bnxt_en: Improve VF/PF link change logic.
bnxt_en: Don't use rtnl
("bnxt_en: Implement DCBNL to support host-based DCBX.")
Signed-off-by: Sankar Patchineelam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/bro
n the same host and both take the rtnl lock and one is
waiting for the other, it will cause timeout. This patch fixes these
timeouts.
Fixes: 90c694bb7181 ("bnxt_en: Fix RTNL lock usage on bnxt_update_link().")
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt
From: Vasundhara Volam
PCIE PCIE_EP_REG_LINK_STATUS_CONTROL register is only defined in PF
config space, so we must read it from the PF.
Fixes: 90c4f788f6c0 ("bnxt_en: Report PCIe link speed and width during driver
load")
Signed-off-by: Vasundhara Volam
Signed-off-by: Mi
new variant _hwrm_send_message_silent() that requires
the caller to take the mutex and to release it after the response data has
been copied.
Fixes: 3ebf6f0a09a2 ("bnxt_en: Add installed-package version reporting via
Ethtool GDRVINFO")
Reported-by: Sarveswara Rao Mygapula
Signed-off-b
workqueue. The VF query and PF response will never be on
the same workqueue.
Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 66 +--
1 file changed, 53 insertions(+), 13
On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote:
> There is no reason to wrap the data structures inside the ifdef.
What's so bad about wrapping unused data structures inside #ifdef?
These structures are only used if CONFIG_BNXT_FLOWER_OFFLOAD is
defined.
than Toppins
Acked-by: Michael Chan
On Thu, Aug 31, 2017 at 11:10 PM, Frans van Berckel wrote:
> Dear NetDev Team,
>
> I am new to this machine. On a marketplace website I
> bought a Dell PowerEdge sc1435. Booting a today's Fedora (or even a
> Debian) amd64 Live CD from usb, and goes all fine.
>
> [0.00] Linux version 4.11.8
add TC flower filter offload support")
> Signed-off-by: Sathya Perla
Signed-off-by: Michael Chan
From: Scott Branden
initialize board_info values with proper enums for defensive programming
purposes. This will avoid any errors of the enums being declared not
lining up with the board_info array.
Signed-off-by: Scott Branden
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom
From: Ray Jui
Add PCIe device ID for bcm58802 and bcm58808. Also add chip number
update to declare bcm588xx as chip class phase 4 and later
Signed-off-by: Ray Jui
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +++-
drivers/net/ethernet/broadcom/bnxt/bnxt.h
and reserve again.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 46 +++
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 ++-
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 3 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
From: Sathya Perla
This patch adds the hwrm_cfa_flow_alloc/free() routines
that are needed to issue the FW cmds needed for TC flower offload.
Signed-off-by: Sathya Perla
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 141 ++-
1 file
Reduce default rings from 8 to 4 on multi-port cards to reduce memory
usage.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 13 +
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers
roduced in a subsequent patch.
Signed-off-by: Sathya Perla
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/Kconfig | 9 +
drivers/net/ethernet/broadcom/bnxt/Makefile | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 39 +-
drivers/net/ethernet/broadcom/b
bp->dl by passing a NULL dl ptr.
Fixes: 4ab0c6a8ffd7 ("bnxt_en: add support to enable VF-representors")
Signed-off-by: Sathya Perla
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 4 ++--
drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.h | 14 +++
From: Sathya Perla
This patch adds code to implement TC_CLSFLOWER_STATS TC-cmd and the
required FW code to query the stats from the HW.
Signed-off-by: Sathya Perla
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 95
1 file changed
.
Michael Chan (4):
bnxt_en: Update firmware interface spec. to 1.8.1.4.
bnxt_en: Improve tx ring reservation logic.
bnxt_en: Improve -ENOMEM logic in NAPI poll loop.
bnxt_en: Reduce default rings on multi-port cards.
Ray Jui (1):
bnxt: Add PCIe device IDs for bcm58802/bcm58808
Sathya
-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 25 -
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 +++-
2 files changed, 27 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/drivers/net/ethernet/broadcom/bnxt
towards the NAPI budget.
Cc: Martin KaFai Lau
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 1afb408..a34fcdd 100644
Flow APIs are added in this firmware interface.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 186 +-
1 file changed, 181 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h
b/drivers/net/ethernet
701 - 800 of 1880 matches
Mail list logo
