Hello.
In article [EMAIL PROTECTED] (at Thu, 30 Mar 2006 16:39:14 +0200), Peter
Bieringer [EMAIL PROTECTED] says:
IPv6:
# ip -6 route show table cache
ff02::1 via ff02::1 dev eth0 metric 0
cache mtu 1280 advmss 1220 metric 10 4294967295
ff02::1:ffea:7781 via ff02::1:ffea:7781 dev
In article [EMAIL PROTECTED] (at Thu, 23 Mar 2006 16:34:12 +), Hugo
Santos [EMAIL PROTECTED] says:
This patch fixes a soft lockup when encapsulated packets reach
ip6ip6_rcv() and there is no tunnel associated with it. The error
path returns a positive value (1) which will trigger
In article [EMAIL PROTECTED] (at Tue, 7 Mar 2006 11:26:13 +0100), Ingo Oeser
[EMAIL PROTECTED] says:
What about sth. like this simple defensive patch instead
(against Linux 2.6.16-rc4)?
I disagree again. Sorry.
--yoshfuji
-
To unsubscribe from this list: send the line unsubscribe netdev in
In article [EMAIL PROTECTED] (at Mon, 06 Mar 2006 21:50:33 +0100),
Jean-Mickael Guerin [EMAIL PROTECTED] says:
Hi,
This patch fixes potential null pointer dereference (I never experiment
such crash).
The patch is made for net-2.6.17.
I disagree.
It never happen, because (void *)rt-u.dst
In article [EMAIL PROTECTED] (at Tue, 28 Feb 2006 15:03:31 -0500), Brian
Haley [EMAIL PROTECTED] says:
The scope element in the ipv6_saddr_score struct used in
ipv6_dev_get_saddr() is an unsigned integer, but __ipv6_addr_src_scope()
returns a signed integer (and can return -1).
In article [EMAIL PROTECTED] (at Mon, 6 Mar 2006 02:34:16 -0500), Dave Jones
[EMAIL PROTECTED] says:
We've already dereferenced 'np' a dozen
times at this point, so it's safe to say it's not null.
Signed-off-by: Dave Jones [EMAIL PROTECTED]
Agreed.
--yoshfuji
-
To unsubscribe from this
In article [EMAIL PROTECTED] (at Mon, 27 Feb 2006 22:34:48 -0500), John
Zielinski [EMAIL PROTECTED] says:
I'm having a strange problem with my server machine. When I use an MTU
of 9000 I get a throughput of only 45-65Mbit/sec not counting TCP/IP
overhead. Receiving I get around
Hello.
In article [EMAIL PROTECTED] (at Thu, 23 Feb 2006 17:10:18 -0800 (PST)),
David S. Miller [EMAIL PROTECTED] says:
From: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Date: Fri, 24 Feb 2006 00:23:51 +0900 (JST)
David, please apply. Thank you.
Can you please resend the patch with a full
In article [EMAIL PROTECTED] (at Sun, 19 Feb 2006 14:47:09 +0100), [EMAIL
PROTECTED] says:
The fix is very simple, it only grab the value of frag_size and
use it in ip6_fragment file, could you please review the patch which
fix that problem at :
In article [EMAIL PROTECTED] (at Sun, 19 Feb 2006 15:54:13 +0100), [EMAIL
PROTECTED] says:
Yes, Hugo Santos suggested me to use the minimum of both, the new
patch is available there :
http://clarinet.u-strasbg.fr/~hoerdt/ip6_output.c.softfrag.patch2
Do you mean like this?
Signed-off-by:
In article [EMAIL PROTECTED] (at Fri, 27 Jan 2006 08:05:23 -0500), jamal
[EMAIL PROTECTED] says:
diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h
index 82fbb75..b54a129 100644
--- a/include/linux/xfrm.h
+++ b/include/linux/xfrm.h
:
@@ -235,6 +258,11 @@ struct xfrm_usersa_id {
Hello.
In article [EMAIL PROTECTED] (at Fri, 17 Feb 2006 11:38:42 +0100), Olivier
MATZ [EMAIL PROTECTED] says:
in skb_clone(), the following code is done twice :
#if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
C(nfct_reasm);
In article [EMAIL PROTECTED] (at Wed, 15 Feb 2006 00:23:28 +), Al Viro
[EMAIL PROTECTED] says:
In linux/igmp.h:
struct ip_mc_list
{
struct in_device*interface;
unsigned long multiaddr;
struct ip_sf_list *sources;
and AFAICS all users of
Hello.
In article [EMAIL PROTECTED] (at Thu, 9 Feb 2006 17:36:16 +0100), Ingo Oeser
[EMAIL PROTECTED] says:
Here are some possible (and trivial) cleanups.
:
- remove unused label
@@ -3193,7 +3190,6 @@ static int inet6_fill_ifinfo(struct sk_b
kfree(array);
return skb-len;
Hello.
In article [EMAIL PROTECTED] (at Wed, 08 Feb 2006 17:17:24 +0200), Kristian
Slavov [EMAIL PROTECTED] says:
During NETDEV_DOWN we clear IF_READY, and we don't set it back in
NETDEV_UP. While starting to perform DAD on the link-local address, we
notice that the device is not in
In article [EMAIL PROTECTED] (at Wed, 08 Feb 2006 15:59:31 -0800 (PST)),
David S. Miller [EMAIL PROTECTED] says:
Good spot. Please drop {}, otherwise, I agree. Thank you.
I'll take care of fixing that when I put in the fix.
Okay, thanks.
Acked-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
In article [EMAIL PROTECTED] (at Thu, 2 Feb 2006 23:42:25 +1100), Herbert Xu
[EMAIL PROTECTED] says:
On Thu, Feb 02, 2006 at 05:37:22AM -0700, Eric W. Biederman wrote:
Yes you are right. The locking/refcounting in addrconf.c is such
a mess. I've asked a number of times before as to
In article [EMAIL PROTECTED] (at Fri, 3 Feb 2006 12:48:49 +1100), Herbert Xu
[EMAIL PROTECTED] says:
On Fri, Feb 03, 2006 at 10:31:58AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@
wrote:
We SHALL do autoconf when we up an ipv6-capable device.
It is the IPv6.
I don't think the word SHALL
In article [EMAIL PROTECTED] (at Thu, 02 Feb 2006 20:09:44 -0800 (PST)),
David S. Miller [EMAIL PROTECTED] says:
From: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Date: Fri, 03 Feb 2006 11:32:13 +0900 (JST)
BTW, David, would you mind sending your addrconf patches to me?
I'd like to look into it
In article [EMAIL PROTECTED] (at Wed, 01 Feb 2006 17:28:10 -0800), Roland
Dreier [EMAIL PROTECTED] says:
Sorry to distract everyone from the VJ channel discussion, but on the
other hand it looks like Dave is back... I'm resending this because
I'd really like to get this problem fixed but I
In article [EMAIL PROTECTED] (at Thu, 26 Jan 2006 16:35:08 +0100),
Jean-Mickael Guerin [EMAIL PROTECTED] says:
Following patch drops this flag. As you can see, it requires to set the
flag back to RTF_EXPIRES in ndisc_router_discovery(), because
rt6_add_dflt_router() asks a new route with
Hello.
In article [EMAIL PROTECTED] (at Tue, 24 Jan 2006 16:38:26 -0800), Kris
Katterjohn [EMAIL PROTECTED] says:
+ if (optlen != sizeof val)
sizeof(val)
Please use sizeof(foo) instead of sizeof foo.
--- x/include/linux/if_packet.h 2006-01-24
In article [EMAIL PROTECTED] (at Wed, 25 Jan 2006 13:12:02 -0700), [EMAIL
PROTECTED] (Eric W. Biederman) says:
By bringing down the routes before we bring down the addresses we leak
the dst cache entries held by the addresses.
:
Fix this by simply moving rt6_ifdown where we flush the routes
Hello.
In article [EMAIL PROTECTED] (at Wed, 25 Jan 2006 09:13:26 -0800), Kris
Katterjohn [EMAIL PROTECTED] says:
+
+ case PACKET_ACCUMULATE_STATISTICS:
+ {
+ int val;
+
+ if (optlen != sizeof(val))
+ return -EINVAL;
I think this is
In article [EMAIL PROTECTED] (at Wed, 25 Jan 2006 19:46:07 -0800), Kris
Katterjohn [EMAIL PROTECTED] says:
@@ -1399,6 +1423,17 @@ static int packet_getsockopt(struct sock
return -EINVAL;
switch(optname) {
+ case PACKET_ACCUMULATE_STATISTICS:
+ {
Hello.
In article [EMAIL PROTECTED] (at Wed, 25 Jan 2006 20:25:56 -0800), Kris
Katterjohn [EMAIL PROTECTED] says:
Okey-dokey.
Signed-off-by: Kris Katterjohn [EMAIL PROTECTED]
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
--- x/net/packet/af_packet.c 2006-01-25 22:18:41.0
Hello.
In article [EMAIL PROTECTED] (at Sat, 7 Jan 2006 10:05:52 -0800), Kris
Katterjohn [EMAIL PROTECTED] says:
PACKET_AUTO_STATISTICS is the default and the kernel will zero the packet
statistics when the PACKET_STATISTICS getsockopt() call is used.
+ case PACKET_AUTO_STATISTICS:
+
In article [EMAIL PROTECTED] (at Mon, 16 Jan 2006 17:33:59 -0500), Andy
Gospodarek [EMAIL PROTECTED] says:
On 1/16/06, Jesper Juhl [EMAIL PROTECTED] wrote:
Maybe if you described your current problem someone could suggest a
solution...
Sure, I'd be glad to. If I add up all the
Hello.
Well, basic idea is okay. But...
In article [EMAIL PROTECTED] (at Fri, 13 Jan 2006 14:14:48 -0800), Joe
Perches [EMAIL PROTECTED] says:
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 7129d42..dfb4f14 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@
In article [EMAIL PROTECTED] (at Fri, 13 Jan 2006 14:29:24 -0800 (PST)),
David S. Miller [EMAIL PROTECTED] says:
changes all code to use NIP6_FMT
fixes net/ipv6/ip6_flowlabel.c
:
This looks good, applied, thanks Joe.
As I have commented in another mail, the original patch breaks
In article [EMAIL PROTECTED] (at Sat, 7 Jan 2006 02:09:30 +0100 (MET)),
Patrick McHardy [EMAIL PROTECTED] says:
following are the remaining patches for netfilter IPsec support.
They are missing the common-case optimization for inner transport mode
SAs on the input path, but since its just an
Use macro for spinlock_t/rwlock_t initializations/definition.
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c
b/net/ipv6/netfilter/nf_conntrack_reasm.c
index c2c52af..f3e5ffb 100644
--- a/net/ipv6/netfilter/nf_conntrack_reasm.c
+++
Use macro for spinlock_t definition.
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c
index 34fdac5..cefc26d 100644
--- a/net/econet/af_econet.c
+++ b/net/econet/af_econet.c
@@ -56,7 +56,7 @@ static struct net_device *net2dev_map[25
Use macro for rwlock_t initialization.
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index f829a4a..1cf305a 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -224,7 +224,7 @@ int ipv6_sock_mc_join(struct sock *sk, i
Hello.
Chinen-san has run tests against current net-2.6.16 tree.
We could run tests (Phase-1 for Host, Phase-2 Core for Host),
we see some regression in IPv6 neighbor discovery.
We have not tracked down closely yet.
FYI, you can find the result (IPv6 Ready Logo Phase-2 Core
(Host)) at:
Hello.
Again, we need to fix one more dead lock... sorry..
We need to release idev-lcok before we call addrconf_dad_stop().
It calls ipv6_addr_del(), which will hold idev-lock.
Bug spotted by Yasuyuki KOZAKAI [EMAIL PROTECTED].
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
diff --git
In article [EMAIL PROTECTED] (at Tue, 27 Dec 2005 02:35:52 -0200), Arnaldo
Carvalho de Melo [EMAIL PROTECTED] says:
diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c
index 0ab9c38..8cdeb5c 100644
--- a/drivers/net/sundance.c
+++ b/drivers/net/sundance.c
@@ -633,9 +633,13 @@
Hello.
Sorry, I introduced a dead-lock by the latest NETDEV_CHANGE patch.
We need to relesae ifp-lock before we call addrconf_dad_stop(),
which will hold ifp-lock.
Please apply this.
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index
From: Hiroyuki YAMAMORI [EMAIL PROTECTED]
Since regen_count is stored in the public address, we need to reset it
when we start renewing temporary address.
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 510220f..745aa43 100644
---
In article [EMAIL PROTECTED] (at Thu, 22 Dec 2005 03:54:29 -0500), Jeff
Garzik [EMAIL PROTECTED] says:
I'm not sure all drivers have been converted to use netif_carrier_ok(),
which would imply that IPv6 would now be broken on all drivers that do
not yet support it?
I don't think so.
In article [EMAIL PROTECTED] (at Wed, 21 Dec 2005 14:28:25 +0200), Kristian
Slavov [EMAIL PROTECTED] says:
If you add more than one IPv6 address belonging to the same prefix and
delete the address that was last added, routing table entry for that
prefix is also deleted.
:
Signed-off-by:
Hello.
I'm sorry for taking last minutes.
Please pull the following changesets and push them to the 2.6.15 queue.
These fix, basically, random FAILs in IPv6 Ready Logo Phase-2
Self Test in IPv6 Core Protocols.
Changesets are available at:
In article [EMAIL PROTECTED] (at Sun, 18 Dec 2005 15:27:01 +0100), Patrick
McHardy [EMAIL PROTECTED] says:
YOSHIFUJI Hideaki wrote:
In article [EMAIL PROTECTED] (at Tue, 22 Nov 2005 02:14:26 +0100),
Patrick McHardy [EMAIL PROTECTED] says:
The easiest way would be to store nhoff
Hello.
Please apply the following patch to 2.6.15 tree.
Thank you.
---
[IPV6]: Fix route lifetime.
The route expiration time is stored in rt6i_expires in jiffies.
The argument of rt6_route_add() for adding a route is not the
expiration time in jiffies nor in clock_t, but the lifetime
(or time
In article [EMAIL PROTECTED] (at Sun, 18 Dec 2005 23:59:35 +0100), Patrick
McHardy [EMAIL PROTECTED] says:
YOSHIFUJI Hideaki wrote:
:
BTW, we're now using full of skb-cb
(and we are even exceeding it w/ mobile-ipv6 extensions)...
Not in mainline so far, so maybe we can fit your
In article [EMAIL PROTECTED] (at Tue, 13 Dec 2005 20:57:42 -0800 (PST)),
David S. Miller [EMAIL PROTECTED] says:
From: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Date: Wed, 14 Dec 2005 13:03:55 +0900 (JST)
BTW, will you please capitalize labels in enums?
Andi suggested using function pointer,
In article [EMAIL PROTECTED] (at Fri, 9 Dec 2005 12:02:03 +0200 (EET)), Pekka
Savola [EMAIL PROTECTED] says:
How do you differentiate between these two cases? One is valid while
the other is not, but both seem valid to me.
default via fe80::20a:5eff:fe51:7d58 dev eth1 proto kernel
In article [EMAIL PROTECTED] (at Thu, 01 Dec 2005 18:04:30 -0800 (PST)),
David S. Miller [EMAIL PROTECTED] says:
net/ipv6/af_inet.c:inet6_create() has a similar problem and
it also is missing the module load logic the ipv4 counterpart
has.
Anyone up for cooking up a fix for those two
In article [EMAIL PROTECTED] (at Mon, 28 Nov 2005 18:14:48 -0800 (PST)),
David S. Miller [EMAIL PROTECTED] says:
I've implemented the necessary logic for TCP and UDP, but every other
possible legitimate receiver of PKT_TOOBIG messages (RAW, SCTP, DCCP,
AH6, ESP6, etc. etc. etc.) will need to
Hello.
Ensure to update hiscore.rule in dummy rule 4 in ipv6_dev_get_saddr().
Pointed out by Yan Zheng [EMAIL PROTECTED].
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index a16064b..76ff9f4 100644
--- a/net/ipv6/addrconf.c
+++
Hello.
In article [EMAIL PROTECTED] (at Tue, 22 Nov 2005 02:14:26 +0100), Patrick
McHardy [EMAIL PROTECTED] says:
The easiest way would be to store nhoff somewhere in the skb and
use it to continue at the next header. But I still hope there is
a way without keeping data in the skb.
We've
Hello.
In article [EMAIL PROTECTED] (at Mon, 21 Nov 2005 17:31:41 +0900), Kazunori
Miyazawa [EMAIL PROTECTED] says:
Your ip_xfrm_transport_hook is a good idea, I think.
We could call ip6_rcv_finish if the netfilter changed the addresses
or otherwise we can continue the loop to avoid the
In article [EMAIL PROTECTED] (at Fri, 18 Nov 2005 08:44:27 +0800), Yan Zheng
[EMAIL PROTECTED] says:
I get follow message when switch to single user mode and the kernel version
is 2.6.15-rc1-git5.
:
Nov 18 08:26:23 localhost kernel: Debug: sleeping function called from
invalid context at
In article [EMAIL PROTECTED] (at Tue, 15 Nov 2005 17:20:50 -0500), Vlad
Yasevich [EMAIL PROTECTED] says:
No, according to RFC 4007, loopback is considered a link-local
address.
Agreed. RFC3484 also explicitly says that loopback is treated as link-local.
--yoshfuji
-
To unsubscribe from this
In article [EMAIL PROTECTED] (at Mon, 14 Nov 2005 18:42:30 +0800), Yan Zheng
[EMAIL PROTECTED] says:
The score.rule++ doesn't make any sense for me.
According to codes above, I think it should be hiscore.rule++; .
Oops, you're right.
Signed-off-by: Yan Zheng[EMAIL PROTECTED]
Acked-by:
Hello.
David, this is what I promised before.
Please pull the following changesets, which implement
the source address selection algorythm described in RFC3484; e.g.:
- avoid using daprecated address
- prefer address in appropriate scope / on appropriate interface
- (minimum support of)
Subject: [PATCH 2/2] [IPV6]: Support IPV6_{RECV,}TCLASS socket options /
ancillary data.
Based on patch from David L Stevens [EMAIL PROTECTED]
Signed-off-by: David L Stevens [EMAIL PROTECTED]
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
---
include/linux/in6.h |2 --
In article [EMAIL PROTECTED] (at Tue, 06 Sep 2005 13:05:16 -0700), Ben Greear
[EMAIL PROTECTED] says:
neigh-nud_state = NUD_INCOMPLETE;
*** neigh_hold(neigh, NDRK_NEIGH_TIMER);
neigh-timer.expires = now + 1;
In article [EMAIL PROTECTED] (at Sat, 3 Sep 2005 11:27:56 +0100), Russell
King [EMAIL PROTECTED] says:
While trying to build a kernel with CONFIG_SYSCTL disabled, the following
error occurs:
CC net/ipv4/ip_sockglue.o
net/ipv4/ip_sockglue.c: In function `ip_setsockopt':
In article [EMAIL PROTECTED] (at Mon, 22 Aug 2005 13:08:28 +0200), Thomas
Graf [EMAIL PROTECTED] says:
Collection of cleanups for fib6_lookup() that used to live in my tree
for a while now.
Yoshfuji-san, what's the plan for CONFIG_IPV6_SUBTREES? Is MIPL
going to use it or can we remove it?
In article [EMAIL PROTECTED] (at Tue, 16 Aug 2005 21:58:36 -0700 (PDT)),
David S. Miller [EMAIL PROTECTED] says:
It also is a preferred change than your minimal version
because it makes the ip6 input path very similar to
the ipv4 variant, so it's easier to verify the two pieces
of code doing
In article [EMAIL PROTECTED] (at Sun, 07 Aug 2005 20:33:38 +0200), Balazs
Scheidler [EMAIL PROTECTED] says:
Commit log says it all.
+ xfrm_state_bydst = (struct list_head *) __get_free_pages(GFP_KERNEL,
get_order(sizeof(struct list_head) * XFRM_DST_HSIZE * 2));
Please check the
In article [EMAIL PROTECTED] (at Thu, 21 Jul 2005 21:44:43 +0100), Andrew
McDonald [EMAIL PROTECTED] says:
I guess the fix would be a matter of changing:
if (sk ra-sel == sel) {
to:
if (sk ra-sel == sel
(!sk-sk_bound_dev_if ||
sk-sk_bound_dev_if == skb-dev-ifindex)) {
I
401 - 463 of 463 matches
Mail list logo
