Re: [PATCH RFC net-next 3/6] net: Introduce IFF_LWT_NETDEV flag

2017-05-08 Thread Roopa Prabhu
On Mon, May 8, 2017 at 5:57 PM, David Ahern wrote: > On 5/8/17 1:11 PM, David Miller wrote: >> From: Johannes Berg >> Date: Mon, 08 May 2017 10:55:12 +0200 >> >>> +static inline bool netif_is_lwd(struct net_device *dev) +{ + return !!(dev->priv_flags & IFF_LWT_NETDEV); +} >>

Re: [PATCH RFC net-next 3/6] net: Introduce IFF_LWT_NETDEV flag

2017-05-08 Thread Roopa Prabhu
On Mon, May 8, 2017 at 1:11 PM, David Miller wrote: > From: Johannes Berg > Date: Mon, 08 May 2017 10:55:12 +0200 > >> >>> +static inline bool netif_is_lwd(struct net_device *dev) >>> +{ >>> +return !!(dev->priv_flags & IFF_LWT_NETDEV); >>> +} >> >> Am I the only one who thinks that this "LWT

Re: [PATCH net-next V3 2/2] rtnl: Add support for netdev event attribute to link messages

2017-04-27 Thread Roopa Prabhu
On Thu, Apr 27, 2017 at 12:51 PM, Vlad Yasevich wrote: > On 04/24/2017 11:14 AM, Roopa Prabhu wrote: >> On Sun, Apr 23, 2017 at 6:07 PM, David Ahern >> wrote: >>> >>> On 4/21/17 11:31 AM, Vladislav Yasevich wrote: >>>> @@ -1276,9 +1277,40 @@

Re: [PATCH net-next V3 2/2] rtnl: Add support for netdev event attribute to link messages

2017-04-24 Thread Roopa Prabhu
On Sun, Apr 23, 2017 at 6:07 PM, David Ahern wrote: > > On 4/21/17 11:31 AM, Vladislav Yasevich wrote: > > @@ -1276,9 +1277,40 @@ static int rtnl_xdp_fill(struct sk_buff *skb, struct > > net_device *dev) > > return err; > > } > > > > +static int rtnl_fill_link_event(struct sk_buff *skb, un

Re: [PATCH net-next 1/2 v2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-18 Thread Roopa Prabhu
On 4/18/17, 6:14 PM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > When you dump hundreds of thousands of actions, getting only 32 per > dump batch even when the socket buffer and memory allocations allow > is inefficient. > > With this change, the user will get as many as possibly fitting

Re: [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

2017-04-16 Thread Roopa Prabhu
On 4/16/17, 8:03 AM, Matthias Schiffer wrote: > On 04/14/2017 07:36 PM, Stephen Hemminger wrote: >> On Fri, 14 Apr 2017 18:44:44 +0200 >> Matthias Schiffer wrote: >> >>> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c >>> index 07f89b037681..95a71546e8f2 100644 >>> --- a/drivers/net/vxlan.c

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

2017-04-08 Thread Roopa Prabhu
On 4/8/17, 11:13 AM, David Ahern wrote: > On 4/8/17 2:06 PM, Roopa Prabhu wrote: >> On 4/7/17, 2:25 PM, David Ahern wrote: >>> Changing MTU on a link currently causes 3 messages to be sent to userspace: >>> >>> [LINK]11: dummy1: mtu 1490 qdisc noqueue &

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

2017-04-08 Thread Roopa Prabhu
On 4/7/17, 2:25 PM, David Ahern wrote: > Changing MTU on a link currently causes 3 messages to be sent to userspace: > > [LINK]11: dummy1: mtu 1490 qdisc noqueue state > UNKNOWN group default event PRE_CHANGE_MTU > link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff > > [LINK]11: dummy1: mtu

Re: [PATCH net-next] rtnl: Add support for netdev event to link messages

2017-03-29 Thread Roopa Prabhu
On 3/29/17, 5:23 AM, Vlad Yasevich wrote: > [ resending to list. hit the wrong reply button last time ] > > On 03/27/2017 06:58 PM, David Miller wrote: >> From: Vladislav Yasevich >> Date: Sat, 25 Mar 2017 21:59:47 -0400 >> >>> RTNL currently generates notifications on some netdev notifier events

Re: [PATCH net-next] net: mpls: Update lfib_nlmsg_size to skip deleted nexthops

2017-03-28 Thread Roopa Prabhu
On 3/28/17, 3:19 PM, David Ahern wrote: > A recent commit skips nexthops in a route if the device has been > deleted. Update lfib_nlmsg_size accordingly. > > Reported-by: Roopa Prabhu > Signed-off-by: David Ahern > --- > Acked-by: Roopa Prabhu

[PATCH net-next] vxlan: don't age NTF_EXT_LEARNED fdb entries

2017-03-27 Thread Roopa Prabhu
From: Roopa Prabhu vxlan driver already implicitly supports installing of external fdb entries with NTF_EXT_LEARNED. This patch just makes sure these entries are not aged by the vxlan driver. An external entity managing these entries will age them out. This is consistent with the use of

Re: [PATCH net-next 1/2] net: mpls: Don't show nexthop if device has been deleted

2017-03-26 Thread Roopa Prabhu
dev->ifindex; > if (nh->nh_flags & RTNH_F_LINKDOWN) { > rtnh->rtnh_flags |= RTNH_F_LINKDOWN; > linkdown++; Acked-by: Roopa Prabhu

Re: [PATCH net-next 2/2] net: mpls: Delete route when all nexthops have been deleted

2017-03-26 Thread Roopa Prabhu
On 3/24/17, 3:21 PM, David Ahern wrote: > When all devices for all nexthops in a route have been deleted, the > route is effectively dead, so remove it. > > Signed-off-by: David Ahern > Acked-by: Roopa Prabhu

[PATCH net-next] neighbour: fix nlmsg_pid in notifications

2017-03-19 Thread Roopa Prabhu
From: Roopa Prabhu neigh notifications today carry pid 0 for nlmsg_pid in all cases. This patch fixes it to carry calling process pid when available. Applications (eg. quagga) rely on nlmsg_pid to ignore notifications generated by their own netlink operations. This patch follows the routing

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Roopa Prabhu
On Tue, Mar 14, 2017 at 2:42 PM, Stephen Hemminger wrote: > On Tue, 14 Mar 2017 14:10:22 -0700 > Roopa Prabhu wrote: > >> On Tue, Mar 14, 2017 at 1:25 PM, Stephen Hemminger >> wrote: >> > On Tue, 14 Mar 2017 11:48:37 -0700 (PDT) >> > David Miller wrot

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Roopa Prabhu
On Tue, Mar 14, 2017 at 1:25 PM, Stephen Hemminger wrote: > On Tue, 14 Mar 2017 11:48:37 -0700 (PDT) > David Miller wrote: > >> From: Nikolay Aleksandrov >> Date: Tue, 14 Mar 2017 17:58:46 +0200 >> >> > On 14/03/17 17:55, Stephen Hemminger wrote: >> >> On Tue, 14 Mar 2017 17:36:15 +0200 >> >> Ni

[PATCH net-next] lwtunnel: remove unused but set variable

2017-03-13 Thread Roopa Prabhu
From: Roopa Prabhu silences the below warning: net/core/lwtunnel.c: In function ‘lwtunnel_valid_encap_type_attr’: net/core/lwtunnel.c:165:17: warning: variable ‘nla’ set but not used [-Wunused-but-set-variable] Fixes: 9ed59592e3e3 ("lwtunnel: fix autoload of lwt modules") Signed-off

Re: [PATCH net] vxlan: fix ovs support

2017-03-13 Thread Roopa Prabhu
core/dev.c:6713 > rollback_registered_many+0x9d/0x3f0 > > Fixes: 8bcdc4f3a20b ("vxlan: add changelink support") > CC: Roopa Prabhu > Signed-off-by: Nicolas Dichtel > --- > Acked-by: Roopa Prabhu Thanks Nicolas.

Re: [PATCH net-next v3 0/2] mpls: allow TTL propagation to/from IP packets to be configured

2017-03-13 Thread Roopa Prabhu
man (2): > mpls: allow TTL propagation to IP packets to be configured > mpls: allow TTL propagation from IP packets to be configured > > Acked-by: Roopa Prabhu

Re: [PATCH net-next] net: ipv4: add support for ECMP hash policy choice

2017-03-07 Thread Roopa Prabhu
On 3/6/17, 6:59 AM, Nikolay Aleksandrov wrote: > This patch adds support for ECMP hash policy choice via a new sysctl > called fib_multipath_hash_policy and also adds support for L4 hashes. > The current values for fib_multipath_hash_policy are: > 0 - layer 3 > 1 - layer 4 (new default) > If ther

Re: [PATCH net] bridge: Fix error path in nbp_vlan_init

2017-03-01 Thread Roopa Prabhu
On 3/1/17, 6:50 AM, Yotam Gigi wrote: > Fix error path order in nbp_vlan_init, so if switchdev_port_attr_set > call failes, the vlan_hash wouldn't be destroyed before inited. > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > CC: Roopa Prabh

[PATCH net-next] vxlan: remove unused variable saddr in neigh_reduce

2017-02-20 Thread Roopa Prabhu
From: Roopa Prabhu silences the below warning: drivers/net/vxlan.c: In function ‘neigh_reduce’: drivers/net/vxlan.c:1599:25: warning: variable ‘saddr’ set but not used [-Wunused-but-set-variable] Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c |3 +-- 1 file changed, 1

[PATCH net-next] vxlan: add changelink support

2017-02-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds changelink rtnl op support for vxlan netdevs. code changes involve: - refactor vxlan_newlink into vxlan_nl2conf to be used by vxlan_newlink and vxlan_changelink - vxlan_nl2conf and vxlan_dev_configure take a changelink argument to isolate

[PATCH net-next] bridge: don't indicate expiry on NTF_EXT_LEARNED fdb entries

2017-02-16 Thread Roopa Prabhu
From: Roopa Prabhu added_by_external_learn fdb entries are added and expired by external entities like switchdev driver or external controllers. ageing is already disabled for such entries. Hence, don't indicate expiry for such fdb entries. CC: Nikolay Aleksandrov CC: Jiri Pirko CC

[PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure

2017-02-16 Thread Roopa Prabhu
From: Roopa Prabhu Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") Signed-off-by: Roopa Prabhu --- net/bridge/br_vlan_tunnel.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/net/bridge/br_vlan_tunnel.c b/net/bridge/br_vlan_tunnel.c index b2b79a0..6d2c

[PATCH net-next] vxlan: remove vni zero check and drop for COLLECT_METADATA

2017-02-10 Thread Roopa Prabhu
From: Roopa Prabhu This patch drops the vni zero check for COLLECT_METADATA mode. It is not really needed, vni zero is a valid vni. Fixes: 3ad7a4b141eb ("vxlan: support fdb and learning in COLLECT_METADATA mode" Reported-by: Joe Stringer Signed-off-by: Roopa Prabhu --- drivers/n

Re: [PATCH net-next v2 2/5] vxlan: support fdb and learning in COLLECT_METADATA mode

2017-02-10 Thread Roopa Prabhu
On 2/10/17, 8:05 PM, Joe Stringer wrote: > On 31 January 2017 at 22:59, Roopa Prabhu wrote: >> @@ -1289,7 +1331,12 @@ static int vxlan_rcv(struct sock *sk, struct sk_buff >> *skb) >> if (!vs) >> goto drop; >> >> - vxlan = vx

[PATCH net-next] bridge: vlan tunnel id info range fill size calc cleanups

2017-02-07 Thread Roopa Prabhu
From: Roopa Prabhu This fixes a bug and cleans up tunnelid range size calculation code by using consistent variable names and checks in size calculation and fill functions. tested for a few cases of vlan-vni range mappings: (output from patched iproute2): $bridge vlan showtunnel port vid

[PATCH net-next] bridge: remove unnecessary check for vtbegin in br_fill_vlan_tinfo_range

2017-02-07 Thread Roopa Prabhu
From: Roopa Prabhu vtbegin should not be NULL in this function, Its already checked by the caller. this should silence the below smatch complaint: net/bridge/br_netlink_tunnel.c:144 br_fill_vlan_tinfo_range() error: we previously assumed 'vtbegin' could be null (see line 130)

Re: [PATCH net-next] bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel_info

2017-02-07 Thread Roopa Prabhu
On 2/7/17, 3:46 AM, Nikolay Aleksandrov wrote: > These checks should go after the attributes have been parsed otherwise > we're using tb uninitialized. > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > Reported-by: Colin Ian King > Signed-off-by: Nikolay Aleksandrov > --

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-02 Thread Roopa Prabhu
On 2/2/17, 5:50 PM, David Miller wrote: > I see a lot of "complexity of bridging layer" pushback on these > changes, and I understand where that is coming from. > > But really this isn't even, at a high level, really a bridging change. > > What it's doing is making lwtunnel objects more useful. > >

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-02 Thread Roopa Prabhu
On 2/1/17, 11:06 PM, Stephen Hemminger wrote: > On Wed, 01 Feb 2017 21:58:25 -0800 > Roopa Prabhu wrote: > >> On 2/1/17, 5:23 PM, Alexei Starovoitov wrote: >>> On Tue, Jan 31, 2017 at 10:59:50PM -0800, Roopa Prabhu wrote: >>> >> [snip] >>> I

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread Roopa Prabhu
On 2/1/17, 5:23 PM, Alexei Starovoitov wrote: > On Tue, Jan 31, 2017 at 10:59:50PM -0800, Roopa Prabhu wrote: > [snip] >> Solution in this patch series: >> The Goal is to use a single vxlan device to carry all vnis similar >> to the vxlan collect metadata mode but a

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread Roopa Prabhu
On 2/1/17, 8:04 PM, Stephen Hemminger wrote: > On Wed, 01 Feb 2017 20:02:35 -0800 > Roopa Prabhu wrote: > >> On 2/1/17, 5:59 PM, David Ahern wrote: >>> On 2/1/17 6:23 PM, Alexei Starovoitov wrote: >>>> On Tue, Jan 31, 2017 at

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread Roopa Prabhu
On 2/1/17, 5:59 PM, David Ahern wrote: > On 2/1/17 6:23 PM, Alexei Starovoitov wrote: >> On Tue, Jan 31, 2017 at 10:59:50PM -0800, Roopa Prabhu wrote: >>> >>> This provides the required vxlan bridging function but poses a >>> scalability

Re: [PATCH net-next 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread Roopa Prabhu
On 2/1/17, 8:35 AM, Stephen Hemminger wrote: > On Tue, 31 Jan 2017 12:43:19 -0800 > Roopa Prabhu wrote: > >> On 1/31/17, 8:41 AM, Stephen Hemminger wrote: [snip] >> But, this is just discouraging people from using the bridge driver. sorry, >> but i think it is

[PATCH net-next v2 5/5] bridge: vlan dst_metadata hooks in ingress and egress paths

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu - ingress hook: - if port is a tunnel port, use tunnel info in attached dst_metadata to map it to a local vlan - egress hook: - if port is a tunnel port, use tunnel info attached to vlan to set dst_metadata on the skb CC: Nikolay Aleksandrov Signed-off-by

[PATCH net-next v2 2/5] vxlan: support fdb and learning in COLLECT_METADATA mode

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu Vxlan COLLECT_METADATA mode today solves the per-vni netdev scalability problem in l3 networks. It expects all forwarding information to be present in dst_metadata. This patch series enhances collect metadata mode to include the case where only vni is present in dst_metadata

[PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu High level summary: lwt and dst_metadata have enabled vxlan l3 deployments to use a single vxlan netdev for multiple vnis eliminating the scalability problem with using a single vxlan netdev per vni. This series tries to do the same for vxlan netdevs in pure l2 bridged

[PATCH net-next v2 3/5] bridge: uapi: add per vlan tunnel info

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu New nested netlink attribute to associate tunnel info per vlan. This is used by bridge driver to send tunnel metadata to bridge ports in vlan tunnel mode. This patch also adds new per port flag IFLA_BRPORT_VLAN_TUNNEL to enable vlan tunnel mode. off by default. One example

[PATCH net-next v2 4/5] bridge: per vlan dst_metadata netlink support

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to attach per vlan tunnel info dst metadata. This enables bridge driver to map vlan to tunnel_info at ingress and egress. It uses the kernel dst_metadata infrastructure. The initial use case is vlan to vni bridging, but the api is generic to extend to

[PATCH net-next v2 1/5] ip_tunnels: new IP_TUNNEL_INFO_BRIDGE flag for ip_tunnel_info mode

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu New ip_tunnel_info flag to represent bridged tunnel metadata. Used by bridge driver later in the series to pass per vlan dst metadata to bridge ports. Signed-off-by: Roopa Prabhu --- include/net/ip_tunnels.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/net

Re: [PATCH net-next 2/5] vxlan: support fdb and learning in COLLECT_METADATA mode

2017-01-31 Thread Roopa Prabhu
On 1/31/17, 3:37 PM, Jonathan Toppins wrote: > On 01/31/2017 12:57 AM, Roopa Prabhu wrote: [snip] >> >> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c >> index 19b1653..b80c405 100644 >> --- a/drivers/net/vxlan.c >> +++ b/drivers/net/vxlan.c >> @@

Re: [PATCH net-next 0/5] bridge: per vlan dst_metadata support

2017-01-31 Thread Roopa Prabhu
On 1/31/17, 8:41 AM, Stephen Hemminger wrote: > On Mon, 30 Jan 2017 21:57:10 -0800 > Roopa Prabhu wrote: > >> From: Roopa Prabhu >> >> High level summary: >> lwt and dst_metadata have enabled vxlan l3 deployments >> to use a single vxlan netdev for mu

Re: [PATCH net-next 5/5] bridge: vlan dst_metadata hooks in ingress and egress paths

2017-01-31 Thread Roopa Prabhu
On 1/31/17, 4:52 AM, kbuild test robot wrote: > Hi Roopa, > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Roopa-Prabhu/bridge-per-vlan-dst_metadata-support/20170131-140750 > config: x86_64-allyesdebian (attached as .conf

[PATCH net-next 5/5] bridge: vlan dst_metadata hooks in ingress and egress paths

2017-01-30 Thread Roopa Prabhu
From: Roopa Prabhu - ingress hook: - if port is a tunnel port, use tunnel info in attached dst_metadata to map it to a local vlan - egress hook: - if port is a tunnel port, use tunnel info attached to vlan to set dst_metadata on the skb CC: Nikolay Aleksandrov Signed-off-by

[PATCH net-next 2/5] vxlan: support fdb and learning in COLLECT_METADATA mode

2017-01-30 Thread Roopa Prabhu
From: Roopa Prabhu Vxlan COLLECT_METADATA mode today solves the per-vni netdev scalability problem in l3 networks. It expects all forwarding information to be present in dst_metadata. This patch series enhances collect metadata mode to include the case where only vni is present in dst_metadata

[PATCH net-next 4/5] bridge: per vlan dst_metadata netlink support

2017-01-30 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to attach per vlan tunnel info dst metadata. This enables bridge driver to map vlan to tunnel_info at ingress and egress. It uses the kernel dst_metadata infrastructure. The initial use case is vlan to vni bridging, but the api is generic to extend to

[PATCH net-next 0/5] bridge: per vlan dst_metadata support

2017-01-30 Thread Roopa Prabhu
From: Roopa Prabhu High level summary: lwt and dst_metadata have enabled vxlan l3 deployments to use a single vxlan netdev for multiple vnis eliminating the scalability problem with using a single vxlan netdev per vni. This series tries to do the same for vxlan netdevs in pure l2 bridged

[PATCH net-next 1/5] ip_tunnels: new IP_TUNNEL_INFO_BRIDGE flag for ip_tunnel_info mode

2017-01-30 Thread Roopa Prabhu
From: Roopa Prabhu New ip_tunnel_info flag to represent bridged tunnel metadata. Used by bridge driver later in the series to pass per vlan dst metadata to bridge ports. Signed-off-by: Roopa Prabhu --- include/net/ip_tunnels.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/net

[PATCH net-next 3/5] bridge: uapi: add per vlan tunnel info

2017-01-30 Thread Roopa Prabhu
From: Roopa Prabhu New nested netlink attribute to associate tunnel info per vlan. This is used by bridge driver to send tunnel metadata to bridge ports in vlan tunnel mode. This patch also adds new per port flag IFLA_BRPORT_VLAN_TUNNEL to enable vlan tunnel mode. off by default. One example

Re: [PATCH net-next v2] lwtunnel: remove device arg to lwtunnel_build_state

2017-01-30 Thread Roopa Prabhu
On 1/30/17, 12:07 PM, David Ahern wrote: > Nothing about lwt state requires a device reference, so remove the > input argument. > > Signed-off-by: David Ahern > --- > v2 > - rebased to top of net-next tree > Acked-by: Roopa Prabhu thanks David

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Roopa Prabhu
On 1/30/17, 8:12 AM, David Ahern wrote: > On 1/30/17 8:49 AM, Roopa Prabhu wrote: >>> Single next hop delete will be around because IPv6 allows it -- and because >>> IPv4 needs to support it. >>> >> understand single next hop delete for ipv6 will be around..a

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Roopa Prabhu
On 1/29/17, 6:57 PM, David Ahern wrote: > On 1/29/17 7:20 PM, Roopa Prabhu wrote: >>> 2. Delete - 1 notification for each hop for all combinations of delete >>> commands >> here I was trying to say, for people deleting the full multipath route, you >> should sen

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Roopa Prabhu
On 1/30/17, 3:08 AM, Nicolas Dichtel wrote: > Le 30/01/2017 à 00:55, Roopa Prabhu a écrit : >> On 1/29/17, 10:02 AM, David Ahern wrote: >>> On 1/28/17 6:00 PM, Roopa Prabhu wrote: >>>>> 4. Route Appends >>>>>- IPv6 allows nexthops to be append

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-29 Thread Roopa Prabhu
On 1/29/17, 5:29 PM, David Ahern wrote: [snip] > Let's give an example for each case: > > 1. Add - full multipath route > > This route command: > ip -6 ro add vrf red 2001:db8:200::/120 nexthop via 2001:db8:1::2 nexthop via > 2001:db8:2::2 > > generates this notification (ip -t mon ro): > > 2001:d

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-29 Thread Roopa Prabhu
On 1/29/17, 10:02 AM, David Ahern wrote: > On 1/28/17 6:00 PM, Roopa Prabhu wrote: >>> 4. Route Appends >>>- IPv6 allows nexthops to be appended to an existing route. In this >>> case one notification is sent per nexthop added >> thanks for listing

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-28 Thread Roopa Prabhu
ed (from userspace semantics POV) I don't have a better solution, but with the above still being different, wondering if its worth the risk changing the api for just a few notifications. > > Addresses some of the inconsistencies also noted by Roopa at netdev0.1: > https://www.netd

Re: [RFC PATCH net-next 0/5] bridge: per vlan lwt and dst_metadata support

2017-01-25 Thread Roopa Prabhu
On 1/24/17, 7:47 AM, Stephen Hemminger wrote: > On Fri, 20 Jan 2017 21:46:51 -0800 > Roopa Prabhu wrote: > >> From: Roopa Prabhu >> >> High level summary: >> lwt and dst_metadata/collect_metadata have enabled vxlan l3 deployments >> to use a single vxlan n

[PATCH net-next v2 0/2] vxlan: misc fdb fixes

2017-01-23 Thread Roopa Prabhu
From: Roopa Prabhu Balakrishnan Raman (1): vxlan: do not age static remote mac entries Roopa Prabhu (1): vxlan: don't flush static fdb entries on admin down drivers/net/vxlan.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- v1 -> v2: use bool as suggested by DavidM

[PATCH net-next v2 2/2] vxlan: do not age static remote mac entries

2017-01-23 Thread Roopa Prabhu
From: Balakrishnan Raman Mac aging is applicable only for dynamically learnt remote mac entries. Check for user configured static remote mac entries and skip aging. Signed-off-by: Balakrishnan Raman Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH net-next v2 1/2] vxlan: don't flush static fdb entries on admin down

2017-01-23 Thread Roopa Prabhu
From: Roopa Prabhu This patch skips flushing static fdb entries in ndo_stop, but flushes all fdb entries during vxlan device delete. This is consistent with the bridge driver fdb Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions

Re: [PATCH cumulus-4.1.y 2/5] vxlan: don't replace fdb entry if nothing changed

2017-01-23 Thread Roopa Prabhu
On 1/23/17, 9:02 AM, Stephen Hemminger wrote: > On Fri, 20 Jan 2017 23:40:07 -0800 > Roopa Prabhu wrote: > >> +if (!vxlan_addr_equal(&rd->remote_ip, ip) || >> +rd->remote_port != port || >> +rd->remote_vni != vni || &

Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down

2017-01-23 Thread Roopa Prabhu
On 1/23/17, 1:07 PM, David Miller wrote: > From: Roopa Prabhu > Date: Fri, 20 Jan 2017 23:43:18 -0800 > >> /* Purge the forwarding table */ >> -static void vxlan_flush(struct vxlan_dev *vxlan) >> +static void vxlan_flush(struct vxlan_dev *vxlan, int do_all) > Please

Re: [PATCH cumulus-4.1.y 1/5] vxlan: flush fdb entries on oper down

2017-01-23 Thread Roopa Prabhu
On 1/23/17, 8:59 AM, Stephen Hemminger wrote: > On Fri, 20 Jan 2017 23:40:06 -0800 > Roopa Prabhu wrote: > >> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c >> index 19b1653..15b1c23 100644 >> --- a/drivers/net/vxlan.c >> +++ b/drivers/net/vxlan.c >

Re: [RFC PATCH net-next 0/5] bridge: per vlan lwt and dst_metadata support

2017-01-23 Thread Roopa Prabhu
On 1/23/17, 9:03 AM, Or Gerlitz wrote: > On Mon, Jan 23, 2017 at 6:13 PM, Roopa Prabhu > wrote: > >> Also, the goal is to reduce the number of vxlan devices from say 4k to 1. >> I don't think replacing it with 8k (egress + ingress) rules is going in the >> righ

Re: [RFC PATCH net-next 0/5] bridge: per vlan lwt and dst_metadata support

2017-01-23 Thread Roopa Prabhu
On 1/23/17, 8:24 AM, Jiri Benc wrote: > On Mon, 23 Jan 2017 08:13:30 -0800, Roopa Prabhu wrote: >> And, a 'vlan-to-tunid' mapping is a very common configuration in L2 ethernet >> vpn configurations. > You have one particular and narrow use case in mind and are proposi

Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down

2017-01-23 Thread Roopa Prabhu
On 1/23/17, 12:55 AM, Jiri Benc wrote: > On Fri, 20 Jan 2017 23:43:18 -0800, Roopa Prabhu wrote: >> This patch skips flushing static fdb entries in >> ndo_stop, but flushes all fdb entries during vxlan >> device delete. This is consistent with the bridge >> driver fdb &

Re: [RFC PATCH net-next 0/5] bridge: per vlan lwt and dst_metadata support

2017-01-23 Thread Roopa Prabhu
On 1/23/17, 12:51 AM, Jiri Benc wrote: > On Mon, 23 Jan 2017 09:08:05 +0100, Jiri Pirko wrote: >> Sat, Jan 21, 2017 at 06:46:51AM CET, ro...@cumulusnetworks.com wrote: >>> Other approaches tried and vetoed: >>> - tc vlan push/pop and tunnel metadata dst: >>>- posses a tc rule scalability proble

Re: [RFC PATCH net-next 4/5] bridge: vlan lwt and dst_metadata netlink support

2017-01-23 Thread Roopa Prabhu
On 1/22/17, 4:22 PM, Rosen, Rami wrote: > Hi, Roopa, > > Two minor comments: > > The parameter br is not used in the br_add_vlan_tunnel_info() method, it > should be removed: Thanks Rami. will take care of this in the next version.

Re: [RFC PATCH net-next 4/5] bridge: vlan lwt and dst_metadata netlink support

2017-01-22 Thread Roopa Prabhu
On 1/22/17, 4:05 AM, Nikolay Aleksandrov wrote: > On 21/01/17 06:46, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This patch adds support to attach per vlan tunnel info dst >> metadata. This enables bridge driver to map vlan to tunnel_info >> at ingress and egr

Re: [RFC PATCH net-next 5/5] bridge: vlan lwt dst_metadata hooks in ingress and egress paths

2017-01-22 Thread Roopa Prabhu
On 1/22/17, 4:15 AM, Nikolay Aleksandrov wrote: > On 21/01/17 06:46, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> - ingress hook: >> - if port is a lwt tunnel port, use tunnel info in >> attached dst_metadata to map it to a local vlan >> -

Re: [RFC PATCH net-next 2/5] vxlan: make COLLECT_METADATA mode bridge friendly

2017-01-22 Thread Roopa Prabhu
On 1/22/17, 3:40 AM, Nikolay Aleksandrov wrote: > On 21/01/17 06:46, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This patch series makes vxlan COLLECT_METADATA mode bridge >> and layer2 network friendly. Vxlan COLLECT_METADATA mode today >> solves the per-vni

Re: [RFC PATCH net-next 3/5] bridge: uapi: add per vlan tunnel info

2017-01-21 Thread Roopa Prabhu
On 1/20/17, 9:46 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > New netlink api to associate tunnel info per vlan. > This is used by bridge driver to send tunnel metadata to > bridge ports in LWT tunnel dst metadata mode. > > One example use for this is a vxlan bridging ga

[PATCH net-next 2/2] vxlan: do not age static remote mac entries

2017-01-20 Thread Roopa Prabhu
From: Balakrishnan Raman Mac aging is applicable only for dynamically learnt remote mac entries. Check for user configured static remote mac entries and skip aging. Signed-off-by: Balakrishnan Raman Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH net-next 0/2] vxlan: misc fdb fixes

2017-01-20 Thread Roopa Prabhu
From: Roopa Prabhu Balakrishnan Raman (1): vxlan: do not age static remote mac entries Roopa Prabhu (1): vxlan: don't flush static fdb entries on admin down drivers/net/vxlan.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 1.9.1

[PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down

2017-01-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch skips flushing static fdb entries in ndo_stop, but flushes all fdb entries during vxlan device delete. This is consistent with the bridge driver fdb Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions

Re: [PATCH cumulus-4.1.y 1/5] vxlan: flush fdb entries on oper down

2017-01-20 Thread Roopa Prabhu
On 1/20/17, 11:40 PM, Roopa Prabhu wrote: > From: Balakrishnan Raman > > Flush fdb entries of a vxlan device when its state > changes to oper down. vxlan_stop handles flush on > admin down. > > Signed-off-by: Balakrishnan Raman > Signed-off-by: Roopa Prabhu > ---

[PATCH cumulus-4.1.y 2/5] vxlan: don't replace fdb entry if nothing changed

2017-01-20 Thread Roopa Prabhu
From: Balakrishnan Raman This will avoid unnecessary notifications to userspace. Signed-off-by: Balakrishnan Raman Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net

[PATCH cumulus-4.1.y 1/5] vxlan: flush fdb entries on oper down

2017-01-20 Thread Roopa Prabhu
From: Balakrishnan Raman Flush fdb entries of a vxlan device when its state changes to oper down. vxlan_stop handles flush on admin down. Signed-off-by: Balakrishnan Raman Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers

[PATCH cumulus-4.1.y 3/5] vxlan: enforce precedence for static over dynamic fdb entry

2017-01-20 Thread Roopa Prabhu
From: Wilson Kok This patch enforces fdb state correctly when deciding to add or update an existing fdb. It makes sure static fdb entries are not replaced by dynamic fdb entries. Signed-off-by: Wilson Kok Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 4 1 file changed, 4

[PATCH cumulus-4.1.y 5/5] vxlan: do not age static remote mac entries

2017-01-20 Thread Roopa Prabhu
From: Balakrishnan Raman Mac aging is applicable only for dynamically learnt remote mac entries. Check for user configured static remote mac entries and skip aging. Signed-off-by: Balakrishnan Raman Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH cumulus-4.1.y 4/5] vxlan: don't flush static fdb entries on admin down

2017-01-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch skips flushing static fdb entries in ndo_stop, but flushes all fdb entries during vxlan device delete. This is consistent with the bridge driver fdb Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions

[RFC PATCH net-next 5/5] bridge: vlan lwt dst_metadata hooks in ingress and egress paths

2017-01-20 Thread Roopa Prabhu
From: Roopa Prabhu - ingress hook: - if port is a lwt tunnel port, use tunnel info in attached dst_metadata to map it to a local vlan - egress hook: - if port is a lwt tunnel port, use tunnel info attached to vlan to set dst_metadata on the skb CC: Nikolay Aleksandrov

[RFC PATCH net-next 3/5] bridge: uapi: add per vlan tunnel info

2017-01-20 Thread Roopa Prabhu
From: Roopa Prabhu New netlink api to associate tunnel info per vlan. This is used by bridge driver to send tunnel metadata to bridge ports in LWT tunnel dst metadata mode. One example use for this is a vxlan bridging gateway or vtep which maps vlans to vn-segments (or vnis). User can configure

[RFC PATCH net-next 2/5] vxlan: make COLLECT_METADATA mode bridge friendly

2017-01-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch series makes vxlan COLLECT_METADATA mode bridge and layer2 network friendly. Vxlan COLLECT_METADATA mode today solves the per-vni netdev scalability problem in l3 networks. When vxlan collect metadata device participates in bridging vlan to vn-segments, It can only

[RFC PATCH net-next 1/5] ip_tunnels: new IP_TUNNEL_INFO_BRIDGE flag for ip_tunnel_info mode

2017-01-20 Thread Roopa Prabhu
From: Roopa Prabhu New ip_tunnel_info flag to represent bridged tunnel metadata. Used by bridge driver later in the series to pass per vlan dst metadata to bridge ports. Signed-off-by: Roopa Prabhu --- include/net/ip_tunnels.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/net

[RFC PATCH net-next 4/5] bridge: vlan lwt and dst_metadata netlink support

2017-01-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to attach per vlan tunnel info dst metadata. This enables bridge driver to map vlan to tunnel_info at ingress and egress The initial use case is vlan to vni bridging, but the api is generic to extend to any tunnel_info in the future: - Uapi to

[RFC PATCH net-next 0/5] bridge: per vlan lwt and dst_metadata support

2017-01-20 Thread Roopa Prabhu
From: Roopa Prabhu High level summary: lwt and dst_metadata/collect_metadata have enabled vxlan l3 deployments to use a single vxlan netdev for multiple vnis eliminating the scalability problem with using a single vxlan netdev per vni. This series tries to do the same for vxlan netdevs in pure

Re: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics

2017-01-19 Thread Roopa Prabhu
>>>> u32). This patch adds them as an extended stats. >>>> >>>> It is read with filter type IFLA_STATS_LINK_64 and no sub type. >>>> >>>> It is under the name 64bits >>>> (or any shorten of it as "64") >>>> >&

Re: [PATCH net-next v2 1/3] net: ipv6: Allow shorthand delete of all nexthops in multipath route

2017-01-16 Thread Roopa Prabhu
On 1/15/17, 12:07 PM, David Ahern wrote: > IPv4 allows multipath routes to be deleted using just the prefix and > length. For example: > $ ip ro ls vrf red > unreachable default metric 8192 > 1.1.1.0/24 > nexthop via 10.100.1.254 dev eth1 weight 1 > nexthop via 10.11.20

Re: [PATCH net-next 2/2] mpls: Packet stats

2017-01-13 Thread Roopa Prabhu
exposed in the future either by adding to the end of > struct mpls_link_stats or by additional netlink attributes in the > AF_MPLS IFLA_STATS_AF_SPEC nested attribute. > > Signed-off-by: Robert Shearman > --- > Acked-by: Roopa Prabhu

Re: [PATCH net-next 1/2] net: AF-specific RTM_GETSTATS attributes

2017-01-13 Thread Roopa Prabhu
discounted this approach as I perceived a common use-case > to be getting all the stats for an interface and this approach would > necessitate multiple requests/dumps to retrieve them all. > > Signed-off-by: Robert Shearman > Acked-by: Roopa Prabhu

Re: [PATCH net-next 0/2] mpls: Packet stats

2017-01-13 Thread Roopa Prabhu
On 1/13/17, 10:14 AM, Robert Shearman wrote: > This patchset records per-interface packet stats in the MPLS > forwarding path and exports them using a nest of attributes root at a > new IFLA_STATS_AF_SPEC attribute as part of RTM_GETSTATS messages: > > [IFLA_STATS_AF_SPEC] > -> [AF_MPLS] > -> [M

Re: [PATCH iproute2 v3 4/4] ifstat: Add "sw only" extended statistics to ifstat

2016-12-22 Thread Roopa Prabhu
On 12/22/16, 8:23 AM, Nogah Frankel wrote: > Add support for extended statistics of SW only type, for counting only the > packets that went via the cpu. (useful for systems with forward > offloading). It reads it from filter type IFLA_STATS_LINK_OFFLOAD_XSTATS > and sub type IFLA_OFFLOAD_XSTATS_CPU

Re: [PATCH v2 main-v4.9-rc7] net/ipv6: allow sysctl to change link-local address generation mode

2016-12-04 Thread Roopa Prabhu
On 12/4/16, 2:31 PM, Felix Jia wrote: > Removed the rtnl lock and switch to use RCU lock to iterate through > the netdev list. > > The address generation mode for IPv6 link-local can only be configured > by netlink messages. This patch adds the ability to change the address > generation mode via sy

Re: [RFC PATCH net-next v2] ipv6: implement consistent hashing for equal-cost multipath routing

2016-12-01 Thread Roopa Prabhu
On Tue, Nov 29, 2016 at 11:56 PM, David Lebrun wrote: > On 11/30/2016 04:52 AM, Hannes Frederic Sowa wrote: > >> Also please convert the sysctl to a netlink attribute if you pursue this >> because if I change the sysctl while my quagga is hammering the routing >> table I would like to know which

Re: [PATCH iproute2 0/3] update ifstat for new stats

2016-11-27 Thread Roopa Prabhu
(resending ...failed to send it to the list earlier) On 11/24/16, 6:12 AM, Nogah Frankel wrote: > Previously stats were gotten by RTM_GETLINK which return 32 bits based > statistics. It support only one type of stats. > Lately, a new method to get stats was added - RTM_GETSTATS. It supports > abil

Re: [net] rtnetlink: fix the wrong minimal dump size getting from rtnl_calcit()

2016-11-23 Thread Roopa Prabhu
On 11/21/16, 10:14 PM, Zhang Shengju wrote: > For RT netlink, calcit() function should return the minimal size for > netlink dump message. This will make sure that dump message for every > network device can be stored. > > Currently, rtnl_calcit() function doesn't account the size of header of > ne

Re: [PATCH net-next 1/1] ipv6: sr: add option to control lwtunnel support

2016-11-23 Thread Roopa Prabhu
On 11/23/16, 1:28 AM, David Lebrun wrote: > On 11/23/2016 08:34 AM, Roopa Prabhu wrote: >> I can't seem to reproduce the problem you are seeing. still trying.. >> I don't have CONFIG_LWTUNNEL set nor any of the other SEG6 configs. >> My CONFIG_IPV6 is on and compiled

<    1   2   3   4   5   6   7   8   9   10   >