Re: [PATCH] Rewrite e100_phys_id

2006-11-07 Thread Auke Kok
Matthew Wilcox wrote: The motivator for this was to fix the sparse warning: drivers/net/e100.c:2418:48: warning: cast truncates bits from constant value (83126e978d4fdf becomes 978d4fdf) drivers/net/e100.c:2419:37: warning: cast truncates bits from constant value (83126e978d4fdf becomes

Re: [PATCH] Rewrite e100_phys_id

2006-11-07 Thread Matthew Wilcox
On Tue, Nov 07, 2006 at 10:33:14AM -0800, Auke Kok wrote: Matthew Wilcox wrote: Tested on the internal interface of an HP Integrity rx2600. bad news, it's completely hosed. The adapter does some indistinguishable blinking for a second, then stops blinking alltogether. Weird. I tested it

Re: [PATCH] Rewrite e100_phys_id

2006-11-07 Thread Auke Kok
Matthew Wilcox wrote: On Tue, Nov 07, 2006 at 10:33:14AM -0800, Auke Kok wrote: Matthew Wilcox wrote: Tested on the internal interface of an HP Integrity rx2600. bad news, it's completely hosed. The adapter does some indistinguishable blinking for a second, then stops blinking alltogether.

Re: [PATCH] Rewrite e100_phys_id

2006-10-27 Thread Auke Kok
Matthew Wilcox wrote: On Thu, Oct 26, 2006 at 01:04:32PM -0700, Auke Kok wrote: no objections, so I'll ACK it with the notion that I'm going to let our labs do some more testing on it with all the latest changes to it. Thanks, Auke. Here's the equivalent patch for e1000. I don't have a

[PATCH] Rewrite e100_phys_id

2006-10-26 Thread Matthew Wilcox
The motivator for this was to fix the sparse warning: drivers/net/e100.c:2418:48: warning: cast truncates bits from constant value (83126e978d4fdf becomes 978d4fdf) drivers/net/e100.c:2419:37: warning: cast truncates bits from constant value (83126e978d4fdf becomes 978d4fdf) Initially, I tried

Re: [PATCH] Rewrite e100_phys_id

2006-10-26 Thread Jeff Garzik
On Thu, Oct 26, 2006 at 01:11:55PM -0600, Matthew Wilcox wrote: The motivator for this was to fix the sparse warning: drivers/net/e100.c:2418:48: warning: cast truncates bits from constant value (83126e978d4fdf becomes 978d4fdf) drivers/net/e100.c:2419:37: warning: cast truncates bits from

Re: [PATCH] Rewrite e100_phys_id

2006-10-26 Thread Auke Kok
Jeff Garzik wrote: On Thu, Oct 26, 2006 at 01:11:55PM -0600, Matthew Wilcox wrote: The motivator for this was to fix the sparse warning: drivers/net/e100.c:2418:48: warning: cast truncates bits from constant value (83126e978d4fdf becomes 978d4fdf) drivers/net/e100.c:2419:37: warning: cast

Re: [PATCH] Rewrite e100_phys_id

2006-10-26 Thread Matthew Wilcox
On Thu, Oct 26, 2006 at 01:04:32PM -0700, Auke Kok wrote: no objections, so I'll ACK it with the notion that I'm going to let our labs do some more testing on it with all the latest changes to it. Thanks, Auke. Here's the equivalent patch for e1000. I don't have a convenient machine to test