RE: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-20 Thread Hayes Wang
Corinna Vinschen [mailto:vinsc...@redhat.com] > Sent: Thursday, August 20, 2015 5:42 PM [...] > What about CmdRxEnb? Are there > chips which need this flag set to perform the counter reset? No. CmdRxEnb is used to enable/disable the rx, and you could reset the counters without changing CmdRxEnb.

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-20 Thread Corinna Vinschen
On Aug 20 02:43, Hayes Wang wrote: > Corinna Vinschen [mailto:vinsc...@redhat.com] > > Sent: Thursday, August 20, 2015 3:24 AM > [...] > > + /* > > +* Versions prior to RTL_GIGA_MAC_VER_19 don't support resetting the > > +* tally counters. > > +*/ > > + if (tp->mac_version >= RTL_GI

RE: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-19 Thread Hayes Wang
Corinna Vinschen [mailto:vinsc...@redhat.com] > Sent: Thursday, August 20, 2015 3:24 AM [...] > + /* > + * Versions prior to RTL_GIGA_MAC_VER_19 don't support resetting the > + * tally counters. > + */ > + if (tp->mac_version >= RTL_GIGA_MAC_VER_19) { > + RTL_W32(

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-19 Thread Corinna Vinschen
On Aug 19 16:24, Corinna Vinschen wrote: > On Aug 19 15:07, Corinna Vinschen wrote: > > On Aug 19 09:31, Hayes Wang wrote: > > > Corinna Vinschen [mailto:vinsc...@redhat.com] > > > > Sent: Wednesday, August 19, 2015 5:13 PM > > > [...] > > > > > It could be cleared by setting bit 0, such as rtl_tal

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-19 Thread Corinna Vinschen
On Aug 19 15:07, Corinna Vinschen wrote: > On Aug 19 09:31, Hayes Wang wrote: > > Corinna Vinschen [mailto:vinsc...@redhat.com] > > > Sent: Wednesday, August 19, 2015 5:13 PM > > [...] > > > > It could be cleared by setting bit 0, such as rtl_tally_reset() of > > > > r8152. > > > > > > Is it safe

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-19 Thread Corinna Vinschen
On Aug 19 09:31, Hayes Wang wrote: > Corinna Vinschen [mailto:vinsc...@redhat.com] > > Sent: Wednesday, August 19, 2015 5:13 PM > [...] > > > It could be cleared by setting bit 0, such as rtl_tally_reset() of r8152. > > > > Is it safe to assume that this is implemented in all NICs covered by r8169

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-19 Thread Corinna Vinschen
On Aug 18 19:05, David Miller wrote: > From: Francois Romieu > Date: Tue, 18 Aug 2015 23:40:17 +0200 > > > Corinna Vinschen : > >> The r8169 driver collects statistical information returned by > >> @get_stats64 by counting them in the driver itself, even though many > >> (but not all) of the val

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-19 Thread Corinna Vinschen
On Aug 19 02:51, Hayes Wang wrote: > [...] > > > The TCs are only reset by a power cycle and there's no known way > > > to reset them programatically. > > It could be cleared by setting bit 0, such as rtl_tally_reset() of r8152. Thanks for this hint. I'll give it a try. Is it safe to assume tha

RE: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-19 Thread Hayes Wang
Corinna Vinschen [mailto:vinsc...@redhat.com] > Sent: Wednesday, August 19, 2015 5:13 PM [...] > > It could be cleared by setting bit 0, such as rtl_tally_reset() of r8152. > > Is it safe to assume that this is implemented in all NICs covered by r8169? It is supported from RTL8111C. That is, RTL

RE: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-18 Thread Hayes Wang
[...] > > The TCs are only reset by a power cycle and there's no known way > > to reset them programatically. It could be cleared by setting bit 0, such as rtl_tally_reset() of r8152. Best Regards, Hayes N�r��yb�X��ǧv�^�)޺{.n�+���z�^�)w*jg����ݢj/���z�ޖ��2�ޙ&�)ߡ�a�����G���

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-18 Thread David Miller
From: Francois Romieu Date: Tue, 18 Aug 2015 23:40:17 +0200 > Corinna Vinschen : >> The r8169 driver collects statistical information returned by >> @get_stats64 by counting them in the driver itself, even though many >> (but not all) of the values are already collected by tally counters >> (TCs

Re: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-18 Thread Francois Romieu
Corinna Vinschen : > The r8169 driver collects statistical information returned by > @get_stats64 by counting them in the driver itself, even though many > (but not all) of the values are already collected by tally counters > (TCs) in the NIC. Some of these TC values are not returned by > @get_st

[PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-18 Thread Corinna Vinschen
The r8169 driver collects statistical information returned by @get_stats64 by counting them in the driver itself, even though many (but not all) of the values are already collected by tally counters (TCs) in the NIC. Some of these TC values are not returned by @get_stats64. Especially the receive