On Sep 9 01:27, Francois Romieu wrote:
> Corinna Vinschen :
> [...]
> > - Alternatively I can still reproduce the SEGV in rtl_remove_one
> > when trying to rmmod the module, I just don't have the stack dump
> > handy while writing this mail. I can show it if needed.
>
> I see it too.
>
>
Corinna Vinschen :
[...]
> - Alternatively I can still reproduce the SEGV in rtl_remove_one
> when trying to rmmod the module, I just don't have the stack dump
> handy while writing this mail. I can show it if needed.
I see it too.
> I debugged this on and off the entire day (tweaking, com
On Sep 8 02:02, Francois Romieu wrote:
> Francois Romieu :
> [...]
> > Updated patch is on the way.
>
> Fixed memcpy in patch 0001, moved counters allocation from open()
> to probe(), returned open() to its original state but something is
> still wrong: the link does not come up.
I tested and
On Sep 7 23:52, Francois Romieu wrote:
> Corinna Vinschen :
> [...]
> > I have a bit of a problem with this patch. It crashes when loading the
> > driver manually w/ modprobe. For some reason dev_get_stats is called
> > during rtl_init_one and at that time the counters pointer is NULL, so
> > t
Hi David,
On Sep 7 17:00, David Miller wrote:
> From: Corinna Vinschen
> Date: Mon, 7 Sep 2015 11:29:49 +0200
>
> > Still wondering though. Given that the driver never failed before if
> > the counter values couldn't be updated, and given that these counter
> > values only have statistical rel
Francois Romieu :
[...]
> Updated patch is on the way.
Fixed memcpy in patch 0001, moved counters allocation from open()
to probe(), returned open() to its original state but something is
still wrong: the link does not come up.
Patches attached.
I'll try again tomorrow.
--
Ueimor
>From 8f1b8
From: Corinna Vinschen
Date: Mon, 7 Sep 2015 11:29:49 +0200
> Still wondering though. Given that the driver never failed before if
> the counter values couldn't be updated, and given that these counter
> values only have statistical relevance, why should this suddenly result
> in a fatal failure
Corinna Vinschen :
[...]
> I have a bit of a problem with this patch. It crashes when loading the
> driver manually w/ modprobe. For some reason dev_get_stats is called
> during rtl_init_one and at that time the counters pointer is NULL, so
> the kernel gets a SEGV.
>
> After I worked around th
On Sep 6 12:37, Corinna Vinschen wrote:
> On Sep 5 14:18, rom...@fr.zoreil.com wrote:
> > From: Francois Romieu
> >
> > net/core/net-sysfs.c::netstat_show retrieves stats with spinlock held.
> >
> > This change avoids sleepable allocation and performs some housekeeping:
> > - receive ring, tra
On Sep 6 22:21, Francois Romieu wrote:
> Corinna Vinschen :
> > On Sep 5 14:18, rom...@fr.zoreil.com wrote:
> [...]
> > > - rtl_reset_counters_cond induced failures in open() are also considered
> > > fatal: it takes acceptable work to unwind comfortably.
> >
> > Why?
>
>
> Crap, my descrip
From: Francois Romieu
Date: Sun, 6 Sep 2015 22:21:53 +0200
> Corinna Vinschen :
>> On Sep 5 14:18, rom...@fr.zoreil.com wrote:
> [...]
>> > - rtl_reset_counters_cond induced failures in open() are also considered
>> > fatal: it takes acceptable work to unwind comfortably.
>>
>> Why?
>
>
>
Corinna Vinschen :
> On Sep 5 14:18, rom...@fr.zoreil.com wrote:
[...]
> > - rtl_reset_counters_cond induced failures in open() are also considered
> > fatal: it takes acceptable work to unwind comfortably.
>
> Why?
Crap, my description does not match the code wrt rtl_reset_counters_cond. :o
On Sep 5 14:18, rom...@fr.zoreil.com wrote:
> From: Francois Romieu
>
> net/core/net-sysfs.c::netstat_show retrieves stats with spinlock held.
>
> This change avoids sleepable allocation and performs some housekeeping:
> - receive ring, transmit ring and counters dump area allocation failures
>
From: Francois Romieu
net/core/net-sysfs.c::netstat_show retrieves stats with spinlock held.
This change avoids sleepable allocation and performs some housekeeping:
- receive ring, transmit ring and counters dump area allocation failures
are all considered fatal during open()
- netif_warn is n
14 matches
Mail list logo
