Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-09-16 Thread Marcelo Ricardo Leitner
On Thu, Aug 27, 2015 at 08:40:29AM +0200, Jiri Pirko wrote: > Thu, Aug 27, 2015 at 08:36:03AM CEST, da...@davemloft.net wrote: > >From: Jiri Pirko > >Date: Thu, 27 Aug 2015 08:27:04 +0200 > > > >> I'm not saying it is not possible, it certainly is. But I think that > >> for example rocker internal

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread Jiri Pirko
Thu, Aug 27, 2015 at 08:36:03AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Thu, 27 Aug 2015 08:27:04 +0200 > >> I'm not saying it is not possible, it certainly is. But I think that >> for example rocker internals have no value to default user, he >> should not care and he cannot fin

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread David Miller
From: Jiri Pirko Date: Thu, 27 Aug 2015 08:27:04 +0200 > I'm not saying it is not possible, it certainly is. But I think that > for example rocker internals have no value to default user, he > should not care and he cannot find out what is going on there > without knowledge or rocker.c code. The

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread Jiri Pirko
Thu, Aug 27, 2015 at 08:01:15AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Thu, 27 Aug 2015 07:40:04 +0200 > >> Switch object itselt would not help you to expose rocker internals. I >> don't think that you can find generic way, same for all drivers, to >> expose internal tables and

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread David Miller
From: Jiri Pirko Date: Thu, 27 Aug 2015 07:40:04 +0200 > Switch object itselt would not help you to expose rocker internals. I > don't think that you can find generic way, same for all drivers, to > expose internal tables and stuff. That is hw specific. Tables are datastructures with names and t

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread Jiri Pirko
Wed, Aug 26, 2015 at 08:21:59PM CEST, sfel...@gmail.com wrote: >On Wed, Aug 26, 2015 at 10:49 AM, David Miller wrote: >> From: Jiri Pirko >> Date: Wed, 26 Aug 2015 09:37:57 +0200 >> >>> I don't think that are much more cases like this. Therefore I think that >>> for this cases, debugfs might be a

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread David Miller
From: Scott Feldman Date: Wed, 26 Aug 2015 11:21:59 -0700 > Using another netdev doesn't seem right. Do we need a new device > class for switches, and then create some common tool/interfaces for > switch device class? This is probably what we will need to do. There has also been a discussion l

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread Florian Fainelli
On 26/08/15 11:21, Scott Feldman wrote: > On Wed, Aug 26, 2015 at 10:49 AM, David Miller wrote: >> From: Jiri Pirko >> Date: Wed, 26 Aug 2015 09:37:57 +0200 >> >>> I don't think that are much more cases like this. Therefore I think that >>> for this cases, debugfs might be a good way to expose de

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread Scott Feldman
On Wed, Aug 26, 2015 at 10:49 AM, David Miller wrote: > From: Jiri Pirko > Date: Wed, 26 Aug 2015 09:37:57 +0200 > >> I don't think that are much more cases like this. Therefore I think that >> for this cases, debugfs might be a good way to expose debugging stats. > > Scott wanted to do similar t

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread David Miller
From: Jiri Pirko Date: Wed, 26 Aug 2015 09:37:57 +0200 > I don't think that are much more cases like this. Therefore I think that > for this cases, debugfs might be a good way to expose debugging stats. Scott wanted to do similar things in rocker. DSA guys too. Every switch device is going to

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread Jiri Pirko
Wed, Aug 26, 2015 at 08:08:21AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 26 Aug 2015 07:52:15 +0200 > >> They are simple statistics. But they does not fit into any existing >> interface. This is about EMAD packets. They are not per-netdevice, but >> per-pcidevice. So I cannot

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-25 Thread David Miller
From: Jiri Pirko Date: Wed, 26 Aug 2015 07:52:15 +0200 > They are simple statistics. But they does not fit into any existing > interface. This is about EMAD packets. They are not per-netdevice, but > per-pcidevice. So I cannot put them into ethtool. > > I see no other iface to expose this other

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-25 Thread Jiri Pirko
Tue, Aug 25, 2015 at 11:25:21PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 24 Aug 2015 16:45:46 +0200 > >> From: Jiri Pirko >> >> Signed-off-by: Jiri Pirko >> Signed-off-by: Ido Schimmel >> Signed-off-by: Elad Raz > >Enough with this debugfs madness. > >Expose this stuff t

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-25 Thread David Miller
From: Jiri Pirko Date: Mon, 24 Aug 2015 16:45:46 +0200 > From: Jiri Pirko > > Signed-off-by: Jiri Pirko > Signed-off-by: Ido Schimmel > Signed-off-by: Elad Raz Enough with this debugfs madness. Expose this stuff through standard interfaces. They are simple statistics for crying out loud!

[patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-24 Thread Jiri Pirko
From: Jiri Pirko Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel Signed-off-by: Elad Raz --- drivers/net/ethernet/mellanox/mlxsw/core.c | 51 -- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drive