Hi Jakub,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url:
https://github.com/0day-ci/linux/commits/Jakub-Audykowicz/sctp-frag_point-sanity-check/20181206-011917
config: x86_64-randconfig-x015-12051035 (attached as .config)
compiler: gcc-7
On Wed, Dec 5, 2018 at 10:00 PM Jakub Kicinski
wrote:
>
> On Wed, 5 Dec 2018 17:18:52 -0800, Michael Chan wrote:
> > On Wed, Dec 5, 2018 at 4:42 PM Jakub Kicinski wrote:
> > > On Wed, 5 Dec 2018 16:01:08 -0800, Michael Chan wrote:
> > > > On Wed, Dec 5, 2018 at 3:33 PM Jakub Kicinski wrote:
> > >
Thank you reviewing the patches.
On Wed, Dec 5, 2018 at 5:24 PM Jiri Pirko wrote:
>
> Wed, Dec 05, 2018 at 06:56:54AM CET, vasundhara-v.vo...@broadcom.com wrote:
> >Add functions to register and unregister for the driver supported
> >configuration parameters table per port.
> >
> >Cc: Jiri Pirko
On Wed, 5 Dec 2018 17:18:52 -0800, Michael Chan wrote:
> On Wed, Dec 5, 2018 at 4:42 PM Jakub Kicinski wrote:
> > On Wed, 5 Dec 2018 16:01:08 -0800, Michael Chan wrote:
> > > On Wed, Dec 5, 2018 at 3:33 PM Jakub Kicinski wrote:
> > > > On Wed, 5 Dec 2018 11:27:00 +0530, Vasundhara Volam wrote:
On Thu, Dec 6, 2018 at 1:38 PM David Miller wrote:
>
> From: Xin Long
> Date: Wed, 5 Dec 2018 14:49:40 +0800
>
> > This patch is to separate the base data memory from struct flex_array and
> > save it into a page. With this change, total_nr_elements of a flex_array
> > can grow or shrink
From: David Ahern
Date: Wed, 5 Dec 2018 20:02:29 -0800
> From: David Ahern
>
> Add extack messages for failures in neigh_add and neigh_delete.
>
> Signed-off-by: David Ahern
Looks good, applied, thanks David.
On 06/12/18 12:22 AM, Jiong Wang wrote:
> This patch implements code-gen for BPF_ALU | BPF_ARSH | BPF_*.
>
> Cc: Naveen N. Rao
> Cc: Sandipan Das
> Signed-off-by: Jiong Wang
> ---
> arch/powerpc/include/asm/ppc-opcode.h | 2 ++
> arch/powerpc/net/bpf_jit.h| 4
>
From: Jiri Wiesner
Date: Wed, 5 Dec 2018 16:55:29 +0100
> The *_frag_reasm() functions are susceptible to miscalculating the byte
> count of packet fragments in case the truesize of a head buffer changes.
> The truesize member may be changed by the call to skb_unclone(), leaving
> the fragment
From: Xin Long
Date: Wed, 5 Dec 2018 14:49:40 +0800
> This patch is to separate the base data memory from struct flex_array and
> save it into a page. With this change, total_nr_elements of a flex_array
> can grow or shrink without having the old element's memory changed when
> the new size of
From: Peter Oskolkov
Date: Tue, 4 Dec 2018 11:55:56 -0800
> When testing high-bandwidth TCP streams with large windows,
> high latency, and low jitter, netem consumes a lot of CPU cycles
> doing rbtree rebalancing.
>
> This patch uses a linear list/queue in addition to the rbtree:
> if an
From: Jakub Audykowicz
Date: Tue, 4 Dec 2018 20:27:41 +0100
> If for some reason an association's fragmentation point is zero,
> sctp_datamsg_from_user will try to endlessly try to divide a message
> into zero-sized chunks. This eventually causes kernel panic due to
> running out of memory.
>
On Wed, Dec 05, 2018 at 06:15:23PM +, Quentin Monnet wrote:
> > > +
> > > + /* Allow room for NULL terminating byte and pipe file name */
> > > + snprintf(format, sizeof(format), "%%*s %%%zds %%99s %%*s %%*d %%*d\\n",
> > > + PATH_MAX - strlen(pipe_name) - 1);
> >
> > before scanning
On Wed, Dec 05, 2018 at 03:32:50PM +, Jiong Wang wrote:
> On 05/12/2018 14:52, Edward Cree wrote:
> > On 05/12/18 09:46, Jiong Wang wrote:
> > > There is NO processed instruction number regression, either with or
> > > without
> > > -mattr=+alu32.
> >
> > > Cilium bpf
> > > ===
> > >
On Wed, Dec 05, 2018 at 05:35:43PM -0800, Martin KaFai Lau wrote:
> The patchset has a few improvements on bpf_func_info:
> 1. Improvements on the behaviors of info.func_info, info.func_info_cnt
>and info.func_info_rec_size.
> 2. Name change: s/insn_offset/insn_off/
>
> Please see individual
On Tue, Dec 04, 2018 at 03:26:15PM -0800, Stanislav Fomichev wrote:
> On 12/04, Song Liu wrote:
> > On Mon, Dec 3, 2018 at 8:01 PM Stanislav Fomichev wrote:
> > >
> > > We are returning thoff from the flow dissector, not the nhoff. Pass
> > > thoff along with nhoff to the bpf program (initially
On Wed, Dec 5, 2018 at 4:42 PM Jakub Kicinski
wrote:
>
> On Wed, 5 Dec 2018 16:01:08 -0800, Michael Chan wrote:
> > On Wed, Dec 5, 2018 at 3:33 PM Jakub Kicinski
> > wrote:
> > >
> > > On Wed, 5 Dec 2018 11:27:00 +0530, Vasundhara Volam wrote:
> > > > Register devlink_port with devlink and
David Miller writes:
> Your CC list is so huge that vger.kernel.org dropped all of your postings.
>
> That CC list is not reasonable at all, trim it down to the most minimum
> set. Probably 2 or 3 mailing lists, primarily netdev, and maybe a small
> handful of specific developers.
>
> Nothing
From: David Ahern
Date: Wed, 5 Dec 2018 17:46:37 -0700
> ok. patches 5-7 are not dependent on 1-4. Should I re-send outside of
> this set?
Yes, please respin.
Thanks David.
From: Saeed Mahameed
Date: Wed, 5 Dec 2018 16:12:58 -0800
> The following series is for mlx5e netdevice driver, it adds ethtool
> support for RX hash fields configuration and some misc updates, please
> see tag log below.
>
> Please pull and let me know if there's any problem.
>
> v1->v2:
>
On 12/5/18 5:46 PM, David Ahern wrote:
> ok. patches 5-7 are not dependent on 1-4. Should I re-send outside of
> this set?
bleh. 5 is. I'll re-send.
etpoline it is deadly.
>
> Please avoid removing the full inline expansion of the neigh lookup in the
> ipv6
> and ipv4 data paths.
>
ok. patches 5-7 are not dependent on 1-4. Should I re-send outside of
this set?
From: David Ahern
Date: Wed, 5 Dec 2018 15:34:09 -0800
> @@ -270,37 +270,25 @@ static inline bool neigh_key_eq128(const struct
> neighbour *n, const void *pkey)
> (n32[2] ^ p32[2]) | (n32[3] ^ p32[3])) == 0;
> }
>
> -static inline struct neighbour *___neigh_lookup_noref(
> -
On Wed, 5 Dec 2018 16:01:08 -0800, Michael Chan wrote:
> On Wed, Dec 5, 2018 at 3:33 PM Jakub Kicinski
> wrote:
> >
> > On Wed, 5 Dec 2018 11:27:00 +0530, Vasundhara Volam wrote:
> > > Register devlink_port with devlink and create initial port params
> > > table for bnxt_en. The table consists
ce the issue but it is not a
> > good example. I will rewrite a test code and re-submit the patch.
>
> Now I fully understand ;)
>
> Basically your customer is using SO_DONTROUTE to 'pause' incoming TCP traffic
> by not sending ACK.
>
> Interesting trick but quite hacky. I guess
From: Yuchung Cheng
Date: Wed, 5 Dec 2018 14:38:38 -0800
> TCP loss probe timer may fire when the retranmission queue is empty but
> has a non-zero tp->packets_out counter. tcp_send_loss_probe will call
> tcp_rearm_rto which triggers NULL pointer reference by fetching the
> retranmission queue
From: Jouke Witteveen
Date: Wed, 5 Dec 2018 23:38:17 +0100
> Can you elaborate a bit? I may not be aware of the policy you have in
> mind.
When we have a user facing interface to do something, we don't create
another one unless it is absolutely, positively, unavoidable.
From: Eric Dumazet
Date: Wed, 5 Dec 2018 14:24:31 -0800
> If available rwnd is too small, tcp_tso_should_defer()
> can decide it is worth waiting before splitting a TSO packet.
>
> This really means we are rwnd limited.
>
> Fixes: 5615f88614a4 ("tcp: instrument how long TCP is limited by
From: Alexei Starovoitov
Date: Wed, 5 Dec 2018 13:23:22 -0800
> The following pull-request contains BPF updates for your *net* tree.
>
> The main changes are:
>
> 1) fix bpf uapi pointers for 32-bit architectures, from Daniel.
>
> 2) improve verifer ability to handle progs with a lot of
r side won't receive data after it received some
> data. I extracted the test code from my customer's production
> environment. The test code could reproduce the issue but it is not a
> good example. I will rewrite a test code and re-submit the patch.
Now I fully understand ;)
Basically y
From: Andrew Lunn
Date: Wed, 5 Dec 2018 21:49:39 +0100
> This patchset fixes issues found in the last patchset which converted
> the phydev advertise etc, from a u32 to a linux bitmap. Most of the
> issues are the result of clearing bits which should not of been
> cleared. To make the API
From: Edward Cree
Date: Tue, 4 Dec 2018 17:37:57 +
> list_del() leaves the skb->next pointer poisoned, which can then lead to
> a crash in e.g. OVS forwarding. For example, setting up an OVS VXLAN
> forwarding bridge on sfc as per:
...
> So, in all listified-receive handling, instead
the test code from my customer's production
environment. The test code could reproduce the issue but it is not a
good example. I will rewrite a test code and re-submit the patch.On
Wed, Dec 5, 2018 at 3:17 PM Eric Dumazet wrote:
>
> On Wed, Dec 5, 2018 at 3:07 PM yupeng wrote:
> >
&
On Wed, Dec 5, 2018 at 3:33 PM Jakub Kicinski
wrote:
>
> On Wed, 5 Dec 2018 11:27:00 +0530, Vasundhara Volam wrote:
> > Register devlink_port with devlink and create initial port params
> > table for bnxt_en. The table consists of a generic parameter:
> >
> > wake-on-lan: Enables Wake on Lan for
On Wed, 2018-12-05 at 11:28 -0800, Cong Wang wrote:
> Hello, Saeed
>
> On Tue, Dec 4, 2018 at 10:27 PM Saeed Mahameed
> wrote:
> > static int mlx5e_handle_pflag(struct net_device *netdev,
> > u32 wanted_flags,
> > - enum mlx5e_priv_flag
On Wed, 2018-12-05 at 10:36 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 10:27 PM Saeed Mahameed
> wrote:
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> > b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> > index a429553002a6..49e90ac5dc8b 100644
> > ---
On Wed, 2018-12-05 at 11:19 -0800, Cong Wang wrote:
> Hello, Saeed
>
>
> On Tue, Dec 4, 2018 at 10:26 PM Saeed Mahameed
> wrote:
> > +static int mlx5e_get_rss_hash_opt(struct mlx5e_priv *priv,
> > + struct ethtool_rxnfc *nfc)
> ...
> > + tt =
On Wed, 2018-12-05 at 10:56 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 10:26 PM Saeed Mahameed
> wrote:
> > +static const struct mlx5e_tirc_config
> > +tirc_default_config[MLX5E_NUM_INDIR_TIRS] = {
>
> Is it okay to define an array in a header??? No link error???
>
> I must be dumb...
On 2018/12/05 16:57, Nicolas Belouin wrote:
[...]
>
> Thanks for your help, using your debug patch I got the value of
> needed_headroom:
> USHRT_MAX - 64
> And tracked it down to a legacy out of tree patch of ours I then fixed.
> The patch was increasing/decreasing the needed_headroom without
On Wed, 5 Dec 2018 11:27:00 +0530, Vasundhara Volam wrote:
> Register devlink_port with devlink and create initial port params
> table for bnxt_en. The table consists of a generic parameter:
>
> wake-on-lan: Enables Wake on Lan for this port when magic packet
> is received with this port's MAC
On Wed, Dec 5, 2018 at 3:07 PM yupeng wrote:
>
> after set SO_DONTROUTE to 1, the IP layer should not route packets if
> the dest IP address is not in link scope. But if the socket has cached
> the dst_entry, such packets would be routed until the sk_dst_cache
> expires. So we should clean the
On Wed, Dec 5, 2018 at 8:45 PM David Miller wrote:
>
> From: Jouke Witteveen
> Date: Wed, 5 Dec 2018 14:50:31 +0100
>
> > For example, I maintain a network manager that delegates the actual
> > networking work to specialized programs.
>
> Basically "I've implemented things using separate
On Tue, 2018-12-04 at 20:55 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 6:06 PM Saeed Mahameed
> wrote:
> > +static inline u8 get_cqe_opcode(struct mlx5_cqe64 *cqe)
>
> Make it const please.
Please be specific
I can do:
static inline u8 get_cqe_opcode(struct mlx5_cqe64 const *cqe)
if that
On Wed, Dec 5, 2018 at 2:28 PM Soheil Hassas Yeganeh wrote:
>
> On Wed, Dec 5, 2018 at 5:24 PM Eric Dumazet wrote:
> >
> > If available rwnd is too small, tcp_tso_should_defer()
> > can decide it is worth waiting before splitting a TSO packet.
> >
> > This really means we are rwnd limited.
> >
>
On Wed, Dec 5, 2018 at 5:24 PM Eric Dumazet wrote:
>
> If available rwnd is too small, tcp_tso_should_defer()
> can decide it is worth waiting before splitting a TSO packet.
>
> This really means we are rwnd limited.
>
> Fixes: 5615f88614a4 ("tcp: instrument how long TCP is limited by receive
>
On Wed, 2018-12-05 at 08:09 +, Leon Romanovsky wrote:
> On Tue, Dec 04, 2018 at 06:03:02PM -0800, Saeed Mahameed wrote:
> > From: Tariq Toukan
> >
> > Use the new helper that extracts the opcode
> > from a CQE (completion queue entry) structure.
> >
> > Signed-off-by: Tariq Toukan
> >
On Tue, 2018-12-04 at 21:04 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 6:05 PM Saeed Mahameed
> wrote:
> > After the following flow counters API refactoring:
> > ("net/mlx5: Use flow counter IDs and not the wrapping cache
> > object")
> > flow counters private data structures mlx5_fc_cache
On 12/5/18 12:46 PM, Pavel Machek wrote:
> Hi!
>
> But I'm running into problems with tagging code, and I guess I'd like
> some help understanding.
>
> tag_trailer: allocates new skb, then copies data around.
>
> tag_qca: does dev->stats.tx_packets++, and reuses existing
Hi!
> > > > But I'm running into problems with tagging code, and I guess I'd like
> > > > some help understanding.
> > > >
> > > > tag_trailer: allocates new skb, then copies data around.
> > > >
> > > > tag_qca: does dev->stats.tx_packets++, and reuses existing skb.
> > > >
> > > > tag_brcm:
From: Matteo Croce
Date: Tue, 4 Dec 2018 18:05:42 +0100
> Following commit 59f997b088d2 ("macvlan: return correct error value"),
> there is a duplicate check for mac addresses both in macvlan_sync_address()
> and macvlan_set_mac_address().
> As the former calls the latter, remove the one in
From: Anssi Hannula
Date: Fri, 30 Nov 2018 20:21:34 +0200
> Here are a couple of race condition fixes for the macb driver. The first
> two are issues observed on real HW.
It looks like there is still an active discussion about the memory
barriers in patch #3 being excessive.
Once that is
From: Anssi Hannula
Date: Fri, 30 Nov 2018 20:21:35 +0200
> @@ -682,6 +682,11 @@ static void macb_set_addr(struct macb *bp, struct
> macb_dma_desc *desc, dma_addr_
> if (bp->hw_dma_cap & HW_DMA_CAP_64B) {
> desc_64 = macb_64b_desc(bp, desc);
> desc_64->addrh =
From: Jouke Witteveen
Date: Wed, 5 Dec 2018 14:50:31 +0100
> For example, I maintain a network manager that delegates the actual
> networking work to specialized programs.
Basically "I've implemented things using separate programs"
> Basically, it is an implementation of network manager logic
From: Jiong Wang
Date: Wed, 05 Dec 2018 11:28:32 +
> Indeed. Doubled checked the ISA doc,"Bit 32 of RS is replicated to fill
> RA0:31.".
>
> Will fix both places in v2.
See, sparc64 isn't so weird :-)
Hello, Saeed
On Tue, Dec 4, 2018 at 10:27 PM Saeed Mahameed wrote:
> static int mlx5e_handle_pflag(struct net_device *netdev,
> u32 wanted_flags,
> - enum mlx5e_priv_flag flag,
> - mlx5e_pflag_handler
Hello, Saeed
On Tue, Dec 4, 2018 at 10:26 PM Saeed Mahameed wrote:
> +static int mlx5e_get_rss_hash_opt(struct mlx5e_priv *priv,
> + struct ethtool_rxnfc *nfc)
...
> + tt = flow_type_to_traffic_type(nfc->flow_type);
> +
> + if (tt ==
On Tue, Dec 4, 2018 at 10:26 PM Saeed Mahameed wrote:
> +static const struct mlx5e_tirc_config
> +tirc_default_config[MLX5E_NUM_INDIR_TIRS] = {
Is it okay to define an array in a header??? No link error???
I must be dumb...
On 12/5/18 10:18 AM, Andrew Lunn wrote:
> On Wed, Dec 05, 2018 at 07:00:38PM +0100, Andrew Lunn wrote:
>> On Mon, Dec 03, 2018 at 03:34:56PM -0800, tristram...@microchip.com wrote:
>>> From: Tristram Ha
>>>
>>> Update tag_ksz.c to access switch driver's tail tagging operations.
>>
>> Hi Tristram
On Tue, Dec 4, 2018 at 10:27 PM Saeed Mahameed wrote:
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> index a429553002a6..49e90ac5dc8b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> +++
On Wed, Dec 05, 2018 at 07:00:38PM +0100, Andrew Lunn wrote:
> On Mon, Dec 03, 2018 at 03:34:56PM -0800, tristram...@microchip.com wrote:
> > From: Tristram Ha
> >
> > Update tag_ksz.c to access switch driver's tail tagging operations.
>
> Hi Tristram
>
> Humm, i'm not sure we want this, the
2018-12-05 08:50 UTC-0800 ~ Alexei Starovoitov
On Wed, Dec 05, 2018 at 10:28:24AM +, Quentin Monnet wrote:
BPF programs can use the bpf_trace_printk() helper to print debug
information into the trace pipe. Add a subcommand
"bpftool prog tracelog" to simply dump this pipe to the console.
On Tue, 2018-12-04 at 18:12 +, Edward Cree wrote:
> On 04/12/18 17:44, Paolo Abeni wrote:
> > On Tue, 2018-12-04 at 17:13 +, Edward Cree wrote:
> > > On 03/12/18 11:40, Paolo Abeni wrote:
> > > > This header define a bunch of helpers that allow avoiding the
> > > > retpoline overhead when
On Mon, Dec 03, 2018 at 03:34:56PM -0800, tristram...@microchip.com wrote:
> From: Tristram Ha
>
> Update tag_ksz.c to access switch driver's tail tagging operations.
Hi Tristram
Humm, i'm not sure we want this, the tagging spit into two places. I
need to take a closer look at the previous
On 12/05, Song Liu wrote:
> On Mon, Dec 3, 2018 at 8:01 PM Stanislav Fomichev wrote:
> >
> > This patch series adds support for testing flow dissector BPF programs by
> > extending already existing BPF_PROG_TEST_RUN. The goal is to have a
> > packet as an input and `struct bpf_flow_key' as an
On Mon, Dec 3, 2018 at 8:01 PM Stanislav Fomichev wrote:
>
> This patch series adds support for testing flow dissector BPF programs by
> extending already existing BPF_PROG_TEST_RUN. The goal is to have a
> packet as an input and `struct bpf_flow_key' as an output. That way
> we can easily test
Hi Tristan
> +static void ksz9477_r_mib_cnt(struct ksz_device *dev, int port, u16 addr,
> + u64 *cnt)
> +{
> + u32 data;
> + int timeout;
> + struct ksz_port *p = >ports[port];
> +
> + /* retain the flush/freeze bit */
> + data = p->freeze ?
On Tue, Dec 4, 2018 at 3:26 PM Stanislav Fomichev wrote:
>
> On 12/04, Song Liu wrote:
> > On Mon, Dec 3, 2018 at 8:01 PM Stanislav Fomichev wrote:
> > >
> > > We are returning thoff from the flow dissector, not the nhoff. Pass
> > > thoff along with nhoff to the bpf program (initially thoff ==
On Mon, Dec 03, 2018 at 03:34:52PM -0800, tristram...@microchip.com wrote:
> From: Tristram Ha
>
> Prepare PHY for proper advertisement and get link status for the port.
>
> Signed-off-by: Tristram Ha
> Reviewed-by: Woojung Huh
> ---
> drivers/net/dsa/microchip/ksz9477.c| 12
On 05/12/2018 15:32, Jiong Wang wrote:
On 05/12/2018 14:52, Edward Cree wrote:
On 05/12/18 09:46, Jiong Wang wrote:
There is NO processed instruction number regression, either with or
without
-mattr=+alu32.
Cilium bpf
===
bpf_lb-DLB_L3.o 2110/2110 1730/1733
That looks like a
FWIW, I find the patch really useful - I applied it to my local dev
repo (with minor changes) and use skb_dump() a lot now. It would be
great if it makes its way into net-next in some form.
On Fri, Nov 30, 2018 at 12:15 PM Saeed Mahameed wrote:
>
> On Thu, 2018-11-22 at 17:45 -0800, Cong Wang
On Wed, Dec 5, 2018 at 7:57 AM Jiri Wiesner wrote:
>
> The *_frag_reasm() functions are susceptible to miscalculating the byte
> count of packet fragments in case the truesize of a head buffer changes.
> The truesize member may be changed by the call to skb_unclone(), leaving
> the fragment
On Wed, Dec 05, 2018 at 10:28:24AM +, Quentin Monnet wrote:
> BPF programs can use the bpf_trace_printk() helper to print debug
> information into the trace pipe. Add a subcommand
> "bpftool prog tracelog" to simply dump this pipe to the console.
>
> This is for a good part copied from
On 05/12 15:57, Benjamin Poirier wrote:
> On 2018/12/04 11:52, Nicolas Belouin wrote:
> > On 03/12 07:59, Eric Dumazet wrote:
> > >
> > >
> > > On 12/03/2018 07:20 AM, Nicolas Belouin wrote:
> > > > Hi,
> > > > I ran into a panic while adding an interface to a bridge with a vxlan
> > > >
On Mon, 26 Nov 2018 16:27:28 +
Ioana Ciocoi Radulescu wrote:
> Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX
> actions are supported for now. Frame header changes are also
> allowed.
Do you have any XDP performance benchmarks on this hardware?
Also what boards (and
On 12/05/2018 11:28 AM, Quentin Monnet wrote:
> BPF programs can use the bpf_trace_printk() helper to print debug
> information into the trace pipe. Add a subcommand
> "bpftool prog tracelog" to simply dump this pipe to the console.
>
> This is for a good part copied from iproute2, where the
On 05/12/2018 14:52, Edward Cree wrote:
On 05/12/18 09:46, Jiong Wang wrote:
There is NO processed instruction number regression, either with or without
-mattr=+alu32.
Cilium bpf
===
bpf_lb-DLB_L3.o 2110/21101730/1733
That looks like a regression of 3 insns in the 32-bit case.
On Wed, Dec 5, 2018 at 5:00 AM Russell King - ARM Linux
wrote:
>
> On Mon, Dec 03, 2018 at 05:54:55PM -0600, Rob Herring wrote:
> > On Mon, Nov 12, 2018 at 12:31:02PM +, Russell King wrote:
> > > Signed-off-by: Russell King
> >
> > Needs a better subject and a commit msg.
>
> Hmm, not sure
On 05/12/18 09:46, Jiong Wang wrote:
> There is NO processed instruction number regression, either with or without
> -mattr=+alu32.
> Cilium bpf
> ===
> bpf_lb-DLB_L3.o 2110/21101730/1733
That looks like a regression of 3 insns in the 32-bit case.
May be worth investigating why.
> +
On 5.12.2018 14:37, claudiu.bez...@microchip.com wrote:
>
> On 30.11.2018 20:21, Anssi Hannula wrote:
>> When reading buffer descriptors on RX or on TX completion, an
>> RX_USED/TX_USED bit is checked first to ensure that the descriptor has
>> been populated. However, there are no memory barriers
On 5.12.2018 14:37, claudiu.bez...@microchip.com wrote:
> Hi Anssi,
Hi, and thanks for looking at these.
> Few comments... Otherwise I tested this series on a SAMA5D2 Xplained and
> SAMA5D4 Xplained under heavy traffic and it seems to behave OK.
>
> Thank you,
> Claudiu Beznea
>
> On 30.11.2018
On Wed, Dec 05, 2018 at 02:10:37PM +0100, Pablo Neira Ayuso wrote:
> On Thu, Nov 29, 2018 at 02:12:14PM +0100, Michal Kubecek wrote:
> > On Thu, Nov 29, 2018 at 03:22:28AM +0100, Pablo Neira Ayuso wrote:
> > ...
> > > + act = >rule->action.entries[0];
> > > + switch (fs->ring_cookie) {
> > > +
On Wed, Dec 5, 2018 at 5:50 AM David Miller wrote:
>
> From: Jouke Witteveen
> Date: Sat, 1 Dec 2018 17:00:21 +0100
>
> > Make it easy for userspace to respond to acquisition/loss of carrier.
> > The uevent is picked up by udev and, on systems with systemd, the
> > device unit of the interface
Wed, Dec 05, 2018 at 06:57:00AM CET, vasundhara-v.vo...@broadcom.com wrote:
>Register devlink_port with devlink and create initial port params
>table for bnxt_en. The table consists of a generic parameter:
>
>wake-on-lan: Enables Wake on Lan for this port when magic packet
>is received with this
Wed, Dec 05, 2018 at 06:56:59AM CET, vasundhara-v.vo...@broadcom.com wrote:
>wake-on-lan - Enables Wake on Lan for this port when magic packet
>is received with this port's MAC address using ACPI pattern.
>If enabled, the controller asserts a wake pin upon reception of
>WoL packet. ACPI (Advanced
Wed, Dec 05, 2018 at 06:56:58AM CET, vasundhara-v.vo...@broadcom.com wrote:
>Add notification call for devlink port param set, register and unregister
>functions.
>Add devlink_port_param_value_changed() function to enable the driver notify
>devlink on value change. Driver should use this function
Wed, Dec 05, 2018 at 06:56:57AM CET, vasundhara-v.vo...@broadcom.com wrote:
>Add support for "driverinit" configuration mode value for devlink_port
>configuration parameters. Two additional functions added to help the
>driver get/set the value from/to devlink:
On 30.11.2018 20:21, Anssi Hannula wrote:
> Bit RX_USED set to 0 in the address field allows the controller to write
> data to the receive buffer descriptor.
>
> The driver does not ensure the ctrl field is ready (cleared) when the
> controller sees the RX_USED=0 written by the driver. The ctrl
On 30.11.2018 20:21, Anssi Hannula wrote:
> When reading buffer descriptors on RX or on TX completion, an
> RX_USED/TX_USED bit is checked first to ensure that the descriptor has
> been populated. However, there are no memory barriers to ensure that the
> data protected by the RX_USED/TX_USED
Hi Anssi,
Few comments... Otherwise I tested this series on a SAMA5D2 Xplained and
SAMA5D4 Xplained under heavy traffic and it seems to behave OK.
Thank you,
Claudiu Beznea
On 30.11.2018 20:21, Anssi Hannula wrote:
> 64-bit DMA addresses are split in upper and lower halves that are
> written in
On Wed, Dec 05, 2018 at 02:49:39PM +0800, Xin Long wrote:
> Without the support for the total_nr_elements's growing or shrinking
> dynamically, flex_array is not that 'flexible'. Like when users want
> to change the size, they have to redo flex_array_alloc and copy all
> the elements from the old
Wed, Dec 05, 2018 at 06:56:56AM CET, vasundhara-v.vo...@broadcom.com wrote:
>Add port param set command to set the value for a parameter.
>Value can be set to any of the supported configuration modes.
>
>Cc: Jiri Pirko
>Signed-off-by: Vasundhara Volam
>---
> include/uapi/linux/devlink.h | 1 +
>
Wed, Dec 05, 2018 at 06:56:55AM CET, vasundhara-v.vo...@broadcom.com wrote:
>Add port param get command which gets data per parameter.
>It also has option to dump the parameters data per port.
>
>Cc: Jiri Pirko
>Signed-off-by: Vasundhara Volam
>---
> include/uapi/linux/devlink.h | 2 +
>
Wed, Dec 05, 2018 at 06:56:54AM CET, vasundhara-v.vo...@broadcom.com wrote:
>Add functions to register and unregister for the driver supported
>configuration parameters table per port.
>
>Cc: Jiri Pirko
>Signed-off-by: Vasundhara Volam
>---
> include/net/devlink.h | 29 +++
>
Sandipan Das writes:
> Hi Jiong,
>
> On 05/12/18 2:25 AM, Jiong Wang wrote:
>> This patch implements code-gen for BPF_ALU | BPF_ARSH | BPF_*.
>>
>> Cc: Naveen N. Rao
>> Cc: Sandipan Das
>> Signed-off-by: Jiong Wang
>> ---
> [...]
>> diff --git a/arch/powerpc/net/bpf_jit_comp64.c
>>
On 05/12/2018 00:02, Paul Burton wrote:
Hi Jiong,
On Tue, Dec 04, 2018 at 03:55:16PM -0500, Jiong Wang wrote:
Jitting of BPF_K is supported already, but not BPF_X. This patch complete
the support for the latter on both MIPS and microMIPS.
Cc: Paul Burton
Cc: linux-m...@vger.kernel.org
On Mon, Dec 03, 2018 at 05:54:55PM -0600, Rob Herring wrote:
> On Mon, Nov 12, 2018 at 12:31:02PM +, Russell King wrote:
> > Signed-off-by: Russell King
>
> Needs a better subject and a commit msg.
Hmm, not sure why it didn't contain:
"dt-bindings: net: mvneta: add phys property
Add an
On Tue, Dec 04, 2018 at 06:03:02PM -0800, Saeed Mahameed wrote:
> From: Tariq Toukan
>
> Use the new helper that extracts the opcode
> from a CQE (completion queue entry) structure.
>
> Signed-off-by: Tariq Toukan
> Signed-off-by: Saeed Mahameed
> ---
> drivers/infiniband/hw/mlx5/cq.c | 8
On 2018/12/04 11:52, Nicolas Belouin wrote:
> On 03/12 07:59, Eric Dumazet wrote:
> >
> >
> > On 12/03/2018 07:20 AM, Nicolas Belouin wrote:
> > > Hi,
> > > I ran into a panic while adding an interface to a bridge with a vxlan
> > > interface already attached to it, as it seems related mtu=9000.
Hi Jiong,
On 05/12/18 2:25 AM, Jiong Wang wrote:
> This patch implements code-gen for BPF_ALU | BPF_ARSH | BPF_*.
>
> Cc: Naveen N. Rao
> Cc: Sandipan Das
> Signed-off-by: Jiong Wang
> ---
[...]
> diff --git a/arch/powerpc/net/bpf_jit_comp64.c
> b/arch/powerpc/net/bpf_jit_comp64.c
> index
On Sun, Dec 2, 2018 at 4:37 AM Tariq Toukan wrote:
>
> From: Saeed Mahameed
>
> MLX4_EN depends on NETDEVICES, ETHERNET and INET Kconfigs.
> Make sure they are listed in MLX4_EN Kconfig dependencies.
>
> This fixes the following build break:
>
> drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18:
On Tue, Dec 4, 2018 at 9:06 AM Eric Dumazet wrote:
>
>
>
> On 12/04/2018 08:59 AM, David Laight wrote:
> > Where does 68 come from?
>
> Min IPv4 MTU per RFC791
>
What's wrong with using IPV4_MIN_MTU instead of 68
even in just comment?
201 - 300 of 145660 matches
Mail list logo
