Re: Zero checksum in netconsole/netdump packets

2006-11-07 Thread David Miller
From: Chris Lalancette <[EMAIL PROTECTED]> Date: Tue, 07 Nov 2006 08:33:00 -0500 > David Miller wrote: > > From: Chris Lalancette <[EMAIL PROTECTED]> > > Date: Mon, 06 Nov 2006 18:40:59 -0500 > > > >> Assuming that this is just an oversight, attached is a simple > >> patch to compute th

Re: Zero checksum in netconsole/netdump packets

2006-11-07 Thread Chris Lalancette
David Miller wrote: From: Chris Lalancette <[EMAIL PROTECTED]> Date: Mon, 06 Nov 2006 18:40:59 -0500 Assuming that this is just an oversight, attached is a simple patch to compute the UDP checksum in netpoll_send_udp. If the resulting checksum is zero, you should set it to all 1's,

Re: Zero checksum in netconsole/netdump packets

2006-11-07 Thread Krzysztof Oledzki
On Tue, 7 Nov 2006, Gerrit Renker wrote: Quoting Chris Lalancette: | Hello, | I realized that all of the packets that go from the crashing machine to the netdump server have a zero checksum. | Assuming that this is just an oversight, attached is a simple patch to compute the UD

Re: Zero checksum in netconsole/netdump packets

2006-11-07 Thread Gerrit Renker
Quoting Chris Lalancette: | Hello, | I realized that all of the packets that go from the crashing machine to the netdump server have a zero checksum. | Assuming that this is just an oversight, attached is a simple patch to compute the UDP checksum in netpoll_send_udp. | | Signed

Re: Zero checksum in netconsole/netdump packets

2006-11-06 Thread David Miller
From: Chris Lalancette <[EMAIL PROTECTED]> Date: Mon, 06 Nov 2006 18:40:59 -0500 > Assuming that this is just an oversight, attached is a simple > patch to compute the UDP checksum in netpoll_send_udp. If the resulting checksum is zero, you should set it to all 1's, like the real UDP co

Zero checksum in netconsole/netdump packets

2006-11-06 Thread Chris Lalancette
Hello, I was reading some tcpdump's of netdump traffic today, and I realized that all of the packets that go from the crashing machine to the netdump server have a zero checksum. Looking at the code, it looks like netconsole/netdump use the function netpoll_send_udp to send out the packet